[GitHub] [pulsar] michaeljmarshall commented on pull request #9948: Cleanup PrometheusMetricsTest

2021-03-17 Thread GitBox
michaeljmarshall commented on pull request #9948: URL: https://github.com/apache/pulsar/pull/9948#issuecomment-801675884 @aahmed-se - can you explain why clearing the metric resolves the flakiness? Is it already initialized because of concurrent tests or tests that have already run in the

[GitHub] [pulsar] zymap commented on pull request #9834: Add pulsar 2.7.1 release note

2021-03-17 Thread GitBox
zymap commented on pull request #9834: URL: https://github.com/apache/pulsar/pull/9834#issuecomment-801673074 @Jennifer88huang @Anonymitaet PTAL. Thanks This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] xuesongxs closed issue #9952: The consumer subscribes to a topic and has no output on the log

2021-03-17 Thread GitBox
xuesongxs closed issue #9952: URL: https://github.com/apache/pulsar/issues/9952 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] xuesongxs opened a new issue #9953: The consumer subscribes to a topic and has no output on the log

2021-03-17 Thread GitBox
xuesongxs opened a new issue #9953: URL: https://github.com/apache/pulsar/issues/9953 **Describe the bug** ![image](https://user-images.githubusercontent.com/54351417/111580467-88175d00-87f2-11eb-93b4-fa145f3306bc.png) topicName: persistent://public/default/test-string5 Whe

[GitHub] [pulsar] yitian108 edited a comment on issue #9796: Segment fault occur while test the example of asyn producer using c++

2021-03-17 Thread GitBox
yitian108 edited a comment on issue #9796: URL: https://github.com/apache/pulsar/issues/9796#issuecomment-801670462 [pulsarTest.tar.gz](https://github.com/apache/pulsar/files/6161780/pulsarTest.tar.gz) hi, I upload the test project which built with gcc 4.8.5, BTW, I update the versi

[GitHub] [pulsar] yitian108 commented on issue #9796: Segment fault occur while test the example of asyn producer using c++

2021-03-17 Thread GitBox
yitian108 commented on issue #9796: URL: https://github.com/apache/pulsar/issues/9796#issuecomment-801670462 [pulsarTest.tar.gz](https://github.com/apache/pulsar/files/6161780/pulsarTest.tar.gz) hi, I upload the test project which built with gcc 4.8.5 --

[GitHub] [pulsar] xuesongxs opened a new issue #9952: The consumer subscribes to a topic and has no output on the log

2021-03-17 Thread GitBox
xuesongxs opened a new issue #9952: URL: https://github.com/apache/pulsar/issues/9952 **Describe the bug** ![image](https://user-images.githubusercontent.com/54351417/111580467-88175d00-87f2-11eb-93b4-fa145f3306bc.png) topicName: persistent://public/default/test-string5 Whe

[GitHub] [pulsar] BewareMyPower commented on issue #9922: Create c++ producer/consumer with protobuf schema

2021-03-17 Thread GitBox
BewareMyPower commented on issue #9922: URL: https://github.com/apache/pulsar/issues/9922#issuecomment-801669922 Currently `AVRO`, `JSON` and `PROTOBUF` (not `PROTOBUF_NATIVE`) share the same schema validator. See https://github.com/apache/pulsar/blob/7d3317e290ca34918e10379b6592e28678cde9

[GitHub] [pulsar] sijie commented on pull request #9895: Implement Schema#OBJECT - support for Consumer

2021-03-17 Thread GitBox
sijie commented on pull request #9895: URL: https://github.com/apache/pulsar/pull/9895#issuecomment-801664166 The concerns will still be around AUTO_SCHEMA vs OBJECT. It will cause confusion. IMO, we should just have one schema type that is used to automatically get the "object" based on t

[GitHub] [pulsar] Huanli-Meng opened a new pull request #9951: [Doc] Support DLQ in key_shared subscription mode

2021-03-17 Thread GitBox
Huanli-Meng opened a new pull request #9951: URL: https://github.com/apache/pulsar/pull/9951 ### Motivation According to this [PR](https://github.com/apache/pulsar/pull/9678), the DLQ is supported in the key_shared sub. Therefore, update the docs accordingly. ### Modificat

[GitHub] [pulsar] eolivelli commented on pull request #9895: Implement Schema#OBJECT - support for Consumer

2021-03-17 Thread GitBox
eolivelli commented on pull request #9895: URL: https://github.com/apache/pulsar/pull/9895#issuecomment-801656118 @sijie did you see the latest version of this patch here? I have refactored the initial patch, now there is no code duplication and we have AbstractAutoConsumeSchema inst

[GitHub] [pulsar] jiazhai commented on pull request #9924: 9923-zookeeper-sslQuorum

2021-03-17 Thread GitBox
jiazhai commented on pull request #9924: URL: https://github.com/apache/pulsar/pull/9924#issuecomment-801642189 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [pulsar] softwareace opened a new issue #9950: client-cpp checksum failure on big endian

2021-03-17 Thread GitBox
softwareace opened a new issue #9950: URL: https://github.com/apache/pulsar/issues/9950 Direct quote from the code in crc32c_sw /* Table-driven software version as a fall-back. This is about 15 times slower than using the hardware instructions. This assumes little-endian integers,

[GitHub] [pulsar] zymap commented on a change in pull request #9834: Add pulsar 2.7.1 release note

2021-03-17 Thread GitBox
zymap commented on a change in pull request #9834: URL: https://github.com/apache/pulsar/pull/9834#discussion_r596563144 ## File path: site2/website/release-notes.md ## @@ -1,6 +1,181 @@ ## Apache Pulsar Release Notes +### 2.7.1 — 2020-11-25 Review comment: ```sug

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #9834: Add pulsar 2.7.1 release note

2021-03-17 Thread GitBox
Anonymitaet commented on a change in pull request #9834: URL: https://github.com/apache/pulsar/pull/9834#discussion_r596553790 ## File path: site2/website/release-notes.md ## @@ -1,6 +1,181 @@ ## Apache Pulsar Release Notes +### 2.7.1 — 2020-11-25 + + Broker + +- Fix

[GitHub] [pulsar] michaeljmarshall commented on pull request #9878: [Tiered Storage] Prevent Class Loader Leak; Restore Offloader Directory Override

2021-03-17 Thread GitBox
michaeljmarshall commented on pull request #9878: URL: https://github.com/apache/pulsar/pull/9878#issuecomment-801621751 Had merge conflicts. Fixed with a rebase. This is an automated message from the Apache Git Service. To r

[GitHub] [pulsar] michaeljmarshall commented on issue #3804: ManagedLedger should streamline the read requests

2021-03-17 Thread GitBox
michaeljmarshall commented on issue #3804: URL: https://github.com/apache/pulsar/issues/3804#issuecomment-801619369 @MarvinCai, @sijie, @eolivelli - It looks like the feature to improve read throughput for blob storage is still outstanding. I'm very interested in helping to contribute this

[GitHub] [pulsar] codelipenghui commented on pull request #9886: [WebSocket Client] Make the browser client support the token authentication

2021-03-17 Thread GitBox
codelipenghui commented on pull request #9886: URL: https://github.com/apache/pulsar/pull/9886#issuecomment-801610142 ok This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [pulsar] codelipenghui commented on issue #9922: Create c++ producer/consumer with protobuf schema

2021-03-17 Thread GitBox
codelipenghui commented on issue #9922: URL: https://github.com/apache/pulsar/issues/9922#issuecomment-801609830 @BewareMyPower Could you please help take a look at this issue? This is an automated message from the Apache Git

[GitHub] [pulsar] devinbost commented on issue #6054: Catastrophic frequent random topic freezes, especially on high-traffic topics.

2021-03-17 Thread GitBox
devinbost commented on issue #6054: URL: https://github.com/apache/pulsar/issues/6054#issuecomment-801609488 After taking a closer look at #7266, it's not clear if it will resolve the issue because we're seeing this issue with functions running with exclusive subscriptions, not shared subs

[GitHub] [pulsar] dlg99 commented on a change in pull request #9947: add partitionNumber() to the Record<>

2021-03-17 Thread GitBox
dlg99 commented on a change in pull request #9947: URL: https://github.com/apache/pulsar/pull/9947#discussion_r596539615 ## File path: pulsar-functions/api-java/src/main/java/org/apache/pulsar/functions/api/Record.java ## @@ -77,6 +77,15 @@ return Optional.empty();

[GitHub] [pulsar] sijie commented on pull request #9895: Implement Schema#OBJECT - support for Consumer

2021-03-17 Thread GitBox
sijie commented on pull request #9895: URL: https://github.com/apache/pulsar/pull/9895#issuecomment-801606979 `getField` will return an empty list. `schemaType` gives the schema type. `GenericRecord` is just a container to hold either a primitive value or a struct. My main point here is to

[GitHub] [pulsar] sijie commented on a change in pull request #9947: add partitionNumber() to the Record<>

2021-03-17 Thread GitBox
sijie commented on a change in pull request #9947: URL: https://github.com/apache/pulsar/pull/9947#discussion_r596538029 ## File path: pulsar-functions/api-java/src/main/java/org/apache/pulsar/functions/api/Record.java ## @@ -77,6 +77,15 @@ return Optional.empty();

[pulsar] branch master updated (3bb9c54 -> 7d3317e)

2021-03-17 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 3bb9c54 [Doc] Add guides for TLS SNI support (cpp and python clients) (#9937) add 7d3317e [CI] Fix Transaction

[GitHub] [pulsar] freeznet commented on pull request #9945: Revert "[fix #9851] Add forwardSourceMessageProperty to SourceConfig …

2021-03-17 Thread GitBox
freeznet commented on pull request #9945: URL: https://github.com/apache/pulsar/pull/9945#issuecomment-801605722 @jerrypeng Thanks for bring this here, and I get your point. I would also like to express my opinion here. The added knob is more concern from user's perspective, like if

[pulsar] branch prometheusMtest updated (d822255 -> 8e34089)

2021-03-17 Thread aahmed
This is an automated email from the ASF dual-hosted git repository. aahmed pushed a change to branch prometheusMtest in repository https://gitbox.apache.org/repos/asf/pulsar.git. discard d822255 Cleanup up PromethuesMetricsTest add 8e34089 Cleanup up PromethuesMetricsTest This update ad

[GitHub] [pulsar] aahmed-se commented on a change in pull request #9948: Cleanup PrometheusMetricsTest

2021-03-17 Thread GitBox
aahmed-se commented on a change in pull request #9948: URL: https://github.com/apache/pulsar/pull/9948#discussion_r596537933 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java ## @@ -99,7 +100,8 @@ @

[GitHub] [pulsar] sijie merged pull request #9934: [CI] Fix Transaction flaky test.

2021-03-17 Thread GitBox
sijie merged pull request #9934: URL: https://github.com/apache/pulsar/pull/9934 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] jiazhai commented on pull request #9924: 9923-zookeeper-sslQuorum

2021-03-17 Thread GitBox
jiazhai commented on pull request #9924: URL: https://github.com/apache/pulsar/pull/9924#issuecomment-801605324 rebase the branch with the latest master would help on the CI This is an automated message from the Apache Git Se

[pulsar] branch master updated (f49d094 -> 3bb9c54)

2021-03-17 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from f49d094 [Doc] Add guides for producer access mode (#9938) add 3bb9c54 [Doc] Add guides for TLS SNI support (cpp

[GitHub] [pulsar] sijie merged pull request #9937: [Doc] Add guides for TLS SNI support (C++ and Python clients)

2021-03-17 Thread GitBox
sijie merged pull request #9937: URL: https://github.com/apache/pulsar/pull/9937 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] BewareMyPower commented on issue #9796: Segment fault occur while test the example of asyn producer using c++

2021-03-17 Thread GitBox
BewareMyPower commented on issue #9796: URL: https://github.com/apache/pulsar/issues/9796#issuecomment-801603008 Can you upload your library (built with GCC 4.8.5)? Then I could try it in my CentOS 7 environment. BTW, I assume your library links dependencies dynamically. > Attach fi

[GitHub] [pulsar] aahmed-se commented on a change in pull request #9948: Cleanup PrometheusMetricsTest

2021-03-17 Thread GitBox
aahmed-se commented on a change in pull request #9948: URL: https://github.com/apache/pulsar/pull/9948#discussion_r596536194 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java ## @@ -99,7 +100,8 @@ @

[GitHub] [pulsar] sakurafly123 commented on a change in pull request #9910: [Pulsar-sql]Using pulsar SQL query messages will appear `NoSuchLedger…

2021-03-17 Thread GitBox
sakurafly123 commented on a change in pull request #9910: URL: https://github.com/apache/pulsar/pull/9910#discussion_r596533833 ## File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarConnectorCache.java ## @@ -112,7 +112,7 @@ private static Man

[GitHub] [pulsar] sakurafly123 commented on a change in pull request #9910: [Pulsar-sql]Using pulsar SQL query messages will appear `NoSuchLedger…

2021-03-17 Thread GitBox
sakurafly123 commented on a change in pull request #9910: URL: https://github.com/apache/pulsar/pull/9910#discussion_r596531770 ## File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarConnectorCache.java ## @@ -112,7 +112,7 @@ private static Man

[GitHub] [pulsar] Anonymitaet commented on pull request #9903: [docs] Add description about enable-subscription-types

2021-03-17 Thread GitBox
Anonymitaet commented on pull request #9903: URL: https://github.com/apache/pulsar/pull/9903#issuecomment-801597264 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [pulsar] merlimat commented on a change in pull request #9948: Cleanup PrometheusMetricsTest

2021-03-17 Thread GitBox
merlimat commented on a change in pull request #9948: URL: https://github.com/apache/pulsar/pull/9948#discussion_r596526863 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java ## @@ -99,7 +100,8 @@ @O

[GitHub] [pulsar] yitian108 commented on issue #9796: Segment fault occur while test the example of asyn producer using c++

2021-03-17 Thread GitBox
yitian108 commented on issue #9796: URL: https://github.com/apache/pulsar/issues/9796#issuecomment-801581957 First, I am sorry for the confusion, my bad, actually, I just used the api setMaxPendingMessages(10) Second, I list my enviornment for your reference: - CentOS 7.6

[pulsar-client-node] annotated tag v1.3.0 updated (c8f3943 -> b3dac9e)

2021-03-17 Thread massakam
This is an automated email from the ASF dual-hosted git repository. massakam pushed a change to annotated tag v1.3.0 in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git. *** WARNING: tag v1.3.0 was modified! *** from c8f3943 (commit) to b3dac9e (tag) tagging c8

[pulsar-client-node] branch branch-1.3 updated: 1.3.0

2021-03-17 Thread massakam
This is an automated email from the ASF dual-hosted git repository. massakam pushed a commit to branch branch-1.3 in repository https://gitbox.apache.org/repos/asf/pulsar-client-node.git The following commit(s) were added to refs/heads/branch-1.3 by this push: new c8f3943 1.3.0 c8f3943 is

[pulsar] branch master updated: [Doc] Add guides for producer access mode (#9938)

2021-03-17 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new f49d094 [Doc] Add guides for producer access m

[GitHub] [pulsar] codelipenghui merged pull request #9938: [Doc] Add guides for producer access mode

2021-03-17 Thread GitBox
codelipenghui merged pull request #9938: URL: https://github.com/apache/pulsar/pull/9938 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] Anonymitaet commented on pull request #9938: [Doc] Add guides for producer access mode

2021-03-17 Thread GitBox
Anonymitaet commented on pull request #9938: URL: https://github.com/apache/pulsar/pull/9938#issuecomment-801565135 @zymap many thanks for your instructions. I've updated, PTAL. This is an automated message from the Apache Gi

[pulsar] branch master updated (dedd882 -> fc5768c)

2021-03-17 Thread yong
This is an automated email from the ASF dual-hosted git repository. yong pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from dedd882 [Documentation] Fix reference configuration table formatting (#9941) add fc5768c [Website] Update relea

[GitHub] [pulsar] zymap merged pull request #9949: [Website] Update release.json in website

2021-03-17 Thread GitBox
zymap merged pull request #9949: URL: https://github.com/apache/pulsar/pull/9949 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #9834: Add pulsar 2.7.1 release note

2021-03-17 Thread GitBox
Jennifer88huang commented on a change in pull request #9834: URL: https://github.com/apache/pulsar/pull/9834#discussion_r596483485 ## File path: site2/website/release-notes.md ## @@ -1,6 +1,181 @@ ## Apache Pulsar Release Notes +### 2.7.1 — 2020-11-25 + + Broker + +-

[GitHub] [pulsar] Jennifer88huang commented on pull request #9941: [Documentation] Fix reference configuration table formatting

2021-03-17 Thread GitBox
Jennifer88huang commented on pull request #9941: URL: https://github.com/apache/pulsar/pull/9941#issuecomment-801539240 @michaeljmarshall @eolivelli those configuration info comes from different conf files. I was wondering whether we could generate the configuration reference from those co

[pulsar] branch master updated (c4aaf41 -> dedd882)

2021-03-17 Thread hjf
This is an automated email from the ASF dual-hosted git repository. hjf pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from c4aaf41 Add TestNG groups to pulsar-broker (#9712) add dedd882 [Documentation] Fix reference configuration table

[GitHub] [pulsar] Jennifer88huang merged pull request #9941: [Documentation] Fix reference configuration table formatting

2021-03-17 Thread GitBox
Jennifer88huang merged pull request #9941: URL: https://github.com/apache/pulsar/pull/9941 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] zymap opened a new pull request #9949: [Website] Update release.json in website

2021-03-17 Thread GitBox
zymap opened a new pull request #9949: URL: https://github.com/apache/pulsar/pull/9949 --- *Motivation* Update release.json file to add the 2.7.1 release. This is an automated message from the Apache Git Ser

[GitHub] [pulsar] zymap commented on pull request #9834: Add pulsar 2.7.1 release note

2021-03-17 Thread GitBox
zymap commented on pull request #9834: URL: https://github.com/apache/pulsar/pull/9834#issuecomment-801532773 @Anonymitaet @Huanli-Meng @Jennifer88huang Please take a look when you have time. Thanks This is an automated mess

[GitHub] [pulsar] aahmed-se commented on a change in pull request #9948: Prometheus mtest

2021-03-17 Thread GitBox
aahmed-se commented on a change in pull request #9948: URL: https://github.com/apache/pulsar/pull/9948#discussion_r596473985 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java ## @@ -99,7 +100,8 @@ @

[GitHub] [pulsar] merlimat commented on a change in pull request #9948: Prometheus mtest

2021-03-17 Thread GitBox
merlimat commented on a change in pull request #9948: URL: https://github.com/apache/pulsar/pull/9948#discussion_r596473130 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java ## @@ -99,7 +100,8 @@ @O

[GitHub] [pulsar] jerrypeng commented on issue #6054: Catastrophic frequent random topic freezes, especially on high-traffic topics.

2021-03-17 Thread GitBox
jerrypeng commented on issue #6054: URL: https://github.com/apache/pulsar/issues/6054#issuecomment-801529366 > Do they batch by default? Yes, batching at the pulsar client level is enabled when a Pulsar function is writing messages to the "output" topic. ---

[GitHub] [pulsar] zymap commented on a change in pull request #9938: [Doc] Add guides for producer access mode

2021-03-17 Thread GitBox
zymap commented on a change in pull request #9938: URL: https://github.com/apache/pulsar/pull/9938#discussion_r596472637 ## File path: site2/docs/concepts-messaging.md ## @@ -53,6 +53,25 @@ Producers send messages to brokers synchronously (sync) or asynchronously (async | Syn

[pulsar] branch prometheusMtest updated (c56f50f -> d822255)

2021-03-17 Thread aahmed
This is an automated email from the ASF dual-hosted git repository. aahmed pushed a change to branch prometheusMtest in repository https://gitbox.apache.org/repos/asf/pulsar.git. discard c56f50f Cleanup up PromethuesMetricsTest omit ab8384a Add TestNG groups to pulsar-broker add c4aa

[GitHub] [pulsar] aahmed-se opened a new pull request #9948: Prometheus mtest

2021-03-17 Thread GitBox
aahmed-se opened a new pull request #9948: URL: https://github.com/apache/pulsar/pull/9948 ### Motivation * PrometheusMetricsTest is one of the flaky tests, that needs additional investigation. ### Modifications * Clear static metrics to harden tests. * Remove unnece

[pulsar] branch prometheusMtest created (now c56f50f)

2021-03-17 Thread aahmed
This is an automated email from the ASF dual-hosted git repository. aahmed pushed a change to branch prometheusMtest in repository https://gitbox.apache.org/repos/asf/pulsar.git. at c56f50f Cleanup up PromethuesMetricsTest This branch includes the following new commits: new c56f50f

[pulsar] 01/01: Cleanup up PromethuesMetricsTest

2021-03-17 Thread aahmed
This is an automated email from the ASF dual-hosted git repository. aahmed pushed a commit to branch prometheusMtest in repository https://gitbox.apache.org/repos/asf/pulsar.git commit c56f50fbe2dd514ea545882fc19064b5f8fcf2a7 Author: Ali Ahmed AuthorDate: Wed Mar 17 17:27:10 2021 -0700 Clea

[pulsar] branch master updated (94bf13f -> c4aaf41)

2021-03-17 Thread aahmed
This is an automated email from the ASF dual-hosted git repository. aahmed pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 94bf13f [Documentation] Fix ThresholdShedder Typo (#9933) add c4aaf41 Add TestNG groups to pulsar-broker (#971

[GitHub] [pulsar] aahmed-se merged pull request #9712: Add TestNG groups to pulsar-broker

2021-03-17 Thread GitBox
aahmed-se merged pull request #9712: URL: https://github.com/apache/pulsar/pull/9712 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] devinbost commented on issue #6054: Catastrophic frequent random topic freezes, especially on high-traffic topics.

2021-03-17 Thread GitBox
devinbost commented on issue #6054: URL: https://github.com/apache/pulsar/issues/6054#issuecomment-801518480 **I found a huge clue on this issue** (in Pulsar 2.6.3). Several hours after we collected those stats, I got a heap dump on the function that was consuming from the dead topic, an

[GitHub] [pulsar] jerrypeng commented on pull request #9945: Revert "[fix #9851] Add forwardSourceMessageProperty to SourceConfig …

2021-03-17 Thread GitBox
jerrypeng commented on pull request #9945: URL: https://github.com/apache/pulsar/pull/9945#issuecomment-801501295 I do think the tests written as part of https://github.com/apache/pulsar/pull/9907/files we should still keep. ---

[GitHub] [pulsar] jerrypeng commented on pull request #9945: Revert "[fix #9851] Add forwardSourceMessageProperty to SourceConfig …

2021-03-17 Thread GitBox
jerrypeng commented on pull request #9945: URL: https://github.com/apache/pulsar/pull/9945#issuecomment-801496669 cc @david-streamlio @freeznet This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [pulsar] dlg99 commented on a change in pull request #9927: Add ability to use Kafka's sinks as pulsar sinks

2021-03-17 Thread GitBox
dlg99 commented on a change in pull request #9927: URL: https://github.com/apache/pulsar/pull/9927#discussion_r596433829 ## File path: pulsar-io/kafka-connect-adaptor/src/main/java/org/apache/pulsar/io/kafka/connect/KafkaConnectSink.java ## @@ -0,0 +1,277 @@ +/** + * Licensed

[GitHub] [pulsar] dlg99 opened a new pull request #9947: add partitionNumber() to the Record<>

2021-03-17 Thread GitBox
dlg99 opened a new pull request #9947: URL: https://github.com/apache/pulsar/pull/9947 ### Motivation Looking at https://github.com/apache/pulsar/pull/9927#discussion_r595714308 there is no way to reliably get partition number. There is Optional getPartitionId() which retu

[GitHub] [pulsar] csthomas1 opened a new issue #9946: Deleting a Pulsar Function with a name that includes a colon character crashes the pulsar broker

2021-03-17 Thread GitBox
csthomas1 opened a new issue #9946: URL: https://github.com/apache/pulsar/issues/9946 **Describe the bug** I'm able to successfully deploy in Pulsar a Pulsar function that includes a ':' as part of its function name. When I later try to delete the function deployment, the Pulsar broker

[GitHub] [pulsar] jerrypeng commented on pull request #9945: Revert "[fix #9851] Add forwardSourceMessageProperty to SourceConfig …

2021-03-17 Thread GitBox
jerrypeng commented on pull request #9945: URL: https://github.com/apache/pulsar/pull/9945#issuecomment-801473251 The correct solution should just be https://github.com/apache/pulsar/pull/9943/files This is an automate

[GitHub] [pulsar] jerrypeng opened a new pull request #9945: Revert "[fix #9851] Add forwardSourceMessageProperty to SourceConfig …

2021-03-17 Thread GitBox
jerrypeng opened a new pull request #9945: URL: https://github.com/apache/pulsar/pull/9945 …(#9907)" This reverts commit d0249e5695c75d8d65a4180fd599b17971368f33. ### Motivation We don't need to add additional configuration for message properties to be set for Pulsa

[GitHub] [pulsar] jerrypeng commented on pull request #9907: [fix #9851] Add forwardSourceMessageProperty to SourceConfig

2021-03-17 Thread GitBox
jerrypeng commented on pull request #9907: URL: https://github.com/apache/pulsar/pull/9907#issuecomment-801468702 Why do we need to add a flag for the source? If the `getProperties()` of the Record interface returns a value, it should just automatically be set as a message property. What

[GitHub] [pulsar] david-streamlio commented on a change in pull request #9943: [Issue-9926][Pulsar Functions] Pass through record properties from Pulsar Sources

2021-03-17 Thread GitBox
david-streamlio commented on a change in pull request #9943: URL: https://github.com/apache/pulsar/pull/9943#discussion_r596341448 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java ## @@ -736,8 +737,14 @@ priva

[GitHub] [pulsar] david-streamlio commented on a change in pull request #9943: [Issue-9926][Pulsar Functions] Pass through record properties from Pulsar Sources

2021-03-17 Thread GitBox
david-streamlio commented on a change in pull request #9943: URL: https://github.com/apache/pulsar/pull/9943#discussion_r596341448 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java ## @@ -736,8 +737,14 @@ priva

[GitHub] [pulsar] david-streamlio commented on a change in pull request #9943: [Issue-9926][Pulsar Functions] Pass through record properties from Pulsar Sources

2021-03-17 Thread GitBox
david-streamlio commented on a change in pull request #9943: URL: https://github.com/apache/pulsar/pull/9943#discussion_r596341448 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java ## @@ -736,8 +737,14 @@ priva

[GitHub] [pulsar] david-streamlio commented on a change in pull request #9943: [Issue-9926][Pulsar Functions] Pass through record properties from Pulsar Sources

2021-03-17 Thread GitBox
david-streamlio commented on a change in pull request #9943: URL: https://github.com/apache/pulsar/pull/9943#discussion_r596341448 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java ## @@ -736,8 +737,14 @@ priva

[GitHub] [pulsar] frankjkelly commented on issue #5510: splitting bundle error

2021-03-17 Thread GitBox
frankjkelly commented on issue #5510: URL: https://github.com/apache/pulsar/issues/5510#issuecomment-801377287 Thanks @lhotari I have hit this too in Apache Pulsar 2.6.1 CC @addisonj This is an automated message from the

[GitHub] [pulsar] devinbost opened a new issue #9944: Still get red in IntelliJ...

2021-03-17 Thread GitBox
devinbost opened a new issue #9944: URL: https://github.com/apache/pulsar/issues/9944 It seems like every once in a while I find myself facing this same issue in IntelliJ with Pulsar, and I can't ever seem to remember how to get it to go away... ![image](https://user-images.githubuserc

[GitHub] [pulsar] david-streamlio commented on a change in pull request #9943: [Issue-9926][Pulsar Functions] Pass through record properties from Pulsar Sources

2021-03-17 Thread GitBox
david-streamlio commented on a change in pull request #9943: URL: https://github.com/apache/pulsar/pull/9943#discussion_r596319440 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java ## @@ -736,8 +737,14 @@ priva

[GitHub] [pulsar] david-streamlio commented on a change in pull request #9943: [Issue-9926][Pulsar Functions] Pass through record properties from Pulsar Sources

2021-03-17 Thread GitBox
david-streamlio commented on a change in pull request #9943: URL: https://github.com/apache/pulsar/pull/9943#discussion_r596319440 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java ## @@ -736,8 +737,14 @@ priva

[GitHub] [pulsar] eolivelli commented on a change in pull request #9943: [Issue-9926][Pulsar Functions] Pass through record properties from Pulsar Sources

2021-03-17 Thread GitBox
eolivelli commented on a change in pull request #9943: URL: https://github.com/apache/pulsar/pull/9943#discussion_r596317775 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java ## @@ -736,8 +737,14 @@ private voi

[GitHub] [pulsar] david-streamlio opened a new pull request #9943: [Issue-9926][Pulsar Functions] Pass through record properties from Pulsar Sources

2021-03-17 Thread GitBox
david-streamlio opened a new pull request #9943: URL: https://github.com/apache/pulsar/pull/9943

[GitHub] [pulsar] eolivelli commented on pull request #9898: Upgrade to Apache Avro 1.10.2

2021-03-17 Thread GitBox
eolivelli commented on pull request #9898: URL: https://github.com/apache/pulsar/pull/9898#issuecomment-801233024 Thank you @RyanSkraba for your review This is an automated message from the Apache Git Service. To respond to t

[GitHub] [pulsar] klevy-toast commented on issue #9141: Message redelivery delay with exponential back-off

2021-03-17 Thread GitBox
klevy-toast commented on issue #9141: URL: https://github.com/apache/pulsar/issues/9141#issuecomment-801215940 @codelipenghui sure, although it may take me a while to find the spare cycles. This is an automated message from

[GitHub] [pulsar] BewareMyPower commented on issue #9796: Segment fault occur while test the example of asyn producer using c++

2021-03-17 Thread GitBox
BewareMyPower commented on issue #9796: URL: https://github.com/apache/pulsar/issues/9796#issuecomment-801171217 I noticed that you provided some confused info. `setBlockIfQueueFull` accepts a `bool` value, `setBlockIfQueueFull(10)` is same with `setBlockIfQueueFull(true)` in C++, or

[GitHub] [pulsar] congbobo184 opened a new pull request #9942: [Transaction] Transaction buffer metrics.

2021-03-17 Thread GitBox
congbobo184 opened a new pull request #9942: URL: https://github.com/apache/pulsar/pull/9942 ## Motivation Transaction buffer metrics add. ## implement ``` /** The active transactions. */ public long activeTransactions; /** The commit transaction count o

[GitHub] [pulsar] michaeljmarshall opened a new pull request #9941: [Documentation] Fix reference configuration table formatting

2021-03-17 Thread GitBox
michaeljmarshall opened a new pull request #9941: URL: https://github.com/apache/pulsar/pull/9941 This PR includes basic improvements to table formatting in the `reference-configuration.md` file. There were several issues: 1. Some rows were missing a pipe (`|`). This didn't affect re

[pulsar-dotpulsar] annotated tag 1.0.0 updated (6950c11 -> 63f855b)

2021-03-17 Thread blankensteiner
This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a change to annotated tag 1.0.0 in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git. *** WARNING: tag 1.0.0 was modified! *** from 6950c11 (commit) to 63f855b (tag) tagging

[pulsar-dotpulsar] branch master updated: Make ready for 1.0.0 and fix seek problem (broker is sending close command before success)

2021-03-17 Thread blankensteiner
This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git The following commit(s) were added to refs/heads/master by this push: new 6950c11 Make ready for 1.0.0

[GitHub] [pulsar] gaoran10 commented on a change in pull request #9910: [Pulsar-sql]Using pulsar SQL query messages will appear `NoSuchLedger…

2021-03-17 Thread GitBox
gaoran10 commented on a change in pull request #9910: URL: https://github.com/apache/pulsar/pull/9910#discussion_r596078188 ## File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarConnectorCache.java ## @@ -112,7 +112,7 @@ private static Managed

[GitHub] [pulsar] gaoran10 commented on a change in pull request #9910: [Pulsar-sql]Using pulsar SQL query messages will appear `NoSuchLedger…

2021-03-17 Thread GitBox
gaoran10 commented on a change in pull request #9910: URL: https://github.com/apache/pulsar/pull/9910#discussion_r596078188 ## File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarConnectorCache.java ## @@ -112,7 +112,7 @@ private static Managed

[GitHub] [pulsar] fransguelinckx opened a new issue #9940: Messages can get consumed out of order with key_shared subscriptions and small receiverQueueSize

2021-03-17 Thread GitBox
fransguelinckx opened a new issue #9940: URL: https://github.com/apache/pulsar/issues/9940 **Describe the bug** Messages can get consumed out of order with key_shared subscriptions and small receiverQueueSize **To Reproduce** Steps to reproduce the behavior: * A producer tha

[GitHub] [pulsar] eolivelli commented on pull request #9898: Upgrade to Apache Avro 1.10.1

2021-03-17 Thread GitBox
eolivelli commented on pull request #9898: URL: https://github.com/apache/pulsar/pull/9898#issuecomment-801135722 Avro 1.10.2 has been released today, I will update the patch once CI passes and I am sure that all tests are passing --

[GitHub] [pulsar] eolivelli commented on a change in pull request #9590: Support writing general records to Pulsar sink

2021-03-17 Thread GitBox
eolivelli commented on a change in pull request #9590: URL: https://github.com/apache/pulsar/pull/9590#discussion_r596069056 ## File path: tests/docker-images/java-test-functions/src/main/java/org/apache/pulsar/tests/integration/io/GenericRecordSource.java ## @@ -0,0 +1,88 @@

[GitHub] [pulsar] TIBCOeddie opened a new issue #9939: s/device/measurement

2021-03-17 Thread GitBox
TIBCOeddie opened a new issue #9939: URL: https://github.com/apache/pulsar/issues/9939 https://github.com/apache/pulsar/blob/94bf13f2f216c9f5d7ca00af31a5efaedde7e397/pulsar-io/influxdb/src/main/java/org/apache/pulsar/io/influxdb/v2/InfluxDBSink.java#L70 ---

[GitHub] [pulsar] KannarFr edited a comment on issue #6930: Pulsar SQL: support user defined indexes

2021-03-17 Thread GitBox
KannarFr edited a comment on issue #6930: URL: https://github.com/apache/pulsar/issues/6930#issuecomment-800187333 @pointearth @sijie How do you imagine the index composition regarding ledgers? As the first implementation, regarding pub/sub system, timestamp index-based would be a good sta

[GitHub] [pulsar] KannarFr commented on issue #6930: Pulsar SQL: support user defined indexes

2021-03-17 Thread GitBox
KannarFr commented on issue #6930: URL: https://github.com/apache/pulsar/issues/6930#issuecomment-801032939 And where/how we store this index? This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] yitian108 commented on issue #9796: Segment fault occur while test the example of asyn producer using c++

2021-03-17 Thread GitBox
yitian108 commented on issue #9796: URL: https://github.com/apache/pulsar/issues/9796#issuecomment-801012161 Unluckily, when I try to add the configuration ProducerConfiguration as above, the segment fault still persist, and a small good news, if I set the producerConf.setBlockIfQueueFull(

[GitHub] [pulsar] Anonymitaet commented on pull request #9938: [Doc] Add guides for producer access mode

2021-03-17 Thread GitBox
Anonymitaet commented on pull request #9938: URL: https://github.com/apache/pulsar/pull/9938#issuecomment-800986101 @merlimat @zymap @codelipenghui @Jennifer88huang @Huanli-Meng could you please help review? Thanks This is a

[GitHub] [pulsar] Anonymitaet opened a new pull request #9938: [Doc] Add guides for producer access mode

2021-03-17 Thread GitBox
Anonymitaet opened a new pull request #9938: URL: https://github.com/apache/pulsar/pull/9938 Add docs for https://github.com/apache/pulsar/pull/8992 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] Anonymitaet commented on pull request #9937: [Doc] Add guides for TLS SNI support (C++ and Python clients)

2021-03-17 Thread GitBox
Anonymitaet commented on pull request #9937: URL: https://github.com/apache/pulsar/pull/9937#issuecomment-800979277 @deonvdv @zymap @codelipenghui @Huanli-Meng @Jennifer88huang could you please help review? Thanks This is an

[GitHub] [pulsar] Anonymitaet opened a new pull request #9937: [Doc] Add guides for TLS SNI support (C++ and Python clients)

2021-03-17 Thread GitBox
Anonymitaet opened a new pull request #9937: URL: https://github.com/apache/pulsar/pull/9937 Add docs for https://github.com/apache/pulsar/pull/8957. This is an automated message from the Apache Git Service. To respond to the

  1   2   >