[GitHub] [pulsar] jerrypeng opened a new pull request #10185: Expose local run config metrics-port-start to CLI

2021-04-09 Thread GitBox
jerrypeng opened a new pull request #10185: URL: https://github.com/apache/pulsar/pull/10185 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] 315157973 commented on issue #9216: Support get topic applied policy

2021-04-09 Thread GitBox
315157973 commented on issue #9216: URL: https://github.com/apache/pulsar/issues/9216#issuecomment-817076307 All of my new APIs have descriptions. However, my new APIs and many old APIs with descriptions are not displayed in `Java admin API`. Please help to check the tool. @Anonymitaet

[GitHub] [pulsar] zjyingchang commented on a change in pull request #10163: Add Thread.currentThread.interrupt() after catching InterruptedException and document it in the javadoc

2021-04-09 Thread GitBox
zjyingchang commented on a change in pull request #10163: URL: https://github.com/apache/pulsar/pull/10163#discussion_r610986444 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ## @@ -453,6 +455,7 @@ public UnAckedMessageTracker

[GitHub] [pulsar] rdhabalia opened a new pull request #10184: PIP 83 : Pulsar client: Message consumption with pooled buffer

2021-04-09 Thread GitBox
rdhabalia opened a new pull request #10184: URL: https://github.com/apache/pulsar/pull/10184 ### Motivation Pulsar client library should provide support for an API to allow the application to access message payload from pooled buffers. The library has to also provide an associated

[GitHub] [pulsar-client-go] hunter2046 commented on pull request #507: Expose NumPartitions() method on the producer

2021-04-09 Thread GitBox
hunter2046 commented on pull request #507: URL: https://github.com/apache/pulsar-client-go/pull/507#issuecomment-817052498 > In the `MessageRouter`, you're getting a `TopicMetadata` object which will tell you the number of partitions: > >

[pulsar] branch master updated: Upgrade Jetty libraries to 9.4.39.v20210325 (#10177)

2021-04-09 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 56bad04 Upgrade Jetty libraries to

[GitHub] [pulsar] merlimat merged pull request #10177: Upgrade Jetty libraries to 9.4.39.v20210325

2021-04-09 Thread GitBox
merlimat merged pull request #10177: URL: https://github.com/apache/pulsar/pull/10177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [pulsar] merlimat commented on pull request #10183: CVE-2021-28165-Jetty

2021-04-09 Thread GitBox
merlimat commented on pull request #10183: URL: https://github.com/apache/pulsar/pull/10183#issuecomment-817049525 @dinghram Thanks for the PR, this was already being addressed on #10177 which just got merged. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar-client-go] merlimat commented on pull request #507: Expose NumPartitions() method on the producer

2021-04-09 Thread GitBox
merlimat commented on pull request #507: URL: https://github.com/apache/pulsar-client-go/pull/507#issuecomment-817048549 In the `MessageRouter`, you're getting a `TopicMetadata` object which will tell you the number of partitions:

[GitHub] [pulsar] devinbost commented on pull request #10166: Add debug logging when consumer fails to send permits to Broker

2021-04-09 Thread GitBox
devinbost commented on pull request #10166: URL: https://github.com/apache/pulsar/pull/10166#issuecomment-817037489 I changed this to a debug statement and added a little more detail to assist in debugging permits issues. @merlimat What do you think now? -- This is an automated

[GitHub] [pulsar] devinbost edited a comment on issue #6255: Client flow permits calibration

2021-04-09 Thread GitBox
devinbost edited a comment on issue #6255: URL: https://github.com/apache/pulsar/issues/6255#issuecomment-816987017 Thanks for creating this issue. I'm actively working on it, but I haven't found a clear root cause yet. What I've noticed, however, is that the client consumer has the

[GitHub] [pulsar] devinbost commented on issue #6054: Catastrophic frequent random topic freezes, especially on high-traffic topics.

2021-04-09 Thread GitBox
devinbost commented on issue #6054: URL: https://github.com/apache/pulsar/issues/6054#issuecomment-817014223 The negative permits value matches between the dispatcher and the broker Consumer for the corresponding topic:

[GitHub] [pulsar] dinghram opened a new pull request #10183: CVE-2021-28165-Jetty

2021-04-09 Thread GitBox
dinghram opened a new pull request #10183: URL: https://github.com/apache/pulsar/pull/10183 In Eclipse Jetty 7.2.2 to 9.4.38, 10.0.0.alpha0 to 10.0.1, and 11.0.0.alpha0 to 11.0.1, CPU usage can reach 100% upon receiving a large invalid TLS frame. Upgraded Jetty from

[GitHub] [pulsar] devinbost edited a comment on issue #6054: Catastrophic frequent random topic freezes, especially on high-traffic topics.

2021-04-09 Thread GitBox
devinbost edited a comment on issue #6054: URL: https://github.com/apache/pulsar/issues/6054#issuecomment-817004087 I've confirmed that permits are positive (and appear healthy) on ALL the functions' ConsumerImpl objects when the _brokers_ reported **negative** permits for the topics in

[GitHub] [pulsar] devinbost edited a comment on issue #6054: Catastrophic frequent random topic freezes, especially on high-traffic topics.

2021-04-09 Thread GitBox
devinbost edited a comment on issue #6054: URL: https://github.com/apache/pulsar/issues/6054#issuecomment-817004087 I've confirmed that permits are positive (and appear healthy) on ALL the functions' ConsumerImpl objects when the _brokers_ reported **negative** permits for the topics in

[GitHub] [pulsar] devinbost edited a comment on issue #6255: Client flow permits calibration

2021-04-09 Thread GitBox
devinbost edited a comment on issue #6255: URL: https://github.com/apache/pulsar/issues/6255#issuecomment-816987017 Thanks for creating this issue. I'm actively working on it, but I haven't found a clear root cause yet. What I've noticed, however, is that the client consumer has the

[GitHub] [pulsar] devinbost edited a comment on issue #6054: Catastrophic frequent random topic freezes, especially on high-traffic topics.

2021-04-09 Thread GitBox
devinbost edited a comment on issue #6054: URL: https://github.com/apache/pulsar/issues/6054#issuecomment-817004087 I've confirmed that permits are positive (and appear healthy) on ALL the functions' ConsumerImpl objects when the _brokers_ reported **negative** permits for the topics in

[GitHub] [pulsar-client-go] hunter2046 opened a new pull request #507: Expose NumPartitions() method on the producer

2021-04-09 Thread GitBox
hunter2046 opened a new pull request #507: URL: https://github.com/apache/pulsar-client-go/pull/507 ### Motivation Expose the method so that the client will be able to know the number of partitions, which could help the client decide custom routing strategies. ###

[GitHub] [pulsar] devinbost commented on issue #6054: Catastrophic frequent random topic freezes, especially on high-traffic topics.

2021-04-09 Thread GitBox
devinbost commented on issue #6054: URL: https://github.com/apache/pulsar/issues/6054#issuecomment-817004087 I've confirmed that permits are positive (and appear healthy) on ALL the functions' ConsumerImpl objects when the _brokers_ reported **negative** permits for the topics in two

[GitHub] [pulsar] devinbost commented on issue #6255: Client flow permits calibration

2021-04-09 Thread GitBox
devinbost commented on issue #6255: URL: https://github.com/apache/pulsar/issues/6255#issuecomment-816997775 It's also possible that only certain kinds of workloads trigger the issues. We've seen this issue in function workloads using shared subscriptions with one or more consumers per

[GitHub] [pulsar] linlinnn commented on pull request #10160: [ISSUE 10153]fix time unit ns -> ms

2021-04-09 Thread GitBox
linlinnn commented on pull request #10160: URL: https://github.com/apache/pulsar/pull/10160#issuecomment-816990444 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] linlinnn commented on pull request #10178: [ISSUE 10176] fix npe in CmdTopics

2021-04-09 Thread GitBox
linlinnn commented on pull request #10178: URL: https://github.com/apache/pulsar/pull/10178#issuecomment-816990208 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] devinbost commented on issue #6255: Client flow permits calibration

2021-04-09 Thread GitBox
devinbost commented on issue #6255: URL: https://github.com/apache/pulsar/issues/6255#issuecomment-816987017 Thanks for creating this issue. I'm actively working on it, but I haven't found a clear root cause yet. What I've noticed, however, is that the client consumer has the correct

[GitHub] [pulsar] eolivelli commented on pull request #10140: [Issue-9889] [integration tests] Refactored Function integration tests

2021-04-09 Thread GitBox
eolivelli commented on pull request #10140: URL: https://github.com/apache/pulsar/pull/10140#issuecomment-816961020 @david-streamlio can you fix the conflicts please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[pulsar] branch master updated: Fix IllegalStateException in PersistentReplicator (#10098)

2021-04-09 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 05f1f7e Fix IllegalStateException in

[GitHub] [pulsar] sijie closed issue #10097: Replicated Subscription fail with IllegalStateException

2021-04-09 Thread GitBox
sijie closed issue #10097: URL: https://github.com/apache/pulsar/issues/10097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [pulsar] sijie merged pull request #10098: Fix IllegalStateException in PersistentReplicator

2021-04-09 Thread GitBox
sijie merged pull request #10098: URL: https://github.com/apache/pulsar/pull/10098 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [pulsar] devinbost commented on pull request #9789: [pulsar-broker] Allow broker to discover and unblock stuck subscription

2021-04-09 Thread GitBox
devinbost commented on pull request #9789: URL: https://github.com/apache/pulsar/pull/9789#issuecomment-816922986 I realized that this won't help when negative permits are occurring... So, there's still more work to do to unblock stuck subscriptions. -- This is an automated message

[pulsar] branch master updated (5c521a3 -> c3b02d3)

2021-04-09 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 5c521a3 [C++] Fixed race condition in MemoryLimitController (#10142) add c3b02d3 [C++] Fixed releasing

[pulsar] branch master updated (a5a94ed -> 5c521a3)

2021-04-09 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from a5a94ed GenericObject - support KeyValue in Message#getValue() (#10107) add 5c521a3 [C++] Fixed race

[GitHub] [pulsar] lhotari commented on pull request #10148: [CI] Move flaky tests that fail very often to "quarantine" test group and improve CI stability

2021-04-09 Thread GitBox
lhotari commented on pull request #10148: URL: https://github.com/apache/pulsar/pull/10148#issuecomment-816865118 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] jerrypeng merged pull request #10144: [C++] Fixed releasing semaphore and memory quota after send timeout

2021-04-09 Thread GitBox
jerrypeng merged pull request #10144: URL: https://github.com/apache/pulsar/pull/10144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [pulsar] jerrypeng merged pull request #10142: [C++] Fixed race condition in MemoryLimitController

2021-04-09 Thread GitBox
jerrypeng merged pull request #10142: URL: https://github.com/apache/pulsar/pull/10142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [pulsar] lhotari closed pull request #10180: Use AtomicIntegerFieldUpdater to mutate volatile int totalAvailablePermits in PersistentDispatcherMultipleConsumers class

2021-04-09 Thread GitBox
lhotari closed pull request #10180: URL: https://github.com/apache/pulsar/pull/10180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [pulsar] lhotari commented on pull request #10180: Use AtomicIntegerFieldUpdater to mutate volatile int totalAvailablePermits in PersistentDispatcherMultipleConsumers class

2021-04-09 Thread GitBox
lhotari commented on pull request #10180: URL: https://github.com/apache/pulsar/pull/10180#issuecomment-816852652 I'm closing this PR since as @merlimat pointed out, all mutations are already safe since they are done in `synchronized` methods in `PersistentDispatcherMultipleConsumers`

[pulsar] branch master updated: GenericObject - support KeyValue in Message#getValue() (#10107)

2021-04-09 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new a5a94ed GenericObject - support KeyValue in

[GitHub] [pulsar] eolivelli merged pull request #10107: GenericObject - support KeyValue in Message#getValue()

2021-04-09 Thread GitBox
eolivelli merged pull request #10107: URL: https://github.com/apache/pulsar/pull/10107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [pulsar] lhotari commented on a change in pull request #10180: Use AtomicIntegerFieldUpdater to mutate volatile int totalAvailablePermits in PersistentDispatcherMultipleConsumers class

2021-04-09 Thread GitBox
lhotari commented on a change in pull request #10180: URL: https://github.com/apache/pulsar/pull/10180#discussion_r610772740 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java ## @@ -184,7 +184,7 @@

[GitHub] [pulsar] lhotari commented on a change in pull request #10180: Use AtomicIntegerFieldUpdater to mutate volatile int totalAvailablePermits in PersistentDispatcherMultipleConsumers class

2021-04-09 Thread GitBox
lhotari commented on a change in pull request #10180: URL: https://github.com/apache/pulsar/pull/10180#discussion_r610772740 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java ## @@ -184,7 +184,7 @@

[GitHub] [pulsar] devinbost commented on pull request #10166: Logging warning when consumer fails to send permits to Broker

2021-04-09 Thread GitBox
devinbost commented on pull request #10166: URL: https://github.com/apache/pulsar/pull/10166#issuecomment-816802508 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] bharanic-dev commented on pull request #10008: [PIP-82] [pulsar-broker] Add a task to publish resource usage to a topic

2021-04-09 Thread GitBox
bharanic-dev commented on pull request #10008: URL: https://github.com/apache/pulsar/pull/10008#issuecomment-816799642 @eolivelli, thank you for the review and for merging the changes to master. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] lhotari commented on a change in pull request #10180: Use AtomicIntegerFieldUpdater to mutate volatile int totalAvailablePermits in PersistentDispatcherMultipleConsumers class

2021-04-09 Thread GitBox
lhotari commented on a change in pull request #10180: URL: https://github.com/apache/pulsar/pull/10180#discussion_r610756824 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java ## @@ -175,7 +175,7 @@

[GitHub] [pulsar] devinbost commented on pull request #10180: Use AtomicIntegerFieldUpdater to mutate volatile int totalAvailablePermits in PersistentDispatcherMultipleConsumers class

2021-04-09 Thread GitBox
devinbost commented on pull request #10180: URL: https://github.com/apache/pulsar/pull/10180#issuecomment-816797745 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[pulsar] branch master updated (31f8315 -> 6629b15)

2021-04-09 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 31f8315 [Messaging] Fix delay message block (#10078) add 6629b15 Attempt to fix flaky test

[GitHub] [pulsar] merlimat merged pull request #10118: Attempt to fix flaky test SimpleProducerConsumerTestStreamingDispatcherTest.testRedeliveryFailOverConsumer

2021-04-09 Thread GitBox
merlimat merged pull request #10118: URL: https://github.com/apache/pulsar/pull/10118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [pulsar] merlimat closed issue #10117: Flaky-test: SimpleProducerConsumerTestStreamingDispatcherTest.testRedeliveryFailOverConsumer

2021-04-09 Thread GitBox
merlimat closed issue #10117: URL: https://github.com/apache/pulsar/issues/10117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [pulsar] merlimat commented on a change in pull request #10180: Use AtomicIntegerFieldUpdater to mutate volatile int totalAvailablePermits in PersistentDispatcherMultipleConsumers class

2021-04-09 Thread GitBox
merlimat commented on a change in pull request #10180: URL: https://github.com/apache/pulsar/pull/10180#discussion_r610736439 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java ## @@ -184,7 +184,7

[GitHub] [pulsar] abhilashmandaliya commented on pull request #10028: [Issue 10010][Client] fixed memory leak

2021-04-09 Thread GitBox
abhilashmandaliya commented on pull request #10028: URL: https://github.com/apache/pulsar/pull/10028#issuecomment-816746644 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] lhotari commented on pull request #10180: Use AtomicIntegerFieldUpdater to mutate volatile int totalAvailablePermits in PersistentDispatcherMultipleConsumers class

2021-04-09 Thread GitBox
lhotari commented on pull request #10180: URL: https://github.com/apache/pulsar/pull/10180#issuecomment-816738791 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] yufan022 commented on a change in pull request #9696: [docs] Add documents for Aliyun OSS offload

2021-04-09 Thread GitBox
yufan022 commented on a change in pull request #9696: URL: https://github.com/apache/pulsar/pull/9696#discussion_r610601147 ## File path: site2/docs/tiered-storage-aliyun.md ## @@ -0,0 +1,217 @@ +--- +id: tiered-storage-aliyun +title: Use Aliyun OSS offloader with Pulsar

[GitHub] [pulsar] Anonymitaet edited a comment on issue #9216: Support get topic applied policy

2021-04-09 Thread GitBox
Anonymitaet edited a comment on issue #9216: URL: https://github.com/apache/pulsar/issues/9216#issuecomment-816659258 @315157973 `Java admin API` is the same as what you did for `pulsar-admin` and `REST API`. If you want to add docs for [Java admin

[GitHub] [pulsar] Anonymitaet commented on issue #9216: Support get topic applied policy

2021-04-09 Thread GitBox
Anonymitaet commented on issue #9216: URL: https://github.com/apache/pulsar/issues/9216#issuecomment-816659258 @315157973 If you want to add docs for [Java admin API](https://pulsar.apache.org/api/admin/), you may need to add descriptions to [these

[GitHub] [pulsar] lhotari commented on pull request #10180: Use AtomicIntegerFieldUpdater to mutate volatile int totalAvailablePermits in PersistentDispatcherMultipleConsumers class

2021-04-09 Thread GitBox
lhotari commented on pull request #10180: URL: https://github.com/apache/pulsar/pull/10180#issuecomment-816658084 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] Anonymitaet commented on pull request #9696: [docs] Add documents for Aliyun OSS offload

2021-04-09 Thread GitBox
Anonymitaet commented on pull request #9696: URL: https://github.com/apache/pulsar/pull/9696#issuecomment-816656488 @yufan022 thanks for your feedback. Left one minor suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #9696: [docs] Add documents for Aliyun OSS offload

2021-04-09 Thread GitBox
Anonymitaet commented on a change in pull request #9696: URL: https://github.com/apache/pulsar/pull/9696#discussion_r610596218 ## File path: site2/docs/tiered-storage-aliyun.md ## @@ -0,0 +1,217 @@ +--- +id: tiered-storage-aliyun +title: Use Aliyun OSS offloader with Pulsar

[GitHub] [pulsar] lhotari commented on pull request #10180: Use AtomicIntegerFieldUpdater to mutate volatile int totalAvailablePermits in PersistentDispatcherMultipleConsumers class

2021-04-09 Thread GitBox
lhotari commented on pull request #10180: URL: https://github.com/apache/pulsar/pull/10180#issuecomment-816656107 btw. This problem was only in the `PersistentDispatcherMultipleConsumers` class. Similar code in `NonPersistentDispatcherMultipleConsumers` didn't have the issue:

[GitHub] [pulsar] yufan022 commented on pull request #9696: [docs] Add documents for Aliyun OSS offload

2021-04-09 Thread GitBox
yufan022 commented on pull request #9696: URL: https://github.com/apache/pulsar/pull/9696#issuecomment-816651331 @Anonymitaet @Jennifer88huang @Huanli-Meng PTAL. Apologize again for my delay. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] yufan022 commented on pull request #9696: [docs] Add documents for Aliyun OSS offload

2021-04-09 Thread GitBox
yufan022 commented on pull request #9696: URL: https://github.com/apache/pulsar/pull/9696#issuecomment-816648712 > @yufan022 Thank you very much for your contribution. > I notice that there are some comments that haven't dealt with. Will you incorporate those comments later or will you

[GitHub] [pulsar] yufan022 commented on a change in pull request #9696: [docs] Add documents for Aliyun OSS offload

2021-04-09 Thread GitBox
yufan022 commented on a change in pull request #9696: URL: https://github.com/apache/pulsar/pull/9696#discussion_r610586142 ## File path: site2/docs/tiered-storage-aliyun.md ## @@ -0,0 +1,242 @@ +--- +id: tiered-storage-aliyun +title: Use Aliyun OSS offloader with Pulsar

[GitHub] [pulsar] eolivelli commented on pull request #10182: Issue 10181: Transactions: broker side NullPointerException in case of enableTransactionCoordinator=false

2021-04-09 Thread GitBox
eolivelli commented on pull request #10182: URL: https://github.com/apache/pulsar/pull/10182#issuecomment-816616713 for reference, this is the new error on the client side: > org.apache.pulsar.client.api.transaction.TransactionCoordinatorClientException: Transaction manager is not

[GitHub] [pulsar] lhotari commented on pull request #10180: Use AtomicIntegerFieldUpdater to mutate volatile int totalAvailablePermits in PersistentDispatcherMultipleConsumers class

2021-04-09 Thread GitBox
lhotari commented on pull request #10180: URL: https://github.com/apache/pulsar/pull/10180#issuecomment-816611708 This PR was co-authored with @devinbost . Thanks for @devinbost for pinpointing the code location around `totalAvailablePermits` in `PersistentDispatcherMultipleConsumers`

[GitHub] [pulsar] eolivelli opened a new pull request #10182: Issue 10181: Transactions: broker side NullPointerException in case of enableTransactionCoordinator=false

2021-04-09 Thread GitBox
eolivelli opened a new pull request #10182: URL: https://github.com/apache/pulsar/pull/10182 Fixes #10181 ### Modifications Prevent the NPE to bubble up This change is a trivial rework / code cleanup without any test coverage. -- This is an automated message from

[GitHub] [pulsar] eolivelli opened a new issue #10181: Transactions: broker side NullPointerException in case of enableTransactionCoordinator=false

2021-04-09 Thread GitBox
eolivelli opened a new issue #10181: URL: https://github.com/apache/pulsar/issues/10181 **Describe the bug** ``` 12:42:54.274 [pulsar-io-52-23] WARN org.apache.pulsar.broker.service.ServerCnx - [/127.0.0.1:55491] Got exception java.lang.NullPointerException at

[GitHub] [pulsar] yufan022 commented on a change in pull request #9696: [docs] Add documents for Aliyun OSS offload

2021-04-09 Thread GitBox
yufan022 commented on a change in pull request #9696: URL: https://github.com/apache/pulsar/pull/9696#discussion_r610519180 ## File path: site2/docs/tiered-storage-aliyun.md ## @@ -0,0 +1,242 @@ +--- +id: tiered-storage-aliyun +title: Use Aliyun OSS offloader with Pulsar

[GitHub] [pulsar] lhotari opened a new pull request #10180: Use AtomicIntegerFieldUpdater to mutate volatile int totalAvailablePermits

2021-04-09 Thread GitBox
lhotari opened a new pull request #10180: URL: https://github.com/apache/pulsar/pull/10180 ### Motivation AtomicIntegerFieldUpdater should be used to update `volatile int` fields. ### Modifications Use existing `TOTAL_AVAILABLE_PERMITS_UPDATER` to mutate

[GitHub] [pulsar] 315157973 commented on issue #9216: Support get topic applied policy

2021-04-09 Thread GitBox
315157973 commented on issue #9216: URL: https://github.com/apache/pulsar/issues/9216#issuecomment-816577494 "docs" are added in `pulsar-admin`, `REST API`. The `Java admin API` does not seem to be automatically generated yet? Many new APIs do not exist, not just those I added --

[GitHub] [pulsar] linlinnn commented on pull request #10178: [ISSUE 10176] fix npe in CmdTopics

2021-04-09 Thread GitBox
linlinnn commented on pull request #10178: URL: https://github.com/apache/pulsar/pull/10178#issuecomment-816575166 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] yufan022 commented on pull request #9696: [docs] Add documents for Aliyun OSS offload

2021-04-09 Thread GitBox
yufan022 commented on pull request #9696: URL: https://github.com/apache/pulsar/pull/9696#issuecomment-816568155 > @yufan022 could you please check the comments and update the doc if necessary? Thanks Sorry for the late, I will finish the work. -- This is an automated message

[GitHub] [pulsar] Anonymitaet commented on issue #9216: Support get topic applied policy

2021-04-09 Thread GitBox
Anonymitaet commented on issue #9216: URL: https://github.com/apache/pulsar/issues/9216#issuecomment-816567252 @315157973 yes, the "docs" are added in the code files and they will be shown on websites automatically. One thing should pay attention to is that if your changes apply to

[GitHub] [pulsar] yufan022 commented on a change in pull request #9696: [docs] Add documents for Aliyun OSS offload

2021-04-09 Thread GitBox
yufan022 commented on a change in pull request #9696: URL: https://github.com/apache/pulsar/pull/9696#discussion_r610499167 ## File path: site2/docs/tiered-storage-aliyun.md ## @@ -0,0 +1,242 @@ +--- +id: tiered-storage-aliyun +title: Use Aliyun OSS offloader with Pulsar

[GitHub] [pulsar] yufan022 commented on a change in pull request #9696: [docs] Add documents for Aliyun OSS offload

2021-04-09 Thread GitBox
yufan022 commented on a change in pull request #9696: URL: https://github.com/apache/pulsar/pull/9696#discussion_r610498949 ## File path: site2/docs/tiered-storage-aliyun.md ## @@ -0,0 +1,242 @@ +--- +id: tiered-storage-aliyun +title: Use Aliyun OSS offloader with Pulsar

[GitHub] [pulsar] 315157973 commented on issue #9216: Support get topic applied policy

2021-04-09 Thread GitBox
315157973 commented on issue #9216: URL: https://github.com/apache/pulsar/issues/9216#issuecomment-816560657 ![image](https://user-images.githubusercontent.com/9758905/114161556-ccfa6380-995a-11eb-95b9-9c4793e1f677.png) Looks like it has been generated -- This is an automated

[GitHub] [pulsar] 315157973 commented on issue #9216: Support get topic applied policy

2021-04-09 Thread GitBox
315157973 commented on issue #9216: URL: https://github.com/apache/pulsar/issues/9216#issuecomment-816560118 There are descriptions in my code, and we already have automatic document generation tools, so I don’t need to add them manually, right? @Anonymitaet -- This is an automated

[pulsar] branch master updated (cb507da -> 31f8315)

2021-04-09 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from cb507da [PIP-82] [pulsar-broker] Add a task to publish resource usage to a topic (#10008) add 31f8315

[GitHub] [pulsar] codelipenghui merged pull request #10078: [Messaging] Fix delay message block

2021-04-09 Thread GitBox
codelipenghui merged pull request #10078: URL: https://github.com/apache/pulsar/pull/10078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [pulsar] eolivelli commented on a change in pull request #10129: fix the default retry letter and dead letter topic name

2021-04-09 Thread GitBox
eolivelli commented on a change in pull request #10129: URL: https://github.com/apache/pulsar/pull/10129#discussion_r610487371 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBuilderImpl.java ## @@ -121,8 +117,29 @@ public

[GitHub] [pulsar] eolivelli commented on a change in pull request #10163: Add Thread.currentThread.interrupt() after catching InterruptedException and document it in the javadoc

2021-04-09 Thread GitBox
eolivelli commented on a change in pull request #10163: URL: https://github.com/apache/pulsar/pull/10163#discussion_r610484938 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ## @@ -453,6 +455,7 @@ public UnAckedMessageTracker

[GitHub] [pulsar] wangjialing218 commented on pull request #10129: fix the default retry letter and dead letter topic name

2021-04-09 Thread GitBox
wangjialing218 commented on pull request #10129: URL: https://github.com/apache/pulsar/pull/10129#issuecomment-816543257 @codelipenghui @merlimat Add compatible check. If old name of DLQ and retry topic exists, using old topics. -- This is an automated message from the Apache Git

[GitHub] [pulsar] Anonymitaet commented on pull request #9696: [docs] Add documents for Aliyun OSS offload

2021-04-09 Thread GitBox
Anonymitaet commented on pull request #9696: URL: https://github.com/apache/pulsar/pull/9696#issuecomment-816504271 @yufan022 could you please check the comments and update the doc if necessary? Thanks -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar] thanhcb closed issue #10143: Partitioned topics not served enough active brokers

2021-04-09 Thread GitBox
thanhcb closed issue #10143: URL: https://github.com/apache/pulsar/issues/10143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [pulsar] thanhcb commented on issue #10143: Partitioned topics not served enough active brokers

2021-04-09 Thread GitBox
thanhcb commented on issue #10143: URL: https://github.com/apache/pulsar/issues/10143#issuecomment-816503420 ok, i've got it, close issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] Anonymitaet edited a comment on issue #9216: Support get topic applied policy

2021-04-09 Thread GitBox
Anonymitaet edited a comment on issue #9216: URL: https://github.com/apache/pulsar/issues/9216#issuecomment-816500510 @315157973 thanks for your great contribution! Since you've finished all code work, could u pls add docs for them? Then users know your changes and how to use it.

[GitHub] [pulsar] Anonymitaet commented on issue #9216: Support get topic applied policy

2021-04-09 Thread GitBox
Anonymitaet commented on issue #9216: URL: https://github.com/apache/pulsar/issues/9216#issuecomment-816500510 @315157973 thanks for your great contribution! Since you've finished all code work, could u pls add docs for them? Then users know your changes and how to use it. I

[GitHub] [pulsar] Anonymitaet commented on pull request #7855: [Issue 7846]Add support for regex patterns in tenant and namespace

2021-04-09 Thread GitBox
Anonymitaet commented on pull request #7855: URL: https://github.com/apache/pulsar/pull/7855#issuecomment-816482072 @rmn36 thanks for your work. 1. Any progress for this PR? 2. Could you please help add docs accordingly? Thanks -- This is an automated message from the Apache

[GitHub] [pulsar] Anonymitaet commented on pull request #7266: [pulsar-broker] Dispatch batch messages according consumer permits

2021-04-09 Thread GitBox
Anonymitaet commented on pull request #7266: URL: https://github.com/apache/pulsar/pull/7266#issuecomment-816481953 @rdhabalia thanks for your work. 1. Any progress for this PR? 2. Could you please help add docs accordingly? Thanks -- This is an automated message from the

[GitHub] [pulsar] congbobo184 opened a new pull request #10179: [Transaction] Tc recover handle transaction in committing and aborting status .

2021-04-09 Thread GitBox
congbobo184 opened a new pull request #10179: URL: https://github.com/apache/pulsar/pull/10179 ## Motivation Now recover don't handle transaction in committing or aborting status, it only add to ```transactionTimeOutTracker```. ## implement Add ```TransactionRecoverTracker```

[GitHub] [pulsar] linlinnn commented on a change in pull request #10163: Add Thread.currentThread.interrupt() after catching InterruptedException and document it in the javadoc

2021-04-09 Thread GitBox
linlinnn commented on a change in pull request #10163: URL: https://github.com/apache/pulsar/pull/10163#discussion_r610399977 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ## @@ -453,6 +455,7 @@ public UnAckedMessageTracker

[GitHub] [pulsar] Anonymitaet edited a comment on issue #9282: [Doc] C++ client's doc is poor

2021-04-09 Thread GitBox
Anonymitaet edited a comment on issue #9282: URL: https://github.com/apache/pulsar/issues/9282#issuecomment-815622995 @BewareMyPower I've added more descriptions for various classes in [C++ client API -

[GitHub] [pulsar] Anonymitaet edited a comment on issue #9282: [Doc] C++ client's doc is poor

2021-04-09 Thread GitBox
Anonymitaet edited a comment on issue #9282: URL: https://github.com/apache/pulsar/issues/9282#issuecomment-815622995 @BewareMyPower I've added more descriptions for various classes [here](https://docs.google.com/document/d/10Zp0V_R5QCvc3mv0YofU0D1rIGliirtakQZIUVM83xM/edit#) and

[GitHub] [pulsar] linlinnn edited a comment on issue #10173: Tests of class NullValueTest are randomly failing

2021-04-09 Thread GitBox
linlinnn edited a comment on issue #10173: URL: https://github.com/apache/pulsar/issues/10173#issuecomment-816460077 Emm. I was not able to spot any bug yet :( @codelipenghui @eolivelli @lhotari Please take a look for this issue. -- This is an automated message from the Apache Git

[GitHub] [pulsar] linlinnn commented on issue #10173: Tests of class NullValueTest are randomly failing

2021-04-09 Thread GitBox
linlinnn commented on issue #10173: URL: https://github.com/apache/pulsar/issues/10173#issuecomment-816460077 Emm. I was not able to spot any bug yet :( @codelipenghui @eolivelli Please take a look for this issue. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] linlinnn commented on pull request #10160: [ISSUE 10153]fix time unit ns -> ms

2021-04-09 Thread GitBox
linlinnn commented on pull request #10160: URL: https://github.com/apache/pulsar/pull/10160#issuecomment-816457319 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] linlinnn commented on pull request #10120: [doc] Support generate document automatically for pulsar-perf

2021-04-09 Thread GitBox
linlinnn commented on pull request #10120: URL: https://github.com/apache/pulsar/pull/10120#issuecomment-816456647 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] linlinnn opened a new pull request #10178: [ISSUE 10176] fix npe in CmdTopics

2021-04-09 Thread GitBox
linlinnn opened a new pull request #10178: URL: https://github.com/apache/pulsar/pull/10178 Fixes #10176 ### Motivation fix npe in CmdTopics ### Modifications remove the member topics which causes npe easily. always use getAdmin().topics() -- This is an automated

[GitHub] [pulsar] eolivelli commented on pull request #10034: Pulsar IO: Allow to develop Sinks that support Schema but without setting it at build time (Sink)

2021-04-09 Thread GitBox
eolivelli commented on pull request #10034: URL: https://github.com/apache/pulsar/pull/10034#issuecomment-816442279 @codelipenghui I have reverted the conf file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] eolivelli commented on a change in pull request #10034: Pulsar IO: Allow to develop Sinks that support Schema but without setting it at build time (Sink)

2021-04-09 Thread GitBox
eolivelli commented on a change in pull request #10034: URL: https://github.com/apache/pulsar/pull/10034#discussion_r610374647 ## File path: conf/standalone.conf ## @@ -927,8 +927,10 @@ allowAutoSubscriptionCreation=true # The number of partitioned topics that is allowed to

[pulsar] branch master updated (dd19702 -> cb507da)

2021-04-09 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from dd19702 [C++] Add /opt/homebrew/ as a possible path for OpenSSL on Mac (#10141) add cb507da [PIP-82]

[GitHub] [pulsar] eolivelli merged pull request #10008: [PIP-82] [pulsar-broker] Add a task to publish resource usage to a topic

2021-04-09 Thread GitBox
eolivelli merged pull request #10008: URL: https://github.com/apache/pulsar/pull/10008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [pulsar] eolivelli commented on pull request #10008: [PIP-82] [pulsar-broker] Add a task to publish resource usage to a topic

2021-04-09 Thread GitBox
eolivelli commented on pull request #10008: URL: https://github.com/apache/pulsar/pull/10008#issuecomment-816439371 IIUC @jerrypeng comment will be addresses in the next commit and he agrees with that. I am merging now this patch thank you @bharanic-dev -- This is an

[GitHub] [pulsar] eolivelli commented on a change in pull request #10008: [PIP-82] [pulsar-broker] Add a task to publish resource usage to a topic

2021-04-09 Thread GitBox
eolivelli commented on a change in pull request #10008: URL: https://github.com/apache/pulsar/pull/10008#discussion_r610371564 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceUsageConsumer.java ## @@ -0,0 +1,39 @@ +/** + * Licensed to

  1   2   >