[GitHub] [pulsar] merlimat commented on issue #10054: [Geo-replicaiton] Subscription replication is not working across clusters

merlimat commented on issue #10054: URL: https://github.com/apache/pulsar/issues/10054#issuecomment-821778506 I took a look at the test and the issue is that by the time the consumer has acknowledged all the messages there is still no valid snapshot, therefore we cannot advance the positio

[GitHub] [pulsar] linlinnn commented on pull request #10240: [consumer] fix order guarantee for MultiTopicsConsumerImpl

linlinnn commented on pull request #10240: URL: https://github.com/apache/pulsar/pull/10240#issuecomment-821776677 CICD passed. Could you please help review if you are available? @lhotari -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [pulsar] lhotari commented on pull request #10250: Fix compilation failure in master branch

lhotari commented on pull request #10250: URL: https://github.com/apache/pulsar/pull/10250#issuecomment-821776247 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [pulsar] linlinnn commented on pull request #10240: [consumer] fix order guarantee for MultiTopicsConsumerImpl

linlinnn commented on pull request #10240: URL: https://github.com/apache/pulsar/pull/10240#issuecomment-821774944 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] linlinnn commented on pull request #10240: [consumer] fix order guarantee for MultiTopicsConsumerImpl

linlinnn commented on pull request #10240: URL: https://github.com/apache/pulsar/pull/10240#issuecomment-821773187 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] merlimat commented on pull request #6364: Creating a topic does not wait for creating cursor of replicators

merlimat commented on pull request #6364: URL: https://github.com/apache/pulsar/pull/6364#issuecomment-821771931 @codelipenghui I think there's a problem with this change. We must wait for the replicator cursors to be created before the topic is opened, otherwise we might be losing data th

[GitHub] [pulsar] lhotari commented on pull request #10201: [PIP-82] [pulsar-broker] incorporate review feedback

lhotari commented on pull request #10201: URL: https://github.com/apache/pulsar/pull/10201#issuecomment-821770427 @linlinnn @jerrypeng @codelipenghui @eolivelli @merlimat @aahmed-se I created #10250 to fix the compilation issues in master branch. -- This is an automated message from the

[GitHub] [pulsar] lhotari opened a new pull request #10250: Fix compilation failure in master branch

lhotari opened a new pull request #10250: URL: https://github.com/apache/pulsar/pull/10250 ### Motivation Compiling master branch fails with errors in ResourceGroupServiceTest and ResourceGroupUsageAggregationTest. This is possibly a merge conflict in #10201. ### Modificati

[GitHub] [pulsar] linlinnn commented on pull request #10201: [PIP-82] [pulsar-broker] incorporate review feedback

linlinnn commented on pull request #10201: URL: https://github.com/apache/pulsar/pull/10201#issuecomment-821764293 @merlimat PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [pulsar] linlinnn edited a comment on pull request #10201: [PIP-82] [pulsar-broker] incorporate review feedback

linlinnn edited a comment on pull request #10201: URL: https://github.com/apache/pulsar/pull/10201#issuecomment-821760369 Seems should remove this [line](https://github.com/apache/pulsar/blob/1cc782f88b8934e1c636d45d9f6fc25311ebe260/pulsar-broker/src/test/java/org/apache/pulsar/broker/resou

[GitHub] [pulsar] linlinnn edited a comment on pull request #10201: [PIP-82] [pulsar-broker] incorporate review feedback

linlinnn edited a comment on pull request #10201: URL: https://github.com/apache/pulsar/pull/10201#issuecomment-821760369 should remove this [line](https://github.com/apache/pulsar/blob/1cc782f88b8934e1c636d45d9f6fc25311ebe260/pulsar-broker/src/test/java/org/apache/pulsar/broker/resourcegro

[GitHub] [pulsar] linlinnn edited a comment on pull request #10201: [PIP-82] [pulsar-broker] incorporate review feedback

linlinnn edited a comment on pull request #10201: URL: https://github.com/apache/pulsar/pull/10201#issuecomment-821760369 forget remove this [line](https://github.com/apache/pulsar/blob/1cc782f88b8934e1c636d45d9f6fc25311ebe260/pulsar-broker/src/test/java/org/apache/pulsar/broker/resourcegro

[GitHub] [pulsar] linlinnn edited a comment on pull request #10201: [PIP-82] [pulsar-broker] incorporate review feedback

linlinnn edited a comment on pull request #10201: URL: https://github.com/apache/pulsar/pull/10201#issuecomment-821760369 forget remove this [line](https://github.com/apache/pulsar/blob/1cc782f88b8934e1c636d45d9f6fc25311ebe260/pulsar-broker/src/test/java/org/apache/pulsar/broker/resourcegro

[GitHub] [pulsar] linlinnn commented on pull request #10201: [PIP-82] [pulsar-broker] incorporate review feedback

linlinnn commented on pull request #10201: URL: https://github.com/apache/pulsar/pull/10201#issuecomment-821760369 forget remove this line ` this.conf.setResourceUsageTransportPublishTopicName(INTERNAL_TOPIC);` -- This is an automated message from the Apache Git Service. To res

[GitHub] [pulsar] linlinnn commented on pull request #10201: [PIP-82] [pulsar-broker] incorporate review feedback

linlinnn commented on pull request #10201: URL: https://github.com/apache/pulsar/pull/10201#issuecomment-821759712  -- This is an automated message from the Apache Git Service.

[GitHub] [pulsar] linlinnn commented on pull request #10201: [PIP-82] [pulsar-broker] incorporate review feedback

linlinnn commented on pull request #10201: URL: https://github.com/apache/pulsar/pull/10201#issuecomment-821759638 @jerrypeng CICD seems broken for this merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [pulsar] linlinnn commented on a change in pull request #10240: [consumer] fix order guarantee for MultiTopicsConsumerImpl

linlinnn commented on a change in pull request #10240: URL: https://github.com/apache/pulsar/pull/10240#discussion_r615200762 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ## @@ -407,21 +407,19 @@ public UnAckedMessageTracker getUnAc

[GitHub] [pulsar] linlinnn commented on pull request #10240: [consumer] fix order guarantee for MultiTopicsConsumerImpl

linlinnn commented on pull request #10240: URL: https://github.com/apache/pulsar/pull/10240#issuecomment-821753181 Emm.. any feedback : ) @eolivelli @MarvinCai @merlimat @315157973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [pulsar] linlinnn commented on pull request #10160: [ISSUE 10153]fix time unit ns -> ms

linlinnn commented on pull request #10160: URL: https://github.com/apache/pulsar/pull/10160#issuecomment-821750234 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] linlinnn commented on pull request #10120: [doc] Support generate document automatically for pulsar-perf

linlinnn commented on pull request #10120: URL: https://github.com/apache/pulsar/pull/10120#issuecomment-821750181 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[pulsar] branch master updated: PIP-82 incorporate review feedback (#10201)

This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 1cc782f PIP-82 incorporate review feedback (

[GitHub] [pulsar] jerrypeng merged pull request #10201: [PIP-82] [pulsar-broker] incorporate review feedback

jerrypeng merged pull request #10201: URL: https://github.com/apache/pulsar/pull/10201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [pulsar] devinbost commented on pull request #10217: Adding more permits debug statements to better diagnose permit issues

devinbost commented on pull request #10217: URL: https://github.com/apache/pulsar/pull/10217#issuecomment-821724858 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] merlimat commented on pull request #10164: [Issue 10161] Fix missing LoggerFactoryPtr type.

merlimat commented on pull request #10164: URL: https://github.com/apache/pulsar/pull/10164#issuecomment-821692968 @astifter Yes, the PR should be targeting master. Once it's merged then it will be cherry picked for on the 2.7 branch -- This is an automated message from the Apache Git Se

[pulsar] branch master updated: [Testing] Speed up execution of flaky test group and improve test coverage of test listeners (#10249)

This is an automated email from the ASF dual-hosted git repository. aahmed pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 52b7059 [Testing] Speed up execution of flaky t

[GitHub] [pulsar] aahmed-se merged pull request #10249: [Testing] Speed up execution of flaky test group and improve test coverage of test listeners

aahmed-se merged pull request #10249: URL: https://github.com/apache/pulsar/pull/10249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [pulsar] lhotari commented on pull request #10249: [Testing] Speed up execution of flaky test group and improve test coverage of test listeners

lhotari commented on pull request #10249: URL: https://github.com/apache/pulsar/pull/10249#issuecomment-821524501 [Integration test builds suddenly broke](https://github.com/apache/pulsar/pull/10249/checks?check_run_id=2364929547#step:12:343) since building the docker image tries to downlo

[GitHub] [pulsar] lhotari commented on a change in pull request #10249: [Testing] Speed up execution of flaky test group and improve test coverage of test listeners

lhotari commented on a change in pull request #10249: URL: https://github.com/apache/pulsar/pull/10249#discussion_r615050093 ## File path: buildtools/pom.xml ## @@ -44,6 +44,7 @@ 7.3.0 3.11 3.2.4 +myExcludedGroup Review comment: I removed it. :) -

[GitHub] [pulsar] lhotari commented on a change in pull request #10249: [Testing] Speed up execution of flaky test group and improve test coverage of test listeners

lhotari commented on a change in pull request #10249: URL: https://github.com/apache/pulsar/pull/10249#discussion_r615049420 ## File path: buildtools/pom.xml ## @@ -44,6 +44,7 @@ 7.3.0 3.11 3.2.4 +myExcludedGroup Review comment: I had some doubts so t

[GitHub] [pulsar] lhotari commented on a change in pull request #10249: [Testing] Speed up execution of flaky test group and improve test coverage of test listeners

lhotari commented on a change in pull request #10249: URL: https://github.com/apache/pulsar/pull/10249#discussion_r615048726 ## File path: buildtools/pom.xml ## @@ -44,6 +44,7 @@ 7.3.0 3.11 3.2.4 +myExcludedGroup Review comment: it's just to test with

[GitHub] [pulsar] aahmed-se commented on a change in pull request #10249: [Testing] Speed up execution of flaky test group and improve test coverage of test listeners

aahmed-se commented on a change in pull request #10249: URL: https://github.com/apache/pulsar/pull/10249#discussion_r615048384 ## File path: buildtools/pom.xml ## @@ -44,6 +44,7 @@ 7.3.0 3.11 3.2.4 +myExcludedGroup Review comment: what is this group a

[GitHub] [pulsar] lhotari commented on pull request #10249: [Testing] Speed up execution of flaky test group and improve test coverage of test listeners

lhotari commented on pull request #10249: URL: https://github.com/apache/pulsar/pull/10249#issuecomment-821417610 @aahmed-se @merlimat @sijie @eolivelli Please review. This speeds up execution of `CI - Unit - Brokers - Other`/`BROKER_FLAKY` test group (reduces to about 45 mins). -- This

[GitHub] [pulsar] lhotari opened a new pull request #10249: [Testing] Speed up execution of flaky test group and improve test coverage of test listeners

lhotari opened a new pull request #10249: URL: https://github.com/apache/pulsar/pull/10249 ### Motivation Since the improvements in tests have been made to reduce resource leaks, it is now possible to remove `-DtestReuseFork=false` parameter used in the execution of the BROKER_FLAKY

[pulsar] branch master updated (8128b88 -> 87ebe80)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 8128b88 [Broker] Fix replicated subscriptions related LightProto issues (#10247) add 87ebe80 [C++] Fix use-af

[GitHub] [pulsar] merlimat merged pull request #10220: [C++] Fix use-after-free undefined behavior due to object lifetime problem

merlimat merged pull request #10220: URL: https://github.com/apache/pulsar/pull/10220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [pulsar] merlimat merged pull request #10247: [Broker] Fix replicated subscriptions related LightProto issues

merlimat merged pull request #10247: URL: https://github.com/apache/pulsar/pull/10247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[pulsar] branch master updated (152d1e6 -> 8128b88)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 152d1e6 Shutdown Broker gracefully, but forcefully after brokerShutdownTimeoutMs (#10199) add 8128b88 [Broker

[GitHub] [pulsar] ravi-vaidyanathan commented on a change in pull request #10218: [PIP-82] [pulsar-broker] CRUD support for ResourceGroup

ravi-vaidyanathan commented on a change in pull request #10218: URL: https://github.com/apache/pulsar/pull/10218#discussion_r614957049 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/ResourceGroup.java ## @@ -0,0 +1,74 @@ +/** + * Licensed to t

[GitHub] [pulsar] ravi-vaidyanathan commented on a change in pull request #10218: [PIP-82] [pulsar-broker] CRUD support for ResourceGroup

ravi-vaidyanathan commented on a change in pull request #10218: URL: https://github.com/apache/pulsar/pull/10218#discussion_r614956929 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/cache/ConfigurationCacheService.java ## @@ -101,6 +104,13 @@ public

[pulsar] branch master updated: Shutdown Broker gracefully, but forcefully after brokerShutdownTimeoutMs (#10199)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 152d1e6 Shutdown Broker gracefully, but forcefu

[GitHub] [pulsar] merlimat merged pull request #10199: Shutdown Broker gracefully, but forcefully after brokerShutdownTimeoutMs

merlimat merged pull request #10199: URL: https://github.com/apache/pulsar/pull/10199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [pulsar] eolivelli commented on a change in pull request #10248: Java Client: MessageImpl - ensure that AutoConsumeSchema downloaded the schema before decoding the payload

eolivelli commented on a change in pull request #10248: URL: https://github.com/apache/pulsar/pull/10248#discussion_r614942131 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@ -1707,9 +1707,15 @@ protected void handleGetTopicsOfN

[GitHub] [pulsar] eolivelli opened a new pull request #10248: Java Client: MessageImpl - ensure that AutoConsumeSchema downloaded the schema before decoding the payload

eolivelli opened a new pull request #10248: URL: https://github.com/apache/pulsar/pull/10248 ### Motivation I saw this problem while developing integration tests for GenericObject + KeyValue with SEPARATED KeyValueEncoding. I have extracted this patch in order to make it clearer,

[GitHub] [pulsar] lhotari edited a comment on issue #10054: [Geo-replicaiton] Subscription replication is not working across clusters

lhotari edited a comment on issue #10054: URL: https://github.com/apache/pulsar/issues/10054#issuecomment-821239271 @merlimat do you have a chance to take a look at this issue and answer [the question above](https://github.com/apache/pulsar/issues/10054#issuecomment-87125)? thanks

[GitHub] [pulsar] lhotari edited a comment on issue #10054: [Geo-replicaiton] Subscription replication is not working across clusters

lhotari edited a comment on issue #10054: URL: https://github.com/apache/pulsar/issues/10054#issuecomment-821239271 @merlimat do you have a chance to take a look at this issue and answer [the question above](https://github.com/apache/pulsar/issues/10054#issuecomment-87125)? thanks

[GitHub] [pulsar] freeznet commented on pull request #8668: [pulsar-io] Support authentication on debezium connector

freeznet commented on pull request #8668: URL: https://github.com/apache/pulsar/pull/8668#issuecomment-821239060 @sijie I agree with your thought that try to inherit the pulsar service URL and auth configs from the function worker. But I dont think we should expose them to `Context`, which

[GitHub] [pulsar] lhotari commented on issue #10054: [Geo-replicaiton] Subscription replication is not working across clusters

lhotari commented on issue #10054: URL: https://github.com/apache/pulsar/issues/10054#issuecomment-821239271 @merlimat do you have a chance to take a look at this issue and answer [the question above](https://github.com/apache/pulsar/issues/10054#issuecomment-87125)? thanks the

[GitHub] [pulsar] lhotari commented on pull request #10247: [Broker] Fix replicated subscriptions related LightProto issues

lhotari commented on pull request #10247: URL: https://github.com/apache/pulsar/pull/10247#issuecomment-821236551 @merlimat Please review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [pulsar] lhotari opened a new pull request #10247: [Broker] Fix replicated subscriptions related LightProto issues

lhotari opened a new pull request #10247: URL: https://github.com/apache/pulsar/pull/10247 ### Motivation While investigating the issue about geo replication, #10054 , I came across some issues with handling of some deserialized replicated subscriptions related messages. LightProto

[GitHub] [pulsar] tuteng commented on pull request #10120: [doc] Support generate document automatically for pulsar-perf

tuteng commented on pull request #10120: URL: https://github.com/apache/pulsar/pull/10120#issuecomment-821220836 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] eolivelli edited a comment on pull request #10215: [Client|Proxy] Create copy of response messages before passing to other thread via CompletableFuture

eolivelli edited a comment on pull request #10215: URL: https://github.com/apache/pulsar/pull/10215#issuecomment-821215839 @sijie @merlimat I have this integration test that fails due to this problem, I believe there is no strong need to add a test here https://github.com/apache/pulsar/

[GitHub] [pulsar] eolivelli commented on pull request #10215: [Client|Proxy] Create copy of response messages before passing to other thread via CompletableFuture

eolivelli commented on pull request #10215: URL: https://github.com/apache/pulsar/pull/10215#issuecomment-821215839 @sijie I have this integration test that fails due to this problem, I believe there is no strong need to add a test here https://github.com/apache/pulsar/pull/10211/checks?

[GitHub] [pulsar] eolivelli commented on pull request #10052: Add a JSON RecordBuilder to the GenericJsonSchema

eolivelli commented on pull request #10052: URL: https://github.com/apache/pulsar/pull/10052#issuecomment-821211505 @sijie as you told that you are okay with this patch, can you please click on "Approve" ? otherwise we cannot merge it -- This is an automated message from the Apac

[GitHub] [pulsar] klwilson227 commented on pull request #10246: Add support for deduplication testing

klwilson227 commented on pull request #10246: URL: https://github.com/apache/pulsar/pull/10246#issuecomment-821209966 Merlimat, RE the consumer side, I'm sure the consumer side would also benefit as well for a possible demo/software acceptance level validation. However, in my particular us

[GitHub] [pulsar] lhotari commented on pull request #10215: [Client|Proxy] Create copy of response messages before passing to other thread via CompletableFuture

lhotari commented on pull request #10215: URL: https://github.com/apache/pulsar/pull/10215#issuecomment-821203160 @merlimat I have revisited the change. PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [pulsar] lhotari commented on pull request #10215: Fix IllegalReferenceCountException while getting schema

lhotari commented on pull request #10215: URL: https://github.com/apache/pulsar/pull/10215#issuecomment-821200821 > Can we add test cases? @sijie Do you have a proposal of how to test this? -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [pulsar] lhotari commented on pull request #10215: Fix IllegalReferenceCountException while getting schema

lhotari commented on pull request #10215: URL: https://github.com/apache/pulsar/pull/10215#issuecomment-821200495 > We can simply "clone" the CommandGetSchemaResponse inside `handleGetSchemaResponse`, this way we decode the ByteBuf and we return a safe object to the caller @eolivell

[GitHub] [pulsar] klwilson227 commented on a change in pull request #10246: Add support for deduplication testing

klwilson227 commented on a change in pull request #10246: URL: https://github.com/apache/pulsar/pull/10246#discussion_r614861660 ## File path: pulsar-testclient/pom.xml ## @@ -94,6 +94,13 @@ org.hdrhistogram HdrHistogram

[GitHub] [pulsar] lhotari commented on pull request #10199: Shutdown Broker gracefully, but forcefully after brokerShutdownTimeoutMs

lhotari commented on pull request #10199: URL: https://github.com/apache/pulsar/pull/10199#issuecomment-821192431 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [pulsar] mwmitchell commented on issue #3630: Broker can not respond to client requests

mwmitchell commented on issue #3630: URL: https://github.com/apache/pulsar/issues/3630#issuecomment-821189973 Was this fix ever applied to the 2.6.3 release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [pulsar] eolivelli commented on pull request #10211: Sink unwrap internal AutoConsumeSchema and allow to handle topics with KeyValue schema

eolivelli commented on pull request #10211: URL: https://github.com/apache/pulsar/pull/10211#issuecomment-821186807 @codelipenghui I finally figured out what was wrong in the integration test. now it passes locally. Can you please take a final look ? -- This is an automated message fr

[GitHub] [pulsar] eolivelli commented on pull request #10211: Sink unwrap internal AutoConsumeSchema and allow to handle topics with KeyValue schema

eolivelli commented on pull request #10211: URL: https://github.com/apache/pulsar/pull/10211#issuecomment-821167331 I am adding debug in order to see what's wrong in CI. I will revert all of the debug code when I see CI green -- This is an automated message from the Apache Git Service.

[GitHub] [pulsar] kenbaev commented on issue #10171: Broker fails. Log contains only failed metrics requests (500 error code)

kenbaev commented on issue #10171: URL: https://github.com/apache/pulsar/issues/10171#issuecomment-821123968 Broker crashes again On the client side i see `"ERROR":"Short read when reading frame size: read tcp 10.247.144.5:41024->10.96.137.199:6650: i/o timeout"` `"MESSAGE":"Faile

[GitHub] [pulsar] 315157973 commented on pull request #9598: Make `LocalPolicies` immutable to avoid concurrent modify inconsistent.

315157973 commented on pull request #9598: URL: https://github.com/apache/pulsar/pull/9598#issuecomment-821066752 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [pulsar] lhotari commented on pull request #10199: Shutdown Broker gracefully, but forcefully after brokerShutdownTimeoutMs

lhotari commented on pull request #10199: URL: https://github.com/apache/pulsar/pull/10199#issuecomment-821048730 > The approach LGTM. Just a couple of questions on the await termination @merlimat Thank you for your review and good points about await termination. Please ignore so

[GitHub] [pulsar] lhotari commented on a change in pull request #10199: Shutdown Broker gracefully, but forcefully after brokerShutdownTimeoutMs

lhotari commented on a change in pull request #10199: URL: https://github.com/apache/pulsar/pull/10199#discussion_r614695134 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java ## @@ -480,6 +487,20 @@ public void close() throws PulsarServerExc

[GitHub] [pulsar] lhotari commented on a change in pull request #10199: Shutdown Broker gracefully, but forcefully after brokerShutdownTimeoutMs

lhotari commented on a change in pull request #10199: URL: https://github.com/apache/pulsar/pull/10199#discussion_r614694023 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java ## @@ -480,6 +487,20 @@ public void close() throws PulsarServerExc

[GitHub] [pulsar] lhotari commented on a change in pull request #10199: Shutdown Broker gracefully, but forcefully after brokerShutdownTimeoutMs

lhotari commented on a change in pull request #10199: URL: https://github.com/apache/pulsar/pull/10199#discussion_r614691047 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/GracefulExecutorServicesShutdownHandler.java ## @@ -0,0 +1,116 @@ +/** + * Li

[GitHub] [pulsar] lhotari commented on a change in pull request #10199: Shutdown Broker gracefully, but forcefully after brokerShutdownTimeoutMs

lhotari commented on a change in pull request #10199: URL: https://github.com/apache/pulsar/pull/10199#discussion_r614690537 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java ## @@ -480,6 +487,20 @@ public void close() throws PulsarServerExc

[GitHub] [pulsar] linlinnn commented on pull request #10120: [doc] Support generate document automatically for pulsar-perf

linlinnn commented on pull request #10120: URL: https://github.com/apache/pulsar/pull/10120#issuecomment-821033500 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] devinbost commented on pull request #10217: Adding more permits debug statements to better diagnose permit issues

devinbost commented on pull request #10217: URL: https://github.com/apache/pulsar/pull/10217#issuecomment-821012634 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar-client-go] NessGo opened a new issue #511: zero queue supoort

NessGo opened a new issue #511: URL: https://github.com/apache/pulsar-client-go/issues/511 **Is your feature request related to a problem? Please describe.** support zero queue like java client : pull the next messages when the last messages has been handled. -- This is an au

[GitHub] [pulsar] linlinnn removed a comment on pull request #10160: [ISSUE 10153]fix time unit ns -> ms

linlinnn removed a comment on pull request #10160: URL: https://github.com/apache/pulsar/pull/10160#issuecomment-820632681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. F

[GitHub] [pulsar] linlinnn commented on pull request #10160: [ISSUE 10153]fix time unit ns -> ms

linlinnn commented on pull request #10160: URL: https://github.com/apache/pulsar/pull/10160#issuecomment-820985944 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] eolivelli commented on pull request #10215: Fix IllegalReferenceCountException while getting schema

eolivelli commented on pull request #10215: URL: https://github.com/apache/pulsar/pull/10215#issuecomment-820970570 I have another idea (that I am testing locally) We can simply "clone" the CommandGetSchemaResponse inside `handleGetSchemaResponse`, this way we decode the ByteBuf and

[GitHub] [pulsar] linlinnn commented on pull request #10240: [consumer] fix order guarantee for MultiTopicsConsumerImpl

linlinnn commented on pull request #10240: URL: https://github.com/apache/pulsar/pull/10240#issuecomment-820965281 @eolivelli @codelipenghui @lhotari Please help review this PR, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[pulsar] branch master updated (db99f74 -> 3d6e480)

This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from db99f74 typo: mismatch in retention size examples. (#10245) add 3d6e480 Add preciseTopicPublishRateLimiterE

[GitHub] [pulsar] eolivelli merged pull request #10216: Add preciseTopicPublishRateLimiterEnable to broker.conf

eolivelli merged pull request #10216: URL: https://github.com/apache/pulsar/pull/10216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[pulsar] branch master updated (743777a -> db99f74)

This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 743777a remove unnessary bundle listener triger when topic lookup (#10126) add db99f74 typo: mismatch in r

[GitHub] [pulsar] eolivelli merged pull request #10245: [docs] Fix mismatch in retention size examples.

eolivelli merged pull request #10245: URL: https://github.com/apache/pulsar/pull/10245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [pulsar] linlinnn removed a comment on pull request #10120: [doc] Support generate document automatically for pulsar-perf

linlinnn removed a comment on pull request #10120: URL: https://github.com/apache/pulsar/pull/10120#issuecomment-820556190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. F