[pulsar] branch branch-2.6 updated: Disallow parsing of token with none signature in authenticateToken (#9172)

2021-05-25 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch branch-2.6 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.6 by this push: new 67e7e0c Disallow parsing of token wi

[pulsar] branch master updated (c48b285 -> e0fef93)

2021-05-25 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from c48b285 [Doc] Add descriptions for managed cursor acknowledgment state (#10695) add e0fef93 Add 2.7.3 docs

[GitHub] [pulsar] eolivelli closed issue #10665: [Website + Doc] Generate 2.7.3 docs

2021-05-25 Thread GitBox
eolivelli closed issue #10665: URL: https://github.com/apache/pulsar/issues/10665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [pulsar] eolivelli merged pull request #10666: Add 2.7.3 docs for repo

2021-05-25 Thread GitBox
eolivelli merged pull request #10666: URL: https://github.com/apache/pulsar/pull/10666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [pulsar] linlinnn opened a new pull request #10710: Geo rp conf

2021-05-25 Thread GitBox
linlinnn opened a new pull request #10710: URL: https://github.com/apache/pulsar/pull/10710 Fixes #10693 ### Motivation use unify configuration from remote cluster for geo-replicator, and remove the former logic that using the local cluster's configuration. -- This is an automa

[GitHub] [pulsar] eolivelli commented on a change in pull request #10708: On multi-topic consumer, we shouldn't keep checking the partitioned metadata

2021-05-25 Thread GitBox
eolivelli commented on a change in pull request #10708: URL: https://github.com/apache/pulsar/pull/10708#discussion_r639411467 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java ## @@ -955,7 +955,7 @@ private void doSubscribeTo

[GitHub] [pulsar] wenbingshen opened a new pull request #10709: MINOR: Add error message to setMaxPendingMessagesAcrossPartitions

2021-05-25 Thread GitBox
wenbingshen opened a new pull request #10709: URL: https://github.com/apache/pulsar/pull/10709 ### Motivation When maxPendingMessagesAcrossPartitions is less than maxPendingMessages, an error message will be thrown: null ### Modifications return "maxPendingMessagesAcrossPartiti

[GitHub] [pulsar] merlimat opened a new pull request #10708: On multi-topic consumer, we shouldn't keep checking the partitioned metadata

2021-05-25 Thread GitBox
merlimat opened a new pull request #10708: URL: https://github.com/apache/pulsar/pull/10708 ### Motivation When using a multi-topic consumer, either through the regex or by passing a list of topics, we are ending up checking the partitioned topic metadata every 1 min, even if the to

[pulsar] branch master updated (f355272 -> c48b285)

2021-05-25 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from f355272 Async the method onManagedLedgerLastLedgerInitialize for ManagedLedgerInterceptor (#10706) add c48b285

[GitHub] [pulsar] Anonymitaet merged pull request #10695: [Doc] Add descriptions for managed cursor acknowledgment state

2021-05-25 Thread GitBox
Anonymitaet merged pull request #10695: URL: https://github.com/apache/pulsar/pull/10695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10695: [Doc] Add descriptions for managed cursor acknowledgment state

2021-05-25 Thread GitBox
Anonymitaet commented on a change in pull request #10695: URL: https://github.com/apache/pulsar/pull/10695#discussion_r639380997 ## File path: site2/docs/reference-metrics.md ## @@ -260,6 +260,26 @@ All the managedLedger metrics are labelled with the following labels: | pulsa

[GitHub] [pulsar] wuzhanpeng commented on pull request #10707: force to refresh partition metadata info

2021-05-25 Thread GitBox
wuzhanpeng commented on pull request #10707: URL: https://github.com/apache/pulsar/pull/10707#issuecomment-848431085 @codelipenghui @zhaijack @sijie @hangc0276 @eolivelli @merlimat The above PR modification only affects the result of fetching partition metadata, and has no effect on

[pulsar] branch master updated (6bc9e74 -> f355272)

2021-05-25 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 6bc9e74 [pulsar-proxy]Adjust the location of logger.debug (#10684) add f355272 Async the method onManagedLedge

[GitHub] [pulsar] merlimat merged pull request #10706: Async the method onManagedLedgerLastLedgerInitialize for ManagedLedgerInterceptor

2021-05-25 Thread GitBox
merlimat merged pull request #10706: URL: https://github.com/apache/pulsar/pull/10706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [pulsar] merlimat closed issue #10703: Managed ledger can't been initialized

2021-05-25 Thread GitBox
merlimat closed issue #10703: URL: https://github.com/apache/pulsar/issues/10703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please co

[GitHub] [pulsar] hangc0276 commented on a change in pull request #10695: [Doc] Add descriptions for managed cursor acknowledgment state

2021-05-25 Thread GitBox
hangc0276 commented on a change in pull request #10695: URL: https://github.com/apache/pulsar/pull/10695#discussion_r639376566 ## File path: site2/docs/reference-metrics.md ## @@ -260,6 +260,26 @@ All the managedLedger metrics are labelled with the following labels: | pulsar_

[GitHub] [pulsar] wolfstudy commented on pull request #10666: Add 2.7.3 docs for repo

2021-05-25 Thread GitBox
wolfstudy commented on pull request #10666: URL: https://github.com/apache/pulsar/pull/10666#issuecomment-848425322 > > The 2.7.3 has not yet been released, so we can temporarily use it as a historical document. After 2.7.3 is released, we will show it to users as the main version of the d

[GitHub] [pulsar] RobertIndie commented on pull request #10685: [Broker] Add multi roles support for authentication and authorization

2021-05-25 Thread GitBox
RobertIndie commented on pull request #10685: URL: https://github.com/apache/pulsar/pull/10685#issuecomment-848424496 Thanks @cckellogg. I have fixed some comments. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [pulsar] codelipenghui commented on a change in pull request #10706: Async the method onManagedLedgerLastLedgerInitialize for ManagedLedgerInterceptor

2021-05-25 Thread GitBox
codelipenghui commented on a change in pull request #10706: URL: https://github.com/apache/pulsar/pull/10706#discussion_r639373340 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/intercept/ManagedLedgerInterceptorImpl.java ## @@ -80,31 +80,47 @@ public void

[GitHub] [pulsar] RobertIndie commented on a change in pull request #10685: [Broker] Add multi roles support for authentication and authorization

2021-05-25 Thread GitBox
RobertIndie commented on a change in pull request #10685: URL: https://github.com/apache/pulsar/pull/10685#discussion_r639372972 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/OneStageAuthenticationState.java ## @@ -35,20 +38,33 @@ pu

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10650: [Transactionn] Transaction admin api component in topic status

2021-05-25 Thread GitBox
Anonymitaet commented on a change in pull request #10650: URL: https://github.com/apache/pulsar/pull/10650#discussion_r639370981 ## File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Transactions.java ## @@ -71,4 +73,21 @@ */ Completable

[GitHub] [pulsar] oldthreefeng commented on issue #10692: pulsar-bookie and pulsar-broker CrashLoopBackOff in kubernetes

2021-05-25 Thread GitBox
oldthreefeng commented on issue #10692: URL: https://github.com/apache/pulsar/issues/10692#issuecomment-848420386 @zymap so re run the `pulsar-bookie-init` job can fix the problem? BTW, in our test env, it Crash in the middle night , no one clean up the data directory. -- This

[GitHub] [pulsar] wuzhanpeng opened a new pull request #10707: force to refresh partition metadata info

2021-05-25 Thread GitBox
wuzhanpeng opened a new pull request #10707: URL: https://github.com/apache/pulsar/pull/10707 May resloves #10687 ## Motivation When I was trying to solve #10687, I found that the partitioned-topic's metadata may not be updated timely. When I sent a create-topic request to broke

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10653: [Transaction] Transaction admin api get coordinator internal stats.

2021-05-25 Thread GitBox
Anonymitaet commented on a change in pull request #10653: URL: https://github.com/apache/pulsar/pull/10653#discussion_r639363500 ## File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Transactions.java ## @@ -39,4 +40,14 @@ */ Completable

[GitHub] [pulsar] congbobo184 edited a comment on pull request #10650: [Transactionn] Transaction admin api component in topic status

2021-05-25 Thread GitBox
congbobo184 edited a comment on pull request #10650: URL: https://github.com/apache/pulsar/pull/10650#issuecomment-848412059 @Anonymitaet please review doc thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [pulsar] congbobo184 commented on pull request #10701: [Transaction] Transaction admin api get slow transaction metadata.

2021-05-25 Thread GitBox
congbobo184 commented on pull request #10701: URL: https://github.com/apache/pulsar/pull/10701#issuecomment-848412235 @Anonymitaet please review doc thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [pulsar] congbobo184 commented on pull request #10650: [Transactionn] Transaction admin api component in topic status

2021-05-25 Thread GitBox
congbobo184 commented on pull request #10650: URL: https://github.com/apache/pulsar/pull/10650#issuecomment-848412059 @Anonymitaet please review doc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] congbobo184 commented on pull request #10653: [Transaction] Transaction admin api get coordinator internal stats.

2021-05-25 Thread GitBox
congbobo184 commented on pull request #10653: URL: https://github.com/apache/pulsar/pull/10653#issuecomment-848412167 @Anonymitaet please review doc thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #10706: Async the method onManagedLedgerLastLedgerInitialize for ManagedLedgerInterceptor

2021-05-25 Thread GitBox
BewareMyPower commented on a change in pull request #10706: URL: https://github.com/apache/pulsar/pull/10706#discussion_r639361210 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/intercept/ManagedLedgerInterceptorImpl.java ## @@ -80,31 +80,47 @@ public void

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #10706: Async the method onManagedLedgerLastLedgerInitialize for ManagedLedgerInterceptor

2021-05-25 Thread GitBox
BewareMyPower commented on a change in pull request #10706: URL: https://github.com/apache/pulsar/pull/10706#discussion_r639358859 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/intercept/ManagedLedgerInterceptorImpl.java ## @@ -80,31 +80,47 @@ public void

[GitHub] [pulsar] codelipenghui commented on a change in pull request #10706: Async the method onManagedLedgerLastLedgerInitialize for ManagedLedgerInterceptor

2021-05-25 Thread GitBox
codelipenghui commented on a change in pull request #10706: URL: https://github.com/apache/pulsar/pull/10706#discussion_r639358396 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/intercept/ManagedLedgerInterceptorImpl.java ## @@ -80,31 +80,47 @@ public void

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #10706: Async the method onManagedLedgerLastLedgerInitialize for ManagedLedgerInterceptor

2021-05-25 Thread GitBox
BewareMyPower commented on a change in pull request #10706: URL: https://github.com/apache/pulsar/pull/10706#discussion_r639357679 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/intercept/ManagedLedgerInterceptorImpl.java ## @@ -80,31 +80,47 @@ public void

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #10706: Async the method onManagedLedgerLastLedgerInitialize for ManagedLedgerInterceptor

2021-05-25 Thread GitBox
BewareMyPower commented on a change in pull request #10706: URL: https://github.com/apache/pulsar/pull/10706#discussion_r639357679 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/intercept/ManagedLedgerInterceptorImpl.java ## @@ -80,31 +80,47 @@ public void

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #10706: Async the method onManagedLedgerLastLedgerInitialize for ManagedLedgerInterceptor

2021-05-25 Thread GitBox
BewareMyPower commented on a change in pull request #10706: URL: https://github.com/apache/pulsar/pull/10706#discussion_r639357679 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/intercept/ManagedLedgerInterceptorImpl.java ## @@ -80,31 +80,47 @@ public void

[GitHub] [pulsar] jiazhai commented on pull request #10685: [Broker] Add multi roles support for authentication and authorization

2021-05-25 Thread GitBox
jiazhai commented on pull request #10685: URL: https://github.com/apache/pulsar/pull/10685#issuecomment-848391836 @cckellogg Thanks for the review. And @RobertIndie, Would you please help to handle the comments of @cckellogg? Regarding split into 2 PRs, From my view, the current PR work

[GitHub] [pulsar] merlimat commented on a change in pull request #10706: Async the method onManagedLedgerLastLedgerInitialize for ManagedLedgerInterceptor

2021-05-25 Thread GitBox
merlimat commented on a change in pull request #10706: URL: https://github.com/apache/pulsar/pull/10706#discussion_r639338576 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java ## @@ -355,9 +355,17 @@ public void operationCompl

[GitHub] [pulsar] merlimat commented on a change in pull request #10706: Async the method onManagedLedgerLastLedgerInitialize for ManagedLedgerInterceptor

2021-05-25 Thread GitBox
merlimat commented on a change in pull request #10706: URL: https://github.com/apache/pulsar/pull/10706#discussion_r639337156 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/intercept/ManagedLedgerInterceptorImpl.java ## @@ -80,31 +82,47 @@ public void onMan

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10695: [Doc] Add descriptions for managed cursor acknowledgment state

2021-05-25 Thread GitBox
Anonymitaet commented on a change in pull request #10695: URL: https://github.com/apache/pulsar/pull/10695#discussion_r639336857 ## File path: site2/docs/reference-metrics.md ## @@ -260,6 +260,26 @@ All the managedLedger metrics are labelled with the following labels: | pulsa

[GitHub] [pulsar] codelipenghui opened a new pull request #10706: Async the method onManagedLedgerLastLedgerInitialize for ManagedLedgerInterceptor

2021-05-25 Thread GitBox
codelipenghui opened a new pull request #10706: URL: https://github.com/apache/pulsar/pull/10706 Fixes #10703 ### Motivation Async the method onManagedLedgerLastLedgerInitialize for ManagedLedgerInterceptor. The root cause for issue #10703 is the ManagedLedger Interceptor is

[GitHub] [pulsar] xuesongxs opened a new issue #10705: Gets the exact number of message backlog for pulsar topic subscription

2021-05-25 Thread GitBox
xuesongxs opened a new issue #10705: URL: https://github.com/apache/pulsar/issues/10705 **Is your feature request related to a problem? Please describe.** The producer's asynchronous sending interface is batch sending, and a backlog is a batch of messages. To get the number of messages i

[GitHub] [pulsar] codelipenghui commented on a change in pull request #10650: [Transactionn] Transaction admin api component in topic status

2021-05-25 Thread GitBox
codelipenghui commented on a change in pull request #10650: URL: https://github.com/apache/pulsar/pull/10650#discussion_r639309938 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTransactions.java ## @@ -84,6 +109,8 @@ void run() throws Exception

[GitHub] [pulsar] zymap commented on issue #10692: pulsar-bookie and pulsar-broker CrashLoopBackOff in kubernetes

2021-05-25 Thread GitBox
zymap commented on issue #10692: URL: https://github.com/apache/pulsar/issues/10692#issuecomment-848346982 The reason that `Invalid cookie` looks like you clean up the data directory but not reinitialize the cluster -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar-client-go] addisonj merged pull request #525: [bug] Fix reader latest position

2021-05-25 Thread GitBox
addisonj merged pull request #525: URL: https://github.com/apache/pulsar-client-go/pull/525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[pulsar-client-go] branch master updated: [bug] Fix reader latest position (#525)

2021-05-25 Thread addisonj
This is an automated email from the ASF dual-hosted git repository. addisonj pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new 07006de [bug] Fix reader latest pos

[GitHub] [pulsar] rdhabalia commented on pull request #10704: Fix NPE when filtering read entries

2021-05-25 Thread GitBox
rdhabalia commented on pull request #10704: URL: https://github.com/apache/pulsar/pull/10704#issuecomment-848248010 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[pulsar] branch master updated (a8363a3 -> 6bc9e74)

2021-05-25 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from a8363a3 [Broker] Optimize getTopicPolicies: skip unnecessarily thrown exception (#10683) add 6bc9e74 [puls

[GitHub] [pulsar] eolivelli commented on pull request #10684: [pulsar-proxy]Adjust the location of logger.debug

2021-05-25 Thread GitBox
eolivelli commented on pull request #10684: URL: https://github.com/apache/pulsar/pull/10684#issuecomment-848232647 thank you very much @mantuliu committer to master branch, it will be available on 2.8.0 -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [pulsar] eolivelli merged pull request #10684: [pulsar-proxy]Adjust the location of logger.debug

2021-05-25 Thread GitBox
eolivelli merged pull request #10684: URL: https://github.com/apache/pulsar/pull/10684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [pulsar] lhotari removed a comment on pull request #10670: [Issue 10669] Add Pulsar_GC_LOG when start broker with bin/pulsar

2021-05-25 Thread GitBox
lhotari removed a comment on pull request #10670: URL: https://github.com/apache/pulsar/pull/10670#issuecomment-848226916 Now that we are running on Java 11 for the Docker image in master branch, there's a required change related to `PULSAR_GC_LOG` . It's not currently compatible with Java

[GitHub] [pulsar] lhotari commented on pull request #10670: [Issue 10669] Add Pulsar_GC_LOG when start broker with bin/pulsar

2021-05-25 Thread GitBox
lhotari commented on pull request #10670: URL: https://github.com/apache/pulsar/pull/10670#issuecomment-848226916 Now that we are running on Java 11 for the Docker image in master branch, there's a required change related to `PULSAR_GC_LOG` . It's not currently compatible with Java 11. The

[GitHub] [pulsar] lhotari edited a comment on issue #10654: [Performance] DimensionStats implementation uses inefficient Prometheus client method CollectorRegistry.getSampleValue which is only intende

2021-05-25 Thread GitBox
lhotari edited a comment on issue #10654: URL: https://github.com/apache/pulsar/issues/10654#issuecomment-847566563 > Yes, `CollectorRegistry::getSampleValue()` can be inefficient and we can improve it but just wanted to understand performance impact. It is used to generate Prometheus stat

[pulsar] branch master updated (85effc4 -> a8363a3)

2021-05-25 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 85effc4 [Issue-10109] [admin client] Add --batch-source-config switch to the Pulsar Admin Source API (#10593)

[GitHub] [pulsar] lhotari merged pull request #10683: [Broker] Optimize getTopicPolicies: skip unnecessarily thrown exception

2021-05-25 Thread GitBox
lhotari merged pull request #10683: URL: https://github.com/apache/pulsar/pull/10683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [pulsar] lhotari commented on pull request #10683: [Broker] Optimize getTopicPolicies: skip unnecessarily thrown exception

2021-05-25 Thread GitBox
lhotari commented on pull request #10683: URL: https://github.com/apache/pulsar/pull/10683#issuecomment-848208583 Good work @michaeljmarshall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] lhotari commented on pull request #10704: Fix NPE when filtering read entries

2021-05-25 Thread GitBox
lhotari commented on pull request #10704: URL: https://github.com/apache/pulsar/pull/10704#issuecomment-848206734 Nice catch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [pulsar] david-streamlio closed issue #10269: Pulsar IO Sink errors are not bubbled up correctly

2021-05-25 Thread GitBox
david-streamlio closed issue #10269: URL: https://github.com/apache/pulsar/issues/10269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[pulsar] branch master updated: [Issue-10109] [admin client] Add --batch-source-config switch to the Pulsar Admin Source API (#10593)

2021-05-25 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 85effc4 [Issue-10109] [admin client] Add --b

[GitHub] [pulsar] jerrypeng merged pull request #10593: [Issue-10109] [admin client] Add --batch-source-config switch to the Pulsar Admin Source API

2021-05-25 Thread GitBox
jerrypeng merged pull request #10593: URL: https://github.com/apache/pulsar/pull/10593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [pulsar] jerrypeng closed issue #10109: Add --batch-source-config switch to the Pulsar Admin Source API

2021-05-25 Thread GitBox
jerrypeng closed issue #10109: URL: https://github.com/apache/pulsar/issues/10109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [pulsar] michaeljmarshall commented on pull request #10683: [Broker] Optimize getTopicPolicies: skip unnecessarily thrown exception

2021-05-25 Thread GitBox
michaeljmarshall commented on pull request #10683: URL: https://github.com/apache/pulsar/pull/10683#issuecomment-848066590 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] cckellogg commented on a change in pull request #10685: [Broker] Add multi roles support for authentication and authorization

2021-05-25 Thread GitBox
cckellogg commented on a change in pull request #10685: URL: https://github.com/apache/pulsar/pull/10685#discussion_r639000237 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/OneStageAuthenticationState.java ## @@ -35,20 +38,33 @@ publ

[GitHub] [pulsar] 315157973 closed pull request #10704: Fix NPE when filtering read entries

2021-05-25 Thread GitBox
315157973 closed pull request #10704: URL: https://github.com/apache/pulsar/pull/10704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [pulsar] 315157973 opened a new pull request #10704: Fix NPE when filtering read entries

2021-05-25 Thread GitBox
315157973 opened a new pull request #10704: URL: https://github.com/apache/pulsar/pull/10704 ### Motivation When ConcurrentOpenLongPairRangeSet does not contain any data, calling span() will throw NPE ### Modifications return null instead -- This is an automated message

[GitHub] [pulsar] hangc0276 commented on pull request #10670: [Issue 10669] Add Pulsar_GC_LOG when start broker with bin/pulsar

2021-05-25 Thread GitBox
hangc0276 commented on pull request #10670: URL: https://github.com/apache/pulsar/pull/10670#issuecomment-848044641 @Jason918 For bookie startup, it will be better to add gc log too. In my production env, i have add the gc log for broker, zookeeper and bookie. -- This is an automated mes

[GitHub] [pulsar] hangc0276 commented on pull request #10670: [Issue 10669] Add Pulsar_GC_LOG when start broker with bin/pulsar

2021-05-25 Thread GitBox
hangc0276 commented on pull request #10670: URL: https://github.com/apache/pulsar/pull/10670#issuecomment-848040912 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] hangc0276 commented on a change in pull request #10695: [Doc] Add descriptions for managed cursor acknowledgment state

2021-05-25 Thread GitBox
hangc0276 commented on a change in pull request #10695: URL: https://github.com/apache/pulsar/pull/10695#discussion_r638975554 ## File path: site2/docs/reference-metrics.md ## @@ -260,6 +260,26 @@ All the managedLedger metrics are labelled with the following labels: | pulsar_

[GitHub] [pulsar] massakam commented on a change in pull request #10696: [broker] Fix issue where StackOverflowError occurs when trying to redeliver a large number of already acked messages

2021-05-25 Thread GitBox
massakam commented on a change in pull request #10696: URL: https://github.com/apache/pulsar/pull/10696#discussion_r638971507 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java ## @@ -248,7 +249,9 @@

[pulsar] branch master updated (fa0a1c1 -> a244ed3)

2021-05-25 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from fa0a1c1 [Transaction] Transaction admin api get transaction metadata (#10690) add a244ed3 Fix issues in ad

[GitHub] [pulsar] jerrypeng merged pull request #10667: Fix issues in advanceNonDurableCursors

2021-05-25 Thread GitBox
jerrypeng merged pull request #10667: URL: https://github.com/apache/pulsar/pull/10667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [pulsar] merlimat commented on a change in pull request #10697: [fix #9640] remove `pulsar-client-admin-api` dependency : `pulsar-common`

2021-05-25 Thread GitBox
merlimat commented on a change in pull request #10697: URL: https://github.com/apache/pulsar/pull/10697#discussion_r638936244 ## File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Bookies.java ## @@ -31,12 +32,12 @@ /** * Gets the rack p

[GitHub] [pulsar] codelipenghui opened a new issue #10703: Managed ledger can't been initialized

2021-05-25 Thread GitBox
codelipenghui opened a new issue #10703: URL: https://github.com/apache/pulsar/issues/10703 **Describe the bug** All the broker can't complete the managed ledger creation, the managed ledger will in the `None` state for 1min and after 1min to reconnect to the topic, the managed ledger b

[GitHub] [pulsar] vanmeete edited a comment on issue #10702: [Pulsar IO] In Sink connector, record.getSchema(); returns null when processing from partitioned topic.

2021-05-25 Thread GitBox
vanmeete edited a comment on issue #10702: URL: https://github.com/apache/pulsar/issues/10702#issuecomment-847987078 Yes using `Sink`, I will try 2.8.0-SNAPSHOT tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [pulsar] vanmeete commented on issue #10702: [Pulsar IO] In Sink connector, record.getSchema(); returns null when processing from partitioned topic.

2021-05-25 Thread GitBox
vanmeete commented on issue #10702: URL: https://github.com/apache/pulsar/issues/10702#issuecomment-847987078 Yes using Sink, I will try 2.8.0-SNAPSHOT tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] eolivelli edited a comment on issue #10702: [Pulsar IO] In Sink connector, record.getSchema(); returns null when processing from partitioned topic.

2021-05-25 Thread GitBox
eolivelli edited a comment on issue #10702: URL: https://github.com/apache/pulsar/issues/10702#issuecomment-847977672 can you try on current 2.8.0-SNAPSHOT version ? we did lot of changes about the Schema API and this problem should not be present§ are you using `Sink` ? --

[GitHub] [pulsar] eolivelli commented on issue #10702: [Pulsar IO] In Sink connector, record.getSchema(); returns null when processing from partitioned topic.

2021-05-25 Thread GitBox
eolivelli commented on issue #10702: URL: https://github.com/apache/pulsar/issues/10702#issuecomment-847977672 can you try on current 2.8.0-SNAPSHOT version ? we did lot of changes about the Schema API and this problem should not be present -- This is an automated message from the Apa

[GitHub] [pulsar] vanmeete opened a new issue #10702: [Pulsar IO] In Sink connector, record.getSchema(); returns null when processing from partitioned topic.

2021-05-25 Thread GitBox
vanmeete opened a new issue #10702: URL: https://github.com/apache/pulsar/issues/10702 **Describe the bug** The record.getSchema(); returns null in case the sink connector is consuming from a partitioned topic. The correct schema is returned for non-partitioned topics. **To Repro

[GitHub] [pulsar] congbobo184 opened a new pull request #10701: [Transaction] Transaction admin api get slow transaction metadata.

2021-05-25 Thread GitBox
congbobo184 opened a new pull request #10701: URL: https://github.com/apache/pulsar/pull/10701 ## Motivation Transaction add admin api `getSlowTransactionMetadataByCoordinatorId` Transaction add admin api `getSlowTransactionMetadata` ## implement use `getTransactionMetadata`

[GitHub] [pulsar] congbobo184 commented on a change in pull request #10650: [Transactionn] Transaction admin api component in topic status

2021-05-25 Thread GitBox
congbobo184 commented on a change in pull request #10650: URL: https://github.com/apache/pulsar/pull/10650#discussion_r638840777 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v3/Transactions.java ## @@ -55,6 +55,55 @@ public void getCoordinatorStatus

[GitHub] [pulsar] eolivelli opened a new pull request #10700: AutoConsumeSchema: use decode(payload, schemaversion)

2021-05-25 Thread GitBox
eolivelli opened a new pull request #10700: URL: https://github.com/apache/pulsar/pull/10700 In `AutoConsumeSchema.decode `we should proxy the call to "`decode(payload, schemaversion)`" correctly to the wrapped Schema. Even if the Schema is picked up from a map (`schemaMap`) that kee

[pulsar] branch branch-2.7 updated: fix flaky unit test (#9262)

2021-05-25 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.7 by this push: new eba5d11 fix flaky unit test (#9262)

[GitHub] [pulsar] eolivelli commented on pull request #9262: fix flaky unit test

2021-05-25 Thread GitBox
eolivelli commented on pull request #9262: URL: https://github.com/apache/pulsar/pull/9262#issuecomment-847853131 I have cherry picked this patch to branch-2.7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [pulsar] eolivelli opened a new pull request #10699: Make PrometheusMetricsTest pass on CI

2021-05-25 Thread GitBox
eolivelli opened a new pull request #10699: URL: https://github.com/apache/pulsar/pull/10699 - on CI sometimes the tests sees tls auth metrics - now we verify that token auth is detected and we skip other auth fixes #10698 -- This is an automated message from the Apache Git Serv

[GitHub] [pulsar] eolivelli commented on issue #10698: [Tests] PrometheusMetricsTest testAuthMetrics is flaky on branch-2.7

2021-05-25 Thread GitBox
eolivelli commented on issue #10698: URL: https://github.com/apache/pulsar/issues/10698#issuecomment-847843481 I will send a patch shortly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [pulsar] eolivelli opened a new issue #10698: [Tests] PrometheusMetricsTest testAuthMetrics is flaky on branch-2.7

2021-05-25 Thread GitBox
eolivelli opened a new issue #10698: URL: https://github.com/apache/pulsar/issues/10698 This test fails when it is executed with other tests, for example on CI: ``` [ERROR] testAuthMetrics(org.apache.pulsar.broker.stats.PrometheusMetricsTest) Time elapsed: 0.067 s <<< FAILURE!

[GitHub] [pulsar] eolivelli commented on a change in pull request #10697: [fix #9640] remove `pulsar-client-admin-api` dependency : `pulsar-common`

2021-05-25 Thread GitBox
eolivelli commented on a change in pull request #10697: URL: https://github.com/apache/pulsar/pull/10697#discussion_r638726107 ## File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/NonPersistentPublisherStats.java ## @@ -31,7 +29,9 @@

[GitHub] [pulsar] eolivelli commented on a change in pull request #10696: [broker] Fix issue where StackOverflowError occurs when trying to redeliver a large number of already acked messages

2021-05-25 Thread GitBox
eolivelli commented on a change in pull request #10696: URL: https://github.com/apache/pulsar/pull/10696#discussion_r638723521 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java ## @@ -248,7 +249,9 @

[GitHub] [pulsar] freeznet opened a new pull request #10697: [fix #9640] remove `pulsar-client-admin-api` dependency : `pulsar-common`

2021-05-25 Thread GitBox
freeznet opened a new pull request #10697: URL: https://github.com/apache/pulsar/pull/10697 Fixes #9640 Part 3 ### Motivation Module `pulsar-client-admin-api` has been introduced in #9246, but it pulling in many dependencies.  This PR removes `pulsar-common` from th

[GitHub] [pulsar] eolivelli commented on a change in pull request #10650: [Transactionn] Transaction admin api component in topic status

2021-05-25 Thread GitBox
eolivelli commented on a change in pull request #10650: URL: https://github.com/apache/pulsar/pull/10650#discussion_r638715132 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v3/Transactions.java ## @@ -55,6 +55,55 @@ public void getCoordinatorStatus(@

[GitHub] [pulsar-client-go] jiangbo9510 commented on issue #527: Sometime goroutine send message with timeout option ,but it be blocked

2021-05-25 Thread GitBox
jiangbo9510 commented on issue #527: URL: https://github.com/apache/pulsar-client-go/issues/527#issuecomment-847801289 Polling a item for pendingqueue will lost this one. Also connection recive the response from broken. It will not call the callback function. That's make the sending gor

[GitHub] [pulsar-client-go] jiangbo9510 commented on issue #527: Sometime goroutine send message with timeout option ,but it be blocked

2021-05-25 Thread GitBox
jiangbo9510 commented on issue #527: URL: https://github.com/apache/pulsar-client-go/issues/527#issuecomment-847798068 > I met same problem( pulsar-client-go v0.4.1). > Metrics pulsar_client_producer_pending_messages is always 58 and log in line 488 printed 58 times. So, I think send me

[GitHub] [pulsar] eolivelli commented on pull request #10666: Add 2.7.3 docs for repo

2021-05-25 Thread GitBox
eolivelli commented on pull request #10666: URL: https://github.com/apache/pulsar/pull/10666#issuecomment-847742835 > The 2.7.3 has not yet been released, so we can temporarily use it as a historical document. After 2.7.3 is released, we will show it to users as the main version of the doc

[GitHub] [pulsar] eolivelli commented on a change in pull request #10666: Add 2.7.3 docs for repo

2021-05-25 Thread GitBox
eolivelli commented on a change in pull request #10666: URL: https://github.com/apache/pulsar/pull/10666#discussion_r638651161 ## File path: site2/website/releases.json ## @@ -1,6 +1,7 @@ [ "2.7.2", "2.7.1", + "2.7.3", Review comment: please do not add 2.7.3 her

[GitHub] [pulsar] massakam opened a new pull request #10696: [broker] Fix issue where StackOverflowError occurs when trying to redeliver a large number of already acked messages

2021-05-25 Thread GitBox
massakam opened a new pull request #10696: URL: https://github.com/apache/pulsar/pull/10696 ### Motivation The other day, some of our broker servers got the following StackOverflowError: ``` 13:44:17.410 [pulsar-io-21-6] WARN o.a.pulsar.broker.service.ServerCnx - [/xxx.xxx.x

[GitHub] [pulsar] zhaorongsheng edited a comment on pull request #7894: add cache hit ratio metrics for topic subscription

2021-05-25 Thread GitBox
zhaorongsheng edited a comment on pull request #7894: URL: https://github.com/apache/pulsar/pull/7894#issuecomment-847721162 > I have two high level questions: > > * we are adding a non negligible overhead in terms of object allocations and also we are adding a parameter to a widely

[GitHub] [pulsar] zhaorongsheng edited a comment on pull request #7894: add cache hit ratio metrics for topic subscription

2021-05-25 Thread GitBox
zhaorongsheng edited a comment on pull request #7894: URL: https://github.com/apache/pulsar/pull/7894#issuecomment-847721162 > I have two high level questions: > > * we are adding a non negligible overhead in terms of object allocations and also we are adding a parameter to a widely

[GitHub] [pulsar] zhaorongsheng commented on pull request #7894: add cache hit ratio metrics for topic subscription

2021-05-25 Thread GitBox
zhaorongsheng commented on pull request #7894: URL: https://github.com/apache/pulsar/pull/7894#issuecomment-847721162 > I have two high level questions: > > * we are adding a non negligible overhead in terms of object allocations and also we are adding a parameter to a widely used in

[GitHub] [pulsar] Crtrpt closed issue #9791: How to fetch all function state?

2021-05-25 Thread GitBox
Crtrpt closed issue #9791: URL: https://github.com/apache/pulsar/issues/9791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contac

[GitHub] [pulsar] eolivelli commented on issue #9645: Project-10: Remove ConfigurationCacheService (global-zk + local-zk) cache with Metadata-store API

2021-05-25 Thread GitBox
eolivelli commented on issue #9645: URL: https://github.com/apache/pulsar/issues/9645#issuecomment-847634433 @rdhabalia @merlimat I did not make progress on this work, as I am busy with other priorities. I can move forward but not in time for 2.8 release -- This is an automated

[GitHub] [pulsar] linlinnn commented on issue #10693: Support config remote clusters' TLS settings for geo-replicator

2021-05-25 Thread GitBox
linlinnn commented on issue #10693: URL: https://github.com/apache/pulsar/issues/10693#issuecomment-847621923 @sijie Should we use unify configuration from remote cluster for geo-replicator, and remove the former logic that using the local cluster's configuration? or there are other reason

[GitHub] [pulsar-client-go] xiebei1108 commented on issue #527: Sometime goroutine send message with timeout option ,but it be blocked

2021-05-25 Thread GitBox
xiebei1108 commented on issue #527: URL: https://github.com/apache/pulsar-client-go/issues/527#issuecomment-847614916 I met same problem( pulsar-client-go v0.4.1). Metrics pulsar_client_producer_pending_messages is always 58 and log in line 488 printed 58 times. So, I think send message

  1   2   >