[GitHub] [pulsar] hangc0276 commented on a change in pull request #10818: Make client-admin-api to use interfaces with builders instead of POJOs

2021-06-04 Thread GitBox
hangc0276 commented on a change in pull request #10818: URL: https://github.com/apache/pulsar/pull/10818#discussion_r645951682 ## File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/TenantInfo.java ## @@ -19,13 +19,20 @@ package org.apache.

[GitHub] [pulsar] merlimat commented on pull request #10827: ReflectionUtils use Class.forName in order to properly discover classes in Functions Runtime while using "DefaultImplementation"

2021-06-04 Thread GitBox
merlimat commented on pull request #10827: URL: https://github.com/apache/pulsar/pull/10827#issuecomment-855192152 > With recent changes in Pulsar IO we are bundling the Pulsar Client Implementation in the classpath of the Functions/Pulsar IO connectors. Is it still true in the curre

[GitHub] [pulsar] codelipenghui closed pull request #10835: Use jdk8 to build the project and run the binary license check.

2021-06-04 Thread GitBox
codelipenghui closed pull request #10835: URL: https://github.com/apache/pulsar/pull/10835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [pulsar] ciaocloud commented on pull request #10819: Log number of seconds it takes the broker to bootstrap

2021-06-04 Thread GitBox
ciaocloud commented on pull request #10819: URL: https://github.com/apache/pulsar/pull/10819#issuecomment-855186606 > Thanks for your contribution. For this PR, do we need to update docs? Thank you for asking. As it is a trivial work, I don't think we'll need to update docs. -- Th

[GitHub] [pulsar] hangc0276 commented on pull request #10818: Make client-admin-api to use interfaces with builders instead of POJOs

2021-06-04 Thread GitBox
hangc0276 commented on pull request #10818: URL: https://github.com/apache/pulsar/pull/10818#issuecomment-855184665 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] freeznet commented on a change in pull request #10827: ReflectionUtils use Class.forName in order to properly discover classes in Functions Runtime while using "DefaultImplementation

2021-06-04 Thread GitBox
freeznet commented on a change in pull request #10827: URL: https://github.com/apache/pulsar/pull/10827#discussion_r645941166 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/internal/ReflectionUtils.java ## @@ -51,12 +51,12 @@ try {

[GitHub] [pulsar] codelipenghui commented on pull request #10775: Run code to respond to auth challenge in a different thread in the pulsar client

2021-06-04 Thread GitBox
codelipenghui commented on pull request #10775: URL: https://github.com/apache/pulsar/pull/10775#issuecomment-855174952 @jerrypeng Could you please take a look @merlimat's comment? I'm cutting the 2.8.0 release, if you can't get a change to handle it, we can move the fix to 2.7.3/2.8.1.

[pulsar] branch master updated: [Conf] Fix typo; switch ledged to ledger (#10830)

2021-06-04 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new b7dbf22 [Conf] Fix typo; switch ledged to ledg

[GitHub] [pulsar] codelipenghui merged pull request #10830: [Conf] Fix typo; switch ledged to ledger

2021-06-04 Thread GitBox
codelipenghui merged pull request #10830: URL: https://github.com/apache/pulsar/pull/10830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [pulsar] codelipenghui opened a new pull request #10835: Use jdk8 to build the project and run the binary license check.

2021-06-04 Thread GitBox
codelipenghui opened a new pull request #10835: URL: https://github.com/apache/pulsar/pull/10835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [pulsar] timmyyuan opened a new issue #10834: Build failure when using src/set-project-version.sh: Project version is inherited from parent.

2021-06-04 Thread GitBox
timmyyuan opened a new issue #10834: URL: https://github.com/apache/pulsar/issues/10834 **Describe the bug** When using `src/set-project-version.sh` on the master branch, goal `org.codehaus.mojo:versions-maven-plugin:2.8.1:set` will throw a build failure: Project version is inherited fr

[GitHub] [pulsar] codelipenghui commented on a change in pull request #10831: [Broker] Fix possible data race in getFirstAvailableConsumerPermits

2021-06-04 Thread GitBox
codelipenghui commented on a change in pull request #10831: URL: https://github.com/apache/pulsar/pull/10831#discussion_r645926724 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java ## @@ -673,7 +673

[GitHub] [pulsar] leiless edited a comment on issue #10832: [Question] Can producer send() cause cumulative ACK from previous sendAsync()?

2021-06-04 Thread GitBox
leiless edited a comment on issue #10832: URL: https://github.com/apache/pulsar/issues/10832#issuecomment-855166878 Instead of `fsync(2)` per message manner, I pursuing `fsync(2)` in batch(as a whole). Explicitly, `fsync(2)` for the last msg in a list. Which enforces previous messages

[GitHub] [pulsar] leiless commented on issue #10832: [Question] Can producer send() cause cumulative ACK from previous sendAsync()?

2021-06-04 Thread GitBox
leiless commented on issue #10832: URL: https://github.com/apache/pulsar/issues/10832#issuecomment-855166878 Instead of `fsync(2)` per message manner, I pursuing `fsync(2)` in batch(as a whole). Explicitly, `fsync(2)` for the last msg in a list. Which enforces previous messages to be

[GitHub] [pulsar] codelipenghui opened a new pull request #10833: Rollback netty-tc-native version to 2.0.33.Final

2021-06-04 Thread GitBox
codelipenghui opened a new pull request #10833: URL: https://github.com/apache/pulsar/pull/10833 Fixes #10798 Related to: #10266 ### Motivation Rollback netty-tc-native version to 2.0.33.Final -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pulsar] leiless opened a new issue #10832: [Question] Can producer send() cause cumulative ACK from previous sendAsync()?

2021-06-04 Thread GitBox
leiless opened a new issue #10832: URL: https://github.com/apache/pulsar/issues/10832 ## `send()` > `MessageId send(T message) throws PulsarClientException` > Sends a message. > This call will be blocking until is successfully **acknowledged** by the Pulsar broker. > ...

[GitHub] [pulsar] codelipenghui commented on pull request #10775: Run code to respond to auth challenge in a different thread in the pulsar client

2021-06-04 Thread GitBox
codelipenghui commented on pull request #10775: URL: https://github.com/apache/pulsar/pull/10775#issuecomment-855158333 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] codelipenghui commented on pull request #10818: Make client-admin-api to use interfaces with builders instead of POJOs

2021-06-04 Thread GitBox
codelipenghui commented on pull request #10818: URL: https://github.com/apache/pulsar/pull/10818#issuecomment-855157807 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] codelipenghui commented on pull request #10823: remove pulsar-zookeeper module and call zookeeper quorumPeerMain to start zookeeper

2021-06-04 Thread GitBox
codelipenghui commented on pull request #10823: URL: https://github.com/apache/pulsar/pull/10823#issuecomment-855157727 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] devinbost commented on issue #10813: Consumer stuck while reading from partitioned topic using Shared subscription

2021-06-04 Thread GitBox
devinbost commented on issue #10813: URL: https://github.com/apache/pulsar/issues/10813#issuecomment-855152682 @eolivelli @rdhabalia Could there be two separate issues involved? It looks like the PR that closed this issue only addresses dispatcher behavior, not the ack path. -- This is

[GitHub] [pulsar] michaeljmarshall edited a comment on pull request #10831: [Broker] Fix possible data race in getFirstAvailableConsumerPermits

2021-06-04 Thread GitBox
michaeljmarshall edited a comment on pull request #10831: URL: https://github.com/apache/pulsar/pull/10831#issuecomment-855101337 @lhotari - in order to call `get` on the atomic wrapper just once, what if we added a new method that returns an `Optional` that is a combination of the `isCons

[GitHub] [pulsar] michaeljmarshall commented on pull request #10831: [Broker] Fix possible data race in getFirstAvailableConsumerPermits

2021-06-04 Thread GitBox
michaeljmarshall commented on pull request #10831: URL: https://github.com/apache/pulsar/pull/10831#issuecomment-855101337 @lhotari - in order to call `get` on the atomic wrapper just once, what if we added a new method that returns an `Option` that is a combination of the `isConsumerAvail

[GitHub] [pulsar] michaeljmarshall commented on pull request #10815: Docker image: add vim and nettools (netstat)

2021-06-04 Thread GitBox
michaeljmarshall commented on pull request #10815: URL: https://github.com/apache/pulsar/pull/10815#issuecomment-855055334 > do you have some suggestion about how to help users work on the pods now that we are rootless ? I think the largest difference is that you cannot download depe

[GitHub] [pulsar] jerrypeng commented on a change in pull request #10631: [Functions] reorganize the context hierarchy for functions

2021-06-04 Thread GitBox
jerrypeng commented on a change in pull request #10631: URL: https://github.com/apache/pulsar/pull/10631#discussion_r645876916 ## File path: pulsar-functions/api-java/src/main/java/org/apache/pulsar/functions/api/Context.java ## @@ -40,15 +36,8 @@ * executing function */

[GitHub] [pulsar] jerrypeng commented on a change in pull request #10631: [Functions] reorganize the context hierarchy for functions

2021-06-04 Thread GitBox
jerrypeng commented on a change in pull request #10631: URL: https://github.com/apache/pulsar/pull/10631#discussion_r645873174 ## File path: pulsar-client-1x-base/pulsar-client-1x/src/main/java/org/apache/pulsar/client/api/Producer.java ## @@ -84,7 +84,7 @@ void flush() t

[GitHub] [pulsar] lhotari opened a new pull request #10831: [Broker] Fix possible data race in getFirstAvailableConsumerPermits

2021-06-04 Thread GitBox
lhotari opened a new pull request #10831: URL: https://github.com/apache/pulsar/pull/10831 ### Motivation - there's a chance for a data race so that the consumer's available permits goes below zero after it has been checked in `isConsumerAvailable` ### Modifications

[GitHub] [pulsar] michaeljmarshall opened a new pull request #10830: [Conf] Fix typo; switch ledged to ledger

2021-06-04 Thread GitBox
michaeljmarshall opened a new pull request #10830: URL: https://github.com/apache/pulsar/pull/10830 Basic fix for a typo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. F

[pulsar] branch master updated: Fix the out of index issue when dispatch messages based on the avgBatchSizePerMsg. (#10828)

2021-06-04 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new e3cfbf8 Fix the out of index issue when disp

[GitHub] [pulsar] eolivelli closed issue #10813: Consumer stuck while reading from partitioned topic using Shared subscription

2021-06-04 Thread GitBox
eolivelli closed issue #10813: URL: https://github.com/apache/pulsar/issues/10813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [pulsar] eolivelli merged pull request #10828: Fix the out of index issue when dispatch messages based on the avgBatchSizePerMsg

2021-06-04 Thread GitBox
eolivelli merged pull request #10828: URL: https://github.com/apache/pulsar/pull/10828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [pulsar] megfigura commented on issue #7304: Memory leak on broker with streaming Spark application

2021-06-04 Thread GitBox
megfigura commented on issue #7304: URL: https://github.com/apache/pulsar/issues/7304#issuecomment-854943245 Also hit this issue with a similar use-case (creating batches for a Spark application). The issue is still present in the latest 2.7 branch as of commit 6bbb8d5c34d59a3a2cdd88e3e091

[GitHub] [pulsar] michaeljmarshall opened a new pull request #10829: [SECURITY] Add SECURITY.md with explicit dates for version support

2021-06-04 Thread GitBox
michaeljmarshall opened a new pull request #10829: URL: https://github.com/apache/pulsar/pull/10829 The original context for this PR is on the dev mailing list here: https://lists.apache.org/thread.html/ra2db06e8da85bff67d8d588dc1e93d965f2e1d70c95bda2f08d14138%40%3Cdev.pulsar.apache.org%3E

[GitHub] [pulsar-client-go] omnilight commented on issue #519: Connection health checks

2021-06-04 Thread GitBox
omnilight commented on issue #519: URL: https://github.com/apache/pulsar-client-go/issues/519#issuecomment-854919638 #496 is for consumer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [pulsar] rdhabalia commented on issue #10813: Consumer stuck while reading from partitioned topic using Shared subscription

2021-06-04 Thread GitBox
rdhabalia commented on issue #10813: URL: https://github.com/apache/pulsar/issues/10813#issuecomment-854889631 Below metrics shows the all messages are dispatched but consumer didn't ack the message after `28:8916`. seems ack issue. ``` "lastConfirmedEntry" : "28:8934", : "markD

[GitHub] [pulsar-translation] ericsyh opened a new pull request #41: Book translation to tiered-storage-aws

2021-06-04 Thread GitBox
ericsyh opened a new pull request #41: URL: https://github.com/apache/pulsar-translation/pull/41 ### Motivation Translate tiered-storage-aws file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] codelipenghui opened a new pull request #10828: Fix the out of index issue when dispatch messages based on the avgBatchSizePerMsg

2021-06-04 Thread GitBox
codelipenghui opened a new pull request #10828: URL: https://github.com/apache/pulsar/pull/10828 Fixes #10813 ### Motivation Fix the out of index issue when dispatch messages based on the avgBatchSizePerMsg. Using the avgBatchSizePerMsg to calculate the entr

[GitHub] [pulsar] massakam commented on a change in pull request #10790: [broker] Add REST API to enable or disable replicated subscriptions

2021-06-04 Thread GitBox
massakam commented on a change in pull request #10790: URL: https://github.com/apache/pulsar/pull/10790#discussion_r645689015 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java ## @@ -177,12 +178,28 @@ public boole

[GitHub] [pulsar] massakam commented on a change in pull request #10790: [broker] Add REST API to enable or disable replicated subscriptions

2021-06-04 Thread GitBox
massakam commented on a change in pull request #10790: URL: https://github.com/apache/pulsar/pull/10790#discussion_r645684356 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorSubscriptionTest.java ## @@ -230,6 +233,94 @@ public void testRepl

[GitHub] [pulsar] massakam commented on a change in pull request #10790: [broker] Add REST API to enable or disable replicated subscriptions

2021-06-04 Thread GitBox
massakam commented on a change in pull request #10790: URL: https://github.com/apache/pulsar/pull/10790#discussion_r645684070 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java ## @@ -177,12 +178,28 @@ public boole

[GitHub] [pulsar] cckellogg commented on a change in pull request #10819: Log number of seconds it takes the broker to bootstrap

2021-06-04 Thread GitBox
cckellogg commented on a change in pull request #10819: URL: https://github.com/apache/pulsar/pull/10819#discussion_r645648185 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java ## @@ -801,12 +803,16 @@ public Boolean get() {

[GitHub] [pulsar] mipper edited a comment on pull request #10817: [docs] Incorrect use of subscription mode versus type

2021-06-04 Thread GitBox
mipper edited a comment on pull request #10817: URL: https://github.com/apache/pulsar/pull/10817#issuecomment-854593226 Thanks for the reply. I would classify that as a bug. I know the documentation refers to this as mode; that was why I submitted a PR to change it to make it consistent

[GitHub] [pulsar] mipper edited a comment on pull request #10817: [docs] Incorrect use of subscription mode versus type

2021-06-04 Thread GitBox
mipper edited a comment on pull request #10817: URL: https://github.com/apache/pulsar/pull/10817#issuecomment-854593226 Thanks for the reply. I would classify that as a bug. I know the documentation refers to this as mode; that was why I submitted a PR to change it to make it consistent

[GitHub] [pulsar] eolivelli commented on issue #10813: Consumer stuck while reading from partitioned topic using Shared subscription

2021-06-04 Thread GitBox
eolivelli commented on issue #10813: URL: https://github.com/apache/pulsar/issues/10813#issuecomment-854720684 I am rerunning the after @codelipenghui fix. This is the dump of the stats now that the consumer is still connected and waiting for messages. the interesting point i

[GitHub] [pulsar] eolivelli commented on pull request #10765: pulsar-perf: print total number of messages

2021-06-04 Thread GitBox
eolivelli commented on pull request #10765: URL: https://github.com/apache/pulsar/pull/10765#issuecomment-854663786 @sijie can you please take a look again ? I removed that blank space. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [pulsar] eolivelli commented on issue #10813: Consumer stuck while reading from partitioned topic using Shared subscription

2021-06-04 Thread GitBox
eolivelli commented on issue #10813: URL: https://github.com/apache/pulsar/issues/10813#issuecomment-854660132 Unfortunately #10824 made the situation better and the test arrives to 99% but this we have problems. Also today I see a failure even with Exclusive subscription type. b

[GitHub] [pulsar] eolivelli commented on pull request #10827: ReflectionUtils use Class.forName in order to properly discover classes in Functions Runtime while using "DefaultImplementation"

2021-06-04 Thread GitBox
eolivelli commented on pull request #10827: URL: https://github.com/apache/pulsar/pull/10827#issuecomment-854628063 @codelipenghui it happens that without this patch some connectors that worked on Pulsar 2.7.x do not work anymore on 2.8.0. please take this patch into consideration for 2.

[GitHub] [pulsar] eolivelli opened a new pull request #10827: ReflectionUtils use Class.forName in order to properly discover classes in Functions Runtime while using "DefaultImplementation"

2021-06-04 Thread GitBox
eolivelli opened a new pull request #10827: URL: https://github.com/apache/pulsar/pull/10827 ### Motivation With recent changes in Pulsar IO we are bundling the Pulsar Client Implementation in the classpath of the Functions/Pulsar IO connectors. Sometimes it happens that calls to

[GitHub] [pulsar] eolivelli commented on pull request #10824: Fix consumer stuck issue due to reuse entry wrapper.

2021-06-04 Thread GitBox
eolivelli commented on pull request #10824: URL: https://github.com/apache/pulsar/pull/10824#issuecomment-854606784 @codelipenghui I would like to add that with this fix my test arrived to 99.85% ! it is a good improvement BTW thanks ! -- This is an automated message from the A

[GitHub] [pulsar] mipper commented on pull request #10817: [docs] Incorrect use of subscription mode versus type

2021-06-04 Thread GitBox
mipper commented on pull request #10817: URL: https://github.com/apache/pulsar/pull/10817#issuecomment-854593226 Thanks for the reply. I would classify that as a bug. I know the documentation refers to this as mode; that was why I submitted a PR to change it to make it consistent with AP

[GitHub] [pulsar] codelipenghui commented on a change in pull request #10824: Fix consumer stuck issue due to reuse entry wrapper.

2021-06-04 Thread GitBox
codelipenghui commented on a change in pull request #10824: URL: https://github.com/apache/pulsar/pull/10824#discussion_r645459380 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/impl/DispatchAccordingPermitsTests.java ## @@ -0,0 +1,105 @@ +/** + * Licensed

[pulsar] branch master updated (d8567a8 -> 4f23767)

2021-06-04 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from d8567a8 [Schema] Fix AutoConsumeSchema decode null schema version data (#10811) add 4f23767 Fix consumer stu

[GitHub] [pulsar] codelipenghui merged pull request #10824: Fix consumer stuck issue due to reuse entry wrapper.

2021-06-04 Thread GitBox
codelipenghui merged pull request #10824: URL: https://github.com/apache/pulsar/pull/10824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [pulsar] codelipenghui closed issue #10813: Consumer stuck while reading from partitioned topic using Shared subscription

2021-06-04 Thread GitBox
codelipenghui closed issue #10813: URL: https://github.com/apache/pulsar/issues/10813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[pulsar] branch master updated (0420520 -> d8567a8)

2021-06-04 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 0420520 [Build] Support building site without CROWDIN_DOCUSAURUS_API_KEY (#10804) add d8567a8 [Schema] Fix

[GitHub] [pulsar] eolivelli merged pull request #10811: [Schema] Fix AutoConsumeSchema decode null schema version data

2021-06-04 Thread GitBox
eolivelli merged pull request #10811: URL: https://github.com/apache/pulsar/pull/10811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [pulsar] eolivelli commented on pull request #10824: Fix consumer stuck issue due to reuse entry wrapper.

2021-06-04 Thread GitBox
eolivelli commented on pull request #10824: URL: https://github.com/apache/pulsar/pull/10824#issuecomment-854524938 let's merge the patch as soon as CI is green -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] eolivelli commented on a change in pull request #10824: Fix consumer stuck issue due to reuse entry wrapper.

2021-06-04 Thread GitBox
eolivelli commented on a change in pull request #10824: URL: https://github.com/apache/pulsar/pull/10824#discussion_r645425031 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/impl/DispatchAccordingPermitsTests.java ## @@ -0,0 +1,105 @@ +/** + * Licensed to t

[GitHub] [pulsar] eolivelli commented on pull request #10824: Fix consumer stuck issue due to reuse entry wrapper.

2021-06-04 Thread GitBox
eolivelli commented on pull request #10824: URL: https://github.com/apache/pulsar/pull/10824#issuecomment-854521907 The fix makes sense to me. but unfortunately but test case is still failing -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pulsar] yangl commented on pull request #10715: ZkIsolatedBookieEnsemblePlacementPolicy should use bookie zookeeper

2021-06-04 Thread GitBox
yangl commented on pull request #10715: URL: https://github.com/apache/pulsar/pull/10715#issuecomment-854498312 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] 949808802 closed issue #10812: failover

2021-06-04 Thread GitBox
949808802 closed issue #10812: URL: https://github.com/apache/pulsar/issues/10812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [pulsar] 949808802 closed issue #10826: key_share mode comsumber Could not get connection to broker

2021-06-04 Thread GitBox
949808802 closed issue #10826: URL: https://github.com/apache/pulsar/issues/10826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [pulsar] 949808802 opened a new issue #10826: key_share mode comsumber Could not get connection to broker

2021-06-04 Thread GitBox
949808802 opened a new issue #10826: URL: https://github.com/apache/pulsar/issues/10826 **Describe the bug** key_share mode comsumber Could not get connection to broker **To Reproduce** I user key_share mode,but comsumer could not get connection to broker,but i use exclusive,fa

[GitHub] [pulsar] merlimat commented on a change in pull request #10824: Fix consumer stuck issue due to reuse entry wrapper.

2021-06-04 Thread GitBox
merlimat commented on a change in pull request #10824: URL: https://github.com/apache/pulsar/pull/10824#discussion_r645298702 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractBaseDispatcher.java ## @@ -114,9 +114,11 @@ public void filterEntri

[GitHub] [pulsar] lhotari commented on pull request #10824: Fix consumer stuck issue due to reuse entry wrapper.

2021-06-04 Thread GitBox
lhotari commented on pull request #10824: URL: https://github.com/apache/pulsar/pull/10824#issuecomment-854408822 I have tested the fix. The situation looks better, but all messages don't get delivered from the backlog to the consumer. -- This is an automated message from the Apache Git

[GitHub] [pulsar] lhotari commented on a change in pull request #10824: Fix consumer stuck issue due to reuse entry wrapper.

2021-06-04 Thread GitBox
lhotari commented on a change in pull request #10824: URL: https://github.com/apache/pulsar/pull/10824#discussion_r645299661 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractBaseDispatcher.java ## @@ -114,9 +114,11 @@ public void filterEntrie

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10810: [broker] add brokerServiceUrl in TopicStats

2021-06-04 Thread GitBox
Anonymitaet commented on a change in pull request #10810: URL: https://github.com/apache/pulsar/pull/10810#discussion_r645367435 ## File path: site2/docs/admin-api-topics.md ## @@ -186,6 +186,8 @@ You can check the following statistics of a given non-partitioned topic. -

[GitHub] [pulsar] codelipenghui commented on a change in pull request #10824: Fix consumer stuck issue due to reuse entry wrapper.

2021-06-04 Thread GitBox
codelipenghui commented on a change in pull request #10824: URL: https://github.com/apache/pulsar/pull/10824#discussion_r645354985 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java ## @@ -532,13 +53

[GitHub] [pulsar] eolivelli commented on a change in pull request #10790: [broker] Add REST API to enable or disable replicated subscriptions

2021-06-04 Thread GitBox
eolivelli commented on a change in pull request #10790: URL: https://github.com/apache/pulsar/pull/10790#discussion_r645342826 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorSubscriptionTest.java ## @@ -230,6 +233,94 @@ public void testRep

[GitHub] [pulsar] 315157973 commented on issue #10673: update-partitioned-topic fails for newly created geo-replicated topic

2021-06-04 Thread GitBox
315157973 commented on issue #10673: URL: https://github.com/apache/pulsar/issues/10673#issuecomment-854465666 I will solve it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [pulsar] eolivelli commented on pull request #10815: Docker image: add vim and nettools (netstat)

2021-06-04 Thread GitBox
eolivelli commented on pull request #10815: URL: https://github.com/apache/pulsar/pull/10815#issuecomment-854452118 @sijie @addisonj @michaeljmarshall do you have some suggestion about how to help users work on the pods now that we are rootless ? -- This is an automated message from the

[GitHub] [pulsar] eolivelli commented on pull request #10824: Fix consumer stuck issue due to reuse entry wrapper.

2021-06-04 Thread GitBox
eolivelli commented on pull request #10824: URL: https://github.com/apache/pulsar/pull/10824#issuecomment-854406842 The change makes sense to me. Let me test it locally and see if my case is solved. Thank you very much ! -- This is an automated message from the Apache Git Servic

[GitHub] [pulsar] eolivelli commented on pull request #10793: [Build] Optimize website build by mounting ~/.m2 in the docker container

2021-06-04 Thread GitBox
eolivelli commented on pull request #10793: URL: https://github.com/apache/pulsar/pull/10793#issuecomment-853707332 Sure. Regarding the milestone. This change is only about CI and website. I am not sure it has some value to cite it in the list of changes for a release. Not a

[GitHub] [pulsar] eolivelli merged pull request #10794: [Build] Run crowdin upload once per day to speed up website builds

2021-06-04 Thread GitBox
eolivelli merged pull request #10794: URL: https://github.com/apache/pulsar/pull/10794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [pulsar] eolivelli commented on a change in pull request #10765: pulsar-perf: print total number of messages

2021-06-04 Thread GitBox
eolivelli commented on a change in pull request #10765: URL: https://github.com/apache/pulsar/pull/10765#discussion_r644544878 ## File path: pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceConsumer.java ## @@ -401,13 +403,15 @@ public static void main(S

[GitHub] [pulsar] lhotari commented on issue #10791: "mvn package" has not bulit any jar

2021-06-04 Thread GitBox
lhotari commented on issue #10791: URL: https://github.com/apache/pulsar/issues/10791#issuecomment-853577096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries abo

[GitHub] [pulsar] frank-montyne commented on issue #10263: Cannot delete non empty bundle

2021-06-04 Thread GitBox
frank-montyne commented on issue #10263: URL: https://github.com/apache/pulsar/issues/10263#issuecomment-853675538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queri

[GitHub] [pulsar] yangl commented on a change in pull request #10797: fix transaction pending ack generate managedLedgerStats fail exception.

2021-06-04 Thread GitBox
yangl commented on a change in pull request #10797: URL: https://github.com/apache/pulsar/pull/10797#discussion_r644702804 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/TransactionAggregator.java ## @@ -66,7 +67,7 @@ public static void gen

[GitHub] [pulsar] lhotari commented on pull request #10807: Fix NoClassDefFoundError when running pulsar cli tools in dev directory

2021-06-04 Thread GitBox
lhotari commented on pull request #10807: URL: https://github.com/apache/pulsar/pull/10807#issuecomment-853721029 @sijie @tuteng Please review this asap. This fixes an issue in the Pulsar website build reported as #10802 . -- This is an automated message from the Apache Git Service. To r

[GitHub] [pulsar] lhotari closed issue #10791: "mvn package" has not built any jar

2021-06-04 Thread GitBox
lhotari closed issue #10791: URL: https://github.com/apache/pulsar/issues/10791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[GitHub] [pulsar] Jason918 commented on pull request #10810: [broker] add brokerServiceUrl in TopicStats

2021-06-04 Thread GitBox
Jason918 commented on pull request #10810: URL: https://github.com/apache/pulsar/pull/10810#issuecomment-853776416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queri

[GitHub] [pulsar] sijie commented on a change in pull request #10804: [Build] Support building site without CROWDIN_DOCUSAURUS_API_KEY

2021-06-04 Thread GitBox
sijie commented on a change in pull request #10804: URL: https://github.com/apache/pulsar/pull/10804#discussion_r644613870 ## File path: site2/tools/build-site.sh ## @@ -34,44 +34,55 @@ if [ "$CROWDIN_DOCUSAURUS_API_KEY" != "UNSET" ]; then # or current hour is 0-5 # this

[GitHub] [pulsar] tuteng commented on pull request #10778: [Issue 10776][pulsar-client]Fixed dead letter queue name

2021-06-04 Thread GitBox
tuteng commented on pull request #10778: URL: https://github.com/apache/pulsar/pull/10778#issuecomment-854291204 @codelipenghui How about we encode the subscription name? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [pulsar] codelipenghui merged pull request #10803: use zookeeper prometheus metric provider to export zookeeper metrics

2021-06-04 Thread GitBox
codelipenghui merged pull request #10803: URL: https://github.com/apache/pulsar/pull/10803 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [pulsar] TheNotary removed a comment on issue #6481: Producer connection auto-closes after unspecified timeout

2021-06-04 Thread GitBox
TheNotary removed a comment on issue #6481: URL: https://github.com/apache/pulsar/issues/6481#issuecomment-853498753 I came across this error with a basic python producer script. I had put a shebang at the top of the script to invoke it via `./produce.py`. It was never able to produce an

[GitHub] [pulsar] gaoran10 commented on a change in pull request #10811: [Schema] Fix AutoConsumeSchema decode null schema version data

2021-06-04 Thread GitBox
gaoran10 commented on a change in pull request #10811: URL: https://github.com/apache/pulsar/pull/10811#discussion_r644969977 ## File path: pulsar-client/src/test/java/org/apache/pulsar/client/impl/TypedMessageBuilderImplTest.java ## @@ -225,5 +226,12 @@ public void testSetKey

[GitHub] [pulsar] lhotari commented on issue #10789: This is the bug causing both #10443 and #10449

2021-06-04 Thread GitBox
lhotari commented on issue #10789: URL: https://github.com/apache/pulsar/issues/10789#issuecomment-853578162 Please provide more context in the title and issue description. It will waste everyone's time if issues are reported this way. -- This is an automated message from the Apache Git

[GitHub] [pulsar] sijie commented on pull request #10793: [Build] Optimize website build by mounting ~/.m2 in the docker container

2021-06-04 Thread GitBox
sijie commented on pull request #10793: URL: https://github.com/apache/pulsar/pull/10793#issuecomment-853700497 @eolivelli Can you please update the assignee, labels, and milestone? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [pulsar] sijie commented on pull request #10487: Add the Maven wrapper

2021-06-04 Thread GitBox
sijie commented on pull request #10487: URL: https://github.com/apache/pulsar/pull/10487#issuecomment-853698845 @codelipenghui is releasing 2.8.0. will merge it once 2.8.0 is done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [pulsar] alexyans commented on issue #6481: Producer connection auto-closes after unspecified timeout

2021-06-04 Thread GitBox
alexyans commented on issue #6481: URL: https://github.com/apache/pulsar/issues/6481#issuecomment-853700951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries abou

[GitHub] [pulsar] eolivelli commented on pull request #10800: Update Netty to 4.1.63.Final and TC Native to 2.0.39.Final

2021-06-04 Thread GitBox
eolivelli commented on pull request #10800: URL: https://github.com/apache/pulsar/pull/10800#issuecomment-853651727 This patch does not fix the issue, closing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [pulsar] tomyouyou commented on issue #10791: "mvn package" has not bulit any jar

2021-06-04 Thread GitBox
tomyouyou commented on issue #10791: URL: https://github.com/apache/pulsar/issues/10791#issuecomment-853677853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries a

[GitHub] [pulsar] merlimat merged pull request #10774: Remove pulsar-client-admin-api dependency : pulsar-common

2021-06-04 Thread GitBox
merlimat merged pull request #10774: URL: https://github.com/apache/pulsar/pull/10774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [pulsar] alexyans edited a comment on issue #6481: Producer connection auto-closes after unspecified timeout

2021-06-04 Thread GitBox
alexyans edited a comment on issue #6481: URL: https://github.com/apache/pulsar/issues/6481#issuecomment-853700951 I don't have access to the release version at the moment, but the bug was patched in the C++ client that other language-specific clients wrap around. That was about 9 months a

[GitHub] [pulsar] Anonymitaet commented on pull request #10817: [docs] Incorrect use of subscription mode versus type

2021-06-04 Thread GitBox
Anonymitaet commented on pull request #10817: URL: https://github.com/apache/pulsar/pull/10817#issuecomment-854291148 Hi @mipper, "mode" is normally used to describe how messages are delivered to consumers. ![image](https://user-images.githubusercontent.com/50226895/120732082-4eafdd

[GitHub] [pulsar] Anonymitaet commented on pull request #10805: [DOC] Fix pulsar function python example code error

2021-06-04 Thread GitBox
Anonymitaet commented on pull request #10805: URL: https://github.com/apache/pulsar/pull/10805#issuecomment-854295908 @tuteng could you please help review? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [pulsar] Anonymitaet commented on pull request #10819: Log number of seconds it takes the broker to bootstrap

2021-06-04 Thread GitBox
Anonymitaet commented on pull request #10819: URL: https://github.com/apache/pulsar/pull/10819#issuecomment-854291630 Thanks for your contribution. For this PR, do we need to update docs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] lhotari commented on issue #10760: [Pulsar Release] 2.6.4

2021-06-04 Thread GitBox
lhotari commented on issue #10760: URL: https://github.com/apache/pulsar/issues/10760#issuecomment-853603989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries abo

[GitHub] [pulsar] sijie commented on a change in pull request #10765: pulsar-perf: print total number of messages

2021-06-04 Thread GitBox
sijie commented on a change in pull request #10765: URL: https://github.com/apache/pulsar/pull/10765#discussion_r644914601 ## File path: pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceProducer.java ## @@ -453,15 +453,16 @@ public static void main(Strin

[GitHub] [pulsar] eolivelli commented on pull request #10811: [Schema] Fix AutoConsumeSchema decode null schema version data

2021-06-04 Thread GitBox
eolivelli commented on pull request #10811: URL: https://github.com/apache/pulsar/pull/10811#issuecomment-854105640 @sijie AutoConsumeSchema code is very different in branch-2.7. This patch cannot be cherry picked. We should open a new PR if you want this fix for 2.7.3 -- This is an

[GitHub] [pulsar] codelipenghui closed issue #10802: [Website build] pulsar-admin-doc-gen.sh fails with NoClassDefFoundError error

2021-06-04 Thread GitBox
codelipenghui closed issue #10802: URL: https://github.com/apache/pulsar/issues/10802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

  1   2   >