[GitHub] [pulsar] lhotari commented on issue #11349: Flaky-test: RackAwareTest.testPlacement

2021-07-16 Thread GitBox
lhotari commented on issue #11349: URL: https://github.com/apache/pulsar/issues/11349#issuecomment-881842535 Another [recent failure](https://github.com/apache/pulsar/pull/11343/checks?check_run_id=3089235382#step:10:2099). -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] lhotari commented on issue #11050: Flaky-test: ServerCnxTest.testDuplicateConcurrentSubscribeCommand

2021-07-16 Thread GitBox
lhotari commented on issue #11050: URL: https://github.com/apache/pulsar/issues/11050#issuecomment-881842441 Another [recent failure](https://github.com/apache/pulsar/pull/11343/checks?check_run_id=3089235382#step:10:1299). -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] lhotari commented on issue #11050: Flaky-test: ServerCnxTest.testDuplicateConcurrentSubscribeCommand

2021-07-16 Thread GitBox
lhotari commented on issue #11050: URL: https://github.com/apache/pulsar/issues/11050#issuecomment-881842368 A [recent failure](https://github.com/apache/pulsar/pull/11343/checks?check_run_id=3089235382#step:10:529). -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] lhotari opened a new issue #11350: Flaky-test: TopicDuplicationTest.testDeduplicationPriority

2021-07-16 Thread GitBox
lhotari opened a new issue #11350: URL: https://github.com/apache/pulsar/issues/11350 TopicDuplicationTest is flaky. The testDeduplicationPriority test method fails sporadically. [example failure](https://github.com/apache/pulsar/pull/11345/checks?check_run_id=3089005869#step:10:134

[GitHub] [pulsar] lhotari opened a new issue #11349: Flaky-test: RackAwareTest.testPlacement

2021-07-16 Thread GitBox
lhotari opened a new issue #11349: URL: https://github.com/apache/pulsar/issues/11349 RackAwareTest is flaky. The testPlacement test method fails sporadically. [example failure](https://github.com/apache/pulsar/pull/11345/checks?check_run_id=3089005869#step:10:2090) ``` Err

[GitHub] [pulsar] Johnnyhooyo commented on issue #11315: How to retry send message after send fail at async mode?

2021-07-16 Thread GitBox
Johnnyhooyo commented on issue #11315: URL: https://github.com/apache/pulsar/issues/11315#issuecomment-881813110 Wow!~ @CoderCookE @eolivelli thanks very mach for help~~ i got it~ then i close this issue. -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [pulsar] Johnnyhooyo closed issue #11315: How to retry send message after send fail at async mode?

2021-07-16 Thread GitBox
Johnnyhooyo closed issue #11315: URL: https://github.com/apache/pulsar/issues/11315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [pulsar] Demogorgon314 commented on issue #11348: [Pulsar admin] Can not get leader broker in non-leader brokers.

2021-07-16 Thread GitBox
Demogorgon314 commented on issue #11348: URL: https://github.com/apache/pulsar/issues/11348#issuecomment-881810537 I will try to fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [pulsar] zhanghaou commented on issue #11348: [Pulsar admin] Can not get leader broker in non-leader brokers.

2021-07-16 Thread GitBox
zhanghaou commented on issue #11348: URL: https://github.com/apache/pulsar/issues/11348#issuecomment-881810164 @linlinnn @codelipenghui Please take a look and check, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] zhanghaou opened a new issue #11348: 【Pulsar admin】Can not get leader broker in non-leader brokers.

2021-07-16 Thread GitBox
zhanghaou opened a new issue #11348: URL: https://github.com/apache/pulsar/issues/11348 **Describe the bug** I can use admin cmd to get the leader broker in leader broker, but can not get the info from non-leader broker. **To Reproduce** 1. enter non-leader broker 2. run ' p

[GitHub] [pulsar] Shoothzj opened a new pull request #11347: Avoid infinite waiting for consumer close

2021-07-16 Thread GitBox
Shoothzj opened a new pull request #11347: URL: https://github.com/apache/pulsar/pull/11347 ### Motivation If there are two Events - EventA: Server close the consumer - EventB: consumer close self If EventA and EventB concurrently, then the `cnx.ctx()` has probability to be

[GitHub] [pulsar] yangl commented on pull request #11281: [tests] use Awaitility replace Thread.sleep for pulsar-broker.

2021-07-16 Thread GitBox
yangl commented on pull request #11281: URL: https://github.com/apache/pulsar/pull/11281#issuecomment-881797985 > awesome work. > > I let one comment and a couple of nits. > > please take a look Thank you for the review suggestion, I have fixed these, please take a look

[GitHub] [pulsar] yangl commented on a change in pull request #11281: [tests] use Awaitility replace Thread.sleep for pulsar-broker.

2021-07-16 Thread GitBox
yangl commented on a change in pull request #11281: URL: https://github.com/apache/pulsar/pull/11281#discussion_r671591303 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/namespace/OwnershipCacheTest.java ## @@ -355,9 +356,9 @@ public void testRemoveOwnershi

[GitHub] [pulsar] kaushik-develop commented on a change in pull request #11331: [PIP-82] [pulsar-broker] updates to resource-group stats:

2021-07-16 Thread GitBox
kaushik-develop commented on a change in pull request #11331: URL: https://github.com/apache/pulsar/pull/11331#discussion_r671537112 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroup.java ## @@ -140,6 +140,7 @@ public ResourceGroup(

[GitHub] [pulsar] nlu90 commented on pull request #11332: [function] set subscription name for go function runtime

2021-07-16 Thread GitBox
nlu90 commented on pull request #11332: URL: https://github.com/apache/pulsar/pull/11332#issuecomment-881722938 > Thanks for your contribution. For this PR, do we need to update docs? > > (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/

[GitHub] [pulsar] kaushik-develop commented on a change in pull request #11331: [PIP-82] [pulsar-broker] updates to resource-group stats:

2021-07-16 Thread GitBox
kaushik-develop commented on a change in pull request #11331: URL: https://github.com/apache/pulsar/pull/11331#discussion_r671527093 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/resourcegroup/RGUsageMTAggrWaitForAllMesgsTest.java ## @@ -57,7 +57,7 @@ //

[GitHub] [pulsar] kaushik-develop commented on a change in pull request #11331: [PIP-82] [pulsar-broker] updates to resource-group stats:

2021-07-16 Thread GitBox
kaushik-develop commented on a change in pull request #11331: URL: https://github.com/apache/pulsar/pull/11331#discussion_r671527093 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/resourcegroup/RGUsageMTAggrWaitForAllMesgsTest.java ## @@ -57,7 +57,7 @@ //

[GitHub] [pulsar] kaushik-develop commented on pull request #11331: [PIP-82] [pulsar-broker] updates to resource-group stats:

2021-07-16 Thread GitBox
kaushik-develop commented on pull request #11331: URL: https://github.com/apache/pulsar/pull/11331#issuecomment-881716032 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [pulsar] bharanic-dev commented on a change in pull request #11331: [PIP-82] [pulsar-broker] updates to resource-group stats:

2021-07-16 Thread GitBox
bharanic-dev commented on a change in pull request #11331: URL: https://github.com/apache/pulsar/pull/11331#discussion_r671456164 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroup.java ## @@ -140,6 +140,7 @@ public ResourceGroup(Res

[pulsar] branch master updated (3fcfb22 -> eb4d8aa)

2021-07-16 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 3fcfb22 [Transaction] Fix the transaction marker does not deleted as expect. (#11126) add eb4d8aa Support

[GitHub] [pulsar] rdhabalia merged pull request #11268: Support new topic format for broker admin healthcheck endpoint.

2021-07-16 Thread GitBox
rdhabalia merged pull request #11268: URL: https://github.com/apache/pulsar/pull/11268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pulsar] merlimat opened a new pull request #11346: Fixed inconsistent behavior for Namespace bundles cache

2021-07-16 Thread GitBox
merlimat opened a new pull request #11346: URL: https://github.com/apache/pulsar/pull/11346 ### Motivation In 2.7 there's a bug that leave the Namespace bundles cache to not to be invalidated after a namespace is deleted. If a namespace is deleted and recreated with a differen

[GitHub] [pulsar] lhotari opened a new pull request #11345: [Security] Upgrade commons-compress to 1.21

2021-07-16 Thread GitBox
lhotari opened a new pull request #11345: URL: https://github.com/apache/pulsar/pull/11345 ### Motivation - addresses CVE-2021-35515, CVE-2021-35516, CVE-2021-35517 and CVE-2021-36090 - these are DoS type of vulnerabilities which don't impact Pulsar - main benefit is that i

[GitHub] [pulsar] lhotari opened a new pull request #11344: [Security] Bump Netty version to 4.1.66.Final

2021-07-16 Thread GitBox
lhotari opened a new pull request #11344: URL: https://github.com/apache/pulsar/pull/11344 ### Motivation - contains security fix for sonatype-2021-0789 - fix is https://github.com/netty/netty/pull/11429 - Pulsar code is not impacted. - main benefit is that it clears th

[GitHub] [pulsar] lhotari commented on a change in pull request #11343: [Issue 11340] Fix concurrency issues in NarUnpacker

2021-07-16 Thread GitBox
lhotari commented on a change in pull request #11343: URL: https://github.com/apache/pulsar/pull/11343#discussion_r671451791 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarUnpacker.java ## @@ -136,27 +146,27 @@ private static void makeFile(final Inpu

[GitHub] [pulsar] kaushik-develop commented on a change in pull request #11331: [PIP-82] [pulsar-broker] updates to resource-group stats:

2021-07-16 Thread GitBox
kaushik-develop commented on a change in pull request #11331: URL: https://github.com/apache/pulsar/pull/11331#discussion_r671450212 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupService.java ## @@ -672,8 +690,10 @@ private void

[GitHub] [pulsar] jerrypeng commented on a change in pull request #11343: [Issue 11340] Fix concurrency issues in NarUnpacker

2021-07-16 Thread GitBox
jerrypeng commented on a change in pull request #11343: URL: https://github.com/apache/pulsar/pull/11343#discussion_r671434885 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarUnpacker.java ## @@ -136,27 +146,27 @@ private static void makeFile(final In

[GitHub] [pulsar] jerrypeng commented on a change in pull request #11343: [Issue 11340] Fix concurrency issues in NarUnpacker

2021-07-16 Thread GitBox
jerrypeng commented on a change in pull request #11343: URL: https://github.com/apache/pulsar/pull/11343#discussion_r671430151 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarUnpacker.java ## @@ -136,27 +146,27 @@ private static void makeFile(final In

[GitHub] [pulsar] jerrypeng commented on a change in pull request #11343: [Issue 11340] Fix concurrency issues in NarUnpacker

2021-07-16 Thread GitBox
jerrypeng commented on a change in pull request #11343: URL: https://github.com/apache/pulsar/pull/11343#discussion_r671430151 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarUnpacker.java ## @@ -136,27 +146,27 @@ private static void makeFile(final In

[GitHub] [pulsar] eolivelli commented on issue #7660: Unable to correctly pass JSON object as inline message via CLI pulsar-client

2021-07-16 Thread GitBox
eolivelli commented on issue #7660: URL: https://github.com/apache/pulsar/issues/7660#issuecomment-881610979 There is an open PR of mine that implements this feature -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] afedulov edited a comment on issue #7660: Unable to correctly pass JSON object as inline message via CLI pulsar-client

2021-07-16 Thread GitBox
afedulov edited a comment on issue #7660: URL: https://github.com/apache/pulsar/issues/7660#issuecomment-881608865 @devinbost Any progress on this issue? I see you already seem to have a corresponding fix on your fork? -- This is an automated message from the Apache Git Service. To respo

[GitHub] [pulsar] afedulov commented on issue #7660: Unable to correctly pass JSON object as inline message via CLI pulsar-client

2021-07-16 Thread GitBox
afedulov commented on issue #7660: URL: https://github.com/apache/pulsar/issues/7660#issuecomment-881608865 Any progress on this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [pulsar] kaushik-develop commented on pull request #11331: [PIP-82] [pulsar-broker] updates to resource-group stats:

2021-07-16 Thread GitBox
kaushik-develop commented on pull request #11331: URL: https://github.com/apache/pulsar/pull/11331#issuecomment-881558288 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] dipinhora commented on issue #11315: How to retry send message after send fail at async mode?

2021-07-16 Thread GitBox
dipinhora commented on issue #11315: URL: https://github.com/apache/pulsar/issues/11315#issuecomment-881552207 @CoderCookE @eolivelli thanks for the idea and examples.. i can't believe i missed that.. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] lhotari commented on a change in pull request #11343: [Issue 11340] Fix concurrency issues in NarUnpacker

2021-07-16 Thread GitBox
lhotari commented on a change in pull request #11343: URL: https://github.com/apache/pulsar/pull/11343#discussion_r671359944 ## File path: pulsar-common/src/test/java/org/apache/pulsar/common/nar/NarUnpackerTest.java ## @@ -0,0 +1,160 @@ +/** + * Licensed to the Apache Softwar

[GitHub] [pulsar] lhotari commented on a change in pull request #11343: [Issue 11340] Fix concurrency issues in NarUnpacker

2021-07-16 Thread GitBox
lhotari commented on a change in pull request #11343: URL: https://github.com/apache/pulsar/pull/11343#discussion_r671358327 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarUnpacker.java ## @@ -58,43 +61,55 @@ * if unable to explode

[GitHub] [pulsar] lhotari commented on a change in pull request #11343: [Issue 11340] Fix concurrency issues in NarUnpacker

2021-07-16 Thread GitBox
lhotari commented on a change in pull request #11343: URL: https://github.com/apache/pulsar/pull/11343#discussion_r671355435 ## File path: pulsar-common/src/test/java/org/apache/pulsar/common/nar/NarUnpackerTest.java ## @@ -0,0 +1,160 @@ +/** + * Licensed to the Apache Softwar

[GitHub] [pulsar] eolivelli commented on a change in pull request #11343: [Issue 11340] Fix concurrency issues in NarUnpacker

2021-07-16 Thread GitBox
eolivelli commented on a change in pull request #11343: URL: https://github.com/apache/pulsar/pull/11343#discussion_r671349866 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarUnpacker.java ## @@ -58,43 +61,55 @@ * if unable to explod

[GitHub] [pulsar] lhotari opened a new pull request #11343: [Issue 11340] Fix concurrency issues in NarUnpacker

2021-07-16 Thread GitBox
lhotari opened a new pull request #11343: URL: https://github.com/apache/pulsar/pull/11343 Fixes #11340 ### Motivation NarUnpacker used to extract Pulsar Functions jar files and Pulsar IO connector nar files has concurrency and file corruption issues. When multiple proc

[GitHub] [pulsar] eolivelli commented on a change in pull request #11281: [tests] use Awaitility replace Thread.sleep for pulsar-broker.

2021-07-16 Thread GitBox
eolivelli commented on a change in pull request #11281: URL: https://github.com/apache/pulsar/pull/11281#discussion_r671322733 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/SubscriptionSeekTest.java ## @@ -531,7 +532,7 @@ public void testOnlyClose

[GitHub] [pulsar] sijie commented on issue #11338: [Pulsar Functions and IO] Cannot upgrade Function built for Pulsar 2.7 to Pulsar 2.8

2021-07-16 Thread GitBox
sijie commented on issue #11338: URL: https://github.com/apache/pulsar/issues/11338#issuecomment-881513297 @eolivelli will take a look. @nlu90 @freeznet Can you also check this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] HugoPelletier commented on issue #7785: Failure of the Avro Serialization for Complex Types in the Python Client

2021-07-16 Thread GitBox
HugoPelletier commented on issue #7785: URL: https://github.com/apache/pulsar/issues/7785#issuecomment-881512787 We are in the same situation. The serialization/deserialization doesn't work with complex schemas. With a super simple "complex" schema like this ```python cla

[GitHub] [pulsar] eolivelli edited a comment on issue #11315: How to retry send message after send fail at async mode?

2021-07-16 Thread GitBox
eolivelli edited a comment on issue #11315: URL: https://github.com/apache/pulsar/issues/11315#issuecomment-881506840 @CoderCookE idea is good. In Java you can "capture" the variables outside your function. ``` final var payload = ; CompletableFuture handle = producer

[GitHub] [pulsar] eolivelli commented on issue #11315: How to retry send message after send fail at async mode?

2021-07-16 Thread GitBox
eolivelli commented on issue #11315: URL: https://github.com/apache/pulsar/issues/11315#issuecomment-881506840 @CoderCookE idea is good. In Java you can "capture" the variables outside your function. ``` final var payload = ; CompletableFuture handle = producer.send(p

[GitHub] [pulsar] eolivelli commented on a change in pull request #11331: [PIP-82] [pulsar-broker] updates to resource-group stats:

2021-07-16 Thread GitBox
eolivelli commented on a change in pull request #11331: URL: https://github.com/apache/pulsar/pull/11331#discussion_r671308616 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroup.java ## @@ -294,13 +318,15 @@ protected BytesAndMessage

[GitHub] [pulsar] CoderCookE edited a comment on issue #11315: How to retry send message after send fail at async mode?

2021-07-16 Thread GitBox
CoderCookE edited a comment on issue #11315: URL: https://github.com/apache/pulsar/issues/11315#issuecomment-881499738 at least in node, and i'd imagine you can do something similar in Java, if you wrap the `send` method you'll have the `msg` in scope for your catch method to do whatever y

[GitHub] [pulsar] CoderCookE commented on issue #11315: How to retry send message after send fail at async mode?

2021-07-16 Thread GitBox
CoderCookE commented on issue #11315: URL: https://github.com/apache/pulsar/issues/11315#issuecomment-881499738 at least in node, and i'd imagine you can do something similar in Java, if you wrap the `send` method you'll have the `msg` in scope for your catch method to do whatever you want

[GitHub] [pulsar] codelipenghui opened a new pull request #11342: Close the replicator and replication client when delete cluster.

2021-07-16 Thread GitBox
codelipenghui opened a new pull request #11342: URL: https://github.com/apache/pulsar/pull/11342 ### Motivation Currently, when a cluster has been deleted, the replicator and the replication client will not be closed. The producer of the replicator will try to reconnect to the del

[GitHub] [pulsar] RobertIndie closed pull request #10685: [Broker] Add multi roles support for authentication and authorization

2021-07-16 Thread GitBox
RobertIndie closed pull request #10685: URL: https://github.com/apache/pulsar/pull/10685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [pulsar] RobertIndie opened a new pull request #11341: [Broker] Add multi roles support for authorization

2021-07-16 Thread GitBox
RobertIndie opened a new pull request #11341: URL: https://github.com/apache/pulsar/pull/11341 ### Motivation In https://github.com/apache/pulsar/pull/10375, we add multi roles support for JWT authentication. But the authorization does not support multi roles currently. Only the fir

[GitHub] [pulsar] eolivelli commented on a change in pull request #11322: Pulsar IO: allow Sinks to use native AVRO and JSON

2021-07-16 Thread GitBox
eolivelli commented on a change in pull request #11322: URL: https://github.com/apache/pulsar/pull/11322#discussion_r671258381 ## File path: pulsar-functions/runtime-all/src/test/java/org/apache/pulsar/functions/instance/JavaInstanceDepsTest.java ## @@ -60,11 +60,14 @@ public

[GitHub] [pulsar] lhotari opened a new issue #11340: Extracted Pulsar Function jar file content in /tmp/pulsar-nar directory gets corrupted or overridden by different content

2021-07-16 Thread GitBox
lhotari opened a new issue #11340: URL: https://github.com/apache/pulsar/issues/11340 **Describe the bug** By default, Pulsar Functions runtime extracts files of a Pulsar Function implementation jar file to a directory `/tmp/pulsar-nar/[function-jar-file-name].jar-unpacked` where th

[GitHub] [pulsar] codelipenghui commented on pull request #11023: [Transaction] Fix delete sub then delete pending ack.

2021-07-16 Thread GitBox
codelipenghui commented on pull request #11023: URL: https://github.com/apache/pulsar/pull/11023#issuecomment-881347971 @congbobo184 Can you rebase to the master branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar] eolivelli commented on pull request #11322: Pulsar IO: allow Sinks to use native AVRO and JSON

2021-07-16 Thread GitBox
eolivelli commented on pull request #11322: URL: https://github.com/apache/pulsar/pull/11322#issuecomment-881344083 @Anonymitaet when we will find a good solution for this problem I will be happy to help with the docs. This PR is part of a bigger issue with have with Pulsar IO and Pulsar

[GitHub] [pulsar] eolivelli commented on pull request #11126: [Transaction] Fix the transaction marker doe not deleted as expect.

2021-07-16 Thread GitBox
eolivelli commented on pull request #11126: URL: https://github.com/apache/pulsar/pull/11126#issuecomment-881342614 @codelipenghui can you cherry pick to 2.8.1 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[pulsar] branch master updated (b18a048 -> 3fcfb22)

2021-07-16 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from b18a048 Add docs about how to use stateful functions in pulsar (#11335) add 3fcfb22 [Transaction] Fix the tr

[GitHub] [pulsar] codelipenghui closed issue #11002: [Transactions] Pulsar Admin: peekMessages is returning a wrong message, dealing with non empty list of individuallyDeletedMessages

2021-07-16 Thread GitBox
codelipenghui closed issue #11002: URL: https://github.com/apache/pulsar/issues/11002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] codelipenghui merged pull request #11126: [Transaction] Fix the transaction marker doe not deleted as expect.

2021-07-16 Thread GitBox
codelipenghui merged pull request #11126: URL: https://github.com/apache/pulsar/pull/11126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [pulsar] eolivelli commented on a change in pull request #11263: Enhanced ElasticSearch Sink (TLS, Auth, KeyValue Schema, INSERT/UPDATE/DELETE, "_id" management, multi index support)

2021-07-16 Thread GitBox
eolivelli commented on a change in pull request #11263: URL: https://github.com/apache/pulsar/pull/11263#discussion_r671131506 ## File path: pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/JsonConverter.java ## @@ -0,0 +1,204 @@ +/** Review comment:

[GitHub] [pulsar] Technoboy- commented on issue #11339: Pulsar Admin List Subscription lists only subscriptions created for Partition-0 when partition specific subscriptions are created

2021-07-16 Thread GitBox
Technoboy- commented on issue #11339: URL: https://github.com/apache/pulsar/issues/11339#issuecomment-881334900 I will try to fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar-client-go] wolfstudy closed issue #564: Support handleSendError command in Go SDK

2021-07-16 Thread GitBox
wolfstudy closed issue #564: URL: https://github.com/apache/pulsar-client-go/issues/564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [pulsar-client-go] wolfstudy merged pull request #566: Add send error logic for connection

2021-07-16 Thread GitBox
wolfstudy merged pull request #566: URL: https://github.com/apache/pulsar-client-go/pull/566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[pulsar-client-go] branch master updated: Add send error logic for connection (#566)

2021-07-16 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new f193975 Add send error logic for connect

[GitHub] [pulsar] BewareMyPower commented on pull request #10993: Modify a compilation problem caused by space in standalone.conf

2021-07-16 Thread GitBox
BewareMyPower commented on pull request #10993: URL: https://github.com/apache/pulsar/pull/10993#issuecomment-881325131 Your fix looks like not to be related with your original motivation any more. Would you like to close this PR and open a new PR to describe what's your current fix? --

[pulsar] branch master updated (f625d5e -> b18a048)

2021-07-16 Thread rxl
This is an automated email from the ASF dual-hosted git repository. rxl pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from f625d5e [Go Functions] Upgrade the go client version to 0.5.0 (#11336) add b18a048 Add docs about how to use stat

[GitHub] [pulsar] wolfstudy merged pull request #11335: Add docs about how to use stateful functions in pulsar

2021-07-16 Thread GitBox
wolfstudy merged pull request #11335: URL: https://github.com/apache/pulsar/pull/11335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pulsar] wolfstudy commented on a change in pull request #11335: Add docs about how to use stateful functions in pulsar

2021-07-16 Thread GitBox
wolfstudy commented on a change in pull request #11335: URL: https://github.com/apache/pulsar/pull/11335#discussion_r671105663 ## File path: site2/docs/functions-worker.md ## @@ -42,6 +42,38 @@ If authentication is enabled on the BookKeeper cluster, configure the following -

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11335: Add docs about how to use stateful functions in pulsar

2021-07-16 Thread GitBox
Anonymitaet commented on a change in pull request #11335: URL: https://github.com/apache/pulsar/pull/11335#discussion_r671099622 ## File path: site2/docs/functions-worker.md ## @@ -42,6 +42,38 @@ If authentication is enabled on the BookKeeper cluster, configure the following

[GitHub] [pulsar] manjupriya-ar opened a new issue #11339: Pulsar Admin List Subscription lists only subscriptions created for Partition-0 when partition specific subscriptions are created

2021-07-16 Thread GitBox
manjupriya-ar opened a new issue #11339: URL: https://github.com/apache/pulsar/issues/11339 **Describe the bug** Pulsar Admin List Subscription lists only subscriptions created for Partition-0 when partition specific subscriptions are created **To Reproduce** Pulsar Version

[GitHub] [pulsar] eolivelli opened a new issue #11338: [Pulsar Functions and IO] Cannot upgrade Function built for Pulsar 2.7 to Pulsar 2.8

2021-07-16 Thread GitBox
eolivelli opened a new issue #11338: URL: https://github.com/apache/pulsar/issues/11338 **Describe the bug** Pulsar Functions and Pulsar IO connectors that use the Pulsar Client API, in particular the "Schema" API (like `Schema.JSON(Pojo.class)`) do not work anymore if you upgrade your

[GitHub] [pulsar] eolivelli commented on a change in pull request #11333: Add TransactionEnable in Namespace

2021-07-16 Thread GitBox
eolivelli commented on a change in pull request #11333: URL: https://github.com/apache/pulsar/pull/11333#discussion_r671075036 ## File path: conf/standalone.conf ## @@ -590,7 +590,7 @@ managedLedgerDefaultAckQuorum=1 # How frequently to flush the cursor positions that were a

[pulsar] branch master updated (fcaa372 -> f625d5e)

2021-07-16 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from fcaa372 Add missing parameters for pulsar-perf (#11337) add f625d5e [Go Functions] Upgrade the go client versi

[GitHub] [pulsar] merlimat merged pull request #11336: [Go Functions] Upgrade the go client version to 0.5.0

2021-07-16 Thread GitBox
merlimat merged pull request #11336: URL: https://github.com/apache/pulsar/pull/11336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] merlimat commented on pull request #11330: PIP-45: Converted ResourceQuotaCache

2021-07-16 Thread GitBox
merlimat commented on pull request #11330: URL: https://github.com/apache/pulsar/pull/11330#issuecomment-881283907 @eolivelli PTAL again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[pulsar] branch master updated (bea3f66 -> fcaa372)

2021-07-16 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from bea3f66 set subscription name for go function runtime (#11332) add fcaa372 Add missing parameters for pulsa

[GitHub] [pulsar] eolivelli merged pull request #11337: Add missing parameters for pulsar-perf

2021-07-16 Thread GitBox
eolivelli merged pull request #11337: URL: https://github.com/apache/pulsar/pull/11337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pulsar] wolfstudy opened a new pull request #11337: Add missing parameters for pulsar-perf

2021-07-16 Thread GitBox
wolfstudy opened a new pull request #11337: URL: https://github.com/apache/pulsar/pull/11337 Signed-off-by: xiaolongran ### Motivation Add missing parameters for `pulsar-perf` and `zookeeper-shell` -- This is an automated message from the Apache Git Service. To resp

[GitHub] [pulsar] liangyepianzhou commented on a change in pull request #11333: Add TransactionEnable in Namespace

2021-07-16 Thread GitBox
liangyepianzhou commented on a change in pull request #11333: URL: https://github.com/apache/pulsar/pull/11333#discussion_r671029110 ## File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/NamespacesImpl.java ## @@ -3616,6 +3616,66 @@ public voi

[GitHub] [pulsar] liangyepianzhou commented on a change in pull request #11333: Add TransactionEnable in Namespace

2021-07-16 Thread GitBox
liangyepianzhou commented on a change in pull request #11333: URL: https://github.com/apache/pulsar/pull/11333#discussion_r671028181 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java ## @@ -343,7 +351,16 @@ public Persis

[GitHub] [pulsar] liangyepianzhou commented on a change in pull request #11333: Add TransactionEnable in Namespace

2021-07-16 Thread GitBox
liangyepianzhou commented on a change in pull request #11333: URL: https://github.com/apache/pulsar/pull/11333#discussion_r671023851 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java ## @@ -394,8 +416,16 @@ public