yuruguo edited a comment on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-923515481
PTAL @merlimat @lhotari @eolivelli @codelipenghui @gaoran10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
yuruguo edited a comment on pull request #12020:
URL: https://github.com/apache/pulsar/pull/12020#issuecomment-922978718
PTAL @merlimat @lhotari @eolivelli @codelipenghui @congbobo184 @zymap
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
lhotari commented on a change in pull request #11884:
URL: https://github.com/apache/pulsar/pull/11884#discussion_r712726160
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
##
@@ -1291,6 +1289,50 @@ protected OpSendMsg newObject(Handle
lhotari commented on a change in pull request #11884:
URL: https://github.com/apache/pulsar/pull/11884#discussion_r712725919
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
##
@@ -1291,6 +1289,50 @@ protected OpSendMsg newObject(Handle
yuruguo removed a comment on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-923641315
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
eolivelli commented on a change in pull request #11884:
URL: https://github.com/apache/pulsar/pull/11884#discussion_r712710313
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
##
@@ -1291,6 +1289,50 @@ protected OpSendMsg newObject(Hand
yuruguo commented on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-923641315
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new ea562f8f Fixed NPE in ProxyConnection with no aut
sijie merged pull request #12111:
URL: https://github.com/apache/pulsar/pull/12111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubsc
Technoboy- commented on pull request #12112:
URL: https://github.com/apache/pulsar/pull/12112#issuecomment-923611019
This pr is a little different with the original one.
Original `SourceContext extends ConnectorContext`
But this or make it extends : `SourceContext extends Context`
--
yuruguo removed a comment on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-923607284
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Technoboy- opened a new pull request #12112:
URL: https://github.com/apache/pulsar/pull/12112
Cherry pick #11293
## Motivation
The Debezium requires pulsar a service URL for history database usage.
In #11056 , the service.url field from PulsarKafkaWorkerConfig is no longer
yuruguo commented on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-923607284
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
merlimat commented on a change in pull request #11884:
URL: https://github.com/apache/pulsar/pull/11884#discussion_r712677063
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
##
@@ -1291,6 +1289,50 @@ protected OpSendMsg newObject(Handl
GPrabhudas commented on a change in pull request #612:
URL: https://github.com/apache/pulsar-client-go/pull/612#discussion_r712676881
##
File path: pulsar/consumer_partition.go
##
@@ -479,7 +505,49 @@ func (pc *partitionConsumer) MessageReceived(response
*pb.CommandMessage, he
merlimat opened a new pull request #12111:
URL: https://github.com/apache/pulsar/pull/12111
### Motivation
In #12057 there was a fix for missing authdata, but `AuthData.of()` is
expecting a valid `byte[]` instance, empty if there are no credentials.
--
This is an automated messag
315157973 commented on pull request #11884:
URL: https://github.com/apache/pulsar/pull/11884#issuecomment-923595264
I don't know if it is a good way, waiting for others to CR. @codelipenghui
@hangc0276 @merlimat
--
This is an automated message from the Apache Git Service.
To respond to
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 4bc3c40 ManagedLedger should not attempt deferr
merlimat merged pull request #12101:
URL: https://github.com/apache/pulsar/pull/12101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
Technoboy- opened a new pull request #12110:
URL: https://github.com/apache/pulsar/pull/12110
Cherry pick #11597 .
## Motivation
join() will not time out, when network jitter occurs, it is easy to cause
the thread to get stuck forever
## Modifications
Use get(timeout) in
yuruguo removed a comment on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-923569150
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
yuruguo commented on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-923569150
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
Technoboy- opened a new pull request #12109:
URL: https://github.com/apache/pulsar/pull/12109
Cherry pick #11614.
## Motivation
SubscribeRateLimiter cannot be disabled now.
When there are many subscriptions, it will cause some memory leaks.
- Even if subscribeThrottlingRa
yuruguo removed a comment on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-923559944
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
yuruguo commented on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-923559944
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
BewareMyPower commented on issue #12087:
URL: https://github.com/apache/pulsar/issues/12087#issuecomment-923534386
I think our goal is to configure multiple converters and choose the proper
one for the message. Since I missed the case in this PIP, I merged them into
one. You're right that
yuruguo removed a comment on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-923531807
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
yuruguo commented on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-923531807
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
yuruguo commented on pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108#issuecomment-923515481
PTAL @merlimat @lhotari @eolivelli @gaoran10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
yuruguo opened a new pull request #12108:
URL: https://github.com/apache/pulsar/pull/12108
### Motivation
Detail see [[pulsar-perf] Make it possible to disable
poolMessages](https://github.com/apache/pulsar/pull/12090#issue-736895104)
### Documentation
- no-need-doc
--
merlimat commented on a change in pull request #12106:
URL: https://github.com/apache/pulsar/pull/12106#discussion_r712622946
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/TypedMessageBuilderImpl.java
##
@@ -284,7 +284,7 @@ public MessageMetadata getM
merlimat commented on a change in pull request #12107:
URL: https://github.com/apache/pulsar/pull/12107#discussion_r712610112
##
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##
@@ -1352,6 +1352,9 @@
@FieldContext(categor
merlimat commented on pull request #12101:
URL: https://github.com/apache/pulsar/pull/12101#issuecomment-923443180
@dlg99 The purpose of this change is not to avoid the out-of-sync situation.
This is to ensure, as a best effort, that when we're losing connectivity with
ZK we don't interrup
rdhabalia opened a new pull request #12107:
URL: https://github.com/apache/pulsar/pull/12107
### Motivation
Broker is not able to auto-cert refresh. Broker should support a refresh
duration and perform auto-cert refresh.
```
00:12:59.613 [bookkeeper-io-12-34] ERROR
org.apache.
rdhabalia opened a new pull request #12106:
URL: https://github.com/apache/pulsar/pull/12106
### Motivation
Fix NPE when pulsar-storm bolt or any other client app tries to create
message without initializing producer in it.
```
java.lang.NullPointerException
at
org.apache.
EronWright commented on pull request #12056:
URL: https://github.com/apache/pulsar/pull/12056#issuecomment-923361039
I've addressed the feedback, please take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from e189de9 PIP-45: Removed access to ZK client from PulsarService
(#12100)
add 32401bb [Broker Auth SASL] Remove
merlimat merged pull request #12068:
URL: https://github.com/apache/pulsar/pull/12068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
dlg99 commented on pull request #12101:
URL: https://github.com/apache/pulsar/pull/12101#issuecomment-923346309
> This will not fix the root cause of the other issue, as it there's not a
way to precisely prevent requests while disconnected (eg: we could get
disconnected while the request w
EronWright commented on a change in pull request #12056:
URL: https://github.com/apache/pulsar/pull/12056#discussion_r711640008
##
File path: conf/standalone.conf
##
@@ -33,6 +33,9 @@ webServicePort=8080
# Hostname or IP address the service binds on, default is 0.0.0.0.
bindA
michaeljmarshall opened a new issue #12105:
URL: https://github.com/apache/pulsar/issues/12105
## Motivation
Pulsar's current `AuthenticationProvider` interface only exposes synchronous
methods for authenticating a connection. To date, this has been sufficient
because we do not have
michaeljmarshall opened a new pull request #12104:
URL: https://github.com/apache/pulsar/pull/12104
Master Issue:
### Motivation
As the first part of PIP-97, we need to update the interfaces. This PR is
the only PR that will update interfaces. It should not introduce any brea
merlimat commented on a change in pull request #12101:
URL: https://github.com/apache/pulsar/pull/12101#discussion_r712494496
##
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java
##
@@ -207,6 +218,22 @@ public BookKeeper g
merlimat commented on pull request #12101:
URL: https://github.com/apache/pulsar/pull/12101#issuecomment-923274901
> Possibly a version of this patch would be very useful for branch-2.8
This will not fix the root cause of the other issue, as it there's not a way
to precisely prevent
eolivelli commented on a change in pull request #12101:
URL: https://github.com/apache/pulsar/pull/12101#discussion_r712358254
##
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerFactoryImpl.java
##
@@ -207,6 +218,22 @@ public BookKeeper
merlimat opened a new pull request #12103:
URL: https://github.com/apache/pulsar/pull/12103
### Motivation
After a write failure, a task is scheduled in background to force close the
ledger and trigger the creation of a new one. If the the `OpAddEntry` instance
is already recycled,
merlimat opened a new pull request #12102:
URL: https://github.com/apache/pulsar/pull/12102
### Motivation
Added the JLine dependency into binary distribution so that the
`zookeeper-shell` command will be easier to use with completion/history/etc..
--
This is an automated message
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from f4f4cdd [C++] Support setting priority for the consumer (#12076)
add e189de9 PIP-45: Removed access to ZK clie
merlimat merged pull request #12100:
URL: https://github.com/apache/pulsar/pull/12100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
EronWright edited a comment on pull request #12072:
URL: https://github.com/apache/pulsar/pull/12072#issuecomment-923175384
@codelipenghui since this is a part of PIP-95 feature work, should probably
target 2.9 not 2.8.2. Some of the other PRs are just bug fixes that could be
in 2.8.2 in
EronWright commented on pull request #12072:
URL: https://github.com/apache/pulsar/pull/12072#issuecomment-923175384
@codelipenghui since this is a part of PIP-95, should probably target 2.9
not 2.8.2.
--
This is an automated message from the Apache Git Service.
To respond to the mes
EronWright commented on a change in pull request #12066:
URL: https://github.com/apache/pulsar/pull/12066#discussion_r712413394
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/lookup/TopicLookupBase.java
##
@@ -294,9 +295,10 @@ protected String internalGetNa
dlg99 commented on pull request #12101:
URL: https://github.com/apache/pulsar/pull/12101#issuecomment-923168157
@eolivelli FYI. I think this could be the real rootcause fix for
https://github.com/apache/pulsar/issues/8677 and
https://github.com/apache/pulsar/issues/12070 where the managed
merlimat commented on a change in pull request #12100:
URL: https://github.com/apache/pulsar/pull/12100#discussion_r712372680
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##
@@ -325,6 +324,10 @@ public MetadataStoreExtended
createConfi
michaeljmarshall commented on pull request #12027:
URL: https://github.com/apache/pulsar/pull/12027#issuecomment-923125304
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new f4f4cdd [C++] Support setting priority for the
merlimat merged pull request #12076:
URL: https://github.com/apache/pulsar/pull/12076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 898582b [pulsar-perf] Make it possible to disable poolMessages
(#12090)
add 4b40735 feat(conf): add journalWr
merlimat merged pull request #12093:
URL: https://github.com/apache/pulsar/pull/12093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 69abf98 Replace newInstance() with
getDeclaredConstructor().newInstance() (#12094)
add 898582b [pulsar-perf]
merlimat merged pull request #12090:
URL: https://github.com/apache/pulsar/pull/12090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 9975fe4 Bugfix: Fix rackaware placement policy init error (#12097)
add 69abf98 Replace newInstance() with
get
merlimat merged pull request #12094:
URL: https://github.com/apache/pulsar/pull/12094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
merlimat opened a new pull request #12101:
URL: https://github.com/apache/pulsar/pull/12101
### Motivation
When we detect that we don't have a working connection or session to the
metadata service, we need to avoid doing any operation that will involve access
to the metadata store,
thomasleplus commented on pull request #12082:
URL: https://github.com/apache/pulsar/pull/12082#issuecomment-923087207
Hi @codelipenghui, I see that you assigned this PR back to me, does this
mean there is something left for me to do?
--
This is an automated message from the Apache Git S
EronWright commented on a change in pull request #12066:
URL: https://github.com/apache/pulsar/pull/12066#discussion_r712312488
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/lookup/TopicLookupBase.java
##
@@ -294,9 +295,10 @@ protected String internalGetNa
EronWright commented on a change in pull request #12066:
URL: https://github.com/apache/pulsar/pull/12066#discussion_r712312488
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/lookup/TopicLookupBase.java
##
@@ -294,9 +295,10 @@ protected String internalGetNa
EronWright commented on a change in pull request #12066:
URL: https://github.com/apache/pulsar/pull/12066#discussion_r712312488
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/lookup/TopicLookupBase.java
##
@@ -294,9 +295,10 @@ protected String internalGetNa
eolivelli commented on a change in pull request #12100:
URL: https://github.com/apache/pulsar/pull/12100#discussion_r712293356
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##
@@ -325,6 +324,10 @@ public MetadataStoreExtended
createConf
gaozhangmin commented on pull request #11893:
URL: https://github.com/apache/pulsar/pull/11893#issuecomment-923046430
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
This is an automated email from the ASF dual-hosted git repository.
eolivelli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 9975fe4 Bugfix: Fix rackaware placement poli
eolivelli merged pull request #12097:
URL: https://github.com/apache/pulsar/pull/12097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
eolivelli commented on pull request #12097:
URL: https://github.com/apache/pulsar/pull/12097#issuecomment-923028106
> I don't want to hold up this fix for that test
This usually means that we won't be adding such test :-)
Usually as soon as the problem/urgency is fixed no one takes
merlimat opened a new pull request #12100:
URL: https://github.com/apache/pulsar/pull/12100
### Motivation
Removed direct access to ZK client from the `PulsarService` instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
addisonj commented on pull request #12097:
URL: https://github.com/apache/pulsar/pull/12097#issuecomment-923017644
@eolivelli I do think it is worth the test, but I would suggest we make a
follow up item to do that. While we could do a smoke test and see the logs, the
log is pretty subtle
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from ab413e0 [standalone] remove noisy log on pulsar standalone startup
(#11970)
add 9905a9d [PIP-45] Removed Conf
merlimat merged pull request #12078:
URL: https://github.com/apache/pulsar/pull/12078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
addisonj commented on a change in pull request #12097:
URL: https://github.com/apache/pulsar/pull/12097#discussion_r712252857
##
File path:
pulsar-zookeeper-utils/src/main/java/org/apache/pulsar/zookeeper/ZkBookieRackAffinityMapping.java
##
@@ -94,20 +90,25 @@ private void upd
liangyuanpeng commented on issue #11484:
URL: https://github.com/apache/pulsar/issues/11484#issuecomment-922984398
> @zhaoqiang1980 You can use the same subscription name to subscribe to
different topics and the subscription exists independently under each topic
@zhaoqiang198
yuruguo commented on pull request #12020:
URL: https://github.com/apache/pulsar/pull/12020#issuecomment-922978718
PTAL @merlimat @lhotari @eolivelli @congbobo184 @zymap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
liangyuanpeng commented on issue #11999:
URL: https://github.com/apache/pulsar/issues/11999#issuecomment-922973096
> docker run -itd --name my_pulsar -p 6650:6650 -p 8080:8080 --mount
source=pulsardata,target=/pulsar/data --mount
source=pulsarconf,target=/pulsar/conf my_pulsar:v1.0.feature
yuruguo commented on pull request #12020:
URL: https://github.com/apache/pulsar/pull/12020#issuecomment-922975427
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
yuruguo removed a comment on pull request #12020:
URL: https://github.com/apache/pulsar/pull/12020#issuecomment-922975427
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
eolivelli commented on pull request #11970:
URL: https://github.com/apache/pulsar/pull/11970#issuecomment-922961526
Committed to master branch.
Thank you @nicoloboschi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
This is an automated email from the ASF dual-hosted git repository.
eolivelli pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.
from 3c770a1 [testclient] Call printAggregatedStats method before client
exit (#11985)
add ab413e0 [standalone]
eolivelli merged pull request #11970:
URL: https://github.com/apache/pulsar/pull/11970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
gaozhangmin commented on a change in pull request #12025:
URL: https://github.com/apache/pulsar/pull/12025#discussion_r712198816
##
File path:
pulsar-zookeeper-utils/src/test/java/org/apache/pulsar/zookeeper/ZkIsolatedBookieEnsemblePlacementPolicyTest.java
##
@@ -137,9 +167,12
yuruguo removed a comment on pull request #12084:
URL: https://github.com/apache/pulsar/pull/12084#issuecomment-922955347
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
yuruguo commented on pull request #12084:
URL: https://github.com/apache/pulsar/pull/12084#issuecomment-922955347
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
gaozhangmin commented on a change in pull request #12025:
URL: https://github.com/apache/pulsar/pull/12025#discussion_r712190313
##
File path:
pulsar-zookeeper-utils/src/test/java/org/apache/pulsar/zookeeper/ZkIsolatedBookieEnsemblePlacementPolicyTest.java
##
@@ -137,9 +167,12
eolivelli commented on a change in pull request #12025:
URL: https://github.com/apache/pulsar/pull/12025#discussion_r712186690
##
File path:
pulsar-zookeeper-utils/src/test/java/org/apache/pulsar/zookeeper/ZkIsolatedBookieEnsemblePlacementPolicyTest.java
##
@@ -137,9 +167,12 @
gaozhangmin commented on a change in pull request #12025:
URL: https://github.com/apache/pulsar/pull/12025#discussion_r712182761
##
File path:
pulsar-zookeeper-utils/src/test/java/org/apache/pulsar/zookeeper/ZkIsolatedBookieEnsemblePlacementPolicyTest.java
##
@@ -137,9 +167,12
gaozhangmin commented on a change in pull request #12025:
URL: https://github.com/apache/pulsar/pull/12025#discussion_r712182761
##
File path:
pulsar-zookeeper-utils/src/test/java/org/apache/pulsar/zookeeper/ZkIsolatedBookieEnsemblePlacementPolicyTest.java
##
@@ -137,9 +167,12
yuruguo removed a comment on pull request #12020:
URL: https://github.com/apache/pulsar/pull/12020#issuecomment-922898525
PTAL @merlimat @eolivelli @congbobo184 @zymap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
yuruguo removed a comment on pull request #12020:
URL: https://github.com/apache/pulsar/pull/12020#issuecomment-922911386
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
yuruguo commented on pull request #12020:
URL: https://github.com/apache/pulsar/pull/12020#issuecomment-922911386
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
eolivelli commented on issue #12087:
URL: https://github.com/apache/pulsar/issues/12087#issuecomment-922910119
> if I didn't understand wrong, I think it's a part of converter's
implementation.
Sorry, I didn't check the implementation (this is expected, because if I
take a look to the
BewareMyPower commented on issue #12087:
URL: https://github.com/apache/pulsar/issues/12087#issuecomment-922900220
> `Payload convert(MessageContext message, Payload payload)`
>
> with
>
> ```
> interface MessageContext {
> ... getMetadata()
>
yuruguo commented on pull request #12020:
URL: https://github.com/apache/pulsar/pull/12020#issuecomment-922898525
PTAL @merlimat @eolivelli @congbobo184 @zymap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
yuruguo removed a comment on pull request #12020:
URL: https://github.com/apache/pulsar/pull/12020#issuecomment-922887180
@eolivelli @congbobo184 PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
1 - 100 of 118 matches
Mail list logo
