[GitHub] [pulsar] gaoran10 commented on a change in pull request #12720: [Pulsar SQL] Support query chunked messages feature in Pulsar SQL

2021-11-15 Thread GitBox
gaoran10 commented on a change in pull request #12720: URL: https://github.com/apache/pulsar/pull/12720#discussion_r75070 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java ## @@ -479,6 +479,13 @@ public void sendAsync(Message message

[GitHub] [pulsar] gaoran10 commented on a change in pull request #12720: [Pulsar SQL] Support query chunked messages feature in Pulsar SQL

2021-11-15 Thread GitBox
gaoran10 commented on a change in pull request #12720: URL: https://github.com/apache/pulsar/pull/12720#discussion_r749994015 ## File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarRecordCursor.java ## @@ -706,4 +730,94 @@ private void initEnt

[GitHub] [pulsar] Huanli-Meng commented on pull request #12777: [Doc]--Add example of offloading data to NFS

2021-11-15 Thread GitBox
Huanli-Meng commented on pull request #12777: URL: https://github.com/apache/pulsar/pull/12777#issuecomment-969971323 @Anonymitaet docs are updated and PTAL again. And i met error when running the `yarn start `command. I tried to upgrade the nodejs. but still fails. -- This is an automa

[GitHub] [pulsar] yuruguo commented on pull request #12828: Improve exception info for invaild time-related option

2021-11-15 Thread GitBox
yuruguo commented on pull request #12828: URL: https://github.com/apache/pulsar/pull/12828#issuecomment-969970271 @merlimat @eolivelli @codelipenghui @gaoran10 ptal, thx! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [pulsar] gaoran10 commented on a change in pull request #12720: [Pulsar SQL] Support query chunked messages feature in Pulsar SQL

2021-11-15 Thread GitBox
gaoran10 commented on a change in pull request #12720: URL: https://github.com/apache/pulsar/pull/12720#discussion_r749987884 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ## @@ -60,6 +60,7 @@ import java.util.function.Function; im

[GitHub] [pulsar] gaoran10 commented on a change in pull request #12720: [Pulsar SQL] Support query chunked messages feature in Pulsar SQL

2021-11-15 Thread GitBox
gaoran10 commented on a change in pull request #12720: URL: https://github.com/apache/pulsar/pull/12720#discussion_r749986299 ## File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarRecordCursor.java ## @@ -706,4 +730,94 @@ private void initEnt

[GitHub] [pulsar] gaoran10 commented on a change in pull request #12720: [Pulsar SQL] Support query chunked messages feature in Pulsar SQL

2021-11-15 Thread GitBox
gaoran10 commented on a change in pull request #12720: URL: https://github.com/apache/pulsar/pull/12720#discussion_r749986126 ## File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarRecordCursor.java ## @@ -278,15 +287,25 @@ public void accept(E

[GitHub] [pulsar] hpvd commented on issue #8815: Automated security and update routine before every release

2021-11-15 Thread GitBox
hpvd commented on issue #8815: URL: https://github.com/apache/pulsar/issues/8815#issuecomment-969967248 just another topic for optimizing code quality and security further: Use Automatic Fuzzing to find bugs (e.g. as part of CI / via github action) https://github.com/apache/pulsar/issues

[GitHub] [pulsar] 949808802 opened a new issue #12829: pulsar transaction error

2021-11-15 Thread GitBox
949808802 opened a new issue #12829: URL: https://github.com/apache/pulsar/issues/12829 The same code can be run yesterday, but it can't be used today,I don't know the cause of the problem and how to solve it!pulsar server and client use 2.8.0 code: public static void main(String[

[GitHub] [pulsar] wolfstudy commented on a change in pull request #12711: Fix znode leakage caused by deleting tenant

2021-11-15 Thread GitBox
wolfstudy commented on a change in pull request #12711: URL: https://github.com/apache/pulsar/pull/12711#discussion_r749980874 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/resources/NamespaceResources.java ## @@ -215,12 +258,27 @@ public boolean pa

[GitHub] [pulsar] wolfstudy commented on issue #12824: [Pulsar-Admin] Ledgers in the partitioned-stats-internal command are missing

2021-11-15 Thread GitBox
wolfstudy commented on issue #12824: URL: https://github.com/apache/pulsar/issues/12824#issuecomment-969962471 This is not a problem that can be reproduced stably. This is where the problem is confused. The current logic is problematic. We need to check in the return value. When the ledger

[GitHub] [pulsar] leizhiyuan commented on issue #12824: [Pulsar-Admin] Ledgers in the partitioned-stats-internal command are missing

2021-11-15 Thread GitBox
leizhiyuan commented on issue #12824: URL: https://github.com/apache/pulsar/issues/12824#issuecomment-969935253 ![image](https://user-images.githubusercontent.com/2684384/141936884-0ed1999b-0320-4a3d-9621-856072253031.png) I can not reproduce this issue , can you reproduce it every t

[GitHub] [pulsar] LeBW commented on a change in pull request #12523: add a metric to get earliest time in the backlog

2021-11-15 Thread GitBox
LeBW commented on a change in pull request #12523: URL: https://github.com/apache/pulsar/pull/12523#discussion_r749957876 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java ## @@ -563,10 +563,14 @@ void run() throws PulsarAdminException

[GitHub] [pulsar] merlimat commented on a change in pull request #12823: modify log level for disconnction

2021-11-15 Thread GitBox
merlimat commented on a change in pull request #12823: URL: https://github.com/apache/pulsar/pull/12823#discussion_r749955805 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java ## @@ -253,7 +253,7 @@ protected ByteBuf newConnectCommand() thr

[GitHub] [pulsar] merlimat edited a comment on pull request #12770: PIP-45: Added BookKeeper metadata adapter based on MetadataStore

2021-11-15 Thread GitBox
merlimat edited a comment on pull request #12770: URL: https://github.com/apache/pulsar/pull/12770#issuecomment-969926147 > Great work. The patch is huge I have to make another round of review. Yes, sorry but there was no easy way to break it down :) > It looks like this implem

[GitHub] [pulsar] merlimat commented on pull request #12770: PIP-45: Added BookKeeper metadata adapter based on MetadataStore

2021-11-15 Thread GitBox
merlimat commented on pull request #12770: URL: https://github.com/apache/pulsar/pull/12770#issuecomment-969926147 > Great work. The patch is huge I have to make another round of review. Yes, sorry but there was no easy way to break it down > It looks like this implementation w

[GitHub] [pulsar] equanz commented on a change in pull request #12401: [PIP 79][common,broker,client] Change PartitionedTopicStats to aggregate by producerName

2021-11-15 Thread GitBox
equanz commented on a change in pull request #12401: URL: https://github.com/apache/pulsar/pull/12401#discussion_r749949370 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -485,6 +485,8 @@ message CommandProducer { optional uint64 topic_epoch = 11;

[GitHub] [pulsar] codelipenghui commented on a change in pull request #12711: Fix znode leakage caused by deleting tenant

2021-11-15 Thread GitBox
codelipenghui commented on a change in pull request #12711: URL: https://github.com/apache/pulsar/pull/12711#discussion_r749947958 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/resources/NamespaceResources.java ## @@ -215,12 +258,27 @@ public boolea

[GitHub] [pulsar] Technoboy- commented on a change in pull request #12818: PIP 110: Support Topic metadata

2021-11-15 Thread GitBox
Technoboy- commented on a change in pull request #12818: URL: https://github.com/apache/pulsar/pull/12818#discussion_r749947366 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerConfig.java ## @@ -77,6 +77,7 @@ private int newEntriesChe

[GitHub] [pulsar] Technoboy- commented on a change in pull request #12818: PIP 110: Support Topic metadata

2021-11-15 Thread GitBox
Technoboy- commented on a change in pull request #12818: URL: https://github.com/apache/pulsar/pull/12818#discussion_r749946215 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerConfig.java ## @@ -77,6 +77,7 @@ private int newEntriesChe

svn commit: r50960 - in /dev/pulsar/pulsar-2.9.0-candidate-4: ./ DEB/ RPMS/ connectors/

2021-11-15 Thread eolivelli
Author: eolivelli Date: Tue Nov 16 06:33:57 2021 New Revision: 50960 Log: Rollback Pulsar 2.9.0 candidate 4 Removed: dev/pulsar/pulsar-2.9.0-candidate-4/DEB/ dev/pulsar/pulsar-2.9.0-candidate-4/RPMS/ dev/pulsar/pulsar-2.9.0-candidate-4/apache-pulsar-2.9.0-bin.tar.gz dev/pulsar/pul

[GitHub] [pulsar] yuruguo opened a new pull request #12828: Improve exception info for invaild time

2021-11-15 Thread GitBox
yuruguo opened a new pull request #12828: URL: https://github.com/apache/pulsar/pull/12828 ### Motivation Check the validity of the time-related option in CLI tools and give a more friendly / concise prompt message when time invaild. Currently, it directly display the exception stack in

[GitHub] [pulsar] Anonymitaet commented on pull request #12825: [docs] [ISSUE 12366] Add doc of bundles metrics

2021-11-15 Thread GitBox
Anonymitaet commented on pull request #12825: URL: https://github.com/apache/pulsar/pull/12825#issuecomment-969889573 @gaoran10 can you review this PR from the technical perspective? Thank! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[pulsar] branch master updated: [Pulsar SQL] Handle message null schema version in PulsarRecordCursor (#12809)

2021-11-15 Thread bogong
This is an automated email from the ASF dual-hosted git repository. bogong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new e5619cf [Pulsar SQL] Handle message null schema

[GitHub] [pulsar] congbobo184 merged pull request #12809: [Pulsar SQL] Handle message null schema version in PulsarRecordCursor

2021-11-15 Thread GitBox
congbobo184 merged pull request #12809: URL: https://github.com/apache/pulsar/pull/12809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[pulsar] branch master updated (9994614 -> daff31d)

2021-11-15 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 9994614 [Broker] Synchronize updates to the inactiveProducers map in MessageDeduplication (#12820) add daff31d

[GitHub] [pulsar] Anonymitaet merged pull request #12794: [DOCS] Add descriptions of subscription modes in PR 12745 to versioned docs

2021-11-15 Thread GitBox
Anonymitaet merged pull request #12794: URL: https://github.com/apache/pulsar/pull/12794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [pulsar] MarvinCai commented on a change in pull request #12720: [Pulsar SQL] Support query chunked messages feature in Pulsar SQL

2021-11-15 Thread GitBox
MarvinCai commented on a change in pull request #12720: URL: https://github.com/apache/pulsar/pull/12720#discussion_r749890992 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java ## @@ -479,6 +479,13 @@ public void sendAsync(Message messag

[GitHub] [pulsar] Technoboy- commented on a change in pull request #12818: PIP 110: Support Topic metadata

2021-11-15 Thread GitBox
Technoboy- commented on a change in pull request #12818: URL: https://github.com/apache/pulsar/pull/12818#discussion_r749888166 ## File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java ## @@ -368,9 +368,10 @@ public void revokePer

[GitHub] [pulsar] yuruguo commented on a change in pull request #12818: PIP 110: Support Topic metadata

2021-11-15 Thread GitBox
yuruguo commented on a change in pull request #12818: URL: https://github.com/apache/pulsar/pull/12818#discussion_r749886972 ## File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/TopicsImpl.java ## @@ -368,9 +368,10 @@ public void revokePermis

[GitHub] [pulsar] Anonymitaet commented on pull request #12827: feat: add missing docs for `pulsar-admin`

2021-11-15 Thread GitBox
Anonymitaet commented on pull request #12827: URL: https://github.com/apache/pulsar/pull/12827#issuecomment-969842345 Show commands added in https://github.com/apache/pulsar/pull/12634/files -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] Technoboy- commented on a change in pull request #12818: PIP 110: Support Topic metadata

2021-11-15 Thread GitBox
Technoboy- commented on a change in pull request #12818: URL: https://github.com/apache/pulsar/pull/12818#discussion_r749886069 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerConfig.java ## @@ -77,6 +77,7 @@ private int newEntriesChe

[GitHub] [pulsar] Technoboy- commented on a change in pull request #12818: PIP 110: Support Topic metadata

2021-11-15 Thread GitBox
Technoboy- commented on a change in pull request #12818: URL: https://github.com/apache/pulsar/pull/12818#discussion_r749886018 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerConfig.java ## @@ -77,6 +77,7 @@ private int newEntriesChe

[GitHub] [pulsar] urfreespace opened a new pull request #12827: feat: add missing docs for `pulsar-admin`

2021-11-15 Thread GitBox
urfreespace opened a new pull request #12827: URL: https://github.com/apache/pulsar/pull/12827 Signed-off-by: LiLi *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to

[GitHub] [pulsar] Technoboy- commented on a change in pull request #12818: PIP 110: Support Topic metadata

2021-11-15 Thread GitBox
Technoboy- commented on a change in pull request #12818: URL: https://github.com/apache/pulsar/pull/12818#discussion_r749881580 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java ## @@ -383,10 +385,28 @@ void run() throws PulsarAdminExce

[GitHub] [pulsar] gaoran10 commented on a change in pull request #12818: PIP 110: Support Topic metadata

2021-11-15 Thread GitBox
gaoran10 commented on a change in pull request #12818: URL: https://github.com/apache/pulsar/pull/12818#discussion_r749876032 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerConfig.java ## @@ -77,6 +77,7 @@ private int newEntriesCheck

[GitHub] [pulsar] Shoothzj opened a new pull request #12826: Remove unused clock field in SchemasResources

2021-11-15 Thread GitBox
Shoothzj opened a new pull request #12826: URL: https://github.com/apache/pulsar/pull/12826 ### Modifications Remove unused clock field in SchemasResources ### Documentation Need to update docs? - [x] `no-need-doc` little optimize --

[GitHub] [pulsar] yuruguo removed a comment on pull request #12351: [pulsar-admin] Add remove-clusters command for namespace

2021-11-15 Thread GitBox
yuruguo removed a comment on pull request #12351: URL: https://github.com/apache/pulsar/pull/12351#issuecomment-968812481 @eolivelli @codelipenghui @315157973 please take a look again, thx! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [pulsar] github-actions[bot] commented on pull request #12825: [docs] [ISSUE 12366] Add doc of bundles metrics

2021-11-15 Thread GitBox
github-actions[bot] commented on pull request #12825: URL: https://github.com/apache/pulsar/pull/12825#issuecomment-969804346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] gaozhangmin commented on pull request #12825: [docs] [ISSUE 12366] Add doc of bundles metrics

2021-11-15 Thread GitBox
gaozhangmin commented on pull request #12825: URL: https://github.com/apache/pulsar/pull/12825#issuecomment-969806434 @Anonymitaet PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [pulsar] gaozhangmin opened a new pull request #12825: [docs] [ISSUE 12366] Add doc of bundles metrics

2021-11-15 Thread GitBox
gaozhangmin opened a new pull request #12825: URL: https://github.com/apache/pulsar/pull/12825 ### Motivation Add bundles metrics doc ### Modifications Add bundles metrics doc ### Verifying this change - [ ] Make sure that the change passes the

[GitHub] [pulsar] Jason918 commented on a change in pull request #12818: PIP 110: Support Topic metadata

2021-11-15 Thread GitBox
Jason918 commented on a change in pull request #12818: URL: https://github.com/apache/pulsar/pull/12818#discussion_r749872569 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerConfig.java ## @@ -77,6 +77,7 @@ private int newEntriesCheck

[GitHub] [pulsar] MarvinCai commented on a change in pull request #12720: [Pulsar SQL] Support query chunked messages feature in Pulsar SQL

2021-11-15 Thread GitBox
MarvinCai commented on a change in pull request #12720: URL: https://github.com/apache/pulsar/pull/12720#discussion_r749802832 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ## @@ -60,6 +60,7 @@ import java.util.function.Function; i

[GitHub] [pulsar] aloyszhang commented on issue #12733: peek message for pulsar-admin java client does not return a key of a peeked message

2021-11-15 Thread GitBox
aloyszhang commented on issue #12733: URL: https://github.com/apache/pulsar/issues/12733#issuecomment-969787677 @AlNedorezov @eolivelli you can see this pull request https://github.com/apache/pulsar/pull/11443 -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [pulsar] merlimat commented on a change in pull request #12770: PIP-45: Added BookKeeper metadata adapter based on MetadataStore

2021-11-15 Thread GitBox
merlimat commented on a change in pull request #12770: URL: https://github.com/apache/pulsar/pull/12770#discussion_r749857837 ## File path: pulsar-metadata/src/test/java/org/apache/pulsar/metadata/bookkeeper/EndToEndTest.java ## @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache

[GitHub] [pulsar] codelipenghui commented on a change in pull request #12523: add a metric to get earliest time in the backlog

2021-11-15 Thread GitBox
codelipenghui commented on a change in pull request #12523: URL: https://github.com/apache/pulsar/pull/12523#discussion_r749856334 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java ## @@ -563,10 +563,14 @@ void run() throws PulsarAdminE

[GitHub] [pulsar] wolfstudy opened a new issue #12824: [Pulsar-Admin] Ledgers in the partitioned-stats-internal command are missing

2021-11-15 Thread GitBox
wolfstudy opened a new issue #12824: URL: https://github.com/apache/pulsar/issues/12824 **Describe the bug** Run the command: ``` bin/pulsar-admin topics partitioned-stats-internal ``` the input as follows: ![image](https://user-images.githubuserconten

[GitHub] [pulsar] github-actions[bot] commented on pull request #12823: modify log level for disconnction

2021-11-15 Thread GitBox
github-actions[bot] commented on pull request #12823: URL: https://github.com/apache/pulsar/pull/12823#issuecomment-969686736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] aloyszhang opened a new pull request #12823: modify log level for disconnction

2021-11-15 Thread GitBox
aloyszhang opened a new pull request #12823: URL: https://github.com/apache/pulsar/pull/12823 Fixes #12755 ### Motivation Make channel disconnection information easier to catch. ### Modifications Update log level for disconnection from info to warn. ### Ve

[GitHub] [pulsar] BewareMyPower commented on pull request #11974: [Issue 11846][Java client] Create a consumer in the paused state

2021-11-15 Thread GitBox
BewareMyPower commented on pull request #11974: URL: https://github.com/apache/pulsar/pull/11974#issuecomment-969680844 LGTM. But I'm wondering if it needs a PIP because it's a new feature for Pulsar client while it's very simple. Please help confirm it. @merlimat @codelipenghui -

[GitHub] [pulsar] yuruguo opened a new issue #12822: Add remove-clusters command for namespace in pulsar-admin

2021-11-15 Thread GitBox
yuruguo opened a new issue #12822: URL: https://github.com/apache/pulsar/issues/12822 **Is your feature request related to a problem? Please describe.** CLI `bin/pulsar-admin` supports `set-clusters` and `get-clusters` command so that we can `set` / `get` replication clusters for a names

[GitHub] [pulsar] codelipenghui closed issue #8759: DeadLetterPolicy, If allowAutoTopicCreation enabled in broker, the same subscriber name will conflict under different non-partitioned topics

2021-11-15 Thread GitBox
codelipenghui closed issue #8759: URL: https://github.com/apache/pulsar/issues/8759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [pulsar] merlimat commented on pull request #12776: [metadata] Add RocksdbMetadataStore

2021-11-15 Thread GitBox
merlimat commented on pull request #12776: URL: https://github.com/apache/pulsar/pull/12776#issuecomment-969557911 > @merlimat We already have a metadata interface, so I think `add rocksdb as an option` is not much difference with `remove zookeeper`. If people who use zookeeper standalone

[GitHub] [pulsar] Shoothzj commented on pull request #12776: [metadata] Add RocksdbMetadataStore

2021-11-15 Thread GitBox
Shoothzj commented on pull request #12776: URL: https://github.com/apache/pulsar/pull/12776#issuecomment-969423575 @merlimat We already have a metadata interface, so I think `add rocksdb as an option` is not much difference with `remove zookeeper`. If people who use zookeeper standalone fo

[GitHub] [pulsar] nlu90 commented on pull request #12706: clean code style issues

2021-11-15 Thread GitBox
nlu90 commented on pull request #12706: URL: https://github.com/apache/pulsar/pull/12706#issuecomment-969384680 @codelipenghui let me know if there's any change need to be done before we merge this PR. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [pulsar] zwalsh-toast commented on pull request #11974: [Issue 11846][Java client] Create a consumer in the paused state

2021-11-15 Thread GitBox
zwalsh-toast commented on pull request #11974: URL: https://github.com/apache/pulsar/pull/11974#issuecomment-969325272 Bump on this PR! @eolivelli, @codelipenghui, @BewareMyPower, @sijie, @hangc0276, @merlimat - PTAL -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] eolivelli commented on a change in pull request #12770: PIP-45: Added BookKeeper metadata adapter based on MetadataStore

2021-11-15 Thread GitBox
eolivelli commented on a change in pull request #12770: URL: https://github.com/apache/pulsar/pull/12770#discussion_r749679530 ## File path: pulsar-metadata/src/test/java/org/apache/pulsar/metadata/bookkeeper/EndToEndTest.java ## @@ -0,0 +1,80 @@ +/** + * Licensed to the Apach

[pulsar] branch master updated: [Broker] Synchronize updates to the inactiveProducers map in MessageDeduplication (#12820)

2021-11-15 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 9994614 [Broker] Synchronize updates to the ina

[GitHub] [pulsar] merlimat merged pull request #12820: [Broker] Synchronize updates to the inactiveProducers map in MessageD…

2021-11-15 Thread GitBox
merlimat merged pull request #12820: URL: https://github.com/apache/pulsar/pull/12820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] leroyj commented on issue #12166: Failed to start standalone pulsar on Apple M1

2021-11-15 Thread GitBox
leroyj commented on issue #12166: URL: https://github.com/apache/pulsar/issues/12166#issuecomment-969302860 It probably comes from RocksDB jni lib that is compiled for Intel architecture but not for M1. I have the following message when I try to start Pulsar standalone manually ```

[GitHub] [pulsar] hpvd commented on issue #12800: 40个分区的topic消息严重不均衡下个别partition无法被consumer消费

2021-11-15 Thread GitBox
hpvd commented on issue #12800: URL: https://github.com/apache/pulsar/issues/12800#issuecomment-969295829 just a little translation to make this issue searchable in english language: Suspected pulsar-broker bug, but I can't confirm it. Contents. (1). Reasons for not using En

[pulsar] branch master updated: [Java Client] Use info, not warn, log level when successfully registering schema (#12819)

2021-11-15 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new e993f32 [Java Client] Use info, not warn, log l

[GitHub] [pulsar] merlimat merged pull request #12819: [Java Client] Use info, not warn, log level when successfully registe…

2021-11-15 Thread GitBox
merlimat merged pull request #12819: URL: https://github.com/apache/pulsar/pull/12819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] eolivelli commented on pull request #12820: [Broker] Synchronize updates to the inactiveProducers map in MessageD…

2021-11-15 Thread GitBox
eolivelli commented on pull request #12820: URL: https://github.com/apache/pulsar/pull/12820#issuecomment-969259376 @merlimat I can include this patch in 2.9.0. I was going to send out the VOTE but I can restart the procedure tomorrow -- This is an automated message from the Apache Gi

[GitHub] [pulsar] david-streamlio opened a new pull request #12821: [Issue-12768] [documentation] Fix JSON configuration examples

2021-11-15 Thread GitBox
david-streamlio opened a new pull request #12821: URL: https://github.com/apache/pulsar/pull/12821 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes #12768 ### Motivation The JSON configuration examples for the Pulsar IO connectors were wrong.

[GitHub] [pulsar] michaeljmarshall commented on pull request #12819: [Java Client] Use info, not warn, log level when successfully registe…

2021-11-15 Thread GitBox
michaeljmarshall commented on pull request #12819: URL: https://github.com/apache/pulsar/pull/12819#issuecomment-969211376 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] nicoloboschi commented on pull request #12694: Flaky tests: ElasticSearchClientTests tests time out

2021-11-15 Thread GitBox
nicoloboschi commented on pull request #12694: URL: https://github.com/apache/pulsar/pull/12694#issuecomment-969210332 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] nicoloboschi commented on pull request #12697: [ElasticSearch Sink] Correct @FieldDoc defaultValue for some fields

2021-11-15 Thread GitBox
nicoloboschi commented on pull request #12697: URL: https://github.com/apache/pulsar/pull/12697#issuecomment-969210094 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] michaeljmarshall commented on pull request #12820: [Broker] Synchronize updates to the inactiveProducers map in MessageD…

2021-11-15 Thread GitBox
michaeljmarshall commented on pull request #12820: URL: https://github.com/apache/pulsar/pull/12820#issuecomment-969208639 @merlimat and @congbobo184 - PTAL. Based on https://github.com/apache/pulsar/pull/12493#discussion_r736742728, it looks like we prefer synchronization on the class as

[GitHub] [pulsar] michaeljmarshall opened a new pull request #12820: [Broker] Synchronize updates to the inactiveProducers map in MessageD…

2021-11-15 Thread GitBox
michaeljmarshall opened a new pull request #12820: URL: https://github.com/apache/pulsar/pull/12820 …eduplication ### Motivation In https://github.com/apache/pulsar/pull/12493, we introduced potentially concurrent updates to the `inactiveProducers` map without any synchronizat

svn commit: r50952 - /dev/pulsar/pulsar-client-go-0.7.0-candidate-1/ /release/pulsar/pulsar-client-go-0.7.0/

2021-11-15 Thread mmerli
Author: mmerli Date: Mon Nov 15 18:29:30 2021 New Revision: 50952 Log: release 0.7.0 Added: release/pulsar/pulsar-client-go-0.7.0/ - copied from r50951, dev/pulsar/pulsar-client-go-0.7.0-candidate-1/ Removed: dev/pulsar/pulsar-client-go-0.7.0-candidate-1/

[pulsar] branch master updated (3a79596 -> ecc56b4)

2021-11-15 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 3a79596 Fix flaky test in org.apache.pulsar.client.api.KeySharedSubscriptionTest#testRemoveFirstConsumer (#12807)

[pulsar] branch master updated (86837a3 -> 3a79596)

2021-11-15 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 86837a3 [website][upgrade]feat: docs migration - 2.6.4 / development/reference (#12806) add 3a79596 Fix flaky

[GitHub] [pulsar] merlimat merged pull request #12798: [Test] Fix flaky test in TransactionProduceTest::ackAbortTest

2021-11-15 Thread GitBox
merlimat merged pull request #12798: URL: https://github.com/apache/pulsar/pull/12798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] merlimat merged pull request #12807: [Issue 11426] Fix flaky in KeySharedSubscriptionTest#testRemoveFirstConsumer

2021-11-15 Thread GitBox
merlimat merged pull request #12807: URL: https://github.com/apache/pulsar/pull/12807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] merlimat closed issue #11426: Flaky-test: KeySharedSubscriptionTest.testRemoveFirstConsumer

2021-11-15 Thread GitBox
merlimat closed issue #11426: URL: https://github.com/apache/pulsar/issues/11426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

svn commit: r50951 [1/2] - in /dev/pulsar/pulsar-2.9.0-candidate-4: ./ DEB/ RPMS/ RPMS/repodata/ connectors/

2021-11-15 Thread eolivelli
Author: eolivelli Date: Mon Nov 15 17:29:25 2021 New Revision: 50951 Log: Staging artifacts and signature for Pulsar release 2.9.0 Added: dev/pulsar/pulsar-2.9.0-candidate-4/ dev/pulsar/pulsar-2.9.0-candidate-4/DEB/ dev/pulsar/pulsar-2.9.0-candidate-4/DEB/Packages.gz (with props)

svn commit: r50951 [2/2] - in /dev/pulsar/pulsar-2.9.0-candidate-4: ./ DEB/ RPMS/ RPMS/repodata/ connectors/

2021-11-15 Thread eolivelli
Added: dev/pulsar/pulsar-2.9.0-candidate-4/connectors/pulsar-io-file-2.9.0.nar == Binary file - no diff available. Propchange: dev/pulsar/pulsar-2.9.0-candidate-4/connectors/pulsar-io-file-2.9.0.nar --

[GitHub] [pulsar] michaeljmarshall opened a new pull request #12819: [Java Client] Use info, not warn, log level when successfully registe…

2021-11-15 Thread GitBox
michaeljmarshall opened a new pull request #12819: URL: https://github.com/apache/pulsar/pull/12819 …ring schema ### Motivation Use `INFO` log level when a successful event happens. The Pulsar Coding Guide mentions that `WARN` is only for "bad" events. https://pulsar.apache.o

[GitHub] [pulsar] merlimat commented on pull request #12776: [metadata] Add RocksdbMetadataStore

2021-11-15 Thread GitBox
merlimat commented on pull request #12776: URL: https://github.com/apache/pulsar/pull/12776#issuecomment-969124213 > Also we should state clearly that using this implementation is not possible for production usage because each broker will have its own copy of the data, as RocksDB is not a

[GitHub] [pulsar] merlimat commented on pull request #12776: [metadata] Add RocksdbMetadataStore

2021-11-15 Thread GitBox
merlimat commented on pull request #12776: URL: https://github.com/apache/pulsar/pull/12776#issuecomment-969122620 > Why we need to remove zk from pulsar standalone. It can be an option. > I can still use pulsar standalone to test some metadata storing on zk. For general users, it'

[GitHub] [pulsar] merlimat commented on pull request #12776: [metadata] Add RocksdbMetadataStore

2021-11-15 Thread GitBox
merlimat commented on pull request #12776: URL: https://github.com/apache/pulsar/pull/12776#issuecomment-969120940 > RocksDB is only local, so you could use this mostly only for Pulsar Standalone. Yes, that's the only point of it. > Why should I use RocksDB and not ZooKeeper f

[GitHub] [pulsar] Technoboy- opened a new pull request #12818: PIP 110: Support Topic metadata

2021-11-15 Thread GitBox
Technoboy- opened a new pull request #12818: URL: https://github.com/apache/pulsar/pull/12818 Fixes #12629 ## Motivation The original discussion mail : https://lists.apache.org/thread/m9dkhq1fs6stsdwh78h84fsl5hs5v67f Introduce the ability to store metadata about topics.

[GitHub] [pulsar] yuruguo removed a comment on pull request #12351: [pulsar-admin] Add remove-clusters command for namespace

2021-11-15 Thread GitBox
yuruguo removed a comment on pull request #12351: URL: https://github.com/apache/pulsar/pull/12351#issuecomment-968856427 > @yuruguo we are adding more and more new REST endpoints in order to support this set of commands for pulsar-admin. > > What about creating a list of the feature

[GitHub] [pulsar] yuruguo commented on pull request #12351: [pulsar-admin] Add remove-clusters command for namespace

2021-11-15 Thread GitBox
yuruguo commented on pull request #12351: URL: https://github.com/apache/pulsar/pull/12351#issuecomment-969031722 > @yuruguo we are adding more and more new REST endpoints in order to support this set of commands for pulsar-admin. > > What about creating a list of the features that y

[GitHub] [pulsar] zeo1995 opened a new pull request #12817: [website][upgrade]feat: docs migration - version-2.7.2 Reference

2021-11-15 Thread GitBox
zeo1995 opened a new pull request #12817: URL: https://github.com/apache/pulsar/pull/12817 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] github-actions[bot] commented on pull request #12813: [website][upgrade]feat: docs migration - version-2.7.2 Admin API

2021-11-15 Thread GitBox
github-actions[bot] commented on pull request #12813: URL: https://github.com/apache/pulsar/pull/12813#issuecomment-968975574 @zeo1995:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] zeo1995 opened a new pull request #12816: [website][upgrade]feat: docs migration - version-2.7.2 Develop

2021-11-15 Thread GitBox
zeo1995 opened a new pull request #12816: URL: https://github.com/apache/pulsar/pull/12816 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] zeo1995 opened a new pull request #12815: [website][upgrade]feat: docs migration - version-2.7.2 Cookbooks

2021-11-15 Thread GitBox
zeo1995 opened a new pull request #12815: URL: https://github.com/apache/pulsar/pull/12815 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] zeo1995 opened a new pull request #12814: [website][upgrade]feat: docs migration - version-2.7.2 Adaptors

2021-11-15 Thread GitBox
zeo1995 opened a new pull request #12814: URL: https://github.com/apache/pulsar/pull/12814 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] github-actions[bot] commented on pull request #12813: [website][upgrade]feat: docs migration - version-2.7.2 Admin API

2021-11-15 Thread GitBox
github-actions[bot] commented on pull request #12813: URL: https://github.com/apache/pulsar/pull/12813#issuecomment-968961512 @zeo1995:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/m

[GitHub] [pulsar] zeo1995 opened a new pull request #12813: [website][upgrade]feat: docs migration - version-2.7.2 Admin API

2021-11-15 Thread GitBox
zeo1995 opened a new pull request #12813: URL: https://github.com/apache/pulsar/pull/12813 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[GitHub] [pulsar] sijia-w commented on a change in pull request #12745: [Doc] add explanations for subscription mode

2021-11-15 Thread GitBox
sijia-w commented on a change in pull request #12745: URL: https://github.com/apache/pulsar/pull/12745#discussion_r749361799 ## File path: site2/docs/concepts-messaging.md ## @@ -396,6 +397,57 @@ producer = client.create_producer(topic='my-topic', batching_type=pulsar.Batchin

[GitHub] [pulsar] Jason918 edited a comment on pull request #12753: [Issue 12726][broker] Fix deadlock in metadata-store callback thread

2021-11-15 Thread GitBox
Jason918 edited a comment on pull request #12753: URL: https://github.com/apache/pulsar/pull/12753#issuecomment-968939908 @315157973 Would you please help review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] Jason918 commented on pull request #12753: [Issue 12726][broker] Fix deadlock in metadata-store callback thread

2021-11-15 Thread GitBox
Jason918 commented on pull request #12753: URL: https://github.com/apache/pulsar/pull/12753#issuecomment-968939908 @linlinnn Would you please help review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] mattisonchao commented on issue #8759: DeadLetterPolicy, If allowAutoTopicCreation enabled in broker, the same subscriber name will conflict under different non-partitioned topics

2021-11-15 Thread GitBox
mattisonchao commented on issue #8759: URL: https://github.com/apache/pulsar/issues/8759#issuecomment-968927875 This issue has been fixed by #10129 , I think we should close this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [pulsar] Jason918 opened a new issue #12812: Optimize zookeeper client performance for loading amounts of topics.

2021-11-15 Thread GitBox
Jason918 opened a new issue #12812: URL: https://github.com/apache/pulsar/issues/12812 **Is your enhancement request related to a problem? Please describe.** Optimize zookeeper client performance for loading amounts of topics. Our use case is described here #12651 . **Descr

[GitHub] [pulsar] gaoran10 commented on a change in pull request #12811: [Doc] Add doc for using the Avro JSON schema definition in Python client

2021-11-15 Thread GitBox
gaoran10 commented on a change in pull request #12811: URL: https://github.com/apache/pulsar/pull/12811#discussion_r749313147 ## File path: site2/docs/client-libraries-python.md ## @@ -224,6 +224,71 @@ while True: consumer.negative_acknowledge(msg) ``` +### Using AV

[GitHub] [pulsar] gaoran10 commented on a change in pull request #12811: [Doc] Add doc for using the Avro JSON schema definition in Python client

2021-11-15 Thread GitBox
gaoran10 commented on a change in pull request #12811: URL: https://github.com/apache/pulsar/pull/12811#discussion_r749313147 ## File path: site2/docs/client-libraries-python.md ## @@ -224,6 +224,71 @@ while True: consumer.negative_acknowledge(msg) ``` +### Using AV

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #12811: [Doc] Add doc for using the Avro JSON schema definition in Python client

2021-11-15 Thread GitBox
BewareMyPower commented on a change in pull request #12811: URL: https://github.com/apache/pulsar/pull/12811#discussion_r749310620 ## File path: site2/docs/client-libraries-python.md ## @@ -224,6 +224,71 @@ while True: consumer.negative_acknowledge(msg) ``` +### Usi

  1   2   >