[pulsar] branch branch-2.7 updated (4f19b86 -> a9ce76f)

2021-12-11 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 4f19b86 Upgrade Testcontainers version to 1.15.3 and switch to testcontainers-bom (#10321) add a9ce76f F

[GitHub] [pulsar] michaeljmarshall removed a comment on pull request #13245: Make sure the client can get response when encounter producer busy exception.

2021-12-11 Thread GitBox
michaeljmarshall removed a comment on pull request #13245: URL: https://github.com/apache/pulsar/pull/13245#issuecomment-991842394 Note that when I ran the test for branch-2.7, `ServerCnxTest`, I saw the following stack trace: ``` [ERROR] Tests run: 43, Failures: 1, Errors: 0, Ski

[GitHub] [pulsar] michaeljmarshall commented on pull request #13247: [Broker] Skip response when producerFuture is already complete

2021-12-11 Thread GitBox
michaeljmarshall commented on pull request #13247: URL: https://github.com/apache/pulsar/pull/13247#issuecomment-991845084 I talked this through with @codelipenghui over slack, and we agree that we should not change the behavior in branch 2.7. He committed the test fix here: https://github

[GitHub] [pulsar] michaeljmarshall closed pull request #13247: [Broker] Skip response when producerFuture is already complete

2021-12-11 Thread GitBox
michaeljmarshall closed pull request #13247: URL: https://github.com/apache/pulsar/pull/13247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: comm

[GitHub] [pulsar] Technoboy- commented on a change in pull request #13023: Fix consume message order issue when use listener.

2021-12-11 Thread GitBox
Technoboy- commented on a change in pull request #13023: URL: https://github.com/apache/pulsar/pull/13023#discussion_r767231840 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java ## @@ -916,30 +916,32 @@ private void doPendingBatchReceive

[GitHub] [pulsar] michaeljmarshall edited a comment on pull request #13245: Make sure the client can get response when encounter producer busy exception.

2021-12-11 Thread GitBox
michaeljmarshall edited a comment on pull request #13245: URL: https://github.com/apache/pulsar/pull/13245#issuecomment-991842394 Note that when I ran the test for branch-2.7, `ServerCnxTest`, I saw the following stack trace: ``` [ERROR] Tests run: 43, Failures: 1, Errors: 0, Skip

[GitHub] [pulsar] michaeljmarshall commented on pull request #13245: Make sure the client can get response when encounter producer busy exception.

2021-12-11 Thread GitBox
michaeljmarshall commented on pull request #13245: URL: https://github.com/apache/pulsar/pull/13245#issuecomment-991842394 Note that when I ran the test for branch-2.7, `ServerCnxTest`, I saw the following stack trace: ``` [ERROR] Tests run: 43, Failures: 1, Errors: 0, Skipped: 1,

[GitHub] [pulsar] michaeljmarshall opened a new pull request #13247: [Broker] Skip response when producerFuture is already complete

2021-12-11 Thread GitBox
michaeljmarshall opened a new pull request #13247: URL: https://github.com/apache/pulsar/pull/13247 ### Motivation This PR fixes an issue introduced in branch-2.7 by one of my commits. @codelipenghui has some context in this PR https://github.com/apache/pulsar/pull/13245 and propose

[GitHub] [pulsar] codelipenghui commented on pull request #13245: Make sure the client can get response when encounter producer busy exception.

2021-12-11 Thread GitBox
codelipenghui commented on pull request #13245: URL: https://github.com/apache/pulsar/pull/13245#issuecomment-991840775 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] github-actions[bot] removed a comment on pull request #13242: [Blog] Added Log4j CVE blog post

2021-12-11 Thread GitBox
github-actions[bot] removed a comment on pull request #13242: URL: https://github.com/apache/pulsar/pull/13242#issuecomment-991687460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] merlimat merged pull request #13240: [broker] Replace BaseResources#deleteRecursiveAsync with MetadataStore#deleteRecursive

2021-12-11 Thread GitBox
merlimat merged pull request #13240: URL: https://github.com/apache/pulsar/pull/13240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] codelipenghui merged pull request #13192: [Broker] Add removeMaxConsumersPerSubscription method for v1 namespace

2021-12-11 Thread GitBox
codelipenghui merged pull request #13192: URL: https://github.com/apache/pulsar/pull/13192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [pulsar] codelipenghui commented on pull request #11820: [Functions] ConcurrentHashMap should be used for caching producers

2021-12-11 Thread GitBox
codelipenghui commented on pull request #11820: URL: https://github.com/apache/pulsar/pull/11820#issuecomment-991628151 Removed the release/2.7.4 label due to in branch-2.7, no `publishProducers` for `ContextImpl.java` -- This is an automated message from the Apache Git Service. To respo

[GitHub] [pulsar] lhotari commented on a change in pull request #13242: [Blog] Added Log4j CVE blog post

2021-12-11 Thread GitBox
lhotari commented on a change in pull request #13242: URL: https://github.com/apache/pulsar/pull/13242#discussion_r767173549 ## File path: site2/website/blog/2021-12-11-Log4j-CVE.md ## @@ -0,0 +1,29 @@ +--- +author: Matteo Merli +title: Log4j2 Zero Day vulnerability (CVE-2021-4

[GitHub] [pulsar] sl1316 commented on issue #13174: Pulsar admin api golang client

2021-12-11 Thread GitBox
sl1316 commented on issue #13174: URL: https://github.com/apache/pulsar/issues/13174#issuecomment-991822050 @tuteng thank you! feel free to close the issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar] merlimat commented on a change in pull request #13230: feat(docs): add more limitations for replicated subscriptions

2021-12-11 Thread GitBox
merlimat commented on a change in pull request #13230: URL: https://github.com/apache/pulsar/pull/13230#discussion_r767069070 ## File path: site2/docs/administration-geo.md ## @@ -214,4 +214,5 @@ Consumer consumer = client.newConsumer(Schema.STRING) ### Limitations -When

[GitHub] [pulsar] merlimat merged pull request #13203: Fix when deleting topic with NotFoundException, do not return to client.

2021-12-11 Thread GitBox
merlimat merged pull request #13203: URL: https://github.com/apache/pulsar/pull/13203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] merlimat commented on pull request #13225: Added Etcd MetadataStore implementation

2021-12-11 Thread GitBox
merlimat commented on pull request #13225: URL: https://github.com/apache/pulsar/pull/13225#issuecomment-991506253 > do we need a PIP here ? it is a big feature If you discount the license files, it's 1 single file containing an implementation which is not enabled by default and whic

[GitHub] [pulsar] congbobo184 commented on a change in pull request #13135: [Transaction]No TransactionCoordinatorNotFound, but automatic reconnect

2021-12-11 Thread GitBox
congbobo184 commented on a change in pull request #13135: URL: https://github.com/apache/pulsar/pull/13135#discussion_r766675485 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/TransactionMetaStoreHandler.java ## @@ -158,6 +178,12 @@ public void connect

[GitHub] [pulsar] Jason918 commented on pull request #13240: [broker] Replace BaseResources#deleteRecursiveAsync with MetadataStore#deleteRecursive

2021-12-11 Thread GitBox
Jason918 commented on pull request #13240: URL: https://github.com/apache/pulsar/pull/13240#issuecomment-991605178 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar-client-go] longtengz commented on issue #681: DisableBatching still go thru the batching logic and AUTO_CONSUME can not consume with correct schema type

2021-12-11 Thread GitBox
longtengz commented on issue #681: URL: https://github.com/apache/pulsar-client-go/issues/681#issuecomment-991433969 That seems very confusing to me. If batch is disabled, why using a batchBuilder? From the comments in the code, I assume there's a difference in the format of batch message

[GitHub] [pulsar] HQebupt commented on pull request #13115: [managed-ledger] [code cleanup] unused local variable in ManagedLedgerImpl

2021-12-11 Thread GitBox
HQebupt commented on pull request #13115: URL: https://github.com/apache/pulsar/pull/13115#issuecomment-991554899 @Shoothzj Hi, Could you please help to merge it because the merging is blocked, At least 1 approving review is required by reviewers with write access. Thank you in advance.

[GitHub] [pulsar-client-go] zzzming commented on issue #681: DisableBatching still go thru the batching logic and AUTO_CONSUME can not consume with correct schema type

2021-12-11 Thread GitBox
zzzming commented on issue #681: URL: https://github.com/apache/pulsar-client-go/issues/681#issuecomment-991325782 @longtengz Messages flushed by the BatchBuilder's through internalFlushCurrentBatch(). Even if the batch is disabled, the message still needs to be added to a batchBuilder. W

[GitHub] [pulsar] eolivelli commented on pull request #13225: Added Etcd MetadataStore implementation

2021-12-11 Thread GitBox
eolivelli commented on pull request #13225: URL: https://github.com/apache/pulsar/pull/13225#issuecomment-991498781 do we need a PIP here ? it is a big feature -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [pulsar] hangc0276 commented on issue #13238: Should introduce deleting state for ledger deletion

2021-12-11 Thread GitBox
hangc0276 commented on issue #13238: URL: https://github.com/apache/pulsar/issues/13238#issuecomment-991525734 @wuzhanpeng Thanks for your help, I have assigned this issue to you. If you have any questions or need any help, please ping me at any time. You'd better write a proposal first.

[GitHub] [pulsar] merlimat commented on a change in pull request #13225: Added Etcd MetadataStore implementation

2021-12-11 Thread GitBox
merlimat commented on a change in pull request #13225: URL: https://github.com/apache/pulsar/pull/13225#discussion_r767103805 ## File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/EtcdMetadataStore.java ## @@ -0,0 +1,423 @@ +/** + * Licensed to the Apache

[GitHub] [pulsar] sicklife commented on issue #13167: Not enough non-faulty bookies available

2021-12-11 Thread GitBox
sicklife commented on issue #13167: URL: https://github.com/apache/pulsar/issues/13167#issuecomment-991829361 > I got the same error, my broker config is `managedLedgerDefaultEnsembleSize=2` what should I do to fix this error? -- This is an automated message from the

[GitHub] [pulsar-client-go] zzzming commented on pull request #678: [Issue 513] Correct apparent logic error in batchContainer's hasSpace() method

2021-12-11 Thread GitBox
zzzming commented on pull request #678: URL: https://github.com/apache/pulsar-client-go/pull/678#issuecomment-991337168 We should use this ``` bc.numMessages+1 <= bc.maxMessages ``` Because this will accommodate an individual message when batch is disabled. Currently this

[GitHub] [pulsar] merlimat merged pull request #13242: [Blog] Added Log4j CVE blog post

2021-12-11 Thread GitBox
merlimat merged pull request #13242: URL: https://github.com/apache/pulsar/pull/13242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] github-actions[bot] commented on pull request #13239: [pulsar-client]Add getNumPartitions method into PartitionedProducerImpl

2021-12-11 Thread GitBox
github-actions[bot] commented on pull request #13239: URL: https://github.com/apache/pulsar/pull/13239#issuecomment-991575256 @HQebupt:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/m

[GitHub] [pulsar] codelipenghui commented on a change in pull request #13239: [pulsar-client]Add getNumPartitions method into PartitionedProducerImpl

2021-12-11 Thread GitBox
codelipenghui commented on a change in pull request #13239: URL: https://github.com/apache/pulsar/pull/13239#discussion_r767168311 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PartitionedProducerImpl.java ## @@ -438,4 +438,13 @@ public Timeout getPar

[GitHub] [pulsar] michaeljmarshall commented on pull request #11599: [Broker] Remove RateLimiter constructors and replace with builder usage

2021-12-11 Thread GitBox
michaeljmarshall commented on pull request #11599: URL: https://github.com/apache/pulsar/pull/11599#issuecomment-991505534 Cherry picked to `branch-2.7` because one of the lines it removes is longer than 120 characters. Now `branch-2.7` passes checkstyle. -- This is an automated message

[GitHub] [pulsar] codelipenghui merged pull request #13234: [Transaction] Fix generate transactionId some comments

2021-12-11 Thread GitBox
codelipenghui merged pull request #13234: URL: https://github.com/apache/pulsar/pull/13234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [pulsar] merlimat closed issue #12554: Attempting to delete a topic which has recently been created sometimes fails with a 500 error, with an internal broker error of "Maximum redirect reache

2021-12-11 Thread GitBox
merlimat closed issue #12554: URL: https://github.com/apache/pulsar/issues/12554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[GitHub] [pulsar] codelipenghui commented on pull request #13233: [Client] Fix memory leak when message payload processor is configured

2021-12-11 Thread GitBox
codelipenghui commented on pull request #13233: URL: https://github.com/apache/pulsar/pull/13233#issuecomment-991710265 > BTW, I have sent an email to discuss about if there is any way to detect unused variables. If we can detect the unused private fields in CI, this bug could be exposed i

[GitHub] [pulsar] Demogorgon314 commented on a change in pull request #13236: [C++] Add Wireshark cmake and fix build with latest Wireshark

2021-12-11 Thread GitBox
Demogorgon314 commented on a change in pull request #13236: URL: https://github.com/apache/pulsar/pull/13236#discussion_r767137910 ## File path: pulsar-client-cpp/CMakeLists.txt ## @@ -58,6 +58,9 @@ MESSAGE(STATUS "BUILD_TESTS: " ${BUILD_TESTS}) option(BUILD_PYTHON_WRAPPER "B

[GitHub] [pulsar] wuzhanpeng commented on issue #13238: Should introduce deleting state for ledger deletion

2021-12-11 Thread GitBox
wuzhanpeng commented on issue #13238: URL: https://github.com/apache/pulsar/issues/13238#issuecomment-991524211 I can help with this issue~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [pulsar] codelipenghui commented on pull request #13243: [Don't merge] Bump Pulsar 2.7.5-SNAPSHOT

2021-12-11 Thread GitBox
codelipenghui commented on pull request #13243: URL: https://github.com/apache/pulsar/pull/13243#issuecomment-991836462 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] yuruguo commented on pull request #13237: [Broker] Modify return result of NamespacesBase#internalGetPublishRate

2021-12-11 Thread GitBox
yuruguo commented on pull request #13237: URL: https://github.com/apache/pulsar/pull/13237#issuecomment-991490945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [pulsar] codelipenghui commented on pull request #11852: [Issue 11814] fix pulsar admin method:getMessageById.

2021-12-11 Thread GitBox
codelipenghui commented on pull request #11852: URL: https://github.com/apache/pulsar/pull/11852#issuecomment-991632203 Remove the release/2.7.4 label, #11913 already fixed the branch-2.7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar] BewareMyPower commented on pull request #13243: [Don't merge] Bump Pulsar 2.7.5-SNAPSHOT

2021-12-11 Thread GitBox
BewareMyPower commented on pull request #13243: URL: https://github.com/apache/pulsar/pull/13243#issuecomment-991733728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [pulsar] codelipenghui closed issue #13119: Load balance shedding not in time with the strategy of ThresholdShedder

2021-12-11 Thread GitBox
codelipenghui closed issue #13119: URL: https://github.com/apache/pulsar/issues/13119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] ltamber commented on pull request #9219: support unackMessages stats for cumulative ack

2021-12-11 Thread GitBox
ltamber commented on pull request #9219: URL: https://github.com/apache/pulsar/pull/9219#issuecomment-991823800 > @ltamber - do you plan on completing the work for this PR? There are conflicts right now. As such, I am going to remove the 2.7.4 label. I added the 2.10 milestone. If/when we

[GitHub] [pulsar] lhotari closed pull request #13122: Trigger a build for branch-2.8 to see if the build passes

2021-12-11 Thread GitBox
lhotari closed pull request #13122: URL: https://github.com/apache/pulsar/pull/13122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [pulsar] github-actions[bot] commented on pull request #13242: [Blog] Added Log4j CVE blog post

2021-12-11 Thread GitBox
github-actions[bot] commented on pull request #13242: URL: https://github.com/apache/pulsar/pull/13242#issuecomment-991687462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] codelipenghui merged pull request #13136: Use current resourceUsage value as historyUsage when leader change in ThresholdShedder

2021-12-11 Thread GitBox
codelipenghui merged pull request #13136: URL: https://github.com/apache/pulsar/pull/13136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [pulsar] michaeljmarshall commented on pull request #10017: [pulsar-client] Process partitioned-topic messages on different listener-threads

2021-12-11 Thread GitBox
michaeljmarshall commented on pull request #10017: URL: https://github.com/apache/pulsar/pull/10017#issuecomment-991370606 Cherry picking this to branch-2.7 because https://github.com/apache/pulsar/pull/11455 relies on part of it, and it simplifies the conflict resolution for the other com

[GitHub] [pulsar] Jason918 commented on pull request #13241: [broker] Optimize TopicPolicies#messageTTLInSeconds with HierarchyTopicPolicies

2021-12-11 Thread GitBox
Jason918 commented on pull request #13241: URL: https://github.com/apache/pulsar/pull/13241#issuecomment-991665443 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] ltamber closed pull request #9219: support unackMessages stats for cumulative ack

2021-12-11 Thread GitBox
ltamber closed pull request #9219: URL: https://github.com/apache/pulsar/pull/9219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [pulsar] wuzhanpeng commented on pull request #13208: fix shedding heartbeat ns

2021-12-11 Thread GitBox
wuzhanpeng commented on pull request #13208: URL: https://github.com/apache/pulsar/pull/13208#issuecomment-991510868 I think the proposal of `getBundleDataForLoadShedding` is great, it can effectively reduce the redundancy of the code, I have made changes, @Jason918 @hangc0276 can take a l

[pulsar] 02/02: Upgrade Testcontainers version to 1.15.3 and switch to testcontainers-bom (#10321)

2021-12-11 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 4f19b8622d5d0d17973399883e492b839fc30f0a Author: Lari Hotari AuthorDate: Thu Apr 22 21:39:35 2021 +0300 Upgrad

[pulsar] 01/02: Upgrade TestContainers to 1.15.1 (#9120)

2021-12-11 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit dda795d3f8a1ffa766a10902295576afafca86ec Author: Matteo Merli AuthorDate: Tue Jan 5 21:21:52 2021 -0800 Upgrad

[GitHub] [pulsar-client-go] zzzming edited a comment on issue #681: DisableBatching still go thru the batching logic and AUTO_CONSUME can not consume with correct schema type

2021-12-11 Thread GitBox
zzzming edited a comment on issue #681: URL: https://github.com/apache/pulsar-client-go/issues/681#issuecomment-991325782 @longtengz Messages flushed by the BatchBuilder's through internalFlushCurrentBatch(). Even if the batch is disabled, the message still needs to be added to a batchBui

[GitHub] [pulsar] eolivelli commented on a change in pull request #13135: [Transaction]No TransactionCoordinatorNotFound, but automatic reconnect

2021-12-11 Thread GitBox
eolivelli commented on a change in pull request #13135: URL: https://github.com/apache/pulsar/pull/13135#discussion_r767102340 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java ## @@ -1997,7 +1997,31 @@ private boolean checkTransactionEn

[pulsar] branch branch-2.7 updated (e99777a -> 4f19b86)

2021-12-11 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git. from e99777a [Broker] Fix producer getting incorrectly removed from topic's producers map (#12846) new dda795d

[GitHub] [pulsar] github-actions[bot] commented on pull request #13234: [Transaction] Fix generate transactionId some comments

2021-12-11 Thread GitBox
github-actions[bot] commented on pull request #13234: URL: https://github.com/apache/pulsar/pull/13234#issuecomment-991400652 @congbobo184:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] liangyepianzhou commented on a change in pull request #13135: [Transaction]No TransactionCoordinatorNotFound, but automatic reconnect

2021-12-11 Thread GitBox
liangyepianzhou commented on a change in pull request #13135: URL: https://github.com/apache/pulsar/pull/13135#discussion_r767078065 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/TransactionMetaStoreHandler.java ## @@ -294,7 +340,27 @@ public void ha

[GitHub] [pulsar] yuruguo removed a comment on pull request #13237: [Broker] Modify return result of NamespacesBase#internalGetPublishRate

2021-12-11 Thread GitBox
yuruguo removed a comment on pull request #13237: URL: https://github.com/apache/pulsar/pull/13237#issuecomment-991490945 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar] HQebupt commented on a change in pull request #13239: [pulsar-client]Add getNumPartitions method into PartitionedProducerImpl

2021-12-11 Thread GitBox
HQebupt commented on a change in pull request #13239: URL: https://github.com/apache/pulsar/pull/13239#discussion_r767168615 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PartitionedProducerImpl.java ## @@ -438,4 +438,13 @@ public Timeout getPartition

[GitHub] [pulsar] michaeljmarshall commented on pull request #11912: Forbid to read other topic's data in managedLedger layer

2021-12-11 Thread GitBox
michaeljmarshall commented on pull request #11912: URL: https://github.com/apache/pulsar/pull/11912#issuecomment-991480744 Note that this commit is not cherry picked to `branch-2.7` because the same changes are merged here https://github.com/apache/pulsar/pull/11913. -- This is an automa

[GitHub] [pulsar] codelipenghui commented on pull request #13138: [Broker] Remove tenant permission verification when list partitioned-topic

2021-12-11 Thread GitBox
codelipenghui commented on pull request #13138: URL: https://github.com/apache/pulsar/pull/13138#issuecomment-991570118 @michaeljmarshall Could you please help take a look at this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] codelipenghui commented on pull request #12484: [Branch-2.7] Fixed deadlock on metadata cache missing while doing che…

2021-12-11 Thread GitBox
codelipenghui commented on pull request #12484: URL: https://github.com/apache/pulsar/pull/12484#issuecomment-991834998 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] Jason918 commented on a change in pull request #13225: Added Etcd MetadataStore implementation

2021-12-11 Thread GitBox
Jason918 commented on a change in pull request #13225: URL: https://github.com/apache/pulsar/pull/13225#discussion_r767089475 ## File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/EtcdMetadataStore.java ## @@ -0,0 +1,423 @@ +/** + * Licensed to the Apache

[GitHub] [pulsar] merlimat commented on a change in pull request #13236: [C++] Add Wireshark cmake and fix build with latest Wireshark

2021-12-11 Thread GitBox
merlimat commented on a change in pull request #13236: URL: https://github.com/apache/pulsar/pull/13236#discussion_r767104183 ## File path: pulsar-client-cpp/CMakeLists.txt ## @@ -58,6 +58,9 @@ MESSAGE(STATUS "BUILD_TESTS: " ${BUILD_TESTS}) option(BUILD_PYTHON_WRAPPER "Build

[GitHub] [pulsar] michaeljmarshall commented on pull request #10775: Run code to respond to auth challenge in a different thread in the pulsar client

2021-12-11 Thread GitBox
michaeljmarshall commented on pull request #10775: URL: https://github.com/apache/pulsar/pull/10775#issuecomment-991325796 Removing `release/2.7.4` label, as this PR will not make the release. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [pulsar] hangc0276 commented on issue #13148: Cluster switching failed for producers

2021-12-11 Thread GitBox
hangc0276 commented on issue #13148: URL: https://github.com/apache/pulsar/issues/13148#issuecomment-991425783 We are designing a proposal for auto switch cluster service provider when one cluster is failed. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar] Demogorgon314 opened a new pull request #13246: [C++] Support arm64 optimized CRC32c hardware-instructions

2021-12-11 Thread GitBox
Demogorgon314 opened a new pull request #13246: URL: https://github.com/apache/pulsar/pull/13246 ### Motivation Add arm64 optimized crc32c instructions support to optimize arm64 performance. ### Modifications Add arm64 optimized crc32c instructions support. ### V

[GitHub] [pulsar] codelipenghui commented on pull request #13243: [Don't merge] Bump Pulsar 2.7.5-SNAPSHOT

2021-12-11 Thread GitBox
codelipenghui commented on pull request #13243: URL: https://github.com/apache/pulsar/pull/13243#issuecomment-991836462 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] codelipenghui opened a new pull request #13245: Make sure the client can get response when encounter producer busy exception.

2021-12-11 Thread GitBox
codelipenghui opened a new pull request #13245: URL: https://github.com/apache/pulsar/pull/13245 When the producer with the same producer ID and same connection, Of course, this usually doesn't happen. When cherry-picking #12846, the test using the same producer ID https://github.com/

[GitHub] [pulsar] codelipenghui commented on pull request #12484: [Branch-2.7] Fixed deadlock on metadata cache missing while doing che…

2021-12-11 Thread GitBox
codelipenghui commented on pull request #12484: URL: https://github.com/apache/pulsar/pull/12484#issuecomment-991834998 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[pulsar] 01/01: [Broker] Fix producer getting incorrectly removed from topic's producers map (#12846)

2021-12-11 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit e99777a55740470aa2d807ecc32093b871d28f6e Author: Michael Marshall AuthorDate: Thu Nov 18 02:42:56 2021 -0600 [

[pulsar] branch branch-2.7 updated (b118aa7 -> e99777a)

2021-12-11 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git. omit b118aa7 [Broker] Fix producer getting incorrectly removed from topic's producers map (#12846) new e99777a

[pulsar] branch branch-2.7 updated: [Broker] Fix producer getting incorrectly removed from topic's producers map (#12846)

2021-12-11 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.7 by this push: new b118aa7 [Broker] Fix producer getting

[GitHub] [pulsar] sicklife commented on issue #13167: Not enough non-faulty bookies available

2021-12-11 Thread GitBox
sicklife commented on issue #13167: URL: https://github.com/apache/pulsar/issues/13167#issuecomment-991829361 > I got the same error, my broker config is `managedLedgerDefaultEnsembleSize=2` what should I do to fix this error? -- This is an automated message from the

[GitHub] [pulsar] imaffe opened a new issue #13244: [Enhancement] Use SonarQube to run static code analysis for detecting bugs early

2021-12-11 Thread GitBox
imaffe opened a new issue #13244: URL: https://github.com/apache/pulsar/issues/13244 **Is your enhancement request related to a problem? Please describe.** Current code analysis tool is not able to detect unused variables, which can be potential bugs. Using SonarQube can mitigate this pr

[pulsar] branch branch-2.7 updated (f8389fd -> 76bdbda)

2021-12-11 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git. from f8389fd [C++] Removed usages of boost::regex (#9533) add 76bdbda Fix expired tls certs for cpp tests (#96

[GitHub] [pulsar] ltamber closed pull request #9219: support unackMessages stats for cumulative ack

2021-12-11 Thread GitBox
ltamber closed pull request #9219: URL: https://github.com/apache/pulsar/pull/9219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [pulsar] ltamber commented on pull request #9219: support unackMessages stats for cumulative ack

2021-12-11 Thread GitBox
ltamber commented on pull request #9219: URL: https://github.com/apache/pulsar/pull/9219#issuecomment-991823800 > @ltamber - do you plan on completing the work for this PR? There are conflicts right now. As such, I am going to remove the 2.7.4 label. I added the 2.10 milestone. If/when we

[GitHub] [pulsar] sl1316 commented on issue #13174: Pulsar admin api golang client

2021-12-11 Thread GitBox
sl1316 commented on issue #13174: URL: https://github.com/apache/pulsar/issues/13174#issuecomment-991822050 @tuteng thank you! feel free to close the issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar-client-go] zzzming opened a new pull request #684: Use critical section for batch counters in producer default_router

2021-12-11 Thread GitBox
zzzming opened a new pull request #684: URL: https://github.com/apache/pulsar-client-go/pull/684 ### Motivation A group of batch counters are not properly critical section protected in the producer's default_router. Read and update of these counters should be protected as a whole, i

[GitHub] [pulsar] BewareMyPower commented on pull request #13243: [Don't merge] Bump Pulsar 2.7.5-SNAPSHOT

2021-12-11 Thread GitBox
BewareMyPower commented on pull request #13243: URL: https://github.com/apache/pulsar/pull/13243#issuecomment-991771453 It looks like https://github.com/apache/pulsar/pull/8560 caused the conflict, see [here](https://github.com/apache/pulsar/pull/8560/files#diff-3f27622d4725350710f27dff139

[GitHub] [pulsar] BewareMyPower commented on pull request #13243: [Don't merge] Bump Pulsar 2.7.5-SNAPSHOT

2021-12-11 Thread GitBox
BewareMyPower commented on pull request #13243: URL: https://github.com/apache/pulsar/pull/13243#issuecomment-991770173 https://github.com/apache/pulsar/pull/9607 also needs to be cherry-picked. But I encountered a conflict in pulsar-broker/src/test/java/org/apache/pulsar/io/PulsarFunction

[pulsar] branch master updated: replace BaseResources#deleteRecursive with MetadataStore#deleteRecursive (#13240)

2021-12-11 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 342fb54 replace BaseResources#deleteRecursive w

[GitHub] [pulsar] merlimat merged pull request #13240: [broker] Replace BaseResources#deleteRecursiveAsync with MetadataStore#deleteRecursive

2021-12-11 Thread GitBox
merlimat merged pull request #13240: URL: https://github.com/apache/pulsar/pull/13240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [pulsar] BewareMyPower commented on pull request #13243: [Don't merge] Bump Pulsar 2.7.5-SNAPSHOT

2021-12-11 Thread GitBox
BewareMyPower commented on pull request #13243: URL: https://github.com/apache/pulsar/pull/13243#issuecomment-991733728 The C++ client build error is caused by the cherry-pick of https://github.com/apache/pulsar/pull/9533. It should be based on https://github.com/apache/pulsar/pull/9498 fi

[pulsar] branch master updated (7427791 -> 3f79290)

2021-12-11 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 7427791 [Broker] Add removeMaxConsumersPerSubscription method for v1 namespace (#13192) add 3f79290 [Blog] Ad

[GitHub] [pulsar] merlimat merged pull request #13242: [Blog] Added Log4j CVE blog post

2021-12-11 Thread GitBox
merlimat merged pull request #13242: URL: https://github.com/apache/pulsar/pull/13242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[pulsar] branch branch-2.7 updated (f46bb61 -> f8389fd)

2021-12-11 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a change to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git. from f46bb61 [CI][C++] Force CMake to find Python2 (#9690) add 554f2cd Revert "[C++] Removed usages of boost::rege

[GitHub] [pulsar] lhotari commented on a change in pull request #13242: [Blog] Added Log4j CVE blog post

2021-12-11 Thread GitBox
lhotari commented on a change in pull request #13242: URL: https://github.com/apache/pulsar/pull/13242#discussion_r767173549 ## File path: site2/website/blog/2021-12-11-Log4j-CVE.md ## @@ -0,0 +1,29 @@ +--- +author: Matteo Merli +title: Log4j2 Zero Day vulnerability (CVE-2021-4

[GitHub] [pulsar] codelipenghui commented on pull request #13233: [Client] Fix memory leak when message payload processor is configured

2021-12-11 Thread GitBox
codelipenghui commented on pull request #13233: URL: https://github.com/apache/pulsar/pull/13233#issuecomment-991710265 > BTW, I have sent an email to discuss about if there is any way to detect unused variables. If we can detect the unused private fields in CI, this bug could be exposed i

[GitHub] [pulsar] HQebupt commented on a change in pull request #13239: [pulsar-client]Add getNumPartitions method into PartitionedProducerImpl

2021-12-11 Thread GitBox
HQebupt commented on a change in pull request #13239: URL: https://github.com/apache/pulsar/pull/13239#discussion_r767169893 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PartitionedProducerImpl.java ## @@ -438,4 +438,13 @@ public Timeout getPartition

[GitHub] [pulsar] HQebupt commented on a change in pull request #13239: [pulsar-client]Add getNumPartitions method into PartitionedProducerImpl

2021-12-11 Thread GitBox
HQebupt commented on a change in pull request #13239: URL: https://github.com/apache/pulsar/pull/13239#discussion_r767168615 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PartitionedProducerImpl.java ## @@ -438,4 +438,13 @@ public Timeout getPartition

[GitHub] [pulsar] codelipenghui commented on a change in pull request #13239: [pulsar-client]Add getNumPartitions method into PartitionedProducerImpl

2021-12-11 Thread GitBox
codelipenghui commented on a change in pull request #13239: URL: https://github.com/apache/pulsar/pull/13239#discussion_r767168311 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PartitionedProducerImpl.java ## @@ -438,4 +438,13 @@ public Timeout getPar

[pulsar] 11/11: [CI][C++] Force CMake to find Python2 (#9690)

2021-12-11 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit f46bb61e78daed0a3ebf688426d1ade4d0a6aa7d Author: Yunze Xu AuthorDate: Thu Feb 25 17:08:18 2021 +0800 [CI][C++]

[pulsar] 10/11: [C++] Removed usages of boost::regex (#9533)

2021-12-11 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 63327872d312e660bc14cbcf01bc7ae6ae21c5f5 Author: Matteo Merli AuthorDate: Tue Feb 9 17:08:44 2021 -0800 [C++]

[pulsar] 09/11: [Broker] Optimize ManagedLedger Ledger Ownership Check (#13222)

2021-12-11 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit df0e021422ee17ee393dbb0bb9c125009ce5e5d2 Author: Michael Marshall AuthorDate: Thu Dec 9 18:11:50 2021 -0600 [B

[pulsar] 07/11: Fix update ledger list to znode version mismatch failed, ledger not delete (#12015)

2021-12-11 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 32f7b4ff50795ca77022b07e800ee4a982f952aa Author: Hang Chen AuthorDate: Mon Nov 29 12:22:55 2021 +0800 Fix upda

[pulsar] 06/11: Do not reuse the Failed OpAddEntry object. (#12993)

2021-12-11 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 7a797c7e61f7cacac6d70fd5a27a70a65a7c6910 Author: lipenghui AuthorDate: Sat Nov 27 09:21:01 2021 +0800 Do not r

[pulsar] 08/11: [Java Client] Send CloseProducer on timeout (#13161)

2021-12-11 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 50632a75d552b182239a967759086a2cb14e5e8b Author: Michael Marshall AuthorDate: Thu Dec 9 13:17:13 2021 -0600 [J

[pulsar] 05/11: Fix log level config for pulsar-admin, pulsar-client and pulsar-perf (#12915)

2021-12-11 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.7 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 4d7ca0e5fcb3b47dad2e1e6c13b88a894c7f25ce Author: Lari Hotari AuthorDate: Mon Nov 22 19:38:22 2021 +0200 Fix lo

  1   2   >