[GitHub] [pulsar] equanz commented on pull request #12401: [PIP 79][common,broker,client] Change PartitionedTopicStats to aggregate by producerName

2022-01-12 Thread GitBox
equanz commented on pull request #12401: URL: https://github.com/apache/pulsar/pull/12401#issuecomment-1011884984 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] paladin-dalao opened a new issue #13735: cpp client coredump

2022-01-12 Thread GitBox
paladin-dalao opened a new issue #13735: URL: https://github.com/apache/pulsar/issues/13735 **Describe the bug** There was a sudden crash when our service was running **To Reproduce** Steps to reproduce the behavior: I don't konw how to reproduce **Expected

[GitHub] [pulsar] wolfstudy commented on pull request #12223: fix lost message issues 12221

2022-01-12 Thread GitBox
wolfstudy commented on pull request #12223: URL: https://github.com/apache/pulsar/pull/12223#issuecomment-1011880238 cc @baomingyu @315157973 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] wolfstudy commented on pull request #12223: fix lost message issues 12221

2022-01-12 Thread GitBox
wolfstudy commented on pull request #12223: URL: https://github.com/apache/pulsar/pull/12223#issuecomment-1011880047 ``` Found one Java-level deadlock: = "ZKC-connect-executor-0-SendThread(9.142.172.233:2181)": waiting to lock monitor

[GitHub] [pulsar-client-go] GPrabhudas opened a new issue #707: Race condition detected for producer/consumer when encryption is enabled

2022-01-12 Thread GitBox
GPrabhudas opened a new issue #707: URL: https://github.com/apache/pulsar-client-go/issues/707 Expected behaviour Creation of producer/consumer on partitioned topic should not run into race condition. Actual behaviour For partitioned topic, creation of producer

[GitHub] [pulsar] suiyuzeng commented on pull request #13537: repeat registration when unload a bundle

2022-01-12 Thread GitBox
suiyuzeng commented on pull request #13537: URL: https://github.com/apache/pulsar/pull/13537#issuecomment-1011871014 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar] vinz2714 commented on pull request #10525: [Transaction] Fix transaction buffer delete marker problem.

2022-01-12 Thread GitBox
vinz2714 commented on pull request #10525: URL: https://github.com/apache/pulsar/pull/10525#issuecomment-1011850062 Is this issue resolved/address on v2.9.1? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar] equanz commented on pull request #12401: [PIP 79][common,broker,client] Change PartitionedTopicStats to aggregate by producerName

2022-01-12 Thread GitBox
equanz commented on pull request #12401: URL: https://github.com/apache/pulsar/pull/12401#issuecomment-1011840905 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] Shoothzj commented on a change in pull request #13502: Delete the unused variable in PrometheusMetricsServlet

2022-01-12 Thread GitBox
Shoothzj commented on a change in pull request #13502: URL: https://github.com/apache/pulsar/pull/13502#discussion_r783663070 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsServlet.java ## @@ -100,8 +100,7 @@ protected

[pulsar] branch master updated (8a0cfac -> 0648f6b)

2022-01-12 Thread mmarshall
This is an automated email from the ASF dual-hosted git repository. mmarshall pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 8a0cfac [website][upgrade] feat: code guide page, contributing page and events page (#13700) add 0648f6b

[GitHub] [pulsar] michaeljmarshall merged pull request #13529: support dynamic config for replicationProducerQueueSize

2022-01-12 Thread GitBox
michaeljmarshall merged pull request #13529: URL: https://github.com/apache/pulsar/pull/13529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] michaeljmarshall commented on pull request #13529: support dynamic config for replicationProducerQueueSize

2022-01-12 Thread GitBox
michaeljmarshall commented on pull request #13529: URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1011832179 @lordcheng10 - thanks for the explanation and references. I didn't know it worked that way. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] Shoothzj commented on a change in pull request #12782: [SpotBugs][pulsar-io]Enable spotbugs for pulsar-io-hdfs2 and pulsar-io-hdfs3

2022-01-12 Thread GitBox
Shoothzj commented on a change in pull request #12782: URL: https://github.com/apache/pulsar/pull/12782#discussion_r783658820 ## File path: pulsar-io/hdfs3/src/main/resources/findbugsExclude.xml ## @@ -0,0 +1,22 @@ + + + Review comment: better to add new line on file

[GitHub] [pulsar] Shoothzj commented on a change in pull request #12782: [SpotBugs][pulsar-io]Enable spotbugs for pulsar-io-hdfs2 and pulsar-io-hdfs3

2022-01-12 Thread GitBox
Shoothzj commented on a change in pull request #12782: URL: https://github.com/apache/pulsar/pull/12782#discussion_r783658723 ## File path: pulsar-io/hdfs3/src/main/resources/findbugsExclude.xml ## @@ -0,0 +1,22 @@ + + + Review comment: ```suggestion ```

[GitHub] [pulsar] eolivelli commented on a change in pull request #13502: Delete the unused variable in PrometheusMetricsServlet

2022-01-12 Thread GitBox
eolivelli commented on a change in pull request #13502: URL: https://github.com/apache/pulsar/pull/13502#discussion_r783658547 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsServlet.java ## @@ -100,8 +100,7 @@ protected

[GitHub] [pulsar] lordcheng10 edited a comment on pull request #13529: support dynamic config for replicationProducerQueueSize

2022-01-12 Thread GitBox
lordcheng10 edited a comment on pull request #13529: URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1011827318 > @lordcheng10 - after looking at this again, I'm not sure that it will work properly. As far as I can tell, we read the configuration file once at broker start

[GitHub] [pulsar] lordcheng10 edited a comment on pull request #13529: support dynamic config for replicationProducerQueueSize

2022-01-12 Thread GitBox
lordcheng10 edited a comment on pull request #13529: URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1011827318 > @lordcheng10 - after looking at this again, I'm not sure that it will work properly. As far as I can tell, we read the configuration file once at broker start

[GitHub] [pulsar] zxJin-x commented on pull request #13502: Delete the unused variable in PrometheusMetricsServlet

2022-01-12 Thread GitBox
zxJin-x commented on pull request #13502: URL: https://github.com/apache/pulsar/pull/13502#issuecomment-1011829083 @eolivelli PTAL, again, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] zxJin-x removed a comment on pull request #13502: Delete the unused variable in PrometheusMetricsServlet

2022-01-12 Thread GitBox
zxJin-x removed a comment on pull request #13502: URL: https://github.com/apache/pulsar/pull/13502#issuecomment-1009930440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [pulsar] lordcheng10 edited a comment on pull request #13529: support dynamic config for replicationProducerQueueSize

2022-01-12 Thread GitBox
lordcheng10 edited a comment on pull request #13529: URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1011827318 > @lordcheng10 - after looking at this again, I'm not sure that it will work properly. As far as I can tell, we read the configuration file once at broker start

[GitHub] [pulsar] lordcheng10 edited a comment on pull request #13529: support dynamic config for replicationProducerQueueSize

2022-01-12 Thread GitBox
lordcheng10 edited a comment on pull request #13529: URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1011827318 > @lordcheng10 - after looking at this again, I'm not sure that it will work properly. As far as I can tell, we read the configuration file once at broker start

[GitHub] [pulsar] lordcheng10 commented on pull request #13529: support dynamic config for replicationProducerQueueSize

2022-01-12 Thread GitBox
lordcheng10 commented on pull request #13529: URL: https://github.com/apache/pulsar/pull/13529#issuecomment-1011827318 > @lordcheng10 - after looking at this again, I'm not sure that it will work properly. As far as I can tell, we read the configuration file once at broker start up. Have

[GitHub] [pulsar] limbonicat opened a new issue #13734: Websocket Client TLS not supported on Win7/8 (handshake failure)

2022-01-12 Thread GitBox
limbonicat opened a new issue #13734: URL: https://github.com/apache/pulsar/issues/13734 **Describe the bug** Handshake failure error occurd when websocket client connect to Pulsar(Standalone mode) ; But its worked well on Win10 or Android or use other client(like Java Client);

[GitHub] [pulsar] gaozhangmin commented on issue #13713: [2.7.4] NPE while open reader to pulsar topic

2022-01-12 Thread GitBox
gaozhangmin commented on issue #13713: URL: https://github.com/apache/pulsar/issues/13713#issuecomment-1011805696 #12297 had fixed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] lordcheng10 commented on a change in pull request #13681: Collect broker dispatch latency in prometheus

2022-01-12 Thread GitBox
lordcheng10 commented on a change in pull request #13681: URL: https://github.com/apache/pulsar/pull/13681#discussion_r783621454 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java ## @@ -550,7

[GitHub] [pulsar] yuruguo removed a comment on pull request #13543: [Broker] Other old values are still valid when updating resource group

2022-01-12 Thread GitBox
yuruguo removed a comment on pull request #13543: URL: https://github.com/apache/pulsar/pull/13543#issuecomment-1011652705 @codelipenghui ptal thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[pulsar] branch master updated (c1a31fd -> 8a0cfac)

2022-01-12 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from c1a31fd fix checkstyle for TableViewBuilder (#13727) add 8a0cfac [website][upgrade] feat: code guide page,

[GitHub] [pulsar] AnonHxy commented on pull request #13710: [broker] Optimize TopicPolicies#compactionThreshold with HierarchyTopicPolicies

2022-01-12 Thread GitBox
AnonHxy commented on pull request #13710: URL: https://github.com/apache/pulsar/pull/13710#issuecomment-1011773324 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar-client-go] wolfstudy opened a new pull request #706: fix batchIdx error for non-batch message

2022-01-12 Thread GitBox
wolfstudy opened a new pull request #706: URL: https://github.com/apache/pulsar-client-go/pull/706 Signed-off-by: xiaolongran ### Motivation When producer send message or consumer receive message in non-batch, return the batchIdx is `0` ``` msgId:

[GitHub] [pulsar] hangc0276 opened a new pull request #13733: change loadbalance shedder to ThresholdShedder and add test

2022-01-12 Thread GitBox
hangc0276 opened a new pull request #13733: URL: https://github.com/apache/pulsar/pull/13733 Fix #13340 ### Modification 1. Change the default loadbalance default shedder strategy from `OverloadShedder` to `ThresholdShedder ` 2. Add test for `ThresholdShedder` ###

[GitHub] [pulsar] dlg99 commented on pull request #13726: Updating dependencies to get rid of CVEs brought in with kafka and log4j-1.2 libs

2022-01-12 Thread GitBox
dlg99 commented on pull request #13726: URL: https://github.com/apache/pulsar/pull/13726#issuecomment-1011757207 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] mattisonchao edited a comment on pull request #13534: Offload policies support cross multiple clusters

2022-01-12 Thread GitBox
mattisonchao edited a comment on pull request #13534: URL: https://github.com/apache/pulsar/pull/13534#issuecomment-1011750437 > @mattisonchao Could you please help resolve the conflicts? Conflict has been fixed. PTAL :) -- This is an automated message from the Apache Git

[GitHub] [pulsar] mattisonchao commented on pull request #13534: Offload policies support cross multiple clusters

2022-01-12 Thread GitBox
mattisonchao commented on pull request #13534: URL: https://github.com/apache/pulsar/pull/13534#issuecomment-1011750437 > @mattisonchao Could you please help resolve the conflicts? Conflict has been fixed. PTAL -- This is an automated message from the Apache Git

[pulsar] branch master updated (c1a31fd -> 8a0cfac)

2022-01-12 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from c1a31fd fix checkstyle for TableViewBuilder (#13727) add 8a0cfac [website][upgrade] feat: code guide page,

[GitHub] [pulsar] liudezhi2098 opened a new pull request #13732: Enable CheckStyle Plugin in pulsar-broker-common module

2022-01-12 Thread GitBox
liudezhi2098 opened a new pull request #13732: URL: https://github.com/apache/pulsar/pull/13732 Motivation enable checkStyle_plugin in pulsar-broker-common module. Documentation - [x] `no-need-doc` -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] Shoothzj commented on a change in pull request #13715: Fix some typos

2022-01-12 Thread GitBox
Shoothzj commented on a change in pull request #13715: URL: https://github.com/apache/pulsar/pull/13715#discussion_r783600790 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/OwnershipCache.java ## @@ -177,7 +177,7 @@ public boolean

[pulsar] branch master updated (c1a31fd -> 8a0cfac)

2022-01-12 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from c1a31fd fix checkstyle for TableViewBuilder (#13727) add 8a0cfac [website][upgrade] feat: code guide page,

[GitHub] [pulsar] gaozhangmin commented on pull request #13724: [Flaky-test] BacklogQuotaManagerTest.testConsumerBacklogEvictionTimeQuotaWithEmptyLedger

2022-01-12 Thread GitBox
gaozhangmin commented on pull request #13724: URL: https://github.com/apache/pulsar/pull/13724#issuecomment-1011693862 > @gaozhangmin Could you please provide more context about how the PR can fix the issue? @codelipenghui wait until the topic was loaded. -- This is an automated

[GitHub] [pulsar] urfreespace opened a new pull request #13731: [website][upgrade]feat: team page and some bug fix about version switch

2022-01-12 Thread GitBox
urfreespace opened a new pull request #13731: URL: https://github.com/apache/pulsar/pull/13731 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)*

[pulsar] branch master updated (c1a31fd -> 8a0cfac)

2022-01-12 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from c1a31fd fix checkstyle for TableViewBuilder (#13727) add 8a0cfac [website][upgrade] feat: code guide page,

[GitHub] [pulsar] yuruguo commented on pull request #13543: [Broker] Other old values are still valid when updating resource group

2022-01-12 Thread GitBox
yuruguo commented on pull request #13543: URL: https://github.com/apache/pulsar/pull/13543#issuecomment-1011652705 @codelipenghui ptal thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] dlg99 commented on pull request #13726: Updating dependencies to get rid of CVEs brought in with kafka and log4j-1.2 libs

2022-01-12 Thread GitBox
dlg99 commented on pull request #13726: URL: https://github.com/apache/pulsar/pull/13726#issuecomment-1011637858 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] nlu90 commented on pull request #13729: fix pulsar-common module check-style

2022-01-12 Thread GitBox
nlu90 commented on pull request #13729: URL: https://github.com/apache/pulsar/pull/13729#issuecomment-1011630821 @Shoothzj @liudezhi2098 PTAL, let me know if there is any further change needed. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] zxJin-x commented on pull request #13502: Delete the unused variable in PrometheusMetricsServlet

2022-01-12 Thread GitBox
zxJin-x commented on pull request #13502: URL: https://github.com/apache/pulsar/pull/13502#issuecomment-1011628940 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pulsar] urfreespace merged pull request #13700: [website][upgrade] feat: code guide page, contributing page and events page

2022-01-12 Thread GitBox
urfreespace merged pull request #13700: URL: https://github.com/apache/pulsar/pull/13700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] david-streamlio opened a new issue #13730: [Doc] Update the C# client page to use newer version of the client library

2022-01-12 Thread GitBox
david-streamlio opened a new issue #13730: URL: https://github.com/apache/pulsar/issues/13730 ### What issue do you find in Pulsar docs? The current version of the docs uses version 0.11 of the C# client library, and the newest version of that library is now 2.0.1.

[GitHub] [pulsar] Shoothzj commented on pull request #13729: fix pulsar-common module check-style

2022-01-12 Thread GitBox
Shoothzj commented on pull request #13729: URL: https://github.com/apache/pulsar/pull/13729#issuecomment-1011566986 > enable CheckStyle Plugin in pom.xml ? +1, need to enable checkstyle in pom.xml to avoid corrupt -- This is an automated message from the Apache Git Service. To

[GitHub] [pulsar] liudezhi2098 commented on pull request #13729: fix pulsar-common module check-style

2022-01-12 Thread GitBox
liudezhi2098 commented on pull request #13729: URL: https://github.com/apache/pulsar/pull/13729#issuecomment-1011554125 enable CheckStyle Plugin in pom.xml ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar-client-go] apapia commented on issue #468: Add Support for NonDurable subscriptions

2022-01-12 Thread GitBox
apapia commented on issue #468: URL: https://github.com/apache/pulsar-client-go/issues/468#issuecomment-1011550925 excellent thanks for the explainer @flowchartsman! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[pulsar] branch master updated (c839fe4 -> c1a31fd)

2022-01-12 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from c839fe4 Initial commit for TableView (#12838) add c1a31fd fix checkstyle for TableViewBuilder (#13727) No

[GitHub] [pulsar] merlimat merged pull request #13727: fix checkstyle for TableViewBuilder

2022-01-12 Thread GitBox
merlimat merged pull request #13727: URL: https://github.com/apache/pulsar/pull/13727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-go] flowchartsman edited a comment on issue #468: Add Support for NonDurable subscriptions

2022-01-12 Thread GitBox
flowchartsman edited a comment on issue #468: URL: https://github.com/apache/pulsar-client-go/issues/468#issuecomment-1011537633 `HasNext()` gives you the ability to bail when you're caught up. If you just loop on `reader.Next(ctx)`, you should get the behavior you desire: the client

[GitHub] [pulsar-client-go] flowchartsman commented on issue #468: Add Support for NonDurable subscriptions

2022-01-12 Thread GitBox
flowchartsman commented on issue #468: URL: https://github.com/apache/pulsar-client-go/issues/468#issuecomment-1011537633 `HasNext()` gives you the ability to bail when you're caught up. If you just loop on `reader.Next(ctx)`, you should get the behavior you desire: the client should

[GitHub] [pulsar] nlu90 opened a new pull request #13729: fix pulsar-common module check-style

2022-01-12 Thread GitBox
nlu90 opened a new pull request #13729: URL: https://github.com/apache/pulsar/pull/13729 ### Motivation Fix pulsar-common checkstyle issues ### Modifications checkstyle fix ### Verifying this change ``` ➜ sn-pulsar git:(neng/fix-pulsar-common-checkstyle)

[GitHub] [pulsar] rdhabalia opened a new issue #13728: PIP-136: Sync Pulsar policies across multiple clouds

2022-01-12 Thread GitBox
rdhabalia opened a new issue #13728: URL: https://github.com/apache/pulsar/issues/13728 # Sync Pulsar policies across multiple clouds ## Motivation Apache Pulsar is a cloud-native, distributed messaging framework which natively provides geo-replication. Many organizations

[GitHub] [pulsar-client-go] apapia edited a comment on issue #468: Add Support for NonDurable subscriptions

2022-01-12 Thread GitBox
apapia edited a comment on issue #468: URL: https://github.com/apache/pulsar-client-go/issues/468#issuecomment-1011514612 @flowchartsman I'm picking this up from @frankjkelly and trying to implement the Reader interface. However, I'm unsure how to implement it for our use case.

[GitHub] [pulsar-client-go] apapia commented on issue #468: Add Support for NonDurable subscriptions

2022-01-12 Thread GitBox
apapia commented on issue #468: URL: https://github.com/apache/pulsar-client-go/issues/468#issuecomment-1011514612 @flowchartsman I'm picking this up from @frankjkelly and trying to implement the Reader interface. However, I'm unsure how to implement it for our use case. Essentially,

[GitHub] [pulsar] bin-albin commented on issue #13721: The topic monitoring information is incorrect

2022-01-12 Thread GitBox
bin-albin commented on issue #13721: URL: https://github.com/apache/pulsar/issues/13721#issuecomment-1011498460 pulsar version is 2.6.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] nlu90 opened a new pull request #13727: fix checkstyle for TableViewBuilder

2022-01-12 Thread GitBox
nlu90 opened a new pull request #13727: URL: https://github.com/apache/pulsar/pull/13727 ### Motivation The TableView PR https://github.com/apache/pulsar/pull/12838 was developed before the checkstyle was enabled. So now it's failing the CI check after it's merged. ``` Error:

[GitHub] [pulsar] github-actions[bot] commented on pull request #13726: Updating dependencies to get rid of CVEs brought in with kafka and log4j-1.2 libs

2022-01-12 Thread GitBox
github-actions[bot] commented on pull request #13726: URL: https://github.com/apache/pulsar/pull/13726#issuecomment-1011421293 @dlg99:Thanks for providing doc info! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [pulsar] github-actions[bot] commented on pull request #13726: Updating dependencies to get rid of CVEs brought in with kafka and log4j-1.2 libs

2022-01-12 Thread GitBox
github-actions[bot] commented on pull request #13726: URL: https://github.com/apache/pulsar/pull/13726#issuecomment-1011376548 @dlg99:Thanks for your contribution. For this PR, do we need to update docs? (The [PR template contains info about

[GitHub] [pulsar] dlg99 opened a new pull request #13726: Updating dependencies to get rid of CVEs brought in with kafka and log4j-1.2 libs

2022-01-12 Thread GitBox
dlg99 opened a new pull request #13726: URL: https://github.com/apache/pulsar/pull/13726 Updating dependencies to get rid of CVEs brought in with kafka and log4j-1.2 libs CVE-2020-27218, CVE-2021-38153, CVE-2021-44228, CVE-2021-44832, CVE-2021-45046, CVE-2021-45105,

[pulsar] branch master updated (58c2818 -> c839fe4)

2022-01-12 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 58c2818 [pulsar-broker] The log prints NamespaceService#isServiceUnitActive exception stack information (#13553)

[GitHub] [pulsar] merlimat merged pull request #12838: Initial commit for TableView

2022-01-12 Thread GitBox
merlimat merged pull request #12838: URL: https://github.com/apache/pulsar/pull/12838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] shibd closed issue #11895: Flaky-test: DiscoveryServiceWebTest.testRiderectUrlWithServerStarted

2022-01-12 Thread GitBox
shibd closed issue #11895: URL: https://github.com/apache/pulsar/issues/11895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated (5835191 -> 58c2818)

2022-01-12 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 5835191 [ Issue 13479 ] Fixed internal topic effect by InactiveTopicPolicy. (#13611) add 58c2818

[GitHub] [pulsar] codelipenghui merged pull request #13553: [pulsar-broker] The log prints NamespaceService#isServiceUnitActive exception stack information.

2022-01-12 Thread GitBox
codelipenghui merged pull request #13553: URL: https://github.com/apache/pulsar/pull/13553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated (160ed8a -> 5835191)

2022-01-12 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 160ed8a maxSubscriptionsPerTopic support cross multiple clusters (#13623) add 5835191 [ Issue 13479 ] Fixed

[GitHub] [pulsar] codelipenghui commented on pull request #13534: Offload policies support cross multiple clusters

2022-01-12 Thread GitBox
codelipenghui commented on pull request #13534: URL: https://github.com/apache/pulsar/pull/13534#issuecomment-1011256291 @mattisonchao Could you please help resolve the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] codelipenghui commented on a change in pull request #13534: Offload policies support cross multiple clusters

2022-01-12 Thread GitBox
codelipenghui commented on a change in pull request #13534: URL: https://github.com/apache/pulsar/pull/13534#discussion_r783266722 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorTopicPoliciesTest.java ## @@ -483,6 +485,38 @@ public void

[pulsar] branch master updated (455470d -> 160ed8a)

2022-01-12 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 455470d ReplicatorDispatchRate support cross multiple clusters (#13624) add 160ed8a

[GitHub] [pulsar] codelipenghui commented on pull request #13578: DeduplicationSnapshotIntervalSeconds support cross multiple clusters

2022-01-12 Thread GitBox
codelipenghui commented on pull request #13578: URL: https://github.com/apache/pulsar/pull/13578#issuecomment-1011252417 @Jason918 Please help resolve the conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[pulsar] branch master updated (e57dc8f -> 455470d)

2022-01-12 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from e57dc8f Fix the wrong multi-topic has message available behavior (#13634) add 455470d

[GitHub] [pulsar] codelipenghui merged pull request #13611: [ Issue 13479 ] Fixed internal topic effect by InactiveTopicPolicy.

2022-01-12 Thread GitBox
codelipenghui merged pull request #13611: URL: https://github.com/apache/pulsar/pull/13611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui closed issue #13479: [bug](broker): brokerDeleteInactiveTopic should exclude pulsar internal topics

2022-01-12 Thread GitBox
codelipenghui closed issue #13479: URL: https://github.com/apache/pulsar/issues/13479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[pulsar] branch master updated (1d9e7b5 -> e57dc8f)

2022-01-12 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from 1d9e7b5 Optimize TopicPolicies#delayedDelivery Enabled and TickTimeMillis with HierarchyTopicPolicies (#13649)

[pulsar] branch master updated (dcf01e9 -> 1d9e7b5)

2022-01-12 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from dcf01e9 Fix getInternalStats occasional lack of LeaderInfo (#13656) add 1d9e7b5 Optimize

[GitHub] [pulsar] codelipenghui merged pull request #13623: maxSubscriptionsPerTopic support cross multiple clusters

2022-01-12 Thread GitBox
codelipenghui merged pull request #13623: URL: https://github.com/apache/pulsar/pull/13623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui merged pull request #13624: ReplicatorDispatchRate support cross multiple clusters

2022-01-12 Thread GitBox
codelipenghui merged pull request #13624: URL: https://github.com/apache/pulsar/pull/13624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui closed issue #13605: Flaky-test: MultiTopicsReaderTest.testHasMessageAvailableAsync

2022-01-12 Thread GitBox
codelipenghui closed issue #13605: URL: https://github.com/apache/pulsar/issues/13605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui merged pull request #13634: [pulsar-client] Fix the wrong multi-topic has message available behavior

2022-01-12 Thread GitBox
codelipenghui merged pull request #13634: URL: https://github.com/apache/pulsar/pull/13634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui merged pull request #13649: Optimize TopicPolicies#delayedDelivery Enabled and TickTimeMillis with HierarchyTopicPolicies

2022-01-12 Thread GitBox
codelipenghui merged pull request #13649: URL: https://github.com/apache/pulsar/pull/13649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] marcioapm commented on issue #6054: Catastrophic frequent random subscription freezes, especially on high-traffic topics.

2022-01-12 Thread GitBox
marcioapm commented on issue #6054: URL: https://github.com/apache/pulsar/issues/6054#issuecomment-1011236519 > This bug has been resolved in DataStax Luna Streaming 2.7.2_1.1.21 Hi @devinbost is this is 2.9.1? -- This is an automated message from the Apache Git Service. To

[pulsar] branch master updated: Fix getInternalStats occasional lack of LeaderInfo (#13656)

2022-01-12 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new dcf01e9 Fix getInternalStats occasional lack

[GitHub] [pulsar] codelipenghui merged pull request #13656: Fix getInternalStats occasional lack of LeaderInfo

2022-01-12 Thread GitBox
codelipenghui merged pull request #13656: URL: https://github.com/apache/pulsar/pull/13656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] hpvd commented on issue #13717: PIP-135: Include MetadataStore backend for Etcd

2022-01-12 Thread GitBox
hpvd commented on issue #13717: URL: https://github.com/apache/pulsar/issues/13717#issuecomment-1011223859 @merlimat many thanks for explanation! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[pulsar] branch master updated (e5d828a -> 416e7e5)

2022-01-12 Thread penghui
This is an automated email from the ASF dual-hosted git repository. penghui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git. from e5d828a [Security] Use dependencyManagement to enforce snakeyaml version to 1.30 (#13722) add 416e7e5 Avoid

[GitHub] [pulsar] codelipenghui merged pull request #13668: Avoid call sync method in async rest API for force delete subscription

2022-01-12 Thread GitBox
codelipenghui merged pull request #13668: URL: https://github.com/apache/pulsar/pull/13668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar] codelipenghui commented on pull request #13680: [Issue 13559] Offload compacted ledger into tiered storage

2022-01-12 Thread GitBox
codelipenghui commented on pull request #13680: URL: https://github.com/apache/pulsar/pull/13680#issuecomment-1011220787 @qq619618919 For a new feature, it's better to follow the PIP process https://github.com/apache/pulsar/wiki/Pulsar-Improvement-Proposal-%28PIP%29 -- This is an

[GitHub] [pulsar] merlimat commented on issue #13717: PIP-135: Include MetadataStore backend for Etcd

2022-01-12 Thread GitBox
merlimat commented on issue #13717: URL: https://github.com/apache/pulsar/issues/13717#issuecomment-1011219933 @hpvd We went through a different route here: * Provide a generic KV pluggable interface for Pulsar metadata access (`MetadataStore` APIs) * Implement Bookkeeper metadata

[GitHub] [pulsar] hpvd edited a comment on issue #13717: PIP-135: Include MetadataStore backend for Etcd

2022-01-12 Thread GitBox
hpvd edited a comment on issue #13717: URL: https://github.com/apache/pulsar/issues/13717#issuecomment-1011215722 not sure: is this somehow related/interesting: https://bookkeeper.apache.org/bps/BP-28-etcd-as-metadata-store/ edit: sorry, unqualified, since you work on bk..

[GitHub] [pulsar] hpvd edited a comment on issue #13717: PIP-135: Include MetadataStore backend for Etcd

2022-01-12 Thread GitBox
hpvd edited a comment on issue #13717: URL: https://github.com/apache/pulsar/issues/13717#issuecomment-1011215722 not sure: is this somehow related/interesting: https://bookkeeper.apache.org/bps/BP-28-etcd-as-metadata-store/ edit: sorry, unqualified... -- This is an

[GitHub] [pulsar] hpvd commented on issue #13717: PIP-135: Include MetadataStore backend for Etcd

2022-01-12 Thread GitBox
hpvd commented on issue #13717: URL: https://github.com/apache/pulsar/issues/13717#issuecomment-1011215722 not sure: is this somehow related/interesting: https://bookkeeper.apache.org/bps/BP-28-etcd-as-metadata-store/ -- This is an automated message from the Apache Git Service.

[GitHub] [pulsar] codelipenghui commented on issue #13640: Subscribing non persistent topic error if cluster disallow auto subscription creation

2022-01-12 Thread GitBox
codelipenghui commented on issue #13640: URL: https://github.com/apache/pulsar/issues/13640#issuecomment-1011153267 @shibd For the non-persistent topic, the broker will not hold any messages. It looks like a message is forwarded between channels, from the producer channel to the consumer

[GitHub] [pulsar] codelipenghui commented on pull request #13699: [Client] Fix send chunking message failed when ordering key is set.

2022-01-12 Thread GitBox
codelipenghui commented on pull request #13699: URL: https://github.com/apache/pulsar/pull/13699#issuecomment-1011148843 @RobertIndie Please also help review this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pulsar] codelipenghui commented on pull request #13689: [Issue 13688][client] Fix send chunking message failed when encryption enabled

2022-01-12 Thread GitBox
codelipenghui commented on pull request #13689: URL: https://github.com/apache/pulsar/pull/13689#issuecomment-1011148339 @RobertIndie Please also help review this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[pulsar] branch master updated: [Security] Use dependencyManagement to enforce snakeyaml version to 1.30 (#13722)

2022-01-12 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new e5d828a [Security] Use dependencyManagement

[GitHub] [pulsar] lhotari merged pull request #13722: [Security] Use dependencyManagement to enforce snakeyaml version to 1.30

2022-01-12 Thread GitBox
lhotari merged pull request #13722: URL: https://github.com/apache/pulsar/pull/13722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pulsar-client-go] wolfstudy commented on pull request #705: reader subscribe all partitioned topics

2022-01-12 Thread GitBox
wolfstudy commented on pull request #705: URL: https://github.com/apache/pulsar-client-go/pull/705#issuecomment-1011129506 cc @cckellogg PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pulsar] codelipenghui commented on a change in pull request #13707: [PIP-130] Apply redelivery backoff policy for ack timeout

2022-01-12 Thread GitBox
codelipenghui commented on a change in pull request #13707: URL: https://github.com/apache/pulsar/pull/13707#discussion_r783152015 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java ## @@ -276,11 +276,10 @@ protected

  1   2   >