[GitHub] [pulsar] HQebupt commented on pull request #17884: [improve][broker]add active status into cursor stats

2022-09-30 Thread GitBox
HQebupt commented on PR #17884: URL: https://github.com/apache/pulsar/pull/17884#issuecomment-1264265283 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[pulsar-site] branch asf-site-next updated: Updated site at revision dbaab0d

2022-09-30 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch asf-site-next in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/asf-site-next by this push: new ee0921f85cd Updated site at r

[GitHub] [pulsar-client-cpp] BewareMyPower closed issue #5: Add CI for build and tests

2022-09-30 Thread GitBox
BewareMyPower closed issue #5: Add CI for build and tests URL: https://github.com/apache/pulsar-client-cpp/issues/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#6651bbb)

2022-09-30 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new dbaab0daa1c Docs sync done from apache/pulsar(#

[GitHub] [pulsar-client-cpp] merlimat opened a new pull request, #15: Build release artifacts

2022-09-30 Thread GitBox
merlimat opened a new pull request, #15: URL: https://github.com/apache/pulsar-client-cpp/pull/15 ### Motivation When we push a tag, trigger a job that builds RPM/Deb packages for both x86_64 and arm64 and uploads them as artifacts. The release manager can then fetch the binari

[GitHub] [pulsar-client-cpp] merlimat commented on issue #5: Add CI for build and tests

2022-09-30 Thread GitBox
merlimat commented on issue #5: URL: https://github.com/apache/pulsar-client-cpp/issues/5#issuecomment-1264251228 Sorry, I didn't see this one. I added one PR to start addressing this: https://github.com/apache/pulsar-client-cpp/pull/14 -- This is an automated message from the Apache Gi

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #17820: [Bugfix] [LinuxInfoUtils] incorrect CPU usage collected by pulsar #17815

2022-09-30 Thread GitBox
heesung-sn commented on code in PR #17820: URL: https://github.com/apache/pulsar/pull/17820#discussion_r985050626 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/LinuxInfoUtils.java: ## @@ -72,6 +73,31 @@ public static boolean isCGroupEnabled() { }

[GitHub] [pulsar] lordcheng10 commented on pull request #17151: [fix][broker] Added check for invisible characters for subscription name

2022-09-30 Thread GitBox
lordcheng10 commented on PR #17151: URL: https://github.com/apache/pulsar/pull/17151#issuecomment-1264218248 CI all passed: https://github.com/lordcheng10/pulsar/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [pulsar] lordcheng10 commented on pull request #17151: [fix][broker] Added check for invisible characters for subscription name

2022-09-30 Thread GitBox
lordcheng10 commented on PR #17151: URL: https://github.com/apache/pulsar/pull/17151#issuecomment-1264217771 > > Instead of checking for invalid characters, it would be better to have the check the validity of the given subscription name explicitly. > > I'll start a discussion about n

[GitHub] [pulsar-client-python] tisonkun commented on pull request #3: Use git submodule to download pulsar-client-cpp dependency

2022-09-30 Thread GitBox
tisonkun commented on PR #3: URL: https://github.com/apache/pulsar-client-python/pull/3#issuecomment-1264207597 > thinking again Agree. Submodule increase understanding burdens. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pulsar] lordcheng10 commented on pull request #17151: [fix][broker] Added check for invisible characters for subscription name

2022-09-30 Thread GitBox
lordcheng10 commented on PR #17151: URL: https://github.com/apache/pulsar/pull/17151#issuecomment-1264207167 > Instead of checking for invalid characters, it would be better to have the check the validity of the given subscription name explicitly. I'll start a discussion: Naming rules

[GitHub] [pulsar] lordcheng10 commented on pull request #17151: [fix][broker] Added check for invisible characters for subscription name

2022-09-30 Thread GitBox
lordcheng10 commented on PR #17151: URL: https://github.com/apache/pulsar/pull/17151#issuecomment-1264206243 > Is the root of the problem here that the character sequences in question are not being properly encoded when forming the admin URLs? From the example given, I am seeing what looks

[GitHub] [pulsar] lordcheng10 commented on pull request #17751: [fix][broker] Fix the markdelete position does not move forward when isAutoSkipNonRecoverableData=true and individual ack

2022-09-30 Thread GitBox
lordcheng10 commented on PR #17751: URL: https://github.com/apache/pulsar/pull/17751#issuecomment-1264205209 @codelipenghui @Technoboy- PTAL,thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [pulsar] lordcheng10 commented on pull request #17751: [fix][broker] Fix the markdelete position does not move forward when isAutoSkipNonRecoverableData=true and individual ack

2022-09-30 Thread GitBox
lordcheng10 commented on PR #17751: URL: https://github.com/apache/pulsar/pull/17751#issuecomment-1264205148 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [pulsar] lordcheng10 commented on a diff in pull request #17797: [fix][broker] Update new bundle-range to policies after bundle split

2022-09-30 Thread GitBox
lordcheng10 commented on code in PR #17797: URL: https://github.com/apache/pulsar/pull/17797#discussion_r985026269 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -880,12 +880,22 @@ void splitAndOwnBundleOnceAndRetry(NamespaceBundle

[GitHub] [pulsar] lordcheng10 commented on a diff in pull request #17797: [fix][broker] Update new bundle-range to policies after bundle split

2022-09-30 Thread GitBox
lordcheng10 commented on code in PR #17797: URL: https://github.com/apache/pulsar/pull/17797#discussion_r985026005 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -880,12 +880,22 @@ void splitAndOwnBundleOnceAndRetry(NamespaceBundle

[GitHub] [pulsar] github-actions[bot] commented on pull request #16159: [improve][docs] Use metadataServiceUri in favor of zkServers

2022-09-30 Thread GitBox
github-actions[bot] commented on PR #16159: URL: https://github.com/apache/pulsar/pull/16159#issuecomment-1264202583 The pr had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [pulsar] github-actions[bot] commented on issue #17361: [feature] Automatic trigger offloading by time

2022-09-30 Thread GitBox
github-actions[bot] commented on issue #17361: URL: https://github.com/apache/pulsar/issues/17361#issuecomment-1264201714 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pulsar] github-actions[bot] commented on issue #17362: [feature] Support offload throttling

2022-09-30 Thread GitBox
github-actions[bot] commented on issue #17362: URL: https://github.com/apache/pulsar/issues/17362#issuecomment-1264201701 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pulsar] lordcheng10 commented on a diff in pull request #17797: [fix][broker] Update new bundle-range to policies after bundle split

2022-09-30 Thread GitBox
lordcheng10 commented on code in PR #17797: URL: https://github.com/apache/pulsar/pull/17797#discussion_r984174096 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -880,12 +881,22 @@ void splitAndOwnBundleOnceAndRetry(NamespaceBundle

[GitHub] [pulsar] HQebupt commented on pull request #17884: [improve][broker]add active status into cursor stats

2022-09-30 Thread GitBox
HQebupt commented on PR #17884: URL: https://github.com/apache/pulsar/pull/17884#issuecomment-1264193788 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] HQebupt commented on pull request #17884: [improve][broker]add active status into cursor stats

2022-09-30 Thread GitBox
HQebupt commented on PR #17884: URL: https://github.com/apache/pulsar/pull/17884#issuecomment-1264193381 /pulsarbot ready-to-test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [pulsar] Demogorgon314 commented on pull request #17853: [fxi][doc] Rewrite the steps of docker-deploy

2022-09-30 Thread GitBox
Demogorgon314 commented on PR #17853: URL: https://github.com/apache/pulsar/pull/17853#issuecomment-1264174816 Actually, "latest" is just a label, just like other versions. When you pull the ”latest“ image to local, the image will never update. You need to delete the ”latest“ image a

[GitHub] [pulsar] lordcheng10 commented on pull request #17751: [fix][broker] Fix the markdelete position does not move forward when isAutoSkipNonRecoverableData=true and individual ack

2022-09-30 Thread GitBox
lordcheng10 commented on PR #17751: URL: https://github.com/apache/pulsar/pull/17751#issuecomment-1264152425 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#6651bbb)

2022-09-30 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 0f325220ee9 Docs sync done from apache/pulsar(#

[GitHub] [pulsar] codelipenghui opened a new issue, #17908: Flaky-test: ManagedLedgerBkTest.verifyConcurrentUsage

2022-09-30 Thread GitBox
codelipenghui opened a new issue, #17908: URL: https://github.com/apache/pulsar/issues/17908 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Example failure https://github.com/codelipe

[GitHub] [pulsar-client-cpp] merlimat opened a new pull request, #14: Run unit tests in CI

2022-09-30 Thread GitBox
merlimat opened a new pull request, #14: URL: https://github.com/apache/pulsar-client-cpp/pull/14 ### Motivation Compile and run unit tests against a standalone Pulsar service running inside a docker container. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pulsar] merlimat opened a new pull request, #17907: Allow to configure and disable the size of lookahead for detecting fixed delays in messages

2022-09-30 Thread GitBox
merlimat opened a new pull request, #17907: URL: https://github.com/apache/pulsar/pull/17907 ### Motivation Allow to configure and disable the size of lookahead for detecting fixed delays in messages ### Documentation - [ ] `doc-required` (Your PR needs to up

[pulsar-dotpulsar] branch master updated: modified the "hello world" to fix first run issue (#110)

2022-09-30 Thread blankensteiner
This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git The following commit(s) were added to refs/heads/master by this push: new 3ca870e modified the "hello w

[pulsar-client-cpp] branch main updated: Add TLS transport config (#12)

2022-09-30 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-client-cpp.git The following commit(s) were added to refs/heads/main by this push: new 9eb9011 Add TLS transport config (#12) 9

[GitHub] [pulsar-client-cpp] merlimat merged pull request #12: Add TLS transport config

2022-09-30 Thread GitBox
merlimat merged PR #12: URL: https://github.com/apache/pulsar-client-cpp/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pul

[GitHub] [pulsar-client-go] pgier opened a new pull request, #856: read module version info from golang runtime

2022-09-30 Thread GitBox
pgier opened a new pull request, #856: URL: https://github.com/apache/pulsar-client-go/pull/856 ### Motivation Instead of maintaining a hard coded version string in the sources, we can get the version of the pulsar-client-go module used to build the client application. ### Mod

[GitHub] [pulsar] nicoloboschi merged pull request #17877: [fix][functions] Fix the download of builtin Functions

2022-09-30 Thread GitBox
nicoloboschi merged PR #17877: URL: https://github.com/apache/pulsar/pull/17877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@puls

[pulsar] branch master updated: [fix][functions] Fix the download of builtin Functions (#17877)

2022-09-30 Thread nicoloboschi
This is an automated email from the ASF dual-hosted git repository. nicoloboschi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 6651bbbab5b [fix][functions] Fix the downl

[GitHub] [pulsar-client-cpp] merlimat opened a new pull request, #13: Fixed protobuf compatibility

2022-09-30 Thread GitBox
merlimat opened a new pull request, #13: URL: https://github.com/apache/pulsar-client-cpp/pull/13 ### Motivation Protobuf has broken the compatibility for C++ generated code in 3.20 release. This break compilation in our tests for native protobuf schema. We should use a macro

[GitHub] [pulsar-client-python] merlimat merged pull request #1: PIP-209: Compile Python client wrapper

2022-09-30 Thread GitBox
merlimat merged PR #1: URL: https://github.com/apache/pulsar-client-python/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pu

[pulsar-client-python] branch main updated: PIP-209: Compile Python client wrapper (#1)

2022-09-30 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-client-python.git The following commit(s) were added to refs/heads/main by this push: new 9f6fc69 PIP-209: Compile Python clien

[pulsar-client-cpp] branch main updated: Fixed RPM / Deb / APK packages and enabled CI build (#11)

2022-09-30 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-client-cpp.git The following commit(s) were added to refs/heads/main by this push: new 40c7406 Fixed RPM / Deb / APK packages a

[GitHub] [pulsar-client-cpp] merlimat merged pull request #11: Fixed RPM / Deb / APK packages and enabled CI build

2022-09-30 Thread GitBox
merlimat merged PR #11: URL: https://github.com/apache/pulsar-client-cpp/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pul

[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #11: Fixed RPM / Deb / APK packages and enabled CI build

2022-09-30 Thread GitBox
BewareMyPower commented on code in PR #11: URL: https://github.com/apache/pulsar-client-cpp/pull/11#discussion_r984846914 ## pkg/deb/docker-build-deb.sh: ## @@ -20,15 +20,10 @@ set -ex -ROOT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )"/../../.. &> /dev/null && pwd )" -IMA

[GitHub] [pulsar-client-python] BewareMyPower closed pull request #3: Use git submodule to download pulsar-client-cpp dependency

2022-09-30 Thread GitBox
BewareMyPower closed pull request #3: Use git submodule to download pulsar-client-cpp dependency URL: https://github.com/apache/pulsar-client-python/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar-client-python] BewareMyPower commented on pull request #3: Use git submodule to download pulsar-client-cpp dependency

2022-09-30 Thread GitBox
BewareMyPower commented on PR #3: URL: https://github.com/apache/pulsar-client-python/pull/3#issuecomment-1263868678 > Having the submodule won't help here. I have thought that we can depend on an unstable version of pulsar-client-cpp in main branch, then for those want some specific

[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#c0b3039)

2022-09-30 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 04494d7171c Docs sync done from apache/pulsar(#

[GitHub] [pulsar] jcalcote commented on issue #9084: Improve handling of S3 offloading configuration in other regions

2022-09-30 Thread GitBox
jcalcote commented on issue #9084: URL: https://github.com/apache/pulsar/issues/9084#issuecomment-1263842500 Here's a possible work around for some people's use cases: https://stackoverflow.com/questions/73169813/jclouds-getbucketlocation-timeout-on-getblob/73902608#73902608 Note also

[GitHub] [pulsar-client-cpp] merlimat commented on a diff in pull request #11: Fixed RPM / Deb / APK packages and enabled CI build

2022-09-30 Thread GitBox
merlimat commented on code in PR #11: URL: https://github.com/apache/pulsar-client-cpp/pull/11#discussion_r984806154 ## pkg/deb/build-deb.sh: ## @@ -77,13 +77,8 @@ ls $CPP_DIR/lib/libpulsar* cp -ar $CPP_DIR/include/pulsar $DEVEL_DEST_DIR/usr/include/ cp $CPP_DIR/lib/libpulsar.

[GitHub] [pulsar-client-python] merlimat commented on a diff in pull request #1: PIP-209: Compile Python client wrapper

2022-09-30 Thread GitBox
merlimat commented on code in PR #1: URL: https://github.com/apache/pulsar-client-python/pull/1#discussion_r984793659 ## build-mac-wheels.sh: ## @@ -246,6 +247,43 @@ else echo "Using cached LibCurl" fi +

[pulsar] branch master updated: [fix][CI] Don't run pulsar-ci-flaky workflow for PRs which contain only document changes (#17906)

2022-09-30 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new c0b3039e3b2 [fix][CI] Don't run pulsar-ci-flaky

[GitHub] [pulsar] lhotari merged pull request #17906: [fix][CI] Don't run pulsar-ci-flaky workflow for PRs which contain only document changes

2022-09-30 Thread GitBox
lhotari merged PR #17906: URL: https://github.com/apache/pulsar/pull/17906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

[GitHub] [pulsar] aymkhalil commented on a diff in pull request #17902: [improve][fn] Run search connectors in parallel

2022-09-30 Thread GitBox
aymkhalil commented on code in PR #17902: URL: https://github.com/apache/pulsar/pull/17902#discussion_r984779306 ## pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/io/ConnectorUtils.java: ## @@ -142,49 +149,83 @@ public static TreeMap searchForConnectors(

[GitHub] [pulsar] aymkhalil commented on a diff in pull request #17902: [improve][fn] Run search connectors in parallel

2022-09-30 Thread GitBox
aymkhalil commented on code in PR #17902: URL: https://github.com/apache/pulsar/pull/17902#discussion_r984775978 ## pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/io/ConnectorUtils.java: ## @@ -142,49 +149,83 @@ public static TreeMap searchForConnectors(

[GitHub] [pulsar] liangyepianzhou closed pull request #17888: [fix][conf] Fix port conflict in bookkeeper.conf

2022-09-30 Thread GitBox
liangyepianzhou closed pull request #17888: [fix][conf] Fix port conflict in bookkeeper.conf URL: https://github.com/apache/pulsar/pull/17888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[pulsar] branch master updated: [fix][managed-ledger]fix typo error in ManagedCursorContainer #17509

2022-09-30 Thread houxiaoyu
This is an automated email from the ASF dual-hosted git repository. houxiaoyu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2891d5c58af [fix][managed-ledger]fix typo err

[GitHub] [pulsar] AnonHxy merged pull request #17509: [cleanup][managed-ledger]fix typo error in ManagedCursorContainer

2022-09-30 Thread GitBox
AnonHxy merged PR #17509: URL: https://github.com/apache/pulsar/pull/17509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

[GitHub] [pulsar] aymkhalil commented on a diff in pull request #17902: [improve][fn] Run search connectors in parallel

2022-09-30 Thread GitBox
aymkhalil commented on code in PR #17902: URL: https://github.com/apache/pulsar/pull/17902#discussion_r984766174 ## pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/io/ConnectorUtils.java: ## @@ -142,49 +149,83 @@ public static TreeMap searchForConnectors(

[GitHub] [pulsar] aymkhalil commented on a diff in pull request #17902: [improve][fn] Run search connectors in parallel

2022-09-30 Thread GitBox
aymkhalil commented on code in PR #17902: URL: https://github.com/apache/pulsar/pull/17902#discussion_r984765755 ## pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/io/ConnectorUtils.java: ## @@ -142,49 +149,83 @@ public static TreeMap searchForConnectors(

[GitHub] [pulsar] liangyepianzhou commented on pull request #17853: [fxi][doc] Rewrite the steps of docker-deploy

2022-09-30 Thread GitBox
liangyepianzhou commented on PR #17853: URL: https://github.com/apache/pulsar/pull/17853#issuecomment-1263779719 > @liangyepianzhou Thanks for reporting the issue. Maybe you should pull the latest version of Pulsar image. See #12353 already removed the check. The image of the docker is co

[GitHub] [pulsar] Demogorgon314 commented on pull request #17853: [fxi][doc] Rewrite the steps of docker-deploy

2022-09-30 Thread GitBox
Demogorgon314 commented on PR #17853: URL: https://github.com/apache/pulsar/pull/17853#issuecomment-1263775139 @liangyepianzhou Thanks for reporting the issue. Maybe you should pull the latest version of Pulsar image. See https://github.com/apache/pulsar/pull/12353 already removed the check

[GitHub] [pulsar] nodece commented on pull request #17864: [fix][broker] Fix create ns

2022-09-30 Thread GitBox
nodece commented on PR #17864: URL: https://github.com/apache/pulsar/pull/17864#issuecomment-1263767295 > Lgtm > > What about adding a test case? I think we should add an integration test, what do you think about that? -- This is an automated message from the Apache Git S

[GitHub] [pulsar] liangyepianzhou commented on pull request #17853: [fxi][doc] Rewrite the steps of docker-deploy

2022-09-30 Thread GitBox
liangyepianzhou commented on PR #17853: URL: https://github.com/apache/pulsar/pull/17853#issuecomment-1263747133 There are some exceptions when using the [docker-compose.yaml ](https://gist.github.com/Demogorgon314/c0d397a21c5a05b40235bb43272a4a88)to start up the cluster. The exception happ

[GitHub] [pulsar-client-python] merlimat commented on a diff in pull request #1: PIP-209: Compile Python client wrapper

2022-09-30 Thread GitBox
merlimat commented on code in PR #1: URL: https://github.com/apache/pulsar-client-python/pull/1#discussion_r984710861 ## CMakeLists.txt: ## @@ -17,7 +17,93 @@ # under the License. # -INCLUDE_DIRECTORIES("${Boost_INCLUDE_DIRS}" "${PYTHON_INCLUDE_DIRS}") +project (pulsar-clien

[GitHub] [pulsar-client-python] merlimat commented on a diff in pull request #1: PIP-209: Compile Python client wrapper

2022-09-30 Thread GitBox
merlimat commented on code in PR #1: URL: https://github.com/apache/pulsar-client-python/pull/1#discussion_r984709443 ## CMakeLists.txt: ## @@ -86,18 +179,18 @@ if (APPLE) endif () endif() -message(STATUS "Using Boost Python libs: ${PYTHON_WRAPPER_LIBS}") - if (NOT PYTH

[GitHub] [pulsar-client-python] merlimat commented on a diff in pull request #1: PIP-209: Compile Python client wrapper

2022-09-30 Thread GitBox
merlimat commented on code in PR #1: URL: https://github.com/apache/pulsar-client-python/pull/1#discussion_r984708426 ## build-mac-wheels.sh: ## @@ -246,6 +247,43 @@ else echo "Using cached LibCurl" fi +

[GitHub] [pulsar-client-python] merlimat commented on pull request #3: Use git submodule to download pulsar-client-cpp dependency

2022-09-30 Thread GitBox
merlimat commented on PR #3: URL: https://github.com/apache/pulsar-client-python/pull/3#issuecomment-1263708417 > When we release a Python client, we can specify the tag like Exactly, but then it would be the same as depending on a released version of C++ client. Having the submodule

[GitHub] [pulsar-client-cpp] merlimat commented on a diff in pull request #11: Fixed RPM / Deb / APK packages and enabled CI build

2022-09-30 Thread GitBox
merlimat commented on code in PR #11: URL: https://github.com/apache/pulsar-client-cpp/pull/11#discussion_r984694878 ## pkg/deb/docker-build-deb.sh: ## @@ -20,15 +20,10 @@ set -ex -ROOT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )"/../../.. &> /dev/null && pwd )" -IMAGE_NA

[GitHub] [pulsar] liangyepianzhou commented on pull request #17853: [fxi][doc] Rewrite the steps of docker-deploy

2022-09-30 Thread GitBox
liangyepianzhou commented on PR #17853: URL: https://github.com/apache/pulsar/pull/17853#issuecomment-1263696635 @Demogorgon314 Thanks for your support of my work. After verifying the changes for the health check and other optimizations, I will accept them in the google doc. And then if you

[GitHub] [pulsar] liangyepianzhou commented on pull request #17853: [fxi][doc] Rewrite the steps of docker-deploy

2022-09-30 Thread GitBox
liangyepianzhou commented on PR #17853: URL: https://github.com/apache/pulsar/pull/17853#issuecomment-1263675560 > After trying the `docker-compose.yaml` . I find out the health check implement is wrong. > > For more details, please refer to https://gist.github.com/Demogorgon314/c0d3

[GitHub] [pulsar] HQebupt commented on pull request #17509: [cleanup][managed-ledger]fix typo error in ManagedCursorContainer

2022-09-30 Thread GitBox
HQebupt commented on PR #17509: URL: https://github.com/apache/pulsar/pull/17509#issuecomment-1263621473 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar] teabot commented on pull request #17151: [fix][broker] Added check for invisible characters for subscription name

2022-09-30 Thread GitBox
teabot commented on PR #17151: URL: https://github.com/apache/pulsar/pull/17151#issuecomment-1263605886 Is the root of the problem here that the character sequences in question are not being properly encoded when forming the admin URLs? From the example given, I am seeing what looks to be a

[GitHub] [pulsar] lordcheng10 commented on pull request #17751: [fix][broker] Fix the markdelete position does not move forward when isAutoSkipNonRecoverableData=true and individual ack

2022-09-30 Thread GitBox
lordcheng10 commented on PR #17751: URL: https://github.com/apache/pulsar/pull/17751#issuecomment-1263598303 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [pulsar] Demogorgon314 commented on pull request #17853: [fxi][doc] Rewrite the steps of docker-deploy

2022-09-30 Thread GitBox
Demogorgon314 commented on PR #17853: URL: https://github.com/apache/pulsar/pull/17853#issuecomment-1263583612 After trying the `docker-compose.yaml` . I find out the health check implement is wrong. For more details, please refer to https://gist.github.com/Demogorgon314/c0d397a21c

[pulsar-site] branch main updated: Docs sync done from apache/pulsar(#74d6305)

2022-09-30 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new e9d24402f8f Docs sync done from apache/pulsar(#

[GitHub] [pulsar] eolivelli merged pull request #17855: [fix] Remove pulsar-broker-common dependency from pulsar-client

2022-09-30 Thread GitBox
eolivelli merged PR #17855: URL: https://github.com/apache/pulsar/pull/17855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.

[pulsar] branch master updated: [fix] Remove pulsar-broker-common dependency from pulsar-client (#17855)

2022-09-30 Thread eolivelli
This is an automated email from the ASF dual-hosted git repository. eolivelli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 74d6305b748 [fix] Remove pulsar-broker-common

[GitHub] [pulsar] HQebupt opened a new pull request, #17509: [cleanup][managed-ledger]fix typo error in ManagedCursorContainer

2022-09-30 Thread GitBox
HQebupt opened a new pull request, #17509: URL: https://github.com/apache/pulsar/pull/17509 ### Motivation fix typo error in ManagedCursorContainer ### Verifying this change - [x] Make sure that the change passes the CI checks. This change is a trivial rework / code c

[GitHub] [pulsar] AnonHxy closed pull request #17509: [cleanup][managed-ledger]fix typo error in ManagedCursorContainer

2022-09-30 Thread GitBox
AnonHxy closed pull request #17509: [cleanup][managed-ledger]fix typo error in ManagedCursorContainer URL: https://github.com/apache/pulsar/pull/17509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[pulsar] branch master updated: [improve][doc] Improve TLS encryption (#17808)

2022-09-30 Thread junma
This is an automated email from the ASF dual-hosted git repository. junma pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 7b2626000b3 [improve][doc] Improve TLS encryption

[GitHub] [pulsar] momo-jun merged pull request #17808: [improve][doc] Improve TLS encryption

2022-09-30 Thread GitBox
momo-jun merged PR #17808: URL: https://github.com/apache/pulsar/pull/17808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.a

[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #17853: [fxi][doc] Rewrite the steps of docker-deploy

2022-09-30 Thread GitBox
liangyepianzhou commented on code in PR #17853: URL: https://github.com/apache/pulsar/pull/17853#discussion_r984466128 ## site2/docs/deploy-docker.md: ## @@ -3,50 +3,97 @@ id: deploy-docker title: Deploy a cluster on Docker sidebar_label: "Docker" --- - -To deploy a Pulsar cl

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #17853: [fxi][doc] Rewrite the steps of docker-deploy

2022-09-30 Thread GitBox
Demogorgon314 commented on code in PR #17853: URL: https://github.com/apache/pulsar/pull/17853#discussion_r98172 ## site2/docs/deploy-docker.md: ## @@ -3,50 +3,97 @@ id: deploy-docker title: Deploy a cluster on Docker sidebar_label: "Docker" --- - -To deploy a Pulsar clus

[GitHub] [pulsar-client-cpp] nodece opened a new pull request, #12: Add TLS transport config

2022-09-30 Thread GitBox
nodece opened a new pull request, #12: URL: https://github.com/apache/pulsar-client-cpp/pull/12 ### Motivation Add a TLS transport config for the client. In the old version, we can only use the TLS authentication to config the TLS transport, so we cannot use the other authentic

[GitHub] [pulsar-site] Anonymitaet merged pull request #236: Merge pulsar-site issues to the main repo

2022-09-30 Thread GitBox
Anonymitaet merged PR #236: URL: https://github.com/apache/pulsar-site/pull/236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@puls

[pulsar-site] branch main updated: Merge pulsar-site issues to the main repo (#236)

2022-09-30 Thread liuyu
This is an automated email from the ASF dual-hosted git repository. liuyu pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 9c69079f24d Merge pulsar-site issues to the main

[GitHub] [pulsar] congbobo184 closed issue #16864: Flaky-test: NegativeAcksTest.testNegativeAcksWithBatchAckEnabled

2022-09-30 Thread GitBox
congbobo184 closed issue #16864: Flaky-test: NegativeAcksTest.testNegativeAcksWithBatchAckEnabled URL: https://github.com/apache/pulsar/issues/16864 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] congbobo184 merged pull request #17893: [fix][flaky-test]NegativeAcksTest.testNegativeAcksWithBatchAckEnabled

2022-09-30 Thread GitBox
congbobo184 merged PR #17893: URL: https://github.com/apache/pulsar/pull/17893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsa

[pulsar] branch master updated: [fix][flaky-test]NegativeAcksTest.testNegativeAcksWithBatchAckEnabled (#17893)

2022-09-30 Thread bogong
This is an automated email from the ASF dual-hosted git repository. bogong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 85b1138593a [fix][flaky-test]NegativeAcksTest.t

[GitHub] [pulsar] nicoloboschi commented on pull request #17855: [fix] Remove pulsar-broker-common dependency from pulsar-client

2022-09-30 Thread GitBox
nicoloboschi commented on PR #17855: URL: https://github.com/apache/pulsar/pull/17855#issuecomment-1263330648 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [pulsar] nodece commented on a diff in pull request #17864: [fix][broker] Fix create ns

2022-09-30 Thread GitBox
nodece commented on code in PR #17864: URL: https://github.com/apache/pulsar/pull/17864#discussion_r984389298 ## pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandalone.java: ## @@ -394,9 +392,7 @@ void createNameSpace(String cluster, String publicTenant, NamespaceName n

[GitHub] [pulsar] Jason918 commented on a diff in pull request #17864: [fix][broker] Fix create ns

2022-09-30 Thread GitBox
Jason918 commented on code in PR #17864: URL: https://github.com/apache/pulsar/pull/17864#discussion_r984384060 ## pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandalone.java: ## @@ -394,9 +392,7 @@ void createNameSpace(String cluster, String publicTenant, NamespaceName

[GitHub] [pulsar] eolivelli commented on a diff in pull request #17782: [fix][broker]Can't consume messages for a long time due to Entry Filter

2022-09-30 Thread GitBox
eolivelli commented on code in PR #17782: URL: https://github.com/apache/pulsar/pull/17782#discussion_r984309409 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java: ## @@ -700,6 +707,30 @@ protected synchronized

[GitHub] [pulsar] tisonkun commented on pull request #17854: [improve][java-client]Shrink BatchMessageContainer maxBatchSize

2022-09-30 Thread GitBox
tisonkun commented on PR #17854: URL: https://github.com/apache/pulsar/pull/17854#issuecomment-1263299796 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [pulsar-client-go] nodece opened a new pull request, #855: Add TLS transport config

2022-09-30 Thread GitBox
nodece opened a new pull request, #855: URL: https://github.com/apache/pulsar-client-go/pull/855 ### Motivation Add a TLS transport config for the client. In the old version, we can only use the TLS authentication to config the TLS transport, so we cannot use the other authenti

[GitHub] [pulsar] Jason918 commented on a diff in pull request #17797: [fix][broker] Update new bundle-range to policies after bundle split

2022-09-30 Thread GitBox
Jason918 commented on code in PR #17797: URL: https://github.com/apache/pulsar/pull/17797#discussion_r984344809 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -880,12 +880,22 @@ void splitAndOwnBundleOnceAndRetry(NamespaceBundle bu

[GitHub] [pulsar-client-python] BewareMyPower commented on a diff in pull request #1: PIP-209: Compile Python client wrapper

2022-09-30 Thread GitBox
BewareMyPower commented on code in PR #1: URL: https://github.com/apache/pulsar-client-python/pull/1#discussion_r984341586 ## build-mac-wheels.sh: ## @@ -246,6 +247,43 @@ else echo "Using cached LibCurl" fi +###

[GitHub] [pulsar] lhotari opened a new pull request, #17906: [fix][CI] Don't run pulsar-ci-flaky workflow for PRs which contain only document changes

2022-09-30 Thread GitBox
lhotari opened a new pull request, #17906: URL: https://github.com/apache/pulsar/pull/17906 ### Motivation There's a typo in pulsar-ci-flaky workflow definition which results in the workflow to get run for document only changes. This was a typo in #17881 at https://github.com/apac

[GitHub] [pulsar-site] tisonkun commented on issue #241: site build error

2022-09-30 Thread GitBox
tisonkun commented on issue #241: URL: https://github.com/apache/pulsar-site/issues/241#issuecomment-1263263870 Seems it's a first failed attempt and `yarn build --locale en` succeeds locally. I suppose it can be something network unstable according to "Call retries were exceeded". We can o

[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #11: Fixed RPM / Deb / APK packages and enabled CI build

2022-09-30 Thread GitBox
BewareMyPower commented on code in PR #11: URL: https://github.com/apache/pulsar-client-cpp/pull/11#discussion_r984331663 ## pkg/deb/docker-build-deb.sh: ## @@ -20,15 +20,10 @@ set -ex -ROOT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )"/../../.. &> /dev/null && pwd )" -IMA

[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #11: Fixed RPM / Deb / APK packages and enabled CI build

2022-09-30 Thread GitBox
BewareMyPower commented on code in PR #11: URL: https://github.com/apache/pulsar-client-cpp/pull/11#discussion_r984331663 ## pkg/deb/docker-build-deb.sh: ## @@ -20,15 +20,10 @@ set -ex -ROOT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )"/../../.. &> /dev/null && pwd )" -IMA

[GitHub] [pulsar-site] tisonkun commented on issue #241: site build error

2022-09-30 Thread GitBox
tisonkun commented on issue #241: URL: https://github.com/apache/pulsar-site/issues/241#issuecomment-1263257853 @urfreespace I'm looking into this. You may transfer this issue to `apache/pulsar` repo and merge #236. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [pulsar-client-cpp] BewareMyPower commented on a diff in pull request #11: Fixed RPM / Deb / APK packages and enabled CI build

2022-09-30 Thread GitBox
BewareMyPower commented on code in PR #11: URL: https://github.com/apache/pulsar-client-cpp/pull/11#discussion_r984329518 ## pkg/deb/build-deb.sh: ## @@ -77,13 +77,8 @@ ls $CPP_DIR/lib/libpulsar* cp -ar $CPP_DIR/include/pulsar $DEVEL_DEST_DIR/usr/include/ cp $CPP_DIR/lib/libpu

[GitHub] [pulsar] AnonHxy commented on pull request #17884: [improve][broker]add active status into cursor stats

2022-09-30 Thread GitBox
AnonHxy commented on PR #17884: URL: https://github.com/apache/pulsar/pull/17884#issuecomment-1263202275 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

  1   2   >