[GitHub] [pulsar] Demogorgon314 commented on issue #20007: Flaky-test: ExtensibleLoadManagerImplTest

2023-04-03 Thread via GitHub
Demogorgon314 commented on issue #20007: URL: https://github.com/apache/pulsar/issues/20007#issuecomment-1495439297 Fixed by https://github.com/apache/pulsar/pull/19945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #20006: [fix][test]Fix flaky test produceCommitTest

2023-04-03 Thread via GitHub
poorbarcode commented on code in PR #20006: URL: https://github.com/apache/pulsar/pull/20006#discussion_r1156798535 ## pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java: ## @@ -811,7 +811,7 @@ private void txnCumulativeAckTest(boolean batchEn

[GitHub] [pulsar] heesung-sn commented on issue #20007: Flaky-test: ExtensibleLoadManagerImplTest

2023-04-03 Thread via GitHub
heesung-sn commented on issue #20007: URL: https://github.com/apache/pulsar/issues/20007#issuecomment-1495429396 Expecting this change will fix this flaky test. https://github.com/apache/pulsar/pull/19945/commits/f129646059385557750d89bd4b0c37c74134750f -- This is an automated mess

[GitHub] [pulsar] michaeljmarshall commented on pull request #19989: [fix][broker] Only validate superuser access if authz enabled

2023-04-03 Thread via GitHub
michaeljmarshall commented on PR #19989: URL: https://github.com/apache/pulsar/pull/19989#issuecomment-1495423656 Looks like there are some legitimate test failures. I fixed the first. The second is `activeBrokerParse` added by https://github.com/apache/pulsar/pull/9191. It looks like that

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #19972: [fix][broker] Ignore and remove the replicator cursor when the remote cluster is absent

2023-04-03 Thread via GitHub
poorbarcode commented on code in PR #19972: URL: https://github.com/apache/pulsar/pull/19972#discussion_r1156789638 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1696,14 +1696,32 @@ public void openCursorFailed(ManagedLed

[GitHub] [pulsar] lhotari commented on pull request #19102: [improve][broker] PIP-192: Implement extensible load manager

2023-04-03 Thread via GitHub
lhotari commented on PR #19102: URL: https://github.com/apache/pulsar/pull/19102#issuecomment-1495413728 This PR introduced a new flaky test #20007 . @Demogorgon314 Do you have a chance to fix that? -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [pulsar] lhotari opened a new issue, #20007: Flaky-test: ExtensibleLoadManagerImplTest

2023-04-03 Thread via GitHub
lhotari opened a new issue, #20007: URL: https://github.com/apache/pulsar/issues/20007 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Example failure https://github.com/apache/pulsar/

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #19972: [fix][broker] Ignore and remove the replicator cursor when the remote cluster is absent

2023-04-03 Thread via GitHub
BewareMyPower commented on code in PR #19972: URL: https://github.com/apache/pulsar/pull/19972#discussion_r1156774692 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1696,14 +1696,32 @@ public void openCursorFailed(ManagedL

[GitHub] [pulsar] liangyepianzhou opened a new pull request, #20006: [fix][test]Fix flaky test produceCommitTest

2023-04-03 Thread via GitHub
liangyepianzhou opened a new pull request, #20006: URL: https://github.com/apache/pulsar/pull/20006 Fixes https://github.com/apache/pulsar/issues/18466 ### Motivation Fix flaky tests - produceCommitTest. Upon analysis, it was discovered that the issue was due to machine limitations whi

[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #19832: [fix][misc] Change PIP issue template

2023-04-03 Thread via GitHub
liangyepianzhou commented on code in PR #19832: URL: https://github.com/apache/pulsar/pull/19832#discussion_r1156748874 ## .github/ISSUE_TEMPLATE/pip.md: ## @@ -0,0 +1,157 @@ +--- +name: PIP +about: Submit a Pulsar Improvement Proposal (PIP) +title: 'PIP-XYZ: ' +labels: PIP +---

[GitHub] [pulsar-site] Huanli-Meng commented on a diff in pull request #502: [feat][doc] Add Observability Guide

2023-04-03 Thread via GitHub
Huanli-Meng commented on code in PR #502: URL: https://github.com/apache/pulsar-site/pull/502#discussion_r1156746968 ## docs/administration-stats.md: ## @@ -22,15 +22,15 @@ All metrics below are *reset* to 0 upon broker restart, *except* gauges marked a | msgRateOut

[GitHub] [pulsar] lhotari opened a new pull request, #20005: [fix][build] Suppress Guava CVE-2020-8908 in OWASP dependency check

2023-04-03 Thread via GitHub
lhotari opened a new pull request, #20005: URL: https://github.com/apache/pulsar/pull/20005 ### Motivation - Fix OWASP dependency check for master branch - The vulnerable method is deprecated in Guava, but isn't removed. It's necessary to suppress this CVE. See https://github.com/g

[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #19832: [fix][misc] Change PIP issue template

2023-04-03 Thread via GitHub
liangyepianzhou commented on code in PR #19832: URL: https://github.com/apache/pulsar/pull/19832#discussion_r1156742410 ## .github/ISSUE_TEMPLATE/pip.md: ## @@ -0,0 +1,157 @@ +--- +name: PIP +about: Submit a Pulsar Improvement Proposal (PIP) +title: 'PIP-XYZ: ' +labels: PIP +---

[GitHub] [pulsar-site] rupertw commented on pull request #503: Revise a error statement

2023-04-03 Thread via GitHub
rupertw commented on PR #503: URL: https://github.com/apache/pulsar-site/pull/503#issuecomment-1495337170 > @rupertw could you update the NEXT version doc also? The file should locate at `docs/deploy-bare-metal.md`. The error statement in `docs/deploy-bare-metal.md` is already revised -

[GitHub] [pulsar-site] github-actions[bot] commented on pull request #503: Revise a error statement

2023-04-03 Thread via GitHub
github-actions[bot] commented on PR #503: URL: https://github.com/apache/pulsar-site/pull/503#issuecomment-1495305053 @rupertw Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `d

[GitHub] [pulsar-site] rupertw opened a new pull request, #503: Revise a error statement

2023-04-03 Thread via GitHub
rupertw opened a new pull request, #503: URL: https://github.com/apache/pulsar-site/pull/503 Revise a error statement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [pulsar] Demogorgon314 commented on pull request #19958: [improve][broker] PIP-192: Filter the transfer dest broker

2023-04-03 Thread via GitHub
Demogorgon314 commented on PR #19958: URL: https://github.com/apache/pulsar/pull/19958#issuecomment-1495298672 @gaoran10 @Technoboy- PTAL by any chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #502: [feat][doc] Add Observability Guide

2023-04-03 Thread via GitHub
Anonymitaet commented on code in PR #502: URL: https://github.com/apache/pulsar-site/pull/502#discussion_r1156686768 ## sidebars.json: ## @@ -265,6 +263,15 @@ } ] }, +{ + "type": "category", + "label": "Observability", Review Comment: For r

[GitHub] [pulsar-site] Anonymitaet commented on pull request #502: [feat][doc] Add Observability Guide

2023-04-03 Thread via GitHub
Anonymitaet commented on PR #502: URL: https://github.com/apache/pulsar-site/pull/502#issuecomment-1495288948 @momo-jun @Huanli-Meng could you please help review? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pulsar-site] Anonymitaet commented on pull request #501: [feat][doc] Add Get Started for TXN

2023-04-03 Thread via GitHub
Anonymitaet commented on PR #501: URL: https://github.com/apache/pulsar-site/pull/501#issuecomment-1495282512 > have an overview page to map out the reading/learning path, as we do for other major features: introduce basics like "why" and "what", and link to "use" and advanced concepts/deta

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #501: [feat][doc] Add Get Started for TXN

2023-04-03 Thread via GitHub
Anonymitaet commented on code in PR #501: URL: https://github.com/apache/pulsar-site/pull/501#discussion_r1156677146 ## docs/txn-use.md: ## @@ -1,148 +1,170 @@ --- id: txn-use -title: How to use transactions? -sidebar_label: "How to use transactions?" +title: Get started +side

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #501: [feat][doc] Add Get Started for TXN

2023-04-03 Thread via GitHub
Anonymitaet commented on code in PR #501: URL: https://github.com/apache/pulsar-site/pull/501#discussion_r1156676735 ## docs/txn-use.md: ## @@ -1,148 +1,170 @@ --- id: txn-use -title: How to use transactions? -sidebar_label: "How to use transactions?" +title: Get started +side

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #501: [feat][doc] Add Get Started for TXN

2023-04-03 Thread via GitHub
Anonymitaet commented on code in PR #501: URL: https://github.com/apache/pulsar-site/pull/501#discussion_r1156675904 ## docs/txn-advanced-features.md: ## @@ -0,0 +1,45 @@ +--- +id: txn-advanced-features +title: Advanced features +sidebar_label: "Advanced features" +--- + +You ca

[GitHub] [pulsar-client-cpp] shibd commented on pull request #242: [Bug Fix][KeySharedPolicy] Fixed bug where KeySharedPolicy::setStickyRanges duplicated ranges.

2023-04-03 Thread via GitHub
shibd commented on PR #242: URL: https://github.com/apache/pulsar-client-cpp/pull/242#issuecomment-1495259785 @hyperevo Please fix the code format. You can use `./build-support/docker-format.sh` -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #19934: [fix][broker] Return if AbstractDispatcherSingleActiveConsumer closed

2023-04-03 Thread via GitHub
poorbarcode commented on code in PR #19934: URL: https://github.com/apache/pulsar/pull/19934#discussion_r1156658262 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java: ## @@ -102,6 +102,11 @@ public clas

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #19944: [improve][client] Support multi-topic messageId deserialization to ack messages

2023-04-03 Thread via GitHub
BewareMyPower commented on code in PR #19944: URL: https://github.com/apache/pulsar/pull/19944#discussion_r1156655580 ## pulsar-common/src/main/proto/PulsarApi.proto: ## @@ -62,9 +62,9 @@ message MessageIdData { optional int32 batch_index = 4 [default = -1]; repeated i

[pulsar] branch master updated: [fix][broker] Ignore and remove the replicator cursor when the remote cluster is absent (#19972)

2023-04-03 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new d1fc7323cbf [fix][broker] Ignore and remove the rep

[GitHub] [pulsar-site] Huanli-Meng commented on a diff in pull request #501: [feat][doc] Add Get Started for TXN

2023-04-03 Thread via GitHub
Huanli-Meng commented on code in PR #501: URL: https://github.com/apache/pulsar-site/pull/501#discussion_r1156653807 ## docs/txn-advanced-features.md: ## @@ -0,0 +1,45 @@ +--- +id: txn-advanced-features +title: Advanced features +sidebar_label: "Advanced features" +--- + +You ca

[GitHub] [pulsar] BewareMyPower merged pull request #19972: [fix][broker] Ignore and remove the replicator cursor when the remote cluster is absent

2023-04-03 Thread via GitHub
BewareMyPower merged PR #19972: URL: https://github.com/apache/pulsar/pull/19972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pul

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #19944: [improve][client] Support multi-topic messageId deserialization to ack messages

2023-04-03 Thread via GitHub
BewareMyPower commented on code in PR #19944: URL: https://github.com/apache/pulsar/pull/19944#discussion_r1156655580 ## pulsar-common/src/main/proto/PulsarApi.proto: ## @@ -62,9 +62,9 @@ message MessageIdData { optional int32 batch_index = 4 [default = -1]; repeated i

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #19934: [fix][broker] Return if AbstractDispatcherSingleActiveConsumer closed

2023-04-03 Thread via GitHub
AnonHxy commented on code in PR #19934: URL: https://github.com/apache/pulsar/pull/19934#discussion_r1156653236 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentStickyKeyDispatcherMultipleConsumersTest.java: ## @@ -94,6 +94,15 @@ public

[GitHub] [pulsar-site] momo-jun commented on a diff in pull request #501: [feat][doc] Add Get Started for TXN

2023-04-03 Thread via GitHub
momo-jun commented on code in PR #501: URL: https://github.com/apache/pulsar-site/pull/501#discussion_r1156638847 ## docs/txn-use.md: ## @@ -1,148 +1,170 @@ --- id: txn-use -title: How to use transactions? -sidebar_label: "How to use transactions?" +title: Get started +sidebar

[GitHub] [pulsar] github-actions[bot] commented on issue #17878: [Doc] Fix Admin Interface docs for Managing partitioned topics

2023-04-03 Thread via GitHub
github-actions[bot] commented on issue #17878: URL: https://github.com/apache/pulsar/issues/17878#issuecomment-1495229413 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pulsar] github-actions[bot] commented on issue #19713: Expose zookeeper client metric in BookkeeperMetadataDrivers.

2023-04-03 Thread via GitHub
github-actions[bot] commented on issue #19713: URL: https://github.com/apache/pulsar/issues/19713#issuecomment-1495227588 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pulsar] Anonymitaet commented on issue #20002: [improve][doc] Optimize instructions for Pulsar stats

2023-04-03 Thread via GitHub
Anonymitaet commented on issue #20002: URL: https://github.com/apache/pulsar/issues/20002#issuecomment-1495223284 Fix in https://github.com/apache/pulsar-site/pull/502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [pulsar] Anonymitaet commented on issue #19776: [doc][feat] add *Observability* guide and *Structured Event Logging* chapters

2023-04-03 Thread via GitHub
Anonymitaet commented on issue #19776: URL: https://github.com/apache/pulsar/issues/19776#issuecomment-1495222785 Reply from @ivankelly: This was an idea that never got off the ground. The plan had been to instrument the broker and functions so that there would be information that t

[GitHub] [pulsar-site] Anonymitaet commented on pull request #502: [feat][doc] Add Observability Guide

2023-04-03 Thread via GitHub
Anonymitaet commented on PR #502: URL: https://github.com/apache/pulsar-site/pull/502#issuecomment-1495220153 @hangc0276 Could you please review this PR from a technical perspective? Then I'll ask tws to review it from a technical writing side. Thank you! -- This is an automated message f

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #502: [feat][doc] Add Observability Guide

2023-04-03 Thread via GitHub
Anonymitaet commented on code in PR #502: URL: https://github.com/apache/pulsar-site/pull/502#discussion_r1156626060 ## docs/administration-stats.md: ## @@ -1,7 +1,7 @@ --- id: administration-stats title: Pulsar stats -sidebar_label: "Pulsar statistics" Review Comment: Fo

[GitHub] [pulsar-site] Anonymitaet commented on pull request #502: [feat][doc] Add Observability Guide

2023-04-03 Thread via GitHub
Anonymitaet commented on PR #502: URL: https://github.com/apache/pulsar-site/pull/502#issuecomment-1495218738 The preview looks good: https://user-images.githubusercontent.com/50226895/229664285-249aa7bf-72bf-462e-a761-70bdd156830d.png";> -- This is an automated message from the Apa

[GitHub] [pulsar-site] Anonymitaet opened a new pull request, #502: [feat][doc] Add Observability Guide

2023-04-03 Thread via GitHub
Anonymitaet opened a new pull request, #502: URL: https://github.com/apache/pulsar-site/pull/502 ## What issues does this PR solve? This PR fixes https://github.com/apache/pulsar/issues/19776 and https://github.com/apache/pulsar/issues/20002. I’ve summarized all issues with the

[GitHub] [pulsar-client-go] d80tb7 commented on issue #932: [feature request] Support Transaction API

2023-04-03 Thread via GitHub
d80tb7 commented on issue #932: URL: https://github.com/apache/pulsar-client-go/issues/932#issuecomment-1495203620 Hi @liangyepianzhou good work on this so far! Am I right in thinking that transactions aren't available in the public api in `0.10`? I can see there's an `EnableTransaction`

[GitHub] [pulsar] yuweisung opened a new issue, #20003: [clarification][Doc] bouncy castle providers only support JCE not JSSE

2023-04-03 Thread via GitHub
yuweisung opened a new issue, #20003: URL: https://github.com/apache/pulsar/issues/20003 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### What issue do you find in Pulsar docs? Pulsar on

[GitHub] [pulsar] michaeljmarshall commented on pull request #19976: [improve][txn] Cleanup how superusers abort txns

2023-04-03 Thread via GitHub
michaeljmarshall commented on PR #19976: URL: https://github.com/apache/pulsar/pull/19976#issuecomment-1494911892 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] heesung-sn commented on pull request #19988: [improve][broker] PIP-192 made split handler idempotent

2023-04-03 Thread via GitHub
heesung-sn commented on PR #19988: URL: https://github.com/apache/pulsar/pull/19988#issuecomment-1494872685 @Demogorgon314 fyi, I updated the code - to continue splitting after monitoring logic - to fix the dst and src broker order in the splitting state data copy. -- This is an auto

[GitHub] [pulsar] rdhabalia commented on a diff in pull request #19944: [improve][client] Support multi-topic messageId deserialization to ack messages

2023-04-03 Thread via GitHub
rdhabalia commented on code in PR #19944: URL: https://github.com/apache/pulsar/pull/19944#discussion_r1156269601 ## pulsar-common/src/main/proto/PulsarApi.proto: ## @@ -62,9 +62,9 @@ message MessageIdData { optional int32 batch_index = 4 [default = -1]; repeated int64

[GitHub] [pulsar] rdhabalia commented on issue #18616: PIP-224: Introduce TopicMessageId for consumer's MessageId related APIs

2023-04-03 Thread via GitHub
rdhabalia commented on issue #18616: URL: https://github.com/apache/pulsar/issues/18616#issuecomment-1494728202 @BewareMyPower : serializing and deserializing is expensive and on top of that having different APIs for different use cases is creating a really bad experience for users, and I s

[GitHub] [pulsar] poorbarcode commented on pull request #19989: [fix][broker] Only validate superuser access if authz enabled

2023-04-03 Thread via GitHub
poorbarcode commented on PR #19989: URL: https://github.com/apache/pulsar/pull/19989#issuecomment-1494726887 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [pulsar] rdhabalia commented on a diff in pull request #19944: [improve][client] Support multi-topic messageId deserialization to ack messages

2023-04-03 Thread via GitHub
rdhabalia commented on code in PR #19944: URL: https://github.com/apache/pulsar/pull/19944#discussion_r1156265055 ## pulsar-common/src/main/proto/PulsarApi.proto: ## @@ -62,9 +62,9 @@ message MessageIdData { optional int32 batch_index = 4 [default = -1]; repeated int64

[GitHub] [pulsar-client-python] hyperevo commented on pull request #109: [Enhancement/Feature Issue #47] Added support for KeySharedPolicy for the consumer when in KeyShared mode.

2023-04-03 Thread via GitHub
hyperevo commented on PR #109: URL: https://github.com/apache/pulsar-client-python/pull/109#issuecomment-1494578218 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[pulsar] branch branch-2.10 updated: [branch-2.10] [fix] [auth] fix not forward compatible config saslJaasServerRoleTokenSignerSecretPath after cherry-pick #15121 (#19971)

2023-04-03 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-2.10 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.10 by this push: new cef4f71e7e8 [branch-2.10] [fix] [auth]

[GitHub] [pulsar] poorbarcode merged pull request #19971: [branch-2.10] [fix] [auth] fix not forward compatible config saslJaasServerRoleTokenSignerSecretPath after cherry-pick #15121

2023-04-03 Thread via GitHub
poorbarcode merged PR #19971: URL: https://github.com/apache/pulsar/pull/19971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsa

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #501: [feat][doc] Add Get Started for TXN

2023-04-03 Thread via GitHub
Anonymitaet commented on code in PR #501: URL: https://github.com/apache/pulsar-site/pull/501#discussion_r1156048672 ## sidebars.json: ## @@ -204,9 +204,10 @@ "items": [ "txn-why", "txn-what", -"txn-how", "txn-use", -"txn-monitor

[GitHub] [pulsar] Anonymitaet commented on issue #19996: [improve][doc] Optimize "Get Started" for transactions

2023-04-03 Thread via GitHub
Anonymitaet commented on issue #19996: URL: https://github.com/apache/pulsar/issues/19996#issuecomment-1494442287 Fix this in https://github.com/apache/pulsar-site/pull/501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [pulsar-site] Anonymitaet commented on pull request #501: [feat][doc] Add Get Started for txn

2023-04-03 Thread via GitHub
Anonymitaet commented on PR #501: URL: https://github.com/apache/pulsar-site/pull/501#issuecomment-1494441075 Hi @congbobo184 Could you please review this PR from a technical perspective? Then writers (@Huanli-Meng @momo-jun) will review it from a technical writing side. Thank you!

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #501: [feat][doc] Add Get Started for txn

2023-04-03 Thread via GitHub
Anonymitaet commented on code in PR #501: URL: https://github.com/apache/pulsar-site/pull/501#discussion_r1156048672 ## sidebars.json: ## @@ -204,9 +204,10 @@ "items": [ "txn-why", "txn-what", -"txn-how", "txn-use", -"txn-monitor

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #501: [feat][doc] Add Get Started for txn

2023-04-03 Thread via GitHub
Anonymitaet commented on code in PR #501: URL: https://github.com/apache/pulsar-site/pull/501#discussion_r1156047762 ## docs/txn-what.md: ## @@ -1,7 +1,7 @@ --- id: txn-what title: What are transactions? -sidebar_label: "What are transactions?" +sidebar_label: "Concept" Revi

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #501: [feat][doc] Add Get Started for txn

2023-04-03 Thread via GitHub
Anonymitaet commented on code in PR #501: URL: https://github.com/apache/pulsar-site/pull/501#discussion_r1156045487 ## docs/txn-use.md: ## @@ -1,148 +1,166 @@ --- id: txn-use -title: How to use transactions? -sidebar_label: "How to use transactions?" +title: Get started +side

[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #501: [feat][doc] Add Get Started for txn

2023-04-03 Thread via GitHub
Anonymitaet commented on code in PR #501: URL: https://github.com/apache/pulsar-site/pull/501#discussion_r1156045487 ## docs/txn-use.md: ## @@ -1,148 +1,166 @@ --- id: txn-use -title: How to use transactions? -sidebar_label: "How to use transactions?" +title: Get started +side

[GitHub] [pulsar-site] Anonymitaet commented on pull request #501: [feat][doc] Add Get Started for txn

2023-04-03 Thread via GitHub
Anonymitaet commented on PR #501: URL: https://github.com/apache/pulsar-site/pull/501#issuecomment-1494428177 The preview looks good: ![image](https://user-images.githubusercontent.com/50226895/229539104-5094b6c7-ffd0-426d-bf2d-04c1c06cac0f.png) -- This is an automated mess

[GitHub] [pulsar] heesung-sn commented on pull request #19988: [improve][broker] PIP-192 made split handler idempotent

2023-04-03 Thread via GitHub
heesung-sn commented on PR #19988: URL: https://github.com/apache/pulsar/pull/19988#issuecomment-1494423658 @Demogorgon314 @Technoboy- PTAL by any chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [pulsar] shibd commented on a diff in pull request #15622: [Java Client] Fix messages sent by producers without schema cannot be decoded

2023-04-03 Thread via GitHub
shibd commented on code in PR #15622: URL: https://github.com/apache/pulsar/pull/15622#discussion_r1156018535 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java: ## @@ -382,23 +384,28 @@ public Optional> getReaderSchema() { if (schema == null)

[GitHub] [pulsar] heesung-sn commented on pull request #19945: [improve][broker] PIP-192 updated metrics and cleanup broker selector

2023-04-03 Thread via GitHub
heesung-sn commented on PR #19945: URL: https://github.com/apache/pulsar/pull/19945#issuecomment-1494421586 @gaoran10 @Technoboy- PTAL by any chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar-site] Anonymitaet opened a new pull request, #501: [feat][doc] Add Get Started for txn

2023-04-03 Thread via GitHub
Anonymitaet opened a new pull request, #501: URL: https://github.com/apache/pulsar-site/pull/501 ## What issues does this PR solve? Currently, there are some issues in the [Pulsar transactions doc](https://pulsar.apache.org/docs/next/txn-use/) (as stated in https://github.com/apa

[GitHub] [pulsar] shibd commented on a diff in pull request #15622: [Java Client] Fix messages sent by producers without schema cannot be decoded

2023-04-03 Thread via GitHub
shibd commented on code in PR #15622: URL: https://github.com/apache/pulsar/pull/15622#discussion_r1156018535 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java: ## @@ -382,23 +384,28 @@ public Optional> getReaderSchema() { if (schema == null)

[GitHub] [pulsar] shibd commented on a diff in pull request #15622: [Java Client] Fix messages sent by producers without schema cannot be decoded

2023-04-03 Thread via GitHub
shibd commented on code in PR #15622: URL: https://github.com/apache/pulsar/pull/15622#discussion_r1156018535 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java: ## @@ -382,23 +384,28 @@ public Optional> getReaderSchema() { if (schema == null)

[GitHub] [pulsar] 315157973 commented on a diff in pull request #19992: [fix][broker] Avoid Bookie data is never deleted

2023-04-03 Thread via GitHub
315157973 commented on code in PR #19992: URL: https://github.com/apache/pulsar/pull/19992#discussion_r1155911442 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java: ## @@ -2931,39 +2949,53 @@ public void deleteCursorFailed(ManagedLedgerExc

[GitHub] [pulsar] poorbarcode commented on pull request #19971: [branch-2.10] [fix] [auth] fix not forward compatible config saslJaasServerRoleTokenSignerSecretPath after cherry-pick #15121

2023-04-03 Thread via GitHub
poorbarcode commented on PR #19971: URL: https://github.com/apache/pulsar/pull/19971#issuecomment-1494187247 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [pulsar] tisonkun commented on pull request #19432: [improve] Allow to build and push multi-arch Docker images

2023-04-03 Thread via GitHub
tisonkun commented on PR #19432: URL: https://github.com/apache/pulsar/pull/19432#issuecomment-1494168901 Seems we failed to build the test image in time (killed due to 1 hour timeout). I'm retriggering the workflow, but if it remains, we may find someway to speed up the execution. -- Th

[GitHub] [pulsar] GerMoranOverstock commented on pull request #19766: [improve][ci] Docker multi arch - Addresses PR comments from #19432

2023-04-03 Thread via GitHub
GerMoranOverstock commented on PR #19766: URL: https://github.com/apache/pulsar/pull/19766#issuecomment-1494148981 > It seems the original PR is active again. Closing... Yeah glad to see, unfortunately I found getting the automation kicked off on the PR process quiet complex and wasn'

[GitHub] [pulsar] 315157973 commented on a diff in pull request #19972: [fix][broker] Ignore and remove the replicator cursor when the remote cluster is absent

2023-04-03 Thread via GitHub
315157973 commented on code in PR #19972: URL: https://github.com/apache/pulsar/pull/19972#discussion_r1155826899 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1696,14 +1696,32 @@ public void openCursorFailed(ManagedLedge

[GitHub] [pulsar] codecov-commenter commented on pull request #19972: [fix][broker] Ignore and remove the replicator cursor when the remote cluster is absent

2023-04-03 Thread via GitHub
codecov-commenter commented on PR #19972: URL: https://github.com/apache/pulsar/pull/19972#issuecomment-1494092713 ## [Codecov](https://codecov.io/gh/apache/pulsar/pull/19972?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+S

[GitHub] [pulsar] Anonymitaet opened a new issue, #20002: [improve][doc] Optimize instructions for Pulsar stats

2023-04-03 Thread via GitHub
Anonymitaet opened a new issue, #20002: URL: https://github.com/apache/pulsar/issues/20002 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### What issue do you find in Pulsar docs? Current

[GitHub] [pulsar-client-go] RobertIndie opened a new pull request, #1000: [Doc] Fix missing link in the release process

2023-04-03 Thread via GitHub
RobertIndie opened a new pull request, #1000: URL: https://github.com/apache/pulsar-client-go/pull/1000 ### Motivation Fix missing link in the release process ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, p

[pulsar-site] branch main updated: Add issue triaging doc (#485)

2023-04-03 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 7be51c24a06 Add issue triaging doc (#485) 7be51c

[GitHub] [pulsar-site] tisonkun merged pull request #485: Add issue triaging doc

2023-04-03 Thread via GitHub
tisonkun merged PR #485: URL: https://github.com/apache/pulsar-site/pull/485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.

[GitHub] [pulsar] AnonHxy opened a new pull request, #20001: [improve][broker] Read cache misses metric for topic

2023-04-03 Thread via GitHub
AnonHxy opened a new pull request, #20001: URL: https://github.com/apache/pulsar/pull/20001 ### Motivation When threre are too many read request from bookie server, we need find which topic is catch up reading. So here we add a `storage_read_cache_misses_rate` for topic level.

svn commit: r61020 - /dev/pulsar/pulsar-client-go-0.10.0-candidate-1/ /release/pulsar/pulsar-client-go-0.10.0/

2023-04-03 Thread technoboy
Author: technoboy Date: Mon Apr 3 09:52:50 2023 New Revision: 61020 Log: Release 0.10.0 Added: release/pulsar/pulsar-client-go-0.10.0/ - copied from r61019, dev/pulsar/pulsar-client-go-0.10.0-candidate-1/ Removed: dev/pulsar/pulsar-client-go-0.10.0-candidate-1/

[GitHub] [pulsar] poorbarcode commented on pull request #19971: [branch-2.10] [fix] [auth] fix not forward compatible config saslJaasServerRoleTokenSignerSecretPath after cherry-pick #15121

2023-04-03 Thread via GitHub
poorbarcode commented on PR #19971: URL: https://github.com/apache/pulsar/pull/19971#issuecomment-1494012163 Cherry-picked https://github.com/apache/pulsar/pull/14509 into `branch-2.10` to fix the OOM EX. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar] poorbarcode commented on pull request #14509: [Build/Tests] Make the test JVM exit if OOME occurs

2023-04-03 Thread via GitHub
poorbarcode commented on PR #14509: URL: https://github.com/apache/pulsar/pull/14509#issuecomment-1494010961 Hi @lhotari The 2.10 branch also occurs the OOM exception, so I cherry-picked this PR into the `branch-2.10`. see: https://github.com/apache/pulsar/actions/runs/456671

[pulsar] branch branch-2.10 updated: [Build] Make the test JVM exit if OOME occurs (#14509)

2023-04-03 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch branch-2.10 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.10 by this push: new a19879ba17b [Build] Make the test JVM

[GitHub] [pulsar] asafm commented on a diff in pull request #19832: [fix][misc] Change PIP issue template

2023-04-03 Thread via GitHub
asafm commented on code in PR #19832: URL: https://github.com/apache/pulsar/pull/19832#discussion_r1155720883 ## .github/ISSUE_TEMPLATE/pip.md: ## @@ -0,0 +1,151 @@ +--- +name: PIP +about: Submit a Pulsar Improvement Proposal (PIP) +title: 'PIP-XYZ: ' +labels: PIP +--- + + + +#

[GitHub] [pulsar] asafm commented on a diff in pull request #19832: [fix][misc] Change PIP issue template

2023-04-03 Thread via GitHub
asafm commented on code in PR #19832: URL: https://github.com/apache/pulsar/pull/19832#discussion_r1155718725 ## .github/ISSUE_TEMPLATE/pip.md: ## @@ -0,0 +1,151 @@ +--- +name: PIP +about: Submit a Pulsar Improvement Proposal (PIP) +title: 'PIP-XYZ: ' +labels: PIP +--- + + + +#

[GitHub] [pulsar] asafm commented on a diff in pull request #19832: [fix][misc] Change PIP issue template

2023-04-03 Thread via GitHub
asafm commented on code in PR #19832: URL: https://github.com/apache/pulsar/pull/19832#discussion_r1155716128 ## .github/ISSUE_TEMPLATE/pip.md: ## @@ -0,0 +1,151 @@ +--- +name: PIP +about: Submit a Pulsar Improvement Proposal (PIP) +title: 'PIP-XYZ: ' +labels: PIP +--- + + + +#

[GitHub] [pulsar] asafm commented on a diff in pull request #19832: [fix][misc] Change PIP issue template

2023-04-03 Thread via GitHub
asafm commented on code in PR #19832: URL: https://github.com/apache/pulsar/pull/19832#discussion_r1155716128 ## .github/ISSUE_TEMPLATE/pip.md: ## @@ -0,0 +1,151 @@ +--- +name: PIP +about: Submit a Pulsar Improvement Proposal (PIP) +title: 'PIP-XYZ: ' +labels: PIP +--- + + + +#

[GitHub] [pulsar] asafm commented on a diff in pull request #19832: [fix][misc] Change PIP issue template

2023-04-03 Thread via GitHub
asafm commented on code in PR #19832: URL: https://github.com/apache/pulsar/pull/19832#discussion_r1155714389 ## .github/ISSUE_TEMPLATE/pip.md: ## @@ -0,0 +1,151 @@ +--- +name: PIP +about: Submit a Pulsar Improvement Proposal (PIP) +title: 'PIP-XYZ: ' +labels: PIP +--- + + + +#

[GitHub] [pulsar] poorbarcode commented on pull request #19971: [branch-2.10] [fix] [auth] fix not forward compatible config saslJaasServerRoleTokenSignerSecretPath after cherry-pick #15121

2023-04-03 Thread via GitHub
poorbarcode commented on PR #19971: URL: https://github.com/apache/pulsar/pull/19971#issuecomment-1493958327 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [pulsar] tisonkun commented on issue #19970: [Bug]

2023-04-03 Thread via GitHub
tisonkun commented on issue #19970: URL: https://github.com/apache/pulsar/issues/19970#issuecomment-1493942977 Hi @sigikjohn-vargheese! The interface `PartitionedTopicStats` which is returned by `getPartitionedStats` is `extends TopicStats` which is returned by `getStats`. So any fie

[GitHub] [pulsar-site] tisonkun commented on pull request #485: Add issue triaging doc

2023-04-03 Thread via GitHub
tisonkun commented on PR #485: URL: https://github.com/apache/pulsar-site/pull/485#issuecomment-1493925380 I'm going to merge it later since we sooner or later need to talk about how to triage issues. Comments after merging are always welcome. -- This is an automated message from the

[GitHub] [pulsar] tisonkun commented on issue #19997: should support IPv4/IPv6 dualstack

2023-04-03 Thread via GitHub
tisonkun commented on issue #19997: URL: https://github.com/apache/pulsar/issues/19997#issuecomment-1493919430 @zhangdejin-tom could you please provide more background and context? Better if you can have a reproduced repo for what's proposed here. One line "request" just does not work. --

[GitHub] [pulsar] jiangpengcheng opened a new pull request, #20000: [fix][fn] Support multiple input topics for GO runtime

2023-04-03 Thread via GitHub
jiangpengcheng opened a new pull request, #2: URL: https://github.com/apache/pulsar/pull/2 Fixes #19981 Master Issue: #xyz PIP: #xyz ### Motivation The GO runtime doesn't support multi-input topics, ### Modif

[GitHub] [pulsar] labuladong commented on issue #19316: [Bug] The data returned by the "/non-persistent/{tenant}/{namespace}" interface does not seem to be correct

2023-04-03 Thread via GitHub
labuladong commented on issue #19316: URL: https://github.com/apache/pulsar/issues/19316#issuecomment-1493911964 @syhily Sorry, I didn't have time to resolve this now; I've unassigned myself. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[pulsar] branch branch-2.11 updated: [fix] [ml] make the result of delete cursor is success if cursor is deleted (#19825)

2023-04-03 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.11 by this push: new 1b4f35db22e [fix] [ml] make the res

[GitHub] [pulsar-helm-chart] Shohou commented on issue #357: PDB issue on EKS version 1.25+

2023-04-03 Thread via GitHub
Shohou commented on issue #357: URL: https://github.com/apache/pulsar-helm-chart/issues/357#issuecomment-1493884880 Well, my guess was incorrect and this was issue with the helm... This commands fixed issue: ``` helm plugin install https://github.com/helm/helm-mapkubeapis helm ma

[GitHub] [pulsar-helm-chart] Shohou closed issue #357: PDB issue on EKS version 1.25+

2023-04-03 Thread via GitHub
Shohou closed issue #357: PDB issue on EKS version 1.25+ URL: https://github.com/apache/pulsar-helm-chart/issues/357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [pulsar] Technoboy- commented on pull request #19991: [fix][build] Client modules should be built with Java 8

2023-04-03 Thread via GitHub
Technoboy- commented on PR #19991: URL: https://github.com/apache/pulsar/pull/19991#issuecomment-1493876953 > Hi @Technoboy-! This can be a release blocker to 2.11.1. Since you're the RM for this release, I'd like to let you know this patch and ask if you can cherry-pick it to branch-2.11 a

[pulsar] branch branch-2.11 updated: [fix][build] Client modules should be built with Java 8 (#19991)

2023-04-03 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.11 by this push: new f3b69efce83 [fix][build] Client mod

[GitHub] [pulsar] tisonkun commented on pull request #19991: [fix][build] Client modules should be built with Java 8

2023-04-03 Thread via GitHub
tisonkun commented on PR #19991: URL: https://github.com/apache/pulsar/pull/19991#issuecomment-1493873410 Hi @Technoboy-! This can be a release blocker to 2.11.1. Since you're the RM for this release, I'd like to let you know this patch and ask if you can cherry-pick it to branch-2.11 and i

[pulsar] branch branch-2.11 updated: [fix][broker] Fix NPE when update topic policy. (#19875)

2023-04-03 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.11 by this push: new b441b2f784b [fix][broker] Fix NPE w

[GitHub] [pulsar] Demogorgon314 opened a new pull request, #19999: [improve][broker] PIP-192: Update the lookup data path to support deploy and rollback

2023-04-03 Thread via GitHub
Demogorgon314 opened a new pull request, #1: URL: https://github.com/apache/pulsar/pull/1 PIP: https://github.com/apache/pulsar/issues/16691 ### Motivation If we deploy the new LB or rollback to the old LB. We need to isolate broker-bundle assignments to those brokers t

[GitHub] [pulsar] eolivelli merged pull request #19991: [fix][build] Client modules should be built with Java 8

2023-04-03 Thread via GitHub
eolivelli merged PR #19991: URL: https://github.com/apache/pulsar/pull/19991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.

  1   2   >