BewareMyPower commented on code in PR #19944:
URL: https://github.com/apache/pulsar/pull/19944#discussion_r1156655580
##########
pulsar-common/src/main/proto/PulsarApi.proto:
##########
@@ -62,9 +62,9 @@ message MessageIdData {
optional int32 batch_index = 4 [default = -1];
repeated int64 ack_set = 5;
optional int32 batch_size = 6;
-
// For the chunk message id, we need to specify the first chunk message id.
optional MessageIdData first_chunk_message_id = 7;
+ optional string topicName = 8;
Review Comment:
Actually I'm +1 to your PR and I think the API proposed in PIP-224 could be
replaced with this PR.
> few committers block all the PRs without any reason
However, the reason I blocked this PR is the current requirement of the
https://github.com/apache/pulsar/blob/master/wiki/proposals/PIP.md
> Any change to the wire protocol APIs
This PR brings a change to the wire protocol API, and I think it should not
be passed without any proposal. /cc @merlimat @eolivelli @codelipenghui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
