[I] [BUG] Execution of go test is blocked [pulsar-client-go]

2023-10-20 Thread via GitHub
Kolo7 opened a new issue, #1106: URL: https://github.com/apache/pulsar-client-go/issues/1106 Expected behavior > go test ./... Execute go test correctly, whether it passes or not. Actual behavior After executing go test, the command will not complete.

Re: [PR] [improve][common] Reuse ClassLoader for the same NAR [pulsar]

2023-10-20 Thread via GitHub
coderzc commented on code in PR #21402: URL: https://github.com/apache/pulsar/pull/21402#discussion_r1366567027 ## pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarClassLoader.java: ## @@ -135,24 +141,41 @@ public class NarClassLoader extends URLClassLoader { *

Re: [PR] [improve][common] Reuse ClassLoader for the same NAR [pulsar]

2023-10-20 Thread via GitHub
coderzc commented on code in PR #21402: URL: https://github.com/apache/pulsar/pull/21402#discussion_r1366566761 ## pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarClassLoader.java: ## @@ -135,24 +141,41 @@ public class NarClassLoader extends URLClassLoader { *

[PR] Avoid blocking the message listener threads [pulsar-client-cpp]

2023-10-20 Thread via GitHub
erobot opened a new pull request, #332: URL: https://github.com/apache/pulsar-client-cpp/pull/332 ### Motivation The message listener thread blocks when the receiver queue of `MultiTopicsConsumerImpl` is full. As message listener threads are used by all consumers in the same `Client`

[PR] [improve][txn] Take first snapshot before persisting the first transactional message [pulsar]

2023-10-20 Thread via GitHub
liangyepianzhou opened a new pull request, #21406: URL: https://github.com/apache/pulsar/pull/21406 ### Motivation The decision to write a snapshot before the first transaction message instead of before building the producer, is based on the fact that only the act of writing transactiona

[pulsar-dotpulsar] branch master updated: Running the tests multiple times revealed some race conditions causing a hang when disposing the client and its producers, consumers, and readers after the cu

2023-10-20 Thread blankensteiner
This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git The following commit(s) were added to refs/heads/master by this push: new d520b3e Running the tests mul

Re: [PR] Avoid blocking the message listener threads [pulsar-client-cpp]

2023-10-20 Thread via GitHub
BewareMyPower commented on code in PR #332: URL: https://github.com/apache/pulsar-client-cpp/pull/332#discussion_r1366703612 ## tests/ConsumerTest.cc: ## @@ -1335,4 +1335,67 @@ TEST(ConsumerTest, testRetrySubscribe) { // milliseconds } +TEST(ConsumerTest, testNoListenerT

Re: [PR] Avoid blocking the message listener threads [pulsar-client-cpp]

2023-10-20 Thread via GitHub
BewareMyPower commented on code in PR #332: URL: https://github.com/apache/pulsar-client-cpp/pull/332#discussion_r1366708418 ## lib/MessageImpl.h: ## @@ -47,6 +47,7 @@ class MessageImpl { int redeliveryCount_; bool hasSchemaVersion_; const std::string* schemaVersi

Re: [PR] [fix][client] Fix typos in AuthenticationDataProvider interface [pulsar]

2023-10-20 Thread via GitHub
hanmz commented on PR #21404: URL: https://github.com/apache/pulsar/pull/21404#issuecomment-1772383354 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] [Bug] Subscription consumption stuck on [pulsar]

2023-10-20 Thread via GitHub
ethqunzhong commented on issue #21199: URL: https://github.com/apache/pulsar/issues/21199#issuecomment-1772387172 Can normal consumption be restored after unload or restart owner broker ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [improve][txn] Take first snapshot before persisting the first transactional message [pulsar]

2023-10-20 Thread via GitHub
Demogorgon314 commented on code in PR #21406: URL: https://github.com/apache/pulsar/pull/21406#discussion_r1366731435 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/buffer/TopicTransactionBufferTest.java: ## @@ -179,4 +182,57 @@ public void testCloseTransact

Re: [I] [Bug] SIGSEGV fatal error detected by JRE [pulsar]

2023-10-20 Thread via GitHub
vinz2714 commented on issue #20571: URL: https://github.com/apache/pulsar/issues/20571#issuecomment-1772510703 we have also faced the same error with 2.11.0 This is happening when we are doing load test # # A fatal error has been detected by the Java Runtime Environment: # # S

Re: [PR] [improve][txn] Take first snapshot before persisting the first transactional message [pulsar]

2023-10-20 Thread via GitHub
poorbarcode commented on code in PR #21406: URL: https://github.com/apache/pulsar/pull/21406#discussion_r1366824933 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java: ## @@ -255,6 +230,40 @@ public long getCommittedTxnCou

Re: [PR] [fix][txn]Remove subscription after transaction pending ack init failed. [pulsar]

2023-10-20 Thread via GitHub
poorbarcode commented on code in PR #21274: URL: https://github.com/apache/pulsar/pull/21274#discussion_r1366845862 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java: ## @@ -945,12 +954,33 @@ public void completeHandleF

Re: [PR] [fix][txn]Remove subscription after transaction pending ack init failed. [pulsar]

2023-10-20 Thread via GitHub
poorbarcode commented on code in PR #21274: URL: https://github.com/apache/pulsar/pull/21274#discussion_r1366845862 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java: ## @@ -945,12 +954,33 @@ public void completeHandleF

Re: [PR] [fix][txn]Remove subscription after transaction pending ack init failed. [pulsar]

2023-10-20 Thread via GitHub
poorbarcode commented on code in PR #21274: URL: https://github.com/apache/pulsar/pull/21274#discussion_r1366854269 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java: ## @@ -153,7 +163,11 @@ public PendingAckHandleImpl(

Re: [PR] Avoid blocking the message listener threads [pulsar-client-cpp]

2023-10-20 Thread via GitHub
erobot commented on code in PR #332: URL: https://github.com/apache/pulsar-client-cpp/pull/332#discussion_r1366862301 ## tests/ConsumerTest.cc: ## @@ -1335,4 +1335,67 @@ TEST(ConsumerTest, testRetrySubscribe) { // milliseconds } +TEST(ConsumerTest, testNoListenerThreadBl

[PR] [fix][test] Fix LocalBookkeeperEnsemble resource leak in tests [pulsar]

2023-10-20 Thread via GitHub
lhotari opened a new pull request, #21407: URL: https://github.com/apache/pulsar/pull/21407 ### Motivation LocalBookkeeperEnsemble leaks threads and memory. The way it leaks threads is when `portManager` is set to `() -> 0`, the metadata in Zookeeper will conflict and the bookies t

Re: [PR] [improve][common] Reuse ClassLoader for the same NAR [pulsar]

2023-10-20 Thread via GitHub
lhotari commented on code in PR #21402: URL: https://github.com/apache/pulsar/pull/21402#discussion_r1366883462 ## pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarClassLoader.java: ## @@ -283,4 +304,32 @@ protected String findLibrary(final String libname) { publ

Re: [PR] [improve][common] Reuse ClassLoader for the same NAR [pulsar]

2023-10-20 Thread via GitHub
coderzc commented on code in PR #21402: URL: https://github.com/apache/pulsar/pull/21402#discussion_r1366886884 ## pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarClassLoader.java: ## @@ -283,4 +304,32 @@ protected String findLibrary(final String libname) { publ

Re: [PR] [improve][common] Reuse ClassLoader for the same NAR [pulsar]

2023-10-20 Thread via GitHub
lhotari commented on code in PR #21402: URL: https://github.com/apache/pulsar/pull/21402#discussion_r1366887822 ## pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarClassLoader.java: ## @@ -135,21 +143,34 @@ public class NarClassLoader extends URLClassLoader { *

Re: [PR] [improve][common] Reuse ClassLoader for the same NAR [pulsar]

2023-10-20 Thread via GitHub
eolivelli commented on PR #21402: URL: https://github.com/apache/pulsar/pull/21402#issuecomment-1772627062 If you want to go this way we must ask the connector developers to mark the connector as "classloader safe", in some configuration entry in the nar manifest for instance -- This is

Re: [PR] [improve][common] Reuse ClassLoader for the same NAR [pulsar]

2023-10-20 Thread via GitHub
coderzc commented on PR #21402: URL: https://github.com/apache/pulsar/pull/21402#issuecomment-1772635957 > This is not a good idea, if you share the classloader then you share the static variables and if the connector is not well coded (i.e. it uses shared state in static variables like cac

Re: [PR] [improve][common] Reuse ClassLoader for the same NAR [pulsar]

2023-10-20 Thread via GitHub
eolivelli commented on PR #21402: URL: https://github.com/apache/pulsar/pull/21402#issuecomment-1772639469 what's the point of sharing the classloader if you are not sharing the same code ? The goal of this patch is to not load the same classes twice, and that is my problem. If yo

Re: [PR] Release process and GitHub Action to release a NuGet packages, based on tags. [pulsar-dotpulsar]

2023-10-20 Thread via GitHub
tisonkun commented on PR #184: URL: https://github.com/apache/pulsar-dotpulsar/pull/184#issuecomment-1772641409 I'll review this patch in the next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Avoid blocking the message listener threads [pulsar-client-cpp]

2023-10-20 Thread via GitHub
erobot commented on code in PR #332: URL: https://github.com/apache/pulsar-client-cpp/pull/332#discussion_r1366948388 ## lib/MessageImpl.h: ## @@ -47,6 +47,7 @@ class MessageImpl { int redeliveryCount_; bool hasSchemaVersion_; const std::string* schemaVersion_; +

Re: [PR] Release process and GitHub Action to release a NuGet packages, based on tags. [pulsar-dotpulsar]

2023-10-20 Thread via GitHub
dave2wave commented on PR #184: URL: https://github.com/apache/pulsar-dotpulsar/pull/184#issuecomment-1772783047 @eolivelli is correct and the release must be VOTED on as a source release. Once that passes then pressing a button to build and release a convenience binary to a packager may be

[I] Is there a way to get the status of client connection? [pulsar-client-python]

2023-10-20 Thread via GitHub
abmoussaoui opened a new issue, #158: URL: https://github.com/apache/pulsar-client-python/issues/158 Hello, When the pulsar server go down after a succressful connection to the python client, is there a way to check if that the connection is destroyed. like for instance a boo

[PR] [Issue 1105][pulsaradmin] fix AutoTopicCreation for type non-partitioned [pulsar-client-go]

2023-10-20 Thread via GitHub
tomjo opened a new pull request, #1107: URL: https://github.com/apache/pulsar-client-go/pull/1107 Fixes #1105 ### Motivation To allow setting the AutoTopicCreation policy to non-partitioned it is required to not send the partitions parameter, by making Partitions a pointer ins

[PR] [improve][broker] PIP-307 Added assignedBrokerUrl to CloseProducerCmd to skip lookups upon producer reconnections during unloading [pulsar]

2023-10-20 Thread via GitHub
heesung-sn opened a new pull request, #21408: URL: https://github.com/apache/pulsar/pull/21408 PIP: #20748 ### Motivation Please refer to the pip https://github.com/apache/pulsar/pull/20748 There will be a separate PR for the similar c

[PR] [fix][broker] Allow broker deployment in heterogeneous hw config cluster without restricting nic speed detection [pulsar]

2023-10-20 Thread via GitHub
rdhabalia opened a new pull request, #21409: URL: https://github.com/apache/pulsar/pull/21409 ### Motivation This PR #14648 is incorrectly introduced, causing broker service unavailability while upgrading brokers in heterogeneous hardware config clusters. Sometime broker can’t find n

[pulsar-site] branch main updated: Docs sync done from apache/pulsar (#772f16c)

2023-10-20 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 1018e3e12480 Docs sync done from apache/pulsar

Re: [I] topics.getPartitionedInternalStats should allow the returned data to not contain publishers or subscriptions information. [pulsar]

2023-10-20 Thread via GitHub
github-actions[bot] commented on issue #21200: URL: https://github.com/apache/pulsar/issues/21200#issuecomment-1773594925 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [I] [Doc] Kubernetes installation doc link broken [pulsar]

2023-10-20 Thread via GitHub
github-actions[bot] commented on issue #21195: URL: https://github.com/apache/pulsar/issues/21195#issuecomment-1773594982 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [I] pulsar-shell persistent modes [pulsar]

2023-10-20 Thread via GitHub
github-actions[bot] commented on issue #21194: URL: https://github.com/apache/pulsar/issues/21194#issuecomment-1773595009 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [I] [Bug] Deduplication and short alive producers make broker in high gc frequency state. [pulsar]

2023-10-20 Thread via GitHub
github-actions[bot] commented on issue #21192: URL: https://github.com/apache/pulsar/issues/21192#issuecomment-1773595039 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [I] [Bug] The global topic policy config override the local topic policy config [pulsar]

2023-10-20 Thread via GitHub
github-actions[bot] commented on issue #21202: URL: https://github.com/apache/pulsar/issues/21202#issuecomment-1773594901 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [I] [Bug] about metrics bug [pulsar]

2023-10-20 Thread via GitHub
github-actions[bot] commented on issue #21196: URL: https://github.com/apache/pulsar/issues/21196#issuecomment-1773594946 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [I] Pause countdown timer of delayed message or change it's delayed time. [pulsar]

2023-10-20 Thread via GitHub
github-actions[bot] commented on issue #21173: URL: https://github.com/apache/pulsar/issues/21173#issuecomment-1773595086 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [I] [Bug] Topic level geo configure, the partitioned topics can not auto created on remote cluster. [pulsar]

2023-10-20 Thread via GitHub
github-actions[bot] commented on issue #21153: URL: https://github.com/apache/pulsar/issues/21153#issuecomment-1773595128 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [I] [Bug] After enabling replication, the number of topic partitions cannot be modified [pulsar]

2023-10-20 Thread via GitHub
github-actions[bot] commented on issue #21049: URL: https://github.com/apache/pulsar/issues/21049#issuecomment-1773595260 The issue had no activity for 30 days, mark with Stale label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[PR] [improve][ci] Schedule daily Pulsar CI build with Java 21 [pulsar]

2023-10-20 Thread via GitHub
lhotari opened a new pull request, #21410: URL: https://github.com/apache/pulsar/pull/21410 ### Motivation Run a scheduled daily Java 21 CI build to ensure that Java 21 support doesn't break in master branch. ### Modifications - add new scheduled build to pulsar-ci.yaml