[PR] [fix][tiered-storage] Don't cleanup data when offload met MetaStore exception [pulsar]

2023-12-06 Thread via GitHub
zymap opened a new pull request, #21686: URL: https://github.com/apache/pulsar/pull/21686 ### Motivation #17915 changes the fix #17512 which lead the offload data is deleted when metadata store exception happened. Then the ledger can not be read. The logs shows

Re: [I] [Bug] all broker FullGC and shutdown when a large number of producers concurrently update schema [pulsar]

2023-12-06 Thread via GitHub
keyboardbobo commented on issue #21672: URL: https://github.com/apache/pulsar/issues/21672#issuecomment-1844817305 @Technoboy- I found that this problem has been indirectly solved by this PR, although not the same problem : https://github.com/apache/pulsar/pull/17283 Close the ledger '`

Re: [PR] [fix][broker] Key-shared subscription must follow consumer redelivery as per shared sub semantic [pulsar]

2023-12-06 Thread via GitHub
rdhabalia commented on PR #21657: URL: https://github.com/apache/pulsar/pull/21657#issuecomment-1844803489 can we remove the blocker if there is no concern about the PR and can we merge it as it's really needed for various production systems. -- This is an automated message from the Apach

Re: [I] Expose Error for user [pulsar-client-go]

2023-12-06 Thread via GitHub
Gleiphir2769 commented on issue #1142: URL: https://github.com/apache/pulsar-client-go/issues/1142#issuecomment-1844783755 > Expose errors, and let users be able to use error. +1. I think at least it should allow users to use the std library to compare errors (errors.Is/As). -- This i

[I] The dependencies of some of the beans in the application context form a cycle [pulsar-manager]

2023-12-06 Thread via GitHub
scmod opened a new issue, #542: URL: https://github.com/apache/pulsar-manager/issues/542 packaged from master branch start failed with an error ``` *** APPLICATION FAILED TO START *** Description: The dependencies of so

Re: [PR] [fix][broker] Key-shared subscription must follow consumer redelivery as per shared sub semantic [pulsar]

2023-12-06 Thread via GitHub
rdhabalia commented on PR #21657: URL: https://github.com/apache/pulsar/pull/21657#issuecomment-1844738249 @codelipenghui simply adding removed consuner's unack messages into redelivery/replay list will not work because there are scenarios where key-shared dispatcher adds additionally f

Re: [I] schema copy in geo relicator [pulsar]

2023-12-06 Thread via GitHub
qiaofazhan closed issue #20502: schema copy in geo relicator URL: https://github.com/apache/pulsar/issues/20502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [improve][txn] Add command to abort transaction [pulsar]

2023-12-06 Thread via GitHub
liangyepianzhou commented on PR #21630: URL: https://github.com/apache/pulsar/pull/21630#issuecomment-1844730126 @hr I think you are better to write a proposal or send a email to discuss when you are trying to introduce a new API. -- This is an automated message from the Apache Git Se

Re: [I] Expose Error for user [pulsar-client-go]

2023-12-06 Thread via GitHub
tisonkun commented on issue #1142: URL: https://github.com/apache/pulsar-client-go/issues/1142#issuecomment-1844678398 Thanks for reporting this case @WoWsj! I agree that currently almost all errors pulsar-client-go returns are opaque and we may expose the error in the public API or

[I] [Doc] pulsar v3.0.2 lacks release notes [pulsar]

2023-12-06 Thread via GitHub
StevenLuMT opened a new issue, #21685: URL: https://github.com/apache/pulsar/issues/21685 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### What issue do you find in Pulsar docs? @poorbar

Re: [PR] [fix][broker] Key-shared subscription must follow consumer redelivery as per shared sub semantic [pulsar]

2023-12-06 Thread via GitHub
codelipenghui commented on PR #21657: URL: https://github.com/apache/pulsar/pull/21657#issuecomment-181110 Hi @rdhabalia, I can confirm this is an issue that we need to fix it. I tried on my laptop to find a simpler solution for this issue. The main idea of this solution

[PR] [fix] [broker] network package lost if enable haProxyProtocolEnabled [pulsar]

2023-12-06 Thread via GitHub
poorbarcode opened a new pull request, #21684: URL: https://github.com/apache/pulsar/pull/21684 Fixes #21557 ### Motivation There is a network package loss issue after enabling `haProxyProtocolEnabled`, which leads the error `Checksum failed on the broker` and `Adjusted frame

Re: [PR] fix: update ci timeout to 50m [pulsar-client-go]

2023-12-06 Thread via GitHub
gunli closed pull request #1140: fix: update ci timeout to 50m URL: https://github.com/apache/pulsar-client-go/pull/1140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] fix: update ci timeout to 50m [pulsar-client-go]

2023-12-06 Thread via GitHub
gunli commented on PR #1140: URL: https://github.com/apache/pulsar-client-go/pull/1140#issuecomment-1844324172 > > But it fails frequently, even if I run it on my local host. > > What is the cause of the failure? Do you have any link to your CI failure? Maybe it is something to

Re: [PR] [fix][broker] Automatically create topic for remote cluster in geo [pulsar]

2023-12-06 Thread via GitHub
nodece commented on PR #21679: URL: https://github.com/apache/pulsar/pull/21679#issuecomment-1844323597 Thank @liudezhi2098 for your suggest, the `GeoReplicationTest` can cover these changes, including persistent and non-persistent topics, but it cannot verify your issue because there is on

Re: [PR] [fix][broker] Automatically create topic for remote cluster in geo [pulsar]

2023-12-06 Thread via GitHub
nodece commented on PR #21679: URL: https://github.com/apache/pulsar/pull/21679#issuecomment-1844282778 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [fix][broker] Fix multiple race conditions in topic unloading and loading [pulsar]

2023-12-06 Thread via GitHub
graysonzeng commented on PR #20540: URL: https://github.com/apache/pulsar/pull/20540#issuecomment-1844281116 Thanks for the fix, I tried using this PR but still encountered this problem on rolling restart bookies and was unable to consume until I restarted all the broker. I will try to trou

Re: [PR] [broker][improve] Pulsar Rate Limiting Refactoring changes (PIP-322) [pulsar]

2023-12-06 Thread via GitHub
lhotari commented on PR #21681: URL: https://github.com/apache/pulsar/pull/21681#issuecomment-1844141012 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[PR] [fix][broker] Allow namespace roles consume any subs [pulsar]

2023-12-06 Thread via GitHub
wenbingshen opened a new pull request, #21683: URL: https://github.com/apache/pulsar/pull/21683 ### Motivation When I have an auth role user in a namespace and give it the AuthAction.CONSUME permission, I have read-only permissions on all topics under the namespace, but when I subscr

Re: [PR] [improve][io] Make connectors load sensitive fields from secrets [pulsar]

2023-12-06 Thread via GitHub
shibd commented on code in PR #21675: URL: https://github.com/apache/pulsar/pull/21675#discussion_r1418227509 ## pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaSourceConfig.java: ## @@ -152,8 +153,13 @@ public static KafkaSourceConfig load(String yamlFile) throws

Re: [PR] [fix][broker] Automatically create partitioned topic for remote cluster in geo [pulsar]

2023-12-06 Thread via GitHub
liudezhi2098 commented on PR #21679: URL: https://github.com/apache/pulsar/pull/21679#issuecomment-1844109467 Test cases can be added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [improve][io] Make connectors load sensitive fields from secrets [pulsar]

2023-12-06 Thread via GitHub
RobertIndie commented on code in PR #21675: URL: https://github.com/apache/pulsar/pull/21675#discussion_r1418215427 ## pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaSourceConfig.java: ## @@ -152,8 +153,13 @@ public static KafkaSourceConfig load(String yamlFile)

Re: [PR] [Fix][Producer]: handle TopicNotFound/TopicTerminated/ProducerBlockedQuotaExceededException/ProducerFenced when reconnecting [pulsar-client-go]

2023-12-06 Thread via GitHub
gunli commented on PR #1134: URL: https://github.com/apache/pulsar-client-go/pull/1134#issuecomment-1844084073 > There is a data race issue in the CI: https://github.com/apache/pulsar-client-go/actions/runs/6978661724/job/19165650715?pr=1134#step:5:9630 > > @gunli Could you take a lo

svn commit: r65867 - in /dev/pulsar/pulsar-dotpulsar-3.1.1-rc.1: pulsar-dotpulsar-3.1.1.tar.gz pulsar-dotpulsar-3.1.1.tar.gz.asc pulsar-dotpulsar-3.1.1.tar.gz.sha512

2023-12-06 Thread tison
Author: tison Date: Thu Dec 7 02:11:44 2023 New Revision: 65867 Log: Staging artifacts and signature for DotPulsar 3.1.1-rc.1 Added: dev/pulsar/pulsar-dotpulsar-3.1.1-rc.1/pulsar-dotpulsar-3.1.1.tar.gz (with props) dev/pulsar/pulsar-dotpulsar-3.1.1-rc.1/pulsar-dotpulsar-3.1.1.tar.gz.a

(pulsar-dotpulsar) branch master updated: docs: simplify svn command

2023-12-06 Thread tison
This is an automated email from the ASF dual-hosted git repository. tison pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git The following commit(s) were added to refs/heads/master by this push: new 49ddf32 docs: simplify svn command 49d

svn commit: r65866 - /dev/pulsar/pulsar-dotpulsar-3.1.1-rc.1/

2023-12-06 Thread tison
Author: tison Date: Thu Dec 7 02:09:08 2023 New Revision: 65866 Log: Create DotPulsar pre-release dir Added: dev/pulsar/pulsar-dotpulsar-3.1.1-rc.1/

Re: [PR] [improve][io] Make connectors load sensitive fields from secrets [pulsar]

2023-12-06 Thread via GitHub
shibd closed pull request #21675: [improve][io] Make connectors load sensitive fields from secrets URL: https://github.com/apache/pulsar/pull/21675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] [improve][sec] Add group pulsar and add user pulsar to it instead of root [pulsar]

2023-12-06 Thread via GitHub
codecov-commenter commented on PR #21084: URL: https://github.com/apache/pulsar/pull/21084#issuecomment-1843995912 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] [improve][sec] Add group pulsar and add user pulsar to it instead of root [pulsar]

2023-12-06 Thread via GitHub
zymap commented on PR #21084: URL: https://github.com/apache/pulsar/pull/21084#issuecomment-1843991639 Failed to build the image: ``` Failed to execute goal io.fabric8:docker-maven-plugin:0.43.3:build (default) on project latest-version-image: Unable to build image [apachepulsar/pulsa

(pulsar-site) branch main updated: Docs sync done from apache/pulsar (#ab77ca2)

2023-12-06 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new abff422df68e Docs sync done from apache/pulsar

Re: [PR] [improve][sec] Add group pulsar and add user pulsar to it instead of root [pulsar]

2023-12-06 Thread via GitHub
zymap closed pull request #21084: [improve][sec] Add group pulsar and add user pulsar to it instead of root URL: https://github.com/apache/pulsar/pull/21084 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [improve][build] Add a default username in the image [pulsar]

2023-12-06 Thread via GitHub
zymap closed pull request #21678: [improve][build] Add a default username in the image URL: https://github.com/apache/pulsar/pull/21678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [improve][build] Add a default username in the image [pulsar]

2023-12-06 Thread via GitHub
zymap commented on PR #21678: URL: https://github.com/apache/pulsar/pull/21678#issuecomment-1843936753 Duplicate with #21084. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [fix][broker] Key-shared subscription must follow consumer redelivery as per shared sub semantic [pulsar]

2023-12-06 Thread via GitHub
codecov-commenter commented on PR #21657: URL: https://github.com/apache/pulsar/pull/21657#issuecomment-1843854652 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21657?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] [fix][broker] Key-shared subscription must follow consumer redelivery as per shared sub semantic [pulsar]

2023-12-06 Thread via GitHub
rdhabalia commented on code in PR #21657: URL: https://github.com/apache/pulsar/pull/21657#discussion_r1418087933 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java: ## @@ -355,25 +355,8 @@ private int g

Re: [PR] [fix][broker] Key-shared subscription must follow consumer redelivery as per shared sub semantic [pulsar]

2023-12-06 Thread via GitHub
rdhabalia commented on code in PR #21657: URL: https://github.com/apache/pulsar/pull/21657#discussion_r1418087933 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java: ## @@ -355,25 +355,8 @@ private int g

Re: [I] Replace the Boost dependency with Boost.Asio or Asio [pulsar-client-cpp]

2023-12-06 Thread via GitHub
oversearch commented on issue #367: URL: https://github.com/apache/pulsar-client-cpp/issues/367#issuecomment-1843826324 I personally don't mind a boost dependency on the project. It has a lot of great stuff that you wouldn't want to re-implement yourself, and a large number of C++ project

Re: [PR] [improve][broker] PIP-307: Skip consumer topic lookups during topic load balancing [pulsar]

2023-12-06 Thread via GitHub
heesung-sn commented on code in PR #21682: URL: https://github.com/apache/pulsar/pull/21682#discussion_r1418044228 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java: ## @@ -542,6 +544,10 @@ public SubType getTyp

[PR] [improve][broker] PIP-307: Skip consumer topic lookups during topic load balancing [pulsar]

2023-12-06 Thread via GitHub
dragosvictor opened a new pull request, #21682: URL: https://github.com/apache/pulsar/pull/21682 PIP: [PIP-307](https://github.com/apache/pulsar/pull/20748) ### Motivation Topic unloading can be sped up, as described by PIP-307, by forwarding the target broker lookup da

Re: [PR] [improve][pip] PIP-320: OpenTelemetry Scaffolding [pulsar]

2023-12-06 Thread via GitHub
visortelle commented on PR #21635: URL: https://github.com/apache/pulsar/pull/21635#issuecomment-1843331926 I left some comments. Asked questions I was interested in during the reading. Don't consider it a review. I’m not deep enough into the metrics/OTel topic to leave comments that may

Re: [PR] [improve][pip] PIP-320: OpenTelemetry Scaffolding [pulsar]

2023-12-06 Thread via GitHub
visortelle commented on code in PR #21635: URL: https://github.com/apache/pulsar/pull/21635#discussion_r1417599918 ## pip/pip-320.md: ## @@ -0,0 +1,241 @@ +# PIP-320 OpenTelemetry Scaffolding + +# Background knowledge + +## PIP-264 - parent PIP titled "Enhanced OTel-based metri

Re: [PR] [improve][pip] PIP-320: OpenTelemetry Scaffolding [pulsar]

2023-12-06 Thread via GitHub
visortelle commented on code in PR #21635: URL: https://github.com/apache/pulsar/pull/21635#discussion_r1417655529 ## pip/pip-320.md: ## @@ -0,0 +1,241 @@ +# PIP-320 OpenTelemetry Scaffolding + +# Background knowledge + +## PIP-264 - parent PIP titled "Enhanced OTel-based metri

Re: [PR] [improve][pip] PIP-320: OpenTelemetry Scaffolding [pulsar]

2023-12-06 Thread via GitHub
visortelle commented on code in PR #21635: URL: https://github.com/apache/pulsar/pull/21635#discussion_r1417655529 ## pip/pip-320.md: ## @@ -0,0 +1,241 @@ +# PIP-320 OpenTelemetry Scaffolding + +# Background knowledge + +## PIP-264 - parent PIP titled "Enhanced OTel-based metri

[PR] [broker][improve] Pulsar Rate Limiting Refactoring changes (PIP-322) [pulsar]

2023-12-06 Thread via GitHub
lhotari opened a new pull request, #21681: URL: https://github.com/apache/pulsar/pull/21681 PIP: #21680 ### Motivation See PIP-322 for details. ### Modifications See PIP-322 for details. ### Documentation - [ ] `doc` - [ ] `doc-required`

Re: [PR] [improve][pip] PIP-320: OpenTelemetry Scaffolding [pulsar]

2023-12-06 Thread via GitHub
visortelle commented on code in PR #21635: URL: https://github.com/apache/pulsar/pull/21635#discussion_r1417648439 ## pip/pip-320.md: ## @@ -0,0 +1,241 @@ +# PIP-320 OpenTelemetry Scaffolding + +# Background knowledge + +## PIP-264 - parent PIP titled "Enhanced OTel-based metri

Re: [PR] [improve][pip] PIP-320: OpenTelemetry Scaffolding [pulsar]

2023-12-06 Thread via GitHub
visortelle commented on code in PR #21635: URL: https://github.com/apache/pulsar/pull/21635#discussion_r1417648439 ## pip/pip-320.md: ## @@ -0,0 +1,241 @@ +# PIP-320 OpenTelemetry Scaffolding + +# Background knowledge + +## PIP-264 - parent PIP titled "Enhanced OTel-based metri

Re: [PR] [improve][pip] PIP-320: OpenTelemetry Scaffolding [pulsar]

2023-12-06 Thread via GitHub
visortelle commented on code in PR #21635: URL: https://github.com/apache/pulsar/pull/21635#discussion_r1417648439 ## pip/pip-320.md: ## @@ -0,0 +1,241 @@ +# PIP-320 OpenTelemetry Scaffolding + +# Background knowledge + +## PIP-264 - parent PIP titled "Enhanced OTel-based metri

[PR] [improve][pip] PIP-322: Pulsar Rate Limiting Refactoring [pulsar]

2023-12-06 Thread via GitHub
lhotari opened a new pull request, #21680: URL: https://github.com/apache/pulsar/pull/21680 ### Motivation This contains PIP-322: Pulsar Rate Limiting Refactoring. Check the pip-322.md document for details. ### Does this pull request potentially affect one of the following part

Re: [PR] [improve][pip] PIP-320: OpenTelemetry Scaffolding [pulsar]

2023-12-06 Thread via GitHub
visortelle commented on code in PR #21635: URL: https://github.com/apache/pulsar/pull/21635#discussion_r1417609104 ## pip/pip-320.md: ## @@ -0,0 +1,241 @@ +# PIP-320 OpenTelemetry Scaffolding + +# Background knowledge + +## PIP-264 - parent PIP titled "Enhanced OTel-based metri

Re: [PR] [improve][pip] PIP-320: OpenTelemetry Scaffolding [pulsar]

2023-12-06 Thread via GitHub
visortelle commented on code in PR #21635: URL: https://github.com/apache/pulsar/pull/21635#discussion_r1417609104 ## pip/pip-320.md: ## @@ -0,0 +1,241 @@ +# PIP-320 OpenTelemetry Scaffolding + +# Background knowledge + +## PIP-264 - parent PIP titled "Enhanced OTel-based metri

Re: [PR] [improve][pip] PIP-320: OpenTelemetry Scaffolding [pulsar]

2023-12-06 Thread via GitHub
visortelle commented on code in PR #21635: URL: https://github.com/apache/pulsar/pull/21635#discussion_r1417599918 ## pip/pip-320.md: ## @@ -0,0 +1,241 @@ +# PIP-320 OpenTelemetry Scaffolding + +# Background knowledge + +## PIP-264 - parent PIP titled "Enhanced OTel-based metri

Re: [PR] [improve][pip] PIP-320: OpenTelemetry Scaffolding [pulsar]

2023-12-06 Thread via GitHub
visortelle commented on code in PR #21635: URL: https://github.com/apache/pulsar/pull/21635#discussion_r1417599918 ## pip/pip-320.md: ## @@ -0,0 +1,241 @@ +# PIP-320 OpenTelemetry Scaffolding + +# Background knowledge + +## PIP-264 - parent PIP titled "Enhanced OTel-based metri

Re: [PR] [improve][pip] PIP-320: OpenTelemetry Scaffolding [pulsar]

2023-12-06 Thread via GitHub
visortelle commented on code in PR #21635: URL: https://github.com/apache/pulsar/pull/21635#discussion_r1417591010 ## pip/pip-320.md: ## @@ -0,0 +1,241 @@ +# PIP-320 OpenTelemetry Scaffolding + +# Background knowledge + +## PIP-264 - parent PIP titled "Enhanced OTel-based metri

Re: [PR] [improve][pip] PIP-320: OpenTelemetry Scaffolding [pulsar]

2023-12-06 Thread via GitHub
loicberthou commented on code in PR #21635: URL: https://github.com/apache/pulsar/pull/21635#discussion_r1417540945 ## pip/pip-320.md: ## @@ -0,0 +1,241 @@ +# PIP-320 OpenTelemetry Scaffolding + +# Background knowledge + +## PIP-264 - parent PIP titled "Enhanced OTel-based metr

Re: [PR] fix: channel deadlock in regexp consumer [pulsar-client-go]

2023-12-06 Thread via GitHub
goncalo-rodrigues commented on code in PR #1141: URL: https://github.com/apache/pulsar-client-go/pull/1141#discussion_r1417395627 ## pulsar/consumer_regex.go: ## @@ -320,6 +319,25 @@ func (c *regexConsumer) closed() bool { } func (c *regexConsumer) monitor() { + defer

Re: [I] [Bug] After upgrading to the 3.0.1, the topic was deleted! [pulsar]

2023-12-06 Thread via GitHub
crossoverJie commented on issue #21653: URL: https://github.com/apache/pulsar/issues/21653#issuecomment-1842962452 Reproduce step: ```java @Test public void testCreateTopicAndUpdatePolicyConcurrent() throws Exception { final int topicNum = 100; f

Re: [PR] fix: channel deadlock in regexp consumer [pulsar-client-go]

2023-12-06 Thread via GitHub
RobertIndie commented on code in PR #1141: URL: https://github.com/apache/pulsar-client-go/pull/1141#discussion_r1417231033 ## pulsar/consumer_regex.go: ## @@ -320,6 +319,25 @@ func (c *regexConsumer) closed() bool { } func (c *regexConsumer) monitor() { + defer close(

Re: [PR] [Fix][Producer]: handle TopicNotFound/TopicTerminated/ProducerBlockedQuotaExceededException/ProducerFenced when reconnecting [pulsar-client-go]

2023-12-06 Thread via GitHub
RobertIndie commented on PR #1134: URL: https://github.com/apache/pulsar-client-go/pull/1134#issuecomment-1842793235 There is a data race issue in the CI: https://github.com/apache/pulsar-client-go/actions/runs/6978661724/job/19165650715?pr=1134#step:5:9630 @gunli Could you take a lo

Re: [PR] fix: channel deadlock in regexp consumer [pulsar-client-go]

2023-12-06 Thread via GitHub
goncalo-rodrigues commented on code in PR #1141: URL: https://github.com/apache/pulsar-client-go/pull/1141#discussion_r1417209866 ## pulsar/consumer_regex.go: ## @@ -320,6 +319,25 @@ func (c *regexConsumer) closed() bool { } func (c *regexConsumer) monitor() { + defer

Re: [PR] fix: update ci timeout to 50m [pulsar-client-go]

2023-12-06 Thread via GitHub
RobertIndie commented on PR #1140: URL: https://github.com/apache/pulsar-client-go/pull/1140#issuecomment-1842774672 > But it fails frequently, even if I run it on my local host. What is the cause of the failure? Do you have any link to your CI failure? -- This is an automated mess

Re: [PR] fix: channel deadlock in regexp consumer [pulsar-client-go]

2023-12-06 Thread via GitHub
RobertIndie commented on code in PR #1141: URL: https://github.com/apache/pulsar-client-go/pull/1141#discussion_r1417203425 ## pulsar/consumer_regex.go: ## @@ -320,6 +319,25 @@ func (c *regexConsumer) closed() bool { } func (c *regexConsumer) monitor() { + defer close(

[I] [Feature Request] Support executing callbacks concurrently [pulsar-client-cpp]

2023-12-06 Thread via GitHub
BewareMyPower opened a new issue, #368: URL: https://github.com/apache/pulsar-client-cpp/issues/368 ```c++ #include #include #include #include "lib/LogUtils.h" DECLARE_LOG_OBJECT() using namespace pulsar; int main(int argc, char *argv[]) { Client

Re: [PR] [fix][broker] Record GeoPersistentReplicator.msgOut before producer#sendAsync [pulsar]

2023-12-06 Thread via GitHub
nodece commented on PR #21673: URL: https://github.com/apache/pulsar/pull/21673#issuecomment-1842687439 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[PR] [fix][broker] Automatically create partitioned topic for remote cluster in geo [pulsar]

2023-12-06 Thread via GitHub
nodece opened a new pull request, #21679: URL: https://github.com/apache/pulsar/pull/21679 Fixes https://github.com/apache/pulsar/issues/21153 ### Motivation Enable the geo-replication only on the topic level to replicate the partitioned topic, if the topic was not created in t

Re: [I] [Bug] Failed to verify checksum [pulsar]

2023-12-06 Thread via GitHub
poorbarcode commented on issue #21557: URL: https://github.com/apache/pulsar/issues/21557#issuecomment-1842617019 @zifengmo Are you using `HaProxy` or other proxies? One user hit the same problem caused by using `HaProxy`. see the [doc](https://pulsar.apache.org/docs/3.1.x/concepts

Re: [I] [Bug] Wrong rows order at the Release notes table [pulsar]

2023-12-06 Thread via GitHub
poorbarcode closed issue #21677: [Bug] Wrong rows order at the Release notes table URL: https://github.com/apache/pulsar/issues/21677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

(pulsar-site) branch main updated: FIx the release tables for 3.0.2 (#746)

2023-12-06 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 010e4ef03c4b FIx the release tables for 3.0.2 (

Re: [PR] Fix the release tables for 3.0.2 [pulsar-site]

2023-12-06 Thread via GitHub
poorbarcode merged PR #746: URL: https://github.com/apache/pulsar-site/pull/746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@puls

(pulsar-dotpulsar) tag 3.1.1-rc.1 created (now f35e682)

2023-12-06 Thread blankensteiner
This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a change to tag 3.1.1-rc.1 in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git at f35e682 (commit) No new revisions were added by this update.

(pulsar-dotpulsar) branch master updated: Make ready for release 3.1.1-rc.1 Fixed a bug where disposing a disconnected consumer, reader or producer would cause a hang. Updated NuGet packages

2023-12-06 Thread blankensteiner
This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git The following commit(s) were added to refs/heads/master by this push: new f35e682 Make ready for releas

[PR] [improve][build] Add a default username in the image [pulsar]

2023-12-06 Thread via GitHub
zymap opened a new pull request, #21678: URL: https://github.com/apache/pulsar/pull/21678 ### Motivation Add a default username in the pulsar image. When using HDFS offloader, it requires a username. ### Modifications ### Verifying this change - [ ] Make s

Re: [PR] [improve][build] Add a default username in the image [pulsar]

2023-12-06 Thread via GitHub
github-actions[bot] commented on PR #21678: URL: https://github.com/apache/pulsar/pull/21678#issuecomment-1842550561 @zymap Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-

[PR] FIx the release tables for 3.0.2 [pulsar-site]

2023-12-06 Thread via GitHub
RobertIndie opened a new pull request, #746: URL: https://github.com/apache/pulsar-site/pull/746 This PR fixes https://github.com/apache/pulsar/issues/21677 https://github.com/apache/pulsar-site/assets/16974619/a548a810-86b5-471a-9844-3e8577c3845d";>

[I] [Bug] Wrong rows order at the Release notes table [pulsar]

2023-12-06 Thread via GitHub
visortelle opened a new issue, #21677: URL: https://github.com/apache/pulsar/issues/21677 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version - ### Minimal reproduce step

Re: [PR] [improve][broker] Support not retaining null-key message during topic compaction (#21578) [pulsar]

2023-12-06 Thread via GitHub
RobertIndie commented on PR #21662: URL: https://github.com/apache/pulsar/pull/21662#issuecomment-1842418605 What is the motivation for cherry-picking this to branch-3.0? This changes the default configuration value and should be considered an important notice. We shouldn't bring this cha

Re: [PR] [improve] [broker] Add logs for the checksum comparation [pulsar]

2023-12-06 Thread via GitHub
poorbarcode commented on PR #21676: URL: https://github.com/apache/pulsar/pull/21676#issuecomment-1842404758 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

(pulsar) branch master updated: [fix][cli] Add `get-cluster-migration` cmd (#21473)

2023-12-06 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new ab77ca2d380 [fix][cli] Add `get-cluster-migra

Re: [PR] [fix][cli] Add `get-cluster-migration` cmd [pulsar]

2023-12-06 Thread via GitHub
Technoboy- merged PR #21473: URL: https://github.com/apache/pulsar/pull/21473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar

[PR] [DON'T MERGE] Upgrade the C++ client to 3.4.2 [pulsar-client-python]

2023-12-06 Thread via GitHub
BewareMyPower opened a new pull request, #170: URL: https://github.com/apache/pulsar-client-python/pull/170 Test 3.4.2 candidate 1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com