[PR] [improve][client] PIP-313 Support force unsubscribe using consumer api [pulsar]

2023-12-07 Thread via GitHub
rdhabalia opened a new pull request, #21687: URL: https://github.com/apache/pulsar/pull/21687 PIP: #21452 ### Motivation As discussed in Issue: https://github.com/apache/pulsar/issues/21451 Apache Pulsar provides a messaging queue using a Shared subscription to proc

Re: [PR] [fix][offload] Don't cleanup data when offload met MetaStore exception [pulsar]

2023-12-07 Thread via GitHub
zymap commented on PR #21686: URL: https://github.com/apache/pulsar/pull/21686#issuecomment-1844892858 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [fix][broker] Key-shared subscription must follow consumer redelivery as per shared sub semantic [pulsar]

2023-12-07 Thread via GitHub
codelipenghui commented on code in PR #21657: URL: https://github.com/apache/pulsar/pull/21657#discussion_r1418634507 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java: ## @@ -388,6 +376,17 @@ private i

Re: [PR] [improve][sec] Add group pulsar and add user pulsar to it instead of root [pulsar]

2023-12-07 Thread via GitHub
zymap merged PR #21084: URL: https://github.com/apache/pulsar/pull/21084 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apac

(pulsar) branch master updated: [improve][sec] Add group pulsar and add user pulsar to it instead of root (#21084)

2023-12-07 Thread yong
This is an automated email from the ASF dual-hosted git repository. yong pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new f25b082125e [improve][sec] Add group pulsar and ad

Re: [PR] [improve][broker] PIP-307: Skip consumer topic lookups during topic load balancing [pulsar]

2023-12-07 Thread via GitHub
dragosvictor commented on code in PR #21682: URL: https://github.com/apache/pulsar/pull/21682#discussion_r1418641046 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImplTest.java: ## @@ -410,111 +426,240 @@ public boolean test(

Re: [PR] [fix][broker] Key-shared subscription must follow consumer redelivery as per shared sub semantic [pulsar]

2023-12-07 Thread via GitHub
codelipenghui commented on code in PR #21657: URL: https://github.com/apache/pulsar/pull/21657#discussion_r1418641605 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java: ## @@ -269,7 +269,12 @@ protected

Re: [PR] [improve][broker] PIP-307: Skip consumer topic lookups during topic load balancing [pulsar]

2023-12-07 Thread via GitHub
dragosvictor commented on code in PR #21682: URL: https://github.com/apache/pulsar/pull/21682#discussion_r1418641716 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -1509,14 +1508,15 @@ public CompletableFuture close(

Re: [PR] [fix][broker] Key-shared subscription must follow consumer redelivery as per shared sub semantic [pulsar]

2023-12-07 Thread via GitHub
codelipenghui commented on code in PR #21657: URL: https://github.com/apache/pulsar/pull/21657#discussion_r1418641605 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java: ## @@ -269,7 +269,12 @@ protected

[I] [Bug] Can not offload to HDFS filesystem ,the error is java.lang.NoSuchMethodError: 'java.lang.String org.apache.pulsar.common.naming.TopicName.fromPersistenceNamingEncoding(java.lang.String)' [pu

2023-12-07 Thread via GitHub
zhaoyajun2009 opened a new issue, #21688: URL: https://github.com/apache/pulsar/issues/21688 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version Can not offloading the data to HDFS.

Re: [PR] [fix][offload] Don't cleanup data when offload met MetaStore exception [pulsar]

2023-12-07 Thread via GitHub
gaoran10 commented on code in PR #21686: URL: https://github.com/apache/pulsar/pull/21686#discussion_r1418674208 ## managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerTest.java: ## @@ -4152,4 +4156,53 @@ private long calculatePendingTaskCount(OrderedSch

Re: [PR] [fix][offload] Don't cleanup data when offload met MetaStore exception [pulsar]

2023-12-07 Thread via GitHub
gaoran10 commented on code in PR #21686: URL: https://github.com/apache/pulsar/pull/21686#discussion_r1418674208 ## managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerTest.java: ## @@ -4152,4 +4156,53 @@ private long calculatePendingTaskCount(OrderedSch

Re: [PR] [fix][offload] Don't cleanup data when offload met MetaStore exception [pulsar]

2023-12-07 Thread via GitHub
gaoran10 commented on code in PR #21686: URL: https://github.com/apache/pulsar/pull/21686#discussion_r1418679536 ## managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerTest.java: ## @@ -4152,4 +4156,53 @@ private long calculatePendingTaskCount(OrderedSch

Re: [PR] [fix] [broker] network package lost if enable haProxyProtocolEnabled [pulsar]

2023-12-07 Thread via GitHub
coderzc commented on code in PR #21684: URL: https://github.com/apache/pulsar/pull/21684#discussion_r1418734575 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/OptionalProxyProtocolDecoder.java: ## @@ -19,35 +19,67 @@ package org.apache.pulsar.common.protocol;

Re: [I] Expose Error for user [pulsar-client-go]

2023-12-07 Thread via GitHub
RobertIndie commented on issue #1142: URL: https://github.com/apache/pulsar-client-go/issues/1142#issuecomment-1845090349 Thanks for reporting it. I'm +1 for this. Just to make sure we need to handle the backward compatibility carefully. -- This is an automated message from the Ap

Re: [I] Expose Error for user [pulsar-client-go]

2023-12-07 Thread via GitHub
tisonkun commented on issue #1142: URL: https://github.com/apache/pulsar-client-go/issues/1142#issuecomment-1845114696 > compare errors (errors.Is/As) A rough approach is sorting out all the errors we return now and move them to a public package (`pulsar/error.go`) and gradually expo

Re: [PR] [fix][offload] Don't cleanup data when offload met MetaStore exception [pulsar]

2023-12-07 Thread via GitHub
zymap commented on code in PR #21686: URL: https://github.com/apache/pulsar/pull/21686#discussion_r1418792990 ## managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerTest.java: ## @@ -4152,4 +4156,53 @@ private long calculatePendingTaskCount(OrderedSchedu

Re: [PR] [fix] [broker] network package lost if enable haProxyProtocolEnabled [pulsar]

2023-12-07 Thread via GitHub
coderzc commented on code in PR #21684: URL: https://github.com/apache/pulsar/pull/21684#discussion_r1418798687 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/OptionalProxyProtocolDecoder.java: ## @@ -19,35 +19,67 @@ package org.apache.pulsar.common.protocol;

Re: [PR] [fix] [broker] network package lost if enable haProxyProtocolEnabled [pulsar]

2023-12-07 Thread via GitHub
coderzc commented on code in PR #21684: URL: https://github.com/apache/pulsar/pull/21684#discussion_r1418798687 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/OptionalProxyProtocolDecoder.java: ## @@ -19,35 +19,67 @@ package org.apache.pulsar.common.protocol;

Re: [PR] [fix][offload] Don't cleanup data when offload met MetaStore exception [pulsar]

2023-12-07 Thread via GitHub
zymap commented on code in PR #21686: URL: https://github.com/apache/pulsar/pull/21686#discussion_r1418810224 ## managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerTest.java: ## @@ -4152,4 +4156,53 @@ private long calculatePendingTaskCount(OrderedSchedu

Re: [PR] [fix] [broker] network package lost if enable haProxyProtocolEnabled [pulsar]

2023-12-07 Thread via GitHub
coderzc commented on code in PR #21684: URL: https://github.com/apache/pulsar/pull/21684#discussion_r1418798687 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/OptionalProxyProtocolDecoder.java: ## @@ -19,35 +19,67 @@ package org.apache.pulsar.common.protocol;

Re: [PR] [fix][offload] Don't cleanup data when offload met MetaStore exception [pulsar]

2023-12-07 Thread via GitHub
codecov-commenter commented on PR #21686: URL: https://github.com/apache/pulsar/pull/21686#issuecomment-1845181157 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21686?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] [fix] [broker] network package lost if enable haProxyProtocolEnabled [pulsar]

2023-12-07 Thread via GitHub
codelipenghui commented on code in PR #21684: URL: https://github.com/apache/pulsar/pull/21684#discussion_r1418819587 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/OptionalProxyProtocolDecoder.java: ## @@ -19,36 +19,61 @@ package org.apache.pulsar.common.prot

Re: [PR] [fix] [broker] network package lost if enable haProxyProtocolEnabled [pulsar]

2023-12-07 Thread via GitHub
Technoboy- commented on code in PR #21684: URL: https://github.com/apache/pulsar/pull/21684#discussion_r1418855601 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/OptionalProxyProtocolDecoder.java: ## @@ -19,36 +19,61 @@ package org.apache.pulsar.common.protoco

Re: [PR] [fix] [broker] network package lost if enable haProxyProtocolEnabled [pulsar]

2023-12-07 Thread via GitHub
poorbarcode commented on code in PR #21684: URL: https://github.com/apache/pulsar/pull/21684#discussion_r1418863294 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/OptionalProxyProtocolDecoder.java: ## @@ -19,36 +19,61 @@ package org.apache.pulsar.common.protoc

Re: [PR] [fix] [broker] network package lost if enable haProxyProtocolEnabled [pulsar]

2023-12-07 Thread via GitHub
poorbarcode commented on code in PR #21684: URL: https://github.com/apache/pulsar/pull/21684#discussion_r1418865258 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/OptionalProxyProtocolDecoder.java: ## @@ -19,36 +19,61 @@ package org.apache.pulsar.common.protoc

Re: [PR] [fix] [broker] network package lost if enable haProxyProtocolEnabled [pulsar]

2023-12-07 Thread via GitHub
poorbarcode commented on code in PR #21684: URL: https://github.com/apache/pulsar/pull/21684#discussion_r1418866629 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/OptionalProxyProtocolDecoder.java: ## @@ -19,35 +19,67 @@ package org.apache.pulsar.common.protoc

Re: [PR] [fix] [broker] network package lost if enable haProxyProtocolEnabled [pulsar]

2023-12-07 Thread via GitHub
poorbarcode commented on code in PR #21684: URL: https://github.com/apache/pulsar/pull/21684#discussion_r1418863294 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/OptionalProxyProtocolDecoder.java: ## @@ -19,36 +19,61 @@ package org.apache.pulsar.common.protoc

[PR] [branch-2.10][test] Remove non-existing and useless methods in tests [pulsar]

2023-12-07 Thread via GitHub
gaoran10 opened a new pull request, #21689: URL: https://github.com/apache/pulsar/pull/21689 ### Motivation There are some non-existing methods in branch-2.10, they are introduced by PRs from the latest version. ### Modifications Remove non-existing and useless methods i

Re: [PR] [branch-2.10][test] Remove non-existing and useless methods in tests [pulsar]

2023-12-07 Thread via GitHub
github-actions[bot] commented on PR #21689: URL: https://github.com/apache/pulsar/pull/21689#issuecomment-1845236277 @gaoran10 Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `d

Re: [PR] [fix] [broker] network package lost if enable haProxyProtocolEnabled [pulsar]

2023-12-07 Thread via GitHub
coderzc commented on code in PR #21684: URL: https://github.com/apache/pulsar/pull/21684#discussion_r1418889787 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/OptionalProxyProtocolDecoder.java: ## @@ -19,35 +19,67 @@ package org.apache.pulsar.common.protocol;

Re: [I] [Bug] Websocket connection closed [pulsar]

2023-12-07 Thread via GitHub
miton18 commented on issue #21628: URL: https://github.com/apache/pulsar/issues/21628#issuecomment-1845263476 Yes, the connection never succeed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [fix] [broker] network package lost if enable haProxyProtocolEnabled [pulsar]

2023-12-07 Thread via GitHub
coderzc commented on code in PR #21684: URL: https://github.com/apache/pulsar/pull/21684#discussion_r1418889787 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/OptionalProxyProtocolDecoder.java: ## @@ -19,35 +19,67 @@ package org.apache.pulsar.common.protocol;

Re: [PR] [branch-2.10][test] Remove non-existing and useless methods in tests [pulsar]

2023-12-07 Thread via GitHub
gaoran10 closed pull request #21689: [branch-2.10][test] Remove non-existing and useless methods in tests URL: https://github.com/apache/pulsar/pull/21689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] [fix] [broker] network package lost if enable haProxyProtocolEnabled [pulsar]

2023-12-07 Thread via GitHub
poorbarcode commented on code in PR #21684: URL: https://github.com/apache/pulsar/pull/21684#discussion_r1418977159 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/OptionalProxyProtocolDecoder.java: ## @@ -19,35 +19,67 @@ package org.apache.pulsar.common.protoc

[PR] [fix][broker] Fix typo in the config key [pulsar]

2023-12-07 Thread via GitHub
coderzc opened a new pull request, #21690: URL: https://github.com/apache/pulsar/pull/21690 Fixes #xyz Main Issue: #xyz PIP: #xyz ### Motivation There hasn't been a release since #21578 merged, so we can just fix it.

Re: [PR] [improve][broker][PIP-318] Support not retaining null-key message during topic compaction [pulsar]

2023-12-07 Thread via GitHub
coderzc commented on code in PR #21578: URL: https://github.com/apache/pulsar/pull/21578#discussion_r1418988388 ## conf/broker.conf: ## @@ -538,6 +538,9 @@ brokerServiceCompactionThresholdInBytes=0 # If the execution time of the compaction phase one loop exceeds this time, the

Re: [PR] [fix][broker] Fix typo in the config key [pulsar]

2023-12-07 Thread via GitHub
coderzc closed pull request #21690: [fix][broker] Fix typo in the config key URL: https://github.com/apache/pulsar/pull/21690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix] [broker] network package lost if enable haProxyProtocolEnabled [pulsar]

2023-12-07 Thread via GitHub
coderzc commented on code in PR #21684: URL: https://github.com/apache/pulsar/pull/21684#discussion_r1418999660 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/OptionalProxyProtocolDecoder.java: ## @@ -19,35 +19,67 @@ package org.apache.pulsar.common.protocol;

Re: [PR] [fix] [broker] network package lost if enable haProxyProtocolEnabled [pulsar]

2023-12-07 Thread via GitHub
codecov-commenter commented on PR #21684: URL: https://github.com/apache/pulsar/pull/21684#issuecomment-1845395950 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21684?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] [fix] [broker] network package lost if enable haProxyProtocolEnabled [pulsar]

2023-12-07 Thread via GitHub
Technoboy- commented on code in PR #21684: URL: https://github.com/apache/pulsar/pull/21684#discussion_r1419035617 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/OptionalProxyProtocolDecoder.java: ## @@ -19,36 +19,63 @@ package org.apache.pulsar.common.protoco

Re: [PR] [fix] [broker] network package lost if enable haProxyProtocolEnabled [pulsar]

2023-12-07 Thread via GitHub
poorbarcode commented on code in PR #21684: URL: https://github.com/apache/pulsar/pull/21684#discussion_r1419157675 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/OptionalProxyProtocolDecoder.java: ## @@ -19,36 +19,63 @@ package org.apache.pulsar.common.protoc

Re: [PR] [fix][broker] Fix typo in the config key [pulsar]

2023-12-07 Thread via GitHub
codecov-commenter commented on PR #21690: URL: https://github.com/apache/pulsar/pull/21690#issuecomment-1845600785 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21690?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] [improve][broker] Pulsar Rate Limiting Refactoring changes (PIP-322) [pulsar]

2023-12-07 Thread via GitHub
onobc commented on code in PR #21681: URL: https://github.com/apache/pulsar/pull/21681#discussion_r1419209100 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java: ## @@ -898,57 +888,35 @@ public long increasePublishLimitedTimes() { .re

Re: [PR] [improve][broker] Pulsar Rate Limiting Refactoring changes (PIP-322) [pulsar]

2023-12-07 Thread via GitHub
onobc commented on code in PR #21681: URL: https://github.com/apache/pulsar/pull/21681#discussion_r1419217417 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Producer.java: ## @@ -852,4 +852,25 @@ public boolean isDisconnecting() { private static final Log

Re: [PR] [improve][broker] Pulsar Rate Limiting Refactoring changes (PIP-322) [pulsar]

2023-12-07 Thread via GitHub
onobc commented on code in PR #21681: URL: https://github.com/apache/pulsar/pull/21681#discussion_r1419235949 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PublishRateLimiterImpl.java: ## @@ -16,70 +16,133 @@ * specific language governing permissions and limi

Re: [PR] [improve][broker] Pulsar Rate Limiting Refactoring changes (PIP-322) [pulsar]

2023-12-07 Thread via GitHub
onobc commented on code in PR #21681: URL: https://github.com/apache/pulsar/pull/21681#discussion_r1419241987 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PublishRateLimiterImpl.java: ## @@ -16,70 +16,133 @@ * specific language governing permissions and limi

Re: [PR] [improve][broker] Pulsar Rate Limiting Refactoring changes (PIP-322) [pulsar]

2023-12-07 Thread via GitHub
onobc commented on code in PR #21681: URL: https://github.com/apache/pulsar/pull/21681#discussion_r1419244684 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PublishRateLimiterImpl.java: ## @@ -16,70 +16,133 @@ * specific language governing permissions and limi

Re: [PR] [fix][broker] Key-shared subscription must follow consumer redelivery as per shared sub semantic [pulsar]

2023-12-07 Thread via GitHub
rdhabalia commented on code in PR #21657: URL: https://github.com/apache/pulsar/pull/21657#discussion_r1419421668 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStickyKeyDispatcherMultipleConsumers.java: ## @@ -388,6 +376,17 @@ private int g

Re: [PR] [improve][broker] Pulsar Rate Limiting Refactoring changes (PIP-322) [pulsar]

2023-12-07 Thread via GitHub
lhotari commented on code in PR #21681: URL: https://github.com/apache/pulsar/pull/21681#discussion_r1419462440 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java: ## @@ -898,57 +888,35 @@ public long increasePublishLimitedTimes() { .

Re: [PR] [improve][broker] Pulsar Rate Limiting Refactoring changes (PIP-322) [pulsar]

2023-12-07 Thread via GitHub
onobc commented on code in PR #21681: URL: https://github.com/apache/pulsar/pull/21681#discussion_r1419483803 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java: ## @@ -898,57 +888,35 @@ public long increasePublishLimitedTimes() { .re

Re: [PR] [improve][sec] Add group pulsar and add user pulsar to it instead of root [pulsar]

2023-12-07 Thread via GitHub
lhotari commented on PR #21084: URL: https://github.com/apache/pulsar/pull/21084#issuecomment-1845972457 > Currently, the user pulsar is in the root group, it would be better to use the non-root group to keep more safety. I think we need to revert and first do a PIP if we are doing th

Re: [PR] [improve][sec] Add group pulsar and add user pulsar to it instead of root [pulsar]

2023-12-07 Thread via GitHub
lhotari commented on PR #21084: URL: https://github.com/apache/pulsar/pull/21084#issuecomment-1845982713 This PR #13376 provides more context and the reference about why root group must be used for OpenShift support: * https://engineering.bitnami.com/articles/running-non-root-containers-

Re: [PR] [improve][pip] PIP-320: OpenTelemetry Scaffolding [pulsar]

2023-12-07 Thread via GitHub
asafm commented on code in PR #21635: URL: https://github.com/apache/pulsar/pull/21635#discussion_r1419529311 ## pip/pip-320.md: ## @@ -0,0 +1,241 @@ +# PIP-320 OpenTelemetry Scaffolding + +# Background knowledge + +## PIP-264 - parent PIP titled "Enhanced OTel-based metric sys

Re: [PR] [improve][pip] PIP-320: OpenTelemetry Scaffolding [pulsar]

2023-12-07 Thread via GitHub
asafm commented on code in PR #21635: URL: https://github.com/apache/pulsar/pull/21635#discussion_r1419530990 ## pip/pip-320.md: ## @@ -0,0 +1,241 @@ +# PIP-320 OpenTelemetry Scaffolding + +# Background knowledge + +## PIP-264 - parent PIP titled "Enhanced OTel-based metric sys

Re: [PR] [improve][pip] PIP-320: OpenTelemetry Scaffolding [pulsar]

2023-12-07 Thread via GitHub
asafm commented on code in PR #21635: URL: https://github.com/apache/pulsar/pull/21635#discussion_r1419533017 ## pip/pip-320.md: ## @@ -0,0 +1,241 @@ +# PIP-320 OpenTelemetry Scaffolding + +# Background knowledge + +## PIP-264 - parent PIP titled "Enhanced OTel-based metric sys

Re: [PR] [improve][pip] PIP-313 Support force unsubscribe using consumer api [pulsar]

2023-12-07 Thread via GitHub
asafm commented on code in PR #21452: URL: https://github.com/apache/pulsar/pull/21452#discussion_r1419546710 ## pip/pip_313.md: ## @@ -0,0 +1,74 @@ +# PIP-313: Support force unsubscribe using consumer api Review Comment: filename should be pip-313.md -- This is an autom

Re: [PR] [fix][offload] Don't cleanup data when offload met MetaStore exception [pulsar]

2023-12-07 Thread via GitHub
merlimat merged PR #21686: URL: https://github.com/apache/pulsar/pull/21686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.a

(pulsar) branch master updated: [fix][offload] Don't cleanup data when offload met MetaStore exception (#21686)

2023-12-07 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 1ccf90d95a7 [fix][offload] Don't cleanup data wh

(pulsar) branch branch-3.1 updated: [fix][offload] Don't cleanup data when offload met MetaStore exception (#21686)

2023-12-07 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch branch-3.1 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.1 by this push: new 16e6c462211 [fix][offload] Don't cleanup

(pulsar) branch branch-3.0 updated: [fix][offload] Don't cleanup data when offload met MetaStore exception (#21686)

2023-12-07 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new 17c3bc8312f [fix][offload] Don't cleanup

Re: [PR] [fix][broker] Fix typo in the config key [pulsar]

2023-12-07 Thread via GitHub
merlimat merged PR #21690: URL: https://github.com/apache/pulsar/pull/21690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.a

(pulsar) branch master updated: [fix][broker] Fix typo in the config key (#21690)

2023-12-07 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 822b7f434e0 [fix][broker] Fix typo in the config

(pulsar) branch branch-3.1 updated: [fix][broker] Fix typo in the config key (#21690)

2023-12-07 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch branch-3.1 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.1 by this push: new 89b56a1abf0 [fix][broker] Fix typo in th

(pulsar) branch branch-3.0 updated: [fix][broker] Fix typo in the config key (#21690)

2023-12-07 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new 44131f98110 [fix][broker] Fix typo in th

Re: [PR] [improve][broker] PIP-307: Skip consumer topic lookups during topic load balancing [pulsar]

2023-12-07 Thread via GitHub
heesung-sn commented on code in PR #21682: URL: https://github.com/apache/pulsar/pull/21682#discussion_r1418044228 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java: ## @@ -542,6 +544,10 @@ public SubType getTyp

[PR] Testing CI with the latest Node image for Kind 0.20.0 [pulsar-helm-chart]

2023-12-07 Thread via GitHub
frankjkelly opened a new pull request, #412: URL: https://github.com/apache/pulsar-helm-chart/pull/412 ### Motivation Before tackling upgrade testing I want to make sure that the Helm chart works with the latest Kind node image ### Modifications Hard-coded the default Ki

Re: [PR] [improve][broker] PIP-307: Skip consumer topic lookups during topic load balancing [pulsar]

2023-12-07 Thread via GitHub
heesung-sn commented on code in PR #21682: URL: https://github.com/apache/pulsar/pull/21682#discussion_r1419600767 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentDispatcherMultipleConsumers.java: ## @@ -147,12 +151,13 @@ public synchro

Re: [PR] [improve][pip] PIP-320: OpenTelemetry Scaffolding [pulsar]

2023-12-07 Thread via GitHub
Apurva007 commented on code in PR #21635: URL: https://github.com/apache/pulsar/pull/21635#discussion_r1419708455 ## pip/pip-320.md: ## @@ -0,0 +1,241 @@ +# PIP-320 OpenTelemetry Scaffolding + +# Background knowledge + +## PIP-264 - parent PIP titled "Enhanced OTel-based metric

Re: [PR] [improve][pip] PIP-320: OpenTelemetry Scaffolding [pulsar]

2023-12-07 Thread via GitHub
Apurva007 commented on code in PR #21635: URL: https://github.com/apache/pulsar/pull/21635#discussion_r1419703835 ## pip/pip-320.md: ## @@ -0,0 +1,241 @@ +# PIP-320 OpenTelemetry Scaffolding + +# Background knowledge + +## PIP-264 - parent PIP titled "Enhanced OTel-based metric

[PR] Add type definition for AthenzX509Config [pulsar-client-node]

2023-12-07 Thread via GitHub
hrsakai opened a new pull request, #358: URL: https://github.com/apache/pulsar-client-node/pull/358 ### Motivation Athenz support x.509 certificate and `tokenExpirationTime` param has been removed at https://github.com/apache/pulsar-client-cpp/pull/274 . ### Modifications

Re: [PR] [improve][broker] PIP-307: Skip consumer topic lookups during topic load balancing [pulsar]

2023-12-07 Thread via GitHub
dragosvictor commented on code in PR #21682: URL: https://github.com/apache/pulsar/pull/21682#discussion_r1419798231 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java: ## @@ -308,7 +309,7 @@ public synchronized void removeCons

Re: [I] [Bug] all broker FullGC and shutdown when a large number of producers concurrently update schema [pulsar]

2023-12-07 Thread via GitHub
keyboardbobo closed issue #21672: [Bug] all broker FullGC and shutdown when a large number of producers concurrently update schema URL: https://github.com/apache/pulsar/issues/21672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [fix] [broker] network package lost if enable haProxyProtocolEnabled [pulsar]

2023-12-07 Thread via GitHub
Technoboy- commented on code in PR #21684: URL: https://github.com/apache/pulsar/pull/21684#discussion_r1419816952 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/OptionalProxyProtocolDecoder.java: ## @@ -19,36 +19,63 @@ package org.apache.pulsar.common.protoco

Re: [I] [Bug] Can not offload to HDFS filesystem ,java.lang.NoSuchMethodError: 'java.lang.String org.apache.pulsar.common.naming.TopicName.fromPersistenceNamingEncoding(java.lang.String)' [pulsar]

2023-12-07 Thread via GitHub
Technoboy- commented on issue #21688: URL: https://github.com/apache/pulsar/issues/21688#issuecomment-1846396713 Ah, please keep all the version 3.0.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

(pulsar-site) branch main updated: Docs sync done from apache/pulsar (#822b7f4)

2023-12-07 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new 835fa692da73 Docs sync done from apache/pulsar

Re: [I] [Bug] Java consumer blocked by message larger than batchReceivePolicy.maxNumBytes when calling batchReceiveAsync [pulsar]

2023-12-07 Thread via GitHub
Technoboy- commented on issue #21631: URL: https://github.com/apache/pulsar/issues/21631#issuecomment-1846421665 > > > but I am not sure if this will break the original design > > > > > > I think it breaks > > If the behavior is expected, then maybe we should improve the doc

Re: [PR] [improve][client] PIP-313 Support force unsubscribe using consumer api [pulsar]

2023-12-07 Thread via GitHub
Technoboy- commented on code in PR #21687: URL: https://github.com/apache/pulsar/pull/21687#discussion_r1419848062 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java: ## @@ -1038,11 +1038,24 @@ private CompletableFuture delete(

Re: [PR] [improve][io] Make connectors load sensitive fields from secrets [pulsar]

2023-12-07 Thread via GitHub
jiangpengcheng commented on code in PR #21675: URL: https://github.com/apache/pulsar/pull/21675#discussion_r1419849262 ## pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaSourceConfig.java: ## @@ -152,8 +153,13 @@ public static KafkaSourceConfig load(String yamlFile

[PR] Revert "[improve][sec] Add group pulsar and add user pulsar to it instead of root" [pulsar]

2023-12-07 Thread via GitHub
yaalsn opened a new pull request, #21691: URL: https://github.com/apache/pulsar/pull/21691 ### Motivation Reverts apache/pulsar#21084. Because the change breaks OpenShift support. ### Modifications ### Verifying this change - [x] Make sure that the change passe

Re: [PR] [improve][sec] Revert "Add group pulsar and add user pulsar to it instead of root" [pulsar]

2023-12-07 Thread via GitHub
yaalsn closed pull request #21691: [improve][sec] Revert "Add group pulsar and add user pulsar to it instead of root" URL: https://github.com/apache/pulsar/pull/21691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [improve][io] Make connectors load sensitive fields from secrets [pulsar]

2023-12-07 Thread via GitHub
jiangpengcheng commented on code in PR #21675: URL: https://github.com/apache/pulsar/pull/21675#discussion_r1419860526 ## pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaSourceConfig.java: ## @@ -152,8 +153,13 @@ public static KafkaSourceConfig load(String yamlFile

Re: [PR] [fix] [broker] network package lost if enable haProxyProtocolEnabled [pulsar]

2023-12-07 Thread via GitHub
coderzc commented on code in PR #21684: URL: https://github.com/apache/pulsar/pull/21684#discussion_r1418999660 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/OptionalProxyProtocolDecoder.java: ## @@ -19,35 +19,67 @@ package org.apache.pulsar.common.protocol;

Re: [PR] [improve][io] Make connectors load sensitive fields from secrets [pulsar]

2023-12-07 Thread via GitHub
jiangpengcheng commented on code in PR #21675: URL: https://github.com/apache/pulsar/pull/21675#discussion_r1419861713 ## pulsar-io/influxdb/src/test/java/org/apache/pulsar/io/influxdb/v1/InfluxDBSinkConfigTest.java: ## @@ -85,12 +123,13 @@ public final void validValidateTest()

Re: [PR] [fix] [broker] network package lost if enable haProxyProtocolEnabled [pulsar]

2023-12-07 Thread via GitHub
coderzc commented on code in PR #21684: URL: https://github.com/apache/pulsar/pull/21684#discussion_r1419862355 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/OptionalProxyProtocolDecoder.java: ## @@ -19,35 +19,67 @@ package org.apache.pulsar.common.protocol;

Re: [PR] [improve][io] Make connectors load sensitive fields from secrets [pulsar]

2023-12-07 Thread via GitHub
jiangpengcheng commented on code in PR #21675: URL: https://github.com/apache/pulsar/pull/21675#discussion_r1419862313 ## pulsar-io/common/src/main/java/org/apache/pulsar/io/common/IOConfigUtils.java: ## @@ -77,13 +77,14 @@ private static T loadWithSecrets(Map map, Class clazz

Re: [I] [Doc] pulsar v3.0.2 lacks release notes [pulsar]

2023-12-07 Thread via GitHub
Technoboy- closed issue #21685: [Doc] pulsar v3.0.2 lacks release notes URL: https://github.com/apache/pulsar/issues/21685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [I] [Doc] pulsar v3.0.2 lacks release notes [pulsar]

2023-12-07 Thread via GitHub
Technoboy- commented on issue #21685: URL: https://github.com/apache/pulsar/issues/21685#issuecomment-1846457084 Added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix][broker] Record GeoPersistentReplicator.msgOut before producer#sendAsync [pulsar]

2023-12-07 Thread via GitHub
Technoboy- merged PR #21673: URL: https://github.com/apache/pulsar/pull/21673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar

(pulsar) branch master updated (822b7f434e0 -> 61098ee2552)

2023-12-07 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 822b7f434e0 [fix][broker] Fix typo in the config key (#21690) add 61098ee2552 [fix][broker] Record GeoPersiste

Re: [PR] [fix] [broker] network package lost if enable haProxyProtocolEnabled [pulsar]

2023-12-07 Thread via GitHub
poorbarcode commented on code in PR #21684: URL: https://github.com/apache/pulsar/pull/21684#discussion_r1419866930 ## pulsar-common/src/main/java/org/apache/pulsar/common/protocol/OptionalProxyProtocolDecoder.java: ## @@ -19,35 +19,67 @@ package org.apache.pulsar.common.protoc

Re: [PR] [improve] [test] Add a test to verify no orphan consumers if release lock caused by checkConnectionLiveness [pulsar]

2023-12-07 Thread via GitHub
poorbarcode commented on code in PR #21498: URL: https://github.com/apache/pulsar/pull/21498#discussion_r1419868582 ## pulsar-broker/src/test/java/org/apache/pulsar/client/api/DispatcherLockTest.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [improve][cli]Introduce Regex and File Input Parameters for Enhanced Topic Deletion Command [pulsar]

2023-12-07 Thread via GitHub
poorbarcode commented on code in PR #21664: URL: https://github.com/apache/pulsar/pull/21664#discussion_r1419875489 ## pulsar-client-tools/src/test/java/org/apache/pulsar/admin/cli/TestCmdTopics.java: ## @@ -160,4 +168,59 @@ public void testPartitionedLookupSortByBroker() throws

Re: [I] [Bug] Java consumer blocked by message larger than batchReceivePolicy.maxNumBytes when calling batchReceiveAsync [pulsar]

2023-12-07 Thread via GitHub
shuoqingding commented on issue #21631: URL: https://github.com/apache/pulsar/issues/21631#issuecomment-1846481859 Got it, I will work on a PR soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [improve][pip] PIP-320: OpenTelemetry Scaffolding [pulsar]

2023-12-07 Thread via GitHub
BewareMyPower commented on code in PR #21635: URL: https://github.com/apache/pulsar/pull/21635#discussion_r1419877816 ## pip/pip-320.md: ## @@ -0,0 +1,241 @@ +# PIP-320 OpenTelemetry Scaffolding + +# Background knowledge + +## PIP-264 - parent PIP titled "Enhanced OTel-based me

Re: [PR] [improve][pip] PIP-320: OpenTelemetry Scaffolding [pulsar]

2023-12-07 Thread via GitHub
BewareMyPower commented on PR #21635: URL: https://github.com/apache/pulsar/pull/21635#issuecomment-1846483526 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

(pulsar) branch branch-3.1 updated: [improve][broker] Print recoverBucketSnapshot log if cursorProperties are empty (#21651)

2023-12-07 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch branch-3.1 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.1 by this push: new 2393ca7c3f9 [improve][broker] Print r

(pulsar) branch branch-3.1 updated: [fix][broker] Record GeoPersistentReplicator.msgOut before producer#sendAsync (#21673)

2023-12-07 Thread technoboy
This is an automated email from the ASF dual-hosted git repository. technoboy pushed a commit to branch branch-3.1 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.1 by this push: new c4196fba3ae [fix][broker] Record GeoP

Re: [PR] [improve][sec] Revert "Add group pulsar and add user pulsar to it instead of root" [pulsar]

2023-12-07 Thread via GitHub
codecov-commenter commented on PR #21691: URL: https://github.com/apache/pulsar/pull/21691#issuecomment-1846495927 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21691?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] [Improve][broker] When calculating resource usage, use getMaxResourceUsageWithWeight instead of getMaxResourceUsage [pulsar]

2023-12-07 Thread via GitHub
keyboardbobo commented on PR #16319: URL: https://github.com/apache/pulsar/pull/16319#issuecomment-1846506274 @lordcheng10 @heesung-sn @HQebupt @eolivelli @Jason918 Is there any progress on this PR? If different dimensions are considered when bundle unloading and assigning, there may be f

  1   2   >