[PR] Add the release note for Python client 3.4.0 [pulsar-site]

2024-01-02 Thread via GitHub
RobertIndie opened a new pull request, #761: URL: https://github.com/apache/pulsar-site/pull/761 This PR adds the release note for Python client 3.4.0 https://github.com/apache/pulsar-site/assets/16974619/98d84f89-1eb3-4626-99db-5ca0119f7b93";> https://github.com/apache/puls

Re: [PR] [improve][build] Update copyright date [pulsar]

2024-01-02 Thread via GitHub
nodece commented on PR #21830: URL: https://github.com/apache/pulsar/pull/21830#issuecomment-1874958742 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Release Pulsar 3.1.2 [pulsar-site]

2024-01-02 Thread via GitHub
AnonHxy commented on PR #758: URL: https://github.com/apache/pulsar-site/pull/758#issuecomment-1874942373 > @AnonHxy need to add version to https://github.com/apache/pulsar-site/blob/main/releases.json Fixed. Thanks @shibd -- This is an automated message from the Apache Git Servi

Re: [PR] Release Pulsar 2.11.3 [pulsar-site]

2024-01-02 Thread via GitHub
shibd merged PR #759: URL: https://github.com/apache/pulsar-site/pull/759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apa

(pulsar-client-python) annotated tag v3.4.0 updated (5e5ba62 -> 79145ec)

2024-01-02 Thread zike
This is an automated email from the ASF dual-hosted git repository. zike pushed a change to annotated tag v3.4.0 in repository https://gitbox.apache.org/repos/asf/pulsar-client-python.git *** WARNING: tag v3.4.0 was modified! *** from 5e5ba62 (commit) to 79145ec (tag) tagging 5e5ba

Re: [PR] Optimize release process doc. [pulsar-site]

2024-01-02 Thread via GitHub
shibd closed pull request #760: Optimize release process doc. URL: https://github.com/apache/pulsar-site/pull/760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[PR] Bumped version to 3.5.0a1 [pulsar-client-python]

2024-01-02 Thread via GitHub
RobertIndie opened a new pull request, #191: URL: https://github.com/apache/pulsar-client-python/pull/191 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

svn commit: r66406 - /dev/pulsar/pulsar-client-python-3.4.0-candidate-1/ /release/pulsar/pulsar-client-python-3.4.0/

2024-01-02 Thread technoboy
Author: technoboy Date: Wed Jan 3 06:53:40 2024 New Revision: 66406 Log: Release Apache Pulsar Client Python 3.4.0 Added: release/pulsar/pulsar-client-python-3.4.0/ - copied from r66405, dev/pulsar/pulsar-client-python-3.4.0-candidate-1/ Removed: dev/pulsar/pulsar-client-python-3.4

Re: [PR] [fix][broker] fix the wrong type and default value of maxUnackedMessagesPerSubscriptionOnBrokerBlocked [pulsar]

2024-01-02 Thread via GitHub
aloyszhang commented on code in PR #21765: URL: https://github.com/apache/pulsar/pull/21765#discussion_r1440089694 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -373,10 +373,10 @@ public BrokerService(PulsarService pulsar, EventLoopGro

Re: [PR] [fix][broker] fix the wrong type and default value of maxUnackedMessagesPerSubscriptionOnBrokerBlocked [pulsar]

2024-01-02 Thread via GitHub
aloyszhang commented on PR #21765: URL: https://github.com/apache/pulsar/pull/21765#issuecomment-1874870946 @315157973 @Technoboy- Apply the comment, PTAL again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Optimize release process doc. [pulsar-site]

2024-01-02 Thread via GitHub
RobertIndie commented on code in PR #760: URL: https://github.com/apache/pulsar-site/pull/760#discussion_r1440078028 ## contribute/release-process.md: ## @@ -425,6 +425,10 @@ The wheel files will be generated at each platform directory under `pulsar-clien This step is for ev

(pulsar) branch master updated: [improve][ci] Require all conversations on code to be resolved before merging PRs (#21832)

2024-01-02 Thread zixuan
This is an automated email from the ASF dual-hosted git repository. zixuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 1a4a9d9d1a2 [improve][ci] Require all conversati

Re: [PR] [improve][ci] Require all conversations on code to be resolved before merging PRs [pulsar]

2024-01-02 Thread via GitHub
nodece merged PR #21832: URL: https://github.com/apache/pulsar/pull/21832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apa

[PR] Optimize release process doc. [pulsar-site]

2024-01-02 Thread via GitHub
shibd opened a new pull request, #760: URL: https://github.com/apache/pulsar-site/pull/760 - [x] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc-complete` -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [I] HasMessageAvailable incorrectly returns "true" when there are no available messages [pulsar]

2024-01-02 Thread via GitHub
Technoboy- closed issue #10515: HasMessageAvailable incorrectly returns "true" when there are no available messages URL: https://github.com/apache/pulsar/issues/10515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [I] HasMessageAvailable incorrectly returns "true" when there are no available messages [pulsar]

2024-01-02 Thread via GitHub
Technoboy- commented on issue #10515: URL: https://github.com/apache/pulsar/issues/10515#issuecomment-1874845466 Fixed by https://github.com/apache/pulsar/pull/16443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] Handle already have connected replicate produce with same name [pulsar]

2024-01-02 Thread via GitHub
Technoboy- closed issue #5104: Handle already have connected replicate produce with same name URL: https://github.com/apache/pulsar/issues/5104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [I] Handle already have connected replicate produce with same name [pulsar]

2024-01-02 Thread via GitHub
Technoboy- commented on issue #5104: URL: https://github.com/apache/pulsar/issues/5104#issuecomment-1874843547 https://github.com/apache/pulsar/pull/21155 https://github.com/apache/pulsar/pull/21144 Has fixed this issue. -- This is an automated message from the Apache Git Service. To

Re: [PR] [fix] [broker] Update topic policies as much as possible when some ex was thrown [pulsar]

2024-01-02 Thread via GitHub
poorbarcode commented on code in PR #21810: URL: https://github.com/apache/pulsar/pull/21810#discussion_r1440055369 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3736,40 +3765,30 @@ public void onUpdate(TopicPolicies poli

Re: [PR] [fix] [broker] Update topic policies as much as possible when some ex was thrown [pulsar]

2024-01-02 Thread via GitHub
poorbarcode commented on code in PR #21810: URL: https://github.com/apache/pulsar/pull/21810#discussion_r1440055261 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3061,39 +3062,67 @@ public CompletableFuture onPoliciesUpd

Re: [PR] [fix] [broker] Update topic policies as much as possible when some ex was thrown [pulsar]

2024-01-02 Thread via GitHub
poorbarcode commented on code in PR #21810: URL: https://github.com/apache/pulsar/pull/21810#discussion_r1440055143 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3736,40 +3765,30 @@ public void onUpdate(TopicPolicies poli

Re: [PR] [fix] [broker] Update topic policies as much as possible when some ex was thrown [pulsar]

2024-01-02 Thread via GitHub
Technoboy- commented on code in PR #21810: URL: https://github.com/apache/pulsar/pull/21810#discussion_r1440054057 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3736,40 +3765,30 @@ public void onUpdate(TopicPolicies polic

Re: [PR] [fix] [broker] Update topic policies as much as possible when some ex was thrown [pulsar]

2024-01-02 Thread via GitHub
Technoboy- commented on code in PR #21810: URL: https://github.com/apache/pulsar/pull/21810#discussion_r1440052677 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3736,40 +3765,30 @@ public void onUpdate(TopicPolicies polic

Re: [PR] [fix] [broker] Update topic policies as much as possible when some ex was thrown [pulsar]

2024-01-02 Thread via GitHub
Technoboy- commented on code in PR #21810: URL: https://github.com/apache/pulsar/pull/21810#discussion_r1440052364 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3061,39 +3062,67 @@ public CompletableFuture onPoliciesUpda

Re: [PR] [improve] [broker] PIP-299-part-3: Add dynamic config support: dispatcherPauseOnAckStatePersistentEnabled [pulsar]

2024-01-02 Thread via GitHub
poorbarcode commented on code in PR #21837: URL: https://github.com/apache/pulsar/pull/21837#discussion_r1440051271 ## pulsar-broker/src/test/java/org/apache/pulsar/client/api/SubscriptionPauseOnAckStatPersistTest.java: ## @@ -211,6 +213,69 @@ public boolean hasAckedMessage(Stri

[I] [Bug] maxTotalReceiverQueueSizeAcrossPartitions doesn't actually limit the receiver queue size for MultiTopicConsumer [pulsar]

2024-01-02 Thread via GitHub
RobertIndie opened a new issue, #21838: URL: https://github.com/apache/pulsar/issues/21838 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version b944f10d2a9bac2fbe19dc83bf250a276f1ed4

Re: [PR] Release Pulsar 3.1.2 [pulsar-site]

2024-01-02 Thread via GitHub
AnonHxy commented on PR #758: URL: https://github.com/apache/pulsar-site/pull/758#issuecomment-187481 @tisonkun @momo-jun @Technoboy- PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Release Pulsar 2.11.3 [pulsar-site]

2024-01-02 Thread via GitHub
github-actions[bot] commented on PR #759: URL: https://github.com/apache/pulsar-site/pull/759#issuecomment-1874807302 @shibd Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `doc

[PR] Release Pulsar 2.11.3 [pulsar-site]

2024-01-02 Thread via GitHub
shibd opened a new pull request, #759: URL: https://github.com/apache/pulsar-site/pull/759 ## Preview https://github.com/apache/pulsar-site/assets/33416836/e08c4802-6dba-4514-b433-eed08871c6cf";> https://github.com/apache/pulsar-site/assets/33416836/a08b0fca-12d8-468f-a607-e2de6

Re: [PR] [improve] [broker] PIP-299-part-3: Add dynamic config support: dispatcherPauseOnAckStatePersistentEnabled [pulsar]

2024-01-02 Thread via GitHub
Technoboy- commented on code in PR #21837: URL: https://github.com/apache/pulsar/pull/21837#discussion_r1440025341 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java: ## @@ -1039,25 +1039,40 @@ public void addUnA

Re: [PR] [improve] [broker] PIP-299-part-3: Add dynamic config support: dispatcherPauseOnAckStatePersistentEnabled [pulsar]

2024-01-02 Thread via GitHub
Technoboy- commented on code in PR #21837: URL: https://github.com/apache/pulsar/pull/21837#discussion_r1440025341 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java: ## @@ -1039,25 +1039,40 @@ public void addUnA

Re: [PR] [improve] [broker] PIP-299-part-3: Add dynamic config support: dispatcherPauseOnAckStatePersistentEnabled [pulsar]

2024-01-02 Thread via GitHub
Technoboy- commented on code in PR #21837: URL: https://github.com/apache/pulsar/pull/21837#discussion_r1440024802 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java: ## @@ -1039,25 +1039,40 @@ public void addUnA

Re: [PR] [improve] [broker] PIP-299-part-3: Add dynamic config support: dispatcherPauseOnAckStatePersistentEnabled [pulsar]

2024-01-02 Thread via GitHub
poorbarcode commented on code in PR #21837: URL: https://github.com/apache/pulsar/pull/21837#discussion_r1440022120 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java: ## @@ -1039,23 +1039,31 @@ public void addUn

Re: [PR] [improve] [broker] PIP-299-part-3: Add dynamic config support: dispatcherPauseOnAckStatePersistentEnabled [pulsar]

2024-01-02 Thread via GitHub
poorbarcode commented on code in PR #21837: URL: https://github.com/apache/pulsar/pull/21837#discussion_r1440020503 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3770,6 +3770,21 @@ public boolean isDispatcherPauseOnAckSt

Re: [PR] [improve] [broker] PIP-299-part-3: Add dynamic config support: dispatcherPauseOnAckStatePersistentEnabled [pulsar]

2024-01-02 Thread via GitHub
poorbarcode commented on code in PR #21837: URL: https://github.com/apache/pulsar/pull/21837#discussion_r1440020365 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3770,6 +3770,21 @@ public boolean isDispatcherPauseOnAckSt

Re: [PR] [improve] [broker] PIP-299-part-3: Add dynamic config support: dispatcherPauseOnAckStatePersistentEnabled [pulsar]

2024-01-02 Thread via GitHub
poorbarcode commented on code in PR #21837: URL: https://github.com/apache/pulsar/pull/21837#discussion_r1440019920 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3770,6 +3770,21 @@ public boolean isDispatcherPauseOnAckSt

Re: [PR] [improve] [broker] PIP-299-part-3: Add dynamic config support: dispatcherPauseOnAckStatePersistentEnabled [pulsar]

2024-01-02 Thread via GitHub
codelipenghui commented on code in PR #21837: URL: https://github.com/apache/pulsar/pull/21837#discussion_r1440009248 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3770,6 +3770,21 @@ public boolean isDispatcherPauseOnAck

svn commit: r66396 - /dev/pulsar/pulsar-2.11.3-candidate-2/ /release/pulsar/pulsar-2.11.3/

2024-01-02 Thread yubiao
Author: yubiao Date: Wed Jan 3 02:22:09 2024 New Revision: 66396 Log: Release Apache Pulsar 2.11.3 Added: release/pulsar/pulsar-2.11.3/ - copied from r66395, dev/pulsar/pulsar-2.11.3-candidate-2/ Removed: dev/pulsar/pulsar-2.11.3-candidate-2/

(pulsar) annotated tag v2.11.3 updated (c7ac62ca9eb -> 15c7bffebf1)

2024-01-02 Thread baodi
This is an automated email from the ASF dual-hosted git repository. baodi pushed a change to annotated tag v2.11.3 in repository https://gitbox.apache.org/repos/asf/pulsar.git *** WARNING: tag v2.11.3 was modified! *** from c7ac62ca9eb (commit) to 15c7bffebf1 (tag) tagging c7ac62ca9e

(pulsar-site) branch main updated: Docs sync done from apache/pulsar (#0ba5ae6)

2024-01-02 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new bd5bd14172e5 Docs sync done from apache/pulsar

Re: [I] [Bug] Consumer.batchReceive() with large batchSize setting times out when there are plenty of messages to receive [pulsar]

2024-01-02 Thread via GitHub
zebehringer commented on issue #21794: URL: https://github.com/apache/pulsar/issues/21794#issuecomment-1874728613 I am able to get more consistent results with fewer timeouts if I change the _publisher_ config to flush batches after 100 milliseconds rather than the default of 1 millisecond.

Re: [PR] [bug] tenant's allowedClusters is not updated when removing a cluster is fixed [pulsar]

2024-01-02 Thread via GitHub
ubo-dev closed pull request #21740: [bug] tenant's allowedClusters is not updated when removing a cluster is fixed URL: https://github.com/apache/pulsar/pull/21740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] [feat][broker] Implementation of PIP-323: Complete Backlog Quota Telemetry [pulsar]

2024-01-02 Thread via GitHub
codecov-commenter commented on PR #21816: URL: https://github.com/apache/pulsar/pull/21816#issuecomment-1874452496 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21816?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

(pulsar) branch branch-3.0 updated: Upgrade OWASP dependency check maven plugin version

2024-01-02 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new 4c915bdcddd Upgrade OWASP dependency ch

(pulsar) branch branch-2.11 updated: Upgrade OWASP dependency check maven plugin version

2024-01-02 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.11 by this push: new 79f16f48623 Upgrade OWASP dependency

(pulsar) branch branch-2.10 updated: Upgrade OWASP dependency check maven plugin version

2024-01-02 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-2.10 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.10 by this push: new 5e70810f98c Upgrade OWASP dependency

(pulsar) branch branch-3.1 updated: Upgrade OWASP dependency check maven plugin version

2024-01-02 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.1 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.1 by this push: new b0e8b5abb57 Upgrade OWASP dependency ch

(pulsar) branch master updated: [improve][ci] Upgrade to actions/upload-artifact@v4 (#21836)

2024-01-02 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0ba5ae60850 [improve][ci] Upgrade to actions/up

Re: [PR] [improve][ci] Upgrade to actions/upload-artifact@v4 [pulsar]

2024-01-02 Thread via GitHub
lhotari merged PR #21836: URL: https://github.com/apache/pulsar/pull/21836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

Re: [PR] [improve] [broker] PIP-299-part-3: Add dynamic config support: dispatcherPauseOnAckStatePersistentEnabled [pulsar]

2024-01-02 Thread via GitHub
lhotari commented on code in PR #21837: URL: https://github.com/apache/pulsar/pull/21837#discussion_r1439619703 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3770,6 +3770,21 @@ public boolean isDispatcherPauseOnAckStateP

Re: [PR] [improve][ci] Upgrade to actions/upload-artifact@v4 [pulsar]

2024-01-02 Thread via GitHub
codecov-commenter commented on PR #21836: URL: https://github.com/apache/pulsar/pull/21836#issuecomment-1874259948 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21836?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] [improve] [broker] PIP-299-part-3: Add dynamic config support: dispatcherPauseOnAckStatePersistentEnabled [pulsar]

2024-01-02 Thread via GitHub
poorbarcode commented on code in PR #21837: URL: https://github.com/apache/pulsar/pull/21837#discussion_r1439618787 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -2743,6 +2747,28 @@ private void updateTopicMessageDispatchRate() {

(pulsar) branch master updated (92e0e4744a5 -> cf6b5d0a4e3)

2024-01-02 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 92e0e4744a5 [fix][ci] Fix OWASP dep check GH actions workflow (#21831) add cf6b5d0a4e3 [fix][build] Fix the erro

Re: [PR] [fix][build] Fix the errorprone maven profile [pulsar]

2024-01-02 Thread via GitHub
lhotari merged PR #21834: URL: https://github.com/apache/pulsar/pull/21834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

Re: [PR] [improve] [broker] PIP-299-part-3: Add dynamic config support: dispatcherPauseOnAckStatePersistentEnabled [pulsar]

2024-01-02 Thread via GitHub
lhotari commented on code in PR #21837: URL: https://github.com/apache/pulsar/pull/21837#discussion_r1439613250 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -2743,6 +2747,28 @@ private void updateTopicMessageDispatchRate() {

Re: [PR] [improve] [broker] PIP-299-part-3: Add dynamic config support: dispatcherPauseOnAckStatePersistentEnabled [pulsar]

2024-01-02 Thread via GitHub
lhotari commented on code in PR #21837: URL: https://github.com/apache/pulsar/pull/21837#discussion_r1439613250 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -2743,6 +2747,28 @@ private void updateTopicMessageDispatchRate() {

[PR] [improve] [broker] PIP-299-part-3: Add dynamic config support: dispatcherPauseOnAckStatePersistentEnabled [pulsar]

2024-01-02 Thread via GitHub
poorbarcode opened a new pull request, #21837: URL: https://github.com/apache/pulsar/pull/21837 The part 1 of [PIP-299](https://github.com/apache/pulsar/pull/21118/files?short_path=cf766b5#diff-cf766b5d463b6832017e482baad14832f6a4d41dc969da279b98b69e26ec6f6a): the implementation of "Stop di

Re: [PR] [feat][broker] Implementation of PIP-323: Complete Backlog Quota Telemetry [pulsar]

2024-01-02 Thread via GitHub
asafm commented on PR #21816: URL: https://github.com/apache/pulsar/pull/21816#issuecomment-1874215642 Thanks for the comments, @dragosvictor, very helpful! I replied to all. Can you re-review and resolve if it is solved? -- This is an automated message from the Apache Git Service. To res

Re: [PR] [fix][client] Support for PKCS#8 private key [pulsar]

2024-01-02 Thread via GitHub
izumo27 commented on PR #21828: URL: https://github.com/apache/pulsar/pull/21828#issuecomment-1874185519 I missed many tests using ```private-key.client-rsa.pem```. I modified them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [fix][client] Support for PKCS#8 private key [pulsar]

2024-01-02 Thread via GitHub
izumo27 commented on PR #21828: URL: https://github.com/apache/pulsar/pull/21828#issuecomment-1874183131 > We should keep the original test with `x.pem`key. In ```testRSAEncryption```, ```producer``` and ```producer2``` use the same key, so it looks like producer2 is not needed. h

Re: [PR] [fix][broker] Fix messages could not expire due to incorrect client clock [pulsar]

2024-01-02 Thread via GitHub
lhotari commented on PR #21835: URL: https://github.com/apache/pulsar/pull/21835#issuecomment-1874157322 Please also update the comment in `org.apache.pulsar.common.protocol.Commands#getEntryTimestamp` . I guess that now the BrokerEntryMetadata with the timestamp will always be added? --

(pulsar) branch master updated: [fix][ci] Fix OWASP dep check GH actions workflow (#21831)

2024-01-02 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 92e0e4744a5 [fix][ci] Fix OWASP dep check GH ac

Re: [PR] [fix][ci] Fix OWASP dep check GH actions workflow [pulsar]

2024-01-02 Thread via GitHub
lhotari merged PR #21831: URL: https://github.com/apache/pulsar/pull/21831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

Re: [PR] [improve][broker] PIP-299-part-2: add config dispatcherPauseOnAckStatePersistentEnabled [pulsar]

2024-01-02 Thread via GitHub
poorbarcode merged PR #21370: URL: https://github.com/apache/pulsar/pull/21370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsa

(pulsar) branch master updated: [improve][broker] PIP-299-part-2: add config dispatcherPauseOnAckStatePersistentEnabled (#21370)

2024-01-02 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new c0b89eb7481 [improve][broker] PIP-299-part-2: ad

Re: [PR] [fix][broker] Fix messages could not expire due to incorrect client clock [pulsar]

2024-01-02 Thread via GitHub
codecov-commenter commented on PR #21835: URL: https://github.com/apache/pulsar/pull/21835#issuecomment-1874083823 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21835?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] [improve][ci] Upgrade to actions/upload-artifact@v4 [pulsar]

2024-01-02 Thread via GitHub
lhotari commented on PR #21836: URL: https://github.com/apache/pulsar/pull/21836#issuecomment-1874064920 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] [improve][broker] PIP-299-part-2: add config dispatcherPauseOnAckStatePersistentEnabled [pulsar]

2024-01-02 Thread via GitHub
codecov-commenter commented on PR #21370: URL: https://github.com/apache/pulsar/pull/21370#issuecomment-1874020973 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/21370?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] [fix][broker] Fix messages could not expire due to incorrect client clock [pulsar]

2024-01-02 Thread via GitHub
Technoboy- closed pull request #21835: [fix][broker] Fix messages could not expire due to incorrect client clock URL: https://github.com/apache/pulsar/pull/21835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [feat][broker] Implementation of PIP-323: Complete Backlog Quota Telemetry [pulsar]

2024-01-02 Thread via GitHub
asafm commented on code in PR #21816: URL: https://github.com/apache/pulsar/pull/21816#discussion_r1439280519 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorContainer.java: ## @@ -204,6 +281,24 @@ public ManagedCursor getSlowestReader() {

Re: [PR] [fix][broker] fix the wrong type and default value of maxUnackedMessagesPerSubscriptionOnBrokerBlocked [pulsar]

2024-01-02 Thread via GitHub
315157973 commented on code in PR #21765: URL: https://github.com/apache/pulsar/pull/21765#discussion_r1439425407 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -373,10 +373,10 @@ public BrokerService(PulsarService pulsar, EventLoopGrou

Re: [PR] [fix][build] Fix the errorprone maven profile [pulsar]

2024-01-02 Thread via GitHub
lhotari commented on PR #21834: URL: https://github.com/apache/pulsar/pull/21834#issuecomment-1873966407 /cc @asafm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[PR] Fix messages could not expire due to incorrect client clock [pulsar]

2024-01-02 Thread via GitHub
315157973 opened a new pull request, #21835: URL: https://github.com/apache/pulsar/pull/21835 Fixes #21347 ### Motivation When the client machine's clock is incorrect (eg: set to 1 year later) and the Broker does not set the AppendBrokerTimestampMetadataInterceptor, the Ledger wil

[PR] [fix][build] Fix the errorprone maven profile [pulsar]

2024-01-02 Thread via GitHub
lhotari opened a new pull request, #21834: URL: https://github.com/apache/pulsar/pull/21834 ### Motivation The errorprone maven profile is currently broken and doesn't work. ### Modifications - update to work with JDK17 - upgrade errorprone to latest version ###

Re: [PR] [feat][broker] Implementation of PIP-323: Complete Backlog Quota Telemetry [pulsar]

2024-01-02 Thread via GitHub
asafm commented on code in PR #21816: URL: https://github.com/apache/pulsar/pull/21816#discussion_r1439373355 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BacklogQuotaManagerTest.java: ## @@ -344,6 +362,269 @@ public void testTriggerBacklogQuotaSizeWithReader(

Re: [PR] Preview Add the release note for Pulsar 3.1.2 [pulsar-site]

2024-01-02 Thread via GitHub
github-actions[bot] commented on PR #758: URL: https://github.com/apache/pulsar-site/pull/758#issuecomment-1873915133 @AnonHxy Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `d

[PR] Preview Add the release note for Pulsar 3.1.2 [pulsar-site]

2024-01-02 Thread via GitHub
AnonHxy opened a new pull request, #758: URL: https://github.com/apache/pulsar-site/pull/758 Preview ![image](https://github.com/apache/pulsar-site/assets/10233437/a30eca2b-5a69-4502-8612-7c3b3ca97d64) ![image](https://github.com/apache/pulsar-site/assets/10233437/d00aad24-48b2-42

Re: [I] IPv6 Pulsar-manager deployment through helm chart [pulsar-manager]

2024-01-02 Thread via GitHub
harshitvp19 commented on issue #450: URL: https://github.com/apache/pulsar-manager/issues/450#issuecomment-1873891008 I am trying to deploy pulsar in an IPv6 cluster. It's unable to resolve hostname of zookeeper. Did you modify any configuration to achieve successful installation? --

Re: [PR] [feat][broker] Implementation of PIP-323: Complete Backlog Quota Telemetry [pulsar]

2024-01-02 Thread via GitHub
asafm commented on code in PR #21816: URL: https://github.com/apache/pulsar/pull/21816#discussion_r1439288913 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -3158,35 +3201,99 @@ public boolean isSizeBacklogExceeded() {

[PR] [improve][fn] Show the class name of exceptions for pulsar functions [pulsar]

2024-01-02 Thread via GitHub
jiangpengcheng opened a new pull request, #21833: URL: https://github.com/apache/pulsar/pull/21833 Fixes #xyz Main Issue: #xyz PIP: #xyz ### Motivation Some exceptions may have an empty messages, which makes it hard to know

Re: [PR] [feat][broker] Implementation of PIP-323: Complete Backlog Quota Telemetry [pulsar]

2024-01-02 Thread via GitHub
asafm commented on code in PR #21816: URL: https://github.com/apache/pulsar/pull/21816#discussion_r1439280519 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorContainer.java: ## @@ -204,6 +281,24 @@ public ManagedCursor getSlowestReader() {

Re: [PR] [feat][broker] Implementation of PIP-323: Complete Backlog Quota Telemetry [pulsar]

2024-01-02 Thread via GitHub
asafm commented on code in PR #21816: URL: https://github.com/apache/pulsar/pull/21816#discussion_r1439280519 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorContainer.java: ## @@ -204,6 +281,24 @@ public ManagedCursor getSlowestReader() {

Re: [PR] [feat][broker] Implementation of PIP-323: Complete Backlog Quota Telemetry [pulsar]

2024-01-02 Thread via GitHub
asafm commented on code in PR #21816: URL: https://github.com/apache/pulsar/pull/21816#discussion_r1439275659 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorContainer.java: ## @@ -56,10 +76,61 @@ private static class Item { } } -

Re: [PR] [fix][ci] Fix OWASP dep check GH actions workflow [pulsar]

2024-01-02 Thread via GitHub
lhotari commented on PR #21831: URL: https://github.com/apache/pulsar/pull/21831#issuecomment-1873759619 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] [fix][ci] Fix OWASP dep check GH actions workflow [pulsar]

2024-01-02 Thread via GitHub
lhotari commented on PR #21831: URL: https://github.com/apache/pulsar/pull/21831#issuecomment-1873756516 One more test run here with more useful scanning for tiered-storage/offloaders and pulsar-io connectors: https://github.com/lhotari/pulsar/actions/runs/7383922078/job/20085915493 -- T

Re: [PR] [improve][ml] Filter out deleted entries before read entries from ledger. [pulsar]

2024-01-02 Thread via GitHub
dao-jun commented on PR #21739: URL: https://github.com/apache/pulsar/pull/21739#issuecomment-1873717614 > @dao-jun Is it better to split them into 2 PRs? The current one is focused on `filter-out deleted entries before reading entries` and the another one for making the reads parallelly. I