Re: [PR] [improve][pip] PIP-343: Use picocli instead of jcommander [pulsar]

2024-03-05 Thread via GitHub
nodece commented on PR #22181: URL: https://github.com/apache/pulsar/pull/22181#issuecomment-1980272344 Due to the large scope of refactoring, I need to split the PR: - [x] https://github.com/apache/pulsar/pull/22209 - bin/pulsar-admin - bin/pulsar-client - bin/pulsar

Re: [PR] [fix][client] fix Reader.hasMessageAvailable might return true after seeking to latest [pulsar]

2024-03-05 Thread via GitHub
codecov-commenter commented on PR #22201: URL: https://github.com/apache/pulsar/pull/22201#issuecomment-1980232160 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/22201?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [I] Flaky-test: RGUsageMTAggrWaitForAllMsgsTest.testMTProduceConsumeRGUsageNonPersistentTopicNamesDifferentTenant [pulsar]

2024-03-05 Thread via GitHub
BewareMyPower commented on issue #13755: URL: https://github.com/apache/pulsar/issues/13755#issuecomment-1980203273 It's still flaky. https://github.com/apache/pulsar/actions/runs/8157633990/job/22329172173?pr=22201 ``` java.lang.AssertionError: expected [400] but found [0]

Re: [PR] [fix][client] fix Reader.hasMessageAvailable might return true after seeking to latest [pulsar]

2024-03-05 Thread via GitHub
BewareMyPower commented on code in PR #22201: URL: https://github.com/apache/pulsar/pull/22201#discussion_r1513919792 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java: ## @@ -2279,14 +2287,25 @@ private void seekAsyncInternal(long requestId, ByteBuf

[I] [Bug] Messages lost if a multi-topics consumer does not receive all messages after seek [pulsar]

2024-03-05 Thread via GitHub
BewareMyPower opened a new issue, #22208: URL: https://github.com/apache/pulsar/issues/22208 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version master (207335a449f2bc9cdf6782c67f93

Re: [PR] [improve] [pip] PIP-344 Correct the behavior of the public API pulsarClient.getPartitionsForTopic(topicName) [pulsar]

2024-03-05 Thread via GitHub
poorbarcode commented on PR #22182: URL: https://github.com/apache/pulsar/pull/22182#issuecomment-197139 - https://github.com/apache/pulsar/pull/22206 fixes the incorrect behavior of the case 4 - In the future, a PR will be committed to fix the incorrect behavior of case 5. --

[PR] [fix] [client] PIP-344 Do not create partitioned metadata when calling pulsarClient.getPartitionsForTopic(topicName) [pulsar]

2024-03-05 Thread via GitHub
poorbarcode opened a new pull request, #22206: URL: https://github.com/apache/pulsar/pull/22206 ### Motivation see also [PIP-344 Correct the behavior of the public API pulsarClient.getPartitionsForTopic(topicName)](https://github.com/apache/pulsar/pull/22182) Background

[PR] The sample configuration of io-debezium has an error of container's name. [pulsar-site]

2024-03-05 Thread via GitHub
zhaoyajun2009 opened a new pull request, #826: URL: https://github.com/apache/pulsar-site/pull/826 This PR adds doc for #xyz This PR fixes #xyz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [improve] PIP 342: Support OpenTelemetry metrics in Pulsar client [pulsar]

2024-03-05 Thread via GitHub
merlimat commented on code in PR #22178: URL: https://github.com/apache/pulsar/pull/22178#discussion_r1513733755 ## pip/pip-342 OTel client metrics support.md: ## @@ -0,0 +1,201 @@ +# PIP 342: Support OpenTelemetry metrics in Pulsar client + +## Motivation + +Current support for

Re: [PR] [cherry-pick] [branch-3.0] Fix reader stuck when read from compacted topic with read compact mode disable [pulsar]

2024-03-05 Thread via GitHub
thetumbled commented on PR #22199: URL: https://github.com/apache/pulsar/pull/22199#issuecomment-1979948976 https://github.com/apache/pulsar/assets/52550727/15f5e709-b1ca-40f8-9273-d426db56a4ec";> ``` Error: No release type found in pull request title "[cherry-pick] [branch-3.0] Fix re

[PR] The sample configuration of io-debezium has a error of parameter. [pulsar-site]

2024-03-05 Thread via GitHub
zhaoyajun2009 opened a new pull request, #825: URL: https://github.com/apache/pulsar-site/pull/825 This PR adds doc for #xyz This PR fixes #xyz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [feat][cli] Add a cli tool to check whether the input schema is validated [pulsar]

2024-03-05 Thread via GitHub
codelipenghui commented on PR #22151: URL: https://github.com/apache/pulsar/pull/22151#issuecomment-1979908467 Admin CLI: https://pulsar.apache.org/reference/#/3.2.x/pulsar-admin/schemas?id=compatibility Admin REST API: https://pulsar.apache.org/admin-rest-api/?version=3.2.0#operation/Sc

[I] [Bug] Attempt to send cookie metrics to pushgateway failed [pulsar]

2024-03-05 Thread via GitHub
ktpktr0 opened a new issue, #22205: URL: https://github.com/apache/pulsar/issues/22205 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Version java: 1.8.0.162 pulsar: 2.10.5 os: c

Re: [PR] [improve][broker] Consistently add fine-grain authorization to REST API [pulsar]

2024-03-05 Thread via GitHub
lhotari commented on PR #22202: URL: https://github.com/apache/pulsar/pull/22202#issuecomment-1979903493 Good work @mattisonchao ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] [fix][client] Fix getProxyConnection when the topic is migrated [pulsar]

2024-03-05 Thread via GitHub
heesung-sn commented on code in PR #22085: URL: https://github.com/apache/pulsar/pull/22085#discussion_r1513678571 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java: ## @@ -990,8 +991,13 @@ public CompletableFuture getConnectionToServiceUrl() {

Re: [PR] [improve][broker] Consistently add fine-grain authorization to REST API [pulsar]

2024-03-05 Thread via GitHub
lhotari commented on code in PR #22202: URL: https://github.com/apache/pulsar/pull/22202#discussion_r1513660630 ## pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/PolicyName.java: ## @@ -52,5 +52,6 @@ public enum PolicyName { RESOURCEGROUP, ENTRY_FIL

Re: [PR] [improve][broker] Consistently add fine-grain authorization to REST API [pulsar]

2024-03-05 Thread via GitHub
lhotari commented on code in PR #22202: URL: https://github.com/apache/pulsar/pull/22202#discussion_r1513659780 ## pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/PolicyName.java: ## @@ -52,5 +52,6 @@ public enum PolicyName { RESOURCEGROUP, ENTRY_FIL

Re: [PR] [improve][pip] PIP-324: Alpine Docker images [pulsar]

2024-03-05 Thread via GitHub
lhotari commented on code in PR #21716: URL: https://github.com/apache/pulsar/pull/21716#discussion_r1513635870 ## pip/pip-324-Alpine Docker images.md: ## @@ -0,0 +1,144 @@ +# PIP-324: Switch to Alpine Linux base Docker images + + +# Motivation + +Pulsar Docker images are curren

(pulsar) branch master updated: [improve][client] add physicalAddress as part of connection pool key (#22196)

2024-03-05 Thread heesung
This is an automated email from the ASF dual-hosted git repository. heesung pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new e2f94dc98db [improve][client] add physicalAddre

Re: [PR] [improve][client] add physicalAddress as part of connection pool key [pulsar]

2024-03-05 Thread via GitHub
heesung-sn merged PR #22196: URL: https://github.com/apache/pulsar/pull/22196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar

Re: [PR] [improve][client] add physicalAddress as part of connection pool key [pulsar]

2024-03-05 Thread via GitHub
codecov-commenter commented on PR #22196: URL: https://github.com/apache/pulsar/pull/22196#issuecomment-1979826977 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/22196?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

(pulsar-site) branch main updated: Fix bugs in sample cherry-picking helper script

2024-03-05 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new d9402d2938a3 Fix bugs in sample cherry-picking

(pulsar) branch branch-3.1 updated: [fix][broker][branch-3.1] Fix broker not starting when both transactions and the Extensible Load Manager are enabled (#22194)

2024-03-05 Thread heesung
This is an automated email from the ASF dual-hosted git repository. heesung pushed a commit to branch branch-3.1 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.1 by this push: new 4366a13ae2f [fix][broker][branch-3.1] F

Re: [PR] [fix][broker][branch-3.1] Fix broker not starting when both transactions and the Extensible Load Manager are enabled [pulsar]

2024-03-05 Thread via GitHub
heesung-sn merged PR #22194: URL: https://github.com/apache/pulsar/pull/22194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar

Re: [PR] [cherry-pick] [branch-3.0] Fix reader stuck when read from compacted topic with read compact mode disable [pulsar]

2024-03-05 Thread via GitHub
heesung-sn closed pull request #22199: [cherry-pick] [branch-3.0] Fix reader stuck when read from compacted topic with read compact mode disable URL: https://github.com/apache/pulsar/pull/22199 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] [Enhancement] authentication refresh support for mTLS auth [pulsar]

2024-03-05 Thread via GitHub
lhotari commented on issue #22125: URL: https://github.com/apache/pulsar/issues/22125#issuecomment-1979731410 @damienburke Thank you for your proposal. We greatly appreciate your willingness to contribute to this project! I'd encourage you to join the #dev channel on Apache Pulsar's Slac

Re: [PR] [improve][client] add physicalAddress as part of connection pool key [pulsar]

2024-03-05 Thread via GitHub
heesung-sn commented on code in PR #22196: URL: https://github.com/apache/pulsar/pull/22196#discussion_r1513552224 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConnectionPool.java: ## @@ -222,59 +230,55 @@ public CompletableFuture getConnection(InetSocketAddress

Re: [PR] [improve][client] add physicalAddress as part of connection pool key [pulsar]

2024-03-05 Thread via GitHub
lhotari commented on code in PR #22196: URL: https://github.com/apache/pulsar/pull/22196#discussion_r1513545416 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConnectionPool.java: ## @@ -222,59 +230,55 @@ public CompletableFuture getConnection(InetSocketAddress lo

(pulsar) branch branch-2.11 updated: [fix][test] testModularLoadManagerRemoveBundleAndLoad (#19710)

2024-03-05 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.11 by this push: new 0cf5a837512 [fix][test] testModularLo

Re: [PR] [improve][broker] Replace ScheduledExecutorService to ExecutorService in ModularLoadManagerImpl [pulsar]

2024-03-05 Thread via GitHub
lhotari commented on PR #19656: URL: https://github.com/apache/pulsar/pull/19656#issuecomment-1979674944 Nevermind, cherry-picking and backporting #19710 to fix the issue in branch-2.11. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [improve][broker] Replace ScheduledExecutorService to ExecutorService in ModularLoadManagerImpl [pulsar]

2024-03-05 Thread via GitHub
lhotari commented on PR #19656: URL: https://github.com/apache/pulsar/pull/19656#issuecomment-1979667112 Why was this cherry-picked to branch-2.11? The tests are broken in branch-2.11 ``` Error: Tests run: 42, Failures: 1, Errors: 0, Skipped: 36, Time elapsed: 21.939 s <<< FAIL

Re: [PR] [fix][broker][branch-3.1] Fix broker not starting when both transactions and the Extensible Load Manager are enabled [pulsar]

2024-03-05 Thread via GitHub
heesung-sn closed pull request #22194: [fix][broker][branch-3.1] Fix broker not starting when both transactions and the Extensible Load Manager are enabled URL: https://github.com/apache/pulsar/pull/22194 -- This is an automated message from the Apache Git Service. To respond to the message,

(pulsar) branch branch-3.0 updated: [fix][broker][branch-3.0] Fix broker not starting when both transactions and the Extensible Load Manager are enabled (#22168)

2024-03-05 Thread heesung
This is an automated email from the ASF dual-hosted git repository. heesung pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new d396e44efdc [fix][broker][branch-3.0] F

Re: [PR] [fix][broker][branch-3.0] Fix broker not starting when both transactions and the Extensible Load Manager are enabled [pulsar]

2024-03-05 Thread via GitHub
heesung-sn merged PR #22168: URL: https://github.com/apache/pulsar/pull/22168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar

Re: [D] getMessageIdFromTimestamp Timeout issues [pulsar]

2024-03-05 Thread via GitHub
GitHub user KannarFr closed a discussion: getMessageIdFromTimestamp Timeout issues Hi, when trying to getMessageIdFromTimestamp on a heavy topic with offloaded ledgers I get AdminProxyHandler Gateway Timeout after 30s. I am not sure to correctly identify the TO I should increase. Is that the

Re: [D] getMessageIdFromTimestamp Timeout issues [pulsar]

2024-03-05 Thread via GitHub
GitHub user KannarFr added a comment to the discussion: getMessageIdFromTimestamp Timeout issues Thanks a lot for the pointer. I'm following it. GitHub link: https://github.com/apache/pulsar/discussions/22098#discussioncomment-8684091 This is an automatically sent email for commits@puls

Re: [PR] WIP: PIP-342: OTel client metrics support [pulsar]

2024-03-05 Thread via GitHub
merlimat commented on code in PR #22179: URL: https://github.com/apache/pulsar/pull/22179#discussion_r1513299277 ## pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ConsumerStats.java: ## @@ -29,9 +30,12 @@ * * All the stats are relative to the last recording per

Re: [PR] WIP: PIP-342: OTel client metrics support [pulsar]

2024-03-05 Thread via GitHub
merlimat commented on code in PR #22179: URL: https://github.com/apache/pulsar/pull/22179#discussion_r1513274697 ## pulsar-broker/src/test/java/org/apache/pulsar/client/api/PulsarMultiListenersWithInternalListenerNameTest.java: ## @@ -137,7 +139,7 @@ private void doFindBrokerWit

Re: [PR] WIP: PIP-342: OTel client metrics support [pulsar]

2024-03-05 Thread via GitHub
merlimat commented on code in PR #22179: URL: https://github.com/apache/pulsar/pull/22179#discussion_r1513267595 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/BinaryProtoLookupService.java: ## @@ -84,6 +92,21 @@ public BinaryProtoLookupService(PulsarClientImpl cli

Re: [PR] WIP: PIP-342: OTel client metrics support [pulsar]

2024-03-05 Thread via GitHub
merlimat commented on code in PR #22179: URL: https://github.com/apache/pulsar/pull/22179#discussion_r1513267164 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/BinaryProtoLookupService.java: ## @@ -84,6 +92,21 @@ public BinaryProtoLookupService(PulsarClientImpl cli

Re: [PR] WIP: PIP-342: OTel client metrics support [pulsar]

2024-03-05 Thread via GitHub
merlimat commented on code in PR #22179: URL: https://github.com/apache/pulsar/pull/22179#discussion_r1513265863 ## pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ClientBuilder.java: ## @@ -451,15 +452,18 @@ ClientBuilder authentication(String authPluginClassName,

Re: [PR] [improve][client] add physicalAddress as part of connection pool key [pulsar]

2024-03-05 Thread via GitHub
heesung-sn commented on code in PR #22196: URL: https://github.com/apache/pulsar/pull/22196#discussion_r1513265005 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConnectionPool.java: ## @@ -439,17 +451,16 @@ public void close() throws Exception { } }

Re: [PR] [improve][broker] add physicalAddress as part of connection pool key [pulsar]

2024-03-05 Thread via GitHub
lhotari commented on code in PR #22196: URL: https://github.com/apache/pulsar/pull/22196#discussion_r1513258739 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConnectionPool.java: ## @@ -439,17 +451,16 @@ public void close() throws Exception { } } -

Re: [PR] [improve][broker] add physicalAddress as part of connection pool key [pulsar]

2024-03-05 Thread via GitHub
lhotari commented on code in PR #22196: URL: https://github.com/apache/pulsar/pull/22196#discussion_r1513249636 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConnectionPool.java: ## @@ -439,17 +451,16 @@ public void close() throws Exception { } } -

Re: [PR] [feat][monitor] PIP-223: Add metrics for all rest endpoints. [pulsar]

2024-03-05 Thread via GitHub
dao-jun commented on code in PR #21772: URL: https://github.com/apache/pulsar/pull/21772#discussion_r1513225699 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/web/RestEndpointMetricsFilter.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (AS

(pulsar) annotated tag v3.1.3-candidate-1 updated (7e28e8404f5 -> e70f9cefd74)

2024-03-05 Thread rgao
This is an automated email from the ASF dual-hosted git repository. rgao pushed a change to annotated tag v3.1.3-candidate-1 in repository https://gitbox.apache.org/repos/asf/pulsar.git *** WARNING: tag v3.1.3-candidate-1 was modified! *** from 7e28e8404f5 (commit) to e70f9cefd74 (tag

Re: [PR] [improve][broker] add physicalAddress as part of connection pool key [pulsar]

2024-03-05 Thread via GitHub
dragosvictor commented on code in PR #22196: URL: https://github.com/apache/pulsar/pull/22196#discussion_r1513208595 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConnectionPool.java: ## @@ -459,11 +470,9 @@ public void doMarkAndReleaseUselessConnections(){

svn commit: r67746 - /release/pulsar/KEYS

2024-03-05 Thread lhotari
Author: lhotari Date: Tue Mar 5 17:21:03 2024 New Revision: 67746 Log: Added gpg key for rgao Modified: release/pulsar/KEYS Modified: release/pulsar/KEYS == --- release/pulsar/KEYS (original) +++ release/pulsar/KEYS

Re: [D] Add a "From zero to hero" contributor roadmap article to https://pulsar.apache.org/contribute/contributor-roadmap [pulsar]

2024-03-05 Thread via GitHub
GitHub user visortelle added a comment to the discussion: Add a "From zero to hero" contributor roadmap article to https://pulsar.apache.org/contribute/contributor-roadmap I think “Recommended ” fits better here. Therefore “Recommended Knowledge” until we haven't better options. GitHub lin

Re: [PR] Add more git tips to setup-mergetool.md [pulsar-site]

2024-03-05 Thread via GitHub
asafm commented on PR #824: URL: https://github.com/apache/pulsar-site/pull/824#issuecomment-1979245456 @lhotari I think it's more effective if people who have done the release and have all their experience would review this. @codelipenghui can recommend someone from his team -- This is

Re: [D] Add a "From zero to hero" contributor roadmap article to https://pulsar.apache.org/contribute/contributor-roadmap [pulsar]

2024-03-05 Thread via GitHub
GitHub user asafm added a comment to the discussion: Add a "From zero to hero" contributor roadmap article to https://pulsar.apache.org/contribute/contributor-roadmap Cool. Maybe "Prerequisite Knowledge"? or "Recommended Knowledge"? GitHub link: https://github.com/apache/pulsar/discussions/

Re: [PR] [feat][misc] PIP-264: Implement topic lookup metrics using OpenTelemetry [pulsar]

2024-03-05 Thread via GitHub
asafm commented on PR #22058: URL: https://github.com/apache/pulsar/pull/22058#issuecomment-1979228496 @lhotari You're up next on the review wrap up :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [D] Pulsar will not Run [pulsar]

2024-03-05 Thread via GitHub
GitHub user Ceyword added a comment to the discussion: Pulsar will not Run Yes @visortelle , that will be a very reasonable conclusion. GitHub link: https://github.com/apache/pulsar/discussions/22200#discussioncomment-8683012 This is an automatically sent email for commits@pulsar.apache.

Re: [D] Pulsar will not Run [pulsar]

2024-03-05 Thread via GitHub
GitHub user visortelle added a comment to the discussion: Pulsar will not Run So the process was killed just because of OOM? GitHub link: https://github.com/apache/pulsar/discussions/22200#discussioncomment-8682963 This is an automatically sent email for commits@pulsar.apache.org. To uns

Re: [D] Pulsar will not Run [pulsar]

2024-03-05 Thread via GitHub
GitHub user Ceyword added a comment to the discussion: Pulsar will not Run @jak78 , I installed JRE/JDK 17 as recommended here (https://github.com/apache/pulsar/blob/master/README.md#pulsar-runtime-java-version-recommendation). I have done this before, and ran pulsar from a laptop in developme

Re: [PR] [improve] PIP 342: Support OpenTelemetry metrics in Pulsar client [pulsar]

2024-03-05 Thread via GitHub
asafm commented on code in PR #22178: URL: https://github.com/apache/pulsar/pull/22178#discussion_r1513136592 ## pip/pip-342 OTel client metrics support.md: ## @@ -0,0 +1,201 @@ +# PIP 342: Support OpenTelemetry metrics in Pulsar client + +## Motivation + +Current support for me

Re: [D] Add a "From zero to hero" contributor roadmap article to https://pulsar.apache.org/contribute/contributor-roadmap [pulsar]

2024-03-05 Thread via GitHub
GitHub user visortelle added a comment to the discussion: Add a "From zero to hero" contributor roadmap article to https://pulsar.apache.org/contribute/contributor-roadmap Probably Contribute -> Development -> Developer Roadmap ![IMG_0472](https://github.com/apache/pulsar/assets/9302460/08056

Re: [D] Add a "From zero to hero" contributor roadmap article to https://pulsar.apache.org/contribute/contributor-roadmap [pulsar]

2024-03-05 Thread via GitHub
GitHub user asafm added a comment to the discussion: Add a "From zero to hero" contributor roadmap article to https://pulsar.apache.org/contribute/contributor-roadmap Where would you like to place this? GitHub link: https://github.com/apache/pulsar/discussions/22176#discussioncomment-868261

Re: [PR] [improve][broker] add physicalAddress as part of connection pool key [pulsar]

2024-03-05 Thread via GitHub
heesung-sn commented on code in PR #22196: URL: https://github.com/apache/pulsar/pull/22196#discussion_r1513106111 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConnectionPool.java: ## @@ -198,10 +199,18 @@ void closeAllConnections() { // succeed

(pulsar) branch branch-2.11 updated: [fix][test] Make base test class method protected so that it passes ReportUnannotatedMethods validation (#21976)

2024-03-05 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-2.11 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-2.11 by this push: new 855050880c1 [fix][test] Make base tes

Re: [PR] WIP: PIP-342: OTel client metrics support [pulsar]

2024-03-05 Thread via GitHub
merlimat commented on code in PR #22179: URL: https://github.com/apache/pulsar/pull/22179#discussion_r1513100988 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/BinaryProtoLookupService.java: ## @@ -84,6 +92,21 @@ public BinaryProtoLookupService(PulsarClientImpl cli

Re: [PR] [feat][misc] PIP-264: Implement topic lookup metrics using OpenTelemetry [pulsar]

2024-03-05 Thread via GitHub
dragosvictor commented on code in PR #22058: URL: https://github.com/apache/pulsar/pull/22058#discussion_r1513100646 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -153,35 +151,37 @@ public class NamespaceService implements AutoClo

Re: [PR] WIP: PIP-342: OTel client metrics support [pulsar]

2024-03-05 Thread via GitHub
merlimat commented on code in PR #22179: URL: https://github.com/apache/pulsar/pull/22179#discussion_r1513094996 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/BinaryProtoLookupService.java: ## @@ -84,6 +92,21 @@ public BinaryProtoLookupService(PulsarClientImpl cli

Re: [PR] WIP: PIP-342: OTel client metrics support [pulsar]

2024-03-05 Thread via GitHub
merlimat commented on code in PR #22179: URL: https://github.com/apache/pulsar/pull/22179#discussion_r1513086036 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java: ## @@ -258,11 +270,17 @@ public ClientCnx(ClientConfigurationData conf, EventLoopGroup e

Re: [PR] WIP: PIP-342: OTel client metrics support [pulsar]

2024-03-05 Thread via GitHub
merlimat commented on code in PR #22179: URL: https://github.com/apache/pulsar/pull/22179#discussion_r1513085236 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java: ## @@ -386,7 +402,30 @@ protected ConsumerImpl(PulsarClientImpl client, String topic,

Re: [PR] WIP: PIP-342: OTel client metrics support [pulsar]

2024-03-05 Thread via GitHub
merlimat commented on code in PR #22179: URL: https://github.com/apache/pulsar/pull/22179#discussion_r1513081438 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java: ## @@ -268,6 +283,23 @@ public ProducerImpl(PulsarClientImpl client, String topic, Pr

Re: [PR] [improve][client] add externalListenerThreadName parameter [pulsar]

2024-03-05 Thread via GitHub
lhotari commented on PR #22174: URL: https://github.com/apache/pulsar/pull/22174#issuecomment-1979083454 I'd suggest renaming `externalListenerThreadName` to `externalListenerThreadNamePrefix`. The value is currently passed to io.netty.util.concurrent.DefaultThreadFactory under the c

svn commit: r67742 - /dev/pulsar/pulsar-3.1.3-candidate-1/apache-pulsar-3.1.3-bin.tar.gz

2024-03-05 Thread rgao
Author: rgao Date: Tue Mar 5 15:49:45 2024 New Revision: 67742 Log: Staging artifacts and signature for Pulsar release 3.1.3 Added: dev/pulsar/pulsar-3.1.3-candidate-1/apache-pulsar-3.1.3-bin.tar.gz (with props) Added: dev/pulsar/pulsar-3.1.3-candidate-1/apache-pulsar-3.1.3-bin.tar.gz ==

Re: [PR] Add more git tips to setup-mergetool.md [pulsar-site]

2024-03-05 Thread via GitHub
visortelle commented on PR #824: URL: https://github.com/apache/pulsar-site/pull/824#issuecomment-1979012207 > Perhaps we need to reorganize the content and add another page for this information? If we keep the `setup-mergetool.md` page name, then agree, it is better to create new `g

svn commit: r67734 [1/2] - in /dev/pulsar/pulsar-2.10.6-candidate-1: ./ connectors/

2024-03-05 Thread technoboy
Author: technoboy Date: Tue Mar 5 15:10:25 2024 New Revision: 67734 Log: Staging artifacts and signature for Pulsar release 2.10.6-1 Added: dev/pulsar/pulsar-2.10.6-candidate-1/ dev/pulsar/pulsar-2.10.6-candidate-1/apache-pulsar-2.10.6-bin.tar.gz (with props) dev/pulsar/pulsar-2.1

svn commit: r67734 [2/2] - in /dev/pulsar/pulsar-2.10.6-candidate-1: ./ connectors/

2024-03-05 Thread technoboy
Added: dev/pulsar/pulsar-2.10.6-candidate-1/connectors/pulsar-io-kinesis-2.10.6.nar.sha512 == --- dev/pulsar/pulsar-2.10.6-candidate-1/connectors/pulsar-io-kinesis-2.10.6.nar.sha512 (added) +++ dev/pulsar/pulsar-2.10.6-

Re: [PR] Remove `VERSION` and `stable.txt` files [pulsar-client-go]

2024-03-05 Thread via GitHub
BewareMyPower commented on PR #1158: URL: https://github.com/apache/pulsar-client-go/pull/1158#issuecomment-1978976123 Could you resolve the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Add more git tips to setup-mergetool.md [pulsar-site]

2024-03-05 Thread via GitHub
lhotari commented on code in PR #824: URL: https://github.com/apache/pulsar-site/pull/824#discussion_r1512978470 ## contribute/setup-mergetool.md: ## @@ -90,6 +90,78 @@ sudo apt install git-gui There are many tools available for this purpose, but `git gui` is one of the simp

Re: [PR] Add more git tips to setup-mergetool.md [pulsar-site]

2024-03-05 Thread via GitHub
visortelle commented on code in PR #824: URL: https://github.com/apache/pulsar-site/pull/824#discussion_r1512957875 ## contribute/setup-mergetool.md: ## @@ -90,6 +90,78 @@ sudo apt install git-gui There are many tools available for this purpose, but `git gui` is one of the s

Re: [PR] Add more git tips to setup-mergetool.md [pulsar-site]

2024-03-05 Thread via GitHub
lhotari commented on code in PR #824: URL: https://github.com/apache/pulsar-site/pull/824#discussion_r1512971714 ## contribute/setup-mergetool.md: ## @@ -90,6 +90,78 @@ sudo apt install git-gui There are many tools available for this purpose, but `git gui` is one of the simp

Re: [PR] Add more git tips to setup-mergetool.md [pulsar-site]

2024-03-05 Thread via GitHub
visortelle commented on code in PR #824: URL: https://github.com/apache/pulsar-site/pull/824#discussion_r1512957875 ## contribute/setup-mergetool.md: ## @@ -90,6 +90,78 @@ sudo apt install git-gui There are many tools available for this purpose, but `git gui` is one of the s

Re: [PR] Add more git tips to setup-mergetool.md [pulsar-site]

2024-03-05 Thread via GitHub
visortelle commented on code in PR #824: URL: https://github.com/apache/pulsar-site/pull/824#discussion_r1512957875 ## contribute/setup-mergetool.md: ## @@ -90,6 +90,78 @@ sudo apt install git-gui There are many tools available for this purpose, but `git gui` is one of the s

Re: [PR] Add more git tips to setup-mergetool.md [pulsar-site]

2024-03-05 Thread via GitHub
visortelle commented on code in PR #824: URL: https://github.com/apache/pulsar-site/pull/824#discussion_r1512957875 ## contribute/setup-mergetool.md: ## @@ -90,6 +90,78 @@ sudo apt install git-gui There are many tools available for this purpose, but `git gui` is one of the s

Re: [PR] Add more git tips to setup-mergetool.md [pulsar-site]

2024-03-05 Thread via GitHub
visortelle commented on code in PR #824: URL: https://github.com/apache/pulsar-site/pull/824#discussion_r1512957875 ## contribute/setup-mergetool.md: ## @@ -90,6 +90,78 @@ sudo apt install git-gui There are many tools available for this purpose, but `git gui` is one of the s

Re: [D] Feasibility of Integrating Spring into Pulsar Sink Connector [pulsar]

2024-03-05 Thread via GitHub
GitHub user lhotari added a comment to the discussion: Feasibility of Integrating Spring into Pulsar Sink Connector @onobc any comments on integrating Spring into a Pulsar Sink Connector? GitHub link: https://github.com/apache/pulsar/discussions/22052#discussioncomment-8681355 This is a

Re: [D] getMessageIdFromTimestamp Timeout issues [pulsar]

2024-03-05 Thread via GitHub
GitHub user lhotari edited a comment on the discussion: getMessageIdFromTimestamp Timeout issues @KannarFr There's no way to increase `idleTimeout` in AdminProxyHandler by configuration alone. It would require code changes to address that. `idleTimeout` is documented in Jetty as "the max tim

Re: [D] getMessageIdFromTimestamp Timeout issues [pulsar]

2024-03-05 Thread via GitHub
GitHub user lhotari added a comment to the discussion: getMessageIdFromTimestamp Timeout issues @KannarFr There's no way to increase `idleTimeout` in AdminProxyHandler by configuration alone. It would require code changes to address that. `idleTimeout` is documented in Jetty as "the max time

Re: [PR] Add more git tips to setup-mergetool.md [pulsar-site]

2024-03-05 Thread via GitHub
visortelle commented on code in PR #824: URL: https://github.com/apache/pulsar-site/pull/824#discussion_r1512903123 ## contribute/setup-mergetool.md: ## @@ -90,6 +90,78 @@ sudo apt install git-gui There are many tools available for this purpose, but `git gui` is one of the s

Re: [D] Pulsar will not Run [pulsar]

2024-03-05 Thread via GitHub
GitHub user visortelle edited a comment on the discussion: Pulsar will not Run Agree. It would simplify getting started a lot. Single command instead of multiple. Also "Pulsar cluster locally" and "Deploy a cluster on bare metal" pages don't describe steps (or have links to an article) on how

Re: [D] Pulsar will not Run [pulsar]

2024-03-05 Thread via GitHub
GitHub user visortelle added a comment to the discussion: Pulsar will not Run Agree. It would simplify getting started a lot. Single command instead of multiple. Also "Pulsar cluster locally" and "Deploy a cluster on bare metal" don't describe steps (or have links to an article) on how to prop

Re: [D] getMessageIdFromTimestamp Timeout issues [pulsar]

2024-03-05 Thread via GitHub
GitHub user lhotari added a comment to the discussion: getMessageIdFromTimestamp Timeout issues This is not an answer to your question, but a comment about the underlying problem. There's an issue https://github.com/apache/pulsar/issues/22129 requesting optimization of seeking by timestamp.

Re: [PR] Add more git tips to setup-mergetool.md [pulsar-site]

2024-03-05 Thread via GitHub
visortelle commented on code in PR #824: URL: https://github.com/apache/pulsar-site/pull/824#discussion_r1512909507 ## contribute/setup-mergetool.md: ## @@ -90,6 +90,78 @@ sudo apt install git-gui There are many tools available for this purpose, but `git gui` is one of the s

Re: [D] Pulsar will not Run [pulsar]

2024-03-05 Thread via GitHub
GitHub user lhotari added a comment to the discussion: Pulsar will not Run It's recommended to run Pulsar in Docker in developer environments. Please follow the instructions at https://pulsar.apache.org/docs/3.2.x/getting-started-docker/ . @visortelle @jak78 Perhaps we should make this the de

Re: [PR] Add more git tips to setup-mergetool.md [pulsar-site]

2024-03-05 Thread via GitHub
visortelle commented on code in PR #824: URL: https://github.com/apache/pulsar-site/pull/824#discussion_r1512903123 ## contribute/setup-mergetool.md: ## @@ -90,6 +90,78 @@ sudo apt install git-gui There are many tools available for this purpose, but `git gui` is one of the s

Re: [PR] Add more git tips to setup-mergetool.md [pulsar-site]

2024-03-05 Thread via GitHub
visortelle commented on code in PR #824: URL: https://github.com/apache/pulsar-site/pull/824#discussion_r1512909507 ## contribute/setup-mergetool.md: ## @@ -90,6 +90,78 @@ sudo apt install git-gui There are many tools available for this purpose, but `git gui` is one of the s

Re: [PR] Add more git tips to setup-mergetool.md [pulsar-site]

2024-03-05 Thread via GitHub
visortelle commented on code in PR #824: URL: https://github.com/apache/pulsar-site/pull/824#discussion_r1512909507 ## contribute/setup-mergetool.md: ## @@ -90,6 +90,78 @@ sudo apt install git-gui There are many tools available for this purpose, but `git gui` is one of the s

Re: [PR] Add more git tips to setup-mergetool.md [pulsar-site]

2024-03-05 Thread via GitHub
visortelle commented on code in PR #824: URL: https://github.com/apache/pulsar-site/pull/824#discussion_r1512909507 ## contribute/setup-mergetool.md: ## @@ -90,6 +90,78 @@ sudo apt install git-gui There are many tools available for this purpose, but `git gui` is one of the s

Re: [PR] Add more git tips to setup-mergetool.md [pulsar-site]

2024-03-05 Thread via GitHub
visortelle commented on code in PR #824: URL: https://github.com/apache/pulsar-site/pull/824#discussion_r1512909507 ## contribute/setup-mergetool.md: ## @@ -90,6 +90,78 @@ sudo apt install git-gui There are many tools available for this purpose, but `git gui` is one of the s

Re: [PR] Add more git tips to setup-mergetool.md [pulsar-site]

2024-03-05 Thread via GitHub
visortelle commented on code in PR #824: URL: https://github.com/apache/pulsar-site/pull/824#discussion_r1512909507 ## contribute/setup-mergetool.md: ## @@ -90,6 +90,78 @@ sudo apt install git-gui There are many tools available for this purpose, but `git gui` is one of the s

Re: [PR] Add more git tips to setup-mergetool.md [pulsar-site]

2024-03-05 Thread via GitHub
visortelle commented on code in PR #824: URL: https://github.com/apache/pulsar-site/pull/824#discussion_r1512909507 ## contribute/setup-mergetool.md: ## @@ -90,6 +90,78 @@ sudo apt install git-gui There are many tools available for this purpose, but `git gui` is one of the s

Re: [PR] [fix][client] fix Reader.hasMessageAvailable might return true after seeking to latest [pulsar]

2024-03-05 Thread via GitHub
BewareMyPower commented on code in PR #22201: URL: https://github.com/apache/pulsar/pull/22201#discussion_r1512907076 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java: ## @@ -2279,14 +2287,25 @@ private void seekAsyncInternal(long requestId, ByteBuf

Re: [PR] Add more git tips to setup-mergetool.md [pulsar-site]

2024-03-05 Thread via GitHub
visortelle commented on code in PR #824: URL: https://github.com/apache/pulsar-site/pull/824#discussion_r1512904094 ## contribute/setup-mergetool.md: ## @@ -90,6 +90,78 @@ sudo apt install git-gui There are many tools available for this purpose, but `git gui` is one of the s

Re: [PR] Add more git tips to setup-mergetool.md [pulsar-site]

2024-03-05 Thread via GitHub
visortelle commented on code in PR #824: URL: https://github.com/apache/pulsar-site/pull/824#discussion_r1512903123 ## contribute/setup-mergetool.md: ## @@ -90,6 +90,78 @@ sudo apt install git-gui There are many tools available for this purpose, but `git gui` is one of the s

[PR] Add more git tips to setup-mergetool.md [pulsar-site]

2024-03-05 Thread via GitHub
lhotari opened a new pull request, #824: URL: https://github.com/apache/pulsar-site/pull/824 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] [feat][misc] PIP-264: Implement topic lookup metrics using OpenTelemetry [pulsar]

2024-03-05 Thread via GitHub
asafm commented on code in PR #22058: URL: https://github.com/apache/pulsar/pull/22058#discussion_r1512441743 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java: ## @@ -153,35 +151,37 @@ public class NamespaceService implements AutoCloseable

  1   2   >