Re: [PR] [improve][client] Add maxConnectionsPerHost and connectionMaxIdleSeconds to PulsarAdminBuilder [pulsar]

2024-04-22 Thread via GitHub
lhotari commented on PR #22541: URL: https://github.com/apache/pulsar/pull/22541#issuecomment-2071568113 There's a problem with backpressure handling with async requests in the Pulsar code base. Since this PR limits the Pulsar Admin client to 16 connections per host, it now shows up prob

Re: [I] customRuntimeOptions in "Creates a new Pulsar Source in cluster mode" API call in source connector doesn't add nodeselectors & tolerations [pulsar-helm-chart]

2024-04-22 Thread via GitHub
kunjbosamiaFalkonry commented on issue #394: URL: https://github.com/apache/pulsar-helm-chart/issues/394#issuecomment-2071520742 > Related to #382 In this issue , you suggested to configure things by passing values to broker's config map. which i did ``` PF_runtimeCustomizerCla

[PR] [fix][ci] Don't allow merging PR without successful result [pulsar]

2024-04-22 Thread via GitHub
lhotari opened a new pull request, #22563: URL: https://github.com/apache/pulsar/pull/22563 ### Motivation Currently it's possible to merge a PR when it hasn't been approved at all and no tests have run. The reason for this is that the required job gets skipped in this case.

Re: [PR] [improve] [broker] add role for consumer stat [pulsar]

2024-04-22 Thread via GitHub
BewareMyPower commented on code in PR #22562: URL: https://github.com/apache/pulsar/pull/22562#discussion_r1575706071 ## pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/ConsumerStats.java: ## @@ -25,6 +25,9 @@ * Consumer statistics. */ public in

Re: [PR] [improve] PIP-307: Use assigned broker URL hints during broker reconnection [pulsar-client-go]

2024-04-22 Thread via GitHub
dragosvictor commented on code in PR #1208: URL: https://github.com/apache/pulsar-client-go/pull/1208#discussion_r1575673797 ## pulsar/producer_partition.go: ## @@ -429,12 +453,22 @@ func (p *partitionProducer) reconnectToBroker() { return

Re: [PR] [improve][broker] Make BrokerSelectionStrategy pluggable [pulsar]

2024-04-22 Thread via GitHub
BewareMyPower commented on PR #22553: URL: https://github.com/apache/pulsar/pull/22553#issuecomment-2071455028 ``` Error: Failures: Error: org.apache.pulsar.broker.loadbalance.extensions.strategy.CustomBrokerSelectionStrategyTest.testSingleBrokerSelected [INFO] Run 1: PAS

(pulsar) branch master updated: [improve][broker] Apply loadBalancerDebugModeEnabled in LeastResourceUsageWithWeight (#22549)

2024-04-22 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 882ce415c94 [improve][broker] Apply loadBalancerDeb

Re: [PR] [improve][broker] Apply loadBalancerDebugModeEnabled in LeastResourceUsageWithWeight [pulsar]

2024-04-22 Thread via GitHub
BewareMyPower merged PR #22549: URL: https://github.com/apache/pulsar/pull/22549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pul

Re: [PR] [improve] [broker] add role for consumer stat [pulsar]

2024-04-22 Thread via GitHub
thetumbled commented on PR #22562: URL: https://github.com/apache/pulsar/pull/22562#issuecomment-2071376117 PTAL, thanks. @lhotari @codelipenghui @BewareMyPower @Technoboy- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [improve] PIP-307: Use assigned broker URL hints during broker reconnection [pulsar-client-go]

2024-04-22 Thread via GitHub
BewareMyPower commented on code in PR #1208: URL: https://github.com/apache/pulsar-client-go/pull/1208#discussion_r1575606991 ## pulsar/producer_partition.go: ## @@ -429,12 +453,22 @@ func (p *partitionProducer) reconnectToBroker() { return

[PR] [improve] [broker] add role for consumer stat [pulsar]

2024-04-22 Thread via GitHub
thetumbled opened a new pull request, #22562: URL: https://github.com/apache/pulsar/pull/22562 ### Motivation By config `allowAutoSubscriptionCreation`, we allow uses to create subscriptions automatically if user have the `consume` permission. We have a strong need to trace back who

Re: [PR] [improve] [broker] add role for consumer stat [pulsar]

2024-04-22 Thread via GitHub
thetumbled closed pull request #22561: [improve] [broker] add role for consumer stat URL: https://github.com/apache/pulsar/pull/22561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[PR] [improve] [broker] add role for consumer stat [pulsar]

2024-04-22 Thread via GitHub
thetumbled opened a new pull request, #22561: URL: https://github.com/apache/pulsar/pull/22561 ### Motivation By config `allowAutoSubscriptionCreation`, we allow uses to create subscriptions automatically if user have the `consume` permission. We have a strong need to trace back

Re: [PR] [fix][fn]make sure the classloader for ContextImpl is `functionClassLoader` in different runtimes [pulsar]

2024-04-22 Thread via GitHub
Awsmsniper commented on PR #22501: URL: https://github.com/apache/pulsar/pull/22501#issuecomment-2071364851 > @Awsmsniper it should be another issue, could you please create a new issue first? > > Also, https://hub.docker.com/layers/freeznet/pulsar-all/3.0.5-SNAPSHOT-1c46877/images/s

Re: [PR] [improve][broker] Exclude producers for geo-replication from publishers field of topic stats [pulsar]

2024-04-22 Thread via GitHub
massakam commented on PR #22556: URL: https://github.com/apache/pulsar/pull/22556#issuecomment-2071325099 Resolved the conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [improve] PIP-307: Use assigned broker URL hints during broker reconnection [pulsar-client-go]

2024-04-22 Thread via GitHub
BewareMyPower commented on code in PR #1208: URL: https://github.com/apache/pulsar-client-go/pull/1208#discussion_r1575573046 ## pulsar/internal/pulsar_proto/PulsarApi.pb.go: ## @@ -18,8 +18,8 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // versions: -// protoc-ge

[PR] [improve][ml] Make ManagedLedger read entries parallel [pulsar]

2024-04-22 Thread via GitHub
dao-jun opened a new pull request, #22560: URL: https://github.com/apache/pulsar/pull/22560 ### Motivation In https://github.com/apache/pulsar/pull/19035 we introduced `skipCondition` to filter-out delay delivery messages before read entries from Bookkeeper, and in https://github.com

(pulsar-site) branch main updated: Docs sync done from apache/pulsar (#4924052)

2024-04-22 Thread urfree
This is an automated email from the ASF dual-hosted git repository. urfree pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/pulsar-site.git The following commit(s) were added to refs/heads/main by this push: new eaf427144d02 Docs sync done from apache/pulsar

(pulsar) branch master updated: [fix] [broker] Part-1: Replicator can not created successfully due to an orphan replicator in the previous topic owner (#21946)

2024-04-22 Thread yubiao
This is an automated email from the ASF dual-hosted git repository. yubiao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 49240522f54 [fix] [broker] Part-1: Replicator ca

Re: [PR] [fix] [broker] Part-1: Replicator can not created successfully due to an orphan replicator in the previous topic owner [pulsar]

2024-04-22 Thread via GitHub
poorbarcode merged PR #21946: URL: https://github.com/apache/pulsar/pull/21946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsa

Re: [PR] [improve][broker] Exclude producers for geo-replication from publishers field of topic stats [pulsar]

2024-04-22 Thread via GitHub
massakam commented on PR #22556: URL: https://github.com/apache/pulsar/pull/22556#issuecomment-2071211652 @lhotari PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [improve][broker] Exclude producers for geo-replication from publishers field of topic stats [pulsar]

2024-04-22 Thread via GitHub
codecov-commenter commented on PR #22556: URL: https://github.com/apache/pulsar/pull/22556#issuecomment-2071211068 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/22556?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] [feat][broker] PIP-264: Add topic messaging metrics [pulsar]

2024-04-22 Thread via GitHub
merlimat commented on PR #22467: URL: https://github.com/apache/pulsar/pull/22467#issuecomment-2071140865 @dragosvictor I think we shouldn't worry about v1 topic names, these were deprecated long ago we should actually start to get rid of them completely. > The topic name, as is curre

Re: [PR] [feat][broker] PIP-264: Add topic messaging metrics [pulsar]

2024-04-22 Thread via GitHub
dragosvictor commented on PR #22467: URL: https://github.com/apache/pulsar/pull/22467#issuecomment-2071044457 > Changes look good. > > My only comment is that we should be using qualified names in the attributes: > > > pulsar.namespace Includes the namespace portion only my

(pulsar) branch master updated: [improve] Update Oxia client to 0.1.6 (#22525)

2024-04-22 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new c72c135541e [improve] Update Oxia client to 0.1.

Re: [PR] [improve] Update Oxia client to 0.1.6 [pulsar]

2024-04-22 Thread via GitHub
merlimat merged PR #22525: URL: https://github.com/apache/pulsar/pull/22525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.a

Re: [PR] [improve] Update Oxia client to 0.1.6 [pulsar]

2024-04-22 Thread via GitHub
merlimat commented on PR #22525: URL: https://github.com/apache/pulsar/pull/22525#issuecomment-2070940582 > ``` > LockManagerTest.acquireLocks:66 ยป NoClassDefFound Could not initialize class io.streamnative.oxia.proto.ListResponse > ``` This was due to protobuf version conflicts

[I] [Bug] broker healthcheck ran into loop after decommissioned a cluster of bookies [pulsar]

2024-04-22 Thread via GitHub
wallacepeng opened a new issue, #22559: URL: https://github.com/apache/pulsar/issues/22559 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Read release policy - [X] I understand that un

Re: [I] [Bug] broker healthcheck ran into loop after decommissioned a cluster of bookies [pulsar]

2024-04-22 Thread via GitHub
wallacepeng commented on issue #22559: URL: https://github.com/apache/pulsar/issues/22559#issuecomment-2070891379 https://github.com/apache/pulsar/assets/894641/f8879642-e3e2-40b1-b063-308e957e693a";> -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [I] Argo CD unable to generate template with pulsar chart 3.3.0 [pulsar-helm-chart]

2024-04-22 Thread via GitHub
hpvd commented on issue #471: URL: https://github.com/apache/pulsar-helm-chart/issues/471#issuecomment-2070823328 3.4.0 version of the Apache Pulsar Helm chart is now available: https://github.com/apache/pulsar-helm-chart/releases/tag/pulsar-3.4.0 -- This is an automated message from t

Re: [D] Pulsar 3.2.2 correct Message send to InfluxDBv2 sink connector with Python Producer [pulsar]

2024-04-22 Thread via GitHub
GitHub user smuehlmann edited a discussion: Pulsar 3.2.2 correct Message send to InfluxDBv2 sink connector with Python Producer Hi, i have problems to send a message with a python producer which should be processed by an InfluxDBv2 sink connector. With a java test code it is possible. Java

Re: [D] Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer [pulsar]

2024-04-22 Thread via GitHub
GitHub user smuehlmann edited a discussion: Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer Hi, i have problems to send a message with a python producer which should be processed by an InfluxDBv2 sink connector. With a java test code it is possible.

Re: [D] Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer [pulsar]

2024-04-22 Thread via GitHub
GitHub user smuehlmann edited a discussion: Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer Hi, i have problems to send a message with a python producer which should be processed by an InfluxDBv2 sink connector. With a java test code it is possible.

Re: [D] Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer [pulsar]

2024-04-22 Thread via GitHub
GitHub user smuehlmann edited a discussion: Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer Hi, i have problems to send a message with a python producer which should be processed by an InfluxDBv2 sink connector. With a java test code it is possible.

Re: [D] Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer [pulsar]

2024-04-22 Thread via GitHub
GitHub user smuehlmann edited a discussion: Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer Hi, i have problems to send a message with a python producer which should be processed by an InfluxDBv2 sink connector. With a java test code it is possible.

Re: [D] Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer [pulsar]

2024-04-22 Thread via GitHub
GitHub user smuehlmann edited a discussion: Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer Hi, i have problems to send a message with a python producer which should be processed by an InfluxDBv2 sink connector. With a java test code it is possible.

Re: [D] Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer [pulsar]

2024-04-22 Thread via GitHub
GitHub user smuehlmann edited a discussion: Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer Hi, i have problems to send a message with a python producer which should be processed by an InfluxDBv2 sink connector. With a java test code it is possible.

Re: [D] Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer [pulsar]

2024-04-22 Thread via GitHub
GitHub user smuehlmann edited a discussion: Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer Hi, i have problems to send a message with a python producer which should be processed by an InfluxDBv2 sink connector. With a java test code it is possible.

Re: [D] Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer [pulsar]

2024-04-22 Thread via GitHub
GitHub user smuehlmann edited a discussion: Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer Hi, i have problems to send a message with a python producer which should be processed by an InfluxDBv2 sink connector. With a java test code it is possible.

Re: [D] Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer [pulsar]

2024-04-22 Thread via GitHub
GitHub user smuehlmann edited a discussion: Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer Hi, i have problems to send a message with a python producer which should be processed by an InfluxDBv2 sink connector. With a java test code it is possible.

Re: [D] Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer [pulsar]

2024-04-22 Thread via GitHub
GitHub user smuehlmann edited a discussion: Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer Hi, i have problems to send a message with a python producer which should be processed by an InfluxDBv2 sink connector. With a java test code it is possible.

Re: [D] Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer [pulsar]

2024-04-22 Thread via GitHub
GitHub user smuehlmann edited a discussion: Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer Hi, i have problems to send a message with a python producer which should be processed by an InfluxDBv2 sink connector. With a java test code it is possible.

Re: [D] Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer [pulsar]

2024-04-22 Thread via GitHub
GitHub user smuehlmann edited a discussion: Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer Hi, i have problems to send a message with a python producer which should be processed by an InfluxDBv2 sink connector. With a java test code it is possible.

Re: [D] Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer [pulsar]

2024-04-22 Thread via GitHub
GitHub user smuehlmann edited a discussion: Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer Hi, i have problems to send a message with a python producer which should be processed by an InfluxDBv2 sink connector. With a java test code it is possible.

Re: [D] Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer [pulsar]

2024-04-22 Thread via GitHub
GitHub user smuehlmann edited a discussion: Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer Hi, i have problems to send a message with a python producer which should be processed by an InfluxDBv2 sink connector. With a java test code it is possible.

Re: [D] Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer [pulsar]

2024-04-22 Thread via GitHub
GitHub user smuehlmann edited a discussion: Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer Hi, i have problems to send a message with a python producer which should be processed by an InfluxDBv2 sink connector. With a java test code it is possible.

Re: [D] Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer [pulsar]

2024-04-22 Thread via GitHub
GitHub user smuehlmann edited a discussion: Pulsar 3.2.2 correct Message Format send to InfluxDBv2 sink connector with Python Producer Hi, i have problems to send a message with a python producer which should be processed by an InfluxDBv2 sink connector. With a java test code it is possible.

Re: [PR] [improve] PIP-307: Use assigned broker URL hints during broker reconnection [pulsar-client-go]

2024-04-22 Thread via GitHub
dragosvictor commented on code in PR #1208: URL: https://github.com/apache/pulsar-client-go/pull/1208#discussion_r1575129127 ## pulsar/internal/lookup_service.go: ## @@ -30,8 +30,9 @@ import ( // LookupResult encapsulates a struct for lookup a request, containing two parts:

Re: [PR] [improve][client] Add maxConnectionsPerHost and connectionMaxIdleSeconds to PulsarAdminBuilder [pulsar]

2024-04-22 Thread via GitHub
lhotari commented on PR #22541: URL: https://github.com/apache/pulsar/pull/22541#issuecomment-2070268832 the `setMaxConnectionsPerHost` in async http client doesn't seem to behave as expected. Will check the errors ``` Caused by: java.util.concurrent.CompletionException: org.apache.

Re: [PR] [improve][broker] Exclude producers for geo-replication from publishers field of topic stats [pulsar]

2024-04-22 Thread via GitHub
massakam commented on code in PR #22556: URL: https://github.com/apache/pulsar/pull/22556#discussion_r1575095343 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentTopic.java: ## @@ -745,8 +746,7 @@ public void updateRates(NamespaceStats n

Re: [PR] [improve] PIP-307: Use assigned broker URL hints during broker reconnection [pulsar-client-go]

2024-04-22 Thread via GitHub
dragosvictor commented on code in PR #1208: URL: https://github.com/apache/pulsar-client-go/pull/1208#discussion_r1575070621 ## pulsar/internal/pulsar_proto/PulsarApi.pb.go: ## @@ -18,8 +18,8 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // versions: -// protoc-gen

Re: [PR] [improve] PIP-307: Use assigned broker URL hints during broker reconnection [pulsar-client-go]

2024-04-22 Thread via GitHub
dragosvictor commented on code in PR #1208: URL: https://github.com/apache/pulsar-client-go/pull/1208#discussion_r1575072107 ## pulsar/producer_partition.go: ## @@ -373,10 +390,14 @@ func (p *partitionProducer) GetBuffer() internal.Buffer { return b } -func (p *partit

[PR] [improve][cli] Add generate-completion command to admin and client [pulsar]

2024-04-22 Thread via GitHub
nodece opened a new pull request, #22557: URL: https://github.com/apache/pulsar/pull/22557 ### Motivation The tab-completion is a important feature, we migrate the CLI parser to picocli from jcommander, right now we can use the picocli autocomplete to do that. - pulsar-admin

(pulsar) branch master updated: [improve][misc] Upgrade to Bookkeeper 4.17.0 (#22551)

2024-04-22 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new a037fa33eee [improve][misc] Upgrade to Bookkeepe

Re: [PR] [improve][misc] Upgrade to Bookkeeper 4.17.0 [pulsar]

2024-04-22 Thread via GitHub
merlimat merged PR #22551: URL: https://github.com/apache/pulsar/pull/22551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.a

Re: [PR] [improve][broker] Exclude producers for geo-replication from publishers field of topic stats [pulsar]

2024-04-22 Thread via GitHub
lhotari commented on code in PR #22556: URL: https://github.com/apache/pulsar/pull/22556#discussion_r1575054920 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java: ## @@ -2107,8 +2108,7 @@ public void updateRates(NamespaceStats nsStat

Re: [PR] [improve][broker] Exclude producers for geo-replication from publishers field of topic stats [pulsar]

2024-04-22 Thread via GitHub
lhotari commented on code in PR #22556: URL: https://github.com/apache/pulsar/pull/22556#discussion_r1575054611 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentTopic.java: ## @@ -745,8 +746,7 @@ public void updateRates(NamespaceStats ns

(pulsar) branch branch-3.2 updated (a3122b106fc -> 01671b16417)

2024-04-22 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a change to branch branch-3.2 in repository https://gitbox.apache.org/repos/asf/pulsar.git from a3122b106fc [fix][ml] Fix NPE of getValidPositionAfterSkippedEntries when recovering a terminated managed ledger

(pulsar) 02/02: [fix][offload] Increase file upload limit from 2048MiB to 4096MiB for GCP/GCS offloading (#22554)

2024-04-22 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.2 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 01671b16417f553a6bf51257ed74202656339d83 Author: Lari Hotari AuthorDate: Mon Apr 22 18:13:45 2024 +0300 [fix][

(pulsar) 01/02: [fix][broker] upgrade jclouds 2.5.0 -> 2.6.0 (#22220)

2024-04-22 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.2 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 83a243c4df4f5a8492d0fa3850f14ab3db1051a5 Author: Paul Gier AuthorDate: Fri Mar 15 09:46:33 2024 -0500 [fix][br

(pulsar) 02/02: [fix][offload] Increase file upload limit from 2048MiB to 4096MiB for GCP/GCS offloading (#22554)

2024-04-22 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.1 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 1c8fd73b9c2c72cd91297723d6681dcaff82d8e7 Author: Lari Hotari AuthorDate: Mon Apr 22 18:13:45 2024 +0300 [fix][

(pulsar) 01/02: [fix][broker] upgrade jclouds 2.5.0 -> 2.6.0 (#22220)

2024-04-22 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.1 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 48ff241a45d795d9dbd64aa9377c42f67219ecaa Author: Paul Gier AuthorDate: Fri Mar 15 09:46:33 2024 -0500 [fix][br

(pulsar) branch branch-3.1 updated (6be74f1adaf -> 1c8fd73b9c2)

2024-04-22 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a change to branch branch-3.1 in repository https://gitbox.apache.org/repos/asf/pulsar.git from 6be74f1adaf [fix][ml] Fix NPE of getValidPositionAfterSkippedEntries when recovering a terminated managed ledger

(pulsar) branch branch-3.0 updated (def695b18b2 -> 5c09c20b33c)

2024-04-22 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a change to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git from def695b18b2 [fix][ml] Fix NPE of getValidPositionAfterSkippedEntries when recovering a terminated managed ledger

(pulsar) 01/02: [fix][broker] upgrade jclouds 2.5.0 -> 2.6.0 (#22220)

2024-04-22 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit fc136e8fe11e3a16477ca92784debe592c1d8568 Author: Paul Gier AuthorDate: Fri Mar 15 09:46:33 2024 -0500 [fix][br

(pulsar) 02/02: [fix][offload] Increase file upload limit from 2048MiB to 4096MiB for GCP/GCS offloading (#22554)

2024-04-22 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git commit 5c09c20b33c8e9563df82b4f510fe1d7b519f33c Author: Lari Hotari AuthorDate: Mon Apr 22 18:13:45 2024 +0300 [fix][

(pulsar) branch branch-3.2 updated: [fix][ml] Fix NPE of getValidPositionAfterSkippedEntries when recovering a terminated managed ledger (#22552)

2024-04-22 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.2 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.2 by this push: new a3122b106fc [fix][ml] Fix NPE of getVal

(pulsar) branch branch-3.0 updated: [fix][ml] Fix NPE of getValidPositionAfterSkippedEntries when recovering a terminated managed ledger (#22552)

2024-04-22 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new def695b18b2 [fix][ml] Fix NPE of getVal

(pulsar) branch branch-3.1 updated: [fix][ml] Fix NPE of getValidPositionAfterSkippedEntries when recovering a terminated managed ledger (#22552)

2024-04-22 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch branch-3.1 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.1 by this push: new 6be74f1adaf [fix][ml] Fix NPE of getVal

Re: [PR] [fix][broker] Create new ledger after the current ledger is closed [pulsar]

2024-04-22 Thread via GitHub
lhotari commented on PR #22034: URL: https://github.com/apache/pulsar/pull/22034#issuecomment-2070058523 When cherry-picking, it's important to also pick #22552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

(pulsar-client-go) branch dependabot/go_modules/golang.org/x/net-0.23.0 deleted (was 43818365)

2024-04-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/go_modules/golang.org/x/net-0.23.0 in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git was 43818365 chore(deps): bump golang.org/x/net from 0.17.0 to 0.23.

(pulsar-client-go) branch master updated (b4d45cd3 -> 458defe3)

2024-04-22 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git from b4d45cd3 [Improve] Add admin api GetLeaderBroker (#1203) add 458defe3 chore(deps): bump golang.org/x/ne

Re: [PR] chore(deps): bump golang.org/x/net from 0.17.0 to 0.23.0 [pulsar-client-go]

2024-04-22 Thread via GitHub
merlimat merged PR #1209: URL: https://github.com/apache/pulsar-client-go/pull/1209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

(pulsar) branch master updated (e81f37000ec -> 35599b73253)

2024-04-22 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from e81f37000ec [fix][offload] Increase file upload limit from 2048MiB to 4096MiB for GCP/GCS offloading (#22554) a

Re: [PR] [fix][ml] Fix NPE of getValidPositionAfterSkippedEntries when recovering a terminated managed ledger [pulsar]

2024-04-22 Thread via GitHub
lhotari merged PR #22552: URL: https://github.com/apache/pulsar/pull/22552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

(pulsar) branch master updated: [fix][offload] Increase file upload limit from 2048MiB to 4096MiB for GCP/GCS offloading (#22554)

2024-04-22 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new e81f37000ec [fix][offload] Increase file upload

Re: [I] Offloading large ledgers (>2GB) fail with Google Cloud Storage [pulsar]

2024-04-22 Thread via GitHub
lhotari closed issue #15159: Offloading large ledgers (>2GB) fail with Google Cloud Storage URL: https://github.com/apache/pulsar/issues/15159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] [fix][offload] Increase file upload limit from 2048MiB to 4096MiB for GCP/GCS offloading [pulsar]

2024-04-22 Thread via GitHub
lhotari merged PR #22554: URL: https://github.com/apache/pulsar/pull/22554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

Re: [PR] [fix][broker] upgrade jclouds 2.5.0 -> 2.6.0 [pulsar]

2024-04-22 Thread via GitHub
nikhil-ctds commented on PR #0: URL: https://github.com/apache/pulsar/pull/0#issuecomment-2069791969 @lhotari I have tested with `gcsManagedLedgerOffloadMaxBlockSizeInBytes=134217728`, and was able to offload ledger of 3.5gb to gcs bucket. -- This is an automated message from the

[I] PKIX path building failed: unable to find valid certification path to request to requested target [pulsar-helm-chart]

2024-04-22 Thread via GitHub
bharatbhushan1705 opened a new issue, #492: URL: https://github.com/apache/pulsar-helm-chart/issues/492 **Describe the bug** A clear and concise description of what the bug is. The error message javax.net.ssl.SSLHandshakeException: PKIX path building failed: sun.security.provider.certp

Re: [PR] [improve] PIP-307: Use assigned broker URL hints during broker reconnection [pulsar-client-go]

2024-04-22 Thread via GitHub
BewareMyPower commented on code in PR #1208: URL: https://github.com/apache/pulsar-client-go/pull/1208#discussion_r1574823910 ## pulsar/internal/lookup_service.go: ## @@ -30,8 +30,9 @@ import ( // LookupResult encapsulates a struct for lookup a request, containing two parts:

Re: [D] broker healthcheck endpoint reports No such ledger exists on Metadata Server - ledger endlessly [pulsar]

2024-04-22 Thread via GitHub
GitHub user wallacepeng edited a discussion: broker healthcheck endpoint reports No such ledger exists on Metadata Server - ledger endlessly 2024-04-21T03:14:20,474+ [pulsar-io-4-7] ERROR org.apache.pulsar.client.impl.ProducerImpl - [persistent://pulsar/pulsar/pulsar-broker-0.pulsar-bro

Re: [PR] 3.0 test [pulsar]

2024-04-22 Thread via GitHub
coderzc closed pull request #22555: 3.0 test URL: https://github.com/apache/pulsar/pull/22555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[PR] 3.0 test [pulsar]

2024-04-22 Thread via GitHub
coderzc opened a new pull request, #22555: URL: https://github.com/apache/pulsar/pull/22555 Fixes #xyz Main Issue: #xyz PIP: #xyz ### Motivation ### Modifications ### Verifying this change - [ ]

Re: [PR] 3.0 test [pulsar]

2024-04-22 Thread via GitHub
github-actions[bot] commented on PR #22555: URL: https://github.com/apache/pulsar/pull/22555#issuecomment-2069570265 @coderzc Please add the following content to your PR description and select a checkbox: ``` - [ ] `doc` - [ ] `doc-required` - [ ] `doc-not-needed` - [ ] `do

Re: [PR] [fix][ml] Fix NPE of getValidPositionAfterSkippedEntries when recovering a terminated managed ledger [pulsar]

2024-04-22 Thread via GitHub
coderzc commented on code in PR #22552: URL: https://github.com/apache/pulsar/pull/22552#discussion_r1574766383 ## managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedCursorTest.java: ## @@ -4695,5 +4695,58 @@ public void readEntriesFailed(ManagedLedgerExcepti

(pulsar-client-go) branch master updated: [Improve] Add admin api GetLeaderBroker (#1203)

2024-04-22 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new b4d45cd3 [Improve] Add admin api GetLeade

Re: [PR] [Improve] Add admin api GetLeaderBroker [pulsar-client-go]

2024-04-22 Thread via GitHub
BewareMyPower merged PR #1203: URL: https://github.com/apache/pulsar-client-go/pull/1203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

(pulsar-client-go) branch master updated: [improve] add a lint-docker command in makefile (#1207)

2024-04-22 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git The following commit(s) were added to refs/heads/master by this push: new 13ecca24 [improve] add a lint-docker comm

Re: [PR] [improve] add a lint-docker command in makefile [pulsar-client-go]

2024-04-22 Thread via GitHub
BewareMyPower merged PR #1207: URL: https://github.com/apache/pulsar-client-go/pull/1207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

Re: [PR] [fix][broker] upgrade jclouds 2.5.0 -> 2.6.0 [pulsar]

2024-04-22 Thread via GitHub
lhotari commented on PR #0: URL: https://github.com/apache/pulsar/pull/0#issuecomment-2069414827 @nikhil-ctds I created #22554 that changes the default value of `gcsManagedLedgerOffloadMaxBlockSizeInBytes`. It would be helpful if you could test that `gcsManagedLedgerOffloadMaxBlockS

[I] Offloading large ledgers (>2GB) fail with Google Cloud Storage [pulsar]

2024-04-22 Thread via GitHub
lhotari opened a new issue, #15159: URL: https://github.com/apache/pulsar/issues/15159 **Describe the bug** Offloading large ledgers fail with Google Cloud Storage and the default settings. With default settings offloading ledgers over 2GB will fail to GCS since there's a limitation

Re: [I] Offloading large ledgers (>2GB) fail with Google Cloud Storage [pulsar]

2024-04-22 Thread via GitHub
lhotari commented on issue #15159: URL: https://github.com/apache/pulsar/issues/15159#issuecomment-2069410440 #0 alone doesn't fix the issue. Created #22554 to fix the remaining issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] [fix][ml] Fix NPE of getValidPositionAfterSkippedEntries when recovering a terminated managed ledger [pulsar]

2024-04-22 Thread via GitHub
shibd commented on code in PR #22552: URL: https://github.com/apache/pulsar/pull/22552#discussion_r1574746976 ## managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedCursorTest.java: ## @@ -4695,5 +4695,58 @@ public void readEntriesFailed(ManagedLedgerException

[PR] [improve][broker] Make BrokerSelectionStrategy pluggable [pulsar]

2024-04-22 Thread via GitHub
BewareMyPower opened a new pull request, #22553: URL: https://github.com/apache/pulsar/pull/22553 ### Motivation When users want to extend the `ExtensibleLoadManagerImpl`, the `BrokerSelectionStrategy` cannot be customized, so users have to write much duplicated code for a customized

Re: [PR] [fix][ml] Fix NPE of getValidPositionAfterSkippedEntries when recovering a terminated managed ledger [pulsar]

2024-04-22 Thread via GitHub
shibd commented on code in PR #22552: URL: https://github.com/apache/pulsar/pull/22552#discussion_r1574746976 ## managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedCursorTest.java: ## @@ -4695,5 +4695,58 @@ public void readEntriesFailed(ManagedLedgerException

Re: [PR] [improve] [broker] Create partitioned topics automatically when enable topic level replication [pulsar]

2024-04-22 Thread via GitHub
poorbarcode commented on code in PR #22537: URL: https://github.com/apache/pulsar/pull/22537#discussion_r1574733176 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java: ## @@ -621,35 +625,82 @@ protected void internalCreatePartitionedTopic(AsyncResp

Re: [PR] [improve] [broker] Create partitioned topics automatically when enable topic level replication [pulsar]

2024-04-22 Thread via GitHub
poorbarcode commented on code in PR #22537: URL: https://github.com/apache/pulsar/pull/22537#discussion_r1574733176 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java: ## @@ -621,35 +625,82 @@ protected void internalCreatePartitionedTopic(AsyncResp

[PR] [fix][ml] Fix NPE of getValidPositionAfterSkippedEntries when recovering a terminated managed ledger [pulsar]

2024-04-22 Thread via GitHub
coderzc opened a new pull request, #22552: URL: https://github.com/apache/pulsar/pull/22552 ### Motivation Since managedLedger does not create a new ledger when recovering a terminated managed ledger, lead to getValidPositionAfterSkippedEntries will get an NPE. ``` org.apac

Re: [PR] [fix][broker] upgrade jclouds 2.5.0 -> 2.6.0 [pulsar]

2024-04-22 Thread via GitHub
lhotari commented on PR #0: URL: https://github.com/apache/pulsar/pull/0#issuecomment-2069324241 > @lhotari With the above fix I tried testing GCS offloader with ledgers of size >= 2.5gb. I'm still facing the same error > > ``` > Error in offload > null > > Reason

  1   2   >