(pulsar) branch master updated: [fix] Include swagger annotations in shaded client lib (#22570)

2024-04-23 Thread lhotari
This is an automated email from the ASF dual-hosted git repository. lhotari pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 77a99ed287c [fix] Include swagger annotations i

Re: [PR] [fix] Include swagger annotations in shaded client lib [pulsar]

2024-04-23 Thread via GitHub
lhotari merged PR #22570: URL: https://github.com/apache/pulsar/pull/22570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

Re: [I] Missing shade io.swagger classes in org.apache.pulsar:pulsar-client jar [pulsar]

2024-04-23 Thread via GitHub
lhotari closed issue #21962: Missing shade io.swagger classes in org.apache.pulsar:pulsar-client jar URL: https://github.com/apache/pulsar/issues/21962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [improve] [broker] Create partitioned topics automatically when enable topic level replication [pulsar]

2024-04-23 Thread via GitHub
poorbarcode commented on PR #22537: URL: https://github.com/apache/pulsar/pull/22537#issuecomment-2074019426 Rebase master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[PR] [fix] Include swagger annotations in shaded client lib [pulsar]

2024-04-23 Thread via GitHub
merlimat opened a new pull request, #22570: URL: https://github.com/apache/pulsar/pull/22570 ### Motivation Fixes: #21962 #20700 marked the swagger-annotation with scope `provided` in the `pulsar-client` pom. The side effect is that the library is not getting included when the

Re: [PR] [feat][site] PIP-264: Document topic messaging metrics [pulsar-site]

2024-04-23 Thread via GitHub
dragosvictor commented on code in PR #880: URL: https://github.com/apache/pulsar-site/pull/880#discussion_r1576804180 ## docs/reference-metrics-opentelemetry.md: ## @@ -8,6 +8,153 @@ Pulsar exposes the following OpenTelemetry metrics. ## Broker +### Topic Messaging metrics

Re: [PR] [feat][site] PIP-264: Document topic messaging metrics [pulsar-site]

2024-04-23 Thread via GitHub
dragosvictor commented on code in PR #880: URL: https://github.com/apache/pulsar-site/pull/880#discussion_r1576716453 ## docs/reference-metrics-opentelemetry.md: ## @@ -8,6 +8,153 @@ Pulsar exposes the following OpenTelemetry metrics. ## Broker +### Topic Messaging metrics

Re: [PR] [improve][meta] Log a warning when ZK batch fails with connectionloss [pulsar]

2024-04-23 Thread via GitHub
heesung-sn commented on code in PR #22566: URL: https://github.com/apache/pulsar/pull/22566#discussion_r1576674865 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKMetadataStore.java: ## @@ -192,7 +192,20 @@ protected void batchOperation(List ops) {

Re: [PR] [improve][meta] Log a warning when ZK batch fails with connectionloss [pulsar]

2024-04-23 Thread via GitHub
heesung-sn commented on code in PR #22566: URL: https://github.com/apache/pulsar/pull/22566#discussion_r1576672640 ## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKMetadataStore.java: ## @@ -192,7 +192,20 @@ protected void batchOperation(List ops) {

Re: [PR] [feat][site] PIP-264: Document topic messaging metrics [pulsar-site]

2024-04-23 Thread via GitHub
dragosvictor commented on code in PR #880: URL: https://github.com/apache/pulsar-site/pull/880#discussion_r1576606808 ## docs/reference-metrics-opentelemetry.md: ## @@ -8,6 +8,153 @@ Pulsar exposes the following OpenTelemetry metrics. ## Broker +### Topic Messaging metrics

Re: [PR] [feat][site] PIP-264: Document topic messaging metrics [pulsar-site]

2024-04-23 Thread via GitHub
dragosvictor commented on code in PR #880: URL: https://github.com/apache/pulsar-site/pull/880#discussion_r1576586529 ## docs/reference-metrics-opentelemetry.md: ## @@ -8,6 +8,153 @@ Pulsar exposes the following OpenTelemetry metrics. ## Broker +### Topic Messaging metrics

Re: [PR] [feat][site] PIP-264: Document topic messaging metrics [pulsar-site]

2024-04-23 Thread via GitHub
dragosvictor commented on code in PR #880: URL: https://github.com/apache/pulsar-site/pull/880#discussion_r1576589918 ## docs/reference-metrics-opentelemetry.md: ## @@ -8,6 +8,153 @@ Pulsar exposes the following OpenTelemetry metrics. ## Broker +### Topic Messaging metrics

Re: [PR] [feat][site] PIP-264: Document topic messaging metrics [pulsar-site]

2024-04-23 Thread via GitHub
dragosvictor commented on code in PR #880: URL: https://github.com/apache/pulsar-site/pull/880#discussion_r1576587699 ## docs/reference-metrics-opentelemetry.md: ## @@ -8,6 +8,153 @@ Pulsar exposes the following OpenTelemetry metrics. ## Broker +### Topic Messaging metrics

Re: [PR] [feat][site] PIP-264: Document topic messaging metrics [pulsar-site]

2024-04-23 Thread via GitHub
dragosvictor commented on code in PR #880: URL: https://github.com/apache/pulsar-site/pull/880#discussion_r1576586529 ## docs/reference-metrics-opentelemetry.md: ## @@ -8,6 +8,153 @@ Pulsar exposes the following OpenTelemetry metrics. ## Broker +### Topic Messaging metrics

Re: [PR] [feat][site] PIP-264: Document topic messaging metrics [pulsar-site]

2024-04-23 Thread via GitHub
dragosvictor commented on code in PR #880: URL: https://github.com/apache/pulsar-site/pull/880#discussion_r1576582036 ## docs/reference-metrics-opentelemetry.md: ## @@ -8,6 +8,153 @@ Pulsar exposes the following OpenTelemetry metrics. ## Broker +### Topic Messaging metrics

Re: [PR] [feat][site] PIP-264: Document topic messaging metrics [pulsar-site]

2024-04-23 Thread via GitHub
dragosvictor commented on code in PR #880: URL: https://github.com/apache/pulsar-site/pull/880#discussion_r1576580042 ## docs/reference-metrics-opentelemetry.md: ## @@ -8,6 +8,153 @@ Pulsar exposes the following OpenTelemetry metrics. ## Broker +### Topic Messaging metrics

Re: [PR] [improve] PIP-307: Use assigned broker URL hints during broker reconnection [pulsar-client-go]

2024-04-23 Thread via GitHub
BewareMyPower merged PR #1208: URL: https://github.com/apache/pulsar-client-go/pull/1208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

Re: [PR] [improve] PIP-307: Use assigned broker URL hints during broker reconnection [pulsar-client-go]

2024-04-23 Thread via GitHub
BewareMyPower commented on code in PR #1208: URL: https://github.com/apache/pulsar-client-go/pull/1208#discussion_r1576550511 ## pulsar/producer_partition.go: ## @@ -429,12 +453,22 @@ func (p *partitionProducer) reconnectToBroker() { return

Re: [PR] [improve] PIP-307: Use assigned broker URL hints during broker reconnection [pulsar-client-go]

2024-04-23 Thread via GitHub
dragosvictor commented on code in PR #1208: URL: https://github.com/apache/pulsar-client-go/pull/1208#discussion_r1576544492 ## pulsar/producer_partition.go: ## @@ -429,12 +453,22 @@ func (p *partitionProducer) reconnectToBroker() { return

Re: [PR] [improve] PIP-307: Use assigned broker URL hints during broker reconnection [pulsar-client-go]

2024-04-23 Thread via GitHub
BewareMyPower commented on code in PR #1208: URL: https://github.com/apache/pulsar-client-go/pull/1208#discussion_r1576526236 ## pulsar/producer_partition.go: ## @@ -429,12 +453,22 @@ func (p *partitionProducer) reconnectToBroker() { return

Re: [PR] [improve] PIP-307: Use assigned broker URL hints during broker reconnection [pulsar-client-go]

2024-04-23 Thread via GitHub
BewareMyPower commented on code in PR #1208: URL: https://github.com/apache/pulsar-client-go/pull/1208#discussion_r1576526236 ## pulsar/producer_partition.go: ## @@ -429,12 +453,22 @@ func (p *partitionProducer) reconnectToBroker() { return

Re: [PR] [improve] PIP-307: Use assigned broker URL hints during broker reconnection [pulsar-client-go]

2024-04-23 Thread via GitHub
BewareMyPower commented on code in PR #1208: URL: https://github.com/apache/pulsar-client-go/pull/1208#discussion_r1576526236 ## pulsar/producer_partition.go: ## @@ -429,12 +453,22 @@ func (p *partitionProducer) reconnectToBroker() { return

Re: [PR] [improve] PIP-307: Use assigned broker URL hints during broker reconnection [pulsar-client-go]

2024-04-23 Thread via GitHub
BewareMyPower commented on code in PR #1208: URL: https://github.com/apache/pulsar-client-go/pull/1208#discussion_r1576520011 ## pulsar/producer_partition.go: ## @@ -429,12 +453,22 @@ func (p *partitionProducer) reconnectToBroker() { return

Re: [PR] [improve] PIP-307: Use assigned broker URL hints during broker reconnection [pulsar-client-go]

2024-04-23 Thread via GitHub
dragosvictor commented on code in PR #1208: URL: https://github.com/apache/pulsar-client-go/pull/1208#discussion_r1576510648 ## pulsar/producer_partition.go: ## @@ -429,12 +453,22 @@ func (p *partitionProducer) reconnectToBroker() { return

Re: [PR] [improve] PIP-307: Use assigned broker URL hints during broker reconnection [pulsar-client-go]

2024-04-23 Thread via GitHub
dragosvictor commented on code in PR #1208: URL: https://github.com/apache/pulsar-client-go/pull/1208#discussion_r1576510648 ## pulsar/producer_partition.go: ## @@ -429,12 +453,22 @@ func (p *partitionProducer) reconnectToBroker() { return

Re: [PR] [improve] PIP-307: Use assigned broker URL hints during broker reconnection [pulsar-client-go]

2024-04-23 Thread via GitHub
dragosvictor commented on code in PR #1208: URL: https://github.com/apache/pulsar-client-go/pull/1208#discussion_r1576507047 ## pulsar/producer_partition.go: ## @@ -429,12 +453,22 @@ func (p *partitionProducer) reconnectToBroker() { return

Re: [PR] [improve] PIP-307: Use assigned broker URL hints during broker reconnection [pulsar-client-go]

2024-04-23 Thread via GitHub
BewareMyPower commented on code in PR #1208: URL: https://github.com/apache/pulsar-client-go/pull/1208#discussion_r1576335249 ## pulsar/producer_partition.go: ## @@ -429,12 +453,22 @@ func (p *partitionProducer) reconnectToBroker() { return

Re: [PR] [improve][meta] Log a warning when ZK batch fails with connectionloss [pulsar]

2024-04-23 Thread via GitHub
lhotari commented on PR #22566: URL: https://github.com/apache/pulsar/pull/22566#issuecomment-2072415742 It seems that batching reads could cause more harm than benefit when the returned data exceeds jute.maxbuffer size. This impacts stability a lot so there should be a way to disable bat

Re: [PR] [improve][meta] Log a warning when ZK batch fails with connectionloss [pulsar]

2024-04-23 Thread via GitHub
lhotari commented on PR #22566: URL: https://github.com/apache/pulsar/pull/22566#issuecomment-2072410563 The test https://github.com/apache/pulsar/blob/61296d90d912493113d7a18c18eef23114810ce7/pulsar-metadata/src/test/java/org/apache/pulsar/metadata/MetadataStoreBatchingTest.java#L151-L182

(pulsar) branch master updated: [fix][admin] Fix can't delete tenant for v1 (#22550)

2024-04-23 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new d5c72312ff4 [fix][admin] Fix can't delete tenant

Re: [PR] [fix][admin] Fix can't delete tenant for v1 [pulsar]

2024-04-23 Thread via GitHub
merlimat merged PR #22550: URL: https://github.com/apache/pulsar/pull/22550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.a

Re: [I] [Bug] broker healthcheck ran into loop after decommissioned a cluster of bookies [pulsar]

2024-04-23 Thread via GitHub
wallacepeng commented on issue #22559: URL: https://github.com/apache/pulsar/issues/22559#issuecomment-2072404304 @hpvd we are downgrading the storage so provisioned the bookkeeper cluster. we will upgrade the cluster a bit later. is there any way to clean the healthcheck topic it looks lik

[I] [Bug] Broker could take 30+ seconds to close with extensible load manager [pulsar]

2024-04-23 Thread via GitHub
BewareMyPower opened a new issue, #22569: URL: https://github.com/apache/pulsar/issues/22569 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Read release policy - [X] I understand that

Re: [I] [Bug] Unload with destinationBroker could fail with 504 with extensible load manager [pulsar]

2024-04-23 Thread via GitHub
BewareMyPower closed issue #22136: [Bug] Unload with destinationBroker could fail with 504 with extensible load manager URL: https://github.com/apache/pulsar/issues/22136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

(pulsar-dotpulsar) branch master updated: Added traits to tests. Now using Pulsar 3.1.3 for tests

2024-04-23 Thread blankensteiner
This is an automated email from the ASF dual-hosted git repository. blankensteiner pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-dotpulsar.git The following commit(s) were added to refs/heads/master by this push: new 4a05f01 Added traits to tests

Re: [PR] [improve][ci] Skip detecting changed files in fork repositories [pulsar]

2024-04-23 Thread via GitHub
BewareMyPower closed pull request #22567: [improve][ci] Skip detecting changed files in fork repositories URL: https://github.com/apache/pulsar/pull/22567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] [improve][ci] Skip detecting changed files in fork repositories [pulsar]

2024-04-23 Thread via GitHub
lhotari commented on PR #22567: URL: https://github.com/apache/pulsar/pull/22567#issuecomment-2072261695 experiment in #22568 in draft mode -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[PR] [improve][ci] Add explicit GitHub Actions permissions [pulsar]

2024-04-23 Thread via GitHub
lhotari opened a new pull request, #22568: URL: https://github.com/apache/pulsar/pull/22568 ### Motivation This is required when running GitHub Actions in a fork that has been configured with restrictive access. - [GitHub Actions workflow or job permissions](https://docs.gith

Re: [PR] [improve][ci] Skip detecting changed files in fork repositories [pulsar]

2024-04-23 Thread via GitHub
BewareMyPower commented on PR #22567: URL: https://github.com/apache/pulsar/pull/22567#issuecomment-2072194156 I also found another permission issue in the **Semantic Pull Request / Check pull request title** workflow though it does not block the development. ``` Run amannn/action-

Re: [PR] [improve][ci] Skip detecting changed files in fork repositories [pulsar]

2024-04-23 Thread via GitHub
lhotari commented on PR #22567: URL: https://github.com/apache/pulsar/pull/22567#issuecomment-2072183428 > Technically it's right. But the [`paths-filter` plugin](https://github.com/apache/pulsar-test-infra/commits/master/paths-filter) is hard to maintain for contributors not familiar with

Re: [PR] [improve][ci] Skip detecting changed files in fork repositories [pulsar]

2024-04-23 Thread via GitHub
BewareMyPower commented on PR #22567: URL: https://github.com/apache/pulsar/pull/22567#issuecomment-2072080615 > The problem with the changes in this PR is that it would make it harder to develop the workflow in a public forked repository. The main affect is the PRs that only modify t

Re: [D] Python Producer Message to InfluxDB v2 sink connector [pulsar]

2024-04-23 Thread via GitHub
GitHub user smuehlmann edited a discussion: Python Producer Message to InfluxDB v2 sink connector Hi, i have problems to send a message with a python producer which should be processed by an InfluxDB v2 sink connector. Especially the message content / payload in combination with the used pro

Re: [D] Python Producer Message to InfluxDB v2 sink connector [pulsar]

2024-04-23 Thread via GitHub
GitHub user smuehlmann edited a discussion: Python Producer Message to InfluxDB v2 sink connector Hi, i have problems to send a message with a python producer which should be processed by an InfluxDBv2 sink connector. Especially the message content / payload in combination with the used prod

Re: [D] Python Producer Message to InfluxDBv2 sink connector [pulsar]

2024-04-23 Thread via GitHub
GitHub user smuehlmann edited a discussion: Python Producer Message to InfluxDBv2 sink connector Hi, i have problems to send a message with a python producer which should be processed by an InfluxDBv2 sink connector. Especially the message content / payload in combination with the used produ

Re: [D] Python Producer Message to InfluxDBv2 sink connector with [pulsar]

2024-04-23 Thread via GitHub
GitHub user smuehlmann edited a discussion: Python Producer Message to InfluxDBv2 sink connector with Hi, i have problems to send a message with a python producer which should be processed by an InfluxDBv2 sink connector. Especially the message content / payload in combination with the used

Re: [D] Python Producer Message to InfluxDBv2 sink connector with [pulsar]

2024-04-23 Thread via GitHub
GitHub user smuehlmann edited a discussion: Python Producer Message to InfluxDBv2 sink connector with Hi, i have problems to send a message with a python producer which should be processed by an InfluxDBv2 sink connector. With a java test code it is possible. Java class: public class Dev

Re: [D] Pulsar 3.2.2 Message for InfluxDBv2 sink connector with Python Producer [pulsar]

2024-04-23 Thread via GitHub
GitHub user smuehlmann edited a discussion: Pulsar 3.2.2 Message for InfluxDBv2 sink connector with Python Producer Hi, i have problems to send a message with a python producer which should be processed by an InfluxDBv2 sink connector. With a java test code it is possible. Java class: pu

Re: [PR] [improve][broker] Optimize topic production rate stats. [pulsar]

2024-04-23 Thread via GitHub
hanmz commented on PR #22518: URL: https://github.com/apache/pulsar/pull/22518#issuecomment-2072064765 > @hanmz This is a long-standing issue and the plan was to address as part of the overall changes of [PIP-264](https://github.com/apache/pulsar/blob/master/pip/pip-264.md). I wouldn't int

Re: [PR] [improve][broker] Optimize topic production rate stats. [pulsar]

2024-04-23 Thread via GitHub
hanmz closed pull request #22518: [improve][broker] Optimize topic production rate stats. URL: https://github.com/apache/pulsar/pull/22518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [D] Pulsar 3.2.2 correct Message to InfluxDBv2 sink connector with Python Producer [pulsar]

2024-04-23 Thread via GitHub
GitHub user smuehlmann edited a discussion: Pulsar 3.2.2 correct Message to InfluxDBv2 sink connector with Python Producer Hi, i have problems to send a message with a python producer which should be processed by an InfluxDBv2 sink connector. With a java test code it is possible. Java clas

Re: [PR] [improve][ci] Skip detecting changed files in fork repositories [pulsar]

2024-04-23 Thread via GitHub
lhotari commented on PR #22567: URL: https://github.com/apache/pulsar/pull/22567#issuecomment-2072051995 Is there a way where explicit job permissions specified with https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs would address the issue? -- This is an automat

Re: [PR] [improve][meta] Log a warning when ZK batch fails with connectionloss [pulsar]

2024-04-23 Thread via GitHub
lhotari commented on PR #22566: URL: https://github.com/apache/pulsar/pull/22566#issuecomment-2072024722 I might have encountered this issue recently when working on the /metrics endpoint issue. A few times I got errors such as `java.io.IOException: Packet len 15589885 is out of range!`

[PR] [improve][ci] Skip detecting changed files in fork repositories [pulsar]

2024-04-23 Thread via GitHub
BewareMyPower opened a new pull request, #22567: URL: https://github.com/apache/pulsar/pull/22567 ### Motivation In a private fork repository, the precondition workflow of a PR will always fail due to the lack of the permission to fetch the content of that PR. ``` Fetching l

(pulsar) branch master updated: [improve][broker] Make BrokerSelectionStrategy pluggable (#22553)

2024-04-23 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 89b201ed8a4 [improve][broker] Make BrokerSelectionS

Re: [PR] [improve][broker] Make BrokerSelectionStrategy pluggable [pulsar]

2024-04-23 Thread via GitHub
BewareMyPower merged PR #22553: URL: https://github.com/apache/pulsar/pull/22553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pul

Re: [PR] [improve] [broker] Create partitioned topics automatically when enable topic level replication [pulsar]

2024-04-23 Thread via GitHub
gaoran10 commented on code in PR #22537: URL: https://github.com/apache/pulsar/pull/22537#discussion_r1576003194 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java: ## @@ -621,35 +625,82 @@ protected void internalCreatePartitionedTopic(AsyncRespons

Re: [D] Apache Beam support for Pulsar [pulsar]

2024-04-23 Thread via GitHub
GitHub user hpvd added a comment to the discussion: Apache Beam support for Pulsar opened an issue to add current state of Pulsar support to Beams doc: https://github.com/apache/beam/issues/31079 GitHub link: https://github.com/apache/pulsar/discussions/18453#discussioncomment-9199245 T

Re: [I] [Bug] one topic suddenly cannot be consumed,others is ok [pulsar]

2024-04-23 Thread via GitHub
MichalKoziorowski-TomTom commented on issue #21082: URL: https://github.com/apache/pulsar/issues/21082#issuecomment-2071880394 @poorbarcode I've checked with 3.0.4 client containing https://github.com/apache/pulsar/issues/22352 fix and I can't reproduce it now. I don't know if this PR fi

Re: [PR] [improve][client] Add maxConnectionsPerHost and connectionMaxIdleSeconds to PulsarAdminBuilder [pulsar]

2024-04-23 Thread via GitHub
lhotari commented on PR #22541: URL: https://github.com/apache/pulsar/pull/22541#issuecomment-2071881698 Another challenge is to cancel work that is queued in the system, but not waited by any clients. Newer Jersey clients have support for this. I noticed commit https://github.com/eclip

[I] Why are Clusters not displayed? Is special configuration required? [pulsar-manager]

2024-04-23 Thread via GitHub
YANGJINJUE opened a new issue, #558: URL: https://github.com/apache/pulsar-manager/issues/558 "Why are Clusters not displayed? Is special configuration required?" ![image](https://github.com/apache/pulsar-manager/assets/32013488/14279828-f26a-4295-adbd-e8585abb3907)

Re: [I] [Bug] Client with shared subscription is blocked [pulsar]

2024-04-23 Thread via GitHub
MichalKoziorowski-TomTom commented on issue #21104: URL: https://github.com/apache/pulsar/issues/21104#issuecomment-2071870500 @michalcukierman Could you recheck your case? I've checked my case and I can't reproduce with 3.0.4 client while it was easily reproducible with 3.0.1. Test with ve

Re: [D] Apache Beam support for Pulsar [pulsar]

2024-04-23 Thread via GitHub
GitHub user hpvd added a comment to the discussion: Apache Beam support for Pulsar just opened an issue in Beam repository to maintain a good overview on this: https://github.com/apache/beam/issues/31078 GitHub link: https://github.com/apache/pulsar/discussions/18453#discussioncomment-9198904

Re: [PR] [improve][client] Add maxConnectionsPerHost and connectionMaxIdleSeconds to PulsarAdminBuilder [pulsar]

2024-04-23 Thread via GitHub
lhotari commented on PR #22541: URL: https://github.com/apache/pulsar/pull/22541#issuecomment-2071822579 Noticed that there's a solution to run 1-by-1 using https://github.com/apache/pulsar/blob/ed599673c7e60ab5bb02e1fb0615a7ff8e5d6430/pulsar-common/src/main/java/org/apache/pulsar/common/uti

Re: [PR] [improve][pip] PIP-347: add role field in consumer's stat [pulsar]

2024-04-23 Thread via GitHub
thetumbled commented on PR #22564: URL: https://github.com/apache/pulsar/pull/22564#issuecomment-2071713876 PTAL, thanks. @BewareMyPower @lhotari @codelipenghui @poorbarcode @Technoboy- -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [improve] [broker] add role for consumer stat [pulsar]

2024-04-23 Thread via GitHub
thetumbled commented on code in PR #22562: URL: https://github.com/apache/pulsar/pull/22562#discussion_r1575843420 ## pulsar-client-admin-api/src/main/java/org/apache/pulsar/common/policies/data/ConsumerStats.java: ## @@ -25,6 +25,9 @@ * Consumer statistics. */ public inter

[PR] [improve][pip] PIP-347: add role field in consumer's stat [pulsar]

2024-04-23 Thread via GitHub
thetumbled opened a new pull request, #22564: URL: https://github.com/apache/pulsar/pull/22564 ### Motivation pip-347 ### Modifications ### Verifying this change - [ ] Make sure that the change passes the CI checks. *(Please pick either of the fo

Re: [PR] [improve][client] Add maxConnectionsPerHost and connectionMaxIdleSeconds to PulsarAdminBuilder [pulsar]

2024-04-23 Thread via GitHub
lhotari commented on PR #22541: URL: https://github.com/apache/pulsar/pull/22541#issuecomment-2071687995 Looks like https://github.com/spotify/completable-futures/blob/master/src/main/java/com/spotify/futures/ConcurrencyReducer.java could be a useful solution to leverage. -- This is an a

(pulsar) branch master updated (7fe92ac43cf -> 358c7cc6bbb)

2024-04-23 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git from 7fe92ac43cf [fix][broker] Support lookup options for extensible load manager (#22487) add 358c7cc6bbb [fix][ci] Don

Re: [PR] [fix][ci] Don't allow merging PR without successful result [pulsar]

2024-04-23 Thread via GitHub
BewareMyPower merged PR #22563: URL: https://github.com/apache/pulsar/pull/22563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pul

Re: [PR] [improve][client] Add maxConnectionsPerHost and connectionMaxIdleSeconds to PulsarAdminBuilder [pulsar]

2024-04-23 Thread via GitHub
lhotari commented on PR #22541: URL: https://github.com/apache/pulsar/pull/22541#issuecomment-2071666071 example of creating partitions: https://github.com/apache/pulsar/blob/50121e7f7be541f45bb6dc976f51e30658b1cb8d/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.

Re: [I] [Bug] broker healthcheck ran into loop after decommissioned a cluster of bookies [pulsar]

2024-04-23 Thread via GitHub
hpvd commented on issue #22559: URL: https://github.com/apache/pulsar/issues/22559#issuecomment-2071657216 since 2.10 is not supported anymore, cna you plz check if this also appears in newer versions? For details see - supported versions: https://pulsar.apache.org/contribute/release-p

Re: [I] customRuntimeOptions in "Creates a new Pulsar Source in cluster mode" API call in source connector doesn't add nodeselectors & tolerations [pulsar-helm-chart]

2024-04-23 Thread via GitHub
lhotari commented on issue #394: URL: https://github.com/apache/pulsar-helm-chart/issues/394#issuecomment-2071647058 > But I want different nodeSelector for different functions which I deploy. @kunjbosamiaFalkonry One possible approach would be to create your own customizer implement

Re: [I] Argo CD unable to generate template with pulsar chart 3.3.0 [pulsar-helm-chart]

2024-04-23 Thread via GitHub
lhotari closed issue #471: Argo CD unable to generate template with pulsar chart 3.3.0 URL: https://github.com/apache/pulsar-helm-chart/issues/471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [improve][client] Add maxConnectionsPerHost and connectionMaxIdleSeconds to PulsarAdminBuilder [pulsar]

2024-04-23 Thread via GitHub
lhotari commented on PR #22541: URL: https://github.com/apache/pulsar/pull/22541#issuecomment-2071621213 Another location without proper backpressure is namespace deletion: https://github.com/apache/pulsar/blob/d7d54522933b63f6a74ec7139c6dedebe8ad9149/pulsar-broker/src/main/java/org/apach

(pulsar) branch branch-3.0 updated: [fix][test][branch-3.0] Fix test PersistentTopicsTest.testUpdatePartitionedTopic

2024-04-23 Thread zhaocong
This is an automated email from the ASF dual-hosted git repository. zhaocong pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new 6e849fcb064 [fix][test][branch-3.0] Fi

Re: [PR] [improve][pip] PIP-346: Add a simplified configuration file for Pulsar [pulsar]

2024-04-23 Thread via GitHub
lhotari commented on PR #22274: URL: https://github.com/apache/pulsar/pull/22274#issuecomment-2071609387 > Hi, could we move forward with this PIP? It seems that it is not rely on another PIP `Proposal to Replace Pulsar's Homegrown Configuration Framework with Gestalt Config`. @merlimat @Be

(pulsar) branch master updated: [fix][broker] Support lookup options for extensible load manager (#22487)

2024-04-23 Thread xyz
This is an automated email from the ASF dual-hosted git repository. xyz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/master by this push: new 7fe92ac43cf [fix][broker] Support lookup options fo

Re: [PR] [fix][broker] Support lookup options for extensible load manager [pulsar]

2024-04-23 Thread via GitHub
BewareMyPower merged PR #22487: URL: https://github.com/apache/pulsar/pull/22487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pul

Re: [PR] [improve][broker] Make BrokerSelectionStrategy pluggable [pulsar]

2024-04-23 Thread via GitHub
BewareMyPower commented on PR #22553: URL: https://github.com/apache/pulsar/pull/22553#issuecomment-2071585235 The test failed because the broker selection strategy of `CustomExtensibleLoadManager ` chooses the broker with the smallest **HTTP listen port**, while the test uses the `PulsarSe

Re: [PR] [fix][broker] Introduce the last sent position to fix message ordering issues in Key_Shared (PIP-282) [pulsar]

2024-04-23 Thread via GitHub
equanz commented on PR #21953: URL: https://github.com/apache/pulsar/pull/21953#issuecomment-2071580220 Rebased to fix conflicts. BTW, can someone review this? I've been trying to fix the issue for a year now... (cf. https://github.com/apache/pulsar/pull/20179) -- This is an automated

(pulsar) branch branch-3.0 updated: Revert "[fix][test][branch-3.0] Fix broken ManagedLedgerTest.testGetNumberOfEntriesInStorage"

2024-04-23 Thread zhaocong
This is an automated email from the ASF dual-hosted git repository. zhaocong pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/pulsar.git The following commit(s) were added to refs/heads/branch-3.0 by this push: new d6791a8de26 Revert "[fix][test][branch

Re: [I] Cleanup synchronous call in resources component [pulsar]

2024-04-23 Thread via GitHub
lhotari commented on issue #22544: URL: https://github.com/apache/pulsar/issues/22544#issuecomment-2071571572 We have another problem with asynchronous calls and that's about the lack of proper backpressure. Here's a comment about it: https://github.com/apache/pulsar/pull/22541#issuecomment