Re: [PR] [fix] Reconnection logic and Backoff policy doesn't work correctly [pulsar-client-go]

2024-07-07 Thread via GitHub
crossoverJie commented on code in PR #1197: URL: https://github.com/apache/pulsar-client-go/pull/1197#discussion_r1667619137 ## pulsar/consumer_partition.go: ## @@ -1673,11 +1680,8 @@ func (pc *partitionConsumer) reconnectToBroker() { return

Re: [PR] [fix][broker] PulsarStandalone started with error if --stream-storage-port is not 4181 [pulsar]

2024-07-07 Thread via GitHub
zhouyifan279 commented on PR #22993: URL: https://github.com/apache/pulsar/pull/22993#issuecomment-2212337979 @nodece `OpenTelemetrySanityTest#testOpenTelemetryMetricsOtlpExport` timed out multiple times. I'm investigating the reason today. -- This is an automated message from the

Re: [PR] [fix] Reconnection logic and Backoff policy doesn't work correctly [pulsar-client-go]

2024-07-06 Thread via GitHub
nodece commented on PR #1197: URL: https://github.com/apache/pulsar-client-go/pull/1197#issuecomment-2211821702 Any updates? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] High GC pause cases high publish latency [pulsar]

2024-07-06 Thread via GitHub
dao-jun closed issue #22866: High GC pause cases high publish latency URL: https://github.com/apache/pulsar/issues/22866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [improve][broker] Use RoaringBitmap in tracking individual acks to reduce memory usage [pulsar]

2024-07-06 Thread via GitHub
dao-jun merged PR #23006: URL: https://github.com/apache/pulsar/pull/23006 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [Bug] Segmentation Fault when using Pulsar Consumer batchReceive [pulsar-client-node]

2024-07-06 Thread via GitHub
shibd commented on issue #390: URL: https://github.com/apache/pulsar-client-node/issues/390#issuecomment-2211725622 #389 can resolve batch_recieve crash issue when the consumer running on `Debian` system. -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] [Bug] Segmentation Fault when using Pulsar Consumer batchReceive [pulsar-client-node]

2024-07-06 Thread via GitHub
shibd commented on issue #390: URL: https://github.com/apache/pulsar-client-node/issues/390#issuecomment-2211724898 @rafael-polakiewicz What is the env in which the consumer is running? Maybe you can try this version: `npm i pulsar-client@1.11.1-rc.2

Re: [PR] Bump certifi from 2023.7.22 to 2024.7.4 in /tools/pytools [pulsar-site]

2024-07-05 Thread via GitHub
visortelle merged PR #935: URL: https://github.com/apache/pulsar-site/pull/935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Bump certifi from 2023.7.22 to 2024.7.4 in /tools/pytools [pulsar-site]

2024-07-05 Thread via GitHub
dependabot[bot] opened a new pull request, #935: URL: https://github.com/apache/pulsar-site/pull/935 Bumps [certifi](https://github.com/certifi/python-certifi) from 2023.7.22 to 2024.7.4. Commits

Re: [PR] [fix][broker] Fix MessageDeduplication replay timeout cause topic loading stuck [pulsar]

2024-07-05 Thread via GitHub
dao-jun merged PR #23004: URL: https://github.com/apache/pulsar/pull/23004 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [Bug][broker] MessageDeduplication replay timeout would cause topic loading stuck and become unavailable [pulsar]

2024-07-05 Thread via GitHub
dao-jun closed issue #23003: [Bug][broker] MessageDeduplication replay timeout would cause topic loading stuck and become unavailable URL: https://github.com/apache/pulsar/issues/23003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [improve][broker] Use RoaringBitmap in tracking individual acks to reduce memory usage [pulsar]

2024-07-05 Thread via GitHub
codecov-commenter commented on PR #23006: URL: https://github.com/apache/pulsar/pull/23006#issuecomment-2211386044 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/23006?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] [fix][broker] Replication stuck when partitions count between two clusters is not the same [pulsar]

2024-07-05 Thread via GitHub
poorbarcode commented on code in PR #22983: URL: https://github.com/apache/pulsar/pull/22983#discussion_r1667078640 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractReplicator.java: ## @@ -184,8 +187,42 @@ public void startProducer() { }

Re: [PR] [fix][broker] Replication stuck when partitions count between two clusters is not the same [pulsar]

2024-07-05 Thread via GitHub
poorbarcode commented on code in PR #22983: URL: https://github.com/apache/pulsar/pull/22983#discussion_r1667074885 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ProducerConfigurationData.java: ## @@ -204,6 +204,8 @@ public class ProducerConfigurationData

Re: [PR] Add a note about increases in backlog when replicated subscription is activated [pulsar-site]

2024-07-05 Thread via GitHub
visortelle merged PR #916: URL: https://github.com/apache/pulsar-site/pull/916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] [feat][doc] PIP-264: Update OpenTelemetry deployment documentation [pulsar-site]

2024-07-05 Thread via GitHub
dragosvictor opened a new pull request, #934: URL: https://github.com/apache/pulsar-site/pull/934 ### ✅ Contribution Checklist - [x] I read the [contribution guide](https://pulsar.apache.org/contribute/document-contribution/) - [x] I updated the [versioned

[I] [Bug] Segmentation Fault when using Pulsar Consumer batchReceive [pulsar-client-node]

2024-07-05 Thread via GitHub
rafael-polakiewicz opened a new issue, #390: URL: https://github.com/apache/pulsar-client-node/issues/390 # Description I encountered a segmentation fault using pulsar consumer batch receive method. The consumer process terminates unexpectedly with a segmentation fault. # Node and

Re: [PR] [fix][broker] Fix MessageDeduplication replay timeout cause topic loading stuck [pulsar]

2024-07-05 Thread via GitHub
codecov-commenter commented on PR #23004: URL: https://github.com/apache/pulsar/pull/23004#issuecomment-2211127484 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/23004?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] [fix][broker] Replication stuck when partitions count between two clusters is not the same [pulsar]

2024-07-05 Thread via GitHub
nodece commented on code in PR #22983: URL: https://github.com/apache/pulsar/pull/22983#discussion_r1666970494 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractReplicator.java: ## @@ -184,8 +187,42 @@ public void startProducer() { }

Re: [PR] [fix][admin] Fix half deletion when attempt to topic with a incorrect API [pulsar]

2024-07-05 Thread via GitHub
nodece commented on code in PR #23002: URL: https://github.com/apache/pulsar/pull/23002#discussion_r1666965046 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminTopicApiTest.java: ## @@ -71,6 +75,62 @@ protected void cleanup() throws Exception {

Re: [PR] [fix][admin] Fix half deletion when attempt to topic with a incorrect API [pulsar]

2024-07-05 Thread via GitHub
nodece commented on code in PR #23002: URL: https://github.com/apache/pulsar/pull/23002#discussion_r1666963241 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminTopicApiTest.java: ## @@ -71,6 +75,62 @@ protected void cleanup() throws Exception {

Re: [PR] [fix][admin] Fix half deletion when attempt to topic with a incorrect API [pulsar]

2024-07-05 Thread via GitHub
nodece commented on code in PR #23002: URL: https://github.com/apache/pulsar/pull/23002#discussion_r1666960652 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java: ## @@ -1167,7 +1167,17 @@ public void deleteTopic( @ApiParam(value

Re: [PR] [fix][admin] Fix half deletion when attempt to topic with a incorrect API [pulsar]

2024-07-05 Thread via GitHub
nodece commented on code in PR #23002: URL: https://github.com/apache/pulsar/pull/23002#discussion_r1666960439 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java: ## @@ -742,7 +742,17 @@ protected void

Re: [PR] [fix][admin] Fix half deletion when attempt to topic with a incorrect API [pulsar]

2024-07-05 Thread via GitHub
nodece commented on code in PR #23002: URL: https://github.com/apache/pulsar/pull/23002#discussion_r1666959049 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java: ## @@ -742,7 +742,17 @@ protected void

Re: [PR] [improve] [pip] PIP-364: Introduce a new load balance algorithm AvgShedder [pulsar]

2024-07-05 Thread via GitHub
thetumbled commented on code in PR #22949: URL: https://github.com/apache/pulsar/pull/22949#discussion_r1666934066 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java: ## @@ -270,7 +270,12 @@ public void initialize(final

Re: [PR] Add a note about increases in backlog when replicated subscription is activated [pulsar-site]

2024-07-05 Thread via GitHub
AlvaroStream commented on PR #916: URL: https://github.com/apache/pulsar-site/pull/916#issuecomment-2210999728 Sorry I missed the ping. Updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [improve][broker] log exception in MessageDeduplication#takeSnapshot [pulsar]

2024-07-05 Thread via GitHub
codecov-commenter commented on PR #22994: URL: https://github.com/apache/pulsar/pull/22994#issuecomment-2210981823 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/22994?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] [improve] [pip] PIP-364: Introduce a new load balance algorithm AvgShedder [pulsar]

2024-07-05 Thread via GitHub
Demogorgon314 commented on code in PR #22949: URL: https://github.com/apache/pulsar/pull/22949#discussion_r1666868940 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java: ## @@ -270,7 +270,12 @@ public void initialize(final

Re: [PR] [improve][broker] log exception in MessageDeduplication#takeSnapshot [pulsar]

2024-07-05 Thread via GitHub
lhotari closed pull request #22994: [improve][broker] log exception in MessageDeduplication#takeSnapshot URL: https://github.com/apache/pulsar/pull/22994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [improve] [pip] PIP-364: Introduce a new load balance algorithm AvgShedder [pulsar]

2024-07-05 Thread via GitHub
thetumbled commented on code in PR #22949: URL: https://github.com/apache/pulsar/pull/22949#discussion_r1666768514 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java: ## @@ -270,7 +270,12 @@ public void initialize(final

Re: [PR] [improve] [pip] PIP-364: Introduce a new load balance algorithm AvgShedder [pulsar]

2024-07-05 Thread via GitHub
Demogorgon314 commented on code in PR #22949: URL: https://github.com/apache/pulsar/pull/22949#discussion_r1666766200 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java: ## @@ -270,7 +270,12 @@ public void initialize(final

Re: [PR] [improve] [pip] PIP-364: Introduce a new load balance algorithm AvgShedder [pulsar]

2024-07-05 Thread via GitHub
thetumbled commented on code in PR #22949: URL: https://github.com/apache/pulsar/pull/22949#discussion_r1666757425 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java: ## @@ -270,7 +270,12 @@ public void initialize(final

Re: [PR] [improve] [pip] PIP-364: Introduce a new load balance algorithm AvgShedder [pulsar]

2024-07-05 Thread via GitHub
Demogorgon314 commented on code in PR #22949: URL: https://github.com/apache/pulsar/pull/22949#discussion_r134368 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java: ## @@ -270,7 +270,12 @@ public void initialize(final

Re: [PR] [improve] [pip] PIP-364: Introduce a new load balance algorithm AvgShedder [pulsar]

2024-07-05 Thread via GitHub
thetumbled commented on code in PR #22949: URL: https://github.com/apache/pulsar/pull/22949#discussion_r118448 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/AvgShedder.java: ## @@ -0,0 +1,312 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-05 Thread via GitHub
RobertIndie merged PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-05 Thread via GitHub
RobertIndie commented on PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#issuecomment-2210572269 > but I noticed that the [v0.13.0](https://github.com/apache/pulsar-client-go/milestone/15) milestone has a deadline in 2 days. > And was wondering, due to the nature of

Re: [PR] [feat][broker] PIP-264: Add OpenTelemetry managed cursor metrics [pulsar]

2024-07-05 Thread via GitHub
merlimat merged PR #23000: URL: https://github.com/apache/pulsar/pull/23000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Fix transaction coordinator client cann't reconnect to the broker [pulsar-client-go]

2024-07-05 Thread via GitHub
RobertIndie opened a new pull request, #1237: URL: https://github.com/apache/pulsar-client-go/pull/1237 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master

Re: [PR] [improve] [pip] PIP-364: Introduce a new load balance algorithm AvgShedder [pulsar]

2024-07-05 Thread via GitHub
Demogorgon314 commented on code in PR #22949: URL: https://github.com/apache/pulsar/pull/22949#discussion_r1650555346 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/AvgShedder.java: ## @@ -0,0 +1,316 @@ +/** + * Licensed to the Apache Software

Re: [PR] [fix][broker] Replication stuck when partitions count between two clusters is not the same [pulsar]

2024-07-05 Thread via GitHub
Demogorgon314 commented on code in PR #22983: URL: https://github.com/apache/pulsar/pull/22983#discussion_r1666513004 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/OneWayReplicatorTest.java: ## @@ -1034,4 +1040,88 @@ public void testConfigReplicationStartAt()

Re: [PR] (WIP) Build deb packages via vcpkg [pulsar-client-cpp]

2024-07-05 Thread via GitHub
BewareMyPower closed pull request #375: (WIP) Build deb packages via vcpkg URL: https://github.com/apache/pulsar-client-cpp/pull/375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [feat][misc] PIP-264: Copy OpenTelemetry resource attributes to Prometheus labels [pulsar]

2024-07-05 Thread via GitHub
merlimat merged PR #23005: URL: https://github.com/apache/pulsar/pull/23005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [fix][admin] Fix half deletion when attempt to topic with a incorrect API [pulsar]

2024-07-05 Thread via GitHub
poorbarcode commented on PR #23002: URL: https://github.com/apache/pulsar/pull/23002#issuecomment-2210359336 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [fix][broker] Replication stuck when partitions count between two clusters is not the same [pulsar]

2024-07-05 Thread via GitHub
poorbarcode commented on PR #22983: URL: https://github.com/apache/pulsar/pull/22983#issuecomment-2210358547 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-05 Thread via GitHub
ivan-penchev commented on PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#issuecomment-2210350936 If everyone is OK with the suggested changes, would someone be able to merge this in? cc @nodece @crossoverJie @RobertIndie -- This is an automated message from the

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-04 Thread via GitHub
ivan-penchev commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1666321239 ## pulsar/log/wrapper_slog_test.go: ## @@ -0,0 +1,49 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-04 Thread via GitHub
ivan-penchev commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1666321239 ## pulsar/log/wrapper_slog_test.go: ## @@ -0,0 +1,49 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-04 Thread via GitHub
ivan-penchev commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1666321239 ## pulsar/log/wrapper_slog_test.go: ## @@ -0,0 +1,49 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-04 Thread via GitHub
ivan-penchev commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1666286324 ## README.md: ## @@ -152,7 +152,7 @@ Run the tests: Run the tests with specific versions of GOLANG and PULSAR: -make test GOLANG_VERSION=1.20

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-04 Thread via GitHub
ivan-penchev commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1666286324 ## README.md: ## @@ -152,7 +152,7 @@ Run the tests: Run the tests with specific versions of GOLANG and PULSAR: -make test GOLANG_VERSION=1.20

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-04 Thread via GitHub
nodece commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1666194036 ## pulsar/log/wrapper_slog_test.go: ## @@ -0,0 +1,49 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-04 Thread via GitHub
nodece commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1666190182 ## README.md: ## @@ -152,7 +152,7 @@ Run the tests: Run the tests with specific versions of GOLANG and PULSAR: -make test GOLANG_VERSION=1.20

Re: [PR] [fix][broker] Fix MessageDeduplication replay timeout cause topic loading stuck [pulsar]

2024-07-04 Thread via GitHub
TakaHiR07 commented on code in PR #23004: URL: https://github.com/apache/pulsar/pull/23004#discussion_r1666176443 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/TopicDuplicationTest.java: ## @@ -529,6 +538,89 @@ public void

Re: [PR] [fix][broker] Fix MessageDeduplication replay timeout cause topic loading stuck [pulsar]

2024-07-04 Thread via GitHub
TakaHiR07 commented on code in PR #23004: URL: https://github.com/apache/pulsar/pull/23004#discussion_r1666175402 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/TopicDuplicationTest.java: ## @@ -529,6 +538,88 @@ public void

Re: [PR] [fix][broker] The topic might reference a closed ledger [pulsar]

2024-07-04 Thread via GitHub
TakaHiR07 commented on PR #22860: URL: https://github.com/apache/pulsar/pull/22860#issuecomment-2209878165 > 1. When the broker loads a topic and times it out, it should not complete the future to the client before closing all resources. This way seems better. -- This is

Re: [PR] [fix][broker] Fix MessageDeduplication replay timeout cause topic loading stuck [pulsar]

2024-07-04 Thread via GitHub
shibd commented on code in PR #23004: URL: https://github.com/apache/pulsar/pull/23004#discussion_r1666137904 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/TopicDuplicationTest.java: ## @@ -529,6 +538,88 @@ public void

Re: [I] [Bug][broker] MessageDeduplication replay timeout would cause topic loading stuck and become unavailable [pulsar]

2024-07-04 Thread via GitHub
shibd commented on issue #23003: URL: https://github.com/apache/pulsar/issues/23003#issuecomment-2209762114 > The reason is if topic loading timeout, the topic would close. However, topic close and takeSnapshot is executed concurrently, so takeSnapshot may throw exception since topic has

Re: [PR] [fix][broker] The topic might reference a closed ledger [pulsar]

2024-07-04 Thread via GitHub
shibd commented on PR #22860: URL: https://github.com/apache/pulsar/pull/22860#issuecomment-2209737237 > client can acquire the timeout response immediately and retry. Yes, you are right. Maybe we need improve client, when get a timoutexception, don't be so aggressive in retrying.

[PR] [feat][misc] PIP-264: Copy OpenTelemetry resource attributes to Prometheus labels [pulsar]

2024-07-04 Thread via GitHub
dragosvictor opened a new pull request, #23005: URL: https://github.com/apache/pulsar/pull/23005 [PIP-264](https://github.com/apache/pulsar/blob/master/pip/pip-264.md) ### Motivation The OpenTelemetry collector can be configured to expose the metrics as a Prometheus server,

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-04 Thread via GitHub
nodece commented on PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#issuecomment-2209260330 > 1. Where should I place the test? You can write a test in the `pulsar/client_impl_with_slog_test.go`. > 2. What should I be testing? (that producer and consumer do

Re: [PR] [fix][client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

2024-07-04 Thread via GitHub
poorbarcode commented on code in PR #22854: URL: https://github.com/apache/pulsar/pull/22854#discussion_r1665801286 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java: ## @@ -585,19 +585,28 @@ private CompletableFuture>

Re: [PR] [fix][client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

2024-07-04 Thread via GitHub
poorbarcode commented on code in PR #22854: URL: https://github.com/apache/pulsar/pull/22854#discussion_r1665797519 ## pulsar-broker/src/test/java/org/apache/pulsar/client/impl/LookupServiceTest.java: ## @@ -108,8 +108,8 @@ public void testGetTopicsOfGetTopicsResult(boolean

Re: [PR] [fix][client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

2024-07-04 Thread via GitHub
mattisonchao commented on code in PR #22854: URL: https://github.com/apache/pulsar/pull/22854#discussion_r1665793987 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java: ## @@ -585,19 +585,28 @@ private CompletableFuture>

Re: [PR] [fix][client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

2024-07-04 Thread via GitHub
mattisonchao commented on code in PR #22854: URL: https://github.com/apache/pulsar/pull/22854#discussion_r1665793987 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java: ## @@ -585,19 +585,28 @@ private CompletableFuture>

Re: [PR] [fix][client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

2024-07-04 Thread via GitHub
mattisonchao commented on code in PR #22854: URL: https://github.com/apache/pulsar/pull/22854#discussion_r1665785500 ## pulsar-broker/src/test/java/org/apache/pulsar/client/impl/LookupServiceTest.java: ## @@ -108,8 +108,8 @@ public void testGetTopicsOfGetTopicsResult(boolean

Re: [PR] [fix][broker] Fix MessageDeduplication replay timeout cause topic loading stuck [pulsar]

2024-07-04 Thread via GitHub
BewareMyPower commented on code in PR #23004: URL: https://github.com/apache/pulsar/pull/23004#discussion_r1665659571 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/TopicDuplicationTest.java: ## @@ -529,6 +538,89 @@ public void

[PR] [fix][broker] Fix MessageDeduplication replay timeout cause topic loading stuck [pulsar]

2024-07-04 Thread via GitHub
TakaHiR07 opened a new pull request, #23004: URL: https://github.com/apache/pulsar/pull/23004 Fixes https://github.com/apache/pulsar/issues/23003 ### Motivation As shown in the issue. fix the risk of topic loading stuck. ### Modifications 1. make takeSnapshot()

[I] [Bug][broker] MessageDeduplication replay timeout would cause topic loading stuck and become unavailable [pulsar]

2024-07-04 Thread via GitHub
TakaHiR07 opened a new issue, #23003: URL: https://github.com/apache/pulsar/issues/23003 ### Search before asking - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar. ### Read release policy - [X] I understand that

[PR] [improve][admin] Improve error message when attempt to delete a partitioned topic with a wrong API [pulsar]

2024-07-04 Thread via GitHub
poorbarcode opened a new pull request, #23002: URL: https://github.com/apache/pulsar/pull/23002 ### Motivation & Modifications The correct usage of deleting topics: - `non-partitioned`: `pulsar-admin topics delete ` - `partitioned`: `pulsar-admin topics delete-partitioned-topic

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-04 Thread via GitHub
ivan-penchev commented on PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#issuecomment-2208768095 > @ivan-penchev I noticed this PR doesn't add a test, could you add a test for the producer and consumer with this logger? @nodece I appreciate the need for a test

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-04 Thread via GitHub
nodece commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1665562539 ## go.mod: ## @@ -1,6 +1,6 @@ module github.com/apache/pulsar-client-go -go 1.18 +go 1.20 Review Comment: Good catch, this should be 1.20. --

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-04 Thread via GitHub
nodece commented on PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#issuecomment-2208723135 @ivan-penchev I noticed this PR doesn't add a test, could you add a test for the producer and consumer with this logger? -- This is an automated message from the Apache Git

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-04 Thread via GitHub
ivan-penchev commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1665552093 ## pulsar/log/wrapper_slog.go: ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-04 Thread via GitHub
ivan-penchev commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1665547176 ## pulsar/log/wrapper_slog.go: ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-04 Thread via GitHub
nodece commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1665495312 ## pulsar/log/wrapper_slog.go: ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-04 Thread via GitHub
nodece commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1665491465 ## README.md: ## @@ -38,7 +38,7 @@ CGo-based library. ## Requirements -- Go 1.20+ +- Go 1.21+ Review Comment: Revert. ## README.md:

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-04 Thread via GitHub
nodece commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1665491316 ## README.md: ## @@ -152,7 +152,7 @@ Run the tests: Run the tests with specific versions of GOLANG and PULSAR: -make test GOLANG_VERSION=1.20

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-04 Thread via GitHub
nodece commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1665490761 ## pulsar/log/wrapper_slog.go: ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-04 Thread via GitHub
nodece commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1665490761 ## pulsar/log/wrapper_slog.go: ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-04 Thread via GitHub
nodece commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1665485246 ## pulsar/log/wrapper_slog.go: ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] [fix][ci] Fix OWASP Dependency Check download by using NVD API key [pulsar]

2024-07-04 Thread via GitHub
lhotari merged PR #22999: URL: https://github.com/apache/pulsar/pull/22999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [fix][client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

2024-07-04 Thread via GitHub
codecov-commenter commented on PR #22854: URL: https://github.com/apache/pulsar/pull/22854#issuecomment-2208505903 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/22854?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-04 Thread via GitHub
crossoverJie commented on PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#issuecomment-2208412685 > Edit: @crossoverJie I decided to give the upgrade a chance, after reading go's release policy. I hope I haven't done anything bad. I have no objections to

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-04 Thread via GitHub
ivan-penchev commented on PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#issuecomment-2208336183 > @ivan-penchev In this [PR](https://github.com/apache/pulsar-client-go/pull/1230), the Go version is upgraded to a minimum of 1.20, but the slog package is officially

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-04 Thread via GitHub
ivan-penchev commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1665275431 ## pulsar/log/wrapper_slog.go: ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license

Re: [PR] [CI] Use macos-12 to build macOS libraries [pulsar-client-cpp]

2024-07-04 Thread via GitHub
merlimat merged PR #433: URL: https://github.com/apache/pulsar-client-cpp/pull/433 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [improve][pip] PIP-337: SSL Factory Plugin to customize SSL Context and SSL Engine generation [pulsar]

2024-07-04 Thread via GitHub
merlimat merged PR #22016: URL: https://github.com/apache/pulsar/pull/22016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] [CI] Use macos-12 to build macOS libraries [pulsar-client-cpp]

2024-07-03 Thread via GitHub
BewareMyPower opened a new pull request, #433: URL: https://github.com/apache/pulsar-client-cpp/pull/433 The release workflow is broken because it uses `macos-latest` runner, which is now macOS 14 Arm64, see https://github.com/actions/runner-images ``` + pip3 install pyyaml

Re: [I] [Bug] [broker] subscription of topic in a permanent fence state and consumerList remain offline consumer [pulsar]

2024-07-03 Thread via GitHub
TakaHiR07 closed issue #20576: [Bug] [broker] subscription of topic in a permanent fence state and consumerList remain offline consumer URL: https://github.com/apache/pulsar/issues/20576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] [Bug] [broker] subscription of topic in a permanent fence state and consumerList remain offline consumer [pulsar]

2024-07-03 Thread via GitHub
TakaHiR07 commented on issue #20576: URL: https://github.com/apache/pulsar/issues/20576#issuecomment-2207953143 https://github.com/apache/pulsar/pull/22283 has fixed the same problem. Close it -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] [Bug] Can not cleanup heartbeat data if scaling down broker [pulsar]

2024-07-03 Thread via GitHub
TakaHiR07 closed issue #21324: [Bug] Can not cleanup heartbeat data if scaling down broker URL: https://github.com/apache/pulsar/issues/21324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] [Bug] Can not cleanup heartbeat data if scaling down broker [pulsar]

2024-07-03 Thread via GitHub
TakaHiR07 commented on issue #21324: URL: https://github.com/apache/pulsar/issues/21324#issuecomment-2207951787 issue has fixed. close it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [fix][broker] The topic might reference a closed ledger [pulsar]

2024-07-03 Thread via GitHub
TakaHiR07 commented on PR #22860: URL: https://github.com/apache/pulsar/pull/22860#issuecomment-2207948571 @shibd I have a concern about this pr. After this pr, the process is "topicFuture timeout -> close topic -> remove topicFuture". During the "close topic", client can acquire the

Re: [I] ackReq Variable Assignment in Code [pulsar-client-go]

2024-07-03 Thread via GitHub
crossoverJie closed issue #1233: ackReq Variable Assignment in Code URL: https://github.com/apache/pulsar-client-go/issues/1233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [Issue 1233] Fix the issue where the AckIDCumulativ cannot return error. [pulsar-client-go]

2024-07-03 Thread via GitHub
crossoverJie merged PR #1235: URL: https://github.com/apache/pulsar-client-go/pull/1235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-03 Thread via GitHub
crossoverJie commented on code in PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#discussion_r1665013908 ## pulsar/log/wrapper_slog.go: ## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license

Re: [PR] [feat] added a slog wrapper of the logger interface [pulsar-client-go]

2024-07-03 Thread via GitHub
crossoverJie commented on PR #1234: URL: https://github.com/apache/pulsar-client-go/pull/1234#issuecomment-2207890261 @ivan-penchev In this [PR](https://github.com/apache/pulsar-client-go/pull/1230), the Go version is upgraded to a minimum of 1.20, but the slog package is officially used

Re: [PR] Add -Bsymbolic link option to avoid symbol interposition [pulsar-client-cpp]

2024-07-03 Thread via GitHub
BewareMyPower merged PR #432: URL: https://github.com/apache/pulsar-client-cpp/pull/432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [fix][broker] Can't connecte to non-persist topic when enable broker client tls [pulsar]

2024-07-03 Thread via GitHub
shibd merged PR #22991: URL: https://github.com/apache/pulsar/pull/22991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Dmisca pip 264 managed cursor metrics [pulsar]

2024-07-03 Thread via GitHub
dragosvictor opened a new pull request, #23000: URL: https://github.com/apache/pulsar/pull/23000 [PIP-264](https://github.com/apache/pulsar/blob/master/pip/pip-264.md) ### Motivation Adds Managed Cursor metrics, as currently described

  1   2   3   4   5   6   7   8   9   10   >