[GitHub] [pulsar] Technoboy- commented on a change in pull request #13383: Fix batch message ack does not decrease the unacked-msg count.

2022-01-26 Thread GitBox
Technoboy- commented on a change in pull request #13383: URL: https://github.com/apache/pulsar/pull/13383#discussion_r792407746 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BatchMessageWithBatchIndexLevelTest.java ## @@ -0,0 +1,104 @@ +/** + * Lic

[GitHub] [pulsar] Technoboy- commented on a change in pull request #13383: Fix batch message ack does not decrease the unacked-msg count.

2022-01-25 Thread GitBox
Technoboy- commented on a change in pull request #13383: URL: https://github.com/apache/pulsar/pull/13383#discussion_r791445391 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BatchMessageWithBatchIndexLevelTest.java ## @@ -0,0 +1,104 @@ +/** + * Lic

[GitHub] [pulsar] Technoboy- commented on a change in pull request #13383: Fix batch message ack does not decrease the unacked-msg count.

2022-01-25 Thread GitBox
Technoboy- commented on a change in pull request #13383: URL: https://github.com/apache/pulsar/pull/13383#discussion_r791445478 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BatchMessageWithBatchIndexLevelTest.java ## @@ -0,0 +1,104 @@ +/** + * Lic

[GitHub] [pulsar] Technoboy- commented on a change in pull request #13383: Fix batch message ack does not decrease the unacked-msg count.

2022-01-25 Thread GitBox
Technoboy- commented on a change in pull request #13383: URL: https://github.com/apache/pulsar/pull/13383#discussion_r791791059 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BatchMessageWithBatchIndexLevelTest.java ## @@ -0,0 +1,104 @@ +/** + * Lic

[GitHub] [pulsar] Technoboy- commented on a change in pull request #13383: Fix batch message ack does not decrease the unacked-msg count.

2022-01-25 Thread GitBox
Technoboy- commented on a change in pull request #13383: URL: https://github.com/apache/pulsar/pull/13383#discussion_r791790929 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BatchMessageWithBatchIndexLevelTest.java ## @@ -0,0 +1,104 @@ +/** + * Lic

[GitHub] [pulsar] Technoboy- commented on a change in pull request #13383: Fix batch message ack does not decrease the unacked-msg count.

2022-01-25 Thread GitBox
Technoboy- commented on a change in pull request #13383: URL: https://github.com/apache/pulsar/pull/13383#discussion_r791445391 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BatchMessageWithBatchIndexLevelTest.java ## @@ -0,0 +1,104 @@ +/** + * Lic

[GitHub] [pulsar] Technoboy- commented on a change in pull request #13383: Fix batch message ack does not decrease the unacked-msg count.

2022-01-24 Thread GitBox
Technoboy- commented on a change in pull request #13383: URL: https://github.com/apache/pulsar/pull/13383#discussion_r790732767 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java ## @@ -489,6 +562,31 @@ private void checkCanRemovePendingA

[GitHub] [pulsar] Technoboy- commented on a change in pull request #13383: Fix batch message ack does not decrease the unacked-msg count.

2022-01-24 Thread GitBox
Technoboy- commented on a change in pull request #13383: URL: https://github.com/apache/pulsar/pull/13383#discussion_r790727164 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BatchMessageWithBatchIndexLevelTest.java ## @@ -0,0 +1,104 @@ +/** + * Lic

[GitHub] [pulsar] Technoboy- commented on a change in pull request #13383: Fix batch message ack does not decrease the unacked-msg count.

2022-01-24 Thread GitBox
Technoboy- commented on a change in pull request #13383: URL: https://github.com/apache/pulsar/pull/13383#discussion_r790723071 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BatchMessageWithBatchIndexLevelTest.java ## @@ -0,0 +1,104 @@ +/** + * Lic

[GitHub] [pulsar] Technoboy- commented on a change in pull request #13383: Fix batch message ack does not decrease the unacked-msg count.

2022-01-24 Thread GitBox
Technoboy- commented on a change in pull request #13383: URL: https://github.com/apache/pulsar/pull/13383#discussion_r790721977 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java ## @@ -811,8 +916,15 @@ public Subscription getSubscription(

[GitHub] [pulsar] Technoboy- commented on a change in pull request #13383: Fix batch message ack does not decrease the unacked-msg count.

2022-01-11 Thread GitBox
Technoboy- commented on a change in pull request #13383: URL: https://github.com/apache/pulsar/pull/13383#discussion_r782043369 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java ## @@ -243,11 +246,16 @@ public boolean readCompacted() {

[GitHub] [pulsar] Technoboy- commented on a change in pull request #13383: Fix batch message ack does not decrease the unacked-msg count.

2022-01-10 Thread GitBox
Technoboy- commented on a change in pull request #13383: URL: https://github.com/apache/pulsar/pull/13383#discussion_r778584096 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java ## @@ -776,6 +863,12 @@ public void redeliverUnacknowledged

[GitHub] [pulsar] Technoboy- commented on a change in pull request #13383: Fix batch message ack does not decrease the unacked-msg count.

2022-01-10 Thread GitBox
Technoboy- commented on a change in pull request #13383: URL: https://github.com/apache/pulsar/pull/13383#discussion_r781747342 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java ## @@ -776,6 +863,12 @@ public void redeliverUnacknowledged

[GitHub] [pulsar] Technoboy- commented on a change in pull request #13383: Fix batch message ack does not decrease the unacked-msg count.

2022-01-05 Thread GitBox
Technoboy- commented on a change in pull request #13383: URL: https://github.com/apache/pulsar/pull/13383#discussion_r779259574 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java ## @@ -476,6 +499,46 @@ public void doUnsubscribe(final long

[GitHub] [pulsar] Technoboy- commented on a change in pull request #13383: Fix batch message ack does not decrease the unacked-msg count.

2022-01-04 Thread GitBox
Technoboy- commented on a change in pull request #13383: URL: https://github.com/apache/pulsar/pull/13383#discussion_r778584096 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java ## @@ -776,6 +863,12 @@ public void redeliverUnacknowledged

[GitHub] [pulsar] Technoboy- commented on a change in pull request #13383: Fix batch message ack does not decrease the unacked-msg count.

2022-01-04 Thread GitBox
Technoboy- commented on a change in pull request #13383: URL: https://github.com/apache/pulsar/pull/13383#discussion_r778582148 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BatchMessageTest.java ## @@ -673,7 +673,7 @@ public void testBatchAndNonB

[GitHub] [pulsar] Technoboy- commented on a change in pull request #13383: Fix batch message ack does not decrease the unacked-msg count.

2022-01-04 Thread GitBox
Technoboy- commented on a change in pull request #13383: URL: https://github.com/apache/pulsar/pull/13383#discussion_r778581278 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java ## @@ -476,6 +499,46 @@ public void doUnsubscribe(final long

[GitHub] [pulsar] Technoboy- commented on a change in pull request #13383: Fix batch message ack does not decrease the unacked-msg count.

2022-01-04 Thread GitBox
Technoboy- commented on a change in pull request #13383: URL: https://github.com/apache/pulsar/pull/13383#discussion_r778581076 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java ## @@ -476,6 +499,46 @@ public void doUnsubscribe(final long

[GitHub] [pulsar] Technoboy- commented on a change in pull request #13383: Fix batch message ack does not decrease the unacked-msg count.

2021-12-29 Thread GitBox
Technoboy- commented on a change in pull request #13383: URL: https://github.com/apache/pulsar/pull/13383#discussion_r776562811 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BatchMessageTest.java ## @@ -66,6 +68,7 @@ @BeforeClass @Overrid

[GitHub] [pulsar] Technoboy- commented on a change in pull request #13383: Fix batch message ack does not decrease the unacked-msg count.

2021-12-29 Thread GitBox
Technoboy- commented on a change in pull request #13383: URL: https://github.com/apache/pulsar/pull/13383#discussion_r776562702 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java ## @@ -476,6 +499,46 @@ public void doUnsubscribe(final long

[GitHub] [pulsar] Technoboy- commented on a change in pull request #13383: Fix batch message ack does not decrease the unacked-msg count.

2021-12-29 Thread GitBox
Technoboy- commented on a change in pull request #13383: URL: https://github.com/apache/pulsar/pull/13383#discussion_r776356504 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java ## @@ -489,6 +552,31 @@ private void checkCanRemovePendingA

[GitHub] [pulsar] Technoboy- commented on a change in pull request #13383: Fix batch message ack does not decrease the unacked-msg count.

2021-12-29 Thread GitBox
Technoboy- commented on a change in pull request #13383: URL: https://github.com/apache/pulsar/pull/13383#discussion_r776353126 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java ## @@ -233,7 +236,7 @@ public boolean readCompacted() {

[GitHub] [pulsar] Technoboy- commented on a change in pull request #13383: Fix batch message ack does not decrease the unacked-msg count.

2021-12-29 Thread GitBox
Technoboy- commented on a change in pull request #13383: URL: https://github.com/apache/pulsar/pull/13383#discussion_r776352072 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java ## @@ -1815,13 +1815,13 @@ public void testUna