dlg99 commented on pull request #9927:
URL: https://github.com/apache/pulsar/pull/9927#issuecomment-843567096
@sijie please take another look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dlg99 commented on pull request #9927:
URL: https://github.com/apache/pulsar/pull/9927#issuecomment-822641966
rebased on latest master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
dlg99 commented on pull request #9927:
URL: https://github.com/apache/pulsar/pull/9927#issuecomment-805384033
updated to reflect CR comments (except some that affect pulsar-io/context
and can be done separately/later)
rebased on top of https://github.com/apache/pulsar/pull/9947
--
Thi
dlg99 commented on pull request #9927:
URL: https://github.com/apache/pulsar/pull/9927#issuecomment-800665584
> I am not much convinced about the final packaging, because if you want to
run an existing Kafka Sink you have to build this module and add that Sink as
dependency (this is the sa
dlg99 commented on pull request #9927:
URL: https://github.com/apache/pulsar/pull/9927#issuecomment-800539993
@yuvalgut thank you!
I postponed dealing with GenericRecords for now to make use of the changes
@eolivelli is working on, i.e. https://github.com/apache/pulsar/issues/9844
---
dlg99 commented on pull request #9927:
URL: https://github.com/apache/pulsar/pull/9927#issuecomment-800524060
this replaces https://github.com/apache/pulsar/pull/9825 - reworked
according to @sijie 's feedback
@sijie and @eolivelli please take a look.
--
