[GitHub] [pulsar] gmethvin commented on a change in pull request #9440: [Issue 9438][pulsar-client] Fix inconsistent equals and hashCode for MessageIds

gmethvin commented on a change in pull request #9440: URL: https://github.com/apache/pulsar/pull/9440#discussion_r597308379 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/BatchMessageIdImpl.java ## @@ -18,17 +18,11 @@ */ package org.apache.pulsar.cl

[GitHub] [pulsar] gmethvin commented on a change in pull request #9440: [Issue 9438][pulsar-client] Fix inconsistent equals and hashCode for MessageIds

gmethvin commented on a change in pull request #9440: URL: https://github.com/apache/pulsar/pull/9440#discussion_r597305928 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageIdImpl.java ## @@ -27,15 +27,22 @@ import io.netty.util.concurrent.FastTh

[GitHub] [pulsar] gmethvin commented on a change in pull request #9440: [Issue 9438][pulsar-client] Fix inconsistent equals and hashCode for MessageIds

gmethvin commented on a change in pull request #9440: URL: https://github.com/apache/pulsar/pull/9440#discussion_r569154763 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageIdImpl.java ## @@ -63,17 +78,17 @@ public int getPartitionIndex() {

[GitHub] [pulsar] gmethvin commented on a change in pull request #9440: [Issue 9438][pulsar-client] Fix inconsistent equals and hashCode for MessageIds

gmethvin commented on a change in pull request #9440: URL: https://github.com/apache/pulsar/pull/9440#discussion_r569154763 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageIdImpl.java ## @@ -63,17 +78,17 @@ public int getPartitionIndex() {