[GitHub] [pulsar] hangc0276 commented on pull request #6776: [Docs] Fix the Create subscribtion swagger of PersistentTopic

2020-04-25 Thread GitBox
hangc0276 commented on pull request #6776: URL: https://github.com/apache/pulsar/pull/6776#issuecomment-619477045 > > But i am afraid your present implementation will compile failed due to lack of `MessageIdImpl` constructor for `@QueryParam("messageId") @DefaultValue("latest") MessageIdIm

[GitHub] [pulsar] hangc0276 commented on pull request #6776: [Docs] Fix the Create subscribtion swagger of PersistentTopic

2020-04-25 Thread GitBox
hangc0276 commented on pull request #6776: URL: https://github.com/apache/pulsar/pull/6776#issuecomment-619380515 > > > @hangc0276 Good catch! @wolfstudy could please help take a look the last comment? maybe you need to move the `messageId` to the end of params list. > > > > > >

[GitHub] [pulsar] hangc0276 commented on pull request #6776: [Docs] Fix the Create subscribtion swagger of PersistentTopic

2020-04-23 Thread GitBox
hangc0276 commented on pull request #6776: URL: https://github.com/apache/pulsar/pull/6776#issuecomment-618784699 > @hangc0276 Good catch! @wolfstudy could please help take a look the last comment? maybe you need to move the `messageId` to the end of params list. Thanks for your feed