[GitHub] [pulsar] merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-22 Thread GitBox
merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r277474379 ## File path: pulsar-client-go/pulsar/message.go ## @@ -66,6 +69,9 @@ type Message interface {

[GitHub] [pulsar] merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-20 Thread GitBox
merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r277129050 ## File path: pulsar-client-go/pulsar/client.go ## @@ -103,16 +103,22 @@ type Client interface {

[GitHub] [pulsar] merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-20 Thread GitBox
merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r277128960 ## File path: pulsar-client-go/pulsar/message.go ## @@ -66,6 +69,9 @@ type Message interface {

[GitHub] [pulsar] merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-20 Thread GitBox
merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r277129084 ## File path: pulsar-client-go/pulsar/c_message.go ## @@ -97,8 +98,8 @@ func buildMessage(message

[GitHub] [pulsar] merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276216671 ## File path: pulsar-client-go/pulsar/client.go ## @@ -101,17 +101,17 @@ type ClientOptions struct

[GitHub] [pulsar] merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-15 Thread GitBox
merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r275632050 ## File path: pulsar-client-go/pulsar/client.go ## @@ -101,17 +101,17 @@ type ClientOptions struct

[GitHub] [pulsar] merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-15 Thread GitBox
merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r275625941 ## File path: pulsar-client-go/pulsar/client.go ## @@ -101,17 +101,17 @@ type ClientOptions struct

[GitHub] [pulsar] merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-09 Thread GitBox
merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r273743033 ## File path: pulsar-client-go/pulsar/schema_test.go ## @@ -0,0 +1,502 @@ +// +// Licensed to the

[GitHub] [pulsar] merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-08 Thread GitBox
merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r273303793 ## File path: pulsar-client-go/pulsar/producer.go ## @@ -125,6 +125,12 @@ type ProducerOptions str

[GitHub] [pulsar] merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-08 Thread GitBox
merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r273302845 ## File path: pulsar-client-go/pulsar/producer.go ## @@ -125,6 +125,12 @@ type ProducerOptions str

[GitHub] [pulsar] merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-08 Thread GitBox
merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r273302868 ## File path: pulsar-client-go/pulsar/c_producer.go ## @@ -108,6 +108,14 @@ func createProducerAsy

[GitHub] [pulsar] merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-08 Thread GitBox
merlimat commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r273304065 ## File path: pulsar-client-go/pulsar/schema_test.go ## @@ -0,0 +1,502 @@ +// +// Licensed to the