[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-21 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r277198704 ## File path: pulsar-client-go/pulsar/message.go ## @@ -66,6 +69,9 @@ type Message interface {

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-21 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r277198704 ## File path: pulsar-client-go/pulsar/message.go ## @@ -66,6 +69,9 @@ type Message interface {

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-21 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r277194917 ## File path: pulsar-client-go/pulsar/message.go ## @@ -66,6 +69,9 @@ type Message interface {

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-21 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r277194917 ## File path: pulsar-client-go/pulsar/message.go ## @@ -66,6 +69,9 @@ type Message interface {

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-21 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r277193529 ## File path: pulsar-client-go/pulsar/client.go ## @@ -103,16 +103,22 @@ type Client interface {

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276512005 ## File path: pulsar-client-go/pulsar/client.go ## @@ -101,17 +101,17 @@ type ClientOptions struc

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276226983 ## File path: pulsar-client-go/pulsar/c_consumer.go ## @@ -109,6 +112,24 @@ func subscribeAsync(c

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276226983 ## File path: pulsar-client-go/pulsar/c_consumer.go ## @@ -109,6 +112,24 @@ func subscribeAsync(c

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276226983 ## File path: pulsar-client-go/pulsar/c_consumer.go ## @@ -109,6 +112,24 @@ func subscribeAsync(c

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276206700 ## File path: pulsar-client-go/pulsar/c_consumer.go ## @@ -109,6 +112,24 @@ func subscribeAsync(c

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276206700 ## File path: pulsar-client-go/pulsar/c_consumer.go ## @@ -109,6 +112,24 @@ func subscribeAsync(c

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-16 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276100708 ## File path: pulsar-client-go/pulsar/schema.go ## @@ -0,0 +1,494 @@ +// +// Licensed to the Apac

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-16 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276100825 ## File path: pulsar-client-go/pulsar/schema.go ## @@ -0,0 +1,494 @@ +// +// Licensed to the Apac

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-16 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276100532 ## File path: pulsar-client-go/pulsar/schema.go ## @@ -0,0 +1,494 @@ +// +// Licensed to the Apac

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-09 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r273766719 ## File path: pulsar-client-go/pulsar/schema_test.go ## @@ -0,0 +1,502 @@ +// +// Licensed to the

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-08 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r273318725 ## File path: pulsar-client-go/pulsar/schema_test.go ## @@ -0,0 +1,502 @@ +// +// Licensed to the

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-08 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r273318725 ## File path: pulsar-client-go/pulsar/schema_test.go ## @@ -0,0 +1,502 @@ +// +// Licensed to the

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-08 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r273318170 ## File path: pulsar-client-go/pulsar/schema_test.go ## @@ -0,0 +1,502 @@ +// +// Licensed to the

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-08 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r273311107 ## File path: pulsar-client-go/pulsar/c_producer.go ## @@ -108,6 +108,14 @@ func createProducerAs

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-02 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r271557770 ## File path: pulsar-client-go/pulsar/schema.go ## @@ -0,0 +1,306 @@ +// +// Licensed to the Apac

[GitHub] [pulsar] wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-01 Thread GitBox
wolfstudy commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r271115850 ## File path: pulsar-client-go/pulsar/binaryfreelist.go ## @@ -0,0 +1,318 @@ +// +// Licensed to