[GitHub] cckellogg commented on a change in pull request #2826: Secrets Interface

2018-10-26 Thread GitBox
cckellogg commented on a change in pull request #2826: Secrets Interface URL: https://github.com/apache/pulsar/pull/2826#discussion_r228576463 ## File path: pulsar-functions/instance/src/main/python/secretsprovider.py ## @@ -0,0 +1,61 @@ +#!/usr/bin/env python +# +#

[GitHub] cckellogg commented on a change in pull request #2826: Secrets Interface

2018-10-26 Thread GitBox
cckellogg commented on a change in pull request #2826: Secrets Interface URL: https://github.com/apache/pulsar/pull/2826#discussion_r228569533 ## File path: pulsar-functions/instance/src/main/python/secretsprovider.py ## @@ -0,0 +1,61 @@ +#!/usr/bin/env python +# +#

[GitHub] cckellogg commented on a change in pull request #2826: Secrets Interface

2018-10-23 Thread GitBox
cckellogg commented on a change in pull request #2826: Secrets Interface URL: https://github.com/apache/pulsar/pull/2826#discussion_r227603808 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/io/SinkConfig.java ## @@ -55,6 +55,7 @@ private Map

[GitHub] cckellogg commented on a change in pull request #2826: Secrets Interface

2018-10-23 Thread GitBox
cckellogg commented on a change in pull request #2826: Secrets Interface URL: https://github.com/apache/pulsar/pull/2826#discussion_r227602359 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeUtils.java ## @@ -136,6 +139,13

[GitHub] cckellogg commented on a change in pull request #2826: Secrets Interface

2018-10-23 Thread GitBox
cckellogg commented on a change in pull request #2826: Secrets Interface URL: https://github.com/apache/pulsar/pull/2826#discussion_r227602068 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/KubernetesRuntime.java ## @@ -519,12

[GitHub] cckellogg commented on a change in pull request #2826: Secrets Interface

2018-10-23 Thread GitBox
cckellogg commented on a change in pull request #2826: Secrets Interface URL: https://github.com/apache/pulsar/pull/2826#discussion_r227603808 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/io/SinkConfig.java ## @@ -55,6 +55,7 @@ private Map