[GitHub] david-streamlio commented on issue #2615: Azure offloader

2018-10-05 Thread GitBox
david-streamlio commented on issue #2615: Azure offloader URL: https://github.com/apache/pulsar/pull/2615#issuecomment-427405837 I am open to suggestions on how to split these up, but these changes are tightly coupled. I could remove the Glacier offloader, but that would be just one class.

[GitHub] david-streamlio commented on issue #2615: Azure offloader

2018-09-28 Thread GitBox
david-streamlio commented on issue #2615: Azure offloader URL: https://github.com/apache/pulsar/pull/2615#issuecomment-425484427 What is the expected behavior? So I can confirm the tests are correct. This is an automated m

[GitHub] david-streamlio commented on issue #2615: Azure offloader

2018-09-22 Thread GitBox
david-streamlio commented on issue #2615: Azure offloader URL: https://github.com/apache/pulsar/pull/2615#issuecomment-423765379 Where is the content for the doc page at https://pulsar.incubator.apache.org/docs/en/cookbooks-tiered-storage/? -

[GitHub] david-streamlio commented on issue #2615: Azure offloader

2018-09-21 Thread GitBox
david-streamlio commented on issue #2615: Azure offloader URL: https://github.com/apache/incubator-pulsar/pull/2615#issuecomment-423585237 @sijie Yes, I will update that document as well. This is an automated message from th

[GitHub] david-streamlio commented on issue #2615: Azure offloader

2018-09-21 Thread GitBox
david-streamlio commented on issue #2615: Azure offloader URL: https://github.com/apache/incubator-pulsar/pull/2615#issuecomment-423582999 I am in the process of updating the unit tests, as NONE of them actually used the constructor method that will be used in production. I thought this w