[GitHub] jerrypeng commented on a change in pull request #3021: adding windowed metrics for functions

2018-11-20 Thread GitBox
jerrypeng commented on a change in pull request #3021: adding windowed metrics for functions URL: https://github.com/apache/pulsar/pull/3021#discussion_r235104584 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/InstanceCache.java ###

[GitHub] jerrypeng commented on a change in pull request #3021: adding windowed metrics for functions

2018-11-20 Thread GitBox
jerrypeng commented on a change in pull request #3021: adding windowed metrics for functions URL: https://github.com/apache/pulsar/pull/3021#discussion_r235104150 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/FunctionsBase.java ## @@ -190,