[GitHub] jerrypeng commented on a change in pull request #3168: Refactor api commands

2018-12-20 Thread GitBox
jerrypeng commented on a change in pull request #3168: Refactor api commands URL: https://github.com/apache/pulsar/pull/3168#discussion_r243459531 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SinkBase.java ## @@ -85,15 +85,15 @@ public Resp

[GitHub] jerrypeng commented on a change in pull request #3168: Refactor api commands

2018-12-18 Thread GitBox
jerrypeng commented on a change in pull request #3168: Refactor api commands URL: https://github.com/apache/pulsar/pull/3168#discussion_r242739224 ## File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/ComponentImpl.java ## @@ -709,

[GitHub] jerrypeng commented on a change in pull request #3168: Refactor api commands

2018-12-17 Thread GitBox
jerrypeng commented on a change in pull request #3168: Refactor api commands URL: https://github.com/apache/pulsar/pull/3168#discussion_r242366045 ## File path: pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/rest/api/v2/FunctionApiV2ResourceTest.java #

[GitHub] jerrypeng commented on a change in pull request #3168: Refactor api commands

2018-12-17 Thread GitBox
jerrypeng commented on a change in pull request #3168: Refactor api commands URL: https://github.com/apache/pulsar/pull/3168#discussion_r242365206 ## File path: pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/rest/api/v2/SinkApiV2ResourceTest.java #

[GitHub] jerrypeng commented on a change in pull request #3168: Refactor api commands

2018-12-17 Thread GitBox
jerrypeng commented on a change in pull request #3168: Refactor api commands URL: https://github.com/apache/pulsar/pull/3168#discussion_r242365084 ## File path: pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/rest/api/v2/SourceApiV2ResourceTest.java ###

[GitHub] jerrypeng commented on a change in pull request #3168: Refactor api commands

2018-12-17 Thread GitBox
jerrypeng commented on a change in pull request #3168: Refactor api commands URL: https://github.com/apache/pulsar/pull/3168#discussion_r242364670 ## File path: pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/rest/api/v2/SourceApiV2ResourceTest.java ###

[GitHub] jerrypeng commented on a change in pull request #3168: Refactor api commands

2018-12-17 Thread GitBox
jerrypeng commented on a change in pull request #3168: Refactor api commands URL: https://github.com/apache/pulsar/pull/3168#discussion_r242364651 ## File path: pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/rest/api/v2/SourceApiV2ResourceTest.java ###

[GitHub] jerrypeng commented on a change in pull request #3168: Refactor api commands

2018-12-17 Thread GitBox
jerrypeng commented on a change in pull request #3168: Refactor api commands URL: https://github.com/apache/pulsar/pull/3168#discussion_r242364610 ## File path: pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/rest/api/v2/SourceApiV2ResourceTest.java ###

[GitHub] jerrypeng commented on a change in pull request #3168: Refactor api commands

2018-12-17 Thread GitBox
jerrypeng commented on a change in pull request #3168: Refactor api commands URL: https://github.com/apache/pulsar/pull/3168#discussion_r242364549 ## File path: pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/rest/api/v2/SourceApiV2ResourceTest.java ###

[GitHub] jerrypeng commented on a change in pull request #3168: Refactor api commands

2018-12-17 Thread GitBox
jerrypeng commented on a change in pull request #3168: Refactor api commands URL: https://github.com/apache/pulsar/pull/3168#discussion_r242364584 ## File path: pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/rest/api/v2/SourceApiV2ResourceTest.java ###

[GitHub] jerrypeng commented on a change in pull request #3168: Refactor api commands

2018-12-17 Thread GitBox
jerrypeng commented on a change in pull request #3168: Refactor api commands URL: https://github.com/apache/pulsar/pull/3168#discussion_r242364629 ## File path: pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/rest/api/v2/SourceApiV2ResourceTest.java ###

[GitHub] jerrypeng commented on a change in pull request #3168: Refactor api commands

2018-12-17 Thread GitBox
jerrypeng commented on a change in pull request #3168: Refactor api commands URL: https://github.com/apache/pulsar/pull/3168#discussion_r242364421 ## File path: pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/rest/api/v2/SourceApiV2ResourceTest.java ###

[GitHub] jerrypeng commented on a change in pull request #3168: Refactor api commands

2018-12-17 Thread GitBox
jerrypeng commented on a change in pull request #3168: Refactor api commands URL: https://github.com/apache/pulsar/pull/3168#discussion_r242364354 ## File path: pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/rest/api/v2/SourceApiV2ResourceTest.java ###

[GitHub] jerrypeng commented on a change in pull request #3168: Refactor api commands

2018-12-17 Thread GitBox
jerrypeng commented on a change in pull request #3168: Refactor api commands URL: https://github.com/apache/pulsar/pull/3168#discussion_r242364514 ## File path: pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/rest/api/v2/SourceApiV2ResourceTest.java ###

[GitHub] jerrypeng commented on a change in pull request #3168: Refactor api commands

2018-12-17 Thread GitBox
jerrypeng commented on a change in pull request #3168: Refactor api commands URL: https://github.com/apache/pulsar/pull/3168#discussion_r242364261 ## File path: pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/rest/api/v2/SourceApiV2ResourceTest.java ###

[GitHub] jerrypeng commented on a change in pull request #3168: Refactor api commands

2018-12-17 Thread GitBox
jerrypeng commented on a change in pull request #3168: Refactor api commands URL: https://github.com/apache/pulsar/pull/3168#discussion_r242363724 ## File path: pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/rest/api/v2/SinkApiV2ResourceTest.java #

[GitHub] jerrypeng commented on a change in pull request #3168: Refactor api commands

2018-12-17 Thread GitBox
jerrypeng commented on a change in pull request #3168: Refactor api commands URL: https://github.com/apache/pulsar/pull/3168#discussion_r242361509 ## File path: pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/rest/api/v2/FunctionApiV2ResourceTest.java #

[GitHub] jerrypeng commented on a change in pull request #3168: Refactor api commands

2018-12-17 Thread GitBox
jerrypeng commented on a change in pull request #3168: Refactor api commands URL: https://github.com/apache/pulsar/pull/3168#discussion_r242359693 ## File path: pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/rest/api/v2/FunctionApiV2ResourceTest.java #

[GitHub] jerrypeng commented on a change in pull request #3168: Refactor api commands

2018-12-17 Thread GitBox
jerrypeng commented on a change in pull request #3168: Refactor api commands URL: https://github.com/apache/pulsar/pull/3168#discussion_r242357780 ## File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/v2/FunctionApiV2Resource.java #

[GitHub] jerrypeng commented on a change in pull request #3168: Refactor api commands

2018-12-17 Thread GitBox
jerrypeng commented on a change in pull request #3168: Refactor api commands URL: https://github.com/apache/pulsar/pull/3168#discussion_r242357200 ## File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/ComponentImpl.java ## @@ -1145

[GitHub] jerrypeng commented on a change in pull request #3168: Refactor api commands

2018-12-14 Thread GitBox
jerrypeng commented on a change in pull request #3168: Refactor api commands URL: https://github.com/apache/pulsar/pull/3168#discussion_r241917310 ## File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/v2/FunctionApiV2Resource.java #

[GitHub] jerrypeng commented on a change in pull request #3168: Refactor api commands

2018-12-14 Thread GitBox
jerrypeng commented on a change in pull request #3168: Refactor api commands URL: https://github.com/apache/pulsar/pull/3168#discussion_r241917310 ## File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/v2/FunctionApiV2Resource.java #

[GitHub] jerrypeng commented on a change in pull request #3168: Refactor api commands

2018-12-13 Thread GitBox
jerrypeng commented on a change in pull request #3168: Refactor api commands URL: https://github.com/apache/pulsar/pull/3168#discussion_r241553679 ## File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/SourceImpl.java ## @@ -244,4 +

[GitHub] jerrypeng commented on a change in pull request #3168: Refactor api commands

2018-12-13 Thread GitBox
jerrypeng commented on a change in pull request #3168: Refactor api commands URL: https://github.com/apache/pulsar/pull/3168#discussion_r241553592 ## File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/SinkImpl.java ## @@ -249,4 +25

[GitHub] jerrypeng commented on a change in pull request #3168: Refactor api commands

2018-12-13 Thread GitBox
jerrypeng commented on a change in pull request #3168: Refactor api commands URL: https://github.com/apache/pulsar/pull/3168#discussion_r241552558 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SinkBase.java ## @@ -85,15 +85,15 @@ public Resp