[GitHub] jerrypeng commented on issue #3678: [Pulsar Functions] Add support for multiple sinks/sources in a single NAR file.

2019-02-25 Thread GitBox
jerrypeng commented on issue #3678: [Pulsar Functions] Add support for multiple sinks/sources in a single NAR file. URL: https://github.com/apache/pulsar/pull/3678#issuecomment-467158197 @david-streamlio please revert back the change in pulsar_tools_env.sh and I think we are good to go. Th

[GitHub] jerrypeng commented on issue #3678: [Pulsar Functions] Add support for multiple sinks/sources in a single NAR file.

2019-02-25 Thread GitBox
jerrypeng commented on issue #3678: [Pulsar Functions] Add support for multiple sinks/sources in a single NAR file. URL: https://github.com/apache/pulsar/pull/3678#issuecomment-467157593 @david-streamlio ok that sounds good to me. Just making sure all code paths are covered. -

[GitHub] jerrypeng commented on issue #3678: [Pulsar Functions] Add support for multiple sinks/sources in a single NAR file.

2019-02-24 Thread GitBox
jerrypeng commented on issue #3678: [Pulsar Functions] Add support for multiple sinks/sources in a single NAR file. URL: https://github.com/apache/pulsar/pull/3678#issuecomment-466885922 @david-streamlio so for this NAR you built, pulsar-aws-nar-0.0.1.nar, with multiple sources and sinks,

[GitHub] jerrypeng commented on issue #3678: [Pulsar Functions] Add support for multiple sinks/sources in a single NAR file.

2019-02-24 Thread GitBox
jerrypeng commented on issue #3678: [Pulsar Functions] Add support for multiple sinks/sources in a single NAR file. URL: https://github.com/apache/pulsar/pull/3678#issuecomment-466881983 @david-streamlio this PR looks good to me, but I am unclear how the changes in the PR makes submitting

[GitHub] jerrypeng commented on issue #3678: [Pulsar Functions] Add support for multiple sinks/sources in a single NAR file.

2019-02-24 Thread GitBox
jerrypeng commented on issue #3678: [Pulsar Functions] Add support for multiple sinks/sources in a single NAR file. URL: https://github.com/apache/pulsar/pull/3678#issuecomment-466876485 @david-streamlio so which multiple sources/sinks packaged in a single NAR I would use the specify the c