RobertIndie commented on PR #1244:
URL:
https://github.com/apache/pulsar-client-go/pull/1244#issuecomment-2247617825
> @RobertIndie
>
> So the linting succeeded this time.
>
> Do you know what the process is when this is merged in on how the updated
go package is applied to th
RobertIndie merged PR #1244:
URL: https://github.com/apache/pulsar-client-go/pull/1244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr.
Nikolajls commented on PR #1244:
URL:
https://github.com/apache/pulsar-client-go/pull/1244#issuecomment-2247116184
@RobertIndie
So the linting succeeded this time.
Do you know what the process is when this is merged in on how the updated go
package is applied to the Pulsarctl
Nikolajls commented on PR #1244:
URL:
https://github.com/apache/pulsar-client-go/pull/1244#issuecomment-2245162447
> > @RobertIndie Just pushed a commit that should fix the linting issue, and
thank you!
>
> @Nikolajls There are still lint issues. BTW, you can run `make lint` to
chec
RobertIndie commented on PR #1244:
URL:
https://github.com/apache/pulsar-client-go/pull/1244#issuecomment-2245151605
> @RobertIndie Just pushed a commit that should fix the linting issue, and
thank you!
@Nikolajls There are still lint issues. BTW, you can run `make lint` to
check fo
Nikolajls commented on PR #1244:
URL:
https://github.com/apache/pulsar-client-go/pull/1244#issuecomment-2244988150
@RobertIndie Just pushed a commit that should fix the linting issue, and
thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message,
Nikolajls commented on code in PR #1244:
URL: https://github.com/apache/pulsar-client-go/pull/1244#discussion_r1687509325
##
oauth2/client_credentials_provider_test.go:
##
@@ -34,12 +34,14 @@ func TestNewClientCredentialsProviderFromKeyFile(t
*testing.T) {
ClientSecret
RobertIndie commented on code in PR #1244:
URL: https://github.com/apache/pulsar-client-go/pull/1244#discussion_r1687870287
##
oauth2/client_credentials_provider_test.go:
##
@@ -34,12 +34,14 @@ func TestNewClientCredentialsProviderFromKeyFile(t
*testing.T) {
ClientSecre
Nikolajls commented on code in PR #1244:
URL: https://github.com/apache/pulsar-client-go/pull/1244#discussion_r1687509325
##
oauth2/client_credentials_provider_test.go:
##
@@ -34,12 +34,14 @@ func TestNewClientCredentialsProviderFromKeyFile(t
*testing.T) {
ClientSecret
Nikolajls commented on code in PR #1244:
URL: https://github.com/apache/pulsar-client-go/pull/1244#discussion_r1686359489
##
oauth2/client_credentials_provider_test.go:
##
@@ -34,12 +34,14 @@ func TestNewClientCredentialsProviderFromKeyFile(t
*testing.T) {
ClientSecret
RobertIndie commented on code in PR #1244:
URL: https://github.com/apache/pulsar-client-go/pull/1244#discussion_r1686322894
##
oauth2/client_credentials_provider_test.go:
##
@@ -34,12 +34,14 @@ func TestNewClientCredentialsProviderFromKeyFile(t
*testing.T) {
ClientSecre
Nikolajls opened a new pull request, #1244:
URL: https://github.com/apache/pulsar-client-go/pull/1244
*(If this PR fixes a github issue, please add `Fixes #`.)*
Fixes #
*(or if this PR is one task of a github issue, please add `Master Issue:
#` to link to the master iss
12 matches
Mail list logo
