Re: [PR] [feat][misc] PIP-264: Add OpenTelemetry messaging rate limit metrics [pulsar]

2024-07-23 Thread via GitHub
heesung-sn merged PR #23035: URL: https://github.com/apache/pulsar/pull/23035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [feat][misc] PIP-264: Add OpenTelemetry messaging rate limit metrics [pulsar]

2024-07-17 Thread via GitHub
heesung-sn commented on code in PR #23035: URL: https://github.com/apache/pulsar/pull/23035#discussion_r1681403752 ## pulsar-opentelemetry/src/main/java/org/apache/pulsar/opentelemetry/OpenTelemetryAttributes.java: ## @@ -112,6 +112,17 @@ public interface

Re: [PR] [feat][misc] PIP-264: Add OpenTelemetry messaging rate limit metrics [pulsar]

2024-07-16 Thread via GitHub
dragosvictor commented on code in PR #23035: URL: https://github.com/apache/pulsar/pull/23035#discussion_r1680352885 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -3691,16 +3708,22 @@ public boolean isBrokerPayloadProcessorEnabled() {

Re: [PR] [feat][misc] PIP-264: Add OpenTelemetry messaging rate limit metrics [pulsar]

2024-07-16 Thread via GitHub
dragosvictor commented on code in PR #23035: URL: https://github.com/apache/pulsar/pull/23035#discussion_r1680352885 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -3691,16 +3708,22 @@ public boolean isBrokerPayloadProcessorEnabled() {

Re: [PR] [feat][misc] PIP-264: Add OpenTelemetry messaging rate limit metrics [pulsar]

2024-07-16 Thread via GitHub
heesung-sn commented on code in PR #23035: URL: https://github.com/apache/pulsar/pull/23035#discussion_r1680205712 ## pulsar-opentelemetry/src/main/java/org/apache/pulsar/opentelemetry/OpenTelemetryAttributes.java: ## @@ -112,6 +112,17 @@ public interface

Re: [PR] [feat][misc] PIP-264: Add OpenTelemetry messaging rate limit metrics [pulsar]

2024-07-16 Thread via GitHub
heesung-sn commented on code in PR #23035: URL: https://github.com/apache/pulsar/pull/23035#discussion_r1680204634 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java: ## @@ -3691,16 +3708,22 @@ public boolean isBrokerPayloadProcessorEnabled() {

[PR] [feat][misc] PIP-264: Add OpenTelemetry messaging rate limit metrics [pulsar]

2024-07-16 Thread via GitHub
dragosvictor opened a new pull request, #23035: URL: https://github.com/apache/pulsar/pull/23035 [PIP-264](https://github.com/apache/pulsar/blob/master/pip/pip-264.md) ### Motivation Adds messaging rate limit metrics, currently exposed in classes `InflightReadsLimiter` and