Re: [PR] [fix][broker] Allow broker deployment in heterogeneous hw config cluster without restricting nic speed detection [pulsar]

2023-10-24 Thread via GitHub
rdhabalia merged PR #21409: URL: https://github.com/apache/pulsar/pull/21409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.

Re: [PR] [fix][broker] Allow broker deployment in heterogeneous hw config cluster without restricting nic speed detection [pulsar]

2023-10-24 Thread via GitHub
rdhabalia commented on PR #21409: URL: https://github.com/apache/pulsar/pull/21409#issuecomment-1778201624 > "Once NIC limit is zero, we should get rid of nic usage calculation." Load-balancer already does that. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [fix][broker] Allow broker deployment in heterogeneous hw config cluster without restricting nic speed detection [pulsar]

2023-10-23 Thread via GitHub
mattisonchao commented on PR #21409: URL: https://github.com/apache/pulsar/pull/21409#issuecomment-1776313411 @rdhabalia >Think this way: there is no way to get specific information then should we handle this scenario or should we just not allow that user to use that software? it's

Re: [PR] [fix][broker] Allow broker deployment in heterogeneous hw config cluster without restricting nic speed detection [pulsar]

2023-10-23 Thread via GitHub
rdhabalia commented on PR #21409: URL: https://github.com/apache/pulsar/pull/21409#issuecomment-1775661556 > We calculated facts for the load balancer by NIC limit and usage. If 0 NIC limit and >0 tx and rx will mislead the load balancer? Think this way: there is no way to get specifi

Re: [PR] [fix][broker] Allow broker deployment in heterogeneous hw config cluster without restricting nic speed detection [pulsar]

2023-10-22 Thread via GitHub
mattisonchao commented on PR #21409: URL: https://github.com/apache/pulsar/pull/21409#issuecomment-1774220932 Question: We calculated facts for the load balancer by NIC limit and usage. If 0 NIC limit and >0 tx and rx will mislead the load balancer? -- This is an automated message f

[PR] [fix][broker] Allow broker deployment in heterogeneous hw config cluster without restricting nic speed detection [pulsar]

2023-10-20 Thread via GitHub
rdhabalia opened a new pull request, #21409: URL: https://github.com/apache/pulsar/pull/21409 ### Motivation This PR #14648 is incorrectly introduced, causing broker service unavailability while upgrading brokers in heterogeneous hardware config clusters. Sometime broker can’t find n