[GitHub] [incubator-tvm] masahi edited a comment on issue #4497: [Relay] Add a PyTorch to Relay Parser

2020-02-09 Thread GitBox
masahi edited a comment on issue #4497: [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#issuecomment-583977652 @alexwong It seems you have problems with alexnet, vgg and mobilenet v2 on cuda. In my refactored version, I have no problem with

[GitHub] [incubator-tvm] masahi edited a comment on issue #4497: [Relay] Add a PyTorch to Relay Parser

2020-02-09 Thread GitBox
masahi edited a comment on issue #4497: [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#issuecomment-583977652 @alexwong It seems you have problems with alexnet, vgg and mobilenet v2 on cuda. In my refactored version, I have no problem with

[GitHub] [incubator-tvm] masahi edited a comment on issue #4497: [Relay] Add a PyTorch to Relay Parser

2020-02-09 Thread GitBox
masahi edited a comment on issue #4497: [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#issuecomment-583977652 @alexwong It seems you have problems with alexnet, vgg and mobilenet v2 on cuda. In my refactored version, I have no problem with

[GitHub] [incubator-tvm] masahi commented on issue #4497: [Relay] Add a PyTorch to Relay Parser

2020-02-09 Thread GitBox
masahi commented on issue #4497: [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#issuecomment-583977652 @alexwong It seems you have problems with alexnet, vgg and mobilenet v2 on cuda. In my refactored version, I have no problem with these

[GitHub] [incubator-tvm] masahi commented on issue #4497: [Relay] Add a PyTorch to Relay Parser

2020-02-09 Thread GitBox
masahi commented on issue #4497: [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#issuecomment-583959013 @alexwong need to rebase and ``` tvm.ndarray -> tvm.runtime.ndarray ```

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #4828: [QNN][TFLite] TFLite rounding mode support

2020-02-09 Thread GitBox
FrozenGene commented on a change in pull request #4828: [QNN][TFLite] TFLite rounding mode support URL: https://github.com/apache/incubator-tvm/pull/4828#discussion_r376858216 ## File path: include/tvm/relay/qnn/attrs.h ## @@ -44,14 +44,15 @@ struct RequantizeAttrs :

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #4828: [QNN][TFLite] TFLite rounding mode support

2020-02-09 Thread GitBox
FrozenGene commented on a change in pull request #4828: [QNN][TFLite] TFLite rounding mode support URL: https://github.com/apache/incubator-tvm/pull/4828#discussion_r376858216 ## File path: include/tvm/relay/qnn/attrs.h ## @@ -44,14 +44,15 @@ struct RequantizeAttrs :

[GitHub] [incubator-tvm] LiangHao151941 commented on issue #4828: [QNN][TFLite] TFLite rounding mode support

2020-02-09 Thread GitBox
LiangHao151941 commented on issue #4828: [QNN][TFLite] TFLite rounding mode support URL: https://github.com/apache/incubator-tvm/pull/4828#issuecomment-583939949 > Let us break the model into layer by layer and compare with tflite. I want to describe my development way, maybe it could

[GitHub] [incubator-tvm] LiangHao151941 commented on a change in pull request #4828: [QNN][TFLite] TFLite rounding mode support

2020-02-09 Thread GitBox
LiangHao151941 commented on a change in pull request #4828: [QNN][TFLite] TFLite rounding mode support URL: https://github.com/apache/incubator-tvm/pull/4828#discussion_r376854118 ## File path: src/relay/qnn/util.cc ## @@ -100,35 +134,54 @@ Expr FixedPointMultiply(Expr

[GitHub] [incubator-tvm] LiangHao151941 commented on a change in pull request #4828: [QNN][TFLite] TFLite rounding mode support

2020-02-09 Thread GitBox
LiangHao151941 commented on a change in pull request #4828: [QNN][TFLite] TFLite rounding mode support URL: https://github.com/apache/incubator-tvm/pull/4828#discussion_r376853818 ## File path: src/relay/qnn/util.cc ## @@ -22,13 +22,47 @@ * \brief Utility functions for

[GitHub] [incubator-tvm] LiangHao151941 commented on a change in pull request #4828: [QNN][TFLite] TFLite rounding mode support

2020-02-09 Thread GitBox
LiangHao151941 commented on a change in pull request #4828: [QNN][TFLite] TFLite rounding mode support URL: https://github.com/apache/incubator-tvm/pull/4828#discussion_r376852996 ## File path: include/tvm/relay/qnn/attrs.h ## @@ -44,14 +44,15 @@ struct RequantizeAttrs :

[GitHub] [incubator-tvm] LiangHao151941 commented on issue #4828: [QNN][TFLite] TFLite rounding mode support

2020-02-09 Thread GitBox
LiangHao151941 commented on issue #4828: [QNN][TFLite] TFLite rounding mode support URL: https://github.com/apache/incubator-tvm/pull/4828#issuecomment-583936335 > :( This will be a challenging task. I think, instead of trying to fix the full e2e test, we should now focus on unit tests. I

[GitHub] [incubator-tvm] tobegit3hub commented on issue #4459: [RUNTIME] Implement TVMDSOOp(TensorFlow custom op) for TVM runtime

2020-02-09 Thread GitBox
tobegit3hub commented on issue #4459: [RUNTIME] Implement TVMDSOOp(TensorFlow custom op) for TVM runtime URL: https://github.com/apache/incubator-tvm/pull/4459#issuecomment-583923302 Thanks @zhiics . We are new to TVM and not sure we can add walk-thought test with this op since it is the

[GitHub] [incubator-tvm] inadob commented on issue #4840: [Frontend][TFlite] use qnn helper function in softmax

2020-02-09 Thread GitBox
inadob commented on issue #4840: [Frontend][TFlite] use qnn helper function in softmax URL: https://github.com/apache/incubator-tvm/pull/4840#issuecomment-583880570 LGTM too This is an automated message from the Apache Git

[GitHub] [incubator-tvm] dpankratz opened a new pull request #4852: [Bugfix] Fixed crash when caused by reversing bitwise operators

2020-02-09 Thread GitBox
dpankratz opened a new pull request #4852: [Bugfix] Fixed crash when caused by reversing bitwise operators URL: https://github.com/apache/incubator-tvm/pull/4852 I ran into a bug when using the bitwise operators bitwise_xor, bitwise_and, and bitwise_or. The following code results

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4628: [Object] Add String container

2020-02-09 Thread GitBox
tqchen commented on a change in pull request #4628: [Object] Add String container URL: https://github.com/apache/incubator-tvm/pull/4628#discussion_r376800855 ## File path: include/tvm/runtime/container.h ## @@ -274,7 +298,246 @@ class ADT : public ObjectRef {

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4628: [Object] Add String container

2020-02-09 Thread GitBox
tqchen commented on a change in pull request #4628: [Object] Add String container URL: https://github.com/apache/incubator-tvm/pull/4628#discussion_r376801581 ## File path: include/tvm/runtime/container.h ## @@ -274,7 +298,246 @@ class ADT : public ObjectRef {

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4628: [Object] Add String container

2020-02-09 Thread GitBox
tqchen commented on a change in pull request #4628: [Object] Add String container URL: https://github.com/apache/incubator-tvm/pull/4628#discussion_r376800653 ## File path: include/tvm/runtime/container.h ## @@ -274,7 +298,246 @@ class ADT : public ObjectRef {

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4628: [Object] Add String container

2020-02-09 Thread GitBox
tqchen commented on a change in pull request #4628: [Object] Add String container URL: https://github.com/apache/incubator-tvm/pull/4628#discussion_r376802418 ## File path: tests/cpp/container_test.cc ## @@ -226,6 +226,94 @@ TEST(Map, Iterator) {

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4628: [Object] Add String container

2020-02-09 Thread GitBox
tqchen commented on a change in pull request #4628: [Object] Add String container URL: https://github.com/apache/incubator-tvm/pull/4628#discussion_r376802267 ## File path: include/tvm/runtime/container.h ## @@ -274,7 +298,246 @@ class ADT : public ObjectRef {

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4628: [Object] Add String container

2020-02-09 Thread GitBox
tqchen commented on a change in pull request #4628: [Object] Add String container URL: https://github.com/apache/incubator-tvm/pull/4628#discussion_r376801571 ## File path: include/tvm/runtime/container.h ## @@ -274,7 +298,246 @@ class ADT : public ObjectRef {

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4628: [Object] Add String container

2020-02-09 Thread GitBox
tqchen commented on a change in pull request #4628: [Object] Add String container URL: https://github.com/apache/incubator-tvm/pull/4628#discussion_r376800691 ## File path: include/tvm/runtime/container.h ## @@ -274,7 +298,246 @@ class ADT : public ObjectRef {

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4628: [Object] Add String container

2020-02-09 Thread GitBox
tqchen commented on a change in pull request #4628: [Object] Add String container URL: https://github.com/apache/incubator-tvm/pull/4628#discussion_r376801684 ## File path: include/tvm/runtime/container.h ## @@ -274,7 +298,246 @@ class ADT : public ObjectRef {

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4628: [Object] Add String container

2020-02-09 Thread GitBox
tqchen commented on a change in pull request #4628: [Object] Add String container URL: https://github.com/apache/incubator-tvm/pull/4628#discussion_r376801874 ## File path: include/tvm/runtime/container.h ## @@ -274,7 +298,246 @@ class ADT : public ObjectRef {

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4628: [Object] Add String container

2020-02-09 Thread GitBox
tqchen commented on a change in pull request #4628: [Object] Add String container URL: https://github.com/apache/incubator-tvm/pull/4628#discussion_r376802203 ## File path: include/tvm/runtime/container.h ## @@ -274,7 +298,246 @@ class ADT : public ObjectRef {

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4628: [Object] Add String container

2020-02-09 Thread GitBox
tqchen commented on a change in pull request #4628: [Object] Add String container URL: https://github.com/apache/incubator-tvm/pull/4628#discussion_r376800596 ## File path: include/tvm/runtime/container.h ## @@ -24,11 +24,35 @@ #ifndef TVM_RUNTIME_CONTAINER_H_ #define

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4628: [Object] Add String container

2020-02-09 Thread GitBox
tqchen commented on a change in pull request #4628: [Object] Add String container URL: https://github.com/apache/incubator-tvm/pull/4628#discussion_r376800566 ## File path: include/tvm/runtime/container.h ## @@ -24,11 +24,35 @@ #ifndef TVM_RUNTIME_CONTAINER_H_ #define

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4771: [Relay] Added Merge Composite pass

2020-02-09 Thread GitBox
comaniac commented on a change in pull request #4771: [Relay] Added Merge Composite pass URL: https://github.com/apache/incubator-tvm/pull/4771#discussion_r376800880 ## File path: python/tvm/relay/transform.py ## @@ -513,6 +513,31 @@ def

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4628: [Object] Add String container

2020-02-09 Thread GitBox
tqchen edited a comment on issue #4628: [Object] Add String container URL: https://github.com/apache/incubator-tvm/pull/4628#issuecomment-583871162 @FrozenGene In general I agree that we should avoid std::experimental. In this particular case, i think the usage is fair, because it

[GitHub] [incubator-tvm] tqchen commented on issue #4628: [Object] Add String container

2020-02-09 Thread GitBox
tqchen commented on issue #4628: [Object] Add String container URL: https://github.com/apache/incubator-tvm/pull/4628#issuecomment-583871162 @FrozenGene In general I agree that we should avoid std::experimental. In this particular case, i think the usage is fair, because it is

[incubator-tvm] branch master updated: [CI][DOCKER] Update ci-lint to pylint2.4.4 (#4851)

2020-02-09 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 13f2155 [CI][DOCKER] Update ci-lint to

[GitHub] [incubator-tvm] tqchen merged pull request #4851: [CI][DOCKER] Update ci-lint to pylint2.4.4

2020-02-09 Thread GitBox
tqchen merged pull request #4851: [CI][DOCKER] Update ci-lint to pylint2.4.4 URL: https://github.com/apache/incubator-tvm/pull/4851 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-tvm] FrozenGene commented on issue #4748: [RELAY] Support RelayBuild with Only Constants

2020-02-09 Thread GitBox
FrozenGene commented on issue #4748: [RELAY] Support RelayBuild with Only Constants URL: https://github.com/apache/incubator-tvm/issues/4748#issuecomment-583851947 >I even think it is just okay to leave it as it is because it means we just return a null pointer when returning an empty

[GitHub] [incubator-tvm] uday60 edited a comment on issue #4830: libnnvm_compiler.so file missing | Commands inside

2020-02-09 Thread GitBox
uday60 edited a comment on issue #4830: libnnvm_compiler.so file missing | Commands inside URL: https://github.com/apache/incubator-tvm/issues/4830#issuecomment-583401837 @tqchen I have been using an earlier version of TVM. Now things have changed the following script is giving me a

[GitHub] [incubator-tvm] optima2005 commented on issue #4009: [RFC] 3D model support

2020-02-09 Thread GitBox
optima2005 commented on issue #4009: [RFC] 3D model support URL: https://github.com/apache/incubator-tvm/issues/4009#issuecomment-583818527 @masahi Sorry, I have been busy at some other things recently. I'd like to be back if I could have more free time again. Thanks!