[GitHub] [incubator-tvm] zhiics edited a comment on issue #5159: [RELAY] Migrate AlphaEqual to StructuralEqual

zhiics edited a comment on issue #5159: [RELAY] Migrate AlphaEqual to StructuralEqual URL: https://github.com/apache/incubator-tvm/issues/5159#issuecomment-605404362 I can probably try to squeeze some time to work on some of them over the weekend. Being really busy recently. -

[GitHub] [incubator-tvm] gmagogsfm commented on a change in pull request #4459: [RUNTIME] Implement TVMDSOOp(TensorFlow custom op) for TVM runtime

gmagogsfm commented on a change in pull request #4459: [RUNTIME] Implement TVMDSOOp(TensorFlow custom op) for TVM runtime URL: https://github.com/apache/incubator-tvm/pull/4459#discussion_r399627780 ## File path: src/contrib/tf_op/tvm_dso_op_kernels.cc ## @@ -0,0 +1,344 @@

[GitHub] [incubator-tvm] zhiics commented on issue #5159: [RELAY] Migrate AlphaEqual to StructuralEqual

zhiics commented on issue #5159: [RELAY] Migrate AlphaEqual to StructuralEqual URL: https://github.com/apache/incubator-tvm/issues/5159#issuecomment-605404362 I can probably try to squeeze some time to work on some of them over the weekend --

[GitHub] [incubator-tvm] tqchen merged pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR.

tqchen merged pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR. URL: https://github.com/apache/incubator-tvm/pull/5154 This is an automated message from the Apache Git Service. To respond to

[incubator-tvm] branch master updated: [NODE][IR] Introduce StructuralEqual Infra for the unified IR. (#5154)

This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 997a14e [NODE][IR] Introduce StructuralE

[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #5158: [Runtime][MISRA-C][Bundle] Bundle deployment with static linking

siju-samuel commented on a change in pull request #5158: [Runtime][MISRA-C][Bundle] Bundle deployment with static linking URL: https://github.com/apache/incubator-tvm/pull/5158#discussion_r399615789 ## File path: apps/bundle_deploy/bundle.h ## @@ -0,0 +1,41 @@ +/* + * Lice

[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #5158: [Runtime][MISRA-C][Bundle] Bundle deployment with static linking

siju-samuel commented on a change in pull request #5158: [Runtime][MISRA-C][Bundle] Bundle deployment with static linking URL: https://github.com/apache/incubator-tvm/pull/5158#discussion_r399617118 ## File path: apps/bundle_deploy/demo_static.c ## @@ -0,0 +1,106 @@ +/* +

[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #5158: [Runtime][MISRA-C][Bundle] Bundle deployment with static linking

siju-samuel commented on a change in pull request #5158: [Runtime][MISRA-C][Bundle] Bundle deployment with static linking URL: https://github.com/apache/incubator-tvm/pull/5158#discussion_r399616351 ## File path: apps/bundle_deploy/Makefile ## @@ -33,22 +33,36 @@ PKG_LDFLA

[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #5158: [Runtime][MISRA-C][Bundle] Bundle deployment with static linking

siju-samuel commented on a change in pull request #5158: [Runtime][MISRA-C][Bundle] Bundle deployment with static linking URL: https://github.com/apache/incubator-tvm/pull/5158#discussion_r399616880 ## File path: apps/bundle_deploy/bundle.h ## @@ -0,0 +1,41 @@ +/* + * Lice

[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #5158: [Runtime][MISRA-C][Bundle] Bundle deployment with static linking

siju-samuel commented on a change in pull request #5158: [Runtime][MISRA-C][Bundle] Bundle deployment with static linking URL: https://github.com/apache/incubator-tvm/pull/5158#discussion_r399615836 ## File path: apps/bundle_deploy/bundle_static.c ## @@ -0,0 +1,80 @@ +/* +

[GitHub] [incubator-tvm] megjoshi commented on issue #5133: [Torch] A list of missing op conversion in need of help

megjoshi commented on issue #5133: [Torch] A list of missing op conversion in need of help URL: https://github.com/apache/incubator-tvm/issues/5133#issuecomment-605389347 https://github.com/huggingface/transformers#quick-tour this is on which i was trying to optimize using tvm

[incubator-tvm] branch master updated: [Relay][Frontend][Pytorch] Fixed ConvTranspose2D parsing (#5157)

This is an automated email from the ASF dual-hosted git repository. masahi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 9c80662 [Relay][Frontend][Pytorch] Fixed

[GitHub] [incubator-tvm] masahi commented on issue #5157: [Relay][Frontend][Pytorch] Fixed ConvTranspose2D parsing

masahi commented on issue #5157: [Relay][Frontend][Pytorch] Fixed ConvTranspose2D parsing URL: https://github.com/apache/incubator-tvm/pull/5157#issuecomment-605388690 Thanks @jwfromm @tmoreau89 This is an automated message

[GitHub] [incubator-tvm] masahi merged pull request #5157: [Relay][Frontend][Pytorch] Fixed ConvTranspose2D parsing

masahi merged pull request #5157: [Relay][Frontend][Pytorch] Fixed ConvTranspose2D parsing URL: https://github.com/apache/incubator-tvm/pull/5157 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [incubator-tvm] tqchen commented on issue #5159: [RELAY] Migrate AlphaEqual to StructuralEqual

tqchen commented on issue #5159: [RELAY] Migrate AlphaEqual to StructuralEqual URL: https://github.com/apache/incubator-tvm/issues/5159#issuecomment-605385379 cc @zhiics @MarisaKirisame @slyubomirsky see if you are interested

[GitHub] [incubator-tvm] tqchen opened a new issue #5159: [RELAY] Migrate AlphaEqual to StructuralEqual

tqchen opened a new issue #5159: [RELAY] Migrate AlphaEqual to StructuralEqual URL: https://github.com/apache/incubator-tvm/issues/5159 https://github.com/apache/incubator-tvm/pull/5154 inroduces StructuralEqual that supersedes AlphaEqual. We should update the relay's AlphaEqual usa

[GitHub] [incubator-tvm] anijain2305 commented on issue #5153: Adding support for QNN subtract op

anijain2305 commented on issue #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#issuecomment-605376110 Thanks @shoubhik @zhiics This is merged! This is an automated message f

[incubator-tvm] branch master updated (f4286cc -> dada676)

This is an automated email from the ASF dual-hosted git repository. anijain2305 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from f4286cc [TOPI][Tensor Core] Conv2d and Dense ops support on Tensor Core (#5099) add dada676 Addin

[GitHub] [incubator-tvm] anijain2305 merged pull request #5153: Adding support for QNN subtract op

anijain2305 merged pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-tvm] tqchen commented on issue #5099: [TOPI][Tensor Core] Conv2d and Dense ops support on Tensor Core

tqchen commented on issue #5099: [TOPI][Tensor Core] Conv2d and Dense ops support on Tensor Core URL: https://github.com/apache/incubator-tvm/pull/5099#issuecomment-605353636 Thanks @Shawn-Inspur @Hzfengsy @Laurawly @vinx13 @jwfromm ! --

[incubator-tvm] branch master updated (949dca4 -> f4286cc)

This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 949dca4 [External Codegen] Fix annotate pass static variable (#5023) add f4286cc [TOPI][Tensor Core] Co

[GitHub] [incubator-tvm] tqchen merged pull request #5099: [TOPI][Tensor Core] Conv2d and Dense ops support on Tensor Core

tqchen merged pull request #5099: [TOPI][Tensor Core] Conv2d and Dense ops support on Tensor Core URL: https://github.com/apache/incubator-tvm/pull/5099 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #5157: [Relay][Frontend][Pytorch] Fixed ConvTranspose2D parsing

jwfromm commented on a change in pull request #5157: [Relay][Frontend][Pytorch] Fixed ConvTranspose2D parsing URL: https://github.com/apache/incubator-tvm/pull/5157#discussion_r399578712 ## File path: tests/python/frontend/pytorch/test_forward.py ## @@ -448,6 +448,33 @@ de

[GitHub] [incubator-tvm] mehrdadhe commented on a change in pull request #5158: [Runtime][MISRA-C][Bundle] Bundle deployment with static linking

mehrdadhe commented on a change in pull request #5158: [Runtime][MISRA-C][Bundle] Bundle deployment with static linking URL: https://github.com/apache/incubator-tvm/pull/5158#discussion_r399578021 ## File path: apps/bundle_deploy/test_static.c ## @@ -0,0 +1,122 @@ +/* + *

[GitHub] [incubator-tvm] mehrdadhe commented on a change in pull request #5158: [Runtime][MISRA-C][Bundle] Bundle deployment with static linking

mehrdadhe commented on a change in pull request #5158: [Runtime][MISRA-C][Bundle] Bundle deployment with static linking URL: https://github.com/apache/incubator-tvm/pull/5158#discussion_r399577994 ## File path: apps/bundle_deploy/bundle_static.c ## @@ -0,0 +1,94 @@ +/* + *

[GitHub] [incubator-tvm] tmoreau89 commented on a change in pull request #5158: [Runtime][MISRA-C][Bundle] Bundle deployment with static linking

tmoreau89 commented on a change in pull request #5158: [Runtime][MISRA-C][Bundle] Bundle deployment with static linking URL: https://github.com/apache/incubator-tvm/pull/5158#discussion_r399577296 ## File path: apps/bundle_deploy/test_static.c ## @@ -0,0 +1,122 @@ +/* + *

[GitHub] [incubator-tvm] tmoreau89 commented on a change in pull request #5158: [Runtime][MISRA-C][Bundle] Bundle deployment with static linking

tmoreau89 commented on a change in pull request #5158: [Runtime][MISRA-C][Bundle] Bundle deployment with static linking URL: https://github.com/apache/incubator-tvm/pull/5158#discussion_r399576633 ## File path: apps/bundle_deploy/bundle_static.c ## @@ -0,0 +1,94 @@ +/* + *

[GitHub] [incubator-tvm] tmoreau89 commented on issue #5158: [Runtime][MISRA-C][Bundle] Bundle deployment with static linking

tmoreau89 commented on issue #5158: [Runtime][MISRA-C][Bundle] Bundle deployment with static linking URL: https://github.com/apache/incubator-tvm/pull/5158#issuecomment-605350267 @liangfu @siju-samuel This is an automated me

[GitHub] [incubator-tvm] mehrdadhe opened a new pull request #5158: [Runtime][MISRA-C][Bundle] Bundle deployment with static linking

mehrdadhe opened a new pull request #5158: [Runtime][MISRA-C][Bundle] Bundle deployment with static linking URL: https://github.com/apache/incubator-tvm/pull/5158 Current implementation in MISRA-C bundle deployment depends on dynamic linker. This PR adds demo and test which does not rely o

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR.

junrushao1994 commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR. URL: https://github.com/apache/incubator-tvm/pull/5154#discussion_r399550850 ## File path: tests/python/unittest/test_tir_structural_equal.py ## @@ -0,

[GitHub] [incubator-tvm] dpankratz commented on issue #5156: [Bugfix] Fixed rewrite_simplify to correctly cast integers known at compile time.

dpankratz commented on issue #5156: [Bugfix] Fixed rewrite_simplify to correctly cast integers known at compile time. URL: https://github.com/apache/incubator-tvm/pull/5156#issuecomment-605310597 > > > Perhaps it would be better to check the OOB directly in MakeConstScalar, so that

[GitHub] [incubator-tvm] masahi commented on issue #5133: [Torch] A list of missing op conversion in need of help

masahi commented on issue #5133: [Torch] A list of missing op conversion in need of help URL: https://github.com/apache/incubator-tvm/issues/5133#issuecomment-605309855 @megjoshi Updated. If possible, please show your original PyTorch models where these ops are generated from. -

[GitHub] [incubator-tvm] tqchen commented on issue #5156: [Bugfix] Fixed rewrite_simplify to correctly cast integers known at compile time.

tqchen commented on issue #5156: [Bugfix] Fixed rewrite_simplify to correctly cast integers known at compile time. URL: https://github.com/apache/incubator-tvm/pull/5156#issuecomment-605308237 Thanks @dpankratz please fix the CI error, likely due to the fact that stackvm does not yet suppo

[GitHub] [incubator-tvm] masahi commented on a change in pull request #5157: [Relay][Frontend][Pytorch] Fixed ConvTranspose2D parsing

masahi commented on a change in pull request #5157: [Relay][Frontend][Pytorch] Fixed ConvTranspose2D parsing URL: https://github.com/apache/incubator-tvm/pull/5157#discussion_r399529519 ## File path: tests/python/frontend/pytorch/test_forward.py ## @@ -448,6 +448,33 @@ def

[GitHub] [incubator-tvm] mbaret commented on issue #5134: [RELAY] Add MergeCompilerRegions pass

mbaret commented on issue #5134: [RELAY] Add MergeCompilerRegions pass URL: https://github.com/apache/incubator-tvm/pull/5134#issuecomment-605301758 There's still another issue to resolve with this (in AnnotateRestDefault). I'll take a look at it on Monday.

[GitHub] [incubator-tvm] jwfromm commented on issue #5157: [Relay][Frontend][Pytorch] Fixed ConvTranspose2D parsing

jwfromm commented on issue #5157: [Relay][Frontend][Pytorch] Fixed ConvTranspose2D parsing URL: https://github.com/apache/incubator-tvm/pull/5157#issuecomment-605299040 @masahi @alexwong can you take a look at this PR? This i

[GitHub] [incubator-tvm] jwfromm opened a new pull request #5157: [Relay][Frontend][Pytorch] Fixed ConvTranspose2D parsing

jwfromm opened a new pull request #5157: [Relay][Frontend][Pytorch] Fixed ConvTranspose2D parsing URL: https://github.com/apache/incubator-tvm/pull/5157 There were some small bugs in the new pytorch frontend when parsing conv2d_transpose. This PR corrects them and adds related tests.

[GitHub] [incubator-tvm] dpankratz opened a new pull request #5156: [Bugfix] Fixed rewrite_simplify to correctly cast integers known at compile time.

dpankratz opened a new pull request #5156: [Bugfix] Fixed rewrite_simplify to correctly cast integers known at compile time. URL: https://github.com/apache/incubator-tvm/pull/5156 ## Bug Casting values which are known at compile time results in strange behaviour. For example `1 * t

[GitHub] [incubator-tvm] shoubhik commented on a change in pull request #5153: Adding support for QNN subtract op

shoubhik commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399490983 ## File path: src/relay/qnn/op/subtract.cc ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399484380 ## File path: src/relay/qnn/op/op_common.h ## @@ -30,14 +30,152 @@ #include #include #include "../.

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399484380 ## File path: src/relay/qnn/op/op_common.h ## @@ -30,14 +30,152 @@ #include #include #include "../.

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR.

tqchen commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR. URL: https://github.com/apache/incubator-tvm/pull/5154#discussion_r399481397 ## File path: tests/python/unittest/test_tir_structural_equal.py ## @@ -55,8 +55,

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR.

tqchen commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR. URL: https://github.com/apache/incubator-tvm/pull/5154#discussion_r399481397 ## File path: tests/python/unittest/test_tir_structural_equal.py ## @@ -55,8 +55,

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR.

tqchen commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR. URL: https://github.com/apache/incubator-tvm/pull/5154#discussion_r399481397 ## File path: tests/python/unittest/test_tir_structural_equal.py ## @@ -55,8 +55,

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR.

tqchen commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR. URL: https://github.com/apache/incubator-tvm/pull/5154#discussion_r399481397 ## File path: tests/python/unittest/test_tir_structural_equal.py ## @@ -55,8 +55,

[GitHub] [incubator-tvm] shoubhik commented on a change in pull request #5153: Adding support for QNN subtract op

shoubhik commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399475231 ## File path: src/relay/qnn/op/op_common.h ## @@ -30,14 +30,152 @@ #include #include #include "../../o

[GitHub] [incubator-tvm] megjoshi edited a comment on issue #5133: [Torch] A list of missing op conversion in need of help

megjoshi edited a comment on issue #5133: [Torch] A list of missing op conversion in need of help URL: https://github.com/apache/incubator-tvm/issues/5133#issuecomment-605203339 can we add these as well? 'prim::ImplicitTensorToNum', 'aten::layer_norm', 'aten::arange', 'aten::rsub', 'at

[GitHub] [incubator-tvm] megjoshi commented on issue #5133: [Torch] A list of missing op conversion in need of help

megjoshi commented on issue #5133: [Torch] A list of missing op conversion in need of help URL: https://github.com/apache/incubator-tvm/issues/5133#issuecomment-605203339 can we add this as well? 'prim::ImplicitTensorToNum', 'aten::layer_norm', 'aten::arange', 'aten::rsub', 'aten::gelu

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5153: Adding support for QNN subtract op

zhiics commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399459498 ## File path: src/relay/qnn/op/op_common.h ## @@ -30,14 +30,152 @@ #include #include #include "../../op/

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5153: Adding support for QNN subtract op

zhiics commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399459742 ## File path: src/relay/qnn/op/subtract.cc ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [incubator-tvm] shoubhik commented on a change in pull request #5153: Adding support for QNN subtract op

shoubhik commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399458287 ## File path: src/relay/qnn/op/op_common.h ## @@ -74,16 +212,17 @@ static inline bool QnnBroadcastRel(const

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399454748 ## File path: src/relay/qnn/op/op_common.h ## @@ -74,16 +212,17 @@ static inline bool QnnBroadcastRel(co

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399454748 ## File path: src/relay/qnn/op/op_common.h ## @@ -74,16 +212,17 @@ static inline bool QnnBroadcastRel(co

[GitHub] [incubator-tvm] shoubhik commented on a change in pull request #5153: Adding support for QNN subtract op

shoubhik commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399452260 ## File path: src/relay/qnn/op/subtract.cc ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR.

jroesch commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR. URL: https://github.com/apache/incubator-tvm/pull/5154#discussion_r399450430 ## File path: tests/python/unittest/test_tir_structural_equal.py ## @@ -55,8 +55

[GitHub] [incubator-tvm] MarisaKirisame commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR.

MarisaKirisame commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR. URL: https://github.com/apache/incubator-tvm/pull/5154#discussion_r399448385 ## File path: tests/python/unittest/test_tir_structural_equal.py ## @@ -5

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399447558 ## File path: src/relay/qnn/op/subtract.cc ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399446872 ## File path: src/relay/qnn/op/subtract.cc ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-tvm] shoubhik commented on a change in pull request #5153: Adding support for QNN subtract op

shoubhik commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399444523 ## File path: src/relay/qnn/op/op_common.h ## @@ -30,14 +30,152 @@ #include #include #include "../../o

[GitHub] [incubator-tvm] shoubhik commented on a change in pull request #5153: Adding support for QNN subtract op

shoubhik commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r39924 ## File path: src/relay/qnn/op/mul.cc ## @@ -42,22 +42,13 @@ namespace qnn { Expr QnnMulCanonicalize(const

[GitHub] [incubator-tvm] shoubhik commented on a change in pull request #5153: Adding support for QNN subtract op

shoubhik commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399444313 ## File path: src/relay/qnn/op/mul.cc ## @@ -42,22 +42,13 @@ namespace qnn { Expr QnnMulCanonicalize(const

[GitHub] [incubator-tvm] shoubhik commented on a change in pull request #5153: Adding support for QNN subtract op

shoubhik commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399443268 ## File path: src/relay/qnn/op/subtract.cc ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR.

tqchen commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR. URL: https://github.com/apache/incubator-tvm/pull/5154#discussion_r399439011 ## File path: tests/python/unittest/test_tir_structural_equal.py ## @@ -55,8 +55,

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR.

tqchen commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR. URL: https://github.com/apache/incubator-tvm/pull/5154#discussion_r399434631 ## File path: tests/python/unittest/test_tir_structural_equal.py ## @@ -55,8 +55,

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR.

tqchen commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR. URL: https://github.com/apache/incubator-tvm/pull/5154#discussion_r399434631 ## File path: tests/python/unittest/test_tir_structural_equal.py ## @@ -55,8 +55,

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR.

tqchen commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR. URL: https://github.com/apache/incubator-tvm/pull/5154#discussion_r399434059 ## File path: tests/python/unittest/test_tir_structural_equal.py ## @@ -55,8 +55,

[GitHub] [incubator-tvm] MarisaKirisame commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR.

MarisaKirisame commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR. URL: https://github.com/apache/incubator-tvm/pull/5154#discussion_r399432751 ## File path: tests/python/unittest/test_tir_structural_equal.py ## @@ -5

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399431735 ## File path: src/relay/qnn/op/subtract.cc ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399430571 ## File path: src/relay/qnn/op/op_common.h ## @@ -30,14 +30,152 @@ #include #include #include "../.

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399428671 ## File path: src/relay/qnn/op/mul.cc ## @@ -42,22 +42,13 @@ namespace qnn { Expr QnnMulCanonicalize(co

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op

anijain2305 commented on a change in pull request #5153: Adding support for QNN subtract op URL: https://github.com/apache/incubator-tvm/pull/5153#discussion_r399428714 ## File path: src/relay/qnn/op/mul.cc ## @@ -42,22 +42,13 @@ namespace qnn { Expr QnnMulCanonicalize(co

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR.

tqchen commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR. URL: https://github.com/apache/incubator-tvm/pull/5154#discussion_r399422483 ## File path: src/node/structural_equal.cc ## @@ -189,16 +201,19 @@ class RemapVa

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR.

zhiics commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR. URL: https://github.com/apache/incubator-tvm/pull/5154#discussion_r399418044 ## File path: src/node/structural_equal.cc ## @@ -189,16 +201,19 @@ class RemapVa

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR.

zhiics commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR. URL: https://github.com/apache/incubator-tvm/pull/5154#discussion_r399416785 ## File path: include/tvm/relay/expr.h ## @@ -107,7 +107,13 @@ class TupleNode :

[GitHub] [incubator-tvm] trevor-m edited a comment on issue #5134: [RELAY] Add MergeCompilerRegions pass

trevor-m edited a comment on issue #5134: [RELAY] Add MergeCompilerRegions pass URL: https://github.com/apache/incubator-tvm/pull/5134#issuecomment-605105981 @mbaret Thanks for investigating and making the fixes! However, I'm still getting the segfault on call to MergeCompilerRegions in tha

[GitHub] [incubator-tvm] tqchen commented on issue #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR.

tqchen commented on issue #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR. URL: https://github.com/apache/incubator-tvm/pull/5154#issuecomment-605109113 Just did an update to distinguish between graph node(needed in relay semantics) and normal nodes. Please take anothe

[GitHub] [incubator-tvm] trevor-m edited a comment on issue #5134: [RELAY] Add MergeCompilerRegions pass

trevor-m edited a comment on issue #5134: [RELAY] Add MergeCompilerRegions pass URL: https://github.com/apache/incubator-tvm/pull/5134#issuecomment-605105981 Thanks for pushing the fixes! However, I'm still getting the segfault on call to MergeCompilerRegions in that example I posted earlie

[GitHub] [incubator-tvm] trevor-m commented on issue #5134: [RELAY] Add MergeCompilerRegions pass

trevor-m commented on issue #5134: [RELAY] Add MergeCompilerRegions pass URL: https://github.com/apache/incubator-tvm/pull/5134#issuecomment-605105981 Thanks for pushing the fixes! However, I'm still getting the segfault on call to MergeCompilerRegions in that example I posted earlier? Are

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #5134: [RELAY] Add MergeCompilerRegions pass

comaniac commented on a change in pull request #5134: [RELAY] Add MergeCompilerRegions pass URL: https://github.com/apache/incubator-tvm/pull/5134#discussion_r399398280 ## File path: src/relay/transforms/merge_compiler_regions.cc ## @@ -0,0 +1,352 @@ +/* + * Licensed to th

[GitHub] [incubator-tvm] mbaret closed pull request #5155: [FIX] Fixed merging behaviour in AnnotateRegionSet

mbaret closed pull request #5155: [FIX] Fixed merging behaviour in AnnotateRegionSet URL: https://github.com/apache/incubator-tvm/pull/5155 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-tvm] branch master updated: [External Codegen] Fix annotate pass static variable (#5023)

This is an automated email from the ASF dual-hosted git repository. zhic pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 949dca4 [External Codegen] Fix annotate pa

[GitHub] [incubator-tvm] zhiics merged pull request #5023: [External Codegen] Fix annotate pass static variable

zhiics merged pull request #5023: [External Codegen] Fix annotate pass static variable URL: https://github.com/apache/incubator-tvm/pull/5023 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-tvm] mbaret commented on issue #5134: [RELAY] Add MergeCompilerRegions pass

mbaret commented on issue #5134: [RELAY] Add MergeCompilerRegions pass URL: https://github.com/apache/incubator-tvm/pull/5134#issuecomment-605079422 I've incorporated that fix into this PR now. This is an automated message fro

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #5134: [RELAY] Add MergeCompilerRegions pass

mbaret commented on a change in pull request #5134: [RELAY] Add MergeCompilerRegions pass URL: https://github.com/apache/incubator-tvm/pull/5134#discussion_r399364691 ## File path: src/relay/transforms/merge_compiler_regions.cc ## @@ -0,0 +1,352 @@ +/* + * Licensed to the

[GitHub] [incubator-tvm] zhiics commented on issue #5106: [Relay][MergeComposite] Support TupleGetItem in body of pattern

zhiics commented on issue #5106: [Relay][MergeComposite] Support TupleGetItem in body of pattern URL: https://github.com/apache/incubator-tvm/pull/5106#issuecomment-605072507 Thanks @trevor-m This is an automated message fro

[GitHub] [incubator-tvm] zhiics merged pull request #5106: [Relay][MergeComposite] Support TupleGetItem in body of pattern

zhiics merged pull request #5106: [Relay][MergeComposite] Support TupleGetItem in body of pattern URL: https://github.com/apache/incubator-tvm/pull/5106 This is an automated message from the Apache Git Service. To respond to

[incubator-tvm] branch master updated (63937a0 -> 68046ba)

This is an automated email from the ASF dual-hosted git repository. zhic pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 63937a0 [RUNTIME]crt error handling (#5147) add 68046ba [Relay][MergeComposite] Support TupleGetItem in b

[GitHub] [incubator-tvm] zhiics commented on issue #5134: [RELAY] Add MergeCompilerRegions pass

zhiics commented on issue #5134: [RELAY] Add MergeCompilerRegions pass URL: https://github.com/apache/incubator-tvm/pull/5134#issuecomment-605064579 also please fix @comaniac's comments This is an automated message from the Ap

[GitHub] [incubator-tvm] zhiics edited a comment on issue #5134: [RELAY] Add MergeCompilerRegions pass

zhiics edited a comment on issue #5134: [RELAY] Add MergeCompilerRegions pass URL: https://github.com/apache/incubator-tvm/pull/5134#issuecomment-605061790 Can you just incorporate that change as it is really short? This is an

[GitHub] [incubator-tvm] zhiics commented on issue #5134: [RELAY] Add MergeCompilerRegions pass

zhiics commented on issue #5134: [RELAY] Add MergeCompilerRegions pass URL: https://github.com/apache/incubator-tvm/pull/5134#issuecomment-605061790 Can you just incorporate that change? This is an automated message from the A

[GitHub] [incubator-tvm] mbaret edited a comment on issue #5134: [RELAY] Add MergeCompilerRegions pass

mbaret edited a comment on issue #5134: [RELAY] Add MergeCompilerRegions pass URL: https://github.com/apache/incubator-tvm/pull/5134#issuecomment-605056570 > @mbaret could you reproduce the failure and try to resolve it? It crashed before partition graph so it should not be the issue of mul

[GitHub] [incubator-tvm] mbaret commented on issue #5134: [RELAY] Add MergeCompilerRegions pass

mbaret commented on issue #5134: [RELAY] Add MergeCompilerRegions pass URL: https://github.com/apache/incubator-tvm/pull/5134#issuecomment-605056570 > @mbaret could you reproduce the failure and try to resolve it? It crashed before partition graph so it should not be the issue of multiple o

[GitHub] [incubator-tvm] mbaret opened a new pull request #5155: [FIX] Fixed merging behaviour in AnnotateRegionSet

mbaret opened a new pull request #5155: [FIX] Fixed merging behaviour in AnnotateRegionSet URL: https://github.com/apache/incubator-tvm/pull/5155 This is a small fix to the PR that introduces AnnotatedRegionSet. Deleting items from a list while iterating it seems to result in undefin

[GitHub] [incubator-tvm] tqchen commented on issue #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR.

tqchen commented on issue #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR. URL: https://github.com/apache/incubator-tvm/pull/5154#issuecomment-605049843 re : `_type_has_method_sequal_reduce` is a static variable indicating whether the method is available, and is used b

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR.

tqchen commented on a change in pull request #5154: [NODE][IR] Introduce StructuralEqual Infra for the unified IR. URL: https://github.com/apache/incubator-tvm/pull/5154#discussion_r399330782 ## File path: include/tvm/node/structural_equal.h ## @@ -0,0 +1,210 @@ +/* + * Li

[GitHub] [incubator-tvm] manupa-arm commented on a change in pull request #5143: [RELAY] Re-wrote the Graph Partitioner to support multiple outputs

manupa-arm commented on a change in pull request #5143: [RELAY] Re-wrote the Graph Partitioner to support multiple outputs URL: https://github.com/apache/incubator-tvm/pull/5143#discussion_r399295612 ## File path: src/relay/transforms/partition_graph.cc ## @@ -364,36 +388,

[GitHub] [incubator-tvm] manupa-arm commented on a change in pull request #5143: [RELAY] Re-wrote the Graph Partitioner to support multiple outputs

manupa-arm commented on a change in pull request #5143: [RELAY] Re-wrote the Graph Partitioner to support multiple outputs URL: https://github.com/apache/incubator-tvm/pull/5143#discussion_r399294950 ## File path: tests/python/relay/test_pass_partition_graph.py ## @@ -678,

[GitHub] [incubator-tvm] manupa-arm commented on a change in pull request #5143: [RELAY] Re-wrote the Graph Partitioner to support multiple outputs

manupa-arm commented on a change in pull request #5143: [RELAY] Re-wrote the Graph Partitioner to support multiple outputs URL: https://github.com/apache/incubator-tvm/pull/5143#discussion_r399295386 ## File path: src/relay/transforms/partition_graph.cc ## @@ -365,35 +374,

[GitHub] [incubator-tvm] manupa-arm commented on a change in pull request #5143: [RELAY] Re-wrote the Graph Partitioner to support multiple outputs

manupa-arm commented on a change in pull request #5143: [RELAY] Re-wrote the Graph Partitioner to support multiple outputs URL: https://github.com/apache/incubator-tvm/pull/5143#discussion_r399295536 ## File path: tests/python/relay/test_pass_partition_graph.py ## @@ -678,

[GitHub] [incubator-tvm] manupa-arm commented on a change in pull request #5143: [RELAY] Re-wrote the Graph Partitioner to support multiple outputs

manupa-arm commented on a change in pull request #5143: [RELAY] Re-wrote the Graph Partitioner to support multiple outputs URL: https://github.com/apache/incubator-tvm/pull/5143#discussion_r399295343 ## File path: src/relay/transforms/partition_graph.cc ## @@ -365,35 +374,

  1   2   >