[GitHub] [incubator-tvm] jainris opened a new pull request #6397: [TFLite] Implemented MATRIX_DIAG Operator for TFLite.

2020-09-04 Thread GitBox
jainris opened a new pull request #6397: URL: https://github.com/apache/incubator-tvm/pull/6397 * Added implementation for MATRIX_DIAG Operator. * Added tests for MATRIX_DIAG Operator. This is an automated message from

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6395: [BYOC][TensorRT] TensorRT BYOC integration

2020-09-04 Thread GitBox
leandron commented on a change in pull request #6395: URL: https://github.com/apache/incubator-tvm/pull/6395#discussion_r483477103 ## File path: python/tvm/relay/op/contrib/tensorrt.py ## @@ -0,0 +1,675 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [incubator-tvm] ghostplant commented on pull request #6323: Allow Custom Measure Batch Method

2020-09-04 Thread GitBox
ghostplant commented on pull request #6323: URL: https://github.com/apache/incubator-tvm/pull/6323#issuecomment-687040668 @comaniac Thank you, creating a custom Runner will create a lot of codes including every inner branch of the original Runner's logic. While the version I suggested coul

[GitHub] [incubator-tvm] anilmartha commented on a change in pull request #6343: [BYOC][CONTRIB] Vitis-AI codegen integration

2020-09-04 Thread GitBox
anilmartha commented on a change in pull request #6343: URL: https://github.com/apache/incubator-tvm/pull/6343#discussion_r483508132 ## File path: src/runtime/contrib/vitis_ai/vitis_ai_runtime.cc ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

2020-09-04 Thread GitBox
leandron commented on a change in pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#discussion_r483508754 ## File path: python/tvm/driver/tvmc/common.py ## @@ -17,6 +17,74 @@ """ Common utility functions shared by TVMC modules. """ +import argparse +

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

2020-09-04 Thread GitBox
leandron commented on a change in pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#discussion_r483509079 ## File path: python/tvm/driver/tvmc/compiler.py ## @@ -0,0 +1,305 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

2020-09-04 Thread GitBox
leandron commented on a change in pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#discussion_r483511867 ## File path: python/tvm/driver/tvmc/compiler.py ## @@ -0,0 +1,305 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

2020-09-04 Thread GitBox
leandron commented on a change in pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#discussion_r483520459 ## File path: python/tvm/driver/tvmc/frontends.py ## @@ -0,0 +1,389 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more con

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6395: [BYOC][TensorRT] TensorRT BYOC integration

2020-09-04 Thread GitBox
leandron commented on a change in pull request #6395: URL: https://github.com/apache/incubator-tvm/pull/6395#discussion_r483526749 ## File path: python/tvm/relay/op/contrib/tensorrt.py ## @@ -0,0 +1,675 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

2020-09-04 Thread GitBox
leandron commented on a change in pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#discussion_r483539088 ## File path: python/tvm/driver/tvmc/frontends.py ## @@ -0,0 +1,389 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more con

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

2020-09-04 Thread GitBox
leandron commented on a change in pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#discussion_r483539372 ## File path: python/tvm/driver/tvmc/frontends.py ## @@ -0,0 +1,389 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more con

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

2020-09-04 Thread GitBox
leandron commented on a change in pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#discussion_r483539205 ## File path: python/tvm/driver/tvmc/frontends.py ## @@ -0,0 +1,389 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more con

[GitHub] [incubator-tvm] jainris commented on pull request #6397: [TFLite] Implemented MATRIX_DIAG Operator for TFLite.

2020-09-04 Thread GitBox
jainris commented on pull request #6397: URL: https://github.com/apache/incubator-tvm/pull/6397#issuecomment-687078389 cc @u99127 @mbaret @FrozenGene @tqchen @anijain2305 This is an automated message from the Apache Git Serv

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6391: [AutoTVM][Ansor] Enable random fill and CPU cache flush for AutoTVM and Ansor

2020-09-04 Thread GitBox
merrymercy commented on a change in pull request #6391: URL: https://github.com/apache/incubator-tvm/pull/6391#discussion_r483592006 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -566,9 +592,13 @@ def timed_func(inp, build_res): if error_no == 0:

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6391: [AutoTVM][Ansor] Enable random fill and CPU cache flush for AutoTVM and Ansor

2020-09-04 Thread GitBox
merrymercy commented on a change in pull request #6391: URL: https://github.com/apache/incubator-tvm/pull/6391#discussion_r483592006 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -566,9 +592,13 @@ def timed_func(inp, build_res): if error_no == 0:

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6391: [AutoTVM][Ansor] Enable random fill and CPU cache flush for AutoTVM and Ansor

2020-09-04 Thread GitBox
merrymercy commented on a change in pull request #6391: URL: https://github.com/apache/incubator-tvm/pull/6391#discussion_r483593913 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -566,9 +592,13 @@ def timed_func(inp, build_res): if error_no == 0:

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6391: [AutoTVM][Ansor] Enable random fill and CPU cache flush for AutoTVM and Ansor

2020-09-04 Thread GitBox
merrymercy commented on a change in pull request #6391: URL: https://github.com/apache/incubator-tvm/pull/6391#discussion_r483593913 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -566,9 +592,13 @@ def timed_func(inp, build_res): if error_no == 0:

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

2020-09-04 Thread GitBox
leandron commented on a change in pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#discussion_r483629701 ## File path: python/tvm/driver/tvmc/compiler.py ## @@ -0,0 +1,305 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #6391: [AutoTVM][Ansor] Enable random fill and CPU cache flush for AutoTVM and Ansor

2020-09-04 Thread GitBox
FrozenGene commented on a change in pull request #6391: URL: https://github.com/apache/incubator-tvm/pull/6391#discussion_r483631435 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -566,9 +592,13 @@ def timed_func(inp, build_res): if error_no == 0:

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

2020-09-04 Thread GitBox
leandron commented on a change in pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#discussion_r483632453 ## File path: python/tvm/driver/tvmc/compiler.py ## @@ -0,0 +1,305 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

2020-09-04 Thread GitBox
leandron commented on a change in pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#discussion_r483632719 ## File path: python/tvm/driver/tvmc/compiler.py ## @@ -0,0 +1,305 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

[GitHub] [incubator-tvm] leandron opened a new issue #6398: `import tvm` now requires pytest

2020-09-04 Thread GitBox
leandron opened a new issue #6398: URL: https://github.com/apache/incubator-tvm/issues/6398 With the merge of #6331, `import tvm` now requires pytest. I created this issue just to check whether this is something intentional or something that we want to fix. The chain from `import tv

[GitHub] [incubator-tvm] tqchen edited a comment on issue #6398: `import tvm` now requires pytest

2020-09-04 Thread GitBox
tqchen edited a comment on issue #6398: URL: https://github.com/apache/incubator-tvm/issues/6398#issuecomment-687220104 I agree. thanks @leandron ! cc @tkonolige This is an automated message from the Apache Git Service. To r

[GitHub] [incubator-tvm] tqchen commented on issue #6398: `import tvm` now requires pytest

2020-09-04 Thread GitBox
tqchen commented on issue #6398: URL: https://github.com/apache/incubator-tvm/issues/6398#issuecomment-687220104 I agree. thanks @leandron ! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-tvm] tqchen commented on pull request #6351: Dynamic ONNX Importer

2020-09-04 Thread GitBox
tqchen commented on pull request #6351: URL: https://github.com/apache/incubator-tvm/pull/6351#issuecomment-687220734 cc @zhiics @yzhliu This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-tvm] tqchen edited a comment on issue #6398: `import tvm` now requires pytest

2020-09-04 Thread GitBox
tqchen edited a comment on issue #6398: URL: https://github.com/apache/incubator-tvm/issues/6398#issuecomment-687220104 I agree. thanks @leandron ! Please send a PR. cc @tkonolige This is an automated message from the Apache

[GitHub] [incubator-tvm] leandron opened a new pull request #6399: [TEST] Remove unintentional pytest dependency

2020-09-04 Thread GitBox
leandron opened a new pull request #6399: URL: https://github.com/apache/incubator-tvm/pull/6399 This removes an unintentional dependency on `pytest`, that exists on `python/tvm/__init__.py`. Fix #6398 cc @tqchen @tkonolige @d-smirnov ---

[GitHub] [incubator-tvm] zhiics commented on pull request #6353: [RELAY][DYN] Dynamic UpSampling3D Op

2020-09-04 Thread GitBox
zhiics commented on pull request #6353: URL: https://github.com/apache/incubator-tvm/pull/6353#issuecomment-687232927 Thanks @electriclilies @mbrookhart This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-tvm] zhiics merged pull request #6353: [RELAY][DYN] Dynamic UpSampling3D Op

2020-09-04 Thread GitBox
zhiics merged pull request #6353: URL: https://github.com/apache/incubator-tvm/pull/6353 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[incubator-tvm] branch master updated: [RELAY][DYN] Dynamic UpSampling3D Op (#6353)

2020-09-04 Thread zhic
This is an automated email from the ASF dual-hosted git repository. zhic pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 86fa81c [RELAY][DYN] Dynamic UpSampling3D

[GitHub] [incubator-tvm] zhiics commented on pull request #6366: [TARGET] Add layout_transform, clip and expand_dims in onnx converter

2020-09-04 Thread GitBox
zhiics commented on pull request #6366: URL: https://github.com/apache/incubator-tvm/pull/6366#issuecomment-687236164 @zxy844288792 can you re-trigger CI? It seems I cannot merge it This is an automated message from the Apach

[GitHub] [incubator-tvm] tkonolige commented on pull request #6399: [TEST] Remove unintentional pytest dependency

2020-09-04 Thread GitBox
tkonolige commented on pull request #6399: URL: https://github.com/apache/incubator-tvm/pull/6399#issuecomment-687238259 Looks good! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-tvm] tkonolige commented on issue #6398: `import tvm` now requires pytest

2020-09-04 Thread GitBox
tkonolige commented on issue #6398: URL: https://github.com/apache/incubator-tvm/issues/6398#issuecomment-687243358 Good catch. When I was adding the pytest-related functions, I originally put them in `tests/python/__init__.py` so they would be local to the tests. Unfortunately, doi

[GitHub] [incubator-tvm] tkonolige commented on a change in pull request #6274: [Diagnostics][Relay][InferType] Refactor InferType to work on whole module, and use new diagnostics.

2020-09-04 Thread GitBox
tkonolige commented on a change in pull request #6274: URL: https://github.com/apache/incubator-tvm/pull/6274#discussion_r483721274 ## File path: src/ir/diagnostic.cc ## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [incubator-tvm] tkonolige commented on a change in pull request #6274: [Diagnostics][Relay][InferType] Refactor InferType to work on whole module, and use new diagnostics.

2020-09-04 Thread GitBox
tkonolige commented on a change in pull request #6274: URL: https://github.com/apache/incubator-tvm/pull/6274#discussion_r483721402 ## File path: src/ir/diagnostic.cc ## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [incubator-tvm] tkonolige commented on a change in pull request #6274: [Diagnostics][Relay][InferType] Refactor InferType to work on whole module, and use new diagnostics.

2020-09-04 Thread GitBox
tkonolige commented on a change in pull request #6274: URL: https://github.com/apache/incubator-tvm/pull/6274#discussion_r483721274 ## File path: src/ir/diagnostic.cc ## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [incubator-tvm] tkonolige commented on a change in pull request #6274: [Diagnostics][Relay][InferType] Refactor InferType to work on whole module, and use new diagnostics.

2020-09-04 Thread GitBox
tkonolige commented on a change in pull request #6274: URL: https://github.com/apache/incubator-tvm/pull/6274#discussion_r483722840 ## File path: src/ir/diagnostic.cc ## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [incubator-tvm] tkonolige commented on a change in pull request #6274: [Diagnostics][Relay][InferType] Refactor InferType to work on whole module, and use new diagnostics.

2020-09-04 Thread GitBox
tkonolige commented on a change in pull request #6274: URL: https://github.com/apache/incubator-tvm/pull/6274#discussion_r483723482 ## File path: src/ir/diagnostic.cc ## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6391: [AutoTVM][Ansor] Enable random fill and CPU cache flush for AutoTVM and Ansor

2020-09-04 Thread GitBox
comaniac commented on a change in pull request #6391: URL: https://github.com/apache/incubator-tvm/pull/6391#discussion_r483737527 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -697,7 +696,7 @@ def timed_func(): args = [ndarray.empty(get_const_tuple(

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #6391: [AutoTVM][Ansor] Enable random fill and CPU cache flush for AutoTVM and Ansor

2020-09-04 Thread GitBox
FrozenGene commented on a change in pull request #6391: URL: https://github.com/apache/incubator-tvm/pull/6391#discussion_r483743676 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -697,7 +696,7 @@ def timed_func(): args = [ndarray.empty(get_const_tupl

[GitHub] [incubator-tvm] comaniac commented on pull request #6323: Allow Custom Measure Batch Method

2020-09-04 Thread GitBox
comaniac commented on pull request #6323: URL: https://github.com/apache/incubator-tvm/pull/6323#issuecomment-687267906 Although it might be more code to have a customized runner (it's not that mach to be honest), you can keep the customized runner locally so it sounds fine to me. To me th

[GitHub] [incubator-tvm] comaniac edited a comment on pull request #6323: Allow Custom Measure Batch Method

2020-09-04 Thread GitBox
comaniac edited a comment on pull request #6323: URL: https://github.com/apache/incubator-tvm/pull/6323#issuecomment-687267906 Although it might be more code for a customized runner (it's not that mach to be honest), you can keep the customized runner locally so it sounds fine to me. To me

[GitHub] [incubator-tvm] comaniac edited a comment on pull request #6323: Allow Custom Measure Batch Method

2020-09-04 Thread GitBox
comaniac edited a comment on pull request #6323: URL: https://github.com/apache/incubator-tvm/pull/6323#issuecomment-687267906 Although it might be more code for a customized runner (it's not that mach to be honest), you can keep the customized runner locally so it sounds fine to me. To me

[GitHub] [incubator-tvm] hypercubestart opened a new pull request #6400: [Relay] Add Defunctionalization Pass

2020-09-04 Thread GitBox
hypercubestart opened a new pull request #6400: URL: https://github.com/apache/incubator-tvm/pull/6400 introduces a defunctionalization pass based upon Type-Driven Defunctionalization. currently it assumes a number of characteristics about the program, and will be extended upon in f

[GitHub] [incubator-tvm] vathysjacob commented on issue #6376: [BUG] Memory leak in Metal runtime device api

2020-09-04 Thread GitBox
vathysjacob commented on issue #6376: URL: https://github.com/apache/incubator-tvm/issues/6376#issuecomment-687279729 @tqchen - Sure, I'll take a look. It may take me a couple days to get around to investigating if there are other leaks in the retain/release handling.

[GitHub] [incubator-tvm] tmoreau89 commented on pull request #6351: Dynamic ONNX Importer

2020-09-04 Thread GitBox
tmoreau89 commented on pull request #6351: URL: https://github.com/apache/incubator-tvm/pull/6351#issuecomment-687283518 > Thanks to @tmoreau89 for testing some custom models against this branch and finding a regression. Any one else using ONNX, I'd really appreciate it if you could do the

[GitHub] [incubator-tvm] zhiics commented on pull request #6351: Dynamic ONNX Importer

2020-09-04 Thread GitBox
zhiics commented on pull request #6351: URL: https://github.com/apache/incubator-tvm/pull/6351#issuecomment-687283801 @mbrookhart ping me please when it is ready for review This is an automated message from the Apache Git Ser

[GitHub] [incubator-tvm] yongwww commented on issue #6340: Faster RCNN: Unable to compile for CPU because topk fails

2020-09-04 Thread GitBox
yongwww commented on issue #6340: URL: https://github.com/apache/incubator-tvm/issues/6340#issuecomment-687283658 @ashutoshparkhi fasterrcnn should be supported, could you try with latest tvm again? very likely the topk issue you faced is from frontend, topk got one more unexpected argumen

[GitHub] [incubator-tvm] zxy844288792 commented on pull request #6366: [TARGET] Add layout_transform, clip and expand_dims in onnx converter

2020-09-04 Thread GitBox
zxy844288792 commented on pull request #6366: URL: https://github.com/apache/incubator-tvm/pull/6366#issuecomment-687286376 > @zxy844288792 can you re-trigger CI? It seems I cannot merge it Just retrigger the CI. This

[GitHub] [incubator-tvm] yongwww commented on pull request #6108: Fix CUDA Compute Function For `get_valid_counts` and `nms`

2020-09-04 Thread GitBox
yongwww commented on pull request #6108: URL: https://github.com/apache/incubator-tvm/pull/6108#issuecomment-687288778 @lsy643 you are right, the auxiliary op get_valid_count and strided_slice are utilized to help handle TensorFlow dynamic NonMaximumSuppression. As a todo task, the cpu an

[GitHub] [incubator-tvm] yongwww commented on a change in pull request #6388: [Relay][Topi][Op]Advanced indexing

2020-09-04 Thread GitBox
yongwww commented on a change in pull request #6388: URL: https://github.com/apache/incubator-tvm/pull/6388#discussion_r483768613 ## File path: src/relay/op/tensor/transform.cc ## @@ -3146,5 +3146,84 @@ RELAY_REGISTER_OP("matrix_set_diag") .set_attr("FTVMCompute", MatrixSe

[GitHub] [incubator-tvm] yzhliu commented on a change in pull request #6400: [Relay] Add Defunctionalization Pass

2020-09-04 Thread GitBox
yzhliu commented on a change in pull request #6400: URL: https://github.com/apache/incubator-tvm/pull/6400#discussion_r483774102 ## File path: python/tvm/relay/transform/transform.py ## @@ -736,6 +736,23 @@ def gradient(expr, mod=None, mode='higher_order'): return _ffi

[GitHub] [incubator-tvm] mbrookhart commented on a change in pull request #6388: [Relay][Topi][Op]Advanced indexing

2020-09-04 Thread GitBox
mbrookhart commented on a change in pull request #6388: URL: https://github.com/apache/incubator-tvm/pull/6388#discussion_r483783861 ## File path: src/relay/op/tensor/transform.cc ## @@ -3146,5 +3146,84 @@ RELAY_REGISTER_OP("matrix_set_diag") .set_attr("FTVMCompute", Matri

[GitHub] [incubator-tvm] hypercubestart commented on pull request #6400: [Relay] Add Defunctionalization Pass

2020-09-04 Thread GitBox
hypercubestart commented on pull request #6400: URL: https://github.com/apache/incubator-tvm/pull/6400#issuecomment-687312583 cc: @wweic @MarisaKirisame @zhiics @icemelon9 @ZihengJiang @jroesch This is an automated message f

[GitHub] [incubator-tvm] hypercubestart edited a comment on pull request #6400: [Relay] Add Defunctionalization Pass

2020-09-04 Thread GitBox
hypercubestart edited a comment on pull request #6400: URL: https://github.com/apache/incubator-tvm/pull/6400#issuecomment-687312583 cc: @wweic @MarisaKirisame @zhiics @icemelon9 @ZihengJiang @jroesch @tqchen This is an auto

[GitHub] [incubator-tvm] masahi commented on pull request #6383: [Relay/topi] Support scalar inputs in where op

2020-09-04 Thread GitBox
masahi commented on pull request #6383: URL: https://github.com/apache/incubator-tvm/pull/6383#issuecomment-687344111 @zhiics @junrushao1994 @t-vi Any other comments? I think this is a no brainer change. To keep it simple I don't want to get into broadcasting stuff for now. -

[GitHub] [incubator-tvm] zhiics commented on pull request #6383: [Relay/topi] Support scalar inputs in where op

2020-09-04 Thread GitBox
zhiics commented on pull request #6383: URL: https://github.com/apache/incubator-tvm/pull/6383#issuecomment-687391251 @t-vi do you have more comments? This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-tvm] zhiics edited a comment on pull request #6383: [Relay/topi] Support scalar inputs in where op

2020-09-04 Thread GitBox
zhiics edited a comment on pull request #6383: URL: https://github.com/apache/incubator-tvm/pull/6383#issuecomment-687391251 @t-vi do you have more comments? please take another look per https://tvm.apache.org/docs/contribute/code_review.html#approve-and-request-changes-explicitly ---

[GitHub] [incubator-tvm] t-vi commented on pull request #6383: [Relay/topi] Support scalar inputs in where op

2020-09-04 Thread GitBox
t-vi commented on pull request #6383: URL: https://github.com/apache/incubator-tvm/pull/6383#issuecomment-687406321 @zhiics No, thank you for reminding me, I have no actionable comment here. This is an automated message from

[GitHub] [incubator-tvm] zhiics merged pull request #6383: [Relay/topi] Support scalar inputs in where op

2020-09-04 Thread GitBox
zhiics merged pull request #6383: URL: https://github.com/apache/incubator-tvm/pull/6383 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[incubator-tvm] branch master updated: [Relay/topi] Support scalar inputs in where op (#6383)

2020-09-04 Thread zhic
This is an automated email from the ASF dual-hosted git repository. zhic pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 8508ec3 [Relay/topi] Support scalar inputs

[GitHub] [incubator-tvm] zhiics commented on pull request #6383: [Relay/topi] Support scalar inputs in where op

2020-09-04 Thread GitBox
zhiics commented on pull request #6383: URL: https://github.com/apache/incubator-tvm/pull/6383#issuecomment-687408425 Thanks @masahi @t-vi @junrushao1994 This is an automated message from the Apache Git Service. To respond t

[incubator-tvm] branch master updated: Remove unintentional pytest dependency. Fix #6398 (#6399)

2020-09-04 Thread liuyizhi
This is an automated email from the ASF dual-hosted git repository. liuyizhi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new e382b16 Remove unintentional pytest de

[GitHub] [incubator-tvm] yzhliu merged pull request #6399: [TEST] Remove unintentional pytest dependency

2020-09-04 Thread GitBox
yzhliu merged pull request #6399: URL: https://github.com/apache/incubator-tvm/pull/6399 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-tvm] yzhliu closed issue #6398: `import tvm` now requires pytest

2020-09-04 Thread GitBox
yzhliu closed issue #6398: URL: https://github.com/apache/incubator-tvm/issues/6398 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-tvm] yzhliu commented on pull request #6399: [TEST] Remove unintentional pytest dependency

2020-09-04 Thread GitBox
yzhliu commented on pull request #6399: URL: https://github.com/apache/incubator-tvm/pull/6399#issuecomment-687415932 Thanks @leandron @tkonolige @tqchen This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6334: µTVM RPC server and Part 1 of AutoTVM compilation infrastructure

2020-09-04 Thread GitBox
areusch commented on a change in pull request #6334: URL: https://github.com/apache/incubator-tvm/pull/6334#discussion_r483869462 ## File path: 3rdparty/mbed-os/drivers/source/MbedCRC.cpp ## @@ -0,0 +1,249 @@ +/* mbed Microcontroller Library Review comment: note to self

[GitHub] [incubator-tvm] areusch commented on pull request #6334: µTVM RPC server and Part 1 of AutoTVM compilation infrastructure

2020-09-04 Thread GitBox
areusch commented on pull request #6334: URL: https://github.com/apache/incubator-tvm/pull/6334#issuecomment-687453118 @tqchen @liangfu @tmoreau89 @tom-gall @u99127 looks like this is ready for an initial review This is an a

[GitHub] [incubator-tvm] areusch commented on pull request #6334: µTVM RPC server and Part 1 of AutoTVM compilation infrastructure

2020-09-04 Thread GitBox
areusch commented on pull request #6334: URL: https://github.com/apache/incubator-tvm/pull/6334#issuecomment-687453486 See the accompanying [RFC](https://discuss.tvm.apache.org/t/rfc-tvm-tvm-rpc-server/7742) This is an autom

[GitHub] [incubator-tvm] yzhliu commented on a change in pull request #6370: [TOPI] Add einsum operator

2020-09-04 Thread GitBox
yzhliu commented on a change in pull request #6370: URL: https://github.com/apache/incubator-tvm/pull/6370#discussion_r483869815 ## File path: include/tvm/topi/einsum.h ## @@ -0,0 +1,872 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

[GitHub] [incubator-tvm] jroesch opened a new pull request #6401: [Rust] Improve the error reporting in build.rs files by using anyhow.

2020-09-04 Thread GitBox
jroesch opened a new pull request #6401: URL: https://github.com/apache/incubator-tvm/pull/6401 This improves errors when build.rs scripts fail. cc @robo-corg, @mwillsey and @areusch This is an automated message from the Ap

[GitHub] [incubator-tvm] lixiaoquan closed pull request #6024: [Relay][TF] Make StridedSlice support dynamic input and constant attrs

2020-09-04 Thread GitBox
lixiaoquan closed pull request #6024: URL: https://github.com/apache/incubator-tvm/pull/6024 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-tvm] lixiaoquan commented on pull request #6024: [Relay][TF] Make StridedSlice support dynamic input and constant attrs

2020-09-04 Thread GitBox
lixiaoquan commented on pull request #6024: URL: https://github.com/apache/incubator-tvm/pull/6024#issuecomment-687462095 > @lixiaoquan Any update? Sorry the late reply, I think I need some time to figure out how to handle mask in dynamic case, I'll close it for now. --

[GitHub] [incubator-tvm] tqchen commented on pull request #6334: µTVM RPC server and Part 1 of AutoTVM compilation infrastructure

2020-09-04 Thread GitBox
tqchen commented on pull request #6334: URL: https://github.com/apache/incubator-tvm/pull/6334#issuecomment-687463952 cc @weberlo @zhiics This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [incubator-tvm] jroesch merged pull request #6384: Add safe up/downcasting to the Rust object system

2020-09-04 Thread GitBox
jroesch merged pull request #6384: URL: https://github.com/apache/incubator-tvm/pull/6384 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-tvm] branch master updated (e382b16 -> 73d9e01)

2020-09-04 Thread jroesch
This is an automated email from the ASF dual-hosted git repository. jroesch pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from e382b16 Remove unintentional pytest dependency. Fix #6398 (#6399) add 73d9e01 Add safe up/downcasting

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6334: µTVM RPC server and Part 1 of AutoTVM compilation infrastructure

2020-09-04 Thread GitBox
tqchen commented on a change in pull request #6334: URL: https://github.com/apache/incubator-tvm/pull/6334#discussion_r483879722 ## File path: include/tvm/runtime/crt/rpc_common/buffer.h ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6334: µTVM RPC server and Part 1 of AutoTVM compilation infrastructure

2020-09-04 Thread GitBox
tqchen commented on a change in pull request #6334: URL: https://github.com/apache/incubator-tvm/pull/6334#discussion_r483882571 ## File path: include/tvm/runtime/crt/rpc_common/framing.h ## @@ -0,0 +1,267 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6355: [BYOC][ETHOSN] Introduce further operator support

2020-09-04 Thread GitBox
comaniac commented on a change in pull request #6355: URL: https://github.com/apache/incubator-tvm/pull/6355#discussion_r483878188 ## File path: src/runtime/contrib/ethosn/ethosn_runtime.cc ## @@ -120,6 +120,14 @@ Module EthosnModule::LoadFromBinary(void* strm) { return Modu

[GitHub] [incubator-tvm] tmoreau89 opened a new pull request #6402: [VTA][Xilinx] Update to Vivado 2020.1 and Pynq 2.5

2020-09-04 Thread GitBox
tmoreau89 opened a new pull request #6402: URL: https://github.com/apache/incubator-tvm/pull/6402 Summary: * Bumping Vivado version to the lastest 2020.1 thanks to @vegaluisjose's PR https://github.com/apache/incubator-tvm-vta/pull/10 * Updating docs to reflect version change * Upd

[GitHub] [incubator-tvm] tmoreau89 commented on pull request #6402: [VTA][Xilinx] Update to Vivado 2020.1 and Pynq 2.5

2020-09-04 Thread GitBox
tmoreau89 commented on pull request #6402: URL: https://github.com/apache/incubator-tvm/pull/6402#issuecomment-687520533 @vegaluisjose @liangfu @huajsj This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-tvm-vta] tmoreau89 commented on a change in pull request #9: [Hardware][OpenCL] Intelfocl support

2020-09-04 Thread GitBox
tmoreau89 commented on a change in pull request #9: URL: https://github.com/apache/incubator-tvm-vta/pull/9#discussion_r483898387 ## File path: src/oclfpga/oclfpga_driver.cc ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

[GitHub] [incubator-tvm-vta] tmoreau89 commented on a change in pull request #9: [Hardware][OpenCL] Intelfocl support

2020-09-04 Thread GitBox
tmoreau89 commented on a change in pull request #9: URL: https://github.com/apache/incubator-tvm-vta/pull/9#discussion_r483898612 ## File path: src/sim/sim_driver.cc ## @@ -181,6 +181,51 @@ class SRAM { } memset(sram_ptr, 0, kElemBytes * xtotal * op->y_pad_1); } +

[GitHub] [incubator-tvm-vta] tmoreau89 commented on pull request #9: [Hardware][OpenCL] Intelfocl support

2020-09-04 Thread GitBox
tmoreau89 commented on pull request #9: URL: https://github.com/apache/incubator-tvm-vta/pull/9#issuecomment-687523850 Thanks again @remotego for addressing the comments. If we could address: (1) Adding a README file (ideally with instructions on how to compile / run on the FPGA) before

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6391: [AutoTVM][Ansor] Enable random fill and CPU cache flush for AutoTVM and Ansor

2020-09-04 Thread GitBox
merrymercy commented on a change in pull request #6391: URL: https://github.com/apache/incubator-tvm/pull/6391#discussion_r483899527 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -697,7 +696,7 @@ def timed_func(): args = [ndarray.empty(get_const_tupl

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6391: [AutoTVM][Ansor] Enable random fill and CPU cache flush for AutoTVM and Ansor

2020-09-04 Thread GitBox
merrymercy commented on a change in pull request #6391: URL: https://github.com/apache/incubator-tvm/pull/6391#discussion_r483899674 ## File path: python/tvm/autotvm/measure/measure_methods.py ## @@ -511,10 +511,12 @@ def run_through_rpc(measure_input, build_result, if

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6391: [AutoTVM][Ansor] Enable random fill and CPU cache flush for AutoTVM and Ansor

2020-09-04 Thread GitBox
merrymercy commented on a change in pull request #6391: URL: https://github.com/apache/incubator-tvm/pull/6391#discussion_r483899674 ## File path: python/tvm/autotvm/measure/measure_methods.py ## @@ -511,10 +511,12 @@ def run_through_rpc(measure_input, build_result, if

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6391: [AutoTVM][Ansor] Enable random fill and CPU cache flush for AutoTVM and Ansor

2020-09-04 Thread GitBox
merrymercy commented on a change in pull request #6391: URL: https://github.com/apache/incubator-tvm/pull/6391#discussion_r483899674 ## File path: python/tvm/autotvm/measure/measure_methods.py ## @@ -511,10 +511,12 @@ def run_through_rpc(measure_input, build_result, if

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6391: [AutoTVM][Ansor] Enable random fill and CPU cache flush for AutoTVM and Ansor

2020-09-04 Thread GitBox
merrymercy commented on a change in pull request #6391: URL: https://github.com/apache/incubator-tvm/pull/6391#discussion_r483899674 ## File path: python/tvm/autotvm/measure/measure_methods.py ## @@ -511,10 +511,12 @@ def run_through_rpc(measure_input, build_result, if

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6391: [AutoTVM][Ansor] Enable random fill and CPU cache flush for AutoTVM and Ansor

2020-09-04 Thread GitBox
merrymercy commented on a change in pull request #6391: URL: https://github.com/apache/incubator-tvm/pull/6391#discussion_r483899674 ## File path: python/tvm/autotvm/measure/measure_methods.py ## @@ -511,10 +511,12 @@ def run_through_rpc(measure_input, build_result, if

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #6391: [AutoTVM][Ansor] Enable random fill and CPU cache flush for AutoTVM and Ansor

2020-09-04 Thread GitBox
FrozenGene commented on a change in pull request #6391: URL: https://github.com/apache/incubator-tvm/pull/6391#discussion_r483906265 ## File path: python/tvm/autotvm/measure/measure_methods.py ## @@ -511,10 +511,12 @@ def run_through_rpc(measure_input, build_result, if

[GitHub] [incubator-tvm] vegaluisjose commented on pull request #6402: [VTA][Xilinx] Update to Vivado 2020.1 and Pynq 2.5

2020-09-04 Thread GitBox
vegaluisjose commented on pull request #6402: URL: https://github.com/apache/incubator-tvm/pull/6402#issuecomment-687545514 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log