[GitHub] [tvm] insop commented on pull request #7111: Fix a bug in batch_matmul that te.max should be used

insop commented on pull request #7111: URL: https://github.com/apache/tvm/pull/7111#issuecomment-747196507 @tsupei There was a clang-format check fali, here is another [patch](https://github.com/insop/incubator-tvm/commit/f98c5db737ecac5bd2bf4df0204299cb88108978.patch). Thank

[GitHub] [tvm] tqchen commented on a change in pull request #7084: [TIR] Support Return in TIR

tqchen commented on a change in pull request #7084: URL: https://github.com/apache/tvm/pull/7084#discussion_r544772948 ## File path: src/tir/transforms/make_packed_api.cc ## @@ -41,6 +41,56 @@ namespace tvm { namespace tir { +class ReturnRewriter : public StmtMutator { + pu

[GitHub] [tvm] tqchen commented on a change in pull request #7084: [TIR] Support Return in TIR

tqchen commented on a change in pull request #7084: URL: https://github.com/apache/tvm/pull/7084#discussion_r544769579 ## File path: src/tir/transforms/make_packed_api.cc ## @@ -41,6 +41,56 @@ namespace tvm { namespace tir { +class ReturnRewriter : public StmtMutator { + pu

[GitHub] [tvm] tqchen commented on a change in pull request #7084: [TIR] Support Return in TIR

tqchen commented on a change in pull request #7084: URL: https://github.com/apache/tvm/pull/7084#discussion_r544764730 ## File path: src/tir/transforms/make_packed_api.cc ## @@ -41,6 +41,56 @@ namespace tvm { namespace tir { +class ReturnRewriter : public StmtMutator { + pu

[GitHub] [tvm] tqchen commented on a change in pull request #7084: [TIR] Support Return in TIR

tqchen commented on a change in pull request #7084: URL: https://github.com/apache/tvm/pull/7084#discussion_r544764730 ## File path: src/tir/transforms/make_packed_api.cc ## @@ -41,6 +41,56 @@ namespace tvm { namespace tir { +class ReturnRewriter : public StmtMutator { + pu

[GitHub] [tvm] tkonolige commented on a change in pull request #7084: [TIR] Support Return in TIR

tkonolige commented on a change in pull request #7084: URL: https://github.com/apache/tvm/pull/7084#discussion_r544735615 ## File path: src/tir/transforms/make_packed_api.cc ## @@ -41,6 +41,56 @@ namespace tvm { namespace tir { +class ReturnRewriter : public StmtMutator { +

[GitHub] [tvm] tkonolige commented on a change in pull request #7084: [TIR] Support Return in TIR

tkonolige commented on a change in pull request #7084: URL: https://github.com/apache/tvm/pull/7084#discussion_r544734076 ## File path: src/tir/transforms/make_packed_api.cc ## @@ -41,6 +41,56 @@ namespace tvm { namespace tir { +class ReturnRewriter : public StmtMutator { +

[GitHub] [tvm] ZihengJiang commented on a change in pull request #7084: [TIR] Support Return in TIR

ZihengJiang commented on a change in pull request #7084: URL: https://github.com/apache/tvm/pull/7084#discussion_r544733728 ## File path: src/tir/transforms/make_packed_api.cc ## @@ -41,6 +41,56 @@ namespace tvm { namespace tir { +class ReturnRewriter : public StmtMutator {

[GitHub] [tvm] ZihengJiang commented on a change in pull request #7084: [TIR] Support Return in TIR

ZihengJiang commented on a change in pull request #7084: URL: https://github.com/apache/tvm/pull/7084#discussion_r544733728 ## File path: src/tir/transforms/make_packed_api.cc ## @@ -41,6 +41,56 @@ namespace tvm { namespace tir { +class ReturnRewriter : public StmtMutator {

[GitHub] [tvm] ZihengJiang commented on a change in pull request #7084: [TIR] Support Return in TIR

ZihengJiang commented on a change in pull request #7084: URL: https://github.com/apache/tvm/pull/7084#discussion_r544730479 ## File path: src/tir/transforms/make_packed_api.cc ## @@ -41,6 +41,56 @@ namespace tvm { namespace tir { +class ReturnRewriter : public StmtMutator {

[GitHub] [tvm] ZihengJiang commented on a change in pull request #7084: [TIR] Support Return in TIR

ZihengJiang commented on a change in pull request #7084: URL: https://github.com/apache/tvm/pull/7084#discussion_r544730479 ## File path: src/tir/transforms/make_packed_api.cc ## @@ -41,6 +41,56 @@ namespace tvm { namespace tir { +class ReturnRewriter : public StmtMutator {

[GitHub] [tvm] tqchen commented on a change in pull request #7084: [TIR] Support Return in TIR

tqchen commented on a change in pull request #7084: URL: https://github.com/apache/tvm/pull/7084#discussion_r544730502 ## File path: src/tir/transforms/make_packed_api.cc ## @@ -41,6 +41,56 @@ namespace tvm { namespace tir { +class ReturnRewriter : public StmtMutator { + pu

[GitHub] [tvm] tqchen commented on a change in pull request #7084: [TIR] Support Return in TIR

tqchen commented on a change in pull request #7084: URL: https://github.com/apache/tvm/pull/7084#discussion_r544730063 ## File path: src/tir/transforms/make_packed_api.cc ## @@ -41,6 +41,56 @@ namespace tvm { namespace tir { +class ReturnRewriter : public StmtMutator { + pu

[GitHub] [tvm] tqchen commented on a change in pull request #7084: [TIR] Support Return in TIR

tqchen commented on a change in pull request #7084: URL: https://github.com/apache/tvm/pull/7084#discussion_r544730063 ## File path: src/tir/transforms/make_packed_api.cc ## @@ -41,6 +41,56 @@ namespace tvm { namespace tir { +class ReturnRewriter : public StmtMutator { + pu

[GitHub] [tvm] jroesch commented on a change in pull request #7084: [TIR] Support Return in TIR

jroesch commented on a change in pull request #7084: URL: https://github.com/apache/tvm/pull/7084#discussion_r544728295 ## File path: src/tir/transforms/make_packed_api.cc ## @@ -41,6 +41,56 @@ namespace tvm { namespace tir { +class ReturnRewriter : public StmtMutator { + p

[GitHub] [tvm] tkonolige commented on a change in pull request #7084: [TIR] Support Return in TIR

tkonolige commented on a change in pull request #7084: URL: https://github.com/apache/tvm/pull/7084#discussion_r544722927 ## File path: src/tir/transforms/make_packed_api.cc ## @@ -41,6 +41,56 @@ namespace tvm { namespace tir { +class ReturnRewriter : public StmtMutator { +

[GitHub] [tvm] tkonolige commented on a change in pull request #7084: [TIR] Support Return in TIR

tkonolige commented on a change in pull request #7084: URL: https://github.com/apache/tvm/pull/7084#discussion_r544722927 ## File path: src/tir/transforms/make_packed_api.cc ## @@ -41,6 +41,56 @@ namespace tvm { namespace tir { +class ReturnRewriter : public StmtMutator { +

[GitHub] [tvm] tkonolige commented on a change in pull request #7084: [TIR] Support Return in TIR

tkonolige commented on a change in pull request #7084: URL: https://github.com/apache/tvm/pull/7084#discussion_r544710171 ## File path: src/tir/transforms/make_packed_api.cc ## @@ -41,6 +41,56 @@ namespace tvm { namespace tir { +class ReturnRewriter : public StmtMutator { +

[GitHub] [tvm] tqchen commented on a change in pull request #7084: [TIR] Support Return in TIR

tqchen commented on a change in pull request #7084: URL: https://github.com/apache/tvm/pull/7084#discussion_r544715878 ## File path: src/tir/transforms/make_packed_api.cc ## @@ -41,6 +41,56 @@ namespace tvm { namespace tir { +class ReturnRewriter : public StmtMutator { + pu

[GitHub] [tvm] tqchen commented on a change in pull request #7084: [TIR] Support Return in TIR

tqchen commented on a change in pull request #7084: URL: https://github.com/apache/tvm/pull/7084#discussion_r544715878 ## File path: src/tir/transforms/make_packed_api.cc ## @@ -41,6 +41,56 @@ namespace tvm { namespace tir { +class ReturnRewriter : public StmtMutator { + pu

[GitHub] [tvm] tqchen commented on a change in pull request #7084: [TIR] Support Return in TIR

tqchen commented on a change in pull request #7084: URL: https://github.com/apache/tvm/pull/7084#discussion_r544715878 ## File path: src/tir/transforms/make_packed_api.cc ## @@ -41,6 +41,56 @@ namespace tvm { namespace tir { +class ReturnRewriter : public StmtMutator { + pu

[GitHub] [tvm] icemelon9 commented on a change in pull request #7120: [PatternLang] Add Syntatic Sugar to the C++ pattern API and support DataType Attribute Matching

icemelon9 commented on a change in pull request #7120: URL: https://github.com/apache/tvm/pull/7120#discussion_r544714342 ## File path: include/tvm/relay/dataflow_pattern.h ## @@ -46,6 +48,29 @@ class DFPatternNode : public Object { */ class DFPattern : public ObjectRef {

[GitHub] [tvm] tkonolige commented on a change in pull request #7084: [TIR] Support Return in TIR

tkonolige commented on a change in pull request #7084: URL: https://github.com/apache/tvm/pull/7084#discussion_r544710171 ## File path: src/tir/transforms/make_packed_api.cc ## @@ -41,6 +41,56 @@ namespace tvm { namespace tir { +class ReturnRewriter : public StmtMutator { +

[GitHub] [tvm] altanh commented on pull request #7083: [RELAY,TOPI] Threefry PRNG: splittable and stateless

altanh commented on pull request #7083: URL: https://github.com/apache/tvm/pull/7083#issuecomment-747112272 I've moved everything to a new `random` namespace (for Relay and TOPI) and fixed a small bug. This should be good to go I think.

[GitHub] [tvm] tqchen commented on pull request #7083: [RELAY,TOPI] Threefry PRNG: splittable and stateless

tqchen commented on pull request #7083: URL: https://github.com/apache/tvm/pull/7083#issuecomment-747111481 cc @antinucleon This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [tvm] tqchen commented on a change in pull request #7084: [TIR] Support Return in TIR

tqchen commented on a change in pull request #7084: URL: https://github.com/apache/tvm/pull/7084#discussion_r544707446 ## File path: src/tir/transforms/make_packed_api.cc ## @@ -41,6 +41,56 @@ namespace tvm { namespace tir { +class ReturnRewriter : public StmtMutator { + pu

[GitHub] [tvm] tqchen commented on a change in pull request #7084: [TIR] Support Return in TIR

tqchen commented on a change in pull request #7084: URL: https://github.com/apache/tvm/pull/7084#discussion_r544707225 ## File path: src/tir/transforms/make_packed_api.cc ## @@ -41,6 +41,56 @@ namespace tvm { namespace tir { +class ReturnRewriter : public StmtMutator { + pu

[GitHub] [tvm] masahi commented on a change in pull request #6978: [Relay][Topi]Add Sort Op to Relay

masahi commented on a change in pull request #6978: URL: https://github.com/apache/tvm/pull/6978#discussion_r544676738 ## File path: python/tvm/topi/cuda/sort.py ## @@ -316,6 +316,89 @@ def argsort_nms_thrust(data, valid_count, axis=-1, is_ascend=1, dtype="float32") retur

[GitHub] [tvm] mbrookhart commented on a change in pull request #6978: [Relay][Topi]Add Sort Op to Relay

mbrookhart commented on a change in pull request #6978: URL: https://github.com/apache/tvm/pull/6978#discussion_r544675262 ## File path: python/tvm/topi/cuda/sort.py ## @@ -316,6 +316,89 @@ def argsort_nms_thrust(data, valid_count, axis=-1, is_ascend=1, dtype="float32") r

[GitHub] [tvm] masahi commented on a change in pull request #6978: [Relay][Topi]Add Sort Op to Relay

masahi commented on a change in pull request #6978: URL: https://github.com/apache/tvm/pull/6978#discussion_r544668080 ## File path: python/tvm/topi/cuda/sort.py ## @@ -316,6 +316,89 @@ def argsort_nms_thrust(data, valid_count, axis=-1, is_ascend=1, dtype="float32") retur

[GitHub] [tvm] masahi commented on a change in pull request #6978: [Relay][Topi]Add Sort Op to Relay

masahi commented on a change in pull request #6978: URL: https://github.com/apache/tvm/pull/6978#discussion_r544666115 ## File path: python/tvm/topi/cuda/sort.py ## @@ -316,6 +316,89 @@ def argsort_nms_thrust(data, valid_count, axis=-1, is_ascend=1, dtype="float32") retur

[GitHub] [tvm] masahi commented on a change in pull request #6978: [Relay][Topi]Add Sort Op to Relay

masahi commented on a change in pull request #6978: URL: https://github.com/apache/tvm/pull/6978#discussion_r544665982 ## File path: python/tvm/topi/cuda/sort.py ## @@ -316,6 +316,89 @@ def argsort_nms_thrust(data, valid_count, axis=-1, is_ascend=1, dtype="float32") retur

[GitHub] [tvm] manupa-arm commented on a change in pull request #7002: Created CSourceMetaData module for model metadata

manupa-arm commented on a change in pull request #7002: URL: https://github.com/apache/tvm/pull/7002#discussion_r544579729 ## File path: python/tvm/runtime/module.py ## @@ -268,6 +268,11 @@ def export_library(self, file_name, fcompile=None, addons=None, **kwargs):

[GitHub] [tvm] manupa-arm commented on a change in pull request #7002: Created CSourceMetaData module for model metadata

manupa-arm commented on a change in pull request #7002: URL: https://github.com/apache/tvm/pull/7002#discussion_r544579500 ## File path: src/target/source/source_module.cc ## @@ -46,20 +48,25 @@ using runtime::SaveBinaryToFile; *codegens, such as graph runtime codegen

[GitHub] [tvm] manupa-arm commented on a change in pull request #7002: Created CSourceMetaData module for model metadata

manupa-arm commented on a change in pull request #7002: URL: https://github.com/apache/tvm/pull/7002#discussion_r544574951 ## File path: src/relay/backend/contrib/codegen_c/codegen.cc ## @@ -215,20 +215,24 @@ class CodegenC : public MemoizedExprTranslator>, public Code clas

[GitHub] [tvm] manupa-arm commented on a change in pull request #7002: Created CSourceMetaData module for model metadata

manupa-arm commented on a change in pull request #7002: URL: https://github.com/apache/tvm/pull/7002#discussion_r544574734 ## File path: python/tvm/runtime/module.py ## @@ -330,25 +341,25 @@ def export_library(self, file_name, fcompile=None, addons=None, **kwargs):

[GitHub] [tvm] manupa-arm commented on a change in pull request #7002: Created CSourceMetaData module for model metadata

manupa-arm commented on a change in pull request #7002: URL: https://github.com/apache/tvm/pull/7002#discussion_r544574591 ## File path: python/tvm/runtime/module.py ## @@ -268,6 +268,11 @@ def export_library(self, file_name, fcompile=None, addons=None, **kwargs):

[GitHub] [tvm] manupa-arm commented on a change in pull request #7002: Created CSourceMetaData module for model metadata

manupa-arm commented on a change in pull request #7002: URL: https://github.com/apache/tvm/pull/7002#discussion_r544574436 ## File path: python/tvm/micro/build.py ## @@ -74,8 +74,8 @@ def path(self): _CRT_DEFAULT_OPTIONS = { "cflags": ["-std=c11"] + _COMMON_CFLAGS, -

[GitHub] [tvm] kevinthesun commented on a change in pull request #7117: [TOPI] Fix GPU Dynamic Op Schedule

kevinthesun commented on a change in pull request #7117: URL: https://github.com/apache/tvm/pull/7117#discussion_r544558622 ## File path: python/tvm/topi/cuda/conv2d_transpose_nchw.py ## @@ -194,6 +197,8 @@ def _callback(op): if cfg.is_fallback:

[GitHub] [tvm] kevinthesun commented on a change in pull request #7117: [TOPI] Fix GPU Dynamic Op Schedule

kevinthesun commented on a change in pull request #7117: URL: https://github.com/apache/tvm/pull/7117#discussion_r544558368 ## File path: python/tvm/topi/cuda/nms.py ## @@ -754,7 +782,22 @@ def non_max_suppression( ) score_axis = score_index score_shape = (batch_

[GitHub] [tvm] mbrookhart commented on a change in pull request #7117: [TOPI] Fix GPU Dynamic Op Schedule

mbrookhart commented on a change in pull request #7117: URL: https://github.com/apache/tvm/pull/7117#discussion_r544553996 ## File path: tests/python/relay/test_any.py ## @@ -1430,6 +1439,21 @@ def test_non_max_suppression(): disable_targets=["nvptx"], ) +np

[GitHub] [tvm] kevinthesun commented on a change in pull request #7117: [TOPI] Fix GPU Dynamic Op Schedule

kevinthesun commented on a change in pull request #7117: URL: https://github.com/apache/tvm/pull/7117#discussion_r544551395 ## File path: tests/python/relay/test_any.py ## @@ -1430,6 +1439,21 @@ def test_non_max_suppression(): disable_targets=["nvptx"], ) +n

[GitHub] [tvm] mbrookhart opened a new pull request #7120: [PatternLang] Add Syntatic Sugar to the C++ pattern API and support DataType Attribute Matching

mbrookhart opened a new pull request #7120: URL: https://github.com/apache/tvm/pull/7120 cc @icemelon9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [tvm] mbrookhart commented on a change in pull request #7117: [TOPI] Fix GPU Dynamic Op Schedule

mbrookhart commented on a change in pull request #7117: URL: https://github.com/apache/tvm/pull/7117#discussion_r544452199 ## File path: tests/python/relay/test_any.py ## @@ -1430,6 +1439,21 @@ def test_non_max_suppression(): disable_targets=["nvptx"], ) +np

[GitHub] [tvm] mbrookhart commented on a change in pull request #7117: [TOPI] Fix GPU Dynamic Op Schedule

mbrookhart commented on a change in pull request #7117: URL: https://github.com/apache/tvm/pull/7117#discussion_r544451189 ## File path: python/tvm/topi/cuda/nms.py ## @@ -95,23 +94,23 @@ def rearrange_indices_out_ir(data, output, valid_box_count): with ib.new_scope():

[GitHub] [tvm] tkonolige commented on a change in pull request #7084: [TIR] Support Return in TIR

tkonolige commented on a change in pull request #7084: URL: https://github.com/apache/tvm/pull/7084#discussion_r53419 ## File path: src/tir/transforms/make_packed_api.cc ## @@ -41,6 +41,56 @@ namespace tvm { namespace tir { +class ReturnRewriter : public StmtMutator { +

[GitHub] [tvm] tkonolige commented on a change in pull request #7107: [Tutorial] Add output validation to sparse tutorial

tkonolige commented on a change in pull request #7107: URL: https://github.com/apache/tvm/pull/7107#discussion_r544439232 ## File path: tutorials/frontend/deploy_sparse.py ## @@ -119,6 +117,9 @@ # determines how sparse the generated weights should be. The higher # the sparsit

[GitHub] [tvm] ANSHUMAN87 opened a new pull request #7119: [Frontend] Unnecessary default warning msg changed to debug

ANSHUMAN87 opened a new pull request #7119: URL: https://github.com/apache/tvm/pull/7119 By default the log level=WARNING in the package "logging". As these logs are not useful by default, unless we want to debug any issue encountered or developing new feature. Hence the func used is

[GitHub] [tvm] d-smirnov commented on a change in pull request #7114: [TFLite] Added check for dynamic range quantization

d-smirnov commented on a change in pull request #7114: URL: https://github.com/apache/tvm/pull/7114#discussion_r544334819 ## File path: python/tvm/relay/frontend/tflite.py ## @@ -174,17 +174,42 @@ def __init__(self, model, subgraph, exp_tab): def check_unsupported_ops(self

[GitHub] [tvm] liangfu commented on a change in pull request #6964: [µTVM] Add platform timer and RPCTimeEvaluator to enable AutoTVM

liangfu commented on a change in pull request #6964: URL: https://github.com/apache/tvm/pull/6964#discussion_r544324405 ## File path: src/runtime/crt/common/crt_runtime_api.c ## @@ -351,10 +375,120 @@ tvm_crt_error_t TVMInitializeRuntime() { error = TVMFuncRegisterGlobal("

[tvm] branch main updated (18cf9b9 -> 053347c)

This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 18cf9b9 [Relay][Frontend][Onnx] Auto extract onnx input shapes when possible. (#7115) add 053347c [metal] Remove s

[GitHub] [tvm] tqchen commented on pull request #7084: [TIR] Support Return in TIR

tqchen commented on pull request #7084: URL: https://github.com/apache/tvm/pull/7084#issuecomment-746322447 One additional comment, overall lgtm. @junrushao1994 @tkonolige @areusch please take another look and https://tvm.apache.org/docs/contribute/code_review.html#approve-and-request-chan

[GitHub] [tvm] tqchen commented on a change in pull request #7084: [TIR] Support Return in TIR

tqchen commented on a change in pull request #7084: URL: https://github.com/apache/tvm/pull/7084#discussion_r544315890 ## File path: src/tir/op/builtin.cc ## @@ -42,6 +42,10 @@ TIR_DEFINE_BUILTIN_FUNC(reinterpret) .set_attr("TCallEffectKind", Integer(CallEffectKind::kPure

[GitHub] [tvm] tqchen commented on pull request #7118: [metal] Remove support of `double` type

tqchen commented on pull request #7118: URL: https://github.com/apache/tvm/pull/7118#issuecomment-746319035 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [tvm] tqchen merged pull request #7118: [metal] Remove support of `double` type

tqchen merged pull request #7118: URL: https://github.com/apache/tvm/pull/7118 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [tvm] alter-xp commented on pull request #6949: [TF frontend] add support for StridedSlice to input a single constant

alter-xp commented on pull request #6949: URL: https://github.com/apache/tvm/pull/6949#issuecomment-746124247 eh, this branch has not been merged? Is there any problem? This is an automated message from the Apache Git Service

[GitHub] [tvm] insop edited a comment on pull request #7111: Fix a bug in batch_matmul that te.max should be used

insop edited a comment on pull request #7111: URL: https://github.com/apache/tvm/pull/7111#issuecomment-745979049 @tsupei , @zhiics How about this? by doing this, we can test. Patch is [here](https://github.com/insop/incubator-tvm/commit/9b7b1589f4a05a739e19652b7a2705e4bfc7bfcb.p

[GitHub] [tvm] insop edited a comment on issue #7102: [TOPI] batch_matmul cannot use and / or / not operator to Expr

insop edited a comment on issue #7102: URL: https://github.com/apache/tvm/issues/7102#issuecomment-745977528 Moved the post to https://github.com/apache/tvm/pull/7111 instead This is an automated message from the Apache Git S

[GitHub] [tvm] insop commented on pull request #7111: Fix a bug in batch_matmul that te.max should be used

insop commented on pull request #7111: URL: https://github.com/apache/tvm/pull/7111#issuecomment-745979049 @tsupei , @zhiics How about this? by this, we can test. Patch is [here](https://github.com/insop/incubator-tvm/commit/9b7b1589f4a05a739e19652b7a2705e4bfc7bfcb.patch).

[GitHub] [tvm] insop commented on issue #7102: [TOPI] batch_matmul cannot use and / or / not operator to Expr

insop commented on issue #7102: URL: https://github.com/apache/tvm/issues/7102#issuecomment-745977528 @tsupei , @zhiics How about this? by this, we can test. Patch is [here](https://github.com/insop/incubator-tvm/commit/9b7b1589f4a05a739e19652b7a2705e4bfc7bfcb.patch). ```

[GitHub] [tvm] giuseros commented on a change in pull request #7114: [TFLite] Added check for dynamic range quantization

giuseros commented on a change in pull request #7114: URL: https://github.com/apache/tvm/pull/7114#discussion_r544131339 ## File path: python/tvm/relay/frontend/tflite.py ## @@ -174,17 +174,42 @@ def __init__(self, model, subgraph, exp_tab): def check_unsupported_ops(self)