[tvm] branch main updated (d6d6367 -> 0a1eae8)

2021-08-22 Thread junrushao
This is an automated email from the ASF dual-hosted git repository. junrushao pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from d6d6367 Fix typos (#8787) add 0a1eae8 [TensorIR][M2a] Reorder (#8767) No new revisions were added by this

[GitHub] [tvm] junrushao1994 commented on pull request #8767: [TensorIR][M2a] Reorder

2021-08-22 Thread GitBox
junrushao1994 commented on pull request #8767: URL: https://github.com/apache/tvm/pull/8767#issuecomment-903456217 Thanks @jinhongyii for your patience and @MasterJH5574 for helping with code review! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tvm] junrushao1994 merged pull request #8767: [TensorIR][M2a] Reorder

2021-08-22 Thread GitBox
junrushao1994 merged pull request #8767: URL: https://github.com/apache/tvm/pull/8767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] masahi commented on pull request #8781: [Frontend] [Torch] [ONNX] GRU layer

2021-08-22 Thread GitBox
masahi commented on pull request #8781: URL: https://github.com/apache/tvm/pull/8781#issuecomment-903414959 @vvchernov Please add PyTorch GRU tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [tvm] masahi commented on a change in pull request #8781: [Frontend] [Torch] [ONNX] GRU layer

2021-08-22 Thread GitBox
masahi commented on a change in pull request #8781: URL: https://github.com/apache/tvm/pull/8781#discussion_r693628271 ## File path: python/tvm/relay/frontend/common.py ## @@ -658,6 +658,92 @@ def unbind(data, axis=0): return _expr.TupleWrapper(_expr.Tuple(ret),

[GitHub] [tvm] masahi commented on a change in pull request #8781: [Frontend] [Torch] [ONNX] GRU layer

2021-08-22 Thread GitBox
masahi commented on a change in pull request #8781: URL: https://github.com/apache/tvm/pull/8781#discussion_r693628005 ## File path: python/tvm/relay/frontend/common.py ## @@ -658,6 +658,92 @@ def unbind(data, axis=0): return _expr.TupleWrapper(_expr.Tuple(ret),

[GitHub] [tvm] masahi commented on a change in pull request #8781: [Frontend] [Torch] [ONNX] GRU layer

2021-08-22 Thread GitBox
masahi commented on a change in pull request #8781: URL: https://github.com/apache/tvm/pull/8781#discussion_r693628005 ## File path: python/tvm/relay/frontend/common.py ## @@ -658,6 +658,92 @@ def unbind(data, axis=0): return _expr.TupleWrapper(_expr.Tuple(ret),

[GitHub] [tvm] masahi commented on a change in pull request #8781: [Frontend] [Torch] [ONNX] GRU layer

2021-08-22 Thread GitBox
masahi commented on a change in pull request #8781: URL: https://github.com/apache/tvm/pull/8781#discussion_r693627752 ## File path: python/tvm/relay/frontend/common.py ## @@ -658,6 +658,92 @@ def unbind(data, axis=0): return _expr.TupleWrapper(_expr.Tuple(ret),

[GitHub] [tvm-vta] tmoreau89 commented on pull request #32: VTA Chisel Wide memory interface.

2021-08-22 Thread GitBox
tmoreau89 commented on pull request #32: URL: https://github.com/apache/tvm-vta/pull/32#issuecomment-903379745 #34 was just merged, @aasorokiin please rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [tvm-vta] tmoreau89 merged pull request #34: Fix simulation for new chisel release

2021-08-22 Thread GitBox
tmoreau89 merged pull request #34: URL: https://github.com/apache/tvm-vta/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[tvm-vta] branch main updated: fix types (#34)

2021-08-22 Thread moreau
This is an automated email from the ASF dual-hosted git repository. moreau pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm-vta.git The following commit(s) were added to refs/heads/main by this push: new 981bf2f fix types (#34) 981bf2f is described

[GitHub] [tvm-vta] vegaluisjose commented on pull request #32: VTA Chisel Wide memory interface.

2021-08-22 Thread GitBox
vegaluisjose commented on pull request #32: URL: https://github.com/apache/tvm-vta/pull/32#issuecomment-903322080 I think I found the issue of the new chisel version, I just submitted #34 that should fix it. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tvm] vegaluisjose commented on a change in pull request #8797: VTA cmake change to include Verilator header for building tsim library

2021-08-22 Thread GitBox
vegaluisjose commented on a change in pull request #8797: URL: https://github.com/apache/tvm/pull/8797#discussion_r693548857 ## File path: cmake/modules/VTA.cmake ## @@ -73,15 +73,30 @@ elseif(PYTHON) # Cycle accurate simulator driver build if(USE_VTA_TSIM) +if(NOT

[GitHub] [tvm-vta] vegaluisjose opened a new pull request #34: Fix simulation for new chisel release

2021-08-22 Thread GitBox
vegaluisjose opened a new pull request #34: URL: https://github.com/apache/tvm-vta/pull/34 The following fixes building simulation files for the new chisel version update done in #33 @tmoreau89 @ekiwi -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [tvm] aasorokiin commented on a change in pull request #8797: VTA cmake change to include Verilator header for building tsim library

2021-08-22 Thread GitBox
aasorokiin commented on a change in pull request #8797: URL: https://github.com/apache/tvm/pull/8797#discussion_r693547334 ## File path: cmake/modules/VTA.cmake ## @@ -73,15 +73,30 @@ elseif(PYTHON) # Cycle accurate simulator driver build if(USE_VTA_TSIM) +if(NOT

[GitHub] [tvm] aasorokiin commented on a change in pull request #8797: VTA cmake change to include Verilator header for building tsim library

2021-08-22 Thread GitBox
aasorokiin commented on a change in pull request #8797: URL: https://github.com/apache/tvm/pull/8797#discussion_r693547334 ## File path: cmake/modules/VTA.cmake ## @@ -73,15 +73,30 @@ elseif(PYTHON) # Cycle accurate simulator driver build if(USE_VTA_TSIM) +if(NOT

[GitHub] [tvm] MasterJH5574 commented on a change in pull request #8767: [TensorIR][M2a] Reorder

2021-08-22 Thread GitBox
MasterJH5574 commented on a change in pull request #8767: URL: https://github.com/apache/tvm/pull/8767#discussion_r693518027 ## File path: src/tir/schedule/primitive/loop_transformation.cc ## @@ -384,6 +510,182 @@ StmtSRef Fuse(ScheduleState self, const Array& loop_srefs) {

[GitHub] [tvm] vegaluisjose commented on a change in pull request #8797: VTA cmake change to include Verilator header for building tsim library

2021-08-22 Thread GitBox
vegaluisjose commented on a change in pull request #8797: URL: https://github.com/apache/tvm/pull/8797#discussion_r693533655 ## File path: cmake/modules/VTA.cmake ## @@ -73,15 +73,30 @@ elseif(PYTHON) # Cycle accurate simulator driver build if(USE_VTA_TSIM) +if(NOT

[GitHub] [tvm] MasterJH5574 commented on a change in pull request #8767: [TensorIR][M2a] Reorder

2021-08-22 Thread GitBox
MasterJH5574 commented on a change in pull request #8767: URL: https://github.com/apache/tvm/pull/8767#discussion_r693518237 ## File path: src/tir/schedule/primitive/loop_transformation.cc ## @@ -384,6 +510,182 @@ StmtSRef Fuse(ScheduleState self, const Array& loop_srefs) {

[GitHub] [tvm] jinhongyii commented on pull request #8767: [TensorIR][M2a] Reorder

2021-08-22 Thread GitBox
jinhongyii commented on pull request #8767: URL: https://github.com/apache/tvm/pull/8767#issuecomment-903280843 @junrushao1994 I've separated the logic into several methods. You can review again -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tvm] junrushao1994 edited a comment on pull request #8767: [TensorIR][M2a] Reorder

2021-08-22 Thread GitBox
junrushao1994 edited a comment on pull request #8767: URL: https://github.com/apache/tvm/pull/8767#issuecomment-903229077 Thanks for the discussion. I would love to specifically put up a proposal on re-organizing the spaghetti code for better readability, and prove it actually practical

[GitHub] [tvm] junrushao1994 edited a comment on pull request #8767: [TensorIR][M2a] Reorder

2021-08-22 Thread GitBox
junrushao1994 edited a comment on pull request #8767: URL: https://github.com/apache/tvm/pull/8767#issuecomment-903229077 Thanks for the discussion. I would love to specifically put up a proposal on re-organizing the spaghetti code for better readability, and prove it actually practical

[GitHub] [tvm] junrushao1994 edited a comment on pull request #8767: [TensorIR][M2a] Reorder

2021-08-22 Thread GitBox
junrushao1994 edited a comment on pull request #8767: URL: https://github.com/apache/tvm/pull/8767#issuecomment-903229077 Thanks for the discussion. I would love to specifically put up a proposal on re-organizing the spaghetti code for better readability, and prove it actually practical

[GitHub] [tvm] junrushao1994 commented on pull request #8767: [TensorIR][M2a] Reorder

2021-08-22 Thread GitBox
junrushao1994 commented on pull request #8767: URL: https://github.com/apache/tvm/pull/8767#issuecomment-903229077 Thanks for the discussion. I would love to specifically put up a proposal on re-organizing the spaghetti code to better readability, and prove it actually practical in our

[GitHub] [tvm] junrushao1994 commented on a change in pull request #8767: [TensorIR][M2a] Reorder

2021-08-22 Thread GitBox
junrushao1994 commented on a change in pull request #8767: URL: https://github.com/apache/tvm/pull/8767#discussion_r693459325 ## File path: src/tir/schedule/primitive/loop_transformation.cc ## @@ -385,6 +511,122 @@ StmtSRef Fuse(ScheduleState self, const Array& loop_srefs) {

[GitHub] [tvm] jinhongyii commented on pull request #8767: [TensorIR][M2a] Reorder

2021-08-22 Thread GitBox
jinhongyii commented on pull request #8767: URL: https://github.com/apache/tvm/pull/8767#issuecomment-903221680 @junrushao1994 I've fixed the nitpicks and you can review again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [tvm] jinhongyii commented on pull request #8767: [TensorIR][M2a] Reorder

2021-08-22 Thread GitBox
jinhongyii commented on pull request #8767: URL: https://github.com/apache/tvm/pull/8767#issuecomment-903221636 there are some data structures that are used in every step of the overall algorithm, and some steps have multiple outputs, so I think extracting the steps into methods is