[GitHub] [tvm] PhilippvK commented on pull request #9256: [TFLite] Add option to overwrite OperatorConverter class in relay.frontend.from_tflite

2021-10-13 Thread GitBox
PhilippvK commented on pull request #9256: URL: https://github.com/apache/tvm/pull/9256#issuecomment-943046720 @masahi I first tried to follow the same approach as in the PyTorch frontend, just passing a dict to overwrite the convert map. However in the TFLite frontend, the `convert_*` fun

[GitHub] [tvm] zhaiyi000 commented on issue #9268: [Bug] [ios_rpc] Error happens during dlopen execution. Unimplemented

2021-10-13 Thread GitBox
zhaiyi000 commented on issue #9268: URL: https://github.com/apache/tvm/issues/9268#issuecomment-943021024 I still get an error when testing on the iOS sumulator, but it is not the same as the above error, prompting `unsupported case in deploy.dylib` ``` (py38) zy@diyideMacBook-Pro

[tvm] branch main updated (7e014a4 -> 575ac86)

2021-10-13 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 7e014a4 [ONNX] [Relay] Resize Opset 13 (#9265) add 575ac86 Skip onnx test cases if no onnx (#9272) No new revision

[GitHub] [tvm] masahi merged pull request #9272: Skip onnx test cases if no onnx

2021-10-13 Thread GitBox
masahi merged pull request #9272: URL: https://github.com/apache/tvm/pull/9272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[tvm] branch main updated (523eb12 -> 7e014a4)

2021-10-13 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 523eb12 [Pytest] Sort unit tests before running. (#9188) add 7e014a4 [ONNX] [Relay] Resize Opset 13 (#9265) No new

[GitHub] [tvm] masahi merged pull request #9265: [ONNX] [Relay] Resize Opset 13

2021-10-13 Thread GitBox
masahi merged pull request #9265: URL: https://github.com/apache/tvm/pull/9265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [tvm] masahi commented on pull request #9256: [TFLite] Add option to overwrite OperatorConverter class in relay.frontend.from_tflite

2021-10-13 Thread GitBox
masahi commented on pull request #9256: URL: https://github.com/apache/tvm/pull/9256#issuecomment-942983163 Yeah PyTorch frontend also has something similar https://github.com/apache/tvm/blob/2b57907d9ed9b6c31e368ef9b517e528dff3ae9e/python/tvm/relay/frontend/pytorch.py#L3288-L3289. I think

[tvm] branch main updated: [Pytest] Sort unit tests before running. (#9188)

2021-10-13 Thread areusch
This is an automated email from the ASF dual-hosted git repository. areusch pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 523eb12 [Pytest] Sort unit tests before running. (#91

[GitHub] [tvm] areusch merged pull request #9188: [Pytest] Sort unit tests before running.

2021-10-13 Thread GitBox
areusch merged pull request #9188: URL: https://github.com/apache/tvm/pull/9188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [tvm] areusch commented on pull request #9254: Fix USMP parallel to serial loop transform test

2021-10-13 Thread GitBox
areusch commented on pull request #9254: URL: https://github.com/apache/tvm/pull/9254#issuecomment-942934083 thanks for the quick fix @mousius -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] areusch commented on pull request #9256: [TFLite] Add option to overwrite OperatorConverter class in relay.frontend.from_tflite

2021-10-13 Thread GitBox
areusch commented on pull request #9256: URL: https://github.com/apache/tvm/pull/9256#issuecomment-942933735 @philippvk can you retrigger the CI? @jwfromm @masahi are you able to help review this PR? -- This is an automated message from the Apache Git Service. To respond to the mes

[tvm] branch main updated: [CI] Pre-build Reference System Dependencies (#9270)

2021-10-13 Thread areusch
This is an automated email from the ASF dual-hosted git repository. areusch pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 4c00264 [CI] Pre-build Reference System Dependencies

[GitHub] [tvm] areusch commented on pull request #9270: [CI] Pre-build Reference System Dependencies

2021-10-13 Thread GitBox
areusch commented on pull request #9270: URL: https://github.com/apache/tvm/pull/9270#issuecomment-942931703 thanks @mousius, the PR is now merged! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [tvm] areusch merged pull request #9270: [CI] Pre-build Reference System Dependencies

2021-10-13 Thread GitBox
areusch merged pull request #9270: URL: https://github.com/apache/tvm/pull/9270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [tvm] areusch commented on a change in pull request #9255: Fix inconsistencies in graph_executor function names handling

2021-10-13 Thread GitBox
areusch commented on a change in pull request #9255: URL: https://github.com/apache/tvm/pull/9255#discussion_r728621033 ## File path: src/runtime/crt/crt_config-template.h ## @@ -49,7 +49,10 @@ #define TVM_CRT_MAX_STRLEN_DLTYPE 10 /*! Maximum supported string length in func

[GitHub] [tvm] areusch commented on issue #8953: [Bug] [microTVM] Truncated names of fused operators exceed CRT graph executor buffer lengths

2021-10-13 Thread GitBox
areusch commented on issue #8953: URL: https://github.com/apache/tvm/issues/8953#issuecomment-942929570 @philippvk following up on the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [tvm] areusch commented on pull request #9273: Bump ci-gpu to v0.78.

2021-10-13 Thread GitBox
areusch commented on pull request #9273: URL: https://github.com/apache/tvm/pull/9273#issuecomment-942918249 https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/ci-docker-staging/165/pipeline/ -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tvm] areusch commented on pull request #9273: Bump ci-gpu to v0.78.

2021-10-13 Thread GitBox
areusch commented on pull request #9273: URL: https://github.com/apache/tvm/pull/9273#issuecomment-942918101 i think the error was due to missing PR 9227 but just rerunning once more to check -- This is an automated message from the Apache Git Service. To respond to the message, please l

[tvm] 01/01: Bump ci-gpu to v0.78.

2021-10-13 Thread areusch
This is an automated email from the ASF dual-hosted git repository. areusch pushed a commit to branch ci-docker-staging in repository https://gitbox.apache.org/repos/asf/tvm.git commit e45ccbb5126104befc425410eb490fa7771ed73f Author: Andrew Reusch AuthorDate: Wed Oct 13 07:59:38 2021 -0700

[tvm] branch ci-docker-staging updated (55aa699 -> e45ccbb)

2021-10-13 Thread areusch
This is an automated email from the ASF dual-hosted git repository. areusch pushed a change to branch ci-docker-staging in repository https://gitbox.apache.org/repos/asf/tvm.git. omit 55aa699 Bump ci-gpu to v0.78. add 76aa3c8 [UnitTest] Removed vulkan from CI run of task_python_topi.s

[GitHub] [tvm] masahi edited a comment on pull request #9261: [BYOC] CUTLASS integration

2021-10-13 Thread GitBox
masahi edited a comment on pull request #9261: URL: https://github.com/apache/tvm/pull/9261#issuecomment-942895664 I think it is reasonable to ask users for an estimate of a range of dynamism. Without such estimate, or if the estimate turns out to be off, we just fallback to a default kern

[GitHub] [tvm] masahi edited a comment on pull request #9261: [BYOC] CUTLASS integration

2021-10-13 Thread GitBox
masahi edited a comment on pull request #9261: URL: https://github.com/apache/tvm/pull/9261#issuecomment-942895664 I think it is reasonable to ask users for an estimate of a range of dynamism. Without such estimate, or if the estimate turns out to be off, we just fallback to a default kern

[GitHub] [tvm] masahi commented on pull request #9261: [BYOC] CUTLASS integration

2021-10-13 Thread GitBox
masahi commented on pull request #9261: URL: https://github.com/apache/tvm/pull/9261#issuecomment-942895664 I think it is reasonable to ask users for an estimate of a range of dynamism. Without such estimate, we just fallback to a default kernel that works on any input shapes, which should

[GitHub] [tvm] huajsj opened a new pull request #9279: [Tutorial] Fix VTA vision detection tutorial 'sphinx' style error.

2021-10-13 Thread GitBox
huajsj opened a new pull request #9279: URL: https://github.com/apache/tvm/pull/9279 Issue: Some bash code in this tutorial does not get syntax highlighting because of the format errors. Solution: Fix the 'sphinx' 'rst' style error. -- This is an automated message

[GitHub] [tvm] laolihaile commented on issue #6895: run the tutourials file failed cuda is not enable

2021-10-13 Thread GitBox
laolihaile commented on issue #6895: URL: https://github.com/apache/tvm/issues/6895#issuecomment-942882073 I have the same problem, how can I solve it?There is no corresponding solution on the https://discuss.tvm.apache.org/ -- This is an automated message from the Apache Git Service. To

[GitHub] [tvm] comaniac commented on pull request #9261: [BYOC] CUTLASS integration

2021-10-13 Thread GitBox
comaniac commented on pull request #9261: URL: https://github.com/apache/tvm/pull/9261#issuecomment-942878845 Right. Probably just need some experiments to see how many kernels should be generated to cover a range of batch sizes, and we may just hardcore the dispatching logic first to make

[GitHub] [tvm] masahi commented on pull request #9261: [BYOC] CUTLASS integration

2021-10-13 Thread GitBox
masahi commented on pull request #9261: URL: https://github.com/apache/tvm/pull/9261#issuecomment-942877261 > I agree that kernel picking should be handled by the custom runtime. It would be interesting if we can apply the same logic that AutoTIR would develop soon, since they need t

[GitHub] [tvm] zhiics commented on pull request #9261: [BYOC] CUTLASS integration

2021-10-13 Thread GitBox
zhiics commented on pull request #9261: URL: https://github.com/apache/tvm/pull/9261#issuecomment-942853797 > > At this moment, CUTLASS does not provide heuristics to choose which kernel to use based on the runtime information. The user of CUTLASS needs to make the decision to pick kernels

[GitHub] [tvm] vinx13 commented on a change in pull request #9224: [TIR] Add support for 0-dim buffer

2021-10-13 Thread GitBox
vinx13 commented on a change in pull request #9224: URL: https://github.com/apache/tvm/pull/9224#discussion_r728546565 ## File path: tests/python/unittest/test_tvmscript_ops.py ## @@ -101,5 +101,65 @@ def test_get_valid_counts_script_func(): _check_get_valid_counts_with_nu

[tvm] branch main updated (2dc58be -> b206570)

2021-10-13 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 2dc58be Bumping up CMSIS-NN version to be in sync with TFLu (#9247) add b206570 [Runtime] Pipeline Executor Second

[GitHub] [tvm] masahi merged pull request #9108: [Runtime] Pipeline Executor Second patch, configuration load and executor export/import.

2021-10-13 Thread GitBox
masahi merged pull request #9108: URL: https://github.com/apache/tvm/pull/9108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [tvm] masahi commented on pull request #9108: [Runtime] Pipeline Executor Second patch, configuration load and executor export/import.

2021-10-13 Thread GitBox
masahi commented on pull request #9108: URL: https://github.com/apache/tvm/pull/9108#issuecomment-942829812 thanks @huajsj @comaniac -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tvm] masahi commented on a change in pull request #9223: [Codegen][LLVM] Add ability to turn on fast math flags

2021-10-13 Thread GitBox
masahi commented on a change in pull request #9223: URL: https://github.com/apache/tvm/pull/9223#discussion_r728534141 ## File path: src/target/llvm/llvm_common.cc ## @@ -139,8 +152,22 @@ std::unique_ptr GetLLVMTargetMachine(const Target& target, ICHECK(allow_null) << err

[GitHub] [tvm] masahi commented on a change in pull request #9223: [Codegen][LLVM] Add ability to turn on fast math flags

2021-10-13 Thread GitBox
masahi commented on a change in pull request #9223: URL: https://github.com/apache/tvm/pull/9223#discussion_r728534141 ## File path: src/target/llvm/llvm_common.cc ## @@ -139,8 +152,22 @@ std::unique_ptr GetLLVMTargetMachine(const Target& target, ICHECK(allow_null) << err

[GitHub] [tvm] masahi commented on a change in pull request #9223: [Codegen][LLVM] Add ability to turn on fast math flags

2021-10-13 Thread GitBox
masahi commented on a change in pull request #9223: URL: https://github.com/apache/tvm/pull/9223#discussion_r728532649 ## File path: src/target/llvm/llvm_common.cc ## @@ -106,10 +106,23 @@ void ParseLLVMTargetOptions(const Target& target, std::string* triple, std::stri #if TV

[GitHub] [tvm] areusch commented on pull request #9277: Cleanup GraphExecutor parameter-passing style between Python and C++.

2021-10-13 Thread GitBox
areusch commented on pull request #9277: URL: https://github.com/apache/tvm/pull/9277#issuecomment-942773297 @tkonolige also mentioned we need to double-check if DLDevice can be sent over RPC properly. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [tvm] tkonolige commented on pull request #9275: [UnitTest][Flaky] In test_report_serialization, compare csv.

2021-10-13 Thread GitBox
tkonolige commented on pull request #9275: URL: https://github.com/apache/tvm/pull/9275#issuecomment-942773268 There's no guarantee of ordering of columns in the csv, either we need to add ordering or make the test order them. -- This is an automated message from the Apache Git Service.

[GitHub] [tvm] mbs-octoml commented on pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-10-13 Thread GitBox
mbs-octoml commented on pull request #9012: URL: https://github.com/apache/tvm/pull/9012#issuecomment-942772889 @linlifan you're quite right, sorry. https://github.com/apache/tvm/pull/9278. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [tvm] mbs-octoml opened a new pull request #9278: Update TVM_LOG_DEBUG for IR tracing.

2021-10-13 Thread GitBox
mbs-octoml opened a new pull request #9278: URL: https://github.com/apache/tvm/pull/9278 Forgot to do this when I switched to VLOG, sorry. (CORE-97) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [tvm] tkonolige commented on a change in pull request #9277: Cleanup GraphExecutor parameter-passing style between Python and C++.

2021-10-13 Thread GitBox
tkonolige commented on a change in pull request #9277: URL: https://github.com/apache/tvm/pull/9277#discussion_r728492109 ## File path: python/tvm/contrib/graph_executor.py ## @@ -98,17 +98,17 @@ def get_device(libmod, device): device_type_id = [] for cur_dev in devic

[GitHub] [tvm] mehrdadh commented on a change in pull request #9229: [TVMC] Add new micro context

2021-10-13 Thread GitBox
mehrdadh commented on a change in pull request #9229: URL: https://github.com/apache/tvm/pull/9229#discussion_r728480988 ## File path: python/tvm/driver/tvmc/common.py ## @@ -520,3 +522,84 @@ def parse_configs(input_configs): pass_context_configs[name] = parsed_value

[GitHub] [tvm] areusch opened a new pull request #9277: Cleanup GraphExecutor parameter-passing style between Python and C++.

2021-10-13 Thread GitBox
areusch opened a new pull request #9277: URL: https://github.com/apache/tvm/pull/9277 * Fix GraphExecutor factory instantiation. This PR leverages DLDevice support in PackedFunc to improve the GraphExecutor parameter-passing style between Python and c++. -- This is an automated m

[GitHub] [tvm] areusch opened a new pull request #9276: Parameterize test_link_params

2021-10-13 Thread GitBox
areusch opened a new pull request #9276: URL: https://github.com/apache/tvm/pull/9276 Cleaning up test_link_params to support the new parameterized testing. cc @Lunderberg -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #9252: [WIP] [Codegen] [CUDA] enable fast math flags

2021-10-13 Thread GitBox
AndrewZhaoLuo commented on pull request #9252: URL: https://github.com/apache/tvm/pull/9252#issuecomment-942740031 Performance is extremely bad, with pretty much every model I have having final inference regressions in the range of 60%. I'm going to close this for now, but might investigat

[GitHub] [tvm] AndrewZhaoLuo closed pull request #9252: [WIP] [Codegen] [CUDA] enable fast math flags

2021-10-13 Thread GitBox
AndrewZhaoLuo closed pull request #9252: URL: https://github.com/apache/tvm/pull/9252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [tvm] vinx13 commented on issue #9268: [Bug] [ios_rpc] Error happens during dlopen execution. Unimplemented

2021-10-13 Thread GitBox
vinx13 commented on issue #9268: URL: https://github.com/apache/tvm/issues/9268#issuecomment-942693061 cc @apeskov -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [tvm] areusch commented on pull request #9225: [Topi] Fix direct SIMD conv2d schedule name

2021-10-13 Thread GitBox
areusch commented on pull request #9225: URL: https://github.com/apache/tvm/pull/9225#issuecomment-942460738 also it's worth pointing out that we would avoid merging incremental name cleanups in the future (as this would invalidate autotuning logs), but since Cortex-M autotuning is still g

[GitHub] [tvm] areusch commented on pull request #9270: [CI] Pre-build Reference System Dependencies

2021-10-13 Thread GitBox
areusch commented on pull request #9270: URL: https://github.com/apache/tvm/pull/9270#issuecomment-942520731 @Mousius do you have an idea how much larger this makes ci-cpu? just wary of including build artifacts in our docker base images -- This is an automated message from the Apache Gi

[GitHub] [tvm] shingjan commented on pull request #9224: [WIP][TIR] Add support for 0-dim buffer

2021-10-13 Thread GitBox
shingjan commented on pull request #9224: URL: https://github.com/apache/tvm/pull/9224#issuecomment-942589018 @vinx13 With https://github.com/apache/tvm/blob/main/src/te/operation/create_primfunc.cc#L105-L109 removed, all tests under `test_te_*` passed. Should be good to merge after the c

[GitHub] [tvm] Mousius edited a comment on pull request #9270: [CI] Pre-build Reference System Dependencies

2021-10-13 Thread GitBox
Mousius edited a comment on pull request #9270: URL: https://github.com/apache/tvm/pull/9270#issuecomment-942544509 @areusch the Driver is about 364K and CMSIS NN is about 1.6MB -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [tvm] mehrdadh commented on pull request #9274: [microTVM] Add platform version check to template project

2021-10-13 Thread GitBox
mehrdadh commented on pull request #9274: URL: https://github.com/apache/tvm/pull/9274#issuecomment-942572704 cc @areusch @gromero @guberti -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [tvm] hogepodge commented on issue #9217: [Docs] Rust TVM API doc link broken

2021-10-13 Thread GitBox
hogepodge commented on issue #9217: URL: https://github.com/apache/tvm/issues/9217#issuecomment-942479259 It looks like the cargo build in the `task_python_docs.sh` script was disabled. Links to PR and issue: https://github.com/apache/tvm/pull/7743 https://github.com/apache/tvm/is

[GitHub] [tvm] areusch merged pull request #9225: [Topi] Fix direct SIMD conv2d schedule name

2021-10-13 Thread GitBox
areusch merged pull request #9225: URL: https://github.com/apache/tvm/pull/9225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [tvm] electriclilies commented on pull request #9251: [BUGFIX] Fix typo in error message in CMakeLists.txt

2021-10-13 Thread GitBox
electriclilies commented on pull request #9251: URL: https://github.com/apache/tvm/pull/9251#issuecomment-942584558 Thanks all! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [tvm] areusch commented on issue #9085: [CI Image] Update ci-cpu/gpu image

2021-10-13 Thread GitBox
areusch commented on issue #9085: URL: https://github.com/apache/tvm/issues/9085#issuecomment-942396843 ``` docker pull tlcpackstaging/ci_gpu:20210929-225912-da5b4fbfe-validated docker tag tlcpackstaging/ci_gpu:20210929-225912-da5b4fbfe-validated tlcpack/ci-gpu:v0.78 docker push tl

[GitHub] [tvm] Lunderberg opened a new pull request #9275: [UnitTest][Flaky] In test_report_serialization, compare csv.

2021-10-13 Thread GitBox
Lunderberg opened a new pull request #9275: URL: https://github.com/apache/tvm/pull/9275 `str(report)` calls `ReportNode::AsTable()`, which includes aggregate values. Otherwise negligible differences in the computed value can be rounded differently after the round trip. This was first [n

[GitHub] [tvm] areusch commented on a change in pull request #9074: Improve tvmc error message from lazy-loading frontend imports

2021-10-13 Thread GitBox
areusch commented on a change in pull request #9074: URL: https://github.com/apache/tvm/pull/9074#discussion_r728244569 ## File path: python/tvm/driver/tvmc/frontends.py ## @@ -88,10 +96,54 @@ def import_keras(): from tensorflow import keras return tf, keras

[GitHub] [tvm] CircleSpin commented on a change in pull request #9265: [ONNX] [Relay] Resize Opset 13

2021-10-13 Thread GitBox
CircleSpin commented on a change in pull request #9265: URL: https://github.com/apache/tvm/pull/9265#discussion_r728242091 ## File path: python/tvm/relay/frontend/onnx.py ## @@ -2697,6 +2697,40 @@ def _impl_v10(cls, inputs, attr, params): @classmethod def _impl_v11(

[GitHub] [tvm] mikepapadim commented on pull request #9103: [Core][Build] Move build module transformations and utilities to C++

2021-10-13 Thread GitBox
mikepapadim commented on pull request #9103: URL: https://github.com/apache/tvm/pull/9103#issuecomment-942512206 @mbs-octoml @jroesch @tqchen this can be merged now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [tvm] mbrookhart commented on pull request #9248: Propagate tvm target through graph tuning setup

2021-10-13 Thread GitBox
mbrookhart commented on pull request #9248: URL: https://github.com/apache/tvm/pull/9248#issuecomment-942446645 Thanks @rkimball @comaniac -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [tvm] areusch merged pull request #9247: Bumping up CMSIS-NN version to be in sync with TFLu

2021-10-13 Thread GitBox
areusch merged pull request #9247: URL: https://github.com/apache/tvm/pull/9247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [tvm] hwu36 commented on pull request #9261: [BYOC] CUTLASS integration

2021-10-13 Thread GitBox
hwu36 commented on pull request #9261: URL: https://github.com/apache/tvm/pull/9261#issuecomment-942558026 > I assume they also generate a run time dispatching logic (also in the generated C source code) to determine which kernel should be used given the known shape in run time. At

[GitHub] [tvm] mehrdadh commented on pull request #9225: [Topi] Fix direct SIMD conv2d schedule name

2021-10-13 Thread GitBox
mehrdadh commented on pull request #9225: URL: https://github.com/apache/tvm/pull/9225#issuecomment-942469917 @areusch I agree that we should come up with a naming system at least for microTVM at the moment if not possible for all schedules. I suggest we settle down on something before mer

[GitHub] [tvm] Mousius commented on pull request #9270: [CI] Pre-build Reference System Dependencies

2021-10-13 Thread GitBox
Mousius commented on pull request #9270: URL: https://github.com/apache/tvm/pull/9270#issuecomment-942544509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [tvm] mbrookhart merged pull request #9248: Propagate tvm target through graph tuning setup

2021-10-13 Thread GitBox
mbrookhart merged pull request #9248: URL: https://github.com/apache/tvm/pull/9248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [tvm] areusch commented on issue #9217: [Docs] Rust TVM API doc link broken

2021-10-13 Thread GitBox
areusch commented on issue #9217: URL: https://github.com/apache/tvm/issues/9217#issuecomment-942464477 cc @jroesch do you know how we generate rust docs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [tvm] AndrewZhaoLuo commented on a change in pull request #9184: [Relay, TOPI] Add searchsorted op

2021-10-13 Thread GitBox
AndrewZhaoLuo commented on a change in pull request #9184: URL: https://github.com/apache/tvm/pull/9184#discussion_r727574893 ## File path: python/tvm/topi/searchsorted.py ## @@ -0,0 +1,121 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [tvm] emijiayw commented on a change in pull request #9265: [ONNX] [Relay] Resize Opset 13

2021-10-13 Thread GitBox
emijiayw commented on a change in pull request #9265: URL: https://github.com/apache/tvm/pull/9265#discussion_r727677663 ## File path: python/tvm/relay/frontend/onnx.py ## @@ -2697,6 +2697,40 @@ def _impl_v10(cls, inputs, attr, params): @classmethod def _impl_v11(cl

[GitHub] [tvm] rkimball commented on a change in pull request #9248: Propagate tvm target through graph tuning setup

2021-10-13 Thread GitBox
rkimball commented on a change in pull request #9248: URL: https://github.com/apache/tvm/pull/9248#discussion_r727253356 ## File path: tests/python/unittest/test_autotvm_graph_tuner_utils.py ## @@ -155,6 +158,19 @@ def test_get_out_nodes(): ) +@pytest.mark.parametr

[GitHub] [tvm] huajsj commented on a change in pull request #9243: Add runtime.ModuleGetFormat method enabling export of BYOC generated sources which require a .cpp/.cc file extension

2021-10-13 Thread GitBox
huajsj commented on a change in pull request #9243: URL: https://github.com/apache/tvm/pull/9243#discussion_r727681973 ## File path: python/tvm/runtime/module.py ## @@ -185,6 +185,11 @@ def type_key(self): """Get type key of the module.""" return _ffi_api.Modu

[GitHub] [tvm] KJlaccHoeUM9l commented on pull request #9212: [iOS][RPC] Enable iOS simulation in public CI to cover basic tuning capabilities

2021-10-13 Thread GitBox
KJlaccHoeUM9l commented on pull request #9212: URL: https://github.com/apache/tvm/pull/9212#issuecomment-942272506 @areusch, @jwfromm Could you review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [tvm] shingjan commented on a change in pull request #9224: [WIP][TIR] Add support for 0-dim buffer

2021-10-13 Thread GitBox
shingjan commented on a change in pull request #9224: URL: https://github.com/apache/tvm/pull/9224#discussion_r727431386 ## File path: tests/python/unittest/test_tvmscript_complete.py ## @@ -272,10 +272,30 @@ def test_complete_match_buffer(): tvm.ir.assert_structural_equal

[GitHub] [tvm] areusch closed pull request #8892: [Lowering] Add TargetDevice composite data structure.

2021-10-13 Thread GitBox
areusch closed pull request #8892: URL: https://github.com/apache/tvm/pull/8892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [tvm] areusch commented on pull request #8892: [Lowering] Add TargetDevice composite data structure.

2021-10-13 Thread GitBox
areusch commented on pull request #8892: URL: https://github.com/apache/tvm/pull/8892#issuecomment-941525577 @mbs-octoml seems you are taking this on so i will close this PR. @jroesch can feel free to reopen if he has cycles to push it through. -- This is an automated message from the Ap

[GitHub] [tvm] comaniac commented on pull request #9261: [BYOC] CUTLASS integration

2021-10-13 Thread GitBox
comaniac commented on pull request #9261: URL: https://github.com/apache/tvm/pull/9261#issuecomment-942064270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9246: [Relay] Introduce Executor and Runtime representations with associated registries

2021-10-13 Thread GitBox
mbs-octoml commented on a change in pull request #9246: URL: https://github.com/apache/tvm/pull/9246#discussion_r727383049 ## File path: include/tvm/relay/executor.h ## @@ -0,0 +1,276 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [tvm] zhaiyi000 commented on issue #9268: [Bug] [ios_rpc] Error happens during dlopen execution. Unimplemented

2021-10-13 Thread GitBox
zhaiyi000 commented on issue #9268: URL: https://github.com/apache/tvm/issues/9268#issuecomment-942355025 I tested it on iphone7 (ios13.7) and it still has the same problem When I compiled `tvm_runtime`, I specified `DCMAKE_SYSTEM_VERSION=13.0` and `DCMAKE_OSX_DEPLOYMENT_TARGET=13.0`

[GitHub] [tvm] tmoreau89 merged pull request #9198: Hexagon conv2d full output slice

2021-10-13 Thread GitBox
tmoreau89 merged pull request #9198: URL: https://github.com/apache/tvm/pull/9198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [tvm] masahi commented on a change in pull request #9184: [Relay, TOPI] Add searchsorted op

2021-10-13 Thread GitBox
masahi commented on a change in pull request #9184: URL: https://github.com/apache/tvm/pull/9184#discussion_r727476180 ## File path: include/tvm/relay/attrs/algorithm.h ## @@ -76,6 +76,19 @@ struct TopKAttrs : public tvm::AttrsNode { } }; +struct SearchSortedAttrs : publi

[GitHub] [tvm] Lunderberg commented on pull request #9188: [Pytest] Sort unit tests before running.

2021-10-13 Thread GitBox
Lunderberg commented on pull request #9188: URL: https://github.com/apache/tvm/pull/9188#issuecomment-941162714 Rebased on main, because it looks like the CI is stalling out a bit on vulkan+topi tests that were unintentionally enabled in https://github.com/apache/tvm/pull/9093, then intent

[GitHub] [tvm] zhaiyi000 closed issue #8545: automatically terminate when I use breakpoints to debug

2021-10-13 Thread GitBox
zhaiyi000 closed issue #8545: URL: https://github.com/apache/tvm/issues/8545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@t

[GitHub] [tvm] junrushao1994 commented on a change in pull request #9261: [BYOC] CUTLASS integration

2021-10-13 Thread GitBox
junrushao1994 commented on a change in pull request #9261: URL: https://github.com/apache/tvm/pull/9261#discussion_r727471035 ## File path: .gitmodules ## @@ -13,3 +13,6 @@ [submodule "3rdparty/libbacktrace"] path = 3rdparty/libbacktrace url = https://github.co

[GitHub] [tvm] junrushao1994 commented on pull request #9263: [TE] Light refactoring of TE -> TIR paths.

2021-10-13 Thread GitBox
junrushao1994 commented on pull request #9263: URL: https://github.com/apache/tvm/pull/9263#issuecomment-941577021 CC: @Hzfengsy @comaniac -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [tvm] junrushao1994 commented on pull request #9261: [BYOC] CUTLASS integration

2021-10-13 Thread GitBox
junrushao1994 commented on pull request #9261: URL: https://github.com/apache/tvm/pull/9261#issuecomment-941462765 Really cool work @Laurawly! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] leandron commented on pull request #9218: [TVMC] Compose target options from target registry

2021-10-13 Thread GitBox
leandron commented on pull request #9218: URL: https://github.com/apache/tvm/pull/9218#issuecomment-941858425 Thanks @Mousius @areusch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [tvm-rfcs] areusch merged pull request #28: Command Line Composition from Internal Registry

2021-10-13 Thread GitBox
areusch merged pull request #28: URL: https://github.com/apache/tvm-rfcs/pull/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[GitHub] [tvm] areusch merged pull request #9159: Address review comments on Arm(R) Ethos(TM)-U PR 3/6

2021-10-13 Thread GitBox
areusch merged pull request #9159: URL: https://github.com/apache/tvm/pull/9159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [tvm] masahi commented on a change in pull request #9108: [Runtime] Pipeline Executor Second patch, configuration load and executor export/import.

2021-10-13 Thread GitBox
masahi commented on a change in pull request #9108: URL: https://github.com/apache/tvm/pull/9108#discussion_r727593939 ## File path: src/runtime/pipeline/pipeline_struct.h ## @@ -0,0 +1,185 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

[GitHub] [tvm-rfcs] areusch commented on pull request #34: Wiring up the PrimFunc resource_handle

2021-10-13 Thread GitBox
areusch commented on pull request #34: URL: https://github.com/apache/tvm-rfcs/pull/34#issuecomment-941462554 @mbs-octoml @electriclillies and I discussed this at length and we followed up with @Mousius offline as well. While it is tempting to re-use `resource_handle` to pass a `this` cont

[GitHub] [tvm] areusch commented on a change in pull request #9218: [TVMC] Compose target options from target registry

2021-10-13 Thread GitBox
areusch commented on a change in pull request #9218: URL: https://github.com/apache/tvm/pull/9218#discussion_r727372392 ## File path: python/tvm/driver/tvmc/target.py ## @@ -0,0 +1,74 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review comment: shoul

[GitHub] [tvm] areusch commented on a change in pull request #9229: [TVMC] Add new micro context

2021-10-13 Thread GitBox
areusch commented on a change in pull request #9229: URL: https://github.com/apache/tvm/pull/9229#discussion_r727495939 ## File path: apps/microtvm/zephyr/template_project/microtvm_api_server.py ## @@ -229,40 +229,69 @@ def _get_nrf_device_args(options): PROJECT_OPTIONS = [

[GitHub] [tvm] masahi edited a comment on pull request #9261: [BYOC] CUTLASS integration

2021-10-13 Thread GitBox
masahi edited a comment on pull request #9261: URL: https://github.com/apache/tvm/pull/9261#issuecomment-941990346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [tvm] zhiics commented on pull request #9261: [BYOC] CUTLASS integration

2021-10-13 Thread GitBox
zhiics commented on pull request #9261: URL: https://github.com/apache/tvm/pull/9261#issuecomment-942200090 I think even C source code should be able to handle dynamic shapes as well since it only expects tensors at the runtime, or I might forget something here. But in general, json format

[GitHub] [tvm] junrushao1994 edited a comment on pull request #7919: [RUNTIME] Improve signal handling in python env.

2021-10-13 Thread GitBox
junrushao1994 edited a comment on pull request #7919: URL: https://github.com/apache/tvm/pull/7919#issuecomment-941683513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tvm] areusch commented on pull request #7919: [RUNTIME] Improve signal handling in python env.

2021-10-13 Thread GitBox
areusch commented on pull request #7919: URL: https://github.com/apache/tvm/pull/7919#issuecomment-941674880 @junrushao1994 just curious what the motivation is behind your question? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [tvm] vinx13 merged pull request #9262: [Simplifier] Add printing of SplitExprNode and SumExprNode

2021-10-13 Thread GitBox
vinx13 merged pull request #9262: URL: https://github.com/apache/tvm/pull/9262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [tvm-rfcs] areusch commented on a change in pull request #28: Command Line Composition from Internal Registry

2021-10-13 Thread GitBox
areusch commented on a change in pull request #28: URL: https://github.com/apache/tvm-rfcs/pull/28#discussion_r727367147 ## File path: rfcs/0028-command-line-registry-composition.md ## @@ -0,0 +1,153 @@ +- Feature Name: Command Line Composition from Internal Registry +- Start D

[GitHub] [tvm] kparzysz-quic merged pull request #9220: [Hexagon] Add hexagon launcher to apps and add to TVM's build system

2021-10-13 Thread GitBox
kparzysz-quic merged pull request #9220: URL: https://github.com/apache/tvm/pull/9220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [tvm] vinx13 commented on pull request #9224: [WIP][TIR] Add support for 0-dim buffer

2021-10-13 Thread GitBox
vinx13 commented on pull request #9224: URL: https://github.com/apache/tvm/pull/9224#issuecomment-941277329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [tvm] comaniac commented on a change in pull request #9248: Propagate tvm target through graph tuning setup

2021-10-13 Thread GitBox
comaniac commented on a change in pull request #9248: URL: https://github.com/apache/tvm/pull/9248#discussion_r727311387 ## File path: python/tvm/autotvm/graph_tuner/utils/traverse_graph.py ## @@ -50,6 +51,8 @@ def expr2graph(expr, target_ops, node_dict, node_list): Ea

  1   2   >