Lunderberg opened a new pull request, #16836:
URL: https://github.com/apache/tvm/pull/16836
Prior to this commit, the `LLVMModuleNode` provided a `"get_func_names"`
function that would return the names of functions available within the result
of `tvm.build`. However, this utility was not p
tqchen merged PR #16831:
URL: https://github.com/apache/tvm/pull/16831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.or
This is an automated email from the ASF dual-hosted git repository.
tqchen pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git
The following commit(s) were added to refs/heads/main by this push:
new 9862c84b9f [KVCache] Reducing CacheAuxDataManager copy
tqchen commented on PR #16836:
URL: https://github.com/apache/tvm/pull/16836#issuecomment-2034631258
seems this behavior was platform dependent, and ideally we should not
introduce behavior that only works on one platform but not others. Keep the
minimal necessary functionalities is preferr
tqchen merged PR #16834:
URL: https://github.com/apache/tvm/pull/16834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.or
This is an automated email from the ASF dual-hosted git repository.
tqchen pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git
from 9862c84b9f [KVCache] Reducing CacheAuxDataManager copy size (#16831)
add 54e31f374c [Relax] Capture symbolic vars in s
tqchen commented on code in PR #16836:
URL: https://github.com/apache/tvm/pull/16836#discussion_r1549772008
##
src/runtime/dso_library.cc:
##
@@ -136,6 +166,50 @@ void DSOLibrary::Load(const std::string& name) {
void* DSOLibrary::GetSymbol_(const char* name) { return dlsym(li
Lunderberg commented on code in PR #16836:
URL: https://github.com/apache/tvm/pull/16836#discussion_r1549875868
##
src/runtime/dso_library.cc:
##
@@ -136,6 +166,50 @@ void DSOLibrary::Load(const std::string& name) {
void* DSOLibrary::GetSymbol_(const char* name) { return dlsy
Lunderberg commented on PR #16836:
URL: https://github.com/apache/tvm/pull/16836#issuecomment-2034810132
> seems this behavior was platform dependent, and ideally we should not
introduce behavior that only works on one platform but not others.
My goal was partly to avoid needing to al
Lunderberg commented on PR #16836:
URL: https://github.com/apache/tvm/pull/16836#issuecomment-2034815247
As an alternative implementation for the same end-user functionality, what
would you think about a lowering pass that is applied just before
`tir.transform.MakePackedAPI()`? That could
Lunderberg commented on PR #16833:
URL: https://github.com/apache/tvm/pull/16833#issuecomment-2034835923
Thank you!
CI has found a surprising number of failures for this check. It looks like
the new check requiring the same `GlobalVar` and `Function` struct info has
caught an issue
tqchen commented on PR #16836:
URL: https://github.com/apache/tvm/pull/16836#issuecomment-2034865933
the only main issue about generate approach is that it may not be
comprehensive if we in the end link multiple exports together, which is a less
frequent usecase as in static library case(wh
This is an automated email from the ASF dual-hosted git repository.
lunderberg pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git
The following commit(s) were added to refs/heads/main by this push:
new 35c614303a [TVMScript] Do not throw error for dupli
Lunderberg merged PR #16811:
URL: https://github.com/apache/tvm/pull/16811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apach
Lunderberg merged PR #16801:
URL: https://github.com/apache/tvm/pull/16801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apach
This is an automated email from the ASF dual-hosted git repository.
lunderberg pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git
The following commit(s) were added to refs/heads/main by this push:
new 545e0977e3 [Relax] Allow DeadCodeElimination within
Lunderberg commented on PR #16832:
URL: https://github.com/apache/tvm/pull/16832#issuecomment-2034950915
CI failure is for
`tests/python/relay/test_auto_scheduler_tuning.py::test_tuning_cuda`. It looks
like a flaky test, which occurs whenever the randomized tuning fails to find
any valid
Lunderberg opened a new pull request, #16837:
URL: https://github.com/apache/tvm/pull/16837
The `test_auto_scheduler_tuning.py::test_tuning_cuda` unit test has sporadic
failures on unrelated changes. Seems to be triggered when tuning does not find
any valid candidates, and so the "best" ca
Lunderberg commented on PR #16836:
URL: https://github.com/apache/tvm/pull/16836#issuecomment-2034997679
> the only main issue about generate approach is that it may not be
comprehensive if we in the end link multiple exports together, which is a less
frequent usecase as in static library c
dependabot[bot] opened a new pull request, #16838:
URL: https://github.com/apache/tvm/pull/16838
Bumps [pillow](https://github.com/python-pillow/Pillow) from 10.2.0 to
10.3.0.
Release notes
Sourced from https://github.com/python-pillow/Pillow/releases";>pillow's
releases.
1
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/pip/apps/microtvm/ethosu/pillow-10.3.0
in repository https://gitbox.apache.org/repos/asf/tvm.git
at 61558f1e91 Bump pillow from 10.2.0 to 10.3.0 in /apps/microtvm/ethosu
No
Lunderberg commented on code in PR #16826:
URL: https://github.com/apache/tvm/pull/16826#discussion_r1550061085
##
src/relax/op/tensor/index.cc:
##
@@ -102,117 +107,326 @@ TVM_REGISTER_OP("relax.take")
/* relax.strided_slice */
TVM_REGISTER_NODE_TYPE(StridedSliceAttrs);
-Exp
dependabot[bot] opened a new pull request, #16839:
URL: https://github.com/apache/tvm/pull/16839
Bumps [pillow](https://github.com/python-pillow/Pillow) from 10.2.0 to
10.3.0.
Release notes
Sourced from https://github.com/python-pillow/Pillow/releases";>pillow's
releases.
1
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/pip/apps/microtvm/cmsisnn/pillow-10.3.0
in repository https://gitbox.apache.org/repos/asf/tvm.git
at 78f4bc6434 Bump pillow from 10.2.0 to 10.3.0 in /apps/microtvm/cmsisnn
Lunderberg commented on PR #16826:
URL: https://github.com/apache/tvm/pull/16826#issuecomment-2035046706
@Archermmt Can you look into the failing MSC unit tests? It seems that it
is a limitation in the Relax to MSC conversion, that it doesn't correctly
handle in-line leaf nodes that occur
Lunderberg merged PR #16798:
URL: https://github.com/apache/tvm/pull/16798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apach
Lunderberg commented on PR #16798:
URL: https://github.com/apache/tvm/pull/16798#issuecomment-2035050912
Thank you, and good point on the end-to-end examples. I'm planning to
upstream a use case, where the callback would load data from a `.safetensors`
file, and that would be a good place
This is an automated email from the ASF dual-hosted git repository.
lunderberg pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git
The following commit(s) were added to refs/heads/main by this push:
new 61249b41ce [Relax][Transform] Provide callback vers
dependabot[bot] opened a new pull request, #16840:
URL: https://github.com/apache/tvm/pull/16840
Bumps [pillow](https://github.com/python-pillow/Pillow) from 10.2.0 to
10.3.0.
Release notes
Sourced from https://github.com/python-pillow/Pillow/releases";>pillow's
releases.
1
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/pip/apps/microtvm/pillow-10.3.0
in repository https://gitbox.apache.org/repos/asf/tvm.git
at c0de939622 Bump pillow from 10.2.0 to 10.3.0 in /apps/microtvm
No new revisions
Lunderberg opened a new pull request, #16841:
URL: https://github.com/apache/tvm/pull/16841
Prior to this commit, symbolic variables inferred from the parameters were
retained in the output function's `ret_struct_info`. This is ill-formed, as
the parameters from which these symbolic variab
Lunderberg commented on PR #16841:
URL: https://github.com/apache/tvm/pull/16841#issuecomment-2035180020
@slyubomirsky This is the follow-up to
https://github.com/apache/tvm/pull/16798, which I ended up making much sooner
than I had initially planned.
--
This is an automated message from
csullivan opened a new pull request, #16842:
URL: https://github.com/apache/tvm/pull/16842
* Use CCL type traits to share common code between NCCL and MSCCLPP API
invocations in disco
* Add bench to validate results and compare various supported CCL approaches
for cuda.
Aggregate
Lunderberg opened a new pull request, #16843:
URL: https://github.com/apache/tvm/pull/16843
Prior to this commit, `ApplyPassToFunction` removed functions from the
`IRModule` to hide them from the inner `ir.transform.Pass`. The dangling
`GlobalVar` references to those functions meant that t
Lunderberg commented on PR #16843:
URL: https://github.com/apache/tvm/pull/16843#issuecomment-2035187347
A follow-up commit to https://github.com/apache/tvm/pull/16801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
Lunderberg opened a new pull request, #16844:
URL: https://github.com/apache/tvm/pull/16844
A follow-up to https://github.com/apache/tvm/pull/16745. For Relax
functions produced in TVMScript, when `R.func_attrs` was not present, the
default was set to `None` instead of an empty dictionary.
Lunderberg opened a new pull request, #16845:
URL: https://github.com/apache/tvm/pull/16845
Prior to this commit, attempting to execute the result of
`sess.get_global_func` for a non-existing function name would result in a
segfault. While the equivalent `tvm.get_global_func` can throw an
CharlieFRuan commented on PR #16733:
URL: https://github.com/apache/tvm/pull/16733#issuecomment-2035221626
Thank you for the updates! I will review soon today/tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
Lunderberg commented on PR #16457:
URL: https://github.com/apache/tvm/pull/16457#issuecomment-2035371634
With https://github.com/apache/tvm/pull/16642 landed, the functionality in
this PR can now be compiled, and run. Thank you to @csullivan for adding an
`IRModule` transform, so the dynam
tqchen commented on code in PR #16827:
URL: https://github.com/apache/tvm/pull/16827#discussion_r1550301871
##
tests/python/relax/test_op_binary.py:
##
@@ -184,10 +250,10 @@ def
test_binary_infer_struct_info_shape_var(binary_arith_op: Callable):
y4 = relax.Var("y", relax.T
slyubomirsky commented on PR #16844:
URL: https://github.com/apache/tvm/pull/16844#issuecomment-2035582213
What is the specific reason to have this change? It might be a good
invariant to have, just wondering if there was a specific motivation for it.
--
This is an automated message from
slyubomirsky commented on PR #16843:
URL: https://github.com/apache/tvm/pull/16843#issuecomment-2036001152
Are the substituted global vars restored afterwards? I couldn't find a place
where they were put back. I would be worried about these extern funcs ending up
in the final module.
--
Lunderberg merged PR #16841:
URL: https://github.com/apache/tvm/pull/16841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tvm.apach
This is an automated email from the ASF dual-hosted git repository.
lunderberg pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git
The following commit(s) were added to refs/heads/main by this push:
new 6f74762743 [Relax] Provide well-formed output in
`
Lunderberg commented on PR #16841:
URL: https://github.com/apache/tvm/pull/16841#issuecomment-2036048858
> Good catch; I didn't realize that we were losing shape vars from the
signature
Thank you. This ended up resulting from some debugging I did with
`tvm.relax.ir.instrument.WellFo
Lunderberg commented on PR #16844:
URL: https://github.com/apache/tvm/pull/16844#issuecomment-2036062916
Overall, to remove a repeated source of bugs. Since most functions are
publicly exposed, they'll have at least the `"global_symbol"` attribute.
Frequently, utilities would be written t
Lunderberg commented on PR #16843:
URL: https://github.com/apache/tvm/pull/16843#issuecomment-2036068681
The `GlobalVar` instances themselves don't need to be changed, only the
functions to which they point. This is why the pre-transform steps don't need
to modify any function bodies, beca
Lunderberg commented on PR #16843:
URL: https://github.com/apache/tvm/pull/16843#issuecomment-2036071794
The CI failure here will be resolved with
https://github.com/apache/tvm/pull/16843.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
Lunderberg commented on code in PR #16827:
URL: https://github.com/apache/tvm/pull/16827#discussion_r1550803183
##
tests/python/relax/test_op_binary.py:
##
@@ -184,10 +250,10 @@ def
test_binary_infer_struct_info_shape_var(binary_arith_op: Callable):
y4 = relax.Var("y", rel
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch nightly
in repository https://gitbox.apache.org/repos/asf/tvm.git
from ef80af65dd [Web] Support building tvm/web on Windows (#16810)
add 9862c84b9f [KVCache] Reducing CacheAuxDataMan
50 matches
Mail list logo
