[PR] [TIR] Fix Bug in VectorizeLoop [tvm]

2024-05-28 Thread via GitHub
CharlieFRuan opened a new pull request, #17039: URL: https://github.com/apache/tvm/pull/17039 This PR fixes a bug in vectorize loop introduced related to https://github.com/apache/tvm/pull/16966 The visit to condition can write need scalarize to true then the followup visit to then c

(tvm) branch nightly updated (b598f28a1c -> c9d87ef54f)

2024-05-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch nightly in repository https://gitbox.apache.org/repos/asf/tvm.git from b598f28a1c [Contrib] Implement NDArray cache update (#17029) add 20d8c53731 [SVE] Add support for representing

Re: [PR] [SVE] Add support for representing and creating buffer-level predicates [tvm]

2024-05-28 Thread via GitHub
tqchen commented on code in PR #16966: URL: https://github.com/apache/tvm/pull/16966#discussion_r1618046951 ## tests/python/codegen/test_target_codegen_aarch64.py: ## @@ -780,5 +780,31 @@ def before(a: T.handle): assert "get.active.lane.mask" in ll +@pytest.mark.skipif(

Re: [PR] [SVE] Add support for representing and creating buffer-level predicates [tvm]

2024-05-28 Thread via GitHub
tqchen commented on code in PR #16966: URL: https://github.com/apache/tvm/pull/16966#discussion_r1618046951 ## tests/python/codegen/test_target_codegen_aarch64.py: ## @@ -780,5 +780,31 @@ def before(a: T.handle): assert "get.active.lane.mask" in ll +@pytest.mark.skipif(

(tvm) branch main updated: [Relax][Bugfix] Annotate ComputePrimValue output as host function (#17032)

2024-05-28 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new c9d87ef54f [Relax][Bugfix] Annotate ComputePrimValue ou

Re: [PR] [Relax][Bugfix] Annotate ComputePrimValue output as host function [tvm]

2024-05-28 Thread via GitHub
tqchen merged PR #17032: URL: https://github.com/apache/tvm/pull/17032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.or

Re: [PR] [SME][TOPI] Add conv2d NHWC SME fp32 schedule [tvm]

2024-05-28 Thread via GitHub
tqchen commented on PR #17003: URL: https://github.com/apache/tvm/pull/17003#issuecomment-2136289066 Thanks @Anndrey24 @lhutton1 @ekalda . I created a temp revert, https://github.com/apache/tvm/pull/17038 to unblock the ci, if there is an alternative fix that would also be good, eit

Re: [PR] Revert "[SME][TOPI] Add conv2d NHWC SME fp32 schedule (#17003)" [tvm]

2024-05-28 Thread via GitHub
tqchen commented on PR #17038: URL: https://github.com/apache/tvm/pull/17038#issuecomment-2136287195 This is a temp revert to unblock the ci, can be superseded by other changes, another redo PR can be followed up hopefully to fix the issue. -- This is an automated message from the Apache

[PR] Revert "[SME][TOPI] Add conv2d NHWC SME fp32 schedule (#17003)" [tvm]

2024-05-28 Thread via GitHub
tqchen opened a new pull request, #17038: URL: https://github.com/apache/tvm/pull/17038 This reverts commit cab54e0dee82f84d94cd65f8fe0432ee1c2f2e22. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

(tvm) 01/01: Revert "[SME][TOPI] Add conv2d NHWC SME fp32 schedule (#17003)"

2024-05-28 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch revert-17003-sme-conv2d-fp32 in repository https://gitbox.apache.org/repos/asf/tvm.git commit b71a9a3827d81ac17da5f5bc608583f1a02bd0d8 Author: Tianqi Chen AuthorDate: Tue May 28 19:56:33 2024 -04

(tvm) branch revert-17003-sme-conv2d-fp32 created (now b71a9a3827)

2024-05-28 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch revert-17003-sme-conv2d-fp32 in repository https://gitbox.apache.org/repos/asf/tvm.git at b71a9a3827 Revert "[SME][TOPI] Add conv2d NHWC SME fp32 schedule (#17003)" This branch includes t

Re: [PR] [SME][TOPI] Add conv2d NHWC SME fp32 schedule [tvm]

2024-05-28 Thread via GitHub
tqchen commented on PR #17003: URL: https://github.com/apache/tvm/pull/17003#issuecomment-2136283203 Seems we have a breakage/flaky likely due to this PR https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-arm/detail/main/1980/pipeline -- This is an automated message from the Apache Git

(tvm) branch main updated: [Relax][Bugfix] Bind symbolic variables in R.match_cast (#17034)

2024-05-28 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new b2c61162f0 [Relax][Bugfix] Bind symbolic variables in R

Re: [PR] [Relax][Bugfix] Bind symbolic variables in R.match_cast [tvm]

2024-05-28 Thread via GitHub
tqchen merged PR #17034: URL: https://github.com/apache/tvm/pull/17034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.or

[PR] [Runtime][ROCm] Enable ROCm host memory support [tvm]

2024-05-28 Thread via GitHub
MasterJH5574 opened a new pull request, #17037: URL: https://github.com/apache/tvm/pull/17037 This PR enables the ROCMHost memory support in ROCm device API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[PR] [Runtime] Use preferred host memory (pinned memory) in KV cache [tvm]

2024-05-28 Thread via GitHub
MasterJH5574 opened a new pull request, #17036: URL: https://github.com/apache/tvm/pull/17036 This PR updates the PagedKVCache with the pinned memory support, which can reduce the copy overhead between CPU and GPU. This PR also bumps FlashInfer version, which now supports * specify

Re: [PR] [Web] Fix string to uint8 array for special characters [tvm]

2024-05-28 Thread via GitHub
tqchen merged PR #17031: URL: https://github.com/apache/tvm/pull/17031 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.or

(tvm) branch main updated: [Web] Fix string to uint8 array for special characters (#17031)

2024-05-28 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new d4b096f905 [Web] Fix string to uint8 array for special

Re: [PR] [SME][TOPI] Add conv2d NHWC SME fp32 schedule [tvm]

2024-05-28 Thread via GitHub
ekalda commented on PR #17003: URL: https://github.com/apache/tvm/pull/17003#issuecomment-2135675436 Thanks @Anndrey24 and @lhutton1, this is now merged! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [SME][TOPI] Add conv2d NHWC SME fp32 schedule [tvm]

2024-05-28 Thread via GitHub
ekalda merged PR #17003: URL: https://github.com/apache/tvm/pull/17003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.or

(tvm) branch main updated: [SME][TOPI] Add conv2d NHWC SME fp32 schedule (#17003)

2024-05-28 Thread ekalda
This is an automated email from the ASF dual-hosted git repository. ekalda pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new cab54e0dee [SME][TOPI] Add conv2d NHWC SME fp32 schedul

Re: [PR] [SME][TOPI] Add conv2d NHWC SME fp32 schedule [tvm]

2024-05-28 Thread via GitHub
Anndrey24 commented on PR #17003: URL: https://github.com/apache/tvm/pull/17003#issuecomment-2135473130 Resolved the conflict! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [SME] Add scalable fp16->fp32 dense schedule [tvm]

2024-05-28 Thread via GitHub
ekalda commented on PR #16981: URL: https://github.com/apache/tvm/pull/16981#issuecomment-2135439026 Thanks @lhutton1 this is merged now! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

(tvm) branch main updated (20d8c53731 -> 430e02fdcd)

2024-05-28 Thread ekalda
This is an automated email from the ASF dual-hosted git repository. ekalda pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git from 20d8c53731 [SVE] Add support for representing and creating buffer-level predicates (#16966) add 430e02fdcd [SME] Add

Re: [PR] [SME] Add scalable fp16->fp32 dense schedule [tvm]

2024-05-28 Thread via GitHub
ekalda merged PR #16981: URL: https://github.com/apache/tvm/pull/16981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.or

Re: [PR] [Disco][QoL] Implement broadcast/scatter methods for Session [tvm]

2024-05-28 Thread via GitHub
Lunderberg commented on PR #17035: URL: https://github.com/apache/tvm/pull/17035#issuecomment-2135273815 This PR is identical to the now-closed PR https://github.com/apache/tvm/pull/17011, as a CI restart prevented the CI from running on the original PR. -- This is an automated message f

[PR] [Disco][QoL] Implement broadcast/scatter methods for Session [tvm]

2024-05-28 Thread via GitHub
Lunderberg opened a new pull request, #17035: URL: https://github.com/apache/tvm/pull/17035 Prior to this commit, use of the `disco.Session` API to broadcast or scatter an array required several steps from the caller. 1. Allocate memory on worker0 2. Transfer data from the controll

Re: [PR] [Disco][QoL] Implement broadcast/scatter methods for Session [tvm]

2024-05-28 Thread via GitHub
Lunderberg closed pull request #17011: [Disco][QoL] Implement broadcast/scatter methods for Session URL: https://github.com/apache/tvm/pull/17011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [Disco][QoL] Implement broadcast/scatter methods for Session [tvm]

2024-05-28 Thread via GitHub
Lunderberg commented on PR #17011: URL: https://github.com/apache/tvm/pull/17011#issuecomment-2135272878 Closing to resubmit as a new PR (same issue as mentioned [here](https://github.com/apache/tvm/pull/17024#issuecomment-2132387858)), due to CI issues. -- This is an automated message f

Re: [PR] [Relax][Bugfix] Apply FuseOps to nested DataflowBlock [tvm]

2024-05-28 Thread via GitHub
Lunderberg commented on code in PR #17033: URL: https://github.com/apache/tvm/pull/17033#discussion_r1617284952 ## src/relax/transform/fuse_ops.cc: ## @@ -262,16 +262,11 @@ class GraphCreator : public ExprVisitor { IndexedForwardGraph::Node* leaf_node = nullptr; if (it

Re: [PR] [Relax][Bugfix] Apply FuseOps to nested DataflowBlock [tvm]

2024-05-28 Thread via GitHub
Lunderberg commented on code in PR #17033: URL: https://github.com/apache/tvm/pull/17033#discussion_r1617278146 ## src/relax/transform/fuse_ops.cc: ## @@ -262,16 +262,11 @@ class GraphCreator : public ExprVisitor { IndexedForwardGraph::Node* leaf_node = nullptr; if (it

Re: [PR] [Relax][Bugfix] Bind symbolic variables in R.match_cast [tvm]

2024-05-28 Thread via GitHub
Lunderberg commented on PR #17034: URL: https://github.com/apache/tvm/pull/17034#issuecomment-2135234857 This PR is identical to the now-closed PR https://github.com/apache/tvm/pull/17023, as a CI restart prevented the CI from running on the original PR. -- This is an automated message f

[PR] [Relax][Bugfix] Bind symbolic variables in R.match_cast [tvm]

2024-05-28 Thread via GitHub
Lunderberg opened a new pull request, #17034: URL: https://github.com/apache/tvm/pull/17034 Prior to this commit, variable replacement by `BindSymbolicVars` would fail to replace variables that occur within a `relax::MatchCast` node. This pattern is rare, because the `bind_symbolic_vars` me

Re: [PR] [Relax][Bugfix] Bind symbolic variables in R.match_cast [tvm]

2024-05-28 Thread via GitHub
Lunderberg commented on PR #17023: URL: https://github.com/apache/tvm/pull/17023#issuecomment-2135233602 Closing to resubmit as a new PR (same issue as mentioned [here](https://github.com/apache/tvm/pull/17024#issuecomment-2132387858)), due to CI issues. -- This is an automated message f

Re: [PR] [Relax][Bugfix] Bind symbolic variables in R.match_cast [tvm]

2024-05-28 Thread via GitHub
Lunderberg closed pull request #17023: [Relax][Bugfix] Bind symbolic variables in R.match_cast URL: https://github.com/apache/tvm/pull/17023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [Relax][Bugfix] Apply FuseOps to nested DataflowBlock [tvm]

2024-05-28 Thread via GitHub
Lunderberg commented on PR #17033: URL: https://github.com/apache/tvm/pull/17033#issuecomment-2135232856 This PR is identical to the now-closed PR https://github.com/apache/tvm/pull/17022, as a CI restart prevented the CI from running on the original PR. -- This is an automated message f

Re: [PR] [Relax][Bugfix] Apply FuseOps to nested DataflowBlock [tvm]

2024-05-28 Thread via GitHub
Lunderberg closed pull request #17022: [Relax][Bugfix] Apply FuseOps to nested DataflowBlock URL: https://github.com/apache/tvm/pull/17022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [Relax][Bugfix] Annotate ComputePrimValue output as host function [tvm]

2024-05-28 Thread via GitHub
Lunderberg commented on PR #17032: URL: https://github.com/apache/tvm/pull/17032#issuecomment-2135228380 This PR is identical to the now-closed PR https://github.com/apache/tvm/pull/17024, as a CI restart prevented the CI from running on the original PR. -- This is an automated message f

[PR] [Relax][Bugfix] Annotate ComputePrimValue output as host function [tvm]

2024-05-28 Thread via GitHub
Lunderberg opened a new pull request, #17032: URL: https://github.com/apache/tvm/pull/17032 The `ComputePrimValue` transform is used to compute the value of symbolic expressions that may appear within a Relax function. For example, to compute a boolean condition used for a `relax::If` node

Re: [PR] [Relax][Bugfix] Annotate ComputePrimValue output as host function [tvm]

2024-05-28 Thread via GitHub
Lunderberg closed pull request #17024: [Relax][Bugfix] Annotate ComputePrimValue output as host function URL: https://github.com/apache/tvm/pull/17024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [Runtime] Compatibility with dmlc::Stream API changes [tvm]

2024-05-28 Thread via GitHub
tqchen commented on PR #16998: URL: https://github.com/apache/tvm/pull/16998#issuecomment-2135212528 @tvm-bot rerun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [Relax][Bugfix] Annotate ComputePrimValue output as host function [tvm]

2024-05-28 Thread via GitHub
Lunderberg commented on PR #17024: URL: https://github.com/apache/tvm/pull/17024#issuecomment-2135179100 Thank you for looking into the CI failures, and I'll resubmit as a new PR. Looks like #17022 and #17023 have the similar CI failure, as they were all submitted while the CI was down.

Re: [PR] [BugFix][MSC] split name_string with index by colon from the right [tvm]

2024-05-28 Thread via GitHub
psunn commented on PR #17000: URL: https://github.com/apache/tvm/pull/17000#issuecomment-2135112463 @Archermmt thanks for review. Yes, the change in this PR has no effect on existing tests. An additional test case has been added to cover node name_string with an index by colon. I f

[PR] [Web] Fix string to uint8 array for special characters [tvm]

2024-05-28 Thread via GitHub
CharlieFRuan opened a new pull request, #17031: URL: https://github.com/apache/tvm/pull/17031 This PR fixes passing Javascript string with special characters to C for web runtime. Take the upside-down exclamation mark `ยก` as an example. This should encode to `\xC2\xA1` according to h

(tvm) branch main updated: [SVE] Add support for representing and creating buffer-level predicates (#16966)

2024-05-28 Thread leandron
This is an automated email from the ASF dual-hosted git repository. leandron pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 20d8c53731 [SVE] Add support for representing and cre

Re: [PR] [SVE] Add support for representing and creating buffer-level predicates [tvm]

2024-05-28 Thread via GitHub
leandron merged PR #16966: URL: https://github.com/apache/tvm/pull/16966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.