[GitHub] [incubator-tvm] comaniac commented on pull request #6655: [BYOC] Added default_tuples parameter to AnnotateTarget pass

2020-10-13 Thread GitBox
comaniac commented on pull request #6655: URL: https://github.com/apache/incubator-tvm/pull/6655#issuecomment-707867942 This solution looks too ad hoc to me. From the semantic of the changes, I think this PR can be generalized to "improve the annotate target pass to annotate non-call ops

[GitHub] [incubator-tvm] comaniac commented on pull request #6655: [BYOC] Added default_tuples parameter to AnnotateTarget pass

2020-10-09 Thread GitBox
comaniac commented on pull request #6655: URL: https://github.com/apache/incubator-tvm/pull/6655#issuecomment-706369034 Thanks for the PR. I have a hard deadline this weekend and will review it after next Tuesday. This is