[GitHub] [incubator-tvm] masahi edited a comment on pull request #5689: [PatternLang] Add ConstantPattern

2020-05-28 Thread GitBox
masahi edited a comment on pull request #5689: URL: https://github.com/apache/incubator-tvm/pull/5689#issuecomment-635644901 I might be missing something, but I expect constants to be available to external codegen at compile time. Otherwise we cannot do constant folding. Sorry I didn't

[GitHub] [incubator-tvm] masahi edited a comment on pull request #5689: [PatternLang] Add ConstantPattern

2020-05-28 Thread GitBox
masahi edited a comment on pull request #5689: URL: https://github.com/apache/incubator-tvm/pull/5689#issuecomment-635644901 I expect constants to be available to external codegen at compile time. Otherwise we cannot do constant folding. @comaniac Under the current implementation of

[GitHub] [incubator-tvm] masahi edited a comment on pull request #5689: [PatternLang] Add ConstantPattern

2020-05-28 Thread GitBox
masahi edited a comment on pull request #5689: URL: https://github.com/apache/incubator-tvm/pull/5689#issuecomment-635644901 I expect constants to be available to external codegen at compile time. Otherwise we cannot do constant folding. @comaniac Under the current implementation of

[GitHub] [incubator-tvm] masahi edited a comment on pull request #5689: [PatternLang] Add ConstantPattern

2020-05-28 Thread GitBox
masahi edited a comment on pull request #5689: URL: https://github.com/apache/incubator-tvm/pull/5689#issuecomment-635644901 I expect constants to be available to external codegen at compile time. Otherwise we cannot do constant folding. @comaniac Under the current implementation of

[GitHub] [incubator-tvm] masahi edited a comment on pull request #5689: [PatternLang] Add ConstantPattern

2020-05-28 Thread GitBox
masahi edited a comment on pull request #5689: URL: https://github.com/apache/incubator-tvm/pull/5689#issuecomment-635644901 I expect constants to be available to external codegen at compile time. Otherwise we cannot do constant folding. @comaniac Under the current constant impl of