[GitHub] [incubator-tvm] masahi edited a comment on pull request #6449: [Frontend][Pytorch] Improve Pytorch frontend for object detection models

2020-09-15 Thread GitBox
masahi edited a comment on pull request #6449: URL: https://github.com/apache/incubator-tvm/pull/6449#issuecomment-693013272 @kevinthesun Although having a wrapper api doesn't make the code shorter, I do believe there is a value in isolating such "toxic" programming idiom into one place (e

[GitHub] [incubator-tvm] masahi edited a comment on pull request #6449: [Frontend][Pytorch] Improve Pytorch frontend for object detection models

2020-09-14 Thread GitBox
masahi edited a comment on pull request #6449: URL: https://github.com/apache/incubator-tvm/pull/6449#issuecomment-692441507 @kevinthesun Thanks I'm trying running e2e on my end. I have following questions: 1. How long does it take to compile faster or mask rcnn from torchvision? I

[GitHub] [incubator-tvm] masahi edited a comment on pull request #6449: [Frontend][Pytorch] Improve Pytorch frontend for object detection models

2020-09-14 Thread GitBox
masahi edited a comment on pull request #6449: URL: https://github.com/apache/incubator-tvm/pull/6449#issuecomment-692441507 @kevinthesun Thanks I'm trying running e2e on my end. I have following questions: 1. How long does it take to compile faster or mask rcnn from torchvision? I

[GitHub] [incubator-tvm] masahi edited a comment on pull request #6449: [Frontend][Pytorch] Improve Pytorch frontend for object detection models

2020-09-14 Thread GitBox
masahi edited a comment on pull request #6449: URL: https://github.com/apache/incubator-tvm/pull/6449#issuecomment-692441507 @kevinthesun Thanks I'm trying running e2e on my end. How long does it take to compile faster or mask rcnn from torchvision? I remember hearing TF faster rcnn taking

[GitHub] [incubator-tvm] masahi edited a comment on pull request #6449: [Frontend][Pytorch] Improve Pytorch frontend for object detection models

2020-09-12 Thread GitBox
masahi edited a comment on pull request #6449: URL: https://github.com/apache/incubator-tvm/pull/6449#issuecomment-690855865 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-tvm] masahi edited a comment on pull request #6449: [Frontend][Pytorch] Improve Pytorch frontend for object detection models

2020-09-12 Thread GitBox
masahi edited a comment on pull request #6449: URL: https://github.com/apache/incubator-tvm/pull/6449#issuecomment-690855865 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-tvm] masahi edited a comment on pull request #6449: [Frontend][Pytorch] Improve Pytorch frontend for object detection models

2020-09-12 Thread GitBox
masahi edited a comment on pull request #6449: URL: https://github.com/apache/incubator-tvm/pull/6449#issuecomment-690855865 @kevinthesun Thanks for working on this. Can you split this into multiple PRs? In particular, besides the new op conversion, you made many non trivial changes to exi

[GitHub] [incubator-tvm] masahi edited a comment on pull request #6449: [Frontend][Pytorch] Improve Pytorch frontend for object detection models

2020-09-10 Thread GitBox
masahi edited a comment on pull request #6449: URL: https://github.com/apache/incubator-tvm/pull/6449#issuecomment-690855865 @kevinthesun Thanks for working on this. Can you split this into multiple PRs? In particular, besides the new op conversion, you made many non trivial changes to exi