masahi edited a comment on pull request #6449: URL: https://github.com/apache/incubator-tvm/pull/6449#issuecomment-693013272
@kevinthesun Although having a wrapper api doesn't make the code shorter, I do believe there is a value in isolating such "toxic" programming idiom into one place (e.g. it makes updating easier). I can imagine a wrapper that takes a "success handler" and "failure handler" (both lambda functions). That said, I agree that we can proceed with this code as it is, given that this idiom is (unfortunately) already common in other frontends and such low level detail is not the point of this PR. I can give a try at this issue later, since I want to keep PyTorch frontend clean. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
