[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6692: Refactor diagnostic to avoid circular dependencies

tqchen edited a comment on pull request #6692: URL: https://github.com/apache/incubator-tvm/pull/6692#issuecomment-710126019 Thanks @rkimball . I feel the PR can still be simplified further to avoid potential confusion of two diagnostic header files(one minimum and another built for IR). I

[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6692: Refactor diagnostic to avoid circular dependencies

tqchen edited a comment on pull request #6692: URL: https://github.com/apache/incubator-tvm/pull/6692#issuecomment-709642068 In this particular case, ICHECK perhaps should not end up in ir/diagnostic, but instead in `support/logging.h`, moving the marco defs there would be the simplest sol