[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-25 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r955507870 ## tests/cpp-runtime/hexagon/ring_buffer_tests.cc: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-25 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r955489439 ## tests/cpp-runtime/hexagon/ring_buffer_tests.cc: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-25 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r955488224 ## tests/cpp-runtime/hexagon/ring_buffer_tests.cc: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-25 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r955269061 ## tests/cpp-runtime/hexagon/ring_buffer_tests.cc: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-25 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r955267553 ## tests/cpp-runtime/hexagon/ring_buffer_tests.cc: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-24 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r954407081 ## src/runtime/hexagon/hexagon_user_dma.cc: ## @@ -82,12 +95,13 @@ int HexagonUserDMA::Copy(void* dst, void* src, uint32_t length) { dmstart(dma_desc);

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-24 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r954406986 ## tests/cpp-runtime/hexagon/hexagon_user_dma_tests.cc: ## @@ -57,9 +57,9 @@ TEST_F(HexagonUserDMATest, wait) { HexagonUserDMA::Get().Wait(10); } Review Comment:

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-23 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r952910319 ## tests/cpp-runtime/hexagon/hexagon_user_dma_tests.cc: ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-22 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r951975770 ## src/runtime/hexagon/hexagon_user_dma.h: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-19 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r950496671 ## src/runtime/hexagon/hexagon_user_dma.cc: ## @@ -90,32 +78,80 @@ int hexagon_user_dma_1d_sync_helper(void* dst, void* src, uint32_t length) {

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-19 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r950496671 ## src/runtime/hexagon/hexagon_user_dma.cc: ## @@ -90,32 +78,80 @@ int hexagon_user_dma_1d_sync_helper(void* dst, void* src, uint32_t length) {

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-19 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r950333067 ## src/runtime/hexagon/hexagon_user_dma.h: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-18 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r949709289 ## src/runtime/hexagon/hexagon_user_dma.h: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-18 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r949709014 ## src/runtime/hexagon/hexagon_user_dma_instructions.h: ## @@ -24,8 +24,6 @@ namespace tvm { namespace runtime { namespace hexagon { -#if __HEXAGON_ARCH__ >= 68

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-18 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r949031227 ## src/runtime/hexagon/hexagon_user_dma.cc: ## @@ -90,32 +78,80 @@ int hexagon_user_dma_1d_sync_helper(void* dst, void* src, uint32_t length) {

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-18 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r949707780 ## tests/cpp-runtime/hexagon/hexagon_user_dma_tests.cc: ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-18 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r949489424 ## src/runtime/hexagon/hexagon_user_dma.h: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-18 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r949484536 ## src/runtime/hexagon/hexagon_user_dma_instructions.h: ## @@ -24,8 +24,6 @@ namespace tvm { namespace runtime { namespace hexagon { -#if __HEXAGON_ARCH__ >= 68

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-18 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r949483132 ## src/runtime/hexagon/hexagon_user_dma.h: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-18 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r949031227 ## src/runtime/hexagon/hexagon_user_dma.cc: ## @@ -90,32 +78,80 @@ int hexagon_user_dma_1d_sync_helper(void* dst, void* src, uint32_t length) {

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-18 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r949037588 ## tests/cpp-runtime/hexagon/hexagon_user_dma_tests.cc: ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-18 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r949036566 ## src/runtime/hexagon/hexagon_user_dma.cc: ## @@ -90,32 +78,80 @@ int hexagon_user_dma_1d_sync_helper(void* dst, void* src, uint32_t length) {

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-18 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r949035189 ## src/runtime/hexagon/hexagon_user_dma.cc: ## @@ -28,55 +30,41 @@ namespace tvm { namespace runtime { namespace hexagon { -int init_hexagon_user_dma() { -#if

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-18 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r949031702 ## src/runtime/hexagon/hexagon_user_dma.cc: ## @@ -90,32 +78,80 @@ int hexagon_user_dma_1d_sync_helper(void* dst, void* src, uint32_t length) {

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-18 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r949031227 ## src/runtime/hexagon/hexagon_user_dma.cc: ## @@ -90,32 +78,80 @@ int hexagon_user_dma_1d_sync_helper(void* dst, void* src, uint32_t length) {