[GitHub] [tvm] electriclilies commented on a change in pull request #8110: Unify Python and C++ TIR lower API

2021-06-08 Thread GitBox
electriclilies commented on a change in pull request #8110: URL: https://github.com/apache/tvm/pull/8110#discussion_r647713947 ## File path: src/driver/driver_api.cc ## @@ -109,6 +109,51 @@ void GetBinds(const Array& args, bool compact, } } +void GetBinds(const Array&

[GitHub] [tvm] electriclilies commented on a change in pull request #8110: Unify Python and C++ TIR lower API

2021-06-08 Thread GitBox
electriclilies commented on a change in pull request #8110: URL: https://github.com/apache/tvm/pull/8110#discussion_r647699649 ## File path: python/tvm/driver/build_module.py ## @@ -136,7 +98,7 @@ def lower( Parameters -- -input :

[GitHub] [tvm] electriclilies commented on a change in pull request #8110: Unify Python and C++ TIR lower API

2021-06-08 Thread GitBox
electriclilies commented on a change in pull request #8110: URL: https://github.com/apache/tvm/pull/8110#discussion_r647699158 ## File path: include/tvm/driver/driver_api.h ## @@ -42,17 +43,64 @@ #include namespace tvm { + +/*! + * \brief Build an IRModule given a module,

[GitHub] [tvm] electriclilies commented on a change in pull request #8110: Unify Python and C++ TIR lower API

2021-06-08 Thread GitBox
electriclilies commented on a change in pull request #8110: URL: https://github.com/apache/tvm/pull/8110#discussion_r647647392 ## File path: python/tvm/driver/build_module.py ## @@ -136,7 +98,7 @@ def lower( Parameters -- -input :

[GitHub] [tvm] electriclilies commented on a change in pull request #8110: Unify Python and C++ TIR lower API

2021-06-07 Thread GitBox
electriclilies commented on a change in pull request #8110: URL: https://github.com/apache/tvm/pull/8110#discussion_r646984639 ## File path: include/tvm/driver/driver_api.h ## @@ -42,17 +43,64 @@ #include namespace tvm { + +/*! + * \brief Build an IRModule given a module,

[GitHub] [tvm] electriclilies commented on a change in pull request #8110: Unify Python and C++ TIR lower API

2021-06-07 Thread GitBox
electriclilies commented on a change in pull request #8110: URL: https://github.com/apache/tvm/pull/8110#discussion_r646953614 ## File path: src/driver/driver_api.cc ## @@ -128,63 +128,192 @@ transform::Pass Filter(FCond fcond) { return

[GitHub] [tvm] electriclilies commented on a change in pull request #8110: Unify Python and C++ TIR lower API

2021-06-07 Thread GitBox
electriclilies commented on a change in pull request #8110: URL: https://github.com/apache/tvm/pull/8110#discussion_r646927080 ## File path: src/driver/driver_api.cc ## @@ -128,63 +128,192 @@ transform::Pass Filter(FCond fcond) { return

[GitHub] [tvm] electriclilies commented on a change in pull request #8110: Unify Python and C++ TIR lower API

2021-06-07 Thread GitBox
electriclilies commented on a change in pull request #8110: URL: https://github.com/apache/tvm/pull/8110#discussion_r646907873 ## File path: include/tvm/driver/driver_api.h ## @@ -42,17 +43,64 @@ #include namespace tvm { + +/*! + * \brief Build an IRModule given a module,

[GitHub] [tvm] electriclilies commented on a change in pull request #8110: Unify Python and C++ TIR lower API

2021-06-07 Thread GitBox
electriclilies commented on a change in pull request #8110: URL: https://github.com/apache/tvm/pull/8110#discussion_r641221024 ## File path: src/driver/driver_api.cc ## @@ -128,63 +154,219 @@ transform::Pass Filter(FCond fcond) { return